wl1251 deadcoding
cover wl1251 deadcoding
From: "Dr. David Alan Gilbert" <[email protected]>
Hi,
A couple of small deadcode patches for the wl1251;
they're pure function removal rather than anything more subtle.
P
Dr. David Alan Gilbert (2):
wl1251: Remove unused wl1251_acx_rate_policies
wl1251: Remove unused wl1251_cmd_*
drivers/net/wireless/ti/wl1251/acx.c | 35 ------------ drivers/net/wireless/ti/wl1251/acx.h | 1 - drivers/net/wireless/ti/wl1251/cmd.c | 79 ---------------------------- drivers/net/wireless/ti/wl1251/cmd.h | 3 -- 4 files changed, 118 deletions(-)
Signature · 1 line
2.49.0
PATCH 1/2 wl1251: Remove unused wl1251_acx_rate_policies
From: "Dr. David Alan Gilbert" <[email protected]>
wl1251_acx_rate_policies() was added in 2009 by
commit 0e71bb084adc ("wl1251: remove wl1251_ops")
but hasn't been used.
Remove it.
--- drivers/net/wireless/ti/wl1251/acx.c | 35 ---------------------------- drivers/net/wireless/ti/wl1251/acx.h | 1 - 2 files changed, 36 deletions(-)
drivers/net/wireless/ti/wl1251/acx.c +0 -35
@@ -832,41 +832,6 @@ int wl1251_acx_statistics(struct wl1251 *wl, struct acx_statistics *stats)return 0 ; } -int wl1251_acx_rate_policies (struct wl1251 *wl) -{ -struct acx_rate_policy *acx; -int ret =0 ; - -wl1251_debug (DEBUG_ACX ,"acx rate policies" ); - - acx =kzalloc (sizeof (*acx),GFP_KERNEL ); -if (!acx) -return -ENOMEM ; - -/* configure one default (one-size-fits-all) rate class */ - acx->rate_class_cnt =2 ; - acx->rate_class[0 ].enabled_rates =ACX_RATE_MASK_UNSPECIFIED ; - acx->rate_class[0 ].short_retry_limit =ACX_RATE_RETRY_LIMIT ; - acx->rate_class[0 ].long_retry_limit =ACX_RATE_RETRY_LIMIT ; - acx->rate_class[0 ].aflags =0 ; - -/* no-retry rate class */ - acx->rate_class[1 ].enabled_rates =ACX_RATE_MASK_UNSPECIFIED ; - acx->rate_class[1 ].short_retry_limit =0 ; - acx->rate_class[1 ].long_retry_limit =0 ; - acx->rate_class[1 ].aflags =0 ; - - ret =wl1251_cmd_configure (wl,ACX_RATE_POLICY , acx,sizeof (*acx)); -if (ret <0 ) { -wl1251_warning ("Setting of rate policies failed: %d" , ret); - goto out; - } - -out: -kfree (acx); -return ret; -} -int wl1251_acx_mem_cfg (struct wl1251 *wl) {struct wl1251_acx_config_memory *mem_conf;
drivers/net/wireless/ti/wl1251/acx.h +0 -1
@@ -1469,7 +1469,6 @@ int wl1251_acx_cts_protect(struct wl1251 *wl, enum acx_ctsprotect_type ctsprotect);int wl1251_acx_statistics (struct wl1251 *wl,struct acx_statistics *stats);int wl1251_acx_tsf_info (struct wl1251 *wl,u64 *mactime); -int wl1251_acx_rate_policies (struct wl1251 *wl);int wl1251_acx_mem_cfg (struct wl1251 *wl);int wl1251_acx_wr_tbtt_and_dtim (struct wl1251 *wl,u16 tbtt,u8 dtim); int wl1251_acx_bet_enable(struct wl1251 *wl, enum wl1251_acx_bet_mode mode,
Signature · 1 line
2.49.0
PATCH 2/2 wl1251: Remove unused wl1251_cmd_*
In reply to [email protected]From: "Dr. David Alan Gilbert" <[email protected]>
wl1251_cmd_read_memory() and wl1251_cmd_test() last use was removed in 2009 by
commit f298c282a523 ("wl1251: remove accidentally added wl1251_netlink.c")
Remove them.
--- drivers/net/wireless/ti/wl1251/cmd.c | 79 ---------------------------- drivers/net/wireless/ti/wl1251/cmd.h | 3 -- 2 files changed, 82 deletions(-)
drivers/net/wireless/ti/wl1251/cmd.c +0 -79
@@ -58,47 +58,6 @@ int wl1251_cmd_send(struct wl1251 *wl, u16 id, void *buf, size_t len)return ret; } -/** -* wl1251_cmd_test - Send test command to firmware -* -* @wl: wl struct -* @buf: buffer containing the command, with all headers, must work with dma -* @buf_len: length of the buffer -* @answer: is answer needed -*/ -int wl1251_cmd_test (struct wl1251 *wl,void *buf,size_t buf_len,u8 answer) -{ -int ret; - -wl1251_debug (DEBUG_CMD ,"cmd test" ); - - ret =wl1251_cmd_send (wl,CMD_TEST , buf, buf_len); - -if (ret <0 ) { -wl1251_warning ("TEST command failed" ); -return ret; - } - -if (answer) { -struct wl1251_command *cmd_answer; - -/* -* The test command got in, we can read the answer. -* The answer would be a wl1251_command, where the -* parameter array contains the actual answer. -*/ -wl1251_mem_read (wl, wl->cmd_box_addr, buf, buf_len); - - cmd_answer = buf; - -if (cmd_answer->header.status !=CMD_STATUS_SUCCESS ) -wl1251_error ("TEST command answer error: %d" , - cmd_answer->header.status); - } - -return 0 ; -} -/** * wl1251_cmd_interrogate - Read acx from firmware *
@@ -339,44 +298,6 @@ int wl1251_cmd_ps_mode(struct wl1251 *wl, u8 ps_mode)return ret; } -int wl1251_cmd_read_memory (struct wl1251 *wl,u32 addr,void *answer, -size_t len) -{ -struct cmd_read_write_memory *cmd; -int ret =0 ; - -wl1251_debug (DEBUG_CMD ,"cmd read memory" ); - - cmd =kzalloc (sizeof (*cmd),GFP_KERNEL ); -if (!cmd) -return -ENOMEM ; - -WARN_ON (len >MAX_READ_SIZE ); - len =min_t (size_t, len,MAX_READ_SIZE ); - - cmd->addr = addr; - cmd->size = len; - - ret =wl1251_cmd_send (wl,CMD_READ_MEMORY , cmd,sizeof (*cmd)); -if (ret <0 ) { -wl1251_error ("read memory command failed: %d" , ret); - goto out; - } - -/* the read command got in, we can now read the answer */ -wl1251_mem_read (wl, wl->cmd_box_addr, cmd,sizeof (*cmd)); - -if (cmd->header.status !=CMD_STATUS_SUCCESS ) -wl1251_error ("error in read command result: %d" , - cmd->header.status); - -memcpy (answer, cmd->value, len); - -out: -kfree (cmd); -return ret; -} -int wl1251_cmd_template_set (struct wl1251 *wl,u16 cmd_id,void *buf,size_t buf_len) {
drivers/net/wireless/ti/wl1251/cmd.h +0 -3
@@ -16,7 +16,6 @@struct acx_header ;int wl1251_cmd_send (struct wl1251 *wl,u16 type,void *buf,size_t buf_len); -int wl1251_cmd_test (struct wl1251 *wl,void *buf,size_t buf_len,u8 answer);int wl1251_cmd_interrogate (struct wl1251 *wl,u16 id,void *buf,size_t len);int wl1251_cmd_configure (struct wl1251 *wl,u16 id,void *buf,size_t len); int wl1251_cmd_vbm(struct wl1251 *wl, u8 identity,
@@ -26,8 +25,6 @@ int wl1251_cmd_data_path_tx(struct wl1251 *wl, u8 channel, bool enable);int wl1251_cmd_join (struct wl1251 *wl,u8 bss_type,u8 channel,u16 beacon_interval,u8 dtim_interval);int wl1251_cmd_ps_mode (struct wl1251 *wl,u8 ps_mode); -int wl1251_cmd_read_memory (struct wl1251 *wl,u32 addr,void *answer, -size_t len);int wl1251_cmd_template_set (struct wl1251 *wl,u16 cmd_id,void *buf,size_t buf_len); int wl1251_cmd_scan(struct wl1251 *wl, u8 *ssid, size_t ssid_len,
Signature · 1 line
2.49.0