x86/defconfigs: Explicitly unset CONFIG_64BIT in i386_defconfig
PATCH 1/1 x86/defconfigs: Explicitly unset CONFIG_64BIT in i386_defconfig
From: Daniel Díaz <[email protected]>
A recent refresh of the defconfigs got rid of the following (unset) config:
# CONFIG_64BIT is not set
Innocuous as it seems, when the config file is saved again the behavior is changed so that CONFIG_64BIT=y.
Currently,
$ make i386_defconfig $ grep CONFIG_64BIT .config CONFIG_64BIT=y
whereas previously (and with this patch):
$ make i386_defconfig $ grep CONFIG_64BIT .config # CONFIG_64BIT is not set
--- arch/x86/configs/i386_defconfig | 1 + 1 file changed, 1 insertion(+)
arch/x86/configs/i386_defconfig +1 -0
@@ -28,6 +28,7 @@ CONFIG_BLK_DEV_INITRD=y CONFIG_KALLSYMS_ALL=y CONFIG_PROFILING=y CONFIG_KEXEC=y +# CONFIG_64BIT is not set CONFIG_SMP=y CONFIG_HYPERVISOR_GUEST=y CONFIG_PARAVIRT=y
Signature · 1 line
2.47.2
Borislav Petkov
maintainerQuoted 16 lines · Andy Shevchenko
From: Daniel Díaz <[email protected]>
A recent refresh of the defconfigs got rid of the following (unset) config:
#
CONFIG_64BITis not setInnocuous as it seems, when the config file is saved again the behavior is changed so that
CONFIG_64BIT=y.Currently,
$ make i386_defconfig $ grep CONFIG_64BIT .config CONFIG_64BIT=y
Quoted 8 lines
whereas previously (and with this patch):
$ make i386_defconfig $ grep CONFIG_64BIT .config # CONFIG_64BIT is not setFixes 0e11f689ec03 ("x86/kconfig/32: Refresh defconfig")Signed-off-by Andy Shevchenko <[email protected]>
No SOB by Daniel?
Signature · 4 lines
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquetteQuoted 19 lines · Borislav Petkov
Quoted 18 lines · Andy Shevchenko
From: Daniel Díaz <[email protected]>
A recent refresh of the defconfigs got rid of the following (unset) config:
#
CONFIG_64BITis not setInnocuous as it seems, when the config file is saved again the behavior is changed so that
CONFIG_64BIT=y.Currently,
$ make i386_defconfig $ grep CONFIG_64BIT .config CONFIG_64BIT=ywhereas previously (and with this patch):
Quoted 8 lines
Quoted 6 lines
$ make i386_defconfig $ grep CONFIG_64BIT .config # CONFIG_64BIT is not setFixes 0e11f689ec03 ("x86/kconfig/32: Refresh defconfig")Signed-off-by Andy Shevchenko <[email protected]>No SOB by Daniel?
Ah, this is just a cherry-pick (with fixing conflicts, updated Fixes and removed the last paragraph) of 5y.o. 76366050eb1b ("x86/defconfigs:
Explicitly unset CONFIG_64BIT in i386_defconfig"), it should be standalone patch. I borrowed the commit message. So, whatever you prefer: I can send it again as the original one, one of x86 maintainers can do themselves the cherry-picking / conflict resolution, or I can resend it as mine.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Borislav Petkov
maintainerQuoted 3 lines · Andy Shevchenko
Ah, this is just a cherry-pick (with fixing conflicts, updated Fixes and removed the last paragraph) of 5y.o.
76366050eb1b("x86/defconfigs:
Explicitly unsetCONFIG_64BITini386_defconfig"),
What?
A 5yo patch cherrypicked from somewhere has as a Fixes tag a patch from 10 days ago?!?!
Quoted 4 lines
it should be standalone patch. I borrowed the commit message. So, whatever you prefer: I can send it again as the original one, one of x86 maintainers can do themselves the cherry-picking / conflict resolution, or I can resend it as mine.
You should do a proper patch as it is done and not do a mish-mash of old and new things, clarify with Daniel who's going to be the author and you should write a commit message which explains the situation properly, not borrow one.
Thx.
Signature · 4 lines
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquetteQuoted 9 lines · Borislav Petkov
Quoted 3 lines · Andy Shevchenko
Ah, this is just a cherry-pick (with fixing conflicts, updated Fixes and removed the last paragraph) of 5y.o.
76366050eb1b("x86/defconfigs:
Explicitly unsetCONFIG_64BITini386_defconfig"),What?
A 5yo patch cherrypicked from somewhere has as a Fixes tag a patch from 10 days ago?!?!
The base for my patch was the 5.y.o. patch.
Quoted 8 lines
Quoted 4 lines
it should be standalone patch. I borrowed the commit message. So, whatever you prefer: I can send it again as the original one, one of x86 maintainers can do themselves the cherry-picking / conflict resolution, or I can resend it as mine.
You should do a proper patch as it is done and not do a mish-mash of old and new things, clarify with Daniel who's going to be the author and you should write a commit message which explains the situation properly, not borrow one.
It is describes situation properly. Just a test was different in this case. Okay, let me try again in v2.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 7 lines · Andy Shevchenko
Quoted 6 lines · Borislav Petkov
Quoted 5 lines · Andy Shevchenko
Ah, this is just a cherry-pick (with fixing conflicts, updated Fixes and removed the last paragraph) of 5y.o.
76366050eb1b("x86/defconfigs:
Explicitly unsetCONFIG_64BITini386_defconfig"),Quoted 1 line
What?
FWIW< the bug is repetitive (third time already?) that the i386_defconfig was refreshed with ARCH=x86_64 or so and in the result the CONFIG_64BIT is set to 'y' for 32-bit code.
Quoted 16 lines
Quoted 2 lines
A 5yo patch cherrypicked from somewhere has as a Fixes tag a patch from 10 days ago?!?!
The base for my patch was the 5.y.o. patch.
Quoted 8 lines
Quoted 4 lines
it should be standalone patch. I borrowed the commit message. So, whatever you prefer: I can send it again as the original one, one of x86 maintainers can do themselves the cherry-picking / conflict resolution, or I can resend it as mine.
You should do a proper patch as it is done and not do a mish-mash of old and new things, clarify with Daniel who's going to be the author and you should write a commit message which explains the situation properly, not borrow one.
It is describes situation properly. Just a test was different in this case. Okay, let me try again in v2.
Signature · 2 lines
With Best Regards, Andy Shevchenko