Skip to contentSkip to conversation

x86/defconfigs: Explicitly unset CONFIG_64BIT in i386_defconfig

PATCH Superseded Andy Shevchenko 2 participants 6 messages Jun 23, 2025 x86

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/defconfigs: Explicitly unset CONFIG_64BIT in i386_defconfig

From: Daniel Díaz <[email protected]>

A recent refresh of the defconfigs got rid of the following (unset) config:

# CONFIG_64BIT is not set

Innocuous as it seems, when the config file is saved again the behavior is changed so that CONFIG_64BIT=y.

Currently,

  $ make i386_defconfig
  $ grep CONFIG_64BIT .config
  CONFIG_64BIT=y

whereas previously (and with this patch):

  $ make i386_defconfig
  $ grep CONFIG_64BIT .config
  # CONFIG_64BIT is not set
Fixes 0e11f689ec03 ("x86/kconfig/32: Refresh defconfig")
---
 arch/x86/configs/i386_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/x86/configs/i386_defconfig +1 -0
index bd182325ebb4..9fc5c2eb58af 100644
@@ -28,6 +28,7 @@ CONFIG_BLK_DEV_INITRD=y
 CONFIG_KALLSYMS_ALL=y
 CONFIG_PROFILING=y
 CONFIG_KEXEC=y
+# CONFIG_64BIT is not set
 CONFIG_SMP=y
 CONFIG_HYPERVISOR_GUEST=y
 CONFIG_PARAVIRT=y
Signature · 1 line
2.47.2
maintainer
#1 lore raw
Quoted 16 lines · Andy Shevchenko

From: Daniel Díaz <[email protected]>

A recent refresh of the defconfigs got rid of the following (unset) config:

# CONFIG_64BIT is not set

Innocuous as it seems, when the config file is saved again the behavior is changed so that CONFIG_64BIT=y.

Currently,

  $ make i386_defconfig
  $ grep CONFIG_64BIT .config
  CONFIG_64BIT=y
Quoted 8 lines

whereas previously (and with this patch):

  $ make i386_defconfig
  $ grep CONFIG_64BIT .config
  # CONFIG_64BIT is not set
Fixes 0e11f689ec03 ("x86/kconfig/32: Refresh defconfig")

No SOB by Daniel?

Signature · 4 lines
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
#2 lore raw
Quoted 19 lines · Borislav Petkov
Quoted 18 lines · Andy Shevchenko

From: Daniel Díaz <[email protected]>

A recent refresh of the defconfigs got rid of the following (unset) config:

# CONFIG_64BIT is not set

Innocuous as it seems, when the config file is saved again the behavior is changed so that CONFIG_64BIT=y.

Currently,

  $ make i386_defconfig
  $ grep CONFIG_64BIT .config
  CONFIG_64BIT=y

whereas previously (and with this patch):

Quoted 8 lines
Quoted 6 lines
  $ make i386_defconfig
  $ grep CONFIG_64BIT .config
  # CONFIG_64BIT is not set
Fixes 0e11f689ec03 ("x86/kconfig/32: Refresh defconfig")

No SOB by Daniel?

Ah, this is just a cherry-pick (with fixing conflicts, updated Fixes and removed the last paragraph) of 5y.o. 76366050eb1b ("x86/defconfigs:
Explicitly unset CONFIG_64BIT in i386_defconfig"), it should be standalone patch. I borrowed the commit message. So, whatever you prefer: I can send it again as the original one, one of x86 maintainers can do themselves the cherry-picking / conflict resolution, or I can resend it as mine.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#3 lore raw
Quoted 3 lines · Andy Shevchenko

Ah, this is just a cherry-pick (with fixing conflicts, updated Fixes and removed the last paragraph) of 5y.o. 76366050eb1b ("x86/defconfigs:
Explicitly unset CONFIG_64BIT in i386_defconfig"),

What?

A 5yo patch cherrypicked from somewhere has as a Fixes tag a patch from 10 days ago?!?!

Quoted 4 lines

it should be standalone patch. I borrowed the commit message. So, whatever you prefer: I can send it again as the original one, one of x86 maintainers can do themselves the cherry-picking / conflict resolution, or I can resend it as mine.

You should do a proper patch as it is done and not do a mish-mash of old and new things, clarify with Daniel who's going to be the author and you should write a commit message which explains the situation properly, not borrow one.

Thx.

Signature · 4 lines
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
#4 lore raw
Quoted 9 lines · Borislav Petkov
Quoted 3 lines · Andy Shevchenko

Ah, this is just a cherry-pick (with fixing conflicts, updated Fixes and removed the last paragraph) of 5y.o. 76366050eb1b ("x86/defconfigs:
Explicitly unset CONFIG_64BIT in i386_defconfig"),

What?

A 5yo patch cherrypicked from somewhere has as a Fixes tag a patch from 10 days ago?!?!

The base for my patch was the 5.y.o. patch.

Quoted 8 lines
Quoted 4 lines

it should be standalone patch. I borrowed the commit message. So, whatever you prefer: I can send it again as the original one, one of x86 maintainers can do themselves the cherry-picking / conflict resolution, or I can resend it as mine.

You should do a proper patch as it is done and not do a mish-mash of old and new things, clarify with Daniel who's going to be the author and you should write a commit message which explains the situation properly, not borrow one.

It is describes situation properly. Just a test was different in this case. Okay, let me try again in v2.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#5 lore raw
Quoted 7 lines · Andy Shevchenko
Quoted 6 lines · Borislav Petkov
Quoted 5 lines · Andy Shevchenko

Ah, this is just a cherry-pick (with fixing conflicts, updated Fixes and removed the last paragraph) of 5y.o. 76366050eb1b ("x86/defconfigs:
Explicitly unset CONFIG_64BIT in i386_defconfig"),

Quoted 1 line

What?

FWIW< the bug is repetitive (third time already?) that the i386_defconfig was refreshed with ARCH=x86_64 or so and in the result the CONFIG_64BIT is set to 'y' for 32-bit code.

Quoted 16 lines
Quoted 2 lines

A 5yo patch cherrypicked from somewhere has as a Fixes tag a patch from 10 days ago?!?!

The base for my patch was the 5.y.o. patch.

Quoted 8 lines
Quoted 4 lines

it should be standalone patch. I borrowed the commit message. So, whatever you prefer: I can send it again as the original one, one of x86 maintainers can do themselves the cherry-picking / conflict resolution, or I can resend it as mine.

You should do a proper patch as it is done and not do a mish-mash of old and new things, clarify with Daniel who's going to be the author and you should write a commit message which explains the situation properly, not borrow one.

It is describes situation properly. Just a test was different in this case. Okay, let me try again in v2.

Signature · 2 lines
With Best Regards,
Andy Shevchenko