fanotify: selftests for fanotify permission events
PATCH 1/1 fanotify: selftests for fanotify permission events
This adds selftests which exercise generating / responding to permission events. They requre root privileges since FAN_CLASS_PRE_CONTENT requires it.
--- tools/testing/selftests/Makefile | 1 + .../selftests/filesystems/fanotify/.gitignore | 2 + .../selftests/filesystems/fanotify/Makefile | 8 + .../filesystems/fanotify/fanotify_perm_test.c | 386 ++++++++++++++++++ 4 files changed, 397 insertions(+) create mode 100644 tools/testing/selftests/filesystems/fanotify/.gitignore create mode 100644 tools/testing/selftests/filesystems/fanotify/Makefile create mode 100644 tools/testing/selftests/filesystems/fanotify/fanotify_perm_test.c
tools/testing/selftests/Makefile +1 -0
@@ -32,6 +32,7 @@ TARGETS += fchmodat2 TARGETS += filesystems TARGETS += filesystems/binderfs TARGETS += filesystems/epoll +TARGETS += filesystems/fanotify TARGETS += filesystems/fat TARGETS += filesystems/overlayfs TARGETS += filesystems/statmount
tools/testing/selftests/filesystems/fanotify/.gitignore new file +2 -0
@@ -0,0 +1,2 @@ +# SPDX-License-Identifier: GPL-2.0-only +fanotify_perm_test
tools/testing/selftests/filesystems/fanotify/Makefile new file +8 -0
@@ -0,0 +1,8 @@ +# SPDX-License-Identifier: GPL-2.0-or-later + +CFLAGS += -Wall -O2 -g $(KHDR_INCLUDES) $(TOOLS_INCLUDES) +LDLIBS += -lcap + +TEST_GEN_PROGS := fanotify_perm_test + +include ../../lib.mk
tools/testing/selftests/filesystems/fanotify/fanotify_perm_test.c new file +386 -0
386 lines not on this page · raw message
Signature · 1 line
2.47.1
Quoted 3 lines · Ibrahim Jirdeh
This adds selftests which exercise generating / responding to permission events. They requre root privileges since
^^^^ require
Quoted 13 lines
FAN_CLASS_PRE_CONTENTrequires it.Signed-off-by Ibrahim Jirdeh <[email protected]>--- tools/testing/selftests/Makefile | 1 + .../selftests/filesystems/fanotify/.gitignore | 2 + .../selftests/filesystems/fanotify/Makefile | 8 + .../filesystems/fanotify/fanotify_perm_test.c | 386 ++++++++++++++++++ 4 files changed, 397 insertions(+) create mode 100644 tools/testing/selftests/filesystems/fanotify/.gitignore create mode 100644 tools/testing/selftests/filesystems/fanotify/Makefile create mode 100644 tools/testing/selftests/filesystems/fanotify/fanotify_perm_test.c
Hi Ibrahim,
As a general comment, I do not mind having diverse testing methods, but just wanted to make sure that you know that we usually write fanotify tests to new features in LTP.
LTP vs. selftests have their pros and cons, but both bring value and add test coverage.
selftests would not have been my first choice for this particular test, because it is so similar to tests already existing in LTP, e.g.:
https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/syscalls/fanotify/fanotify24.c
but I suppose that testing the full functionality of event listener fd handover might be easier to implement with the selftest infrastructure. Anyway, I will not require you to use one test suite or the other if you have a preference.
One of the perks of using selftests is that you can post the test patch in the same series of the feature patches, but you haven't made use of this perk, so you may want to do that for v2.
Other than that, the test looks good, so you may add:
Thanks,
Amir.
Quoted 429 lines
tools/testing/selftests/Makefile +1
-0@@ -32,6 +32,7 @@ TARGETS += fchmodat2 TARGETS += filesystems TARGETS += filesystems/binderfs TARGETS += filesystems/epoll +TARGETS += filesystems/fanotify TARGETS += filesystems/fat TARGETS += filesystems/overlayfs TARGETS += filesystems/statmounttools/testing/selftests/filesystems/fanotify/.gitignore new file +2
-0@@ -0,0 +1,2 @@ +# SPDX-License-Identifier: GPL-2.0-only +fanotify_perm_testtools/testing/selftests/filesystems/fanotify/Makefile new file +8
-0@@ -0,0 +1,8 @@ +# SPDX-License-Identifier: GPL-2.0-or-later + +CFLAGS += -Wall -O2 -g $(KHDR_INCLUDES) $(TOOLS_INCLUDES) +LDLIBS += -lcap + +TEST_GEN_PROGS := fanotify_perm_test + +include ../../lib.mktools/testing/selftests/filesystems/fanotify/fanotify_perm_test.c new file +386
-1@@ -0,0 +1,386 @@ +// SPDX-License-Identifier: GPL-2.0-or-later + +#define _GNU_SOURCE +#include <fcntl.h> +#include <stdio.h> +#include <string.h> +#include <sys/stat.h> +#include <sys/types.h> +#include <sys/wait.h> +#include <unistd.h> +#include <stdlib.h> +#include <errno.h> +#include <sys/syscall.h> +#include <limits.h> + +#include "../../kselftest_harness.h" + +// Needed for linux/fanotify.h +#ifndef __kernel_fsid_t +typedef struct { +int val[2 ]; +}__kernel_fsid_t ; +#endif +#include <sys/fanotify.h> + +static const char test_dir_templ[] ="/tmp/fanotify_perm_test.XXXXXX" ; + +FIXTURE (fanotify) +{ +char test_dir[sizeof (test_dir_templ)]; +char test_dir2[sizeof (test_dir_templ)]; +int fan_fd; +int fan_fd2; +char test_file_path[PATH_MAX ]; +char test_file_path2[PATH_MAX ]; +char test_exec_path[PATH_MAX ]; +}; + +FIXTURE_SETUP (fanotify) +{ +int ret; + +/* Setup test directories and files */ +strcpy (self->test_dir, test_dir_templ); +ASSERT_NE (mkdtemp (self->test_dir),NULL ); +strcpy (self->test_dir2, test_dir_templ); +ASSERT_NE (mkdtemp (self->test_dir2),NULL ); + +snprintf (self->test_file_path,PATH_MAX ,"%s/test_file" , + self->test_dir); +snprintf (self->test_file_path2,PATH_MAX ,"%s/test_file2" , + self->test_dir2); +snprintf (self->test_exec_path,PATH_MAX ,"%s/test_exec" , + self->test_dir); + + ret =open (self->test_file_path,O_CREAT |O_RDWR ,0644 ); +ASSERT_GE (ret,0 ); +ASSERT_EQ (write (ret,"test data" ,9 ),9 ); +close (ret); + + ret =open (self->test_file_path2,O_CREAT |O_RDWR ,0644 ); +ASSERT_GE (ret,0 ); +ASSERT_EQ (write (ret,"test data2" ,9 ),9 ); +close (ret); + + ret =open (self->test_exec_path,O_CREAT |O_RDWR ,0755 ); +ASSERT_GE (ret,0 ); +ASSERT_EQ (write (ret,"#!/bin/bash\necho test\n" ,22 ),22 ); +close (ret); + + self->fan_fd =fanotify_init ( +FAN_CLASS_PRE_CONTENT |FAN_NONBLOCK |FAN_CLOEXEC ,O_RDONLY ); +ASSERT_GE (self->fan_fd,0 ); + + self->fan_fd2 =fanotify_init (FAN_CLASS_PRE_CONTENT |FAN_NONBLOCK | +FAN_CLOEXEC |FAN_ENABLE_EVENT_ID , +O_RDONLY ); +ASSERT_GE (self->fan_fd2,0 ); + +/* Mark the directories for permission events */ + ret =fanotify_mark (self->fan_fd,FAN_MARK_ADD , +FAN_OPEN_PERM |FAN_OPEN_EXEC_PERM | +FAN_EVENT_ON_CHILD , +AT_FDCWD , self->test_dir); +ASSERT_EQ (ret,0 ); + + ret =fanotify_mark (self->fan_fd2,FAN_MARK_ADD , +FAN_OPEN_PERM |FAN_OPEN_EXEC_PERM | +FAN_EVENT_ON_CHILD , +AT_FDCWD , self->test_dir2); +ASSERT_EQ (ret,0 ); +} + +FIXTURE_TEARDOWN (fanotify) +{ +/* Clean up test directory and files */ +if (self->fan_fd >0 ) +close (self->fan_fd); +if (self->fan_fd2 >0 ) +close (self->fan_fd2); + +EXPECT_EQ (unlink (self->test_file_path),0 ); +EXPECT_EQ (unlink (self->test_file_path2),0 ); +EXPECT_EQ (unlink (self->test_exec_path),0 ); +EXPECT_EQ (rmdir (self->test_dir),0 ); +EXPECT_EQ (rmdir (self->test_dir2),0 ); +} + +static struct fanotify_event_metadata *get_event (int fd) +{ +struct fanotify_event_metadata *metadata; +ssize_t len; +char buf[256 ]; + + len =read (fd, buf,sizeof (buf)); +if (len <=0 ) +return NULL ; + + metadata = (void *)buf; +if (!FAN_EVENT_OK (metadata, len)) +return NULL ; + +return metadata; +} + +static int respond_to_event (int fd,struct fanotify_event_metadata *metadata, +uint32_t response,bool useEventId) +{ +struct fanotify_response resp; + +if (useEventId) { + resp.event_id = metadata->event_id; + }else { + resp.fd = metadata->fd; + } + resp.response = response; + +return write (fd, &resp,sizeof (resp)); +} + +static void verify_event (struct __test_metadata *const _metadata, +struct fanotify_event_metadata *event, +uint64_t expect_mask,int expect_pid) +{ +ASSERT_NE (event,NULL ); +ASSERT_EQ (event->mask, expect_mask); + +if (expect_pid >0 ) +ASSERT_EQ (event->pid, expect_pid); +} + +TEST_F(fanotify, open_perm_allow) +{ +struct fanotify_event_metadata *event; +int fd, ret; +pid_t child; + + child =fork (); +ASSERT_GE (child,0 ); + +if (child ==0 ) { +/* Try to open the file - this should trigger FAN_OPEN_PERM */ + fd =open (self->test_file_path,O_RDONLY ); +if (fd <0 ) +exit (EXIT_FAILURE ); +close (fd); +exit (EXIT_SUCCESS ); + } + +usleep (100000 ); + event =get_event (self->fan_fd); +verify_event (_metadata, event,FAN_OPEN_PERM , child); + +/* Allow the open operation */ +close (event->fd); + ret =respond_to_event (self->fan_fd, event,FAN_ALLOW , + false/* useEventId */ ); +ASSERT_EQ (ret,sizeof (struct fanotify_response )); + +int status; + +ASSERT_EQ (waitpid (child, &status,0 ), child); +ASSERT_EQ (WEXITSTATUS (status),EXIT_SUCCESS ); +} + +TEST_F(fanotify, open_perm_deny) +{ +struct fanotify_event_metadata *event; +int ret; +pid_t child; + + child =fork (); +ASSERT_GE (child,0 ); + +if (child ==0 ) { +/* Try to open the file - this should trigger FAN_OPEN_PERM */ +int fd =open (self->test_file_path,O_RDONLY ); + +/* If open succeeded, this is an error as we expect it to be denied */ +if (fd >=0 ) { +close (fd); +exit (EXIT_FAILURE ); + } + +/* Verify the expected error */ +if (errno ==EPERM ) +exit (EXIT_SUCCESS ); + +exit (EXIT_FAILURE ); + } + +usleep (100000 ); + event =get_event (self->fan_fd); +verify_event (_metadata, event,FAN_OPEN_PERM , child); + +/* Deny the open operation */ +close (event->fd); + ret =respond_to_event (self->fan_fd, event,FAN_DENY , + false/* useEventId */ ); +ASSERT_EQ (ret,sizeof (struct fanotify_response )); + +int status; + +ASSERT_EQ (waitpid (child, &status,0 ), child); +ASSERT_EQ (WEXITSTATUS (status),EXIT_SUCCESS ); +} + +TEST_F(fanotify, exec_perm_allow) +{ +struct fanotify_event_metadata *event; +int ret; +pid_t child; + + child =fork (); +ASSERT_GE (child,0 ); + +if (child ==0 ) { +/* Try to execute the file - this should trigger FAN_OPEN_EXEC_PERM */ +execl (self->test_exec_path,"test_exec" ,NULL ); + +/* If we get here, execl failed */ +exit (EXIT_FAILURE ); + } + +usleep (100000 ); + event =get_event (self->fan_fd); +verify_event (_metadata, event,FAN_OPEN_EXEC_PERM , child); + +/* Allow the exec operation + ignore subsequent events */ +ASSERT_GE (fanotify_mark (self->fan_fd, +FAN_MARK_ADD |FAN_MARK_IGNORED_MASK | +FAN_MARK_IGNORED_SURV_MODIFY , +FAN_OPEN_PERM |FAN_OPEN_EXEC_PERM , event->fd, +NULL ), +0 ); +close (event->fd); + ret =respond_to_event (self->fan_fd, event,FAN_ALLOW , + false/* useEventId */ ); +ASSERT_EQ (ret,sizeof (struct fanotify_response )); + +int status; + +ASSERT_EQ (waitpid (child, &status,0 ), child); +ASSERT_EQ (WIFEXITED (status),1 ); +} + +TEST_F(fanotify, exec_perm_deny) +{ +struct fanotify_event_metadata *event; +int ret; +pid_t child; + + child =fork (); +ASSERT_GE (child,0 ); + +if (child ==0 ) { +/* Try to execute the file - this should trigger FAN_OPEN_EXEC_PERM */ +execl (self->test_exec_path,"test_exec" ,NULL ); + +/* If execl failed with EPERM, that's what we expect */ +if (errno ==EPERM ) +exit (EXIT_SUCCESS ); + +exit (EXIT_FAILURE ); + } + +usleep (100000 ); + event =get_event (self->fan_fd); +verify_event (_metadata, event,FAN_OPEN_EXEC_PERM , child); + +/* Deny the exec operation */ +close (event->fd); + ret =respond_to_event (self->fan_fd, event,FAN_DENY , + false/* useEventId */ ); +ASSERT_EQ (ret,sizeof (struct fanotify_response )); + +int status; + +ASSERT_EQ (waitpid (child, &status,0 ), child); +ASSERT_EQ (WEXITSTATUS (status),EXIT_SUCCESS ); +} + +TEST_F(fanotify, default_response) +{ +struct fanotify_event_metadata *event; +int ret; +pid_t child; +struct fanotify_response resp; + +/* Set default response to deny */ + resp.fd =FAN_NOFD ; + resp.response =FAN_DENY |FAN_DEFAULT ; + ret =write (self->fan_fd, &resp,sizeof (resp)); +ASSERT_EQ (ret,sizeof (resp)); + + child =fork (); +ASSERT_GE (child,0 ); + +if (child ==0 ) { +close (self->fan_fd); +/* Try to open the file - this should trigger FAN_OPEN_PERM */ +int fd =open (self->test_file_path,O_RDONLY ); + +/* If open succeeded, this is an error as we expect it to be denied */ +if (fd >=0 ) { +close (fd); +exit (EXIT_FAILURE ); + } + +/* Verify the expected error */ +if (errno ==EPERM ) +exit (EXIT_SUCCESS ); + +exit (EXIT_FAILURE ); + } + +usleep (100000 ); + event =get_event (self->fan_fd); +verify_event (_metadata, event,FAN_OPEN_PERM , child); + +/* Close fanotify group to return default response (DENY) */ +close (self->fan_fd); + self->fan_fd =-1 ; + +int status; + +ASSERT_EQ (waitpid (child, &status,0 ), child); +ASSERT_EQ (WEXITSTATUS (status),EXIT_SUCCESS ); +} + +TEST_F(fanotify, respond_via_event_id) +{ +struct fanotify_event_metadata *event; +int fd, ret; +pid_t child; + + child =fork (); +ASSERT_GE (child,0 ); + +if (child ==0 ) { +/* Try to open the file - this should trigger FAN_OPEN_PERM */ + fd =open (self->test_file_path2,O_RDONLY ); +if (fd <0 ) +exit (EXIT_FAILURE ); +close (fd); +exit (EXIT_SUCCESS ); + } + +usleep (100000 ); + event =get_event (self->fan_fd2); +verify_event (_metadata, event,FAN_OPEN_PERM , child); +ASSERT_EQ (event->event_id,1 ); + +/* Allow the open operation */ +close (event->fd); + ret =respond_to_event (self->fan_fd2, event,FAN_ALLOW , + true/* useEventId */ ); +ASSERT_EQ (ret,sizeof (struct fanotify_response )); + +int status; + +ASSERT_EQ (waitpid (child, &status,0 ), child); +ASSERT_EQ (WEXITSTATUS (status),EXIT_SUCCESS ); +} + +TEST_HARNESS_MAIN --2.47.1
Jan Kara
reviewerHi!
Quoted 25 lines · Amir Goldstein
Quoted 3 lines · Ibrahim Jirdeh
This adds selftests which exercise generating / responding to permission events. They requre root privileges since
^^^^ requireQuoted 13 lines
FAN_CLASS_PRE_CONTENTrequires it.Signed-off-by Ibrahim Jirdeh <[email protected]>--- tools/testing/selftests/Makefile | 1 + .../selftests/filesystems/fanotify/.gitignore | 2 + .../selftests/filesystems/fanotify/Makefile | 8 + .../filesystems/fanotify/fanotify_perm_test.c | 386 ++++++++++++++++++ 4 files changed, 397 insertions(+) create mode 100644 tools/testing/selftests/filesystems/fanotify/.gitignore create mode 100644 tools/testing/selftests/filesystems/fanotify/Makefile create mode 100644 tools/testing/selftests/filesystems/fanotify/fanotify_perm_test.cHi Ibrahim,
As a general comment, I do not mind having diverse testing methods, but just wanted to make sure that you know that we usually write fanotify tests to new features in LTP.
Quoted 5 lines
LTP vs. selftests have their pros and cons, but both bring value and add test coverage.
selftests would not have been my first choice for this particular test, because it is so similar to tests already existing in LTP, e.g.:
https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/syscalls/fanotify/fanotify24.c
Yeah, frankly I'd prefer to keep tests in one place unless there's a good reason not to. As you write in this case we already have very similar tests in LTP so adding a coverage for the new functionality there seems like a no-brainer...
Quoted 4 lines
but I suppose that testing the full functionality of event listener fd handover might be easier to implement with the selftest infrastructure. Anyway, I will not require you to use one test suite or the other if you have a preference.
If there's some functionality that's hard to test from LTP, we can consider implementing that in kselftests but I'd like to hear those reasons first...
Honza
Quoted 429 lines
Quoted 429 lines
tools/testing/selftests/Makefile +1
-0@@ -32,6 +32,7 @@ TARGETS += fchmodat2 TARGETS += filesystems TARGETS += filesystems/binderfs TARGETS += filesystems/epoll +TARGETS += filesystems/fanotify TARGETS += filesystems/fat TARGETS += filesystems/overlayfs TARGETS += filesystems/statmounttools/testing/selftests/filesystems/fanotify/.gitignore new file +2
-0@@ -0,0 +1,2 @@ +# SPDX-License-Identifier: GPL-2.0-only +fanotify_perm_testtools/testing/selftests/filesystems/fanotify/Makefile new file +8
-0@@ -0,0 +1,8 @@ +# SPDX-License-Identifier: GPL-2.0-or-later + +CFLAGS += -Wall -O2 -g $(KHDR_INCLUDES) $(TOOLS_INCLUDES) +LDLIBS += -lcap + +TEST_GEN_PROGS := fanotify_perm_test + +include ../../lib.mktools/testing/selftests/filesystems/fanotify/fanotify_perm_test.c new file +386
-1@@ -0,0 +1,386 @@ +// SPDX-License-Identifier: GPL-2.0-or-later + +#define _GNU_SOURCE +#include <fcntl.h> +#include <stdio.h> +#include <string.h> +#include <sys/stat.h> +#include <sys/types.h> +#include <sys/wait.h> +#include <unistd.h> +#include <stdlib.h> +#include <errno.h> +#include <sys/syscall.h> +#include <limits.h> + +#include "../../kselftest_harness.h" + +// Needed for linux/fanotify.h +#ifndef __kernel_fsid_t +typedef struct { +int val[2 ]; +}__kernel_fsid_t ; +#endif +#include <sys/fanotify.h> + +static const char test_dir_templ[] ="/tmp/fanotify_perm_test.XXXXXX" ; + +FIXTURE (fanotify) +{ +char test_dir[sizeof (test_dir_templ)]; +char test_dir2[sizeof (test_dir_templ)]; +int fan_fd; +int fan_fd2; +char test_file_path[PATH_MAX ]; +char test_file_path2[PATH_MAX ]; +char test_exec_path[PATH_MAX ]; +}; + +FIXTURE_SETUP (fanotify) +{ +int ret; + +/* Setup test directories and files */ +strcpy (self->test_dir, test_dir_templ); +ASSERT_NE (mkdtemp (self->test_dir),NULL ); +strcpy (self->test_dir2, test_dir_templ); +ASSERT_NE (mkdtemp (self->test_dir2),NULL ); + +snprintf (self->test_file_path,PATH_MAX ,"%s/test_file" , + self->test_dir); +snprintf (self->test_file_path2,PATH_MAX ,"%s/test_file2" , + self->test_dir2); +snprintf (self->test_exec_path,PATH_MAX ,"%s/test_exec" , + self->test_dir); + + ret =open (self->test_file_path,O_CREAT |O_RDWR ,0644 ); +ASSERT_GE (ret,0 ); +ASSERT_EQ (write (ret,"test data" ,9 ),9 ); +close (ret); + + ret =open (self->test_file_path2,O_CREAT |O_RDWR ,0644 ); +ASSERT_GE (ret,0 ); +ASSERT_EQ (write (ret,"test data2" ,9 ),9 ); +close (ret); + + ret =open (self->test_exec_path,O_CREAT |O_RDWR ,0755 ); +ASSERT_GE (ret,0 ); +ASSERT_EQ (write (ret,"#!/bin/bash\necho test\n" ,22 ),22 ); +close (ret); + + self->fan_fd =fanotify_init ( +FAN_CLASS_PRE_CONTENT |FAN_NONBLOCK |FAN_CLOEXEC ,O_RDONLY ); +ASSERT_GE (self->fan_fd,0 ); + + self->fan_fd2 =fanotify_init (FAN_CLASS_PRE_CONTENT |FAN_NONBLOCK | +FAN_CLOEXEC |FAN_ENABLE_EVENT_ID , +O_RDONLY ); +ASSERT_GE (self->fan_fd2,0 ); + +/* Mark the directories for permission events */ + ret =fanotify_mark (self->fan_fd,FAN_MARK_ADD , +FAN_OPEN_PERM |FAN_OPEN_EXEC_PERM | +FAN_EVENT_ON_CHILD , +AT_FDCWD , self->test_dir); +ASSERT_EQ (ret,0 ); + + ret =fanotify_mark (self->fan_fd2,FAN_MARK_ADD , +FAN_OPEN_PERM |FAN_OPEN_EXEC_PERM | +FAN_EVENT_ON_CHILD , +AT_FDCWD , self->test_dir2); +ASSERT_EQ (ret,0 ); +} + +FIXTURE_TEARDOWN (fanotify) +{ +/* Clean up test directory and files */ +if (self->fan_fd >0 ) +close (self->fan_fd); +if (self->fan_fd2 >0 ) +close (self->fan_fd2); + +EXPECT_EQ (unlink (self->test_file_path),0 ); +EXPECT_EQ (unlink (self->test_file_path2),0 ); +EXPECT_EQ (unlink (self->test_exec_path),0 ); +EXPECT_EQ (rmdir (self->test_dir),0 ); +EXPECT_EQ (rmdir (self->test_dir2),0 ); +} + +static struct fanotify_event_metadata *get_event (int fd) +{ +struct fanotify_event_metadata *metadata; +ssize_t len; +char buf[256 ]; + + len =read (fd, buf,sizeof (buf)); +if (len <=0 ) +return NULL ; + + metadata = (void *)buf; +if (!FAN_EVENT_OK (metadata, len)) +return NULL ; + +return metadata; +} + +static int respond_to_event (int fd,struct fanotify_event_metadata *metadata, +uint32_t response,bool useEventId) +{ +struct fanotify_response resp; + +if (useEventId) { + resp.event_id = metadata->event_id; + }else { + resp.fd = metadata->fd; + } + resp.response = response; + +return write (fd, &resp,sizeof (resp)); +} + +static void verify_event (struct __test_metadata *const _metadata, +struct fanotify_event_metadata *event, +uint64_t expect_mask,int expect_pid) +{ +ASSERT_NE (event,NULL ); +ASSERT_EQ (event->mask, expect_mask); + +if (expect_pid >0 ) +ASSERT_EQ (event->pid, expect_pid); +} + +TEST_F(fanotify, open_perm_allow) +{ +struct fanotify_event_metadata *event; +int fd, ret; +pid_t child; + + child =fork (); +ASSERT_GE (child,0 ); + +if (child ==0 ) { +/* Try to open the file - this should trigger FAN_OPEN_PERM */ + fd =open (self->test_file_path,O_RDONLY ); +if (fd <0 ) +exit (EXIT_FAILURE ); +close (fd); +exit (EXIT_SUCCESS ); + } + +usleep (100000 ); + event =get_event (self->fan_fd); +verify_event (_metadata, event,FAN_OPEN_PERM , child); + +/* Allow the open operation */ +close (event->fd); + ret =respond_to_event (self->fan_fd, event,FAN_ALLOW , + false/* useEventId */ ); +ASSERT_EQ (ret,sizeof (struct fanotify_response )); + +int status; + +ASSERT_EQ (waitpid (child, &status,0 ), child); +ASSERT_EQ (WEXITSTATUS (status),EXIT_SUCCESS ); +} + +TEST_F(fanotify, open_perm_deny) +{ +struct fanotify_event_metadata *event; +int ret; +pid_t child; + + child =fork (); +ASSERT_GE (child,0 ); + +if (child ==0 ) { +/* Try to open the file - this should trigger FAN_OPEN_PERM */ +int fd =open (self->test_file_path,O_RDONLY ); + +/* If open succeeded, this is an error as we expect it to be denied */ +if (fd >=0 ) { +close (fd); +exit (EXIT_FAILURE ); + } + +/* Verify the expected error */ +if (errno ==EPERM ) +exit (EXIT_SUCCESS ); + +exit (EXIT_FAILURE ); + } + +usleep (100000 ); + event =get_event (self->fan_fd); +verify_event (_metadata, event,FAN_OPEN_PERM , child); + +/* Deny the open operation */ +close (event->fd); + ret =respond_to_event (self->fan_fd, event,FAN_DENY , + false/* useEventId */ ); +ASSERT_EQ (ret,sizeof (struct fanotify_response )); + +int status; + +ASSERT_EQ (waitpid (child, &status,0 ), child); +ASSERT_EQ (WEXITSTATUS (status),EXIT_SUCCESS ); +} + +TEST_F(fanotify, exec_perm_allow) +{ +struct fanotify_event_metadata *event; +int ret; +pid_t child; + + child =fork (); +ASSERT_GE (child,0 ); + +if (child ==0 ) { +/* Try to execute the file - this should trigger FAN_OPEN_EXEC_PERM */ +execl (self->test_exec_path,"test_exec" ,NULL ); + +/* If we get here, execl failed */ +exit (EXIT_FAILURE ); + } + +usleep (100000 ); + event =get_event (self->fan_fd); +verify_event (_metadata, event,FAN_OPEN_EXEC_PERM , child); + +/* Allow the exec operation + ignore subsequent events */ +ASSERT_GE (fanotify_mark (self->fan_fd, +FAN_MARK_ADD |FAN_MARK_IGNORED_MASK | +FAN_MARK_IGNORED_SURV_MODIFY , +FAN_OPEN_PERM |FAN_OPEN_EXEC_PERM , event->fd, +NULL ), +0 ); +close (event->fd); + ret =respond_to_event (self->fan_fd, event,FAN_ALLOW , + false/* useEventId */ ); +ASSERT_EQ (ret,sizeof (struct fanotify_response )); + +int status; + +ASSERT_EQ (waitpid (child, &status,0 ), child); +ASSERT_EQ (WIFEXITED (status),1 ); +} + +TEST_F(fanotify, exec_perm_deny) +{ +struct fanotify_event_metadata *event; +int ret; +pid_t child; + + child =fork (); +ASSERT_GE (child,0 ); + +if (child ==0 ) { +/* Try to execute the file - this should trigger FAN_OPEN_EXEC_PERM */ +execl (self->test_exec_path,"test_exec" ,NULL ); + +/* If execl failed with EPERM, that's what we expect */ +if (errno ==EPERM ) +exit (EXIT_SUCCESS ); + +exit (EXIT_FAILURE ); + } + +usleep (100000 ); + event =get_event (self->fan_fd); +verify_event (_metadata, event,FAN_OPEN_EXEC_PERM , child); + +/* Deny the exec operation */ +close (event->fd); + ret =respond_to_event (self->fan_fd, event,FAN_DENY , + false/* useEventId */ ); +ASSERT_EQ (ret,sizeof (struct fanotify_response )); + +int status; + +ASSERT_EQ (waitpid (child, &status,0 ), child); +ASSERT_EQ (WEXITSTATUS (status),EXIT_SUCCESS ); +} + +TEST_F(fanotify, default_response) +{ +struct fanotify_event_metadata *event; +int ret; +pid_t child; +struct fanotify_response resp; + +/* Set default response to deny */ + resp.fd =FAN_NOFD ; + resp.response =FAN_DENY |FAN_DEFAULT ; + ret =write (self->fan_fd, &resp,sizeof (resp)); +ASSERT_EQ (ret,sizeof (resp)); + + child =fork (); +ASSERT_GE (child,0 ); + +if (child ==0 ) { +close (self->fan_fd); +/* Try to open the file - this should trigger FAN_OPEN_PERM */ +int fd =open (self->test_file_path,O_RDONLY ); + +/* If open succeeded, this is an error as we expect it to be denied */ +if (fd >=0 ) { +close (fd); +exit (EXIT_FAILURE ); + } + +/* Verify the expected error */ +if (errno ==EPERM ) +exit (EXIT_SUCCESS ); + +exit (EXIT_FAILURE ); + } + +usleep (100000 ); + event =get_event (self->fan_fd); +verify_event (_metadata, event,FAN_OPEN_PERM , child); + +/* Close fanotify group to return default response (DENY) */ +close (self->fan_fd); + self->fan_fd =-1 ; + +int status; + +ASSERT_EQ (waitpid (child, &status,0 ), child); +ASSERT_EQ (WEXITSTATUS (status),EXIT_SUCCESS ); +} + +TEST_F(fanotify, respond_via_event_id) +{ +struct fanotify_event_metadata *event; +int fd, ret; +pid_t child; + + child =fork (); +ASSERT_GE (child,0 ); + +if (child ==0 ) { +/* Try to open the file - this should trigger FAN_OPEN_PERM */ + fd =open (self->test_file_path2,O_RDONLY ); +if (fd <0 ) +exit (EXIT_FAILURE ); +close (fd); +exit (EXIT_SUCCESS ); + } + +usleep (100000 ); + event =get_event (self->fan_fd2); +verify_event (_metadata, event,FAN_OPEN_PERM , child); +ASSERT_EQ (event->event_id,1 ); + +/* Allow the open operation */ +close (event->fd); + ret =respond_to_event (self->fan_fd2, event,FAN_ALLOW , + true/* useEventId */ ); +ASSERT_EQ (ret,sizeof (struct fanotify_response )); + +int status; + +ASSERT_EQ (waitpid (child, &status,0 ), child); +ASSERT_EQ (WEXITSTATUS (status),EXIT_SUCCESS ); +} + +TEST_HARNESS_MAIN --2.47.1
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
PATCH 1/1 fanotify: selftests for fanotify permission events
Quoted 40 lines · On 6/26/25, 3:49 AM, "Jan Kara" <[email protected] <mailto:[email protected]>> wrote:
Quoted 25 lines · Amir Goldstein
Quoted 12 lines · On Mon, Jun 23, 2025 at 9:45 PM Ibrahim Jirdeh <[email protected]…
This adds selftests which exercise generating / responding to permission events. They requre root privileges since ^^^^ require
FAN_CLASS_PRE_CONTENTrequires it.Signed-off-by Ibrahim Jirdeh <[email protected] <mailto:[email protected]>>---
tools/testing/selftests/Makefile| 1 + .../selftests/filesystems/fanotify/.gitignore | 2 + .../selftests/filesystems/fanotify/Makefile | 8 +.../filesystems/fanotify/fanotify_perm_test.c| 386 ++++++++++++++++++Quoted 8 lines
4 files changed, 397 insertions(+)create mode 100644
tools/testing/selftests/filesystems/fanotify/.gitignorecreate mode 100644tools/testing/selftests/filesystems/fanotify/Makefilecreate mode 100644tools/testing/selftests/filesystems/fanotify/fanotify_perm_test.cHi Ibrahim,
As a general comment, I do not mind having diverse testing methods, but just wanted to make sure that you know that we usually write fanotify tests to new features in LTP.
Quoted 5 lines
LTP vs. selftests have their pros and cons, but both bring value
and add test coverage.
selftests would not have been my first choice for this particular test,
because it is so similar to tests already existing in LTP, e.g.:
https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/syscalls/fanotify/fanotify24.c <https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/syscalls/fanotify/fanotify24.c>Yeah, frankly I'd prefer to keep tests in one place unless there's a good reason not to. As you write in this case we already have very similar tests in LTP so adding a coverage for the new functionality there seems like a no-brainer...
Quoted 8 lines
Quoted 4 lines
but I suppose that testing the full functionality of event listener fd handover might be easier to implement with the selftest infrastructure. Anyway, I will not require you to use one test suite or the other if you have a preference.
If there's some functionality that's hard to test from LTP, we can consider implementing that in kselftests but I'd like to hear those reasons first...
I missed the existing tests present in LTP repo. Will resubmit the test cases for new functionality to that repo rather than adding them as selftests.
Quoted 47 lines · Ibrahim Jirdeh
Quoted 47 lines · On 6/26/25, 3:49 AM, "Jan Kara" <[email protected] <mailto:[email protected]>> wrote:
Quoted 25 lines · Amir Goldstein
Quoted 12 lines · On Mon, Jun 23, 2025 at 9:45 PM Ibrahim Jirdeh <[email protected]…
This adds selftests which exercise generating / responding to permission events. They requre root privileges since ^^^^ require
FAN_CLASS_PRE_CONTENTrequires it.Signed-off-by Ibrahim Jirdeh <[email protected] <mailto:[email protected]>>---
tools/testing/selftests/Makefile| 1 + .../selftests/filesystems/fanotify/.gitignore | 2 + .../selftests/filesystems/fanotify/Makefile | 8 +.../filesystems/fanotify/fanotify_perm_test.c| 386 ++++++++++++++++++Quoted 8 lines
4 files changed, 397 insertions(+)create mode 100644
tools/testing/selftests/filesystems/fanotify/.gitignorecreate mode 100644tools/testing/selftests/filesystems/fanotify/Makefilecreate mode 100644tools/testing/selftests/filesystems/fanotify/fanotify_perm_test.cHi Ibrahim,
As a general comment, I do not mind having diverse testing methods, but just wanted to make sure that you know that we usually write fanotify tests to new features in LTP.
Quoted 5 lines
LTP vs. selftests have their pros and cons, but both bring value
and add test coverage.
selftests would not have been my first choice for this particular test,
because it is so similar to tests already existing in LTP, e.g.:
https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/syscalls/fanotify/fanotify24.c <https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/syscalls/fanotify/fanotify24.c>Yeah, frankly I'd prefer to keep tests in one place unless there's a good reason not to. As you write in this case we already have very similar tests in LTP so adding a coverage for the new functionality there seems like a no-brainer...
Quoted 4 lines
but I suppose that testing the full functionality of event listener fd handover might be easier to implement with the selftest infrastructure. Anyway, I will not require you to use one test suite or the other if you have a preference.
Quoted 5 lines
Quoted 2 lines
If there's some functionality that's hard to test from LTP, we can consider implementing that in kselftests but I'd like to hear those reasons first...
I missed the existing tests present in LTP repo. Will resubmit the test cases for new functionality to that repo rather than adding them as selftests.
As I wrote in another reply, please see test fanotify25 that I forked from fanotify24
for testing new pre-content events API:
https://github.com/amir73il/ltp/commits/fan_pre_content_fid/
I do not wish to fork a test for every new feature and config variant. I'd rather test all new features in a given release in the same test if they are related.
Feel free to add FAN_REPORT_EVENT_ID testing to fanotify25 because I do not plan to leave the event->fd when reporting fid info unless I have to, and even if we do leave event->fd, you can use the test_variants iterator to run all test cases with and without FAN_REPORT_EVENT_ID instead of duplicating the test code.
See this test variant expansion for example:a4377184c ("fanotify21: Test reporting fd open errors with FAN_REPORT_FD_ERROR")
Thanks,
Amir.