Skip to contentSkip to conversation

pinctrl: eswin: Fix unsigned comparison to less than zero issue

PATCH In review Colin Ian King 2 participants 2 messages Jun 23, 2025 – Jun 24, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: eswin: Fix unsigned comparison to less than zero issue

The u32 variable voltage is being compared to less than zero and this can never be true. Fix this by making voltage an int type which is the same type as the return from the call to regulator_get_voltage.

Fixes 5b797bcc00ef ("pinctrl: eswin: Add EIC7700 pinctrl driver")
---
 drivers/pinctrl/pinctrl-eic7700.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pinctrl/pinctrl-eic7700.c +2 -2
index 719cd11e276a..4874b5532343 100644
@@ -622,8 +622,8 @@ static int eic7700_pinctrl_probe(struct platform_device *pdev)
 	struct pinctrl_dev *pctldev;
 	struct eic7700_pinctrl *pc;
 	struct regulator *regulator;
-	u32 voltage, rgmii0_mode, rgmii1_mode;
-	int ret;
+	u32 rgmii0_mode, rgmii1_mode;
+	int ret, voltage;
 
 	pc = devm_kzalloc(dev, struct_size(pc, functions, EIC7700_FUNCTIONS_COUNT), GFP_KERNEL);
 	if (!pc)
Signature · 1 line
2.50.0
#1 lore raw
Quoted 6 lines · Colin Ian King

The u32 variable voltage is being compared to less than zero and this can never be true. Fix this by making voltage an int type which is the same type as the return from the call to regulator_get_voltage.

Fixes 5b797bcc00ef ("pinctrl: eswin: Add EIC7700 pinctrl driver")

Patch applied!

Yours,
Linus Walleij