Skip to contentSkip to conversation

Revert "cpufreq: tegra186: Share policy per cluster"

PATCH In review Jon Hunter 2 participants 4 messages Jun 5, 2025 – Jun 24, 2025

Subsystems (2)
lore
Share & tools
lore

Jon Hunter

author maintainer
#0 lore raw

PATCH 1/1 Revert "cpufreq: tegra186: Share policy per cluster"

This reverts commit ac64f0e893ff370c4d3426c83c1bd0acae75bcf4 which is upstream commit be4ae8c19492cd6d5de61ccb34ffb3f5ede5eec8.

This commit is causing a suspend regression on Tegra186 Jetson TX2 with Linux v6.12.y kernels. This is not seen with Linux v6.15 that includes this change but indicates that there are there changes missing. Therefore, revert this change.

Fixes ac64f0e893ff ("cpufreq: tegra186: Share policy per cluster")
---
 drivers/cpufreq/tegra186-cpufreq.c | 7 -------
 1 file changed, 7 deletions(-)
drivers/cpufreq/tegra186-cpufreq.c +0 -7
index 4e5b6f9a56d1..7b8fcfa55038 100644
@@ -73,18 +73,11 @@ static int tegra186_cpufreq_init(struct cpufreq_policy *policy)
 {
 	struct tegra186_cpufreq_data *data = cpufreq_get_driver_data();
 	unsigned int cluster = data->cpus[policy->cpu].bpmp_cluster_id;
-	u32 cpu;
 
 	policy->freq_table = data->clusters[cluster].table;
 	policy->cpuinfo.transition_latency = 300 * 1000;
 	policy->driver_data = NULL;
 
-	/* set same policy for all cpus in a cluster */
-	for (cpu = 0; cpu < ARRAY_SIZE(tegra186_cpus); cpu++) {
-		if (data->cpus[cpu].bpmp_cluster_id == cluster)
-			cpumask_set_cpu(cpu, policy->cpus);
-	}
-
 	return 0;
 }
 
Signature · 1 line
2.43.0
#1 lore raw
Quoted 7 lines · Jon Hunter

This reverts commit ac64f0e893ff370c4d3426c83c1bd0acae75bcf4 which is upstream commit be4ae8c19492cd6d5de61ccb34ffb3f5ede5eec8.

This commit is causing a suspend regression on Tegra186 Jetson TX2 with Linux v6.12.y kernels. This is not seen with Linux v6.15 that includes this change but indicates that there are there changes missing. Therefore, revert this change.

But this is the 6.6.y tree, not 6.12.y tree. So is this still a regression in 6.6.y?

thanks,

greg k-h

#2 lore raw
Quoted 11 lines · Greg Kroah-Hartman
Quoted 7 lines · Jon Hunter

This reverts commit ac64f0e893ff370c4d3426c83c1bd0acae75bcf4 which is upstream commit be4ae8c19492cd6d5de61ccb34ffb3f5ede5eec8.

This commit is causing a suspend regression on Tegra186 Jetson TX2 with Linux v6.12.y kernels. This is not seen with Linux v6.15 that includes this change but indicates that there are there changes missing. Therefore, revert this change.

But this is the 6.6.y tree, not 6.12.y tree. So is this still a regression in 6.6.y?

Ah, nevermind, I'll just edit this by hand :)

author maintainer
#3 lore raw
Quoted 10 lines · Greg Kroah-Hartman
Quoted 9 lines · Greg Kroah-Hartman
Quoted 7 lines · Jon Hunter

This reverts commit ac64f0e893ff370c4d3426c83c1bd0acae75bcf4 which is upstream commit be4ae8c19492cd6d5de61ccb34ffb3f5ede5eec8.

This commit is causing a suspend regression on Tegra186 Jetson TX2 with Linux v6.12.y kernels. This is not seen with Linux v6.15 that includes this change but indicates that there are there changes missing. Therefore, revert this change.

Quoted 4 lines
Quoted 2 lines

But this is the 6.6.y tree, not 6.12.y tree. So is this still a regression in 6.6.y?

Ah, nevermind, I'll just edit this by hand :)

I should have been clearer in the commit message. The regression was only seen for v6.12.y, but we decided to revert for older versions too for consistency [0].

Jon

[0] https://lore.kernel.org/linux-tegra/2025060413-entrust-unsold-7bfd@gregkh/

Signature · 1 line
nvpublic