Skip to contentSkip to conversation

net: libwx: fix Tx L4 checksum

PATCH In review [email protected] 2 participants 2 messages Jun 24, 2025 – Jun 25, 2025 Stable branch

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: libwx: fix Tx L4 checksum

From: Jiawen Wu <[email protected]>

[ Upstream commit c7d82913d5f9e97860772ee4051eaa66b56a6273 ]

The hardware only supports L4 checksum offload for TCP/UDP/SCTP protocol. There was a bug to set Tx checksum flag for the other protocol that results in Tx ring hang. Fix to compute software checksum for these packets.

Fixes 3403960cdf86 ("net: wangxun: libwx add tx offload functions")
---
 drivers/net/ethernet/wangxun/libwx/wx_lib.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/ethernet/wangxun/libwx/wx_lib.c +3 -1
index 71c891d14fb6..0896742b3f30 100644
@@ -1336,6 +1336,7 @@ static void wx_tx_csum(struct wx_ring *tx_ring, struct wx_tx_buffer *first,
 	u8 tun_prot = 0;
 
 	if (skb->ip_summed != CHECKSUM_PARTIAL) {
+csum_failed:
 		if (!(first->tx_flags & WX_TX_FLAGS_HW_VLAN) &&
 		    !(first->tx_flags & WX_TX_FLAGS_CC))
 			return;
@@ -1429,7 +1430,8 @@ static void wx_tx_csum(struct wx_ring *tx_ring, struct wx_tx_buffer *first,
 					WX_TXD_L4LEN_SHIFT;
 			break;
 		default:
-			break;
+			skb_checksum_help(skb);
+			goto csum_failed;
 		}
 
 		/* update TX checksum flag */
Signature · 1 line
2.39.4
maintainer
#1 lore raw

[ Sasha's backport helper bot ]

Hi,

✅ All tests passed successfully. No issues detected. No action required from the submitter.

The upstream commit SHA1 provided is correct: c7d82913d5f9e97860772ee4051eaa66b56a6273

WARNING: Author mismatch between patch and upstream commit:
Backport author: [email protected]
Commit author: Jiawen Wu<[email protected]>

Status in newer kernel trees:
6.15.y | Present (exact SHA1)

Note: The patch differs from the upstream commit:
---
1: c7d82913d5f9e ! 1: 378a713847ffc net: libwx: fix Tx L4 checksum
@@ Metadata
## Commit message ##
net: libwx: fix Tx L4 checksum

+ [ Upstream commit c7d82913d5f9e97860772ee4051eaa66b56a6273 ]
+
The hardware only supports L4 checksum offload for TCP/UDP/SCTP protocol. There was a bug to set Tx checksum flag for the other protocol that results in Tx ring hang. Fix to compute software checksum for these packets.
@@ Commit message

+ Signed-off-by: Wenshan Lan <[email protected]>

## drivers/net/ethernet/wangxun/libwx/wx_lib.c ##
@@ drivers/net/ethernet/wangxun/libwx/wx_lib.c: static void wx_tx_csum(struct wx_ring *tx_ring, struct wx_tx_buffer *first,
---

Results of testing on various branches:

| Branch                    | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-6.12.y       |  Success    |  Success   |