perf debug: Add function symbols to dump_stack
Ian Rogers
reviewerPATCH v5 1/1 perf debug: Add function symbols to dump_stack
Symbolize stack traces by creating a live machine. Add this functionality to dump_stack and switch dump_stack users to use it. Switch TUI to use it. Add stack traces to the child test function which can be useful to diagnose blocked code.
Example output:
```
$ perf test -vv PERF_RECORD_
...
7: PERF_RECORD_* events & perf_sample fields:
7: PERF_RECORD_* events & perf_sample fields : Running (1 active)
^C
Signal (2) while running tests.
Terminating tests with the same signal
Internal test harness failure. Completing any started tests:
: 7: PERF_RECORD_* events & perf_sample fields:
---- unexpected signal (2) ----
#0 0x55788c6210a3 in child_test_sig_handler builtin-test.c:0
#1 0x7fc12fe49df0 in __restore_rt libc_sigaction.c:0
#2 0x7fc12fe99687 in __internal_syscall_cancel cancellation.c:64
#3 0x7fc12fee5f7a in clock_nanosleep@GLIBC_2.2.5 clock_nanosleep.c:72
#4 0x7fc12fef1393 in __nanosleep nanosleep.c:26
#5 0x7fc12ff02d68 in __sleep sleep.c:55
#6 0x55788c63196b in test__PERF_RECORD perf-record.c:0
#7 0x55788c620fb0 in run_test_child builtin-test.c:0
#8 0x55788c5bd18d in start_command run-command.c:127
#9 0x55788c621ef3 in __cmd_test builtin-test.c:0
#10 0x55788c6225bf in cmd_test ??:0
#11 0x55788c5afbd0 in run_builtin perf.c:0
#12 0x55788c5afeeb in handle_internal_command perf.c:0
#13 0x55788c52b383 in main ??:0
#14 0x7fc12fe33ca8 in __libc_start_call_main libc_start_call_main.h:74
#15 0x7fc12fe33d65 in __libc_start_main@@GLIBC_2.34 libc-start.c:128
#16 0x55788c52b9d1 in _start ??:0
---- unexpected signal (2) ----
#0 0x55788c6210a3 in child_test_sig_handler builtin-test.c:0
#1 0x7fc12fe49df0 in __restore_rt libc_sigaction.c:0
#2 0x7fc12fea3a14 in pthread_sigmask@GLIBC_2.2.5 pthread_sigmask.c:45
#3 0x7fc12fe49fd9 in __GI___sigprocmask sigprocmask.c:26
#4 0x7fc12ff2601b in __longjmp_chk longjmp.c:36
#5 0x55788c6210c0 in print_test_result.isra.0 builtin-test.c:0
#6 0x7fc12fe49df0 in __restore_rt libc_sigaction.c:0
#7 0x7fc12fe99687 in __internal_syscall_cancel cancellation.c:64
#8 0x7fc12fee5f7a in clock_nanosleep@GLIBC_2.2.5 clock_nanosleep.c:72
#9 0x7fc12fef1393 in __nanosleep nanosleep.c:26
#10 0x7fc12ff02d68 in __sleep sleep.c:55
#11 0x55788c63196b in test__PERF_RECORD perf-record.c:0
#12 0x55788c620fb0 in run_test_child builtin-test.c:0
#13 0x55788c5bd18d in start_command run-command.c:127
#14 0x55788c621ef3 in __cmd_test builtin-test.c:0
#15 0x55788c6225bf in cmd_test ??:0
#16 0x55788c5afbd0 in run_builtin perf.c:0
#17 0x55788c5afeeb in handle_internal_command perf.c:0
#18 0x55788c52b383 in main ??:0
#19 0x7fc12fe33ca8 in __libc_start_call_main libc_start_call_main.h:74
#20 0x7fc12fe33d65 in __libc_start_main@@GLIBC_2.34 libc-start.c:128
#21 0x55788c52b9d1 in _start ??:0
7: PERF_RECORD_* events & perf_sample fields : Skip (permissions)
```---
v5: Fix v3/v4 by rebasing v2 rather than v1 patch series. Add
uintptr_t cast to avoid -Werror=pointer-to-int-cast (Namhyung)
v4: Additional addr_location__exit (Namhyung)
v3: Rebase
v2: Fix NO_BACKTRACE=1 build (Arnaldo)
--- tools/perf/tests/builtin-test.c | 15 +++++++- tools/perf/ui/tui/setup.c | 2 +- tools/perf/util/debug.c | 68 +++++++++++++++++++++++++++------ tools/perf/util/debug.h | 1 + 4 files changed, 73 insertions(+), 13 deletions(-)
tools/perf/tests/builtin-test.c +14 -1
@@ -6,6 +6,9 @@*/ #include <fcntl.h> #include <errno.h> +#ifdef HAVE_BACKTRACE_SUPPORT +#include <execinfo.h> +#endif #include <poll.h> #include <unistd.h> #include <setjmp.h>
@@ -231,6 +234,16 @@ static jmp_buf run_test_jmp_buf;static void child_test_sig_handler (int sig) { +#ifdef HAVE_BACKTRACE_SUPPORT +void *stackdump[32 ]; +size_t stackdump_size; +#endif + +fprintf (stderr,"\n---- unexpected signal (%d) ----\n" , sig); +#ifdef HAVE_BACKTRACE_SUPPORT + stackdump_size =backtrace (stackdump,ARRAY_SIZE (stackdump)); +__dump_stack (stderr, stackdump, stackdump_size); +#endif siglongjmp (run_test_jmp_buf, sig); }
@@ -244,7 +257,7 @@ static int run_test_child(struct child_process *process) err =sigsetjmp (run_test_jmp_buf,1 );if (err) { -fprintf (stderr,"\n---- unexpected signal (%d) ----\n" , err); +/* Received signal. */ err = err >0 ? -err :-1 ; goto err_out; }
tools/perf/ui/tui/setup.c +1 -1
@@ -108,7 +108,7 @@ static void ui__signal_backtrace(int sig)printf ("-------- backtrace --------\n" ); size =backtrace (stackdump,ARRAY_SIZE (stackdump)); -backtrace_symbols_fd (stackdump, size,STDOUT_FILENO ); +__dump_stack (stdout, stackdump, size);exit (0 ); }
tools/perf/util/debug.c +57 -11
89 lines not on this page · raw message
tools/perf/util/debug.h +1 -0
@@ -85,6 +85,7 @@ void debug_set_display_time(bool set);void perf_debug_setup (void );int perf_quiet_option (void ); +void __dump_stack (FILE *file,void **stackdump,size_t stackdump_size);void dump_stack (void );void sighandler_dump_stack (int sig);
Signature · 1 line
2.50.0.714.g196bf9f422-goog
Quoted 17 lines · Ian Rogers
Symbolize stack traces by creating a live machine. Add this functionality to
dump_stackand switchdump_stackusers to use it. Switch TUI to use it. Add stack traces to the child test function which can be useful to diagnose blocked code.Example output:
```$ perf test -vv PERF_RECORD_ ... 7: PERF_RECORD_* events & perf_sample fields: 7: PERF_RECORD_* events & perf_sample fields : Running (1 active) ^C Signal (2) while running tests. Terminating tests with the same signal Internal test harness failure. Completing any started tests: : 7: PERF_RECORD_* events & perf_sample fields:
Quoted 1 line
[...]
Applied to perf-tools-next, thanks!
Best regards,
Namhyung