iio: adc: ti-adc128s052: add support for TI's ADC121s021
Subsystems (2)
cover iio: adc: ti-adc128s052: add support for TI's ADC121s021
- Add support for ADC121s021 and related (single channel).
This adds support for the 1-channel variants ADC121s021/051/101.
I'm not certain whether this patch is truly necessary, or if there's a more general solution for single-channel ADCs that would make this patch obsolete. If such a solution exists, please let me know. Hence, this is perhaps more of a question than a formal request to accept the patch.
---
Lothar Rubusch (2):
iio: adc: ti-adc128s052: add support for adc121s021
iio: adc: ti-adc128s052: replace literal by unit expression
drivers/iio/adc/ti-adc128s052.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-)
base-commit: b57cb7c47e31244bef6612f271c5dc390f761e17
Signature · 1 line
2.39.5
PATCH 1/2 iio: adc: ti-adc128s052: add support for adc121s021
Add support for the single channel variant(s) of this ADC.
--- drivers/iio/adc/ti-adc128s052.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-)
drivers/iio/adc/ti-adc128s052.c +16 -1
@@ -7,6 +7,7 @@* https://www.ti.com/lit/ds/symlink/adc128s052.pdf * https://www.ti.com/lit/ds/symlink/adc122s021.pdf * https://www.ti.com/lit/ds/symlink/adc124s021.pdf +* https://www.ti.com/lit/ds/symlink/adc121s021.pdf */ #include <linux/cleanup.h>
@@ -110,6 +111,10 @@ static const struct iio_chan_spec adc128s052_channels[] = { ADC128_VOLTAGE_CHANNEL(7), }; +static const struct iio_chan_spec adc121s021_channels[] = { +ADC128_VOLTAGE_CHANNEL (0 ), +}; +static const struct iio_chan_spec adc122s021_channels[] = {ADC128_VOLTAGE_CHANNEL (0 ),ADC128_VOLTAGE_CHANNEL (1 ),
@@ -143,6 +148,10 @@ static const struct adc128_configuration adc128_config[] = { .refname = "vdd", .other_regulators = &bd79104_regulators, .num_other_regulators = 1, + }, { + .channels = adc121s021_channels, + .num_channels = ARRAY_SIZE(adc121s021_channels), + .refname = "vref", }, };
@@ -207,7 +216,10 @@ static const struct of_device_id adc128_of_match[] = { { .compatible = "ti,adc124s051", .data = &adc128_config[2] }, { .compatible = "ti,adc124s101", .data = &adc128_config[2] }, { .compatible = "rohm,bd79104", .data = &adc128_config[3] }, - { } + { .compatible = "ti,adc121s021", .data = &adc128_config[4] }, + { .compatible = "ti,adc121s051", .data = &adc128_config[4] }, + { .compatible = "ti,adc121s101", .data = &adc128_config[4] }, + { }, };MODULE_DEVICE_TABLE (of, adc128_of_match);
@@ -220,6 +232,9 @@ static const struct spi_device_id adc128_id[] = { { "adc124s051", (kernel_ulong_t)&adc128_config[2] }, { "adc124s101", (kernel_ulong_t)&adc128_config[2] }, { "bd79104", (kernel_ulong_t)&adc128_config[3] }, + { "adc121s021", (kernel_ulong_t)&adc128_config[4] }, + { "adc121s051", (kernel_ulong_t)&adc128_config[4] }, + { "adc121s101", (kernel_ulong_t)&adc128_config[4] }, { } };MODULE_DEVICE_TABLE (spi, adc128_id);
Signature · 1 line
2.39.5
Re: [PATCH v1 1/2] iio: adc: ti-adc128s052: add support for adc121s021
Quoted 1 line · Lothar Rubusch
Add support for the single channel variant(s) of this ADC.
...
drivers/iio/adc/ti-adc128s052.c static const struct of_device_id adc128_of_match[] = {
Quoted 3 lines
drivers/iio/adc/ti-adc128s052.c +1
-1- { } + { },
Stray change.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Matti Vaittinen
maintainerRe: [PATCH v1 1/2] iio: adc: ti-adc128s052: add support for adc121s021
In reply to Lothar RubuschHi Lothar,
Quoted 3 lines · Lothar Rubusch
Add support for the single channel variant(s) of this ADC.
Signed-off-by Lothar Rubusch <[email protected]>
Thanks for this addition. In principle, this looks good to me but I am afraid there is another colliding series being worked on:
https://lore.kernel.org/all/[email protected]/
Maybe you can align the effort with Sukrut?
What I specifically like (and think is the right thing to do) in Sukrut's series is replacing the 'adc122s021_channels' -array with individual structures. In my opinion the array is just unnecessary complexity and individual structures are simpler.
Other than that, this looks good to me.
Yours,
-- Matti
Quoted 28 lines
--- drivers/iio/adc/ti-adc128s052.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-)drivers/iio/adc/ti-adc128s052.c +5
-0@@ -7,6 +7,7 @@* https://www.ti.com/lit/ds/symlink/adc128s052.pdf * https://www.ti.com/lit/ds/symlink/adc122s021.pdf * https://www.ti.com/lit/ds/symlink/adc124s021.pdf +* https://www.ti.com/lit/ds/symlink/adc121s021.pdf */ #include <linux/cleanup.h> @@ -110,6 +111,10 @@ static const struct iio_chan_spec adc128s052_channels[] = { ADC128_VOLTAGE_CHANNEL(7), }; +static const struct iio_chan_spec adc121s021_channels[] = { +ADC128_VOLTAGE_CHANNEL (0 ), +}; +static const struct iio_chan_spec adc122s021_channels[] = {ADC128_VOLTAGE_CHANNEL (0 ),ADC128_VOLTAGE_CHANNEL (1 ),
drivers/iio/adc/ti-adc128s052.c static const struct adc128_configuration adc128_config[] = { · line 156
Quoted 9 lines
drivers/iio/adc/ti-adc128s052.c +4
-0@@ -143,6 +148,10 @@ static const struct adc128_configuration adc128_config[] = { .refname = "vdd", .other_regulators = &bd79104_regulators, .num_other_regulators = 1, + }, { + .channels = adc121s021_channels, + .num_channels = ARRAY_SIZE(adc121s021_channels), + .refname = "vref", }, };
I'd love seeing this array split to individual structs.
Quoted 23 lines
drivers/iio/adc/ti-adc128s052.c +7
-1@@ -207,7 +216,10 @@ static const struct of_device_id adc128_of_match[] = { { .compatible = "ti,adc124s051", .data = &adc128_config[2] }, { .compatible = "ti,adc124s101", .data = &adc128_config[2] }, { .compatible = "rohm,bd79104", .data = &adc128_config[3] }, - { } + { .compatible = "ti,adc121s021", .data = &adc128_config[4] }, + { .compatible = "ti,adc121s051", .data = &adc128_config[4] }, + { .compatible = "ti,adc121s101", .data = &adc128_config[4] }, + { }, };MODULE_DEVICE_TABLE (of, adc128_of_match);@@ -220,6 +232,9 @@ static const struct spi_device_id adc128_id[] = { { "adc124s051", (kernel_ulong_t)&adc128_config[2] }, { "adc124s101", (kernel_ulong_t)&adc128_config[2] }, { "bd79104", (kernel_ulong_t)&adc128_config[3] }, + { "adc121s021", (kernel_ulong_t)&adc128_config[4] }, + { "adc121s051", (kernel_ulong_t)&adc128_config[4] }, + { "adc121s101", (kernel_ulong_t)&adc128_config[4] }, { } };MODULE_DEVICE_TABLE (spi, adc128_id);
Jonathan Cameron
maintainerRe: [PATCH v1 1/2] iio: adc: ti-adc128s052: add support for adc121s021
Quoted 5 lines · On Thu, 26 Jun 2025 08:24:41 +0300 Matti Vaittinen <[email protected]>…
Hi Lothar,
Quoted 2 lines · Lothar Rubusch
Add support for the single channel variant(s) of this ADC.
Quoted 8 lines
Quoted 1 line
Signed-off-by Lothar Rubusch <[email protected]>Thanks for this addition. In principle, this looks good to me but I am afraid there is another colliding series being worked on:
https://lore.kernel.org/all/[email protected]/
Maybe you can align the effort with Sukrut?
+CC Sukrut.
Quoted 7 lines
What I specifically like (and think is the right thing to do) in Sukrut's series is replacing the '
adc122s021_channels' -array with individual structures. In my opinion the array is just unnecessary complexity and individual structures are simpler.Other than that, this looks good to me.
Sukrut, perhaps you could add this to the end of your series, rebased to those changes? Would save a synchronization step for your v5 (and later if needed)
No problem if not, but I agree with Matti that we should take your series first.
Jonathan
Quoted 69 lines
Yours,
-- MattiQuoted 28 lines
--- drivers/iio/adc/ti-adc128s052.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-)drivers/iio/adc/ti-adc128s052.c +5
-0@@ -7,6 +7,7 @@* https://www.ti.com/lit/ds/symlink/adc128s052.pdf * https://www.ti.com/lit/ds/symlink/adc122s021.pdf * https://www.ti.com/lit/ds/symlink/adc124s021.pdf +* https://www.ti.com/lit/ds/symlink/adc121s021.pdf */ #include <linux/cleanup.h> @@ -110,6 +111,10 @@ static const struct iio_chan_spec adc128s052_channels[] = { ADC128_VOLTAGE_CHANNEL(7), }; +static const struct iio_chan_spec adc121s021_channels[] = { +ADC128_VOLTAGE_CHANNEL (0 ), +}; +static const struct iio_chan_spec adc122s021_channels[] = {ADC128_VOLTAGE_CHANNEL (0 ),ADC128_VOLTAGE_CHANNEL (1 ),drivers/iio/adc/ti-adc128s052.c static const struct adc128_configuration adc128_config[] = { · line 156
Quoted 9 lines
drivers/iio/adc/ti-adc128s052.c +4
-0@@ -143,6 +148,10 @@ static const struct adc128_configuration adc128_config[] = { .refname = "vdd", .other_regulators = &bd79104_regulators, .num_other_regulators = 1, + }, { + .channels = adc121s021_channels, + .num_channels = ARRAY_SIZE(adc121s021_channels), + .refname = "vref", }, };I'd love seeing this array split to individual structs.
Quoted 23 lines
drivers/iio/adc/ti-adc128s052.c +7
-1@@ -207,7 +216,10 @@ static const struct of_device_id adc128_of_match[] = { { .compatible = "ti,adc124s051", .data = &adc128_config[2] }, { .compatible = "ti,adc124s101", .data = &adc128_config[2] }, { .compatible = "rohm,bd79104", .data = &adc128_config[3] }, - { } + { .compatible = "ti,adc121s021", .data = &adc128_config[4] }, + { .compatible = "ti,adc121s051", .data = &adc128_config[4] }, + { .compatible = "ti,adc121s101", .data = &adc128_config[4] }, + { }, };MODULE_DEVICE_TABLE (of, adc128_of_match);@@ -220,6 +232,9 @@ static const struct spi_device_id adc128_id[] = { { "adc124s051", (kernel_ulong_t)&adc128_config[2] }, { "adc124s101", (kernel_ulong_t)&adc128_config[2] }, { "bd79104", (kernel_ulong_t)&adc128_config[3] }, + { "adc121s021", (kernel_ulong_t)&adc128_config[4] }, + { "adc121s051", (kernel_ulong_t)&adc128_config[4] }, + { "adc121s101", (kernel_ulong_t)&adc128_config[4] }, { } };MODULE_DEVICE_TABLE (spi, adc128_id);
Re: [PATCH v1 1/2] iio: adc: ti-adc128s052: add support for adc121s021
Hi guys,
I absolutely agree and won't send further versions of this.
Hi Sukrut, if you find some possibility to use it, great. If not, nevermind.
Thank you all, for the feedback. One small question below.
Quoted 11 lines · Jonathan Cameron
Quoted 7 lines · On Thu, 26 Jun 2025 08:24:41 +0300 Matti Vaittinen <[email protected]>…
Hi Lothar,
Quoted 3 lines · Lothar Rubusch
Add support for the single channel variant(s) of this ADC.
Signed-off-by Lothar Rubusch <[email protected]>
Quoted 8 lines
Quoted 6 lines
Thanks for this addition. In principle, this looks good to me but I am afraid there is another colliding series being worked on:
https://lore.kernel.org/all/[email protected]/
Maybe you can align the effort with Sukrut?
+CC Sukrut.
Hi Matti,
Perhaps just one little question here to you. You used the regulator name "vdd" where others
before used "vref". At the end, this seems to be pretty free, depending on how it is set in the
DT or how you name it in the DT (in my case it was "5v0", but I wanted to keep the convention,
if so).
So, my question is, is there a naming convention what to take for a, say, default
regulator naming or fixed 5V regulator?
Best,
L
Quoted 89 lines
Quoted 7 lines
What I specifically like (and think is the right thing to do) in Sukrut's series is replacing the '
adc122s021_channels' -array with individual structures. In my opinion the array is just unnecessary complexity and individual structures are simpler.Other than that, this looks good to me.
Sukrut, perhaps you could add this to the end of your series, rebased to those changes? Would save a synchronization step for your v5 (and later if needed)
No problem if not, but I agree with Matti that we should take your series first.
Jonathan
Quoted 69 lines
Yours,
-- MattiQuoted 28 lines
--- drivers/iio/adc/ti-adc128s052.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-)drivers/iio/adc/ti-adc128s052.c +5
-0@@ -7,6 +7,7 @@* https://www.ti.com/lit/ds/symlink/adc128s052.pdf * https://www.ti.com/lit/ds/symlink/adc122s021.pdf * https://www.ti.com/lit/ds/symlink/adc124s021.pdf +* https://www.ti.com/lit/ds/symlink/adc121s021.pdf */ #include <linux/cleanup.h> @@ -110,6 +111,10 @@ static const struct iio_chan_spec adc128s052_channels[] = { ADC128_VOLTAGE_CHANNEL(7), }; +static const struct iio_chan_spec adc121s021_channels[] = { +ADC128_VOLTAGE_CHANNEL (0 ), +}; +static const struct iio_chan_spec adc122s021_channels[] = {ADC128_VOLTAGE_CHANNEL (0 ),ADC128_VOLTAGE_CHANNEL (1 ),drivers/iio/adc/ti-adc128s052.c static const struct adc128_configuration adc128_config[] = { · line 156
Quoted 9 lines
drivers/iio/adc/ti-adc128s052.c +4
-0@@ -143,6 +148,10 @@ static const struct adc128_configuration adc128_config[] = { .refname = "vdd", .other_regulators = &bd79104_regulators, .num_other_regulators = 1, + }, { + .channels = adc121s021_channels, + .num_channels = ARRAY_SIZE(adc121s021_channels), + .refname = "vref", }, };I'd love seeing this array split to individual structs.
Quoted 23 lines
drivers/iio/adc/ti-adc128s052.c +7
-1@@ -207,7 +216,10 @@ static const struct of_device_id adc128_of_match[] = { { .compatible = "ti,adc124s051", .data = &adc128_config[2] }, { .compatible = "ti,adc124s101", .data = &adc128_config[2] }, { .compatible = "rohm,bd79104", .data = &adc128_config[3] }, - { } + { .compatible = "ti,adc121s021", .data = &adc128_config[4] }, + { .compatible = "ti,adc121s051", .data = &adc128_config[4] }, + { .compatible = "ti,adc121s101", .data = &adc128_config[4] }, + { }, };MODULE_DEVICE_TABLE (of, adc128_of_match);@@ -220,6 +232,9 @@ static const struct spi_device_id adc128_id[] = { { "adc124s051", (kernel_ulong_t)&adc128_config[2] }, { "adc124s101", (kernel_ulong_t)&adc128_config[2] }, { "bd79104", (kernel_ulong_t)&adc128_config[3] }, + { "adc121s021", (kernel_ulong_t)&adc128_config[4] }, + { "adc121s051", (kernel_ulong_t)&adc128_config[4] }, + { "adc121s101", (kernel_ulong_t)&adc128_config[4] }, { } };MODULE_DEVICE_TABLE (spi, adc128_id);
David Lechner
reviewerRe: [PATCH v1 1/2] iio: adc: ti-adc128s052: add support for adc121s021
Quoted 2 lines · Lothar Rubusch
Hi guys,
...
Quoted 8 lines
Perhaps just one little question here to you. You used the regulator name "vdd" where others
before used "vref". At the end, this seems to be pretty free, depending on how it is set in the
DT or how you name it in the DT (in my case it was "5v0", but I wanted to keep the convention,
if so).
Quoted 4 lines
So, my question is, is there a naming convention what to take for a, say, default
regulator naming or fixed 5V regulator?
I don't think there is a naming convention for supplies other than making it match the pin name from the datasheet.
If we were to try to come up with some standard naming convention though, I would not include the voltage value in the name. Rather, the properties should be named after the function that it does, like vref-supply for an external reference voltage, vio-supply for I/O pin voltage supply, power-supply for a whole-chip or main supply, analog-supply and digital-supply for chips that don't have a whole-chip supply but rather split the analog and digital circuitry. These are the most common ones that I have seen on ADCs.
The fact that the TI chips in this driver use "vref-supply" doesn't really make sense in the DT bindings. V_REF is an internal signal in the ADC. In other words, it's kind of abusing the binding to specify the reference voltage without actually saying that the chip also has power supplies.
Chips like adc128s052 should really have va-supply for the power supply connected to the V_A pin that also serves as the reference voltage and vd-supply for the supply connected to the V_D pin for the digital I/O supply. And adc121s021 would only have va-supply because there is no separate V_D pin for a separate I/O supply.
But there are lot's of ADCs already incorrectly using vref-supply like this, so not sure if it is worth trying to fix them or not. But if we wanted to fix it for these TI chips, I would suggest to deprecate the vref-supply and add the actual supplies to the DT bindings and implement a fallback in the driver to check for vref-supply if the other supplies are not given so that we don't break existing dtbs.
Jonathan Cameron
maintainerRe: [PATCH v1 1/2] iio: adc: ti-adc128s052: add support for adc121s021
Quoted 42 lines · On Fri, 27 Jun 2025 11:27:22 -0500 David Lechner <[email protected]> wrote:
Quoted 2 lines · Lothar Rubusch
Hi guys,
...
Quoted 8 lines
Perhaps just one little question here to you. You used the regulator name "vdd" where others
before used "vref". At the end, this seems to be pretty free, depending on how it is set in the
DT or how you name it in the DT (in my case it was "5v0", but I wanted to keep the convention,
if so).Quoted 4 lines
So, my question is, is there a naming convention what to take for a, say, default
regulator naming or fixed 5V regulator?I don't think there is a naming convention for supplies other than making it match the pin name from the datasheet.
If we were to try to come up with some standard naming convention though, I would not include the voltage value in the name. Rather, the properties should be named after the function that it does, like vref-supply for an external reference voltage, vio-supply for I/O pin voltage supply, power-supply for a whole-chip or main supply, analog-supply and digital-supply for chips that don't have a whole-chip supply but rather split the analog and digital circuitry. These are the most common ones that I have seen on ADCs.
The fact that the TI chips in this driver use "vref-supply" doesn't really make sense in the DT bindings.
V_REFis an internal signal in the ADC. In other words, it's kind of abusing the binding to specify the reference voltage without actually saying that the chip also has power supplies.Chips like adc128s052 should really have va-supply for the power supply connected to the
V_Apin that also serves as the reference voltage and vd-supply for the supply connected to theV_Dpin for the digital I/O supply. And adc121s021 would only have va-supply because there is no separateV_Dpin for a separate I/O supply.
Quoted 6 lines
But there are lot's of ADCs already incorrectly using vref-supply like this, so not sure if it is worth trying to fix them or not. But if we wanted to fix it for these TI chips, I would suggest to deprecate the vref-supply and add the actual supplies to the DT bindings and implement a fallback in the driver to check for vref-supply if the other supplies are not given so that we don't break existing dtbs.
Agreed. vref-supply should only be used if it's an external pin labeled vref. (which is fairly common). Where it's labeled V_A like here we should name it after that. Fix would be as you suggest with the fallback to cover DT bindings in use.
Jonathan
Re: [PATCH v1 1/2] iio: adc: ti-adc128s052: add support for adc121s021
In reply to Jonathan CameronQuoted 27 lines · Jonathan Cameron
Quoted 5 lines · On Thu, 26 Jun 2025 08:24:41 +0300 Matti Vaittinen <[email protected]>…
Hi Lothar,
Quoted 2 lines · Lothar Rubusch
Add support for the single channel variant(s) of this ADC.
Quoted 8 lines
Quoted 1 line
Signed-off-by Lothar Rubusch <[email protected]>Thanks for this addition. In principle, this looks good to me but I am afraid there is another colliding series being worked on:
https://lore.kernel.org/all/[email protected]/
Maybe you can align the effort with Sukrut?
+CC Sukrut.
Quoted 7 lines
What I specifically like (and think is the right thing to do) in Sukrut's series is replacing the '
adc122s021_channels' -array with individual structures. In my opinion the array is just unnecessary complexity and individual structures are simpler.Other than that, this looks good to me.
Quoted 9 lines
Sukrut, perhaps you could add this to the end of your series, rebased to those changes? Would save a synchronization step for your v5 (and later if needed)
No problem if not, but I agree with Matti that we should take your series first.
Jonathan
Sure, I will add these adc121s0xx to the end of my v5. Thanks.
Quoted 71 lines
Quoted 70 lines
Yours,
-- MattiQuoted 28 lines
--- drivers/iio/adc/ti-adc128s052.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-)drivers/iio/adc/ti-adc128s052.c +5
-0@@ -7,6 +7,7 @@* https://www.ti.com/lit/ds/symlink/adc128s052.pdf * https://www.ti.com/lit/ds/symlink/adc122s021.pdf * https://www.ti.com/lit/ds/symlink/adc124s021.pdf +* https://www.ti.com/lit/ds/symlink/adc121s021.pdf */ #include <linux/cleanup.h> @@ -110,6 +111,10 @@ static const struct iio_chan_spec adc128s052_channels[] = { ADC128_VOLTAGE_CHANNEL(7), }; +static const struct iio_chan_spec adc121s021_channels[] = { +ADC128_VOLTAGE_CHANNEL (0 ), +}; +static const struct iio_chan_spec adc122s021_channels[] = {ADC128_VOLTAGE_CHANNEL (0 ),ADC128_VOLTAGE_CHANNEL (1 ),drivers/iio/adc/ti-adc128s052.c static const struct adc128_configuration adc128_config[] = { · line 156
Quoted 9 lines
drivers/iio/adc/ti-adc128s052.c +4
-0@@ -143,6 +148,10 @@ static const struct adc128_configuration adc128_config[] = { .refname = "vdd", .other_regulators = &bd79104_regulators, .num_other_regulators = 1, + }, { + .channels = adc121s021_channels, + .num_channels = ARRAY_SIZE(adc121s021_channels), + .refname = "vref", }, };I'd love seeing this array split to individual structs.
Quoted 23 lines
drivers/iio/adc/ti-adc128s052.c +7
-1@@ -207,7 +216,10 @@ static const struct of_device_id adc128_of_match[] = { { .compatible = "ti,adc124s051", .data = &adc128_config[2] }, { .compatible = "ti,adc124s101", .data = &adc128_config[2] }, { .compatible = "rohm,bd79104", .data = &adc128_config[3] }, - { } + { .compatible = "ti,adc121s021", .data = &adc128_config[4] }, + { .compatible = "ti,adc121s051", .data = &adc128_config[4] }, + { .compatible = "ti,adc121s101", .data = &adc128_config[4] }, + { }, };MODULE_DEVICE_TABLE (of, adc128_of_match);@@ -220,6 +232,9 @@ static const struct spi_device_id adc128_id[] = { { "adc124s051", (kernel_ulong_t)&adc128_config[2] }, { "adc124s101", (kernel_ulong_t)&adc128_config[2] }, { "bd79104", (kernel_ulong_t)&adc128_config[3] }, + { "adc121s021", (kernel_ulong_t)&adc128_config[4] }, + { "adc121s051", (kernel_ulong_t)&adc128_config[4] }, + { "adc121s101", (kernel_ulong_t)&adc128_config[4] }, { } };MODULE_DEVICE_TABLE (spi, adc128_id);
Re: [PATCH v1 1/2] iio: adc: ti-adc128s052: add support for adc121s021
Quoted 33 lines · Sukrut Bellary
Quoted 31 lines · Jonathan Cameron
Quoted 5 lines · On Thu, 26 Jun 2025 08:24:41 +0300 Matti Vaittinen <[email protected]>…
Hi Lothar,
Quoted 2 lines · Lothar Rubusch
Add support for the single channel variant(s) of this ADC.
Quoted 8 lines
Quoted 1 line
Signed-off-by Lothar Rubusch <[email protected]>Thanks for this addition. In principle, this looks good to me but I am afraid there is another colliding series being worked on:
https://lore.kernel.org/all/[email protected]/
Maybe you can align the effort with Sukrut?
+CC Sukrut.
Quoted 7 lines
What I specifically like (and think is the right thing to do) in Sukrut's series is replacing the '
adc122s021_channels' -array with individual structures. In my opinion the array is just unnecessary complexity and individual structures are simpler.Other than that, this looks good to me.
Sukrut, perhaps you could add this to the end of your series, rebased to those changes? Would save a synchronization step for your v5 (and later if needed)
Quoted 8 lines
Quoted 5 lines
No problem if not, but I agree with Matti that we should take your series first.
Jonathan
Sure, I will add these adc121s0xx to the end of my v5. Thanks.
Hi Sukrut,
Since David Lechner still asked for ordering the TI ADC vs Rohm entries a bit, and complained about the missing binding entry: Shall I fix this rapidly and send in another version?
Best,
L
...
Re: [PATCH v1 1/2] iio: adc: ti-adc128s052: add support for adc121s021
Quoted 43 lines · Lothar Rubusch
Quoted 33 lines · Sukrut Bellary
Quoted 31 lines · Jonathan Cameron
Quoted 5 lines · On Thu, 26 Jun 2025 08:24:41 +0300 Matti Vaittinen <[email protected]>…
Hi Lothar,
Quoted 2 lines · Lothar Rubusch
Add support for the single channel variant(s) of this ADC.
Quoted 8 lines
Quoted 1 line
Signed-off-by Lothar Rubusch <[email protected]>Thanks for this addition. In principle, this looks good to me but I am afraid there is another colliding series being worked on:
https://lore.kernel.org/all/[email protected]/
Maybe you can align the effort with Sukrut?
+CC Sukrut.
Quoted 7 lines
What I specifically like (and think is the right thing to do) in Sukrut's series is replacing the '
adc122s021_channels' -array with individual structures. In my opinion the array is just unnecessary complexity and individual structures are simpler.Other than that, this looks good to me.
Sukrut, perhaps you could add this to the end of your series, rebased to those changes? Would save a synchronization step for your v5 (and later if needed)
Quoted 8 lines
Quoted 5 lines
No problem if not, but I agree with Matti that we should take your series first.
Jonathan
Sure, I will add these adc121s0xx to the end of my v5. Thanks.
Quoted 6 lines
Hi Sukrut,
Since David Lechner still asked for ordering the TI ADC vs Rohm entries a bit, and complained about the missing binding entry: Shall I fix this rapidly and send in another version?
The ordering of TI and Rohm has been addressed in my series v4 [1]. I will arrange ti,adc121xx in order in v5.
[1]. https://lore.kernel.org/all/[email protected]/
Quoted 4 lines
Best,
L...
David Lechner
reviewerRe: [PATCH v1 1/2] iio: adc: ti-adc128s052: add support for adc121s021
In reply to Lothar RubuschQuoted 31 lines · Lothar Rubusch
Add support for the single channel variant(s) of this ADC.
Signed-off-by Lothar Rubusch <[email protected]>--- drivers/iio/adc/ti-adc128s052.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-)drivers/iio/adc/ti-adc128s052.c +5
-0@@ -7,6 +7,7 @@* https://www.ti.com/lit/ds/symlink/adc128s052.pdf * https://www.ti.com/lit/ds/symlink/adc122s021.pdf * https://www.ti.com/lit/ds/symlink/adc124s021.pdf +* https://www.ti.com/lit/ds/symlink/adc121s021.pdf */ #include <linux/cleanup.h> @@ -110,6 +111,10 @@ static const struct iio_chan_spec adc128s052_channels[] = { ADC128_VOLTAGE_CHANNEL(7), }; +static const struct iio_chan_spec adc121s021_channels[] = { +ADC128_VOLTAGE_CHANNEL (0 ), +}; +static const struct iio_chan_spec adc122s021_channels[] = {ADC128_VOLTAGE_CHANNEL (0 ),ADC128_VOLTAGE_CHANNEL (1 ),
drivers/iio/adc/ti-adc128s052.c static const struct adc128_configuration adc128_config[] = { · line 155
Quoted 8 lines
drivers/iio/adc/ti-adc128s052.c +4
-0@@ -143,6 +148,10 @@ static const struct adc128_configuration adc128_config[] = { .refname = "vdd", .other_regulators = &bd79104_regulators, .num_other_regulators = 1, + }, { + .channels = adc121s021_channels, + .num_channels = ARRAY_SIZE(adc121s021_channels), + .refname = "vref", },
Let's try to keep these sorted rather than having rohm in the middle of ti chips.
Same applies to the rest of the changes in this patch as well (other than adc121s021_channels[] which look to be in a logical order already).
drivers/iio/adc/ti-adc128s052.c static const struct of_device_id adc128_of_match[] = { · line 221
Quoted 10 lines
drivers/iio/adc/ti-adc128s052.c +3
-1};@@ -207,7 +216,10 @@ static const struct of_device_id adc128_of_match[] = { { .compatible = "ti,adc124s051", .data = &adc128_config[2] }, { .compatible = "ti,adc124s101", .data = &adc128_config[2] }, { .compatible = "rohm,bd79104", .data = &adc128_config[3] }, - { } + { .compatible = "ti,adc121s021", .data = &adc128_config[4] }, + { .compatible = "ti,adc121s051", .data = &adc128_config[4] }, + { .compatible = "ti,adc121s101", .data = &adc128_config[4] },
We'll need another patch to add these compatible strings to Documentation/devicetree/bindings/iio/adc/ti,adc128s052.yaml
Quoted 14 lines
drivers/iio/adc/ti-adc128s052.c +4
-0+ { }, };MODULE_DEVICE_TABLE (of, adc128_of_match);@@ -220,6 +232,9 @@ static const struct spi_device_id adc128_id[] = { { "adc124s051", (kernel_ulong_t)&adc128_config[2] }, { "adc124s101", (kernel_ulong_t)&adc128_config[2] }, { "bd79104", (kernel_ulong_t)&adc128_config[3] }, + { "adc121s021", (kernel_ulong_t)&adc128_config[4] }, + { "adc121s051", (kernel_ulong_t)&adc128_config[4] }, + { "adc121s101", (kernel_ulong_t)&adc128_config[4] }, { } };MODULE_DEVICE_TABLE (spi, adc128_id);
PATCH 2/2 iio: adc: ti-adc128s052: replace literal by unit expression
In reply to Lothar RubuschReplace the literal number 1000 by MILLI from linux/units.h
--- drivers/iio/adc/ti-adc128s052.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/iio/adc/ti-adc128s052.c +2 -1
@@ -18,6 +18,7 @@#include <linux/property.h> #include <linux/regulator/consumer.h> #include <linux/spi/spi.h> +#include <linux/units.h> struct adc128_configuration {const struct iio_chan_spec *channels;
@@ -189,7 +190,7 @@ static int adc128_probe(struct spi_device *spi)"failed to read '%s' voltage" , config->refname); - adc->vref_mv = ret /1000 ; + adc->vref_mv = ret /MILLI ;if (config->num_other_regulators) { ret = devm_regulator_bulk_get_enable(&spi->dev,
Signature · 1 line
2.39.5
Re: [PATCH v1 2/2] iio: adc: ti-adc128s052: replace literal by unit expression
Quoted 1 line · Lothar Rubusch
Replace the literal number 1000 by MILLI from
linux/units.h
Yeah, but with this units (mV, uV, mA, uA) it would probably better to have dedicated definitions, like we have for Hz, s and maybe something else (bytes?).
Signature · 2 lines
With Best Regards, Andy Shevchenko
Jonathan Cameron
maintainerRe: [PATCH v1 2/2] iio: adc: ti-adc128s052: replace literal by unit expression
Quoted 6 lines · On Wed, 25 Jun 2025 20:57:37 +0300 Andy Shevchenko…
Quoted 1 line · Lothar Rubusch
Replace the literal number 1000 by MILLI from
linux/units.hYeah, but with this units (mV, uV, mA, uA) it would probably better to have dedicated definitions, like we have for Hz, s and maybe something else (bytes?).
I'm not that keen on us getting loads unit specific conversion factors.
From a code readability point of view (given my wish to avoid lots and lots of unit specific defines) I'd favour using MICRO / MILLI here and let the compiler resolve that to 1000
Quoted 1 line
Matti Vaittinen
maintainerRe: [PATCH v1 2/2] iio: adc: ti-adc128s052: replace literal by unit expression
In reply to Lothar RubuschQuoted 20 lines · Lothar Rubusch
Replace the literal number 1000 by MILLI from
linux/units.hSigned-off-by Lothar Rubusch <[email protected]>--- drivers/iio/adc/ti-adc128s052.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/iio/adc/ti-adc128s052.c +1
-0@@ -18,6 +18,7 @@#include <linux/property.h> #include <linux/regulator/consumer.h> #include <linux/spi/spi.h> +#include <linux/units.h> struct adc128_configuration {const struct iio_chan_spec *channels;
drivers/iio/adc/ti-adc128s052.c static int adc128_probe(struct spi_device *spi) · line 193
Quoted 5 lines
drivers/iio/adc/ti-adc128s052.c +1
-1@@ -189,7 +190,7 @@ static int adc128_probe(struct spi_device *spi)"failed to read '%s' voltage" , config->refname); - adc->vref_mv = ret /1000 ; + adc->vref_mv = ret /MILLI ;
This makes no sense to me. What does it mean we divide the micro volts by 'milli'? It is clear when we divide micro volts by 1000 that we get milli volts. Also, the mv suffix in variable makes units clear already, division by MILLI just obfuscates things. I'd keep it as 1000.
I would just drop this unless Jonathan disagrees.
Yours,
-- Matti
Jonathan Cameron
maintainerRe: [PATCH v1 2/2] iio: adc: ti-adc128s052: replace literal by unit expression
Quoted 24 lines · On Thu, 26 Jun 2025 08:07:19 +0300 Matti Vaittinen <[email protected]>…
Quoted 23 lines · Lothar Rubusch
Replace the literal number 1000 by MILLI from
linux/units.hSigned-off-by Lothar Rubusch <[email protected]>--- drivers/iio/adc/ti-adc128s052.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/iio/adc/ti-adc128s052.c +1
-0@@ -18,6 +18,7 @@#include <linux/property.h> #include <linux/regulator/consumer.h> #include <linux/spi/spi.h> +#include <linux/units.h> struct adc128_configuration {const struct iio_chan_spec *channels;@@ -189,7 +190,7 @@ static int adc128_probe(struct spi_device *spi)"failed to read '%s' voltage" , config->refname);
Quoted 8 lines
drivers/iio/adc/ti-adc128s052.c static int adc128_probe(struct spi_device *spi) · line 193
Quoted 2 lines
drivers/iio/adc/ti-adc128s052.c +1
-1- adc->vref_mv = ret /1000 ; + adc->vref_mv = ret /MILLI ;This makes no sense to me. What does it mean we divide the micro volts by 'milli'? It is clear when we divide micro volts by 1000 that we get milli volts. Also, the mv suffix in variable makes units clear already, division by MILLI just obfuscates things. I'd keep it as 1000.
ret / (MICRO / MILLI) would be more descriptive as indicates we are converting form microvolts to milivolts.
Quoted 4 lines
I would just drop this unless Jonathan disagrees.
Yours,
-- Matti