tpm_crb_ffa: Remove unused export
Subsystems (4)
Jarkko Sakkinen
maintainerPATCH 1/1 tpm_crb_ffa: Remove unused export
From: Jarkko Sakkinen <[email protected]>
Remove the export of tpm_crb_ffa_get_interface_version() as it has no callers outside tpm_crb_ffa.
--- drivers/char/tpm/tpm_crb_ffa.c | 3 +-- drivers/char/tpm/tpm_crb_ffa.h | 2 -- 2 files changed, 1 insertion(+), 4 deletions(-)
drivers/char/tpm/tpm_crb_ffa.c +1 -2
@@ -247,7 +247,7 @@ static int __tpm_crb_ffa_send_recieve(unsigned long func_id,* * Return: 0 on success, negative error code on failure. */ -int tpm_crb_ffa_get_interface_version (u16 *major,u16 *minor) +static int tpm_crb_ffa_get_interface_version (u16 *major,u16 *minor) {int rc;
@@ -275,7 +275,6 @@ int tpm_crb_ffa_get_interface_version(u16 *major, u16 *minor)return rc; } -EXPORT_SYMBOL_GPL (tpm_crb_ffa_get_interface_version);/** * tpm_crb_ffa_start() - signals the TPM that a field has changed in the CRB
drivers/char/tpm/tpm_crb_ffa.h +0 -2
@@ -11,11 +11,9 @@#if IS_REACHABLE (CONFIG_TCG_ARM_CRB_FFA )int tpm_crb_ffa_init (void ); -int tpm_crb_ffa_get_interface_version (u16 *major,u16 *minor);int tpm_crb_ffa_start (int request_type,int locality);#else static inline int tpm_crb_ffa_init (void ) {return 0 ; } -static inline int tpm_crb_ffa_get_interface_version (u16 *major,u16 *minor) {return 0 ; }static inline int tpm_crb_ffa_start (int request_type,int locality) {return 0 ; }#endif
Signature · 1 line
2.39.5
Greg KH
maintainerQuoted 6 lines · Jarkko Sakkinen
From: Jarkko Sakkinen <[email protected]>
Remove the export of
tpm_crb_ffa_get_interface_version()as it has no callers outsidetpm_crb_ffa.Cc [email protected] # v6.15+
Why is this marked for stable trees as a fix? Seems to just be a normal cleanup patch to me, what am I missing?
thanks,
greg k-h
Jarkko Sakkinen
maintainerQuoted 10 lines · Greg KH
Quoted 6 lines · Jarkko Sakkinen
From: Jarkko Sakkinen <[email protected]>
Remove the export of
tpm_crb_ffa_get_interface_version()as it has no callers outsidetpm_crb_ffa.Cc [email protected] # v6.15+Why is this marked for stable trees as a fix? Seems to just be a normal cleanup patch to me, what am I missing?
unintentional, i added it as a reflex (was going to add the fixes tag for bookmark/reference)
Quoted 4 lines
thanks,
greg k-h
BR, Jarkko
[...]
Look good to me. Feel free to add:
Thanks!
--
Sincerely,
Yeoreum Yun
Jarkko Sakkinen
maintainerQuoted 11 lines · Yeoreum Yun
[...]
Look good to me. Feel free to add:
Reviewed-by Yeoreum Yun <[email protected]>Thanks!
--
Sincerely,
Yeoreum Yun
Thanks!
BR, Jarkko