bond: fix stack smash in xstats
PATCH 1/1 bond: fix stack smash in xstats
Building with stack smashing detection finds an off by one in the bond xstats attribute parsing.
$ ip link xstats type bond dev bond0
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
bond0
LACPDU Rx 0
LACPDU Tx 0
LACPDU Unknown type Rx 0
LACPDU Illegal Rx 0
Marker Rx 0
Marker Tx 0
Marker response Rx 0
Marker response Tx 0
Marker unknown type Rx 0
*** stack smashing detected ***: terminatedProgram received signal SIGABRT, Aborted.
Reported-by z30015464 <[email protected]>
Fixes 440c5075d662 ("ip: bond: add xstats support")
Signed-off-by Stephen Hemminger <[email protected]>
--- ip/iplink_bond.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ip/iplink_bond.c +1 -1
@@ -852,7 +852,7 @@ static void bond_print_stats_attr(struct rtattr *attr, int ifindex)const char *ifname ="" ;int rem; -parse_rtattr (bondtb,LINK_XSTATS_TYPE_MAX +1 ,RTA_DATA (attr), +parse_rtattr (bondtb,LINK_XSTATS_TYPE_MAX ,RTA_DATA (attr),RTA_PAYLOAD (attr));if (!bondtb[LINK_XSTATS_TYPE_BOND ])return ;
Signature · 1 line
2.47.2