scripts/gdb: Fix dentry_name() lookup
PATCH 1/1 scripts/gdb: Fix dentry_name() lookup
The "d_iname" member was replaced with "d_shortname.string" in the commit referenced in the Fixes tag. This prevented the GDB script "lx-mount" command to properly function:
(gdb) lx-mounts
mount super_block devname pathname fstype options0xff11000002d21180 0xff11000002d24800 rootfs / rootfs rw 0 0 0xff11000002e18a80 0xff11000003713000 /dev/root / ext4 rw,relatime 0 0 Python Exception <class 'gdb.error'>: There is no member named d_iname. Error occurred in Python: There is no member named d_iname.
--- scripts/gdb/linux/vfs.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/gdb/linux/vfs.py +1 -1
@@ -22,7 +22,7 @@ def dentry_name(d): if parent == d or parent == 0: return "" p = dentry_name(d['d_parent']) + "/" - return p + d['d_iname'].string() + return p + d['d_shortname']['string'].string() class DentryName(gdb.Function): """Return string of the full path of a dentry.
Signature · 1 line
2.43.0
Hi Florian,
I have previously submitted (and resent due to inactivity) an equivalent patch here:
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
However, looks like d_shortname is not suitable for entries with name longer than D_NAME_INLINE_LEN characters. Although this matches the previous behavior of the GDB script (before 58cf9c383c5c68666808), I was planning to resubmit a v2 that addresses this issue as well.
Hi Illia,
Quoted 7 lines · Illia Ostapyshyn
Hi Florian,
I have previously submitted (and resent due to inactivity) an equivalent patch here:
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
Ah my bad, I had not seen your submission, then it should be taken instead of mine, but with the Fixes: tag added so that your patch can get back ported to stable trees.
Quoted 5 lines
However, looks like
d_shortnameis not suitable for entries with name longer thanD_NAME_INLINE_LENcharacters. Although this matches the previous behavior of the GDB script (before58cf9c383c5c68666808), I was planning to resubmit a v2 that addresses this issue as well.
Sure, please do! Andrew can you drop my patch in favor of Illia's when it shows up?
Signature · 1 line
Florian
Quoted 16 lines · On Thu, 26 Jun 2025 10:19:25 -0700 Florian Fainelli…
Hi Illia,
Quoted 7 lines · Illia Ostapyshyn
Hi Florian,
I have previously submitted (and resent due to inactivity) an equivalent patch here:
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/Ah my bad, I had not seen your submission, then it should be taken instead of mine, but with the Fixes: tag added so that your patch can get back ported to stable trees.
Quoted 1 line
Quoted 7 lines
Quoted 4 lines
However, looks like
d_shortnameis not suitable for entries with name longer thanD_NAME_INLINE_LENcharacters. Although this matches the previous behavior of the GDB script (before58cf9c383c5c68666808), I was planning to resubmit a v2 that addresses this issue as well.Sure, please do! Andrew can you drop my patch in favor of Illia's when it shows up?
I've moved your "scripts/gdb: Fix dentry_name() lookup" into mm.git's non-rebasing mm-hotfixes-stable branch in preparation for upstreaming today or tomorrow. So I'd prefer not to mess with it now.
Illia, can you please propose your fix against a tree which contains Florian's patch?