Skip to contentSkip to conversation

json-c: Remove icecc specific comment

PATCH New Moritz Haase 1 participant 1 message Jun 27, 2025

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 json-c: Remove icecc specific comment

6481e8b209b ("json-c: fix icecc compilation") disabled '-Werror' unconditionally for all compilers. We want to keep it disabled to reduce efforts when updating or adding support for new toolchains (see [0]), but since support for icecc has been removed via ba4fd5229893 ("classes/recipes-devtools: Drop icecc from OE-Core") recently, we can drop the comment referencing it.

[0]: https://lists.openembedded.org/g/openembedded-core/message/219364

---

changes in v2:

- Re-enabled '-Werror' as suggested in [0], updated commit title/message accordingly.

---

 meta/recipes-devtools/json-c/json-c_0.18.bb | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
meta/recipes-devtools/json-c/json-c_0.18.bb +1 -2
index ece320d66ce1f03ce0c8655374c02c283a9364dd..c112aacf4bceb0c41dbe2e1643d2d7e0944bf250 100644
@@ -19,8 +19,7 @@ UPSTREAM_CHECK_REGEX = "json-c-(?P<pver>\d+(\.\d+)+)-\d+"
 
 RPROVIDES:${PN} = "libjson"
 
-# - '-Werror' must be disabled for ICECC builds
-# - Apps aren't needed/packaged and their CMakeLists.txt is incompatible with CMake 4+.
+# Apps aren't needed/packaged and their CMakeLists.txt is incompatible with CMake 4+.
 EXTRA_OECMAKE = "-DDISABLE_WERROR=ON \
                  -DBUILD_APPS=OFF \
 "