libnvdimm: Don't use "proxy" headers
PATCH v2 1/1 libnvdimm: Don't use "proxy" headers
Update header inclusions to follow IWYU (Include What You Use) principle.
Note that kernel.h is discouraged to be included as it's written at the top of that file.
While doing that, sort headers alphabetically.
---
v2: reshuffled includes and forward declarations (Ira)
include/linux/libnvdimm.h | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-)
include/linux/libnvdimm.h +10 -5
@@ -6,12 +6,12 @@*/ #ifndef __LIBNVDIMM_H__ #define __LIBNVDIMM_H__ -#include <linux/kernel.h> + +#include <linux/io.h> #include <linux/sizes.h> +#include <linux/spinlock.h> #include <linux/types.h> #include <linux/uuid.h> -#include <linux/spinlock.h> -#include <linux/bio.h> struct badrange_entry { u64 start;
@@ -80,7 +80,9 @@ typedef int (*ndctl_fn)(struct nvdimm_bus_descriptor *nd_desc, struct nvdimm *nvdimm, unsigned int cmd, void *buf, unsigned int buf_len, int *cmd_rc); +struct attribute_group ;struct device_node ; +struct module ;struct nvdimm_bus_descriptor {const struct attribute_group **attr_groups;unsigned long cmd_mask;
@@ -121,6 +123,8 @@ struct nd_mapping_desc {int position; }; +struct bio ; +struct resource ;struct nd_region ;struct nd_region_desc {struct resource *res;
@@ -147,8 +151,6 @@ static inline void __iomem *devm_nvdimm_ioremap(struct device *dev,return (void __iomem *)devm_nvdimm_memremap (dev, offset, size,0 ); } -struct nvdimm_bus ; -/* * Note that separate bits for locked + unlocked are defined so that * 'flags == 0' corresponds to an error / not-supported state.
@@ -238,6 +240,9 @@ struct nvdimm_fw_ops {int (*arm)(struct nvdimm *nvdimm,enum nvdimm_fwa_trigger arg); }; +struct kobject ; +struct nvdimm_bus ; +void badrange_init (struct badrange *badrange);int badrange_add (struct badrange *badrange,u64 addr,u64 length); void badrange_forget(struct badrange *badrange, phys_addr_t start,
Signature · 1 line
2.47.2
Quoted 9 lines · Andy Shevchenko
Update header inclusions to follow IWYU (Include What You Use) principle.
Note that
kernel.his discouraged to be included as it's written at the top of that file.While doing that, sort headers alphabetically.
Signed-off-by Andy Shevchenko <[email protected]>
Quoted 65 lines
---
v2: reshuffled includes and forward declarations (Ira)
include/linux/libnvdimm.h | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-)include/linux/libnvdimm.h +10
-5@@ -6,12 +6,12 @@*/ #ifndef __LIBNVDIMM_H__ #define __LIBNVDIMM_H__ -#include <linux/kernel.h> + +#include <linux/io.h> #include <linux/sizes.h> +#include <linux/spinlock.h> #include <linux/types.h> #include <linux/uuid.h> -#include <linux/spinlock.h> -#include <linux/bio.h> struct badrange_entry { u64 start;@@ -80,7 +80,9 @@ typedef int (*ndctl_fn)(struct nvdimm_bus_descriptor *nd_desc, struct nvdimm *nvdimm, unsigned int cmd, void *buf, unsigned int buf_len, int *cmd_rc); +struct attribute_group ;struct device_node ; +struct module ;struct nvdimm_bus_descriptor {const struct attribute_group **attr_groups;unsigned long cmd_mask;@@ -121,6 +123,8 @@ struct nd_mapping_desc {int position; }; +struct bio ; +struct resource ;struct nd_region ;struct nd_region_desc {struct resource *res;@@ -147,8 +151,6 @@ static inline void __iomem *devm_nvdimm_ioremap(struct device *dev,return (void __iomem *)devm_nvdimm_memremap (dev, offset, size,0 ); } -struct nvdimm_bus ; -/* * Note that separate bits for locked + unlocked are defined so that * 'flags == 0' corresponds to an error / not-supported state. @@ -238,6 +240,9 @@ struct nvdimm_fw_ops {int (*arm)(struct nvdimm *nvdimm,enum nvdimm_fwa_trigger arg); }; +struct kobject ; +struct nvdimm_bus ; +void badrange_init (struct badrange *badrange);int badrange_add (struct badrange *badrange,u64 addr,u64 length); void badrange_forget(struct badrange *badrange, phys_addr_t start,
Ira Weiny
AppliedQuoted 9 lines · Andy Shevchenko
Update header inclusions to follow IWYU (Include What You Use) principle.
Note that
kernel.his discouraged to be included as it's written at the top of that file.While doing that, sort headers alphabetically.
[...]
Applied, thanks!
[1/1] libnvdimm: Don't use "proxy" headers
commit: 536f5941adde41c99a18a0ba03b457adc9702ab8
Best regards,
Signature · 1 line
Ira Weiny <[email protected]>
Ira Weiny
AppliedQuoted 9 lines · Andy Shevchenko
Update header inclusions to follow IWYU (Include What You Use) principle.
Note that
kernel.his discouraged to be included as it's written at the top of that file.While doing that, sort headers alphabetically.
[...]
Applied, thanks!
[1/1] libnvdimm: Don't use "proxy" headers
commit: 536f5941adde41c99a18a0ba03b457adc9702ab8
Best regards,
Signature · 1 line
Ira Weiny <[email protected]>