Skip to contentSkip to conversation

drm: xlnx: zynqmp_dp: Support DRM_FORMAT_XRGB8888

PATCH In review Mike Looijmans 7 participants 22 messages Jun 27, 2025 – Nov 13, 2025 1 message not in the archive

Subsystems (4)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.fb98a918-329e-4536-a0a5-a99b22ba0120@emailsignatures365.codetwo.com

#1 lore raw

PATCH 1/1 drm: xlnx: zynqmp_dp: Support DRM_FORMAT_XRGB8888

XRGB8888 is the default mode that Xorg will want to use. Add support for this to the Zynqmp DisplayPort driver, so that applications can use 32-bit framebuffers. This solves that the X server would fail to start unless one provided an xorg.conf that sets DefaultDepth to 16.

---

 drivers/gpu/drm/xlnx/zynqmp_disp.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/gpu/drm/xlnx/zynqmp_disp.c +5 -0
index 80d1e499a18d..501428437000 100644
@@ -312,6 +312,11 @@ static const struct zynqmp_disp_format avbuf_gfx_fmts[] = {
 		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
 		.swap		= true,
 		.sf		= scaling_factors_888,
+	}, {
+		.drm_fmt	= DRM_FORMAT_XRGB8888,
+		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
+		.swap		= true,
+		.sf		= scaling_factors_888,
 	}, {
 		.drm_fmt	= DRM_FORMAT_RGBA8888,
 		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_ABGR8888,
Signature · 20 lines
2.43.0

base-commit: 67a993863163cb88b1b68974c31b0d84ece4293e
branch: linux-master-zynqmpdp-32bit

Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert


TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: [email protected]
W: www.topic.nl

Please consider the environment before printing this e-mail
maintainer
#2 lore raw

Hi Mike,

Thank you for the patch.

Quoted 16 lines · Mike Looijmans

XRGB8888 is the default mode that Xorg will want to use. Add support for this to the Zynqmp DisplayPort driver, so that applications can use 32-bit framebuffers. This solves that the X server would fail to start unless one provided an xorg.conf that sets DefaultDepth to 16.

---

 drivers/gpu/drm/xlnx/zynqmp_disp.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/gpu/drm/xlnx/zynqmp_disp.c +0 -0
index 80d1e499a18d..501428437000 100644

drivers/gpu/drm/xlnx/zynqmp_disp.c static const struct zynqmp_disp_format avbuf_gfx_fmts[] = { · line 319

Quoted 8 lines
drivers/gpu/drm/xlnx/zynqmp_disp.c +5 -0
@@ -312,6 +312,11 @@ static const struct zynqmp_disp_format avbuf_gfx_fmts[] = {
 		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
 		.swap		= true,
 		.sf		= scaling_factors_888,
+	}, {
+		.drm_fmt	= DRM_FORMAT_XRGB8888,
+		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
+		.swap		= true,
+		.sf		= scaling_factors_888,

I'm afraid that's not enough. There's a crucial difference between DRM_FORMAT_ARGB8888 (already supported by this driver) and
DRM_FORMAT_XRGB8888: for the latter, the 'X' component must be ignored. The graphics layer is blended on top of the video layer, and the blender uses both a global alpha parameter and the alpha channel of the graphics layer for 32-bit RGB formats. This will lead to incorrect operation when the 'X' component is not set to full opacity.

Quoted 3 lines
drivers/gpu/drm/xlnx/zynqmp_disp.c +0 -0
 	}, {
 		.drm_fmt	= DRM_FORMAT_RGBA8888,
 		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_ABGR8888,
Signature · 3 lines
Regards,

Laurent Pinchart
#3 lore raw
Quoted 28 lines · Laurent Pinchart

Hi Mike,

Thank you for the patch.

Quoted 23 lines · Mike Looijmans

XRGB8888 is the default mode that Xorg will want to use. Add support for this to the Zynqmp DisplayPort driver, so that applications can use 32-bit framebuffers. This solves that the X server would fail to start unless one provided an xorg.conf that sets DefaultDepth to 16.

---

  drivers/gpu/drm/xlnx/zynqmp_disp.c | 5 +++++
  1 file changed, 5 insertions(+)
drivers/gpu/drm/xlnx/zynqmp_disp.c +4 -0
index 80d1e499a18d..501428437000 100644
@@ -312,6 +312,11 @@ static const struct zynqmp_disp_format avbuf_gfx_fmts[] = {
  		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
  		.swap		= true,
  		.sf		= scaling_factors_888,
+	}, {
+		.drm_fmt	= DRM_FORMAT_XRGB8888,
+		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
+		.swap		= true,
Quoted 8 lines

drivers/gpu/drm/xlnx/zynqmp_disp.c static const struct zynqmp_disp_format avbuf_gfx_fmts[] = { · line 319

Quoted 1 line
drivers/gpu/drm/xlnx/zynqmp_disp.c +1 -0
+		.sf		= scaling_factors_888,

I'm afraid that's not enough. There's a crucial difference between DRM_FORMAT_ARGB8888 (already supported by this driver) and
DRM_FORMAT_XRGB8888: for the latter, the 'X' component must be ignored. The graphics layer is blended on top of the video layer, and the blender uses both a global alpha parameter and the alpha channel of the graphics layer for 32-bit RGB formats. This will lead to incorrect operation when the 'X' component is not set to full opacity.

I spent a few hours digging in the source code and what I could find in the TRM and register maps, but there's not enough information in there to explain how the blender works. The obvious "XRGB" implementation would be to just disable the blender.

What I got from experimenting so far is that the alpha component is ignored anyway while the video path isn't active. So as long as one isn't using the video blending path, the ARGB and XRGB modes are identical.

Guess I'll need assistance from AMD/Xilinx to completely implement the XRGB modes.

(For our application, this patch is sufficient as it solves the issues like X11 not starting up, OpenGL not working and horrendously slow scaling performance)

Quoted 4 lines
Quoted 4 lines
drivers/gpu/drm/xlnx/zynqmp_disp.c +0 -0
  	}, {
  		.drm_fmt	= DRM_FORMAT_RGBA8888,
  		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_ABGR8888,
Signature · 10 lines
Mike Looijmans
System Expert

TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: [email protected]
W: www.topic.nl
maintainer
#4 lore raw
Quoted 35 lines · Mike Looijmans
Quoted 26 lines · Laurent Pinchart
Quoted 16 lines · Mike Looijmans

XRGB8888 is the default mode that Xorg will want to use. Add support for this to the Zynqmp DisplayPort driver, so that applications can use 32-bit framebuffers. This solves that the X server would fail to start unless one provided an xorg.conf that sets DefaultDepth to 16.

---

  drivers/gpu/drm/xlnx/zynqmp_disp.c | 5 +++++
  1 file changed, 5 insertions(+)
drivers/gpu/drm/xlnx/zynqmp_disp.c +0 -0
index 80d1e499a18d..501428437000 100644

drivers/gpu/drm/xlnx/zynqmp_disp.c static const struct zynqmp_disp_format avbuf_gfx_fmts[] = { · line 319

Quoted 8 lines
drivers/gpu/drm/xlnx/zynqmp_disp.c +5 -0
@@ -312,6 +312,11 @@ static const struct zynqmp_disp_format avbuf_gfx_fmts[] = {
  		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
  		.swap		= true,
  		.sf		= scaling_factors_888,
+	}, {
+		.drm_fmt	= DRM_FORMAT_XRGB8888,
+		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
+		.swap		= true,
+		.sf		= scaling_factors_888,
Quoted 7 lines

I'm afraid that's not enough. There's a crucial difference between DRM_FORMAT_ARGB8888 (already supported by this driver) and
DRM_FORMAT_XRGB8888: for the latter, the 'X' component must be ignored. The graphics layer is blended on top of the video layer, and the blender uses both a global alpha parameter and the alpha channel of the graphics layer for 32-bit RGB formats. This will lead to incorrect operation when the 'X' component is not set to full opacity.

Quoted 4 lines

I spent a few hours digging in the source code and what I could find in the TRM and register maps, but there's not enough information in there to explain how the blender works. The obvious "XRGB" implementation would be to just disable the blender.

That won't work when using global alpha unfortunately :-(

Quoted 3 lines

What I got from experimenting so far is that the alpha component is ignored anyway while the video path isn't active. So as long as one isn't using the video blending path, the ARGB and XRGB modes are identical.

Correct, *if* global alpha is set to full opaque, then you can disable the blender. That could confuse userspace though, enabling the graphics plane with XRGB would work, and then enabling the video plane with global alpha would fail.

Quoted 2 lines

Guess I'll need assistance from AMD/Xilinx to completely implement the XRGB modes.

The blender can ignore the alpha channel of the graphics plane for formats that have no alpha channel. It would be nice if there was a bit to force that behaviour for 32-bit RGB too, but I couldn't find any :-( It's worth asking though.

Quoted 7 lines

(For our application, this patch is sufficient as it solves the issues like X11 not starting up, OpenGL not working and horrendously slow scaling performance)

Quoted 3 lines
Quoted 3 lines
drivers/gpu/drm/xlnx/zynqmp_disp.c +0 -0
  	}, {
  		.drm_fmt	= DRM_FORMAT_RGBA8888,
  		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_ABGR8888,
Signature · 3 lines
Regards,

Laurent Pinchart
#5 lore raw
Quoted 48 lines · Laurent Pinchart
Quoted 33 lines · Mike Looijmans
Quoted 24 lines · Laurent Pinchart
Quoted 23 lines · Mike Looijmans

XRGB8888 is the default mode that Xorg will want to use. Add support for this to the Zynqmp DisplayPort driver, so that applications can use 32-bit framebuffers. This solves that the X server would fail to start unless one provided an xorg.conf that sets DefaultDepth to 16.

---

   drivers/gpu/drm/xlnx/zynqmp_disp.c | 5 +++++
   1 file changed, 5 insertions(+)
drivers/gpu/drm/xlnx/zynqmp_disp.c +4 -0
index 80d1e499a18d..501428437000 100644
@@ -312,6 +312,11 @@ static const struct zynqmp_disp_format avbuf_gfx_fmts[] = {
   		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
   		.swap		= true,
   		.sf		= scaling_factors_888,
+	}, {
+		.drm_fmt	= DRM_FORMAT_XRGB8888,
+		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
+		.swap		= true,
Quoted 8 lines

drivers/gpu/drm/xlnx/zynqmp_disp.c static const struct zynqmp_disp_format avbuf_gfx_fmts[] = { · line 319

Quoted 1 line
drivers/gpu/drm/xlnx/zynqmp_disp.c +1 -0
+		.sf		= scaling_factors_888,

I'm afraid that's not enough. There's a crucial difference between DRM_FORMAT_ARGB8888 (already supported by this driver) and
DRM_FORMAT_XRGB8888: for the latter, the 'X' component must be ignored. The graphics layer is blended on top of the video layer, and the blender uses both a global alpha parameter and the alpha channel of the graphics layer for 32-bit RGB formats. This will lead to incorrect operation when the 'X' component is not set to full opacity.

Quoted 4 lines

I spent a few hours digging in the source code and what I could find in the TRM and register maps, but there's not enough information in there to explain how the blender works. The obvious "XRGB" implementation would be to just disable the blender.

That won't work when using global alpha unfortunately :-(

Quoted 3 lines

What I got from experimenting so far is that the alpha component is ignored anyway while the video path isn't active. So as long as one isn't using the video blending path, the ARGB and XRGB modes are identical.

Correct, *if* global alpha is set to full opaque, then you can disable the blender. That could confuse userspace though, enabling the graphics plane with XRGB would work, and then enabling the video plane with global alpha would fail.

Quoted 6 lines
Quoted 2 lines

Guess I'll need assistance from AMD/Xilinx to completely implement the XRGB modes.

The blender can ignore the alpha channel of the graphics plane for formats that have no alpha channel. It would be nice if there was a bit to force that behaviour for 32-bit RGB too, but I couldn't find any :-( It's worth asking though.

Yes, my problem exactly.

Quoted 8 lines
Quoted 8 lines

(For our application, this patch is sufficient as it solves the issues like X11 not starting up, OpenGL not working and horrendously slow scaling performance)

Quoted 3 lines
Quoted 3 lines
drivers/gpu/drm/xlnx/zynqmp_disp.c +0 -0
   	}, {
   		.drm_fmt	= DRM_FORMAT_RGBA8888,
   		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_ABGR8888,
Signature · 10 lines
Mike Looijmans
System Expert

TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: [email protected]
W: www.topic.nl
#6 lore raw

[AMD Official Use Only - AMD Internal Distribution Only]

Hi Mike,

Quoted 62 lines

-----Original Message-----
From: dri-devel <[email protected]> On Behalf Of Mike Looijmans
Sent: Monday, June 30, 2025 7:49 AM
To: Laurent Pinchart <[email protected]>
Cc: [email protected]; David Airlie <[email protected]>; Maarten Lankhorst <[email protected]>; Maxime Ripard <[email protected]>; Simek, Michal <[email protected]>; Simona Vetter <[email protected]>; Thomas Zimmermann <[email protected]>; Tomi Valkeinen <[email protected]>; linux-arm- [email protected]; [email protected]
Subject: Re: [PATCH] drm: xlnx: zynqmp_dp: Support DRM_FORMAT_XRGB8888

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.

Quoted 8 lines · Laurent Pinchart
Quoted 7 lines · Mike Looijmans
Quoted 6 lines · Laurent Pinchart
Quoted 5 lines · Mike Looijmans

XRGB8888 is the default mode that Xorg will want to use. Add support for this to the Zynqmp DisplayPort driver, so that applications can use 32-bit framebuffers. This solves that the X server would fail to start unless one provided an xorg.conf that sets DefaultDepth to 16.

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

Review

Quoted 7 lines

---

   drivers/gpu/drm/xlnx/zynqmp_disp.c | 5 +++++
   1 file changed, 5 insertions(+)
(quoted diff) +0 -0

b/drivers/gpu/drm/xlnx/zynqmp_disp.c

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

drivers/gpu/drm/xlnx/zynqmp_disp.c static const struct zynqmp_disp_format

Quoted 4 lines

index 80d1e499a18d..501428437000 100644

drivers/gpu/drm/xlnx/zynqmp_disp.c +0 -0
@@ -312,6 +312,11 @@ static const struct zynqmp_disp_format

avbuf_gfx_fmts[] = {

Quoted 1 line
Quoted 1 line
Quoted 1 line

drivers/gpu/drm/xlnx/zynqmp_disp.c static const struct zynqmp_disp_format · line 312

Quoted 1 line
drivers/gpu/drm/xlnx/zynqmp_disp.c +0 -0
                   .buf_fmt        =

ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

drivers/gpu/drm/xlnx/zynqmp_disp.c static const struct zynqmp_disp_format avbuf_gfx_fmts[] = {

Quoted 5 lines
drivers/gpu/drm/xlnx/zynqmp_disp.c +3 -0
                   .swap           = true,
                   .sf             = scaling_factors_888,
+  }, {
+          .drm_fmt        = DRM_FORMAT_XRGB8888,
+          .buf_fmt        =

ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

drivers/gpu/drm/xlnx/zynqmp_disp.c static const struct zynqmp_disp_format avbuf_gfx_fmts[] = { · line 319

Quoted 2 lines
drivers/gpu/drm/xlnx/zynqmp_disp.c +2 -0
+          .swap           = true,
+          .sf             = scaling_factors_888,

I'm afraid that's not enough. There's a crucial difference between DRM_FORMAT_ARGB8888 (already supported by this driver) and
DRM_FORMAT_XRGB8888: for the latter, the 'X' component must be

ignored.

Quoted 8 lines
Quoted 8 lines
Quoted 4 lines

The graphics layer is blended on top of the video layer, and the blender uses both a global alpha parameter and the alpha channel of the graphics layer for 32-bit RGB formats. This will lead to incorrect operation when the 'X' component is not set to full opacity.

I spent a few hours digging in the source code and what I could find in the TRM and register maps, but there's not enough information in there to explain how the blender works. The obvious "XRGB" implementation would be to just disable the blender.

Quoted 18 lines
Quoted 5 lines

That won't work when using global alpha unfortunately :-(

Quoted 3 lines

What I got from experimenting so far is that the alpha component is ignored anyway while the video path isn't active. So as long as one isn't using the video blending path, the ARGB and XRGB modes are

identical.

Quoted 11 lines

Correct, *if* global alpha is set to full opaque, then you can disable the blender. That could confuse userspace though, enabling the graphics plane with XRGB would work, and then enabling the video plane with global alpha would fail.

Quoted 2 lines

Guess I'll need assistance from AMD/Xilinx to completely implement the XRGB modes.

The blender can ignore the alpha channel of the graphics plane for formats that have no alpha channel. It would be nice if there was a bit to force that behaviour for 32-bit RGB too, but I couldn't find any :-( It's worth asking though.

Unfortunately, there are no such explicit flag on the HW side. Although, some blender modes may turn off per-pixel alpha as a side effect. Let me check if I can find some trick to make it happen.

Quoted 18 lines

Yes, my problem exactly.

Quoted 8 lines
Quoted 8 lines

(For our application, this patch is sufficient as it solves the issues like X11 not starting up, OpenGL not working and horrendously slow scaling performance)

Quoted 3 lines
Quoted 3 lines
drivers/gpu/drm/xlnx/zynqmp_disp.c +0 -0
           }, {
                   .drm_fmt        = DRM_FORMAT_RGBA8888,
                   .buf_fmt        =

ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_ABGR8888,

--
Mike Looijmans
System Expert

Quoted 9 lines

TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: [email protected]
W: www.topic.nl

--
Thank you,
Anatoliy

#7 lore raw

[AMD Official Use Only - AMD Internal Distribution Only]

Hi All,

Quoted 99 lines

-----Original Message-----
From: Klymenko, Anatoliy
Sent: Monday, June 30, 2025 6:03 PM
To: Mike Looijmans <[email protected]>; Laurent Pinchart <[email protected]>
Cc: [email protected]; David Airlie <[email protected]>; Maarten Lankhorst <[email protected]>; Maxime Ripard <[email protected]>; Simek, Michal <[email protected]>; Simona Vetter <[email protected]>; Thomas Zimmermann <[email protected]>; Tomi Valkeinen <[email protected]>; linux-arm- [email protected]; [email protected]
Subject: RE: [PATCH] drm: xlnx: zynqmp_dp: Support DRM_FORMAT_XRGB8888

Hi Mike,

Quoted 6 lines

-----Original Message-----
From: dri-devel <[email protected]> On Behalf Of Mike Looijmans
Sent: Monday, June 30, 2025 7:49 AM
To: Laurent Pinchart <[email protected]>
Cc: [email protected]; David Airlie <[email protected]>;

Maarten

Quoted 9 lines

Lankhorst <[email protected]>; Maxime Ripard <[email protected]>; Simek, Michal <[email protected]>; Simona Vetter <[email protected]>; Thomas Zimmermann <[email protected]>; Tomi Valkeinen <[email protected]>; linux-arm- [email protected]; [email protected]
Subject: Re: [PATCH] drm: xlnx: zynqmp_dp: Support DRM_FORMAT_XRGB8888

Caution: This message originated from an External Source. Use proper

caution

Quoted 47 lines

when opening attachments, clicking links, or responding.

Quoted 8 lines · Laurent Pinchart
Quoted 7 lines · Mike Looijmans
Quoted 6 lines · Laurent Pinchart
Quoted 5 lines · Mike Looijmans

XRGB8888 is the default mode that Xorg will want to use. Add support for this to the Zynqmp DisplayPort driver, so that applications can use 32-bit framebuffers. This solves that the X server would fail to start unless one provided an xorg.conf that sets DefaultDepth to 16.

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

Review

Quoted 7 lines

---

   drivers/gpu/drm/xlnx/zynqmp_disp.c | 5 +++++
   1 file changed, 5 insertions(+)
(quoted diff) +0 -0

b/drivers/gpu/drm/xlnx/zynqmp_disp.c

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

drivers/gpu/drm/xlnx/zynqmp_disp.c static const struct zynqmp_disp_format

Quoted 4 lines

index 80d1e499a18d..501428437000 100644

drivers/gpu/drm/xlnx/zynqmp_disp.c +0 -0
@@ -312,6 +312,11 @@ static const struct zynqmp_disp_format

avbuf_gfx_fmts[] = {

Quoted 1 line
Quoted 1 line
Quoted 1 line

drivers/gpu/drm/xlnx/zynqmp_disp.c static const struct zynqmp_disp_format · line 312

Quoted 1 line
drivers/gpu/drm/xlnx/zynqmp_disp.c +0 -0
                   .buf_fmt        =

ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

drivers/gpu/drm/xlnx/zynqmp_disp.c static const struct zynqmp_disp_format avbuf_gfx_fmts[] = {

Quoted 5 lines
drivers/gpu/drm/xlnx/zynqmp_disp.c +3 -0
                   .swap           = true,
                   .sf             = scaling_factors_888,
+  }, {
+          .drm_fmt        = DRM_FORMAT_XRGB8888,
+          .buf_fmt        =

ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

drivers/gpu/drm/xlnx/zynqmp_disp.c static const struct zynqmp_disp_format avbuf_gfx_fmts[] = { · line 319

Quoted 2 lines
drivers/gpu/drm/xlnx/zynqmp_disp.c +2 -0
+          .swap           = true,
+          .sf             = scaling_factors_888,

I'm afraid that's not enough. There's a crucial difference between DRM_FORMAT_ARGB8888 (already supported by this driver) and
DRM_FORMAT_XRGB8888: for the latter, the 'X' component must be

ignored.

Quoted 8 lines
Quoted 8 lines
Quoted 4 lines

The graphics layer is blended on top of the video layer, and the blender uses both a global alpha parameter and the alpha channel of the graphics layer for 32-bit RGB formats. This will lead to incorrect operation when the 'X' component is not set to full opacity.

I spent a few hours digging in the source code and what I could find in the TRM and register maps, but there's not enough information in there to explain how the blender works. The obvious "XRGB" implementation would be to just disable the blender.

Quoted 18 lines
Quoted 5 lines

That won't work when using global alpha unfortunately :-(

Quoted 3 lines

What I got from experimenting so far is that the alpha component is ignored anyway while the video path isn't active. So as long as one isn't using the video blending path, the ARGB and XRGB modes are

identical.

Quoted 11 lines

Correct, *if* global alpha is set to full opaque, then you can disable the blender. That could confuse userspace though, enabling the graphics plane with XRGB would work, and then enabling the video plane with global alpha would fail.

Quoted 2 lines

Guess I'll need assistance from AMD/Xilinx to completely implement the XRGB modes.

The blender can ignore the alpha channel of the graphics plane for formats that have no alpha channel. It would be nice if there was a bit to force that behaviour for 32-bit RGB too, but I couldn't find any :-( It's worth asking though.

Quoted 4 lines

Unfortunately, there are no such explicit flag on the HW side. Although, some blender modes may turn off per-pixel alpha as a side effect. Let me check if I can find some trick to make it happen.

After some investigations I may confirm that this patch works, and it is safe to accept it. The ZynqMP DP blender ignores per pixel alpha if top plane alpha is enabled (which is always the case in the driver). So, AR24 is effectively treated as XR24 by the hardware.

Quoted 22 lines
Quoted 22 lines

Yes, my problem exactly.

Quoted 8 lines
Quoted 8 lines

(For our application, this patch is sufficient as it solves the issues like X11 not starting up, OpenGL not working and horrendously slow scaling performance)

Quoted 3 lines
Quoted 3 lines
drivers/gpu/drm/xlnx/zynqmp_disp.c +0 -0
           }, {
                   .drm_fmt        = DRM_FORMAT_RGBA8888,
                   .buf_fmt        =

ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_ABGR8888,

--
Mike Looijmans
System Expert

TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

Quoted 9 lines
Quoted 5 lines

T: +31 (0) 499 33 69 69
E: [email protected]
W: www.topic.nl

--
Thank you,
Anatoliy

Thank you,
Anatoliy

#8 lore raw

[AMD Official Use Only - AMD Internal Distribution Only]

Quoted 156 lines

-----Original Message-----
From: Klymenko, Anatoliy
Sent: Tuesday, October 14, 2025 1:57 PM
To: Mike Looijmans <[email protected]>; Laurent Pinchart <[email protected]>
Cc: [email protected]; David Airlie <[email protected]>; Maarten Lankhorst <[email protected]>; Maxime Ripard <[email protected]>; Simek, Michal <[email protected]>; Simona Vetter <[email protected]>; Thomas Zimmermann <[email protected]>; Tomi Valkeinen <[email protected]>; linux-arm- [email protected]; [email protected]
Subject: RE: [PATCH] drm: xlnx: zynqmp_dp: Support DRM_FORMAT_XRGB8888

Hi All,

Quoted 6 lines

-----Original Message-----
From: Klymenko, Anatoliy
Sent: Monday, June 30, 2025 6:03 PM
To: Mike Looijmans <[email protected]>; Laurent Pinchart <[email protected]>
Cc: [email protected]; David Airlie <[email protected]>;

Maarten

Quoted 8 lines

Lankhorst <[email protected]>; Maxime Ripard <[email protected]>; Simek, Michal <[email protected]>; Simona Vetter <[email protected]>; Thomas Zimmermann <[email protected]>; Tomi Valkeinen <[email protected]>; linux-arm- [email protected]; [email protected]
Subject: RE: [PATCH] drm: xlnx: zynqmp_dp: Support DRM_FORMAT_XRGB8888

Quoted 4 lines

Hi Mike,

Quoted 2 lines

-----Original Message-----
From: dri-devel <[email protected]> On Behalf Of

Mike

Quoted 8 lines
Quoted 4 lines

Looijmans
Sent: Monday, June 30, 2025 7:49 AM
To: Laurent Pinchart <[email protected]>
Cc: [email protected]; David Airlie <[email protected]>;

Maarten

Quoted 3 lines

Lankhorst <[email protected]>; Maxime Ripard <[email protected]>; Simek, Michal <[email protected]>; Simona Vetter <[email protected]>; Thomas Zimmermann

<[email protected]>;

Quoted 5 lines
Quoted 5 lines

Tomi Valkeinen <[email protected]>; linux-arm- [email protected]; [email protected]
Subject: Re: [PATCH] drm: xlnx: zynqmp_dp: Support DRM_FORMAT_XRGB8888

Quoted 43 lines
Quoted 1 line

Caution: This message originated from an External Source. Use proper

caution

Quoted 41 lines

when opening attachments, clicking links, or responding.

Quoted 8 lines · Laurent Pinchart
Quoted 7 lines · Mike Looijmans
Quoted 6 lines · Laurent Pinchart
Quoted 5 lines · Mike Looijmans

XRGB8888 is the default mode that Xorg will want to use. Add support for this to the Zynqmp DisplayPort driver, so that applications can use 32-bit framebuffers. This solves that the X server would fail to start unless one provided an xorg.conf that sets DefaultDepth to 16.

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

Review

Quoted 7 lines

---

   drivers/gpu/drm/xlnx/zynqmp_disp.c | 5 +++++
   1 file changed, 5 insertions(+)
(quoted diff) +0 -0

b/drivers/gpu/drm/xlnx/zynqmp_disp.c

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

drivers/gpu/drm/xlnx/zynqmp_disp.c static const struct zynqmp_disp_format

Quoted 4 lines

index 80d1e499a18d..501428437000 100644

drivers/gpu/drm/xlnx/zynqmp_disp.c +0 -0
@@ -312,6 +312,11 @@ static const struct zynqmp_disp_format

avbuf_gfx_fmts[] = {

Quoted 1 line
Quoted 1 line
Quoted 1 line

drivers/gpu/drm/xlnx/zynqmp_disp.c static const struct zynqmp_disp_format · line 312

Quoted 1 line
drivers/gpu/drm/xlnx/zynqmp_disp.c +0 -0
                   .buf_fmt        =

ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

drivers/gpu/drm/xlnx/zynqmp_disp.c static const struct zynqmp_disp_format · line 317

Quoted 5 lines
drivers/gpu/drm/xlnx/zynqmp_disp.c +3 -0
                   .swap           = true,
                   .sf             = scaling_factors_888,
+  }, {
+          .drm_fmt        = DRM_FORMAT_XRGB8888,
+          .buf_fmt        =

ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

drivers/gpu/drm/xlnx/zynqmp_disp.c static const struct zynqmp_disp_format · line 319

Quoted 2 lines
drivers/gpu/drm/xlnx/zynqmp_disp.c +2 -0
+          .swap           = true,
+          .sf             = scaling_factors_888,

I'm afraid that's not enough. There's a crucial difference between DRM_FORMAT_ARGB8888 (already supported by this driver) and
DRM_FORMAT_XRGB8888: for the latter, the 'X' component must be

ignored.

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

The graphics layer is blended on top of the video layer, and the blender uses both a global alpha parameter and the alpha channel of the

graphics

Quoted 25 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 2 lines

layer for 32-bit RGB formats. This will lead to incorrect operation when the 'X' component is not set to full opacity.

I spent a few hours digging in the source code and what I could find in the TRM and register maps, but there's not enough information in there to explain how the blender works. The obvious "XRGB" implementation would be to just disable the blender.

Quoted 18 lines
Quoted 5 lines

That won't work when using global alpha unfortunately :-(

Quoted 3 lines

What I got from experimenting so far is that the alpha component is ignored anyway while the video path isn't active. So as long as one isn't using the video blending path, the ARGB and XRGB modes are

identical.

Quoted 11 lines

Correct, *if* global alpha is set to full opaque, then you can disable the blender. That could confuse userspace though, enabling the graphics plane with XRGB would work, and then enabling the video plane with global alpha would fail.

Quoted 2 lines

Guess I'll need assistance from AMD/Xilinx to completely implement the XRGB modes.

The blender can ignore the alpha channel of the graphics plane for formats that have no alpha channel. It would be nice if there was a bit to force that behaviour for 32-bit RGB too, but I couldn't find any :-( It's worth asking though.

Quoted 4 lines

Unfortunately, there are no such explicit flag on the HW side. Although, some blender modes may turn off per-pixel alpha as a side effect. Let me check if I can find some trick to make it happen.

After some investigations I may confirm that this patch works, and it is safe to accept it. The ZynqMP DP blender ignores per pixel alpha if top plane alpha is enabled (which is always the case in the driver). So, AR24 is effectively treated as XR24 by the hardware.

Quoted 27 lines
Quoted 27 lines

Yes, my problem exactly.

Quoted 8 lines
Quoted 8 lines

(For our application, this patch is sufficient as it solves the issues like X11 not starting up, OpenGL not working and horrendously slow scaling performance)

Quoted 3 lines
Quoted 3 lines
drivers/gpu/drm/xlnx/zynqmp_disp.c +0 -0
           }, {
                   .drm_fmt        = DRM_FORMAT_RGBA8888,
                   .buf_fmt        =

ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_ABGR8888,

--
Mike Looijmans
System Expert

TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: [email protected]
W: www.topic.nl

Quoted 7 lines
Quoted 4 lines

--
Thank you,
Anatoliy

Thank you,
Anatoliy

Almost forgot,

- Anatoliy

maintainer
#9 lore raw
In reply to Mike Looijmans
Quoted 47 lines · Mike Looijmans
Quoted 28 lines · Laurent Pinchart

Hi Mike,

Thank you for the patch.

Quoted 23 lines · Mike Looijmans

XRGB8888 is the default mode that Xorg will want to use. Add support for this to the Zynqmp DisplayPort driver, so that applications can use 32-bit framebuffers. This solves that the X server would fail to start unless one provided an xorg.conf that sets DefaultDepth to 16.

---

  drivers/gpu/drm/xlnx/zynqmp_disp.c | 5 +++++
  1 file changed, 5 insertions(+)
drivers/gpu/drm/xlnx/zynqmp_disp.c +4 -0
index 80d1e499a18d..501428437000 100644
@@ -312,6 +312,11 @@ static const struct zynqmp_disp_format avbuf_gfx_fmts[] = {
  		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
  		.swap		= true,
  		.sf		= scaling_factors_888,
+	}, {
+		.drm_fmt	= DRM_FORMAT_XRGB8888,
+		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
+		.swap		= true,
Quoted 8 lines

drivers/gpu/drm/xlnx/zynqmp_disp.c static const struct zynqmp_disp_format avbuf_gfx_fmts[] = { · line 319

Quoted 1 line
drivers/gpu/drm/xlnx/zynqmp_disp.c +1 -0
+		.sf		= scaling_factors_888,

I'm afraid that's not enough. There's a crucial difference between DRM_FORMAT_ARGB8888 (already supported by this driver) and
DRM_FORMAT_XRGB8888: for the latter, the 'X' component must be ignored. The graphics layer is blended on top of the video layer, and the blender uses both a global alpha parameter and the alpha channel of the graphics layer for 32-bit RGB formats. This will lead to incorrect operation when the 'X' component is not set to full opacity.

I spent a few hours digging in the source code and what I could find in the TRM and register maps, but there's not enough information in there to explain how the blender works. The obvious "XRGB" implementation would be to just disable the blender.

What I got from experimenting so far is that the alpha component is ignored anyway while the video path isn't active. So as long as one isn't using the video blending path, the ARGB and XRGB modes are identical.

Quoted 6 lines

Guess I'll need assistance from AMD/Xilinx to completely implement the XRGB modes.

(For our application, this patch is sufficient as it solves the issues like X11 not starting up, OpenGL not working and horrendously slow scaling performance)

Given that we consider XRGB8888 mandatory, this patch is a good thing to have anyway, even if suboptimal, or broken in some scenario we can always fix later.

Maxime

maintainer
#10 lore raw
Quoted 45 lines · Maxime Ripard
Quoted 44 lines · Mike Looijmans
Quoted 26 lines · Laurent Pinchart
Quoted 16 lines · Mike Looijmans

XRGB8888 is the default mode that Xorg will want to use. Add support for this to the Zynqmp DisplayPort driver, so that applications can use 32-bit framebuffers. This solves that the X server would fail to start unless one provided an xorg.conf that sets DefaultDepth to 16.

---

  drivers/gpu/drm/xlnx/zynqmp_disp.c | 5 +++++
  1 file changed, 5 insertions(+)
drivers/gpu/drm/xlnx/zynqmp_disp.c +0 -0
index 80d1e499a18d..501428437000 100644

drivers/gpu/drm/xlnx/zynqmp_disp.c static const struct zynqmp_disp_format avbuf_gfx_fmts[] = { · line 319

Quoted 8 lines
drivers/gpu/drm/xlnx/zynqmp_disp.c +5 -0
@@ -312,6 +312,11 @@ static const struct zynqmp_disp_format avbuf_gfx_fmts[] = {
  		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
  		.swap		= true,
  		.sf		= scaling_factors_888,
+	}, {
+		.drm_fmt	= DRM_FORMAT_XRGB8888,
+		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
+		.swap		= true,
+		.sf		= scaling_factors_888,
Quoted 7 lines

I'm afraid that's not enough. There's a crucial difference between DRM_FORMAT_ARGB8888 (already supported by this driver) and
DRM_FORMAT_XRGB8888: for the latter, the 'X' component must be ignored. The graphics layer is blended on top of the video layer, and the blender uses both a global alpha parameter and the alpha channel of the graphics layer for 32-bit RGB formats. This will lead to incorrect operation when the 'X' component is not set to full opacity.

I spent a few hours digging in the source code and what I could find in the TRM and register maps, but there's not enough information in there to explain how the blender works. The obvious "XRGB" implementation would be to just disable the blender.

What I got from experimenting so far is that the alpha component is ignored anyway while the video path isn't active. So as long as one isn't using the video blending path, the ARGB and XRGB modes are identical.

Quoted 8 lines
Quoted 6 lines

Guess I'll need assistance from AMD/Xilinx to completely implement the XRGB modes.

(For our application, this patch is sufficient as it solves the issues like X11 not starting up, OpenGL not working and horrendously slow scaling performance)

Given that we consider XRGB8888 mandatory,

How about platforms that can't support it at all ?

Quoted 3 lines

this patch is a good thing to
have anyway, even if suboptimal, or broken in some scenario we can always fix later.

It needs to at least be updated to disallow XRGB8888 usage when the video plan is enabled, or when global alpha is set to a non-opaque value.

Signature · 3 lines
Regards,

Laurent Pinchart
maintainer
#11 lore raw
Quoted 49 lines · Laurent Pinchart
Quoted 48 lines · Maxime Ripard
Quoted 47 lines · Mike Looijmans
Quoted 26 lines · Laurent Pinchart
Quoted 16 lines · Mike Looijmans

XRGB8888 is the default mode that Xorg will want to use. Add support for this to the Zynqmp DisplayPort driver, so that applications can use 32-bit framebuffers. This solves that the X server would fail to start unless one provided an xorg.conf that sets DefaultDepth to 16.

---

  drivers/gpu/drm/xlnx/zynqmp_disp.c | 5 +++++
  1 file changed, 5 insertions(+)
drivers/gpu/drm/xlnx/zynqmp_disp.c +0 -0
index 80d1e499a18d..501428437000 100644

drivers/gpu/drm/xlnx/zynqmp_disp.c static const struct zynqmp_disp_format avbuf_gfx_fmts[] = { · line 319

Quoted 8 lines
drivers/gpu/drm/xlnx/zynqmp_disp.c +5 -0
@@ -312,6 +312,11 @@ static const struct zynqmp_disp_format avbuf_gfx_fmts[] = {
  		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
  		.swap		= true,
  		.sf		= scaling_factors_888,
+	}, {
+		.drm_fmt	= DRM_FORMAT_XRGB8888,
+		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
+		.swap		= true,
+		.sf		= scaling_factors_888,
Quoted 7 lines

I'm afraid that's not enough. There's a crucial difference between DRM_FORMAT_ARGB8888 (already supported by this driver) and
DRM_FORMAT_XRGB8888: for the latter, the 'X' component must be ignored. The graphics layer is blended on top of the video layer, and the blender uses both a global alpha parameter and the alpha channel of the graphics layer for 32-bit RGB formats. This will lead to incorrect operation when the 'X' component is not set to full opacity.

I spent a few hours digging in the source code and what I could find in the TRM and register maps, but there's not enough information in there to explain how the blender works. The obvious "XRGB" implementation would be to just disable the blender.

What I got from experimenting so far is that the alpha component is ignored anyway while the video path isn't active. So as long as one isn't using the video blending path, the ARGB and XRGB modes are identical.

Guess I'll need assistance from AMD/Xilinx to completely implement the XRGB modes.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

(For our application, this patch is sufficient as it solves the issues like X11 not starting up, OpenGL not working and horrendously slow scaling performance)

Given that we consider XRGB8888 mandatory,

How about platforms that can't support it at all ?

We emulate it.

Quoted 7 lines
Quoted 3 lines

this patch is a good thing to
have anyway, even if suboptimal, or broken in some scenario we can always fix later.

It needs to at least be updated to disallow XRGB8888 usage when the video plan is enabled, or when global alpha is set to a non-opaque value.

Yeah, that's reasonable

Maxime

maintainer
#12 lore raw
Quoted 54 lines · Maxime Ripard
Quoted 53 lines · Laurent Pinchart
Quoted 52 lines · Maxime Ripard
Quoted 50 lines · Mike Looijmans
Quoted 26 lines · Laurent Pinchart
Quoted 16 lines · Mike Looijmans

XRGB8888 is the default mode that Xorg will want to use. Add support for this to the Zynqmp DisplayPort driver, so that applications can use 32-bit framebuffers. This solves that the X server would fail to start unless one provided an xorg.conf that sets DefaultDepth to 16.

---

  drivers/gpu/drm/xlnx/zynqmp_disp.c | 5 +++++
  1 file changed, 5 insertions(+)
drivers/gpu/drm/xlnx/zynqmp_disp.c +0 -0
index 80d1e499a18d..501428437000 100644

drivers/gpu/drm/xlnx/zynqmp_disp.c static const struct zynqmp_disp_format avbuf_gfx_fmts[] = { · line 319

Quoted 8 lines
drivers/gpu/drm/xlnx/zynqmp_disp.c +5 -0
@@ -312,6 +312,11 @@ static const struct zynqmp_disp_format avbuf_gfx_fmts[] = {
  		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
  		.swap		= true,
  		.sf		= scaling_factors_888,
+	}, {
+		.drm_fmt	= DRM_FORMAT_XRGB8888,
+		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
+		.swap		= true,
+		.sf		= scaling_factors_888,
Quoted 7 lines

I'm afraid that's not enough. There's a crucial difference between DRM_FORMAT_ARGB8888 (already supported by this driver) and
DRM_FORMAT_XRGB8888: for the latter, the 'X' component must be ignored. The graphics layer is blended on top of the video layer, and the blender uses both a global alpha parameter and the alpha channel of the graphics layer for 32-bit RGB formats. This will lead to incorrect operation when the 'X' component is not set to full opacity.

I spent a few hours digging in the source code and what I could find in the TRM and register maps, but there's not enough information in there to explain how the blender works. The obvious "XRGB" implementation would be to just disable the blender.

What I got from experimenting so far is that the alpha component is ignored anyway while the video path isn't active. So as long as one isn't using the video blending path, the ARGB and XRGB modes are identical.

Guess I'll need assistance from AMD/Xilinx to completely implement the XRGB modes.

(For our application, this patch is sufficient as it solves the issues like X11 not starting up, OpenGL not working and horrendously slow scaling performance)

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Given that we consider XRGB8888 mandatory,

How about platforms that can't support it at all ?

We emulate it.

Does that imply a full memcpy of the frame buffer in the kernel driver, or is it emulated in userspace ?

Quoted 9 lines
Quoted 7 lines
Quoted 3 lines

this patch is a good thing to
have anyway, even if suboptimal, or broken in some scenario we can always fix later.

It needs to at least be updated to disallow XRGB8888 usage when the video plan is enabled, or when global alpha is set to a non-opaque value.

Yeah, that's reasonable

Signature · 3 lines
Regards,

Laurent Pinchart
maintainer
#13 lore raw
Quoted 55 lines · Laurent Pinchart
Quoted 54 lines · Maxime Ripard
Quoted 53 lines · Laurent Pinchart
Quoted 52 lines · Maxime Ripard
Quoted 50 lines · Mike Looijmans
Quoted 26 lines · Laurent Pinchart
Quoted 16 lines · Mike Looijmans

XRGB8888 is the default mode that Xorg will want to use. Add support for this to the Zynqmp DisplayPort driver, so that applications can use 32-bit framebuffers. This solves that the X server would fail to start unless one provided an xorg.conf that sets DefaultDepth to 16.

---

  drivers/gpu/drm/xlnx/zynqmp_disp.c | 5 +++++
  1 file changed, 5 insertions(+)
drivers/gpu/drm/xlnx/zynqmp_disp.c +0 -0
index 80d1e499a18d..501428437000 100644

drivers/gpu/drm/xlnx/zynqmp_disp.c static const struct zynqmp_disp_format avbuf_gfx_fmts[] = { · line 319

Quoted 8 lines
drivers/gpu/drm/xlnx/zynqmp_disp.c +5 -0
@@ -312,6 +312,11 @@ static const struct zynqmp_disp_format avbuf_gfx_fmts[] = {
  		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
  		.swap		= true,
  		.sf		= scaling_factors_888,
+	}, {
+		.drm_fmt	= DRM_FORMAT_XRGB8888,
+		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
+		.swap		= true,
+		.sf		= scaling_factors_888,
Quoted 7 lines

I'm afraid that's not enough. There's a crucial difference between DRM_FORMAT_ARGB8888 (already supported by this driver) and
DRM_FORMAT_XRGB8888: for the latter, the 'X' component must be ignored. The graphics layer is blended on top of the video layer, and the blender uses both a global alpha parameter and the alpha channel of the graphics layer for 32-bit RGB formats. This will lead to incorrect operation when the 'X' component is not set to full opacity.

I spent a few hours digging in the source code and what I could find in the TRM and register maps, but there's not enough information in there to explain how the blender works. The obvious "XRGB" implementation would be to just disable the blender.

What I got from experimenting so far is that the alpha component is ignored anyway while the video path isn't active. So as long as one isn't using the video blending path, the ARGB and XRGB modes are identical.

Guess I'll need assistance from AMD/Xilinx to completely implement the XRGB modes.

(For our application, this patch is sufficient as it solves the issues like X11 not starting up, OpenGL not working and horrendously slow scaling performance)

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Given that we consider XRGB8888 mandatory,

How about platforms that can't support it at all ?

We emulate it.

Does that imply a full memcpy of the frame buffer in the kernel driver, or is it emulated in userspace ?

Neither :)

The kernel deals with it through drm_fb_xrgb8888_to_* helpers, but only on the parts of the framebuffer that were modified through the damage API.

Maxime

maintainer
#14 lore raw
Quoted 62 lines · Maxime Ripard
Quoted 61 lines · Laurent Pinchart
Quoted 59 lines · Maxime Ripard
Quoted 49 lines · Laurent Pinchart
Quoted 48 lines · Maxime Ripard
Quoted 47 lines · Mike Looijmans
Quoted 26 lines · Laurent Pinchart
Quoted 16 lines · Mike Looijmans

XRGB8888 is the default mode that Xorg will want to use. Add support for this to the Zynqmp DisplayPort driver, so that applications can use 32-bit framebuffers. This solves that the X server would fail to start unless one provided an xorg.conf that sets DefaultDepth to 16.

---

  drivers/gpu/drm/xlnx/zynqmp_disp.c | 5 +++++
  1 file changed, 5 insertions(+)
drivers/gpu/drm/xlnx/zynqmp_disp.c +0 -0
index 80d1e499a18d..501428437000 100644

drivers/gpu/drm/xlnx/zynqmp_disp.c static const struct zynqmp_disp_format avbuf_gfx_fmts[] = { · line 319

Quoted 8 lines
drivers/gpu/drm/xlnx/zynqmp_disp.c +5 -0
@@ -312,6 +312,11 @@ static const struct zynqmp_disp_format avbuf_gfx_fmts[] = {
  		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
  		.swap		= true,
  		.sf		= scaling_factors_888,
+	}, {
+		.drm_fmt	= DRM_FORMAT_XRGB8888,
+		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
+		.swap		= true,
+		.sf		= scaling_factors_888,
Quoted 7 lines

I'm afraid that's not enough. There's a crucial difference between DRM_FORMAT_ARGB8888 (already supported by this driver) and
DRM_FORMAT_XRGB8888: for the latter, the 'X' component must be ignored. The graphics layer is blended on top of the video layer, and the blender uses both a global alpha parameter and the alpha channel of the graphics layer for 32-bit RGB formats. This will lead to incorrect operation when the 'X' component is not set to full opacity.

I spent a few hours digging in the source code and what I could find in the TRM and register maps, but there's not enough information in there to explain how the blender works. The obvious "XRGB" implementation would be to just disable the blender.

What I got from experimenting so far is that the alpha component is ignored anyway while the video path isn't active. So as long as one isn't using the video blending path, the ARGB and XRGB modes are identical.

Guess I'll need assistance from AMD/Xilinx to completely implement the XRGB modes.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

(For our application, this patch is sufficient as it solves the issues like X11 not starting up, OpenGL not working and horrendously slow scaling performance)

Given that we consider XRGB8888 mandatory,

How about platforms that can't support it at all ?

We emulate it.

Quoted 8 lines
Quoted 2 lines

Does that imply a full memcpy of the frame buffer in the kernel driver, or is it emulated in userspace ?

Neither :)

The kernel deals with it through drm_fb_xrgb8888_to_* helpers, but only on the parts of the framebuffer that were modified through the damage API.

Aahhh OK, it's for the fbdev emulation. So that means that drivers are not required to support XRGB8888 ?

Signature · 3 lines
Regards,

Laurent Pinchart
maintainer
#15 lore raw
Quoted 66 lines · Laurent Pinchart
Quoted 65 lines · Maxime Ripard
Quoted 63 lines · Laurent Pinchart
Quoted 54 lines · Maxime Ripard
Quoted 53 lines · Laurent Pinchart
Quoted 52 lines · Maxime Ripard
Quoted 50 lines · Mike Looijmans
Quoted 26 lines · Laurent Pinchart
Quoted 16 lines · Mike Looijmans

XRGB8888 is the default mode that Xorg will want to use. Add support for this to the Zynqmp DisplayPort driver, so that applications can use 32-bit framebuffers. This solves that the X server would fail to start unless one provided an xorg.conf that sets DefaultDepth to 16.

---

  drivers/gpu/drm/xlnx/zynqmp_disp.c | 5 +++++
  1 file changed, 5 insertions(+)
drivers/gpu/drm/xlnx/zynqmp_disp.c +0 -0
index 80d1e499a18d..501428437000 100644

drivers/gpu/drm/xlnx/zynqmp_disp.c static const struct zynqmp_disp_format avbuf_gfx_fmts[] = { · line 319

Quoted 8 lines
drivers/gpu/drm/xlnx/zynqmp_disp.c +5 -0
@@ -312,6 +312,11 @@ static const struct zynqmp_disp_format avbuf_gfx_fmts[] = {
  		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
  		.swap		= true,
  		.sf		= scaling_factors_888,
+	}, {
+		.drm_fmt	= DRM_FORMAT_XRGB8888,
+		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
+		.swap		= true,
+		.sf		= scaling_factors_888,
Quoted 7 lines

I'm afraid that's not enough. There's a crucial difference between DRM_FORMAT_ARGB8888 (already supported by this driver) and
DRM_FORMAT_XRGB8888: for the latter, the 'X' component must be ignored. The graphics layer is blended on top of the video layer, and the blender uses both a global alpha parameter and the alpha channel of the graphics layer for 32-bit RGB formats. This will lead to incorrect operation when the 'X' component is not set to full opacity.

I spent a few hours digging in the source code and what I could find in the TRM and register maps, but there's not enough information in there to explain how the blender works. The obvious "XRGB" implementation would be to just disable the blender.

What I got from experimenting so far is that the alpha component is ignored anyway while the video path isn't active. So as long as one isn't using the video blending path, the ARGB and XRGB modes are identical.

Guess I'll need assistance from AMD/Xilinx to completely implement the XRGB modes.

(For our application, this patch is sufficient as it solves the issues like X11 not starting up, OpenGL not working and horrendously slow scaling performance)

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Given that we consider XRGB8888 mandatory,

How about platforms that can't support it at all ?

We emulate it.

Does that imply a full memcpy of the frame buffer in the kernel driver, or is it emulated in userspace ?

Quoted 8 lines
Quoted 5 lines

Neither :)

The kernel deals with it through drm_fb_xrgb8888_to_* helpers, but only on the parts of the framebuffer that were modified through the damage API.

Aahhh OK, it's for the fbdev emulation. So that means that drivers are not required to support XRGB8888 ?

No, it's for KMS.

Maxime

#16 lore raw
In reply to Maxime Ripard
Quoted 55 lines · Maxime Ripard
Quoted 44 lines · Laurent Pinchart
Quoted 43 lines · Maxime Ripard
Quoted 42 lines · Mike Looijmans
Quoted 24 lines · Laurent Pinchart
Quoted 23 lines · Mike Looijmans

XRGB8888 is the default mode that Xorg will want to use. Add support for this to the Zynqmp DisplayPort driver, so that applications can use 32-bit framebuffers. This solves that the X server would fail to start unless one provided an xorg.conf that sets DefaultDepth to 16.

---

   drivers/gpu/drm/xlnx/zynqmp_disp.c | 5 +++++
   1 file changed, 5 insertions(+)
drivers/gpu/drm/xlnx/zynqmp_disp.c +4 -0
index 80d1e499a18d..501428437000 100644
@@ -312,6 +312,11 @@ static const struct zynqmp_disp_format avbuf_gfx_fmts[] = {
   		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
   		.swap		= true,
   		.sf		= scaling_factors_888,
+	}, {
+		.drm_fmt	= DRM_FORMAT_XRGB8888,
+		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
+		.swap		= true,
Quoted 8 lines

drivers/gpu/drm/xlnx/zynqmp_disp.c static const struct zynqmp_disp_format avbuf_gfx_fmts[] = { · line 319

Quoted 1 line
drivers/gpu/drm/xlnx/zynqmp_disp.c +1 -0
+		.sf		= scaling_factors_888,

I'm afraid that's not enough. There's a crucial difference between DRM_FORMAT_ARGB8888 (already supported by this driver) and
DRM_FORMAT_XRGB8888: for the latter, the 'X' component must be ignored. The graphics layer is blended on top of the video layer, and the blender uses both a global alpha parameter and the alpha channel of the graphics layer for 32-bit RGB formats. This will lead to incorrect operation when the 'X' component is not set to full opacity.

I spent a few hours digging in the source code and what I could find in the TRM and register maps, but there's not enough information in there to explain how the blender works. The obvious "XRGB" implementation would be to just disable the blender.

What I got from experimenting so far is that the alpha component is ignored anyway while the video path isn't active. So as long as one isn't using the video blending path, the ARGB and XRGB modes are identical.

Quoted 8 lines
Quoted 7 lines
Quoted 6 lines

Guess I'll need assistance from AMD/Xilinx to completely implement the XRGB modes.

(For our application, this patch is sufficient as it solves the issues like X11 not starting up, OpenGL not working and horrendously slow scaling performance)

Given that we consider XRGB8888 mandatory,

How about platforms that can't support it at all ?

We emulate it.

Quoted 7 lines
Quoted 6 lines
Quoted 3 lines

this patch is a good thing to
have anyway, even if suboptimal, or broken in some scenario we can always fix later.

It needs to at least be updated to disallow XRGB8888 usage when the video plan is enabled, or when global alpha is set to a non-opaque value.

Yeah, that's reasonable

And feasible too I think. Basically only allow XRGB8888 when things are either totally transparent or totally opaque. I'm only concerned it might to lead to strange behavior, depending on which layer you enable first.

Quoted 2 lines

Maxime

Signature · 1 line
Mike Looijmans
Tested-by on v1 1/1
#17 lore raw
In reply to Mike Looijmans
Quoted 17 lines · Mike Looijmans

XRGB8888 is the default mode that Xorg will want to use. Add support for this to the Zynqmp DisplayPort driver, so that applications can use 32-bit framebuffers. This solves that the X server would fail to start unless one provided an xorg.conf that sets DefaultDepth to 16.

---

 drivers/gpu/drm/xlnx/zynqmp_disp.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/gpu/drm/xlnx/zynqmp_disp.c +0 -0
index 80d1e499a18d..501428437000 100644
@@ -312,6 +312,11 @@ static const struct zynqmp_disp_format avbuf_gfx_fmts[] = {
 		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,

drivers/gpu/drm/xlnx/zynqmp_disp.c static const struct zynqmp_disp_format avbuf_gfx_fmts[] = { · line 322

Quoted 10 lines
drivers/gpu/drm/xlnx/zynqmp_disp.c +5 -0
 		.swap		= true,
 		.sf		= scaling_factors_888,
+	}, {
+		.drm_fmt	= DRM_FORMAT_XRGB8888,
+		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
+		.swap		= true,
+		.sf		= scaling_factors_888,
 	}, {
 		.drm_fmt	= DRM_FORMAT_RGBA8888,
 		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_ABGR8888,

I can confirm that this provides a nice performance boost :)

#18 lore raw
Quoted 31 lines · Sean Anderson
Quoted 17 lines · Mike Looijmans

XRGB8888 is the default mode that Xorg will want to use. Add support for this to the Zynqmp DisplayPort driver, so that applications can use 32-bit framebuffers. This solves that the X server would fail to start unless one provided an xorg.conf that sets DefaultDepth to 16.

---

 drivers/gpu/drm/xlnx/zynqmp_disp.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/gpu/drm/xlnx/zynqmp_disp.c +0 -0
index 80d1e499a18d..501428437000 100644
@@ -312,6 +312,11 @@ static const struct zynqmp_disp_format avbuf_gfx_fmts[] = {
 		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,

drivers/gpu/drm/xlnx/zynqmp_disp.c static const struct zynqmp_disp_format avbuf_gfx_fmts[] = { · line 322

Quoted 10 lines
drivers/gpu/drm/xlnx/zynqmp_disp.c +5 -0
 		.swap		= true,
 		.sf		= scaling_factors_888,
+	}, {
+		.drm_fmt	= DRM_FORMAT_XRGB8888,
+		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
+		.swap		= true,
+		.sf		= scaling_factors_888,
 	}, {
 		.drm_fmt	= DRM_FORMAT_RGBA8888,
 		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_ABGR8888,
Quoted 1 line

I can confirm that this provides a nice performance boost :)

Actually, I think a better fix would be to make the "video" plane the primary one. That plane supports XRGB8888 natively, and then the graphics plane can be used as an overlay for e.g. windows or cursors.

--Sean

maintainer
#19 lore raw

Hi,

Quoted 32 lines · Sean Anderson
Quoted 31 lines · Sean Anderson
Quoted 17 lines · Mike Looijmans

XRGB8888 is the default mode that Xorg will want to use. Add support for this to the Zynqmp DisplayPort driver, so that applications can use 32-bit framebuffers. This solves that the X server would fail to start unless one provided an xorg.conf that sets DefaultDepth to 16.

---

 drivers/gpu/drm/xlnx/zynqmp_disp.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/gpu/drm/xlnx/zynqmp_disp.c +0 -0
index 80d1e499a18d..501428437000 100644
@@ -312,6 +312,11 @@ static const struct zynqmp_disp_format avbuf_gfx_fmts[] = {
 		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,

drivers/gpu/drm/xlnx/zynqmp_disp.c static const struct zynqmp_disp_format avbuf_gfx_fmts[] = { · line 322

Quoted 10 lines
drivers/gpu/drm/xlnx/zynqmp_disp.c +5 -0
 		.swap		= true,
 		.sf		= scaling_factors_888,
+	}, {
+		.drm_fmt	= DRM_FORMAT_XRGB8888,
+		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
+		.swap		= true,
+		.sf		= scaling_factors_888,
 	}, {
 		.drm_fmt	= DRM_FORMAT_RGBA8888,
 		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_ABGR8888,
Quoted 5 lines
Quoted 1 line

I can confirm that this provides a nice performance boost :)

Actually, I think a better fix would be to make the "video" plane the primary one. That plane supports XRGB8888 natively, and then the graphics plane can be used as an overlay for e.g. windows or cursors.

True, but I think usually the overlay plane is the video plane, which supports YUV formats. If we use the video plane as the root plane, then that one is reserved and there's no "real" video overlay plane.

Did you check my recent reply to the thread? I didn't have too much time to debug all the combinations and what exactly the userspace does. I'm inclined to just merge this one which should improve the user experience quite a bit, even if there are still unclear parts to this. The related code can be improved later if we figure out the details.

Any objections?

Tomi

#20 lore raw
Quoted 35 lines · Tomi Valkeinen

Hi,

Quoted 32 lines · Sean Anderson
Quoted 31 lines · Sean Anderson
Quoted 17 lines · Mike Looijmans

XRGB8888 is the default mode that Xorg will want to use. Add support for this to the Zynqmp DisplayPort driver, so that applications can use 32-bit framebuffers. This solves that the X server would fail to start unless one provided an xorg.conf that sets DefaultDepth to 16.

---

 drivers/gpu/drm/xlnx/zynqmp_disp.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/gpu/drm/xlnx/zynqmp_disp.c +0 -0
index 80d1e499a18d..501428437000 100644
@@ -312,6 +312,11 @@ static const struct zynqmp_disp_format avbuf_gfx_fmts[] = {
 		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,

drivers/gpu/drm/xlnx/zynqmp_disp.c static const struct zynqmp_disp_format avbuf_gfx_fmts[] = { · line 322

Quoted 10 lines
drivers/gpu/drm/xlnx/zynqmp_disp.c +5 -0
 		.swap		= true,
 		.sf		= scaling_factors_888,
+	}, {
+		.drm_fmt	= DRM_FORMAT_XRGB8888,
+		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
+		.swap		= true,
+		.sf		= scaling_factors_888,
 	}, {
 		.drm_fmt	= DRM_FORMAT_RGBA8888,
 		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_ABGR8888,
Quoted 8 lines
Quoted 5 lines
Quoted 1 line

I can confirm that this provides a nice performance boost :)

Actually, I think a better fix would be to make the "video" plane the primary one. That plane supports XRGB8888 natively, and then the graphics plane can be used as an overlay for e.g. windows or cursors.

True, but I think usually the overlay plane is the video plane, which supports YUV formats. If we use the video plane as the root plane, then that one is reserved and there's no "real" video overlay plane.

But you can't use it as an overlay anyway unless you enable colorkey. Otherwise it's always an "underlay". So you can't actually have e.g. the video layer display a decoded video in a window because that would require userspace to "carve out" the window in the graphics alpha layer. But as discussed earlier in this thread, the alpha channel is always disabled by this driver! So the video layer is completely unusable in the current driver anyway.

Quoted 7 lines

Did you check my recent reply to the thread? I didn't have too much time to debug all the combinations and what exactly the userspace does. I'm inclined to just merge this one which should improve the user experience quite a bit, even if there are still unclear parts to this. The related code can be improved later if we figure out the details.

Any objections?

I object to this because it solidifies the current state of affairs where the alpha channel of the graphics layer can't be used. I will submit a series later today to change the primary plane and enable the alpha channel.

--Sean

maintainer
#21 lore raw
In reply to Mike Looijmans

Hi,

Quoted 17 lines · Mike Looijmans

XRGB8888 is the default mode that Xorg will want to use. Add support for this to the Zynqmp DisplayPort driver, so that applications can use 32-bit framebuffers. This solves that the X server would fail to start unless one provided an xorg.conf that sets DefaultDepth to 16.

---

 drivers/gpu/drm/xlnx/zynqmp_disp.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/gpu/drm/xlnx/zynqmp_disp.c +0 -0
index 80d1e499a18d..501428437000 100644
@@ -312,6 +312,11 @@ static const struct zynqmp_disp_format avbuf_gfx_fmts[] = {
 		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,

drivers/gpu/drm/xlnx/zynqmp_disp.c static const struct zynqmp_disp_format avbuf_gfx_fmts[] = { · line 322

Quoted 10 lines
drivers/gpu/drm/xlnx/zynqmp_disp.c +5 -0
 		.swap		= true,
 		.sf		= scaling_factors_888,
+	}, {
+		.drm_fmt	= DRM_FORMAT_XRGB8888,
+		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
+		.swap		= true,
+		.sf		= scaling_factors_888,
 	}, {
 		.drm_fmt	= DRM_FORMAT_RGBA8888,
 		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_ABGR8888,

I did some testing with this.

With current upstream, I can't start either weston or X. Weston says XRGB8888 not supported, X says modeset failed.

But we do have XRGB8888, on the VID plane. VID plane is even set as the first plane (perhaps intentionally, to have XRGB8888 on the first plane?). However, for VID plane, we set DRM_PLANE_TYPE_OVERLAY and for GFX plane we set DRM_PLANE_TYPE_PRIMARY. According to docs, these plane type flags are legacy, and are ignored by userspace that supports universal planes. So, both Weston and X should work, but don't.

Out of interest, I tested switching the plane types the other way around. This made weston start, but X still doesn't. So apparently weston does use those flags, and they're mandatory. I'm a bit surprised that X doesn't start. So having the first plane as PRIMARY with XRGB8888 still wasn't enough for some reason.

With this patch, both weston and X start.

According to Anatoliy: "The ZynqMP DP blender ignores per pixel alpha if top plane alpha is enabled (which is always the case in the driver). So, AR24 is effectively treated as XR24 by the hardware". So should we then remove the alpha formats from the driver, as they are effectively not supported?

Tomi

#22 lore raw
Quoted 33 lines · Tomi Valkeinen

Hi,

Quoted 17 lines · Mike Looijmans

XRGB8888 is the default mode that Xorg will want to use. Add support for this to the Zynqmp DisplayPort driver, so that applications can use 32-bit framebuffers. This solves that the X server would fail to start unless one provided an xorg.conf that sets DefaultDepth to 16.

---

 drivers/gpu/drm/xlnx/zynqmp_disp.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/gpu/drm/xlnx/zynqmp_disp.c +0 -0
index 80d1e499a18d..501428437000 100644
@@ -312,6 +312,11 @@ static const struct zynqmp_disp_format avbuf_gfx_fmts[] = {
 		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,

drivers/gpu/drm/xlnx/zynqmp_disp.c static const struct zynqmp_disp_format avbuf_gfx_fmts[] = { · line 322

Quoted 10 lines
drivers/gpu/drm/xlnx/zynqmp_disp.c +5 -0
 		.swap		= true,
 		.sf		= scaling_factors_888,
+	}, {
+		.drm_fmt	= DRM_FORMAT_XRGB8888,
+		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_RGBA8888,
+		.swap		= true,
+		.sf		= scaling_factors_888,
 	}, {
 		.drm_fmt	= DRM_FORMAT_RGBA8888,
 		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_GFX_ABGR8888,

I did some testing with this.

Quoted 2 lines

With current upstream, I can't start either weston or X. Weston says XRGB8888 not supported, X says modeset failed.

You have to configure X to use 16-bit color. e.g. set DefaultDepth 16 in your screen section. That will cause X to use RGB565, which is supported.

--Sean

Quoted 25 lines

But we do have XRGB8888, on the VID plane. VID plane is even set as the first plane (perhaps intentionally, to have XRGB8888 on the first plane?). However, for VID plane, we set DRM_PLANE_TYPE_OVERLAY and for GFX plane we set DRM_PLANE_TYPE_PRIMARY. According to docs, these plane type flags are legacy, and are ignored by userspace that supports universal planes. So, both Weston and X should work, but don't.

Out of interest, I tested switching the plane types the other way around. This made weston start, but X still doesn't. So apparently weston does use those flags, and they're mandatory. I'm a bit surprised that X doesn't start. So having the first plane as PRIMARY with XRGB8888 still wasn't enough for some reason.

With this patch, both weston and X start.

According to Anatoliy: "The ZynqMP DP blender ignores per pixel alpha if top plane alpha is enabled (which is always the case in the driver). So, AR24 is effectively treated as XR24 by the hardware". So should we then remove the alpha formats from the driver, as they are effectively not supported?

Tomi