Skip to contentSkip to conversation

mfd: syscon: atmel-smc: Don't use "proxy" headers

PATCH Applied Andy Shevchenko 2 participants 2 messages Jun 27, 2025 – Jul 2, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 mfd: syscon: atmel-smc: Don't use "proxy" headers

Update header inclusions to follow IWYU (Include What You Use) principle.

Note that kernel.h is discouraged to be included as it's written at the top of that file.

---

v2: fixed multiple compilation errors (LKP)

 drivers/mfd/atmel-smc.c              | 9 ++++++++-
 include/linux/mfd/syscon/atmel-smc.h | 8 +++++---
 2 files changed, 13 insertions(+), 4 deletions(-)
drivers/mfd/atmel-smc.c +8 -1
index 4628ca14e766..0a5b42c83f17 100644
@@ -8,9 +8,16 @@
  * Author: Boris Brezillon <[email protected]>
  */
 
-#include <linux/mfd/syscon/atmel-smc.h>
+#include <linux/bits.h>
+#include <linux/err.h>
+#include <linux/export.h>
+#include <linux/mod_devicetable.h>
+#include <linux/of.h>
+#include <linux/regmap.h>
 #include <linux/string.h>
 
+#include <linux/mfd/syscon/atmel-smc.h>
+
 /**
  * atmel_smc_cs_conf_init - initialize a SMC CS conf
  * @conf: the SMC CS conf to initialize
include/linux/mfd/syscon/atmel-smc.h +5 -3
index e9e24f4c4578..9b9119c742a2 100644
@@ -11,9 +11,11 @@
 #ifndef _LINUX_MFD_SYSCON_ATMEL_SMC_H_
 #define _LINUX_MFD_SYSCON_ATMEL_SMC_H_
 
-#include <linux/kernel.h>
-#include <linux/of.h>
-#include <linux/regmap.h>
+#include <linux/bits.h>
+#include <linux/types.h>
+
+struct device_node;
+struct regmap;
 
 #define ATMEL_SMC_SETUP(cs)			(((cs) * 0x10))
 #define ATMEL_HSMC_SETUP(layout, cs)		\
Signature · 1 line
2.47.2
maintainer Applied
#1 lore raw

Re: (subset) [PATCH v2 1/1] mfd: syscon: atmel-smc: Don't use "proxy" headers

Quoted 8 lines · Andy Shevchenko

Update header inclusions to follow IWYU (Include What You Use) principle.

Note that kernel.h is discouraged to be included as it's written at the top of that file.

[...]

Applied, thanks!

[1/1] mfd: syscon: atmel-smc: Don't use "proxy" headers

      commit: e1411d38da67e53a25aee615c3e5320d373ef741

--
Lee Jones [李琼斯]