meta-ti-bsp: k3r5: Use new tune file for Cortex-R5F
PATCH 1/1 meta-ti-bsp: k3r5: Use new tune file for Cortex-R5F
There is now a tune available specifically for Cortex-R5F cores, use that here. Not sure how much difference this makes as we only build one package for this (U-Boot R5 SPL) but should be no harm either.
--- meta-ti-bsp/conf/machine/include/k3r5.inc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
meta-ti-bsp/conf/machine/include/k3r5.inc +3 -3
@@ -3,9 +3,9 @@ require conf/machine/include/ti-soc.inc SOC_FAMILY:append = ":k3r5" -# The closest of existing tunes for Cortex-R5F -DEFAULTTUNE = "armv7athf" -require conf/machine/include/arm/armv7a/tune-cortexa8.inc +# Tune for Cortex-R5F +DEFAULTTUNE = "cortexr5hf" +require conf/machine/include/arm/armv7r/tune-cortexr5.inc # R5 runs early bootloader and loads SYSFW # https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/doc/board/ti/j721e_evm.rst
Signature · 1 line
2.39.2
Quoted 14 lines · Andrew Davis via lists.yoctoproject.org
There is now a tune available specifically for Cortex-R5F cores, use that here. Not sure how much difference this makes as we only build one package for this (U-Boot R5 SPL) but should be no harm either.
Signed-off-by Andrew Davis <[email protected]>--- meta-ti-bsp/conf/machine/include/k3r5.inc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)meta-ti-bsp/conf/machine/include/k3r5.inc +0
-0
meta-ti-bsp/conf/machine/include/k3r5.inc line 8
Quoted 9 lines
meta-ti-bsp/conf/machine/include/k3r5.inc +3
-3@@ -3,9 +3,9 @@ require conf/machine/include/ti-soc.inc SOC_FAMILY:append = ":k3r5" -# The closest of existing tunes for Cortex-R5F -DEFAULTTUNE = "armv7athf" -require conf/machine/include/arm/armv7a/tune-cortexa8.inc +# Tune for Cortex-R5F +DEFAULTTUNE = "cortexr5hf" +require conf/machine/include/arm/armv7r/tune-cortexr5.inc
Last time I tried this, there were some adverse effects, though I don't remember specific details - could have been something Thumb-related, size or speed.
I still have a patch in one of my old local trees, but I never submited it due to the above uncertainty. Ah, I see, back in Kirstone days, 2 years ago - see attached...
I would recommend thorough testing with this change. But it might have been toolchain-related and is no longer an issue...
Quoted 4 lines
meta-ti-bsp/conf/machine/include/k3r5.inc +0
-0# R5 runs early bootloader and loads SYSFW # https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/doc/board/ti/j721e_evm.rstSignature · 1 line
2.39.2
From 452ef88ddf550c9836ddcaa97f81a6ffea81a888 Mon Sep 17 00:00:00 2001
From: Denys Dmytriyenko <[email protected]>
Date: Tue, 4 Apr 2023 19:45:51 +0000
Subject: [PATCH] machine: k3r5: use new dedicated Cortex-R5 tunes
Back in Dunfell we had to use Cortex-A8 tunes, as the closest match. Since then OE-Core got lots of dedicated tunes and we can now use the correct Cortex-R5 one for K3 R5F cores.
--- meta-ti-bsp/conf/machine/include/k3r5.inc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
meta-ti-bsp/conf/machine/include/k3r5.inc +2 -3
@@ -3,9 +3,8 @@ require conf/machine/include/ti-soc.inc SOC_FAMILY:append = ":k3r5" -# The closest of existing tunes for Cortex-R5F -DEFAULTTUNE = "armv7athf" -require conf/machine/include/arm/armv7a/tune-cortexa8.inc +DEFAULTTUNE = "armv7r" +require conf/machine/include/arm/armv7r/tune-cortexr5.inc # R5 runs early bootloader and loads SYSFW # https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/doc/board/ti/j721e_evm.rst
Signature · 1 line
2.25.1