io_uring: fix four comment typos
PATCH 1/1 io_uring: fix four comment typos
Fix minor spelling mistakes in io_uring.c:
- cancelation -> cancellation
- reuqests -> requests
- discernable -> discernible
- cancelations -> cancellations
--- io_uring/io_uring.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
io_uring/io_uring.c +5 -5
@@ -409,7 +409,7 @@ static void io_clean_op(struct io_kiocb *req) }/* -* Mark the request as inflight, so that file cancelation will find it. +* Mark the request as inflight, so that file cancellation will find it. * Can be used if the file is an io_uring instance, or if the request itself * relies on ->mm being alive for the duration of the request. */
@@ -1162,7 +1162,7 @@ static void io_req_local_work_add(struct io_kiocb *req, unsigned flags)BUILD_BUG_ON (IO_CQ_WAKE_FORCE <=IORING_MAX_CQ_ENTRIES );/* -* We don't know how many reuqests is there in the link and whether +* We don't know how many requests is there in the link and whether * they can even be queued lazily, fall back to non-lazy. */ if (req->flags &IO_REQ_LINK_FLAGS )
@@ -2856,7 +2856,7 @@ static __cold void io_tctx_exit_cb(struct callback_head *cb)* When @in_cancel, we're in cancellation and it's racy to remove the * node. It'll be removed by the end of cancellation, just ignore it. * tctx can be NULL if the queueing of this task_work raced with -* work cancelation off the exec path. +* work cancellation off the exec path. */ if (tctx && !atomic_read (&tctx->in_cancel))io_uring_del_tctx_node ((unsigned long )work->ctx);
@@ -2988,7 +2988,7 @@ static __cold void io_ring_ctx_wait_and_kill(struct io_ring_ctx *ctx)/* * Use system_unbound_wq to avoid spawning tons of event kworkers * if we're exiting a ton of rings at the same time. It just adds -* noise and overhead, there's no discernable change in runtime +* noise and overhead, there's no discernible change in runtime * over using system_wq. */ queue_work (iou_wq, &ctx->exit_work);
@@ -3160,7 +3160,7 @@ __cold void io_uring_cancel_generic(bool cancel_all, struct io_sq_data *sqd)if (!tctx_inflight (tctx, !cancel_all))break ; -/* read completions before cancelations */ +/* read completions before cancellations */ inflight =tctx_inflight (tctx, false);if (!inflight)break ;
Signature · 1 line
2.49.0
Jens Axboe
maintainerQuoted 5 lines · Andrew Bernal
Fix minor spelling mistakes in
io_uring.c:
- cancelation -> cancellation
- reuqests -> requests
- discernable -> discernible
- cancelations -> cancellations
As I've replied on this list before, cancelation is a perfectly cromulent spelling. For the rest, not sure it's worth it. And:
io_uring/io_uring.c static void io_req_local_work_add(struct io_kiocb *req, unsigned flags) · line 1168
Quoted 9 lines
io_uring/io_uring.c +1
-1@@ -1162,7 +1162,7 @@ static void io_req_local_work_add(struct io_kiocb *req, unsigned flags)BUILD_BUG_ON (IO_CQ_WAKE_FORCE <=IORING_MAX_CQ_ENTRIES );/* -* We don't know how many reuqests is there in the link and whether +* We don't know how many requests is there in the link and whether * they can even be queued lazily, fall back to non-lazy. */ if (req->flags &IO_REQ_LINK_FLAGS )
mechanical changes like this that don't even look at the sentence (there's more to correct here...) are certainly less worthwhile than making it more coherent in general.
Signature · 1 line
Jens Axboe