perf test: Add basic callgraph test to record testing
Ian Rogers
reviewerPATCH v2 1/1 perf test: Add basic callgraph test to record testing
Give some basic perf record callgraph coverage.
Signed-off-by Ian Rogers <[email protected]>
---
v2: Pick up s390's needed "--call-graph dwarf" as spotted by James
Clark <[email protected]>.
--- tools/perf/tests/shell/record.sh | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+)
tools/perf/tests/shell/record.sh +30 -0
@@ -12,8 +12,10 @@ shelldir=$(dirname "$0") . "${shelldir}"/lib/perf_has_symbol.sh testsym="test_loop" +testsym2="brstack" skip_test_missing_symbol ${testsym} +skip_test_missing_symbol ${testsym2} err=0 perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
@@ -359,6 +361,33 @@ test_precise_max() { fi } +test_callgraph() { + echo "Callgraph test" + + case $(uname -m) + in s390x) + cmd_flags="--call-graph dwarf -e cpu-clock";; + *) + cmd_flags="-g";; + esac + + if ! perf record -o "${perfdata}" $cmd_flags perf test -w brstack + then + echo "Callgraph test [Failed missing output]" + err=1 + return + fi + + if ! perf report -i "${perfdata}" 2>&1 | grep "${testsym2}" + then + echo "Callgraph test [Failed missing symbol]" + err=1 + return + fi + + echo "Callgraph test [Success]" +} + # raise the limit of file descriptors to minimum if [[ $default_fd_limit -lt $min_fd_limit ]]; then ulimit -Sn $min_fd_limit
@@ -374,6 +403,7 @@ test_uid test_leader_sampling test_topdown_leader_sampling test_precise_max +test_callgraph # restore the default value ulimit -Sn $default_fd_limit
Signature · 1 line
2.50.0.727.gbf7dc18ff4-goog
Quoted 60 lines · Ian Rogers
Give some basic perf record callgraph coverage.
Signed-off-by Ian Rogers <[email protected]>---
v2: Pick up s390's needed "--call-graph dwarf" as spotted by James
Clark <[email protected]>.--- tools/perf/tests/shell/record.sh | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+)tools/perf/tests/shell/record.sh +29
-0@@ -12,8 +12,10 @@ shelldir=$(dirname "$0") . "${shelldir}"/lib/perf_has_symbol.sh testsym="test_loop" +testsym2="brstack" skip_test_missing_symbol ${testsym} +skip_test_missing_symbol ${testsym2} err=0 perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX)@@ -359,6 +361,33 @@ test_precise_max() { fi } +test_callgraph() { + echo "Callgraph test" + + case $(uname -m) + in s390x) + cmd_flags="--call-graph dwarf -e cpu-clock";; + *) + cmd_flags="-g";; + esac + + if ! perf record -o "${perfdata}" $cmd_flags perf test -w brstack + then + echo "Callgraph test [Failed missing output]" + err=1 + return + fi + + if ! perf report -i "${perfdata}" 2>&1 | grep "${testsym2}" + then + echo "Callgraph test [Failed missing symbol]" + err=1 + return + fi + + echo "Callgraph test [Success]" +} + # raise the limit of file descriptors to minimum if [[ $default_fd_limit -lt $min_fd_limit ]]; then ulimit -Sn $min_fd_limit
tools/perf/tests/shell/record.sh test_uid · line 409
Quoted 7 lines
tools/perf/tests/shell/record.sh +1
-0@@ -374,6 +403,7 @@ test_uid test_leader_sampling test_topdown_leader_sampling test_precise_max +test_callgraph # restore the default value ulimit -Sn $default_fd_limit
Works ok for s390
Tested-by Thomas Richter <[email protected]>
Signature · 9 lines
Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany -- IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Wolfgang Wendt Geschäftsführung: David Faller Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294
Quoted 66 lines · Thomas Richter
Quoted 65 lines · Ian Rogers
Give some basic perf record callgraph coverage.
Signed-off-by Ian Rogers <[email protected]>---
v2: Pick up s390's needed "--call-graph dwarf" as spotted by James
Clark <[email protected]>.--- tools/perf/tests/shell/record.sh | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+)tools/perf/tests/shell/record.sh +30
-0@@ -12,8 +12,10 @@ shelldir=$(dirname "$0") . "${shelldir}"/lib/perf_has_symbol.sh testsym="test_loop" +testsym2="brstack" skip_test_missing_symbol ${testsym} +skip_test_missing_symbol ${testsym2} err=0 perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX)@@ -359,6 +361,33 @@ test_precise_max() { fi } +test_callgraph() { + echo "Callgraph test" + + case $(uname -m) + in s390x) + cmd_flags="--call-graph dwarf -e cpu-clock";; + *) + cmd_flags="-g";; + esac + + if ! perf record -o "${perfdata}" $cmd_flags perf test -w brstack + then + echo "Callgraph test [Failed missing output]" + err=1 + return + fi + + if ! perf report -i "${perfdata}" 2>&1 | grep "${testsym2}" + then + echo "Callgraph test [Failed missing symbol]" + err=1 + return + fi + + echo "Callgraph test [Success]" +} + # raise the limit of file descriptors to minimum if [[ $default_fd_limit -lt $min_fd_limit ]]; then ulimit -Sn $min_fd_limit@@ -374,6 +403,7 @@ test_uid test_leader_sampling test_topdown_leader_sampling test_precise_max +test_callgraph
Quoted 6 lines
tools/perf/tests/shell/record.sh test_uid · line 409
Quoted 2 lines
tools/perf/tests/shell/record.sh +0
-0# restore the default value ulimit -Sn $default_fd_limitWorks ok for s390
Tested-by Thomas Richter <[email protected]>
Reviewed-by James Clark <[email protected]>
Quoted 3 lines · Ian Rogers
Give some basic perf record callgraph coverage.
Applied to perf-tools-next, thanks!
Best regards,
Namhyung