rose: fix dangling neighbour pointers in rose_rt_device_down()
Subsystems (2)
PATCH v2 1/1 rose: fix dangling neighbour pointers in rose_rt_device_down()
There are two bugs in rose_rt_device_down() that can cause use-after-free:
1. The loop bound t->count is modified within the loop, which can cause the loop to terminate early and miss some entries.
2. When removing an entry from the neighbour array, the subsequent entries are moved up to fill the gap, but the loop index i is still incremented, causing the next entry to be skipped.
For example, if a node has three neighbours (A, A, B) with count=3 and A is being removed, the second A is not checked.
i=0: (A, A, B) -> (A, B) with count=2
^ checked
i=1: (A, B) -> (A, B) with count=2
^ checked (B, not A!)
i=2: (doesn't occur because i < count is false)
This leaves the second A in the array with count=2, but the rose_neigh structure has been freed. Code that accesses these entries assumes that the first count entries are valid pointers, causing a use-after-free when it accesses the dangling pointer.
Fix both issues by iterating over the array in reverse order with a fixed loop bound. This ensures that all entries are examined and that the removal of an entry doesn't affect subsequent iterations.
---
Changes:
v2:
- Change commit message to describe the UAF scenario correctly
- Replace for loop with memmove() for array shifting
v1: https://lore.kernel.org/all/[email protected]/
--- net/rose/rose_route.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-)
net/rose/rose_route.c +4 -11
@@ -497,22 +497,15 @@ void rose_rt_device_down(struct net_device *dev) t = rose_node; rose_node = rose_node->next; -for (i =0 ; i < t->count; i++) { +for (i = t->count -1 ; i >=0 ; i--) {if (t->neighbour[i] != s)continue ; t->count--; -switch (i) { -case 0 : - t->neighbour[0 ] = t->neighbour[1 ]; - fallthrough; -case 1 : - t->neighbour[1 ] = t->neighbour[2 ]; -break ; -case 2 : -break ; - } +memmove (&t->neighbour[i], &t->neighbour[i +1 ], +sizeof (t->neighbour[0 ]) * + (t->count - i)); }if (t->count <=0 )
Signature · 1 line
2.49.0
Quoted 33 lines · Kohei Enju
There are two bugs in
rose_rt_device_down()that can cause use-after-free:1. The loop bound
t->countis modified within the loop, which can cause the loop to terminate early and miss some entries.2. When removing an entry from the neighbour array, the subsequent entries are moved up to fill the gap, but the loop index
iis still incremented, causing the next entry to be skipped.For example, if a node has three neighbours (A, A, B) with count=3 and A is being removed, the second A is not checked.
i=0: (A, A, B) -> (A, B) with count=2
^ checked
i=1: (A, B) -> (A, B) with count=2
^ checked (B, not A!)
i=2: (doesn't occur because i < count is false)This leaves the second A in the array with count=2, but the
rose_neighstructure has been freed. Code that accesses these entries assumes that the firstcountentries are valid pointers, causing a use-after-free when it accesses the dangling pointer.Fix both issues by iterating over the array in reverse order with a fixed loop bound. This ensures that all entries are examined and that the removal of an entry doesn't affect subsequent iterations.
Reported-by [email protected]Tested-by [email protected]Fixes 1da177e4c3f4 ("Linux-2.6.12-rc2")Signed-off-by Kohei Enju <[email protected]>
Quoted 6 lines
---
Changes:
v2:
- Change commit message to describe the UAF scenario correctly
- Replace for loop withmemmove()for array shifting
v1: https://lore.kernel.org/all/[email protected]/
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 11 lines · On Sun, 29 Jun 2025 12:06:31 +0900 you wrote:
There are two bugs in
rose_rt_device_down()that can cause use-after-free:1. The loop bound
t->countis modified within the loop, which can cause the loop to terminate early and miss some entries.2. When removing an entry from the neighbour array, the subsequent entries are moved up to fill the gap, but the loop index
iis still incremented, causing the next entry to be skipped.[...]
Here is the summary with links:
- [net,v2] rose: fix dangling neighbour pointers in rose_rt_device_down()
https://git.kernel.org/netdev/net/c/34a500caf48c
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html