Skip to contentSkip to conversation

staging: media: atomisp: code style cleanup series

PATCH In review LiangCheng Wang 4 participants 6 messages Jun 29, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v7 1/1 staging: media: atomisp: code style cleanup series

This series applies clang-format and fixes all checkpatch.pl-reported ERRORs in the AtomISP driver, excluding the i2c directory as advised by maintainers.

The changes include:
- Applying clang-format (excluding drivers/staging/media/i2c)
- Removing unnecessary parentheses in return statements
- Removing unnecessary zero-initialized globals
- Fixing space issues after unary minus operators
- Wrapping complex macro values in parentheses
- These patches focus solely on mechanical style cleanups with no functional changes.
- WARNINGs reported by checkpatch.pl were intentionally left for future work to keep each patch clear and manageable.

The full series and corresponding commits are also available in my public Git repository:

https://github.com/lc-wang/linux/tree/b4/atomisp

To: Hans de Goede <[email protected]>
To: Mauro Carvalho Chehab <[email protected]>
To: Sakari Ailus <[email protected]>
To: Andy Shevchenko <[email protected]>
To: Greg Kroah-Hartman <[email protected]>
To: Nathan Chancellor <[email protected]>
To: Nick Desaulniers <[email protected]>
To: Bill Wendling <[email protected]>
To: Justin Stitt <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
Changes in v7:
- Split previous monolithic patch into multiple smaller patches
- Applied clang-format to entire driver excluding i2c directory
- Fixed checkpatch.pl-reported ERRORs (parentheses in macros, unnecessary return parentheses, zero-initialized globals, spaces after unary minus)
- Left WARNINGS untouched for future cleanup
- No functional logic changes
- Link to v6: https://lore.kernel.org/r/[email protected]

Changes in v6:
- Applied clang-format across the entire AtomISP driver
- Fixed all checkpatch.pl-reported ERRORs
- Added explanation of tooling and scope
- No functional logic modified
- Moved 'Suggested-by' and 'Link' tags above Signed-off-by
- Link to v5: https://lore.kernel.org/r/[email protected]

Changes in v5:
- Replaced space-based indentation with tabs in output_1.0 directory
- Used checkpatch.pl and grep to identify formatting issues
- No functional changes made
- This patch is now focused solely on tab/space issues
- Link to v4: https://lore.kernel.org/r/[email protected]

Changes in v4:
- Moved assignment operator '=' to the same line for static struct definitions
- Remove unnecessary line breaks in function definitions
- Update commit message to reflect all the coding style fixes
- Link to v3: https://lore.kernel.org/r/[email protected]

Changes in v3:
- Removed extra spaces between type and asterisk (e.g., *to) in function declarations, as pointed out by Andy Shevchenko
- Update commit message to reflect all the coding style fixes
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Fix patch subject prefix to "staging: media: atomisp:" to comply with media CI style.
- No other functional changes.

Link to v1: https://lore.kernel.org/r/[email protected]

--- b4-submit-tracking ---
# This section is used internally by b4 prep for tracking purposes. {

  "series": {
    "revision": 7,
    "change-id": "20250621-bar-573b8b40fb80",
    "prefixes": [],
    "history": {
      "v1": [
        "[email protected]"
      ],
      "v2": [
        "[email protected]"
      ],
      "v3": [
        "[email protected]"
      ],
      "v4": [
        "[email protected]"
      ],
      "v5": [
        "[email protected]"
      ],
      "v6": [
        "[email protected]"
      ]
    }

}
}

Signature · 1 line
2.43.0
#1 lore raw

Hi,

Quoted 24 lines · LiangCheng Wang

This series applies clang-format and fixes all checkpatch.pl-reported ERRORs in the AtomISP driver, excluding the i2c directory as advised by maintainers.

The changes include:
- Applying clang-format (excluding drivers/staging/media/i2c)
- Removing unnecessary parentheses in return statements
- Removing unnecessary zero-initialized globals
- Fixing space issues after unary minus operators
- Wrapping complex macro values in parentheses
- These patches focus solely on mechanical style cleanups with no functional changes.
- WARNINGs reported by checkpatch.pl were intentionally left for future work to keep each patch clear and manageable.

The full series and corresponding commits are also available in my public Git repository:

https://github.com/lc-wang/linux/tree/b4/atomisp

To: Hans de Goede <[email protected]>
To: Mauro Carvalho Chehab <[email protected]>
To: Sakari Ailus <[email protected]>
To: Andy Shevchenko <[email protected]>
To: Greg Kroah-Hartman <[email protected]>
To: Nathan Chancellor <[email protected]>
To: Nick Desaulniers <[email protected]>
To: Bill Wendling <[email protected]>
To: Justin Stitt <[email protected]>

Quoted 8 lines

Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
Changes in v7:
- Split previous monolithic patch into multiple smaller patches
- Applied clang-format to entire driver excluding i2c directory

I took a quick look at just the clang-format patch and looking at the bits of the diff which were not collapsed by github because the changes are too big, it looks like the changes which clang-format makes are useless and often make things worse, e.g. just looking at the first diff which github shows for:

https://github.com/lc-wang/linux/commit/8a3bbdba275e42dfcb0af2ddcc2f27463bb316d2

which is for drivers/staging/media/atomisp/include/hmm/hmm.h then all of the changes are undesirable and unneeded.

so the running of clang-format just seems to make things worse.

I appreciate coding-style cleanups outside of the i2c dir, but it looks like you need to do everything manually since clang-format is just making a mess of things.

Also if you do manual code-style cleanups please do one type of cleanup per patches, e.g. only fix indentation using spaces instead of tabs and do so on groups of say 10 files at a time to keep things reviewable.

Regards,

Hans

Quoted 67 lines

- Fixed checkpatch.pl-reported ERRORs (parentheses in macros, unnecessary return parentheses, zero-initialized globals, spaces after unary minus)
- Left WARNINGS untouched for future cleanup
- No functional logic changes
- Link to v6: https://lore.kernel.org/r/[email protected]

Changes in v6:
- Applied clang-format across the entire AtomISP driver
- Fixed all checkpatch.pl-reported ERRORs
- Added explanation of tooling and scope
- No functional logic modified
- Moved 'Suggested-by' and 'Link' tags above Signed-off-by
- Link to v5: https://lore.kernel.org/r/[email protected]

Changes in v5:
- Replaced space-based indentation with tabs in output_1.0 directory
- Used checkpatch.pl and grep to identify formatting issues
- No functional changes made
- This patch is now focused solely on tab/space issues
- Link to v4: https://lore.kernel.org/r/[email protected]

Changes in v4:
- Moved assignment operator '=' to the same line for static struct definitions
- Remove unnecessary line breaks in function definitions
- Update commit message to reflect all the coding style fixes
- Link to v3: https://lore.kernel.org/r/[email protected]

Changes in v3:
- Removed extra spaces between type and asterisk (e.g., *to) in function declarations, as pointed out by Andy Shevchenko
- Update commit message to reflect all the coding style fixes
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Fix patch subject prefix to "staging: media: atomisp:" to comply with media CI style.
- No other functional changes.

Link to v1: https://lore.kernel.org/r/[email protected]

--- b4-submit-tracking ---
# This section is used internally by b4 prep for tracking purposes. {

  "series": {
    "revision": 7,
    "change-id": "20250621-bar-573b8b40fb80",
    "prefixes": [],
    "history": {
      "v1": [
        "[email protected]"
      ],
      "v2": [
        "[email protected]"
      ],
      "v3": [
        "[email protected]"
      ],
      "v4": [
        "[email protected]"
      ],
      "v5": [
        "[email protected]"
      ],
      "v6": [
        "[email protected]"
      ]
    }

}
}

author
#2 lore raw

Dear Hans and Andy,

Thanks for the feedback. I'll wait for Andy's opinion on this before taking further actions.

Meanwhile, I understand Hans' concerns about clang-format changes and I can prepare manual cleanup patches as suggested if needed.

Best regards,

LiangCheng Wang

Hans de Goede <[email protected]> 於 2025年6月29日 週日 下午8:20寫道:

Quoted 133 lines

Hi,

Quoted 24 lines · LiangCheng Wang

This series applies clang-format and fixes all checkpatch.pl-reported ERRORs in the AtomISP driver, excluding the i2c directory as advised by maintainers.

The changes include:
- Applying clang-format (excluding drivers/staging/media/i2c)
- Removing unnecessary parentheses in return statements
- Removing unnecessary zero-initialized globals
- Fixing space issues after unary minus operators
- Wrapping complex macro values in parentheses
- These patches focus solely on mechanical style cleanups with no functional changes.
- WARNINGs reported by checkpatch.pl were intentionally left for future work to keep each patch clear and manageable.

The full series and corresponding commits are also available in my public Git repository:

https://github.com/lc-wang/linux/tree/b4/atomisp

To: Hans de Goede <[email protected]>
To: Mauro Carvalho Chehab <[email protected]>
To: Sakari Ailus <[email protected]>
To: Andy Shevchenko <[email protected]>
To: Greg Kroah-Hartman <[email protected]>
To: Nathan Chancellor <[email protected]>
To: Nick Desaulniers <[email protected]>
To: Bill Wendling <[email protected]>
To: Justin Stitt <[email protected]>

Quoted 8 lines

Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
Changes in v7:
- Split previous monolithic patch into multiple smaller patches
- Applied clang-format to entire driver excluding i2c directory

I took a quick look at just the clang-format patch and looking at the bits of the diff which were not collapsed by github because the changes are too big, it looks like the changes which clang-format makes are useless and often make things worse, e.g. just looking at the first diff which github shows for:

https://github.com/lc-wang/linux/commit/8a3bbdba275e42dfcb0af2ddcc2f27463bb316d2

which is for drivers/staging/media/atomisp/include/hmm/hmm.h then all of the changes are undesirable and unneeded.

so the running of clang-format just seems to make things worse.

I appreciate coding-style cleanups outside of the i2c dir, but it looks like you need to do everything manually since clang-format is just making a mess of things.

Also if you do manual code-style cleanups please do one type of cleanup per patches, e.g. only fix indentation using spaces instead of tabs and do so on groups of say 10 files at a time to keep things reviewable.

Regards,

Hans

Quoted 67 lines

- Fixed checkpatch.pl-reported ERRORs (parentheses in macros, unnecessary return parentheses, zero-initialized globals, spaces after unary minus)
- Left WARNINGS untouched for future cleanup
- No functional logic changes
- Link to v6: https://lore.kernel.org/r/[email protected]

Changes in v6:
- Applied clang-format across the entire AtomISP driver
- Fixed all checkpatch.pl-reported ERRORs
- Added explanation of tooling and scope
- No functional logic modified
- Moved 'Suggested-by' and 'Link' tags above Signed-off-by
- Link to v5: https://lore.kernel.org/r/[email protected]

Changes in v5:
- Replaced space-based indentation with tabs in output_1.0 directory
- Used checkpatch.pl and grep to identify formatting issues
- No functional changes made
- This patch is now focused solely on tab/space issues
- Link to v4: https://lore.kernel.org/r/[email protected]

Changes in v4:
- Moved assignment operator '=' to the same line for static struct definitions
- Remove unnecessary line breaks in function definitions
- Update commit message to reflect all the coding style fixes
- Link to v3: https://lore.kernel.org/r/[email protected]

Changes in v3:
- Removed extra spaces between type and asterisk (e.g., *to) in function declarations, as pointed out by Andy Shevchenko
- Update commit message to reflect all the coding style fixes
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Fix patch subject prefix to "staging: media: atomisp:" to comply with media CI style.
- No other functional changes.

Link to v1: https://lore.kernel.org/r/[email protected]

--- b4-submit-tracking ---
# This section is used internally by b4 prep for tracking purposes. {

  "series": {
    "revision": 7,
    "change-id": "20250621-bar-573b8b40fb80",
    "prefixes": [],
    "history": {
      "v1": [
        "[email protected]"
      ],
      "v2": [
        "[email protected]"
      ],
      "v3": [
        "[email protected]"
      ],
      "v4": [
        "[email protected]"
      ],
      "v5": [
        "[email protected]"
      ],
      "v6": [
        "[email protected]"
      ]
    }

}
}

#3 lore raw
Quoted 2 lines · 王良丞

Dear Hans and Andy,

First of all, please stop top-posting!

Quoted 2 lines

Thanks for the feedback. I'll wait for Andy's opinion on this before taking further actions.

TBH I don't know what I can help with or should do. I expressed my worries already in one of the previous emails where I suggested to check clang-format and then when we see the first attempt of using it.

Quoted 2 lines

Meanwhile, I understand Hans' concerns about clang-format changes and I can prepare manual cleanup patches as suggested if needed.

Or you can try (without sending each time the result) amending output of clang-format, or you can do a set of scripts based on the problems found... Take your time and experiment more, no need to send a new version every couple of days or so.

Quoted 41 lines
Quoted 41 lines · LiangCheng Wang
Quoted 11 lines

This series applies clang-format and fixes all checkpatch.pl-reported ERRORs in the AtomISP driver, excluding the i2c directory as advised by maintainers.

The changes include:
- Applying clang-format (excluding drivers/staging/media/i2c)
- Removing unnecessary parentheses in return statements
- Removing unnecessary zero-initialized globals
- Fixing space issues after unary minus operators
- Wrapping complex macro values in parentheses
- These patches focus solely on mechanical style cleanups with no functional changes.
- WARNINGs reported by checkpatch.pl were intentionally left for future work to keep each patch clear and manageable.

Quoted 7 lines

The full series and corresponding commits are also available in my public Git repository:

https://github.com/lc-wang/linux/tree/b4/atomisp

Changes in v7:
- Split previous monolithic patch into multiple smaller patches
- Applied clang-format to entire driver excluding i2c directory

I took a quick look at just the clang-format patch and looking at the bits of the diff which were not collapsed by github because the changes are too big, it looks like the changes which clang-format makes are useless and often make things worse, e.g. just looking at the first diff which github shows for:

https://github.com/lc-wang/linux/commit/8a3bbdba275e42dfcb0af2ddcc2f27463bb316d2

which is for drivers/staging/media/atomisp/include/hmm/hmm.h then all of the changes are undesirable and unneeded.

so the running of clang-format just seems to make things worse.

I appreciate coding-style cleanups outside of the i2c dir, but it looks like you need to do everything manually since clang-format is just making a mess of things.

Also if you do manual code-style cleanups please do one type of cleanup per patches, e.g. only fix indentation using spaces instead of tabs and do so on groups of say 10 files at a time to keep things reviewable.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#4 lore raw
In reply to Hans de Goede
Quoted 1 line · Hans de Goede

On 29-Jun-25 1:30 PM, LiangCheng Wang wrote:

...

Quoted 12 lines
Quoted 3 lines

Changes in v7:
- Split previous monolithic patch into multiple smaller patches
- Applied clang-format to entire driver excluding i2c directory

I took a quick look at just the clang-format patch and looking at the bits of the diff which were not collapsed by github because the changes are too big, it looks like the changes which clang-format makes are useless and often make things worse, e.g. just looking at the first diff which github shows for:

https://github.com/lc-wang/linux/commit/8a3bbdba275e42dfcb0af2ddcc2f27463bb316d2

Quoted 8 lines

which is for drivers/staging/media/atomisp/include/hmm/hmm.h then all of the changes are undesirable and unneeded.

so the running of clang-format just seems to make things worse.

I appreciate coding-style cleanups outside of the i2c dir, but it looks like you need to do everything manually since clang-format is just making a mess of things.

Yeah, that what I was afraid of. I don't know clang-format well enough, but it might be that tweaking existing .clang-format in the kernel can give something better.

Quoted 4 lines

Also if you do manual code-style cleanups please do one type of cleanup per patches, e.g. only fix indentation using spaces instead of tabs and do so on groups of say 10 files at a time to keep things reviewable.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#5 lore raw
Quoted 4 lines · Andy Shevchenko

Yeah, that what I was afraid of. I don't know clang-format well enough, but it might be that tweaking existing .clang-format in the kernel can give something better.

Yeah, there are some proposed changes for the config that I have in the backlog, and with a minimum upgrade we can also improve it further (some things just couldn't be done well with the options that were available at the time when I introduced it). That is why, at least so far, clang-format worked best for formatting snippets or for new files.

Cheers,
Miguel