Add QEMU model for ASPEED OTP memory and integrate with SoC
Subsystems (2)
v3 cover Add QEMU model for ASPEED OTP memory and integrate with SoC
From: Kane-Chen-AS <[email protected]>
This patch series introduces a QEMU model for the ASPEED OTP (One-Time Programmable) memory, along with its integration into the Secure Boot Controller (SBC) and supported SoC (AST2600).
The OTP model emulates a simple fuse array used for secure boot or device configuration, implemented with internal buffers; external file/device support not included in this version. It exposes an AddressSpace to support transaction-based access from controllers like the SBC.
This series includes:
- OTP memory device implementation
- SBC integration with command decoding (READ/PROG)
- Direct integration in AST2600 SoC without requiring user parameters
Any feedback or suggestions are appreciated!
Kane
---
ChangeLog
---------
v3:
- Switched to object_property_set_int() for setting "size"
- Simplified qdev_realize() error handling by passing errp directly
- Added "drive" property to OTP model for future extensibility
v2:
- Rename device from 'aspeed_otpmem' to 'aspeed_otp' and move it to hw/nvram/
- Move OTP device realization from instance_init to the realize function
- Improve error logging with qemu_log_mask() and remove unused error propagation
v1:
- Initial version
---
Kane-Chen-AS (3):
hw/misc/aspeed_otp: Add OTP device model with fallback RAM storage hw/misc/aspeed_sbc: Connect ASPEED OTP memory device to SBC hw/arm: Integrate ASPEED OTP memory support into AST2600 SoCs
include/hw/misc/aspeed_sbc.h | 5 ++ include/hw/nvram/aspeed_otp.h | 33 ++++++++++ hw/arm/aspeed_ast2600.c | 2 +- hw/misc/aspeed_sbc.c | 113 ++++++++++++++++++++++++++++++++++ hw/nvram/aspeed_otp.c | 113 ++++++++++++++++++++++++++++++++++ hw/misc/trace-events | 5 ++ hw/nvram/meson.build | 4 ++ 7 files changed, 274 insertions(+), 1 deletion(-) create mode 100644 include/hw/nvram/aspeed_otp.h create mode 100644 hw/nvram/aspeed_otp.c
Signature · 1 line
2.43.0
PATCH v3 1/3 hw/misc/aspeed_otp: Add OTP device model with fallback RAM storage
From: Kane-Chen-AS <[email protected]>
This patch introduces a QEMU model of the ASPEED One-Time Programmable (OTP) memory, used for secure fuse storage. The model simulates a word-addressable OTP region with a memory-like interface via a dedicated AddressSpace.
If no external block backend is provided via the "drive" property, the model automatically allocates an internal RAM-backed storage buffer to hold OTP data, enabling simplified usage without CLI configuration.
--- include/hw/nvram/aspeed_otp.h | 33 ++++++++++ hw/nvram/aspeed_otp.c | 113 ++++++++++++++++++++++++++++++++++ hw/nvram/meson.build | 4 ++ 3 files changed, 150 insertions(+) create mode 100644 include/hw/nvram/aspeed_otp.h create mode 100644 hw/nvram/aspeed_otp.c
include/hw/nvram/aspeed_otp.h new file +33 -0
@@ -0,0 +1,33 @@ +/* +* ASPEED OTP (One-Time Programmable) memory +* +* Copyright (C) 2025 Aspeed +* +* SPDX-License-Identifier: GPL-2.0-or-later +*/ + +#ifndef ASPEED_OTP_H +#define ASPEED_OTP_H + +#include "system/memory.h" +#include "hw/block/block.h" +#include "system/address-spaces.h" + +#define TYPE_ASPEED_OTP "aspeed.otp" +OBJECT_DECLARE_SIMPLE_TYPE(AspeedOTPState, ASPEED_OTP) + +typedef struct AspeedOTPState { +DeviceState parent_obj; + +BlockBackend *blk; + +uint64_t size; + +AddressSpace as; + +MemoryRegion mmio; + +uint8_t *storage; +}AspeedOTPState ; + +#endif /* ASPEED_OTP_H */
hw/nvram/aspeed_otp.c new file +113 -0
113 lines not on this page · raw message
hw/nvram/meson.build +4 -0
@@ -19,3 +19,7 @@ system_ss.add(when: 'CONFIG_XLNX_BBRAM', if_true: files('xlnx-bbram.c')) specific_ss.add(when: 'CONFIG_PSERIES', if_true: files('spapr_nvram.c')) specific_ss.add(when: 'CONFIG_ACPI', if_true: files('fw_cfg-acpi.c')) + +system_ss.add(when: 'CONFIG_ASPEED_SOC', if_true: files( + 'aspeed_otp.c', + ))
Signature · 1 line
2.43.0
Re: [PATCH v3 1/3] hw/misc/aspeed_otp: Add OTP device model with fallback RAM storage
Quoted 183 lines · Kane Chen
From: Kane-Chen-AS <[email protected]>
This patch introduces a QEMU model of the ASPEED One-Time Programmable (OTP) memory, used for secure fuse storage. The model simulates a word-addressable OTP region with a memory-like interface via a dedicated AddressSpace.
If no external block backend is provided via the "drive" property, the model automatically allocates an internal RAM-backed storage buffer to hold OTP data, enabling simplified usage without CLI configuration.
Signed-off-by Kane-Chen-AS <[email protected]>--- include/hw/nvram/aspeed_otp.h | 33 ++++++++++ hw/nvram/aspeed_otp.c | 113 ++++++++++++++++++++++++++++++++++ hw/nvram/meson.build | 4 ++ 3 files changed, 150 insertions(+)create mode 100644
include/hw/nvram/aspeed_otp.hcreate mode 100644hw/nvram/aspeed_otp.cinclude/hw/nvram/aspeed_otp.h new file +33
-0@@ -0,0 +1,33 @@ +/* +* ASPEED OTP (One-Time Programmable) memory +* +* Copyright (C) 2025 Aspeed +* +* SPDX-License-Identifier: GPL-2.0-or-later +*/ + +#ifndef ASPEED_OTP_H +#define ASPEED_OTP_H + +#include "system/memory.h" +#include "hw/block/block.h" +#include "system/address-spaces.h" + +#define TYPE_ASPEED_OTP "aspeed.otp" +OBJECT_DECLARE_SIMPLE_TYPE(AspeedOTPState, ASPEED_OTP) + +typedef struct AspeedOTPState { +DeviceState parent_obj; + +BlockBackend *blk; + +uint64_t size; + +AddressSpace as; + +MemoryRegion mmio; + +uint8_t *storage; +}AspeedOTPState ; + +#endif /* ASPEED_OTP_H */ hw/nvram/aspeed_otp.c new file +113
-0@@ -0,0 +1,113 @@ +/* +* ASPEED OTP (One-Time Programmable) memory +* +* Copyright (C) 2025 Aspeed +* +* SPDX-License-Identifier: GPL-2.0-or-later +*/ + +#include "qemu/osdep.h" +#include "qemu/log.h" +#include "qapi/error.h" +#include "system/block-backend-global-state.h" +#include "system/block-backend-io.h" +#include "hw/qdev-properties.h" +#include "hw/nvram/aspeed_otp.h" + +static uint64_t aspeed_otp_read (void *opaque,hwaddr offset,unsigned size) +{ +AspeedOTPState *s = opaque; +uint64_t val =0 ; + +memcpy (&val, s->storage + offset, size); + +return val; +} + +static void aspeed_otp_write (void *opaque,hwaddr offset, +uint64_t val,unsigned size) +{ +AspeedOTPState *s = opaque; + +memcpy (s->storage + offset, &val, size); +} + +static bool aspeed_otp_init_storage (AspeedOTPState *s,Error **errp) +{ +uint32_t *p; +int i, num; +uint64_t perm; + +if (s->blk) { + perm =BLK_PERM_CONSISTENT_READ | + (blk_supports_write_perm (s->blk) ?BLK_PERM_WRITE :0 ); +if (blk_set_perm (s->blk, perm,BLK_PERM_ALL , errp) <0 ) { +return false; + } +if (blk_pread (s->blk,0 , s->size, s->storage,0 ) <0 ) { +error_setg (errp,"Failed to read the initial flash content" ); +return false; + } + }else { + num = s->size /sizeof (uint32_t ); + p = (uint32_t *)s->storage; +for (i =0 ; i < num; i++) { + p[i] = (i %2 ==0 ) ?0x00000000 :0xFFFFFFFF ; + } + } +return true; +} + +static const MemoryRegionOps aspeed_otp_ops = { + .read = aspeed_otp_read, + .write = aspeed_otp_write, + .endianness =DEVICE_LITTLE_ENDIAN , + .valid.min_access_size =1 , + .valid.max_access_size =4 , +}; + +static void aspeed_otp_realize (DeviceState *dev,Error **errp) +{ +AspeedOTPState *s =ASPEED_OTP (dev); + +if (s->size ==0 ) { +error_setg (errp,"aspeed.otp: 'size' property must be set" ); +return ; + } + + s->storage =blk_blockalign (s->blk, s->size); + +if (!aspeed_otp_init_storage (s, errp)) { +return ; + } + +memory_region_init_io (&s->mmio,OBJECT (dev), &aspeed_otp_ops, + s,"aspeed.otp" , s->size); +address_space_init (&s->as, &s->mmio,NULL ); +} + +static const Property aspeed_otp_properties[] = { +DEFINE_PROP_UINT64 ("size" , AspeedOTPState, size,0 ), +DEFINE_PROP_DRIVE ("drive" , AspeedOTPState, blk), +}; + +static void aspeed_otp_class_init (ObjectClass *klass,const void *data) +{ +DeviceClass *dc =DEVICE_CLASS (klass); + dc->realize = aspeed_otp_realize; +device_class_set_props (dc, aspeed_otp_properties); +} + +static const TypeInfo aspeed_otp_info = { + .name =TYPE_ASPEED_OTP , + .parent =TYPE_DEVICE , + .instance_size =sizeof (AspeedOTPState), + .class_init = aspeed_otp_class_init, +}; + +static void aspeed_otp_register_types (void ) +{ +type_register_static (&aspeed_otp_info); +} + +type_init (aspeed_otp_register_types)hw/nvram/meson.build +0
-0
hw/nvram/meson.build system_ss.add(when: 'CONFIG_XLNX_BBRAM', if_true: files('xlnx-bbram.c')) · line 25
Quoted 8 lines
hw/nvram/meson.build +4
-0@@ -19,3 +19,7 @@ system_ss.add(when: 'CONFIG_XLNX_BBRAM', if_true: files('xlnx-bbram.c')) specific_ss.add(when: 'CONFIG_PSERIES', if_true: files('spapr_nvram.c')) specific_ss.add(when: 'CONFIG_ACPI', if_true: files('fw_cfg-acpi.c')) + +system_ss.add(when: 'CONFIG_ASPEED_SOC', if_true: files( + 'aspeed_otp.c', + ))
The patch looks OK but, in the previous round, I asked to add the BlockBackend and drive in a new patch. May be I wasn't clear ?
Thanks,
C.
RE: [PATCH v3 1/3] hw/misc/aspeed_otp: Add OTP device model with fallback RAM storage
Hi Cédric,
Thanks for pointing that out — sorry for missing your earlier comment.
I'll roll back the BlockBackend and drive part, and send a separate patch for that as suggested.
Best Regards,
Kane
Quoted 212 lines
-----Original Message-----
From: Cédric Le Goater <[email protected]>
Sent: Monday, June 30, 2025 2:18 PM
To: Kane Chen <[email protected]>; Peter Maydell <[email protected]>; Steven Lee <[email protected]>; Troy Lee <[email protected]>; Jamin Lin <[email protected]>; Andrew Jeffery <[email protected]>; Joel Stanley <[email protected]>; open list:ASPEED BMCs <[email protected]>; open list:All patches CC here <[email protected]>
Cc: Troy Lee <[email protected]>
Subject: Re: [PATCH v3 1/3] hw/misc/aspeed_otp: Add OTP device model with fallback RAM storageQuoted 3 lines · Kane Chen
From: Kane-Chen-AS <[email protected]>
This patch introduces a QEMU model of the ASPEED One-Time
Programmable
Quoted 4 lines
(OTP) memory, used for secure fuse storage. The model simulates a word-addressable OTP region with a memory-like interface via a dedicated AddressSpace.
Quoted 8 lines
If no external block backend is provided via the "drive" property, the model automatically allocates an internal RAM-backed storage buffer to hold OTP data, enabling simplified usage without CLI configuration.
Signed-off-by Kane-Chen-AS <[email protected]>--- include/hw/nvram/aspeed_otp.h | 33 ++++++++++ hw/nvram/aspeed_otp.c | 113++++++++++++++++++++++++++++++++++
Quoted 78 lines
hw/nvram/meson.build | 4 ++ 3 files changed, 150 insertions(+)create mode 100644
include/hw/nvram/aspeed_otp.hcreate mode 100644hw/nvram/aspeed_otp.c(quoted diff) +0
-0
b/include/hw/nvram/aspeed_otp.hnew file mode 100644 index 0000000000..22b2195a00include/hw/nvram/aspeed_otp.h new file +32
-0@@ -0,0 +1,33 @@ +/* +* ASPEED OTP (One-Time Programmable) memory +* +* Copyright (C) 2025 Aspeed +* +* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef ASPEED_OTP_H +#define ASPEED_OTP_H + +#include "system/memory.h" +#include "hw/block/block.h" +#include "system/address-spaces.h" + +#define TYPE_ASPEED_OTP "aspeed.otp" +OBJECT_DECLARE_SIMPLE_TYPE(AspeedOTPState, ASPEED_OTP) + +typedef struct AspeedOTPState { +DeviceState parent_obj; + +BlockBackend *blk; + +uint64_t size; + +AddressSpace as; + +MemoryRegion mmio; + +uint8_t *storage; +}AspeedOTPState ; + +#endif /* ASPEED_OTP_H */ hw/nvram/aspeed_otp.c new file renamed from hw/nvram/aspeed_otp.c +0
-0mode 100644 index 0000000000..f018c58713
hw/nvram/aspeed_otp.c new file +30
-0@@ -0,0 +1,113 @@ +/* +* ASPEED OTP (One-Time Programmable) memory +* +* Copyright (C) 2025 Aspeed +* +* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include "qemu/osdep.h" +#include "qemu/log.h" +#include "qapi/error.h" +#include "system/block-backend-global-state.h" +#include "system/block-backend-io.h" +#include "hw/qdev-properties.h" +#include "hw/nvram/aspeed_otp.h" + +static uint64_t aspeed_otp_read (void *opaque,hwaddr offset,unsigned +size) { +AspeedOTPState *s = opaque; +uint64_t val =0 ; + +memcpy (&val, s->storage + offset, size); + +return val; +} + +static void aspeed_otp_write (void *opaque,hwaddr offset, +uint64_t val,unsigned size) { +AspeedOTPState *s = opaque; + +memcpy (s->storage + offset, &val, size); }hw/nvram/aspeed_otp.c line 40
Quoted 10 lines
hw/nvram/aspeed_otp.c new file +10
-0+ +static bool aspeed_otp_init_storage (AspeedOTPState *s,Error **errp) +{ +uint32_t *p; +int i, num; +uint64_t perm; + +if (s->blk) { + perm = BLK_PERM_CONSISTENT_READ | + (blk_supports_write_perm(s->blk) ? BLK_PERM_WRITE :0);
hw/nvram/meson.build system_ss.add(when: 'CONFIG_XLNX_BBRAM',
Quoted 70 lines
hw/nvram/aspeed_otp.c new file +65
-0+if (blk_set_perm (s->blk, perm,BLK_PERM_ALL , errp) <0 ) { +return false; + } +if (blk_pread (s->blk,0 , s->size, s->storage,0 ) <0 ) { +error_setg (errp,"Failed to read the initial flash content" ); +return false; + } + }else { + num = s->size /sizeof (uint32_t ); + p = (uint32_t *)s->storage; +for (i =0 ; i < num; i++) { + p[i] = (i %2 ==0 ) ?0x00000000 :0xFFFFFFFF ; + } + } +return true; +} + +static const MemoryRegionOps aspeed_otp_ops = { + .read = aspeed_otp_read, + .write = aspeed_otp_write, + .endianness =DEVICE_LITTLE_ENDIAN , + .valid.min_access_size =1 , + .valid.max_access_size =4 , +}; + +static void aspeed_otp_realize (DeviceState *dev,Error **errp) { +AspeedOTPState *s =ASPEED_OTP (dev); + +if (s->size ==0 ) { +error_setg (errp,"aspeed.otp: 'size' property must be set" ); +return ; + } + + s->storage =blk_blockalign (s->blk, s->size); + +if (!aspeed_otp_init_storage (s, errp)) { +return ; + } + +memory_region_init_io (&s->mmio,OBJECT (dev), &aspeed_otp_ops, + s,"aspeed.otp" , s->size); +address_space_init (&s->as, &s->mmio,NULL ); } + +static const Property aspeed_otp_properties[] = { +DEFINE_PROP_UINT64 ("size" , AspeedOTPState, size,0 ), +DEFINE_PROP_DRIVE ("drive" , AspeedOTPState, blk), }; + +static void aspeed_otp_class_init (ObjectClass *klass,const void +*data) { +DeviceClass *dc =DEVICE_CLASS (klass); + dc->realize = aspeed_otp_realize; +device_class_set_props (dc, aspeed_otp_properties); } + +static const TypeInfo aspeed_otp_info = { + .name =TYPE_ASPEED_OTP , + .parent =TYPE_DEVICE , + .instance_size =sizeof (AspeedOTPState), + .class_init = aspeed_otp_class_init, +}; + +static void aspeed_otp_register_types (void ) { +type_register_static (&aspeed_otp_info); +} + +type_init (aspeed_otp_register_types)hw/nvram/meson.build index renamed from hw/nvram/meson.build +0
-0
10f3639db6..b66f23605b100644hw/nvram/meson.build +0
-0@@ -19,3 +19,7 @@ system_ss.add(when: 'CONFIG_XLNX_BBRAM',
if_true:hw/nvram/meson.build system_ss.add(when: 'CONFIG_XLNX_BBRAM', if_true: files('xlnx-bbram.c')) · line 25
Quoted 10 lines
hw/nvram/meson.build +0
-0files('xlnx-bbram.c')) specific_ss.add(when: 'CONFIG_PSERIES', if_true: files('spapr_nvram.c')) specific_ss.add(when: 'CONFIG_ACPI', if_true:
files('fw_cfg-acpi.c'))hw/nvram/meson.build +4
-0+ +system_ss.add(when: 'CONFIG_ASPEED_SOC', if_true: files( + 'aspeed_otp.c', + ))The patch looks OK but, in the previous round, I asked to add the BlockBackend and drive in a new patch. May be I wasn't clear ?
Thanks,
C.
Re: [PATCH v3 1/3] hw/misc/aspeed_otp: Add OTP device model with fallback RAM storage
In reply to Kane Chen viaQuoted 32 lines · Kane Chen
From: Kane-Chen-AS <[email protected]>
This patch introduces a QEMU model of the ASPEED One-Time Programmable (OTP) memory, used for secure fuse storage. The model simulates a word-addressable OTP region with a memory-like interface via a dedicated AddressSpace.
If no external block backend is provided via the "drive" property, the model automatically allocates an internal RAM-backed storage buffer to hold OTP data, enabling simplified usage without CLI configuration.
Signed-off-by Kane-Chen-AS <[email protected]>--- include/hw/nvram/aspeed_otp.h | 33 ++++++++++ hw/nvram/aspeed_otp.c | 113 ++++++++++++++++++++++++++++++++++ hw/nvram/meson.build | 4 ++ 3 files changed, 150 insertions(+)create mode 100644
include/hw/nvram/aspeed_otp.hcreate mode 100644hw/nvram/aspeed_otp.cinclude/hw/nvram/aspeed_otp.h new file +6
-0@@ -0,0 +1,33 @@ +/* +* ASPEED OTP (One-Time Programmable) memory +* +* Copyright (C) 2025 Aspeed +* +* SPDX-License-Identifier: GPL-2.0-or-later
include/hw/nvram/aspeed_otp.h line 16
Quoted 10 lines
include/hw/nvram/aspeed_otp.h new file +10
-0+*/ + +#ifndef ASPEED_OTP_H +#define ASPEED_OTP_H + +#include "system/memory.h" +#include "hw/block/block.h" +#include "system/address-spaces.h" + +#define TYPE_ASPEED_OTP "aspeed.otp"
Please change to "aspeed-otp" so that we can use :
-global aspeed-otp.drive="foo"
to define a backend.
Thanks,
C.
Quoted 149 lines
include/hw/nvram/aspeed_otp.h new file +17
-0+OBJECT_DECLARE_SIMPLE_TYPE(AspeedOTPState, ASPEED_OTP) + +typedef struct AspeedOTPState { +DeviceState parent_obj; + +BlockBackend *blk; + +uint64_t size; + +AddressSpace as; + +MemoryRegion mmio; + +uint8_t *storage; +}AspeedOTPState ; + +#endif /* ASPEED_OTP_H */ hw/nvram/aspeed_otp.c new file +113
-0@@ -0,0 +1,113 @@ +/* +* ASPEED OTP (One-Time Programmable) memory +* +* Copyright (C) 2025 Aspeed +* +* SPDX-License-Identifier: GPL-2.0-or-later +*/ + +#include "qemu/osdep.h" +#include "qemu/log.h" +#include "qapi/error.h" +#include "system/block-backend-global-state.h" +#include "system/block-backend-io.h" +#include "hw/qdev-properties.h" +#include "hw/nvram/aspeed_otp.h" + +static uint64_t aspeed_otp_read (void *opaque,hwaddr offset,unsigned size) +{ +AspeedOTPState *s = opaque; +uint64_t val =0 ; + +memcpy (&val, s->storage + offset, size); + +return val; +} + +static void aspeed_otp_write (void *opaque,hwaddr offset, +uint64_t val,unsigned size) +{ +AspeedOTPState *s = opaque; + +memcpy (s->storage + offset, &val, size); +} + +static bool aspeed_otp_init_storage (AspeedOTPState *s,Error **errp) +{ +uint32_t *p; +int i, num; +uint64_t perm; + +if (s->blk) { + perm =BLK_PERM_CONSISTENT_READ | + (blk_supports_write_perm (s->blk) ?BLK_PERM_WRITE :0 ); +if (blk_set_perm (s->blk, perm,BLK_PERM_ALL , errp) <0 ) { +return false; + } +if (blk_pread (s->blk,0 , s->size, s->storage,0 ) <0 ) { +error_setg (errp,"Failed to read the initial flash content" ); +return false; + } + }else { + num = s->size /sizeof (uint32_t ); + p = (uint32_t *)s->storage; +for (i =0 ; i < num; i++) { + p[i] = (i %2 ==0 ) ?0x00000000 :0xFFFFFFFF ; + } + } +return true; +} + +static const MemoryRegionOps aspeed_otp_ops = { + .read = aspeed_otp_read, + .write = aspeed_otp_write, + .endianness =DEVICE_LITTLE_ENDIAN , + .valid.min_access_size =1 , + .valid.max_access_size =4 , +}; + +static void aspeed_otp_realize (DeviceState *dev,Error **errp) +{ +AspeedOTPState *s =ASPEED_OTP (dev); + +if (s->size ==0 ) { +error_setg (errp,"aspeed.otp: 'size' property must be set" ); +return ; + } + + s->storage =blk_blockalign (s->blk, s->size); + +if (!aspeed_otp_init_storage (s, errp)) { +return ; + } + +memory_region_init_io (&s->mmio,OBJECT (dev), &aspeed_otp_ops, + s,"aspeed.otp" , s->size); +address_space_init (&s->as, &s->mmio,NULL ); +} + +static const Property aspeed_otp_properties[] = { +DEFINE_PROP_UINT64 ("size" , AspeedOTPState, size,0 ), +DEFINE_PROP_DRIVE ("drive" , AspeedOTPState, blk), +}; + +static void aspeed_otp_class_init (ObjectClass *klass,const void *data) +{ +DeviceClass *dc =DEVICE_CLASS (klass); + dc->realize = aspeed_otp_realize; +device_class_set_props (dc, aspeed_otp_properties); +} + +static const TypeInfo aspeed_otp_info = { + .name =TYPE_ASPEED_OTP , + .parent =TYPE_DEVICE , + .instance_size =sizeof (AspeedOTPState), + .class_init = aspeed_otp_class_init, +}; + +static void aspeed_otp_register_types (void ) +{ +type_register_static (&aspeed_otp_info); +} + +type_init (aspeed_otp_register_types)hw/nvram/meson.build +4
-0@@ -19,3 +19,7 @@ system_ss.add(when: 'CONFIG_XLNX_BBRAM', if_true: files('xlnx-bbram.c')) specific_ss.add(when: 'CONFIG_PSERIES', if_true: files('spapr_nvram.c')) specific_ss.add(when: 'CONFIG_ACPI', if_true: files('fw_cfg-acpi.c')) + +system_ss.add(when: 'CONFIG_ASPEED_SOC', if_true: files( + 'aspeed_otp.c', + ))
RE: [PATCH v3 1/3] hw/misc/aspeed_otp: Add OTP device model with fallback RAM storage
Hi Cédric,
Got it, I'll rename the type to "aspeed-otp" as suggested to support the global property syntax.
Thanks for the clarification!
Best regards,
Kane
Quoted 215 lines
-----Original Message-----
From: Cédric Le Goater <[email protected]>
Sent: Monday, June 30, 2025 2:28 PM
To: Kane Chen <[email protected]>; Peter Maydell <[email protected]>; Steven Lee <[email protected]>; Troy Lee <[email protected]>; Jamin Lin <[email protected]>; Andrew Jeffery <[email protected]>; Joel Stanley <[email protected]>; open list:ASPEED BMCs <[email protected]>; open list:All patches CC here <[email protected]>
Cc: Troy Lee <[email protected]>
Subject: Re: [PATCH v3 1/3] hw/misc/aspeed_otp: Add OTP device model with fallback RAM storageQuoted 3 lines · Kane Chen
From: Kane-Chen-AS <[email protected]>
This patch introduces a QEMU model of the ASPEED One-Time
Programmable
Quoted 4 lines
(OTP) memory, used for secure fuse storage. The model simulates a word-addressable OTP region with a memory-like interface via a dedicated AddressSpace.
Quoted 8 lines
If no external block backend is provided via the "drive" property, the model automatically allocates an internal RAM-backed storage buffer to hold OTP data, enabling simplified usage without CLI configuration.
Signed-off-by Kane-Chen-AS <[email protected]>--- include/hw/nvram/aspeed_otp.h | 33 ++++++++++ hw/nvram/aspeed_otp.c | 113++++++++++++++++++++++++++++++++++
Quoted 16 lines
hw/nvram/meson.build | 4 ++ 3 files changed, 150 insertions(+)create mode 100644
include/hw/nvram/aspeed_otp.hcreate mode 100644hw/nvram/aspeed_otp.c(quoted diff) +0
-0
b/include/hw/nvram/aspeed_otp.hnew file mode 100644 index 0000000000..22b2195a00include/hw/nvram/aspeed_otp.h new file +5
-0@@ -0,0 +1,33 @@ +/* +* ASPEED OTP (One-Time Programmable) memory +* +* Copyright (C) 2025 Aspeed +* include/hw/nvram/aspeed_otp.h line 15
Quoted 10 lines
include/hw/nvram/aspeed_otp.h new file +10
-0+* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef ASPEED_OTP_H +#define ASPEED_OTP_H + +#include "system/memory.h" +#include "hw/block/block.h" +#include "system/address-spaces.h" + +#define TYPE_ASPEED_OTP "aspeed.otp"Please change to "aspeed-otp" so that we can use :
-global aspeed-otp.drive="foo"
to define a backend.
Thanks,
C.
Quoted 52 lines
include/hw/nvram/aspeed_otp.h new file +17
-0+OBJECT_DECLARE_SIMPLE_TYPE(AspeedOTPState, ASPEED_OTP) + +typedef struct AspeedOTPState { +DeviceState parent_obj; + +BlockBackend *blk; + +uint64_t size; + +AddressSpace as; + +MemoryRegion mmio; + +uint8_t *storage; +}AspeedOTPState ; + +#endif /* ASPEED_OTP_H */ hw/nvram/aspeed_otp.c new file renamed from hw/nvram/aspeed_otp.c +0
-0mode 100644 index 0000000000..f018c58713
hw/nvram/aspeed_otp.c new file +30
-0@@ -0,0 +1,113 @@ +/* +* ASPEED OTP (One-Time Programmable) memory +* +* Copyright (C) 2025 Aspeed +* +* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include "qemu/osdep.h" +#include "qemu/log.h" +#include "qapi/error.h" +#include "system/block-backend-global-state.h" +#include "system/block-backend-io.h" +#include "hw/qdev-properties.h" +#include "hw/nvram/aspeed_otp.h" + +static uint64_t aspeed_otp_read (void *opaque,hwaddr offset,unsigned +size) { +AspeedOTPState *s = opaque; +uint64_t val =0 ; + +memcpy (&val, s->storage + offset, size); + +return val; +} + +static void aspeed_otp_write (void *opaque,hwaddr offset, +uint64_t val,unsigned size) { +AspeedOTPState *s = opaque; + +memcpy (s->storage + offset, &val, size); }hw/nvram/aspeed_otp.c line 40
Quoted 10 lines
hw/nvram/aspeed_otp.c new file +10
-0+ +static bool aspeed_otp_init_storage (AspeedOTPState *s,Error **errp) +{ +uint32_t *p; +int i, num; +uint64_t perm; + +if (s->blk) { + perm = BLK_PERM_CONSISTENT_READ | + (blk_supports_write_perm(s->blk) ? BLK_PERM_WRITE :0);
hw/nvram/meson.build system_ss.add(when: 'CONFIG_XLNX_BBRAM',
Quoted 70 lines
hw/nvram/aspeed_otp.c new file +65
-0+if (blk_set_perm (s->blk, perm,BLK_PERM_ALL , errp) <0 ) { +return false; + } +if (blk_pread (s->blk,0 , s->size, s->storage,0 ) <0 ) { +error_setg (errp,"Failed to read the initial flash content" ); +return false; + } + }else { + num = s->size /sizeof (uint32_t ); + p = (uint32_t *)s->storage; +for (i =0 ; i < num; i++) { + p[i] = (i %2 ==0 ) ?0x00000000 :0xFFFFFFFF ; + } + } +return true; +} + +static const MemoryRegionOps aspeed_otp_ops = { + .read = aspeed_otp_read, + .write = aspeed_otp_write, + .endianness =DEVICE_LITTLE_ENDIAN , + .valid.min_access_size =1 , + .valid.max_access_size =4 , +}; + +static void aspeed_otp_realize (DeviceState *dev,Error **errp) { +AspeedOTPState *s =ASPEED_OTP (dev); + +if (s->size ==0 ) { +error_setg (errp,"aspeed.otp: 'size' property must be set" ); +return ; + } + + s->storage =blk_blockalign (s->blk, s->size); + +if (!aspeed_otp_init_storage (s, errp)) { +return ; + } + +memory_region_init_io (&s->mmio,OBJECT (dev), &aspeed_otp_ops, + s,"aspeed.otp" , s->size); +address_space_init (&s->as, &s->mmio,NULL ); } + +static const Property aspeed_otp_properties[] = { +DEFINE_PROP_UINT64 ("size" , AspeedOTPState, size,0 ), +DEFINE_PROP_DRIVE ("drive" , AspeedOTPState, blk), }; + +static void aspeed_otp_class_init (ObjectClass *klass,const void +*data) { +DeviceClass *dc =DEVICE_CLASS (klass); + dc->realize = aspeed_otp_realize; +device_class_set_props (dc, aspeed_otp_properties); } + +static const TypeInfo aspeed_otp_info = { + .name =TYPE_ASPEED_OTP , + .parent =TYPE_DEVICE , + .instance_size =sizeof (AspeedOTPState), + .class_init = aspeed_otp_class_init, +}; + +static void aspeed_otp_register_types (void ) { +type_register_static (&aspeed_otp_info); +} + +type_init (aspeed_otp_register_types)hw/nvram/meson.build index renamed from hw/nvram/meson.build +0
-0
10f3639db6..b66f23605b100644hw/nvram/meson.build +0
-0@@ -19,3 +19,7 @@ system_ss.add(when: 'CONFIG_XLNX_BBRAM',
if_true:Quoted 10 lines
hw/nvram/meson.build +0
-0files('xlnx-bbram.c')) specific_ss.add(when: 'CONFIG_PSERIES', if_true: files('spapr_nvram.c')) specific_ss.add(when: 'CONFIG_ACPI', if_true:
files('fw_cfg-acpi.c'))hw/nvram/meson.build +4
-0+ +system_ss.add(when: 'CONFIG_ASPEED_SOC', if_true: files( + 'aspeed_otp.c', + ))
PATCH v3 2/3 hw/misc/aspeed_sbc: Connect ASPEED OTP memory device to SBC
In reply to Kane Chen viaFrom: Kane-Chen-AS <[email protected]>
This patch connects the aspeed.otp device to the ASPEED Secure Boot Controller (SBC) model. It implements OTP memory access via the SBC's command interface and enables emulation of secure fuse programming flows.
The following OTP commands are supported:
- READ: reads a 32-bit word from OTP memory into internal registers
- PROG: programs a 32-bit word value to the specified OTP address
Trace events are added to observe read/program operations and command handling flow.
--- include/hw/misc/aspeed_sbc.h | 5 ++ hw/misc/aspeed_sbc.c | 111 +++++++++++++++++++++++++++++++++++ hw/misc/trace-events | 5 ++ 3 files changed, 121 insertions(+)
include/hw/misc/aspeed_sbc.h +5 -0
@@ -10,6 +10,7 @@#define ASPEED_SBC_H #include "hw/sysbus.h" +#include "hw/nvram/aspeed_otp.h" #define TYPE_ASPEED_SBC "aspeed.sbc"#define TYPE_ASPEED_AST2600_SBC TYPE_ASPEED_SBC "-ast2600"
@@ -36,10 +37,14 @@ struct AspeedSBCState {MemoryRegion iomem;uint32_t regs[ASPEED_SBC_NR_REGS ]; + + AspeedOTPState otp; };struct AspeedSBCClass {SysBusDeviceClass parent_class; + +bool has_otp; };#endif /* ASPEED_SBC_H */
hw/misc/aspeed_sbc.c +111 -0
154 lines not on this page · raw message
hw/misc/trace-events +5 -0
@@ -90,6 +90,11 @@ slavio_sysctrl_mem_readl(uint32_t ret) "Read system control 0x%08x" slavio_led_mem_writew(uint32_t val) "Write diagnostic LED 0x%04x" slavio_led_mem_readw(uint32_t ret) "Read diagnostic LED 0x%04x" +# aspeed_sbc.c +aspeed_sbc_handle_cmd(uint32_t cmd, uint32_t addr, bool ret) "Handling command 0x%" PRIx32 " for OTP addr 0x%" PRIx32 " Result: %d" +aspeed_sbc_otp_read(uint32_t addr, uint32_t value) "OTP Memory read: addr 0x%" PRIx32 " value 0x%" PRIx32 +aspeed_sbc_otp_prog(uint32_t addr, uint32_t value) "OTP Memory write: addr 0x%" PRIx32 " value 0x%" PRIx32 + # aspeed_scu.c aspeed_scu_write(uint64_t offset, unsigned size, uint32_t data) "To 0x%" PRIx64 " of size %u: 0x%" PRIx32 aspeed_scu_read(uint64_t offset, unsigned size, uint32_t data) "To 0x%" PRIx64 " of size %u: 0x%" PRIx32
Signature · 1 line
2.43.0
Re: [PATCH v3 2/3] hw/misc/aspeed_sbc: Connect ASPEED OTP memory device to SBC
Quoted 6 lines · Kane Chen
From: Kane-Chen-AS <[email protected]>
This patch connects the aspeed.otp device to the ASPEED Secure Boot Controller (SBC) model. It implements OTP memory access via the SBC's command interface and enables emulation of secure fuse programming flows.
Quoted 8 lines
The following OTP commands are supported:
- READ: reads a 32-bit word from OTP memory into internal registers
- PROG: programs a 32-bit word value to the specified OTP addressTrace events are added to observe read/program operations and command handling flow.
Signed-off-by Kane-Chen-AS <[email protected]>
Thanks,
C.
Quoted 213 lines
--- include/hw/misc/aspeed_sbc.h | 5 ++ hw/misc/aspeed_sbc.c | 111 +++++++++++++++++++++++++++++++++++ hw/misc/trace-events | 5 ++ 3 files changed, 121 insertions(+)include/hw/misc/aspeed_sbc.h +5
-0@@ -10,6 +10,7 @@#define ASPEED_SBC_H #include "hw/sysbus.h" +#include "hw/nvram/aspeed_otp.h" #define TYPE_ASPEED_SBC "aspeed.sbc"#define TYPE_ASPEED_AST2600_SBC TYPE_ASPEED_SBC "-ast2600"@@ -36,10 +37,14 @@ struct AspeedSBCState {MemoryRegion iomem;uint32_t regs[ASPEED_SBC_NR_REGS ]; + + AspeedOTPState otp; };struct AspeedSBCClass {SysBusDeviceClass parent_class; + +bool has_otp; };#endif /* ASPEED_SBC_H */ hw/misc/aspeed_sbc.c +111
-0@@ -15,9 +15,13 @@#include "hw/misc/aspeed_sbc.h" #include "qapi/error.h" #include "migration/vmstate.h" +#include "trace.h" #define R_PROT (0x000 / 4) +#define R_CMD (0x004 / 4) +#define R_ADDR (0x010 / 4)#define R_STATUS (0x014 / 4) +#define R_CAMP1 (0x020 / 4)#define R_QSR (0x040 / 4)/* R_STATUS */ @@ -41,6 +45,11 @@#define QSR_RSA_MASK (0x3 << 12)#define QSR_HASH_MASK (0x3 << 10) +#define OTP_MEMORY_SIZE 0x4000 +/* OTP command */ +#define SBC_OTP_CMD_READ 0x23b1e361 +#define SBC_OTP_CMD_PROG 0x23b1e364 +static uint64_t aspeed_sbc_read (void *opaque,hwaddr addr,unsigned int size) {AspeedSBCState *s =ASPEED_SBC (opaque);@@ -57,6 +66,84 @@ static uint64_t aspeed_sbc_read(void *opaque, hwaddr addr, unsigned int size)return s->regs[addr]; } +static bool aspeed_sbc_otp_read (AspeedSBCState *s, +uint32_t otp_addr) +{ +MemTxResult ret; +AspeedOTPState *otp = &s->otp; +uint32_t value, otp_offset; + + otp_offset = otp_addr <<2 ; + ret =address_space_read (&otp->as, otp_offset,MEMTXATTRS_UNSPECIFIED , + &value,sizeof (value)); +if (ret !=MEMTX_OK ) { +qemu_log_mask (LOG_GUEST_ERROR , +"Failed to read OTP memory, addr = %x\n" , + otp_addr); +return false; + } + s->regs[R_CAMP1 ] = value; +trace_aspeed_sbc_otp_read (otp_addr, value); + +return true; +} + +static bool aspeed_sbc_otp_prog (AspeedSBCState *s, +uint32_t otp_addr) +{ +MemTxResult ret; +AspeedOTPState *otp = &s->otp; +uint32_t value = s->regs[R_CAMP1 ]; + + ret =address_space_write (&otp->as, otp_addr,MEMTXATTRS_UNSPECIFIED , + &value,sizeof (value)); +if (ret !=MEMTX_OK ) { +qemu_log_mask (LOG_GUEST_ERROR , +"Failed to write OTP memory, addr = %x\n" , + otp_addr); +return false; + } + +trace_aspeed_sbc_otp_prog (otp_addr, value); + +return true; +} + +static void aspeed_sbc_handle_command (void *opaque,uint32_t cmd) +{ +AspeedSBCState *s =ASPEED_SBC (opaque); +AspeedSBCClass *sc =ASPEED_SBC_GET_CLASS (opaque); +bool ret = false; +uint32_t otp_addr; + +if (!sc->has_otp) { +qemu_log_mask (LOG_GUEST_ERROR , +"%s: OTP memory is not supported\n" , + __func__); +return ; + } + + s->regs[R_STATUS ] &= ~(OTP_MEM_IDLE |OTP_IDLE ); + otp_addr = s->regs[R_ADDR ]; + +switch (cmd) { +case SBC_OTP_CMD_READ : + ret =aspeed_sbc_otp_read (s, otp_addr); +break ; +case SBC_OTP_CMD_PROG : + ret =aspeed_sbc_otp_prog (s, otp_addr); +break ; +default : +qemu_log_mask (LOG_GUEST_ERROR , +"%s: Unknown command 0x%x\n" , + __func__, cmd); +break ; + } + +trace_aspeed_sbc_handle_cmd (cmd, otp_addr, ret); + s->regs[R_STATUS ] |= (OTP_MEM_IDLE |OTP_IDLE ); +} +static void aspeed_sbc_write (void *opaque,hwaddr addr,uint64_t data,unsigned int size) {@@ -78,6 +165,9 @@ static void aspeed_sbc_write(void *opaque, hwaddr addr, uint64_t data,"%s: write to read only register 0x%" HWADDR_PRIx"\n" , __func__, addr << 2);return ; +case R_CMD : +aspeed_sbc_handle_command (opaque, data); +return ;default :break ; }@@ -115,10 +205,30 @@ static void aspeed_sbc_reset(DeviceState *dev) s->regs[R_QSR ] = s->signing_settings; } +static void aspeed_sbc_instance_init (Object *obj) +{ +AspeedSBCClass *sc =ASPEED_SBC_GET_CLASS (obj); +AspeedSBCState *s =ASPEED_SBC (obj); + +if (sc->has_otp) { +object_initialize_child (OBJECT (s),"otp" , &s->otp, +TYPE_ASPEED_OTP ); + } +} +static void aspeed_sbc_realize (DeviceState *dev,Error **errp) {AspeedSBCState *s =ASPEED_SBC (dev);SysBusDevice *sbd =SYS_BUS_DEVICE (dev); +AspeedSBCClass *sc =ASPEED_SBC_GET_CLASS (dev); + +if (sc->has_otp) { +object_property_set_int (OBJECT (&s->otp),"size" , +OTP_MEMORY_SIZE , &error_abort); +if (!qdev_realize (DEVICE (&s->otp),NULL , errp)) { +return ; + } + }memory_region_init_io (&s->iomem,OBJECT (s), &aspeed_sbc_ops, s,TYPE_ASPEED_SBC ,0x1000 );@@ -155,6 +265,7 @@ static const TypeInfo aspeed_sbc_info = { .name = TYPE_ASPEED_SBC, .parent = TYPE_SYS_BUS_DEVICE, .instance_size = sizeof(AspeedSBCState), + .instance_init = aspeed_sbc_instance_init, .class_init = aspeed_sbc_class_init, .class_size = sizeof(AspeedSBCClass) };hw/misc/trace-events +5
-0@@ -90,6 +90,11 @@ slavio_sysctrl_mem_readl(uint32_t ret) "Read system control 0x%08x" slavio_led_mem_writew(uint32_t val) "Write diagnostic LED 0x%04x" slavio_led_mem_readw(uint32_t ret) "Read diagnostic LED 0x%04x" +# aspeed_sbc.c +aspeed_sbc_handle_cmd(uint32_t cmd, uint32_t addr, bool ret) "Handling command 0x%" PRIx32 " for OTP addr 0x%" PRIx32 " Result: %d" +aspeed_sbc_otp_read(uint32_t addr, uint32_t value) "OTP Memory read: addr 0x%" PRIx32 " value 0x%" PRIx32 +aspeed_sbc_otp_prog(uint32_t addr, uint32_t value) "OTP Memory write: addr 0x%" PRIx32 " value 0x%" PRIx32 + # aspeed_scu.c aspeed_scu_write(uint64_t offset, unsigned size, uint32_t data) "To 0x%" PRIx64 " of size %u: 0x%" PRIx32 aspeed_scu_read(uint64_t offset, unsigned size, uint32_t data) "To 0x%" PRIx64 " of size %u: 0x%" PRIx32
PATCH v3 3/3 hw/arm: Integrate ASPEED OTP memory support into AST2600 SoCs
In reply to Kane Chen viaFrom: Kane-Chen-AS <[email protected]>
The has_otpmem attribute is enabled in the SBC subclasses for AST2600 to control the presence of OTP support per SoC type.
--- hw/arm/aspeed_ast2600.c | 2 +- hw/misc/aspeed_sbc.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-)
hw/arm/aspeed_ast2600.c +1 -1
@@ -261,7 +261,7 @@ static void aspeed_soc_ast2600_init(Object *obj)object_initialize_child (obj,"i3c" , &s->i3c,TYPE_ASPEED_I3C ); -object_initialize_child (obj,"sbc" , &s->sbc,TYPE_ASPEED_SBC ); +object_initialize_child (obj,"sbc" , &s->sbc,TYPE_ASPEED_AST2600_SBC );object_initialize_child (obj,"iomem" , &s->iomem,TYPE_UNIMPLEMENTED_DEVICE );object_initialize_child (obj,"video" , &s->video,TYPE_UNIMPLEMENTED_DEVICE );
hw/misc/aspeed_sbc.c +2 -0
@@ -273,8 +273,10 @@ static const TypeInfo aspeed_sbc_info = {static void aspeed_ast2600_sbc_class_init (ObjectClass *klass,const void *data) {DeviceClass *dc =DEVICE_CLASS (klass); +AspeedSBCClass *sc =ASPEED_SBC_CLASS (klass); dc->desc ="AST2600 Secure Boot Controller" ; + sc->has_otp = true; }static const TypeInfo aspeed_ast2600_sbc_info = {
Signature · 1 line
2.43.0
Re: [PATCH v3 3/3] hw/arm: Integrate ASPEED OTP memory support into AST2600 SoCs
Quoted 6 lines · Kane Chen
From: Kane-Chen-AS <[email protected]>
The
has_otpmemattribute is enabled in the SBC subclasses for AST2600 to control the presence of OTP support per SoC type.Signed-off-by Kane-Chen-AS <[email protected]>
Thanks,
C.
Quoted 33 lines
--- hw/arm/aspeed_ast2600.c | 2 +- hw/misc/aspeed_sbc.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-)hw/arm/aspeed_ast2600.c +1
-1@@ -261,7 +261,7 @@ static void aspeed_soc_ast2600_init(Object *obj)object_initialize_child (obj,"i3c" , &s->i3c,TYPE_ASPEED_I3C ); -object_initialize_child (obj,"sbc" , &s->sbc,TYPE_ASPEED_SBC ); +object_initialize_child (obj,"sbc" , &s->sbc,TYPE_ASPEED_AST2600_SBC );object_initialize_child (obj,"iomem" , &s->iomem,TYPE_UNIMPLEMENTED_DEVICE );object_initialize_child (obj,"video" , &s->video,TYPE_UNIMPLEMENTED_DEVICE );hw/misc/aspeed_sbc.c +2
-0@@ -273,8 +273,10 @@ static const TypeInfo aspeed_sbc_info = {static void aspeed_ast2600_sbc_class_init (ObjectClass *klass,const void *data) {DeviceClass *dc =DEVICE_CLASS (klass); +AspeedSBCClass *sc =ASPEED_SBC_CLASS (klass); dc->desc ="AST2600 Secure Boot Controller" ; + sc->has_otp = true; }static const TypeInfo aspeed_ast2600_sbc_info = {
Hello Kane,
Quoted 22 lines · Kane Chen
From: Kane-Chen-AS <[email protected]>
This patch series introduces a QEMU model for the ASPEED OTP (One-Time Programmable) memory, along with its integration into the Secure Boot Controller (SBC) and supported SoC (AST2600).
The OTP model emulates a simple fuse array used for secure boot or device configuration, implemented with internal buffers; external file/device support not included in this version. It exposes an AddressSpace to support transaction-based access from controllers like the SBC.
This series includes:
- OTP memory device implementation
- SBC integration with command decoding (READ/PROG)
- Direct integration in AST2600 SoC without requiring user parametersAny feedback or suggestions are appreciated!
Kane
---
Quoted 6 lines
ChangeLog
---------
v3:
- Switched toobject_property_set_int()for setting "size"
- Simplifiedqdev_realize()error handling by passing errp directly
- Added "drive" property to OTP model for future extensibility
This is looking good. I'd prefer the BlockBackend to be added in a patch 4.
A drive can be defined with this command line option :
-global aspeed-otp.drive="path/to/foo"
But it's a not practical.
What's left is to add an 'optmem' machine option and link it to the 'drive' property of the "/machine/soc/sbc/otp" object. That would be for patch 5.
Please refer to the discussion we had before about pc_pflash_create(). Let's see if that works.
Thanks,
C.