Skip to contentSkip to conversation

platform/chrome: chromeos_laptop - replace open coded variant of DEFINE_RES_IRQ()

PATCH In review Andy Shevchenko 2 participants 2 messages Jun 30, 2025 – Jul 1, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/chrome: chromeos_laptop - replace open coded variant of DEFINE_RES_IRQ()

DEFINE_RES_*() are compound literals, and hence no need to do that explicitly. Besides that, we have no IRQ name provided, no need to use _NAMED() variant. Replace open coded variant of DEFINE_RES_IRQ().
No functional changes intended.

---
 drivers/platform/chrome/chromeos_laptop.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/platform/chrome/chromeos_laptop.c +3 -3
index 3579c42b515e..0b92047265de 100644
@@ -726,9 +726,9 @@ static int __init chromeos_laptop_setup_irq(struct i2c_peripheral *i2c_dev)
 		if (irq < 0)
 			return irq;
 
-		i2c_dev->irq_resource  = (struct resource)
-			DEFINE_RES_NAMED(irq, 1, NULL,
-					 IORESOURCE_IRQ | i2c_dev->irqflags);
+		i2c_dev->irq_resource = DEFINE_RES_IRQ(irq);
+		i2c_dev->irq_resource.flags |= i2c_dev->irqflags;
+
 		i2c_dev->board_info.resources = &i2c_dev->irq_resource;
 		i2c_dev->board_info.num_resources = 1;
 	}
Signature · 1 line
2.47.2
maintainer
#1 lore raw
Quoted 6 lines · Andy Shevchenko

DEFINE_RES_*() are compound literals, and hence no need to do that explicitly. Besides that, we have no IRQ name provided, no need to use _NAMED() variant. Replace open coded variant of DEFINE_RES_IRQ().
No functional changes intended.

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next

[1/1] platform/chrome: chromeos_laptop - replace open coded variant of DEFINE_RES_IRQ()

      commit: 5af89b6309417bdc2ff6835509d33a172c4a3218

Thanks!