Skip to contentSkip to conversation

bcachefs: Fix incorrect transaction restart handling

PATCH Applied Alan Huang 2 participants 2 messages Jun 30, 2025

lore
Share & tools
lore

Alan Huang

author
#0 lore raw

PATCH 1/1 bcachefs: Fix incorrect transaction restart handling

---
 fs/bcachefs/fsck.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/bcachefs/fsck.c +1 -1
index 4ceb28a6b9b1..453a5c3184ea 100644
@@ -2811,7 +2811,7 @@ static int check_path_loop(struct btree_trans *trans, struct bkey_s_c inode_k)
 				ret = remove_backpointer(trans, &inode);
 				bch_err_msg(c, ret, "removing dirent");
 				if (ret)
-					break;
+					goto out;
 
 				ret = reattach_inode(trans, &inode);
 				bch_err_msg(c, ret, "reattaching inode %llu", inode.bi_inum);
Signature · 1 line
2.48.1
#1 lore raw
Quoted 2 lines · Alan Huang

Applied, thanks

Quoted 20 lines
---
 fs/bcachefs/fsck.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/bcachefs/fsck.c +1 -1
index 4ceb28a6b9b1..453a5c3184ea 100644
@@ -2811,7 +2811,7 @@ static int check_path_loop(struct btree_trans *trans, struct bkey_s_c inode_k)
 				ret = remove_backpointer(trans, &inode);
 				bch_err_msg(c, ret, "removing dirent");
 				if (ret)
-					break;
+					goto out;
 
 				ret = reattach_inode(trans, &inode);
 				bch_err_msg(c, ret, "reattaching inode %llu", inode.bi_inum);
Signature · 1 line
2.48.1