Skip to contentSkip to conversation

wifi: mac80211: clear frame buffer to never leak stack

PATCH New Johannes Berg 1 participant 1 message Jul 1, 2025 mac80211

lore
Share & tools
lore

Johannes Berg

author maintainer
#0 lore raw

PATCH v2 1/1 wifi: mac80211: clear frame buffer to never leak stack

From: Johannes Berg <[email protected]>

In disconnect paths paths, local frame buffers are used to build deauthentication frames to send them over the air and as notifications to userspace. Some internal error paths (that, given no other bugs, cannot happen) don't always initialize the buffers before sending them to userspace, so in the presence of other bugs they can leak stack content. Initialize the buffers to avoid the possibility of this happening.

---
v2: don't copy-paste the entirely wrong thing for the size

---
 net/mac80211/mlme.c | 3 +++
 1 file changed, 3 insertions(+)
net/mac80211/mlme.c +3 -0
index 2d46d4af60d7..b707d61c1fe0 100644
@@ -3934,6 +3934,9 @@ static void ieee80211_set_disassoc(struct ieee80211_sub_if_data *sdata,
 
 	lockdep_assert_wiphy(local->hw.wiphy);
 
+	if (frame_buf)
+		memset(frame_buf, 0, IEEE80211_DEAUTH_FRAME_LEN);
+
 	if (WARN_ON(!ap_sta))
 		return;
 
Signature · 1 line
2.50.0