Skip to contentSkip to conversation

barebox.h: correct barebox_main default comment

PATCH Applied Bo Sun 2 participants 2 messages Jul 1, 2025 – Jul 2, 2025

lore
Share & tools
lore

Bo Sun

author
#0 lore raw

PATCH 1/1 barebox.h: correct barebox_main default comment

The comment incorrectly states that barebox_main defaults to run_shell() when a shell is enabled. In fact, it defaults to run_init() when both shell and command support are enabled. Update the comment to match the actual logic.

---
 include/barebox.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/barebox.h +1 -1
index 1b291129e9..6f3179d4bd 100644
@@ -14,7 +14,7 @@ void __noreturn hang (void);
 
 /*
  * Function pointer to the main barebox function. Defaults
- * to run_shell() when a shell is enabled.
+ * to run_init() when shell and command support are enabled.
  */
 extern int (*barebox_main)(void);
 
Applied
#1 lore raw
Quoted 6 lines · Bo Sun

The comment incorrectly states that barebox_main defaults to run_shell() when a shell is enabled. In fact, it defaults to run_init() when both shell and command support are enabled. Update the comment to match the actual logic.

Applied, thanks!

[1/1] barebox.h: correct barebox_main default comment
https://git.pengutronix.de/cgit/barebox/commit/?id=6a7348f3f1f6 (link may not be stable)

Best regards,

Signature · 1 line
Sascha Hauer <[email protected]>