selftests/sched_ext: Fix exit selftest hang on UP
Subsystems (2)
Andrea Righi
reviewerPATCH 1/1 selftests/sched_ext: Fix exit selftest hang on UP
On single-CPU systems, ops.select_cpu() is never called, causing the EXIT_SELECT_CPU test case to wait indefinitely.
Avoid the stall by skipping this specific sub-test when only one CPU is available.
--- tools/testing/selftests/sched_ext/exit.c | 8 ++++++++ 1 file changed, 8 insertions(+)
tools/testing/selftests/sched_ext/exit.c +8 -0
@@ -22,6 +22,14 @@ static enum scx_test_status run(void *ctx)struct bpf_link *link;char buf[16 ]; +/* +* On single-CPU systems, ops.select_cpu() is never +* invoked, so skip this test to avoid getting stuck +* indefinitely. +*/ +if (tc ==EXIT_SELECT_CPU &&libbpf_num_possible_cpus () ==1 ) +continue ; + skel =exit__open ();SCX_ENUM_INIT (skel); skel->rodata->exit_point = tc;
Signature · 1 line
2.50.0
Quoted 9 lines · On Tue, Jul 01, 2025 at 08:08:45AM +0200 Andrea Righi wrote:
On single-CPU systems,
ops.select_cpu()is never called, causing theEXIT_SELECT_CPUtest case to wait indefinitely.Avoid the stall by skipping this specific sub-test when only one CPU is available.
Reported-by Phil Auld <[email protected]>Fixes a5db7817af780 ("sched_ext: Add selftests")Signed-off-by Andrea Righi <[email protected]>
Thanks Andrea! You beat me to it. I didn't know that libbpf call existed :)
and
Cheers,
Phil
Quoted 26 lines
--- tools/testing/selftests/sched_ext/exit.c | 8 ++++++++ 1 file changed, 8 insertions(+)tools/testing/selftests/sched_ext/exit.c +8
-0@@ -22,6 +22,14 @@ static enum scx_test_status run(void *ctx)struct bpf_link *link;char buf[16 ]; +/* +* On single-CPU systems, ops.select_cpu() is never +* invoked, so skip this test to avoid getting stuck +* indefinitely. +*/ +if (tc ==EXIT_SELECT_CPU &&libbpf_num_possible_cpus () ==1 ) +continue ; + skel =exit__open ();SCX_ENUM_INIT (skel); skel->rodata->exit_point = tc;Signature · 1 line
2.50.0
Quoted 9 lines · Andrea Righi
On single-CPU systems,
ops.select_cpu()is never called, causing theEXIT_SELECT_CPUtest case to wait indefinitely.Avoid the stall by skipping this specific sub-test when only one CPU is available.
Reported-by Phil Auld <[email protected]>Fixes a5db7817af780 ("sched_ext: Add selftests")Signed-off-by Andrea Righi <[email protected]>
Applied to sched_ext/for-6.16-fixes.
Thanks.
Signature · 1 line
tejun