drm/amd/display: Disable common modes for LVDS
Subsystems (3)
Alex Deucher
maintainerPATCH 1/2 drm/amd/display: Disable common modes for LVDS
[Why]
Common modes are added to LVDS for compatibility in clone mode, but not all panels support them. Non-native modes were disabled in the past but this caused problems because compositors didn't use scaling for non native modes. Now non-native modes on LVDS will enable the scaler by default.
[How]
Check the connector type. If the connector is LVDS avoid adding common modes.
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +2 -1
@@ -8374,7 +8374,8 @@ static int amdgpu_dm_connector_get_modes(struct drm_connector *connector)drm_add_modes_noedid (connector,1920 ,1080 ); }else {amdgpu_dm_connector_ddc_get_modes (connector, drm_edid); -if (encoder && connector->connector_type != DRM_MODE_CONNECTOR_eDP) +if (encoder && (connector->connector_type != DRM_MODE_CONNECTOR_eDP) && + (connector->connector_type !=DRM_MODE_CONNECTOR_LVDS ))amdgpu_dm_connector_add_common_modes (encoder, connector);amdgpu_dm_connector_add_freesync_modes (connector, drm_edid); }
Signature · 1 line
2.50.0
Alex Deucher
maintainerPATCH 2/2 drm/amd/display: Use scaling for non-native resolutions on LVDS
[Why]
Common resolutions are added to supported modes to enable compatibility scenarios that compositors may use to do things like clone displays. There is no guarantee however that the panel will natively support these modes.
[How]
If the compositor hasn't enabled scaling but a non-native resolution has been picked for an LVDS panel turn the scaler on anyway. This will ensure compatibility.
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +2 -1
@@ -7901,7 +7901,8 @@ static int dm_encoder_helper_atomic_check(struct drm_encoder *encoder,int clock, bpp =0 ;bool is_y420 = false; -if (connector->connector_type == DRM_MODE_CONNECTOR_eDP) { +if ((connector->connector_type == DRM_MODE_CONNECTOR_eDP) || + (connector->connector_type ==DRM_MODE_CONNECTOR_LVDS )) {struct amdgpu_encoder *amdgpu_encoder =to_amdgpu_encoder (encoder);struct drm_display_mode *native_mode = &amdgpu_encoder->native_mode;enum drm_mode_status result;
Signature · 1 line
2.50.0
Re: [PATCH 2/2] drm/amd/display: Use scaling for non-native resolutions on LVDS
Quoted 11 lines · Alex Deucher
[Why]
Common resolutions are added to supported modes to enable compatibility scenarios that compositors may use to do things like clone displays. There is no guarantee however that the panel will natively support these modes.[How]
If the compositor hasn't enabled scaling but a non-native resolution has been picked for an LVDS panel turn the scaler on anyway. This will ensure compatibility.Signed-off-by Alex Deucher <[email protected]>
Series is
Harry
Quoted 18 lines
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +2
-1@@ -7901,7 +7901,8 @@ static int dm_encoder_helper_atomic_check(struct drm_encoder *encoder,int clock, bpp =0 ;bool is_y420 = false; -if (connector->connector_type == DRM_MODE_CONNECTOR_eDP) { +if ((connector->connector_type == DRM_MODE_CONNECTOR_eDP) || + (connector->connector_type ==DRM_MODE_CONNECTOR_LVDS )) {struct amdgpu_encoder *amdgpu_encoder =to_amdgpu_encoder (encoder);struct drm_display_mode *native_mode = &amdgpu_encoder->native_mode;enum drm_mode_status result;