Skip to contentSkip to conversation

ata: Correct two dependency issues

PATCH In review Tom Rini 2 participants 3 messages Jul 2, 2025 – Jul 10, 2025 libata

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/1 ata: Correct two dependency issues

First, the SATA_MV driver can only build on kirkwood or mvebu platforms due to header requirements, so add that as a dependency here. Second, SYS_SATA_MAX_DEVICE is also used by the API code so allow it to be configured in that case.

---
 drivers/ata/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/ata/Kconfig +2 -1
index 29ceab849c02..da9c72a99d03 100644
@@ -131,6 +131,7 @@ config FSL_SATA_V2
 
 config SATA_MV
 	bool "Enable Marvell SATA controller driver support"
+	depends on ARCH_KIRKWOOD || ARCH_MVEBU
 	select AHCI
 	select LIBATA
 	help
@@ -148,7 +149,7 @@ config SATA_SIL
 
 config SYS_SATA_MAX_DEVICE
 	int "Maximum number of SATA devices"
-	depends on !AHCI || FSL_SATA || SATA_MV
+	depends on !AHCI || FSL_SATA || SATA_MV || API
 	help
 	  Sets the maximum number of SATA devices which can be supported
 	  by U-Boot.
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 33 lines · Tom Rini

First, the SATA_MV driver can only build on kirkwood or mvebu platforms due to header requirements, so add that as a dependency here. Second, SYS_SATA_MAX_DEVICE is also used by the API code so allow it to be configured in that case.

---
 drivers/ata/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/ata/Kconfig +2 -2
index 29ceab849c02..da9c72a99d03 100644
@@ -131,6 +131,7 @@ config FSL_SATA_V2
 
 config SATA_MV
        bool "Enable Marvell SATA controller driver support"
+       depends on ARCH_KIRKWOOD || ARCH_MVEBU
        select AHCI
        select LIBATA
        help
@@ -148,7 +149,7 @@ config SATA_SIL
 
 config SYS_SATA_MAX_DEVICE
        int "Maximum number of SATA devices"
-       depends on !AHCI || FSL_SATA || SATA_MV
+       depends on !AHCI || FSL_SATA || SATA_MV || API
        help
          Sets the maximum number of SATA devices which can be supported
          by U-Boot.
--
Quoted 1 line

2.43.0

Quoted 1 line
author
#2 lore raw
In reply to Tom Rini
Quoted 6 lines · Tom Rini

First, the SATA_MV driver can only build on kirkwood or mvebu platforms due to header requirements, so add that as a dependency here. Second, SYS_SATA_MAX_DEVICE is also used by the API code so allow it to be configured in that case.

Applied to u-boot/master, thanks!

[1/1] ata: Correct two dependency issues

      commit: a713fa1b5d4090fde3d84d25b7800de8f9feba62
Signature · 1 line
Tom