Skip to contentSkip to conversation

lib/test_vmalloc.c: introduce xfail for failing tests

PATCH Applied Raghavendra K T 3 participants 7 messages Jul 2, 2025 – Jul 4, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib/test_vmalloc.c: introduce xfail for failing tests

The test align_shift_alloc_test is expected to fail. Reporting the test as fail confuses to be a genuine failure. Introduce widely used xfail sematics to address the issue.

Note: a warn_alloc dump similar to below is still expected:

 Call Trace:
  <TASK>
  dump_stack_lvl+0x64/0x80
  warn_alloc+0x137/0x1b0
  ? __get_vm_area_node+0x134/0x140

Snippet of dmesg after change:

Summary: random_size_align_alloc_test passed: 1 failed: 0 xfailed: 0 ..
Summary: align_shift_alloc_test passed: 0 failed: 0 xfailed: 1 ..
Summary: pcpu_alloc_test passed: 1 failed: 0 xfailed: 0 ..

---
 lib/test_vmalloc.c | 36 +++++++++++++++++++++---------------
 1 file changed, 21 insertions(+), 15 deletions(-)
lib/test_vmalloc.c +21 -15
index 1b0b59549aaf..649f352e2046 100644
@@ -396,25 +396,27 @@ vm_map_ram_test(void)
 struct test_case_desc {
 	const char *test_name;
 	int (*test_func)(void);
+	bool xfail;
 };
 
 static struct test_case_desc test_case_array[] = {
-	{ "fix_size_alloc_test", fix_size_alloc_test },
-	{ "full_fit_alloc_test", full_fit_alloc_test },
-	{ "long_busy_list_alloc_test", long_busy_list_alloc_test },
-	{ "random_size_alloc_test", random_size_alloc_test },
-	{ "fix_align_alloc_test", fix_align_alloc_test },
-	{ "random_size_align_alloc_test", random_size_align_alloc_test },
-	{ "align_shift_alloc_test", align_shift_alloc_test },
-	{ "pcpu_alloc_test", pcpu_alloc_test },
-	{ "kvfree_rcu_1_arg_vmalloc_test", kvfree_rcu_1_arg_vmalloc_test },
-	{ "kvfree_rcu_2_arg_vmalloc_test", kvfree_rcu_2_arg_vmalloc_test },
-	{ "vm_map_ram_test", vm_map_ram_test },
+	{ "fix_size_alloc_test", fix_size_alloc_test, },
+	{ "full_fit_alloc_test", full_fit_alloc_test, },
+	{ "long_busy_list_alloc_test", long_busy_list_alloc_test, },
+	{ "random_size_alloc_test", random_size_alloc_test, },
+	{ "fix_align_alloc_test", fix_align_alloc_test, },
+	{ "random_size_align_alloc_test", random_size_align_alloc_test, },
+	{ "align_shift_alloc_test", align_shift_alloc_test, true },
+	{ "pcpu_alloc_test", pcpu_alloc_test, },
+	{ "kvfree_rcu_1_arg_vmalloc_test", kvfree_rcu_1_arg_vmalloc_test, },
+	{ "kvfree_rcu_2_arg_vmalloc_test", kvfree_rcu_2_arg_vmalloc_test, },
+	{ "vm_map_ram_test", vm_map_ram_test, },
 	/* Add a new test case here. */
 };
 
 struct test_case_data {
 	int test_failed;
+	int test_xfailed;
 	int test_passed;
 	u64 time;
 };
@@ -444,7 +446,7 @@ static int test_func(void *private)
 {
 	struct test_driver *t = private;
 	int random_array[ARRAY_SIZE(test_case_array)];
-	int index, i, j;
+	int index, i, j, ret;
 	ktime_t kt;
 	u64 delta;
 
@@ -468,11 +470,14 @@ static int test_func(void *private)
 		 */
 		if (!((run_test_mask & (1 << index)) >> index))
 			continue;
-
 		kt = ktime_get();
 		for (j = 0; j < test_repeat_count; j++) {
-			if (!test_case_array[index].test_func())
+			ret = test_case_array[index].test_func();
+
+			if (!ret && !test_case_array[index].xfail)
 				t->data[index].test_passed++;
+			else if (ret && test_case_array[index].xfail)
+				t->data[index].test_xfailed++;
 			else
 				t->data[index].test_failed++;
 		}
@@ -576,10 +581,11 @@ static void do_concurrent_test(void)
 				continue;
 
 			pr_info(
-				"Summary: %s passed: %d failed: %d repeat: %d loops: %d avg: %llu usec\n",
+				"Summary: %s passed: %d failed: %d xfailed: %d repeat: %d loops: %d avg: %llu usec\n",
 				test_case_array[j].test_name,
 				t->data[j].test_passed,
 				t->data[j].test_failed,
+				t->data[j].test_xfailed,
 				test_repeat_count, test_loop_count,
 				t->data[j].time);
 		}
Signature · 1 line
2.43.0
#1 lore raw
Quoted 12 lines · Raghavendra K T

The test align_shift_alloc_test is expected to fail. Reporting the test as fail confuses to be a genuine failure. Introduce widely used xfail sematics to address the issue.

Note: a warn_alloc dump similar to below is still expected:

  Call Trace:
   <TASK>
   dump_stack_lvl+0x64/0x80
   warn_alloc+0x137/0x1b0
   ? __get_vm_area_node+0x134/0x140
Quoted 8 lines

Snippet of dmesg after change:

Summary: random_size_align_alloc_test passed: 1 failed: 0 xfailed: 0 ..
Summary: align_shift_alloc_test passed: 0 failed: 0 xfailed: 1 ..
Summary: pcpu_alloc_test passed: 1 failed: 0 xfailed: 0 ..

---

Thanks for doing this, been thinking about this for so long but I'm lazy : )

Quoted 30 lines
  lib/test_vmalloc.c | 36 +++++++++++++++++++++---------------
  1 file changed, 21 insertions(+), 15 deletions(-)
lib/test_vmalloc.c +5 -11
index 1b0b59549aaf..649f352e2046 100644
@@ -396,25 +396,27 @@ vm_map_ram_test(void)
  struct test_case_desc {
  	const char *test_name;
  	int (*test_func)(void);
+	bool xfail;
  };
 
  static struct test_case_desc test_case_array[] = {
-	{ "fix_size_alloc_test", fix_size_alloc_test },
-	{ "full_fit_alloc_test", full_fit_alloc_test },
-	{ "long_busy_list_alloc_test", long_busy_list_alloc_test },
-	{ "random_size_alloc_test", random_size_alloc_test },
-	{ "fix_align_alloc_test", fix_align_alloc_test },
-	{ "random_size_align_alloc_test", random_size_align_alloc_test },
-	{ "align_shift_alloc_test", align_shift_alloc_test },
-	{ "pcpu_alloc_test", pcpu_alloc_test },
-	{ "kvfree_rcu_1_arg_vmalloc_test", kvfree_rcu_1_arg_vmalloc_test },
-	{ "kvfree_rcu_2_arg_vmalloc_test", kvfree_rcu_2_arg_vmalloc_test },
-	{ "vm_map_ram_test", vm_map_ram_test },
+	{ "fix_size_alloc_test", fix_size_alloc_test, },
+	{ "full_fit_alloc_test", full_fit_alloc_test, },
+	{ "long_busy_list_alloc_test", long_busy_list_alloc_test, },
+	{ "random_size_alloc_test", random_size_alloc_test, },

lib/test_vmalloc.c vm_map_ram_test(void) · line 416

Quoted 10 lines
lib/test_vmalloc.c +7 -0
+	{ "fix_align_alloc_test", fix_align_alloc_test, },
+	{ "random_size_align_alloc_test", random_size_align_alloc_test, },
+	{ "align_shift_alloc_test", align_shift_alloc_test, true },
+	{ "pcpu_alloc_test", pcpu_alloc_test, },
+	{ "kvfree_rcu_1_arg_vmalloc_test", kvfree_rcu_1_arg_vmalloc_test, },
+	{ "kvfree_rcu_2_arg_vmalloc_test", kvfree_rcu_2_arg_vmalloc_test, },
+	{ "vm_map_ram_test", vm_map_ram_test, },
  	/* Add a new test case here. */
  };
 

Why this change?

Quoted 45 lines
lib/test_vmalloc.c +9 -4
  struct test_case_data {
  	int test_failed;
+	int test_xfailed;
  	int test_passed;
  	u64 time;
  };
@@ -444,7 +446,7 @@ static int test_func(void *private)
  {
  	struct test_driver *t = private;
  	int random_array[ARRAY_SIZE(test_case_array)];
-	int index, i, j;
+	int index, i, j, ret;
  	ktime_t kt;
  	u64 delta;
 
@@ -468,11 +470,14 @@ static int test_func(void *private)
  		 */
  		if (!((run_test_mask & (1 << index)) >> index))
  			continue;
-
  		kt = ktime_get();
  		for (j = 0; j < test_repeat_count; j++) {
-			if (!test_case_array[index].test_func())
+			ret = test_case_array[index].test_func();
+
+			if (!ret && !test_case_array[index].xfail)
  				t->data[index].test_passed++;
+			else if (ret && test_case_array[index].xfail)
+				t->data[index].test_xfailed++;
  			else
  				t->data[index].test_failed++;
  		}
@@ -576,10 +581,11 @@ static void do_concurrent_test(void)
  				continue;
 
  			pr_info(
-				"Summary: %s passed: %d failed: %d repeat: %d loops: %d avg: %llu usec\n",
+				"Summary: %s passed: %d failed: %d xfailed: %d repeat: %d loops: %d avg: %llu usec\n",
  				test_case_array[j].test_name,
  				t->data[j].test_passed,
  				t->data[j].test_failed,
+				t->data[j].test_xfailed,
  				test_repeat_count, test_loop_count,
  				t->data[j].time);
  		}
#2 lore raw
Quoted 20 lines · Dev Jain
Quoted 18 lines · Raghavendra K T

The test align_shift_alloc_test is expected to fail. Reporting the test as fail confuses to be a genuine failure. Introduce widely used xfail sematics to address the issue.

Note: a warn_alloc dump similar to below is still expected:

  Call Trace:
   <TASK>
   dump_stack_lvl+0x64/0x80
   warn_alloc+0x137/0x1b0
   ? __get_vm_area_node+0x134/0x140

Snippet of dmesg after change:

Summary: random_size_align_alloc_test passed: 1 failed: 0 xfailed: 0 ..
Summary: align_shift_alloc_test passed: 0 failed: 0 xfailed: 1 ..
Summary: pcpu_alloc_test passed: 1 failed: 0 xfailed: 0 ..

Quoted 5 lines
Quoted 2 lines

---

Thanks for doing this, been thinking about this for so long but I'm lazy : )

:)

Quoted 33 lines
Quoted 33 lines

  lib/test_vmalloc.c | 36 +++++++++++++++++++++---------------

  1 file changed, 21 insertions(+), 15 deletions(-)
lib/test_vmalloc.c +8 -11
index 1b0b59549aaf..649f352e2046 100644
@@ -396,25 +396,27 @@ vm_map_ram_test(void)
   struct test_case_desc {
       const char *test_name;
       int (*test_func)(void);
+    bool xfail;
   };
   static struct test_case_desc test_case_array[] = {
-    { "fix_size_alloc_test", fix_size_alloc_test },
-    { "full_fit_alloc_test", full_fit_alloc_test },
-    { "long_busy_list_alloc_test", long_busy_list_alloc_test },
-    { "random_size_alloc_test", random_size_alloc_test },
-    { "fix_align_alloc_test", fix_align_alloc_test },
-    { "random_size_align_alloc_test", random_size_align_alloc_test },
-    { "align_shift_alloc_test", align_shift_alloc_test },
-    { "pcpu_alloc_test", pcpu_alloc_test },
-    { "kvfree_rcu_1_arg_vmalloc_test", kvfree_rcu_1_arg_vmalloc_test },
-    { "kvfree_rcu_2_arg_vmalloc_test", kvfree_rcu_2_arg_vmalloc_test },
-    { "vm_map_ram_test", vm_map_ram_test },
+    { "fix_size_alloc_test", fix_size_alloc_test, },
+    { "full_fit_alloc_test", full_fit_alloc_test, },
+    { "long_busy_list_alloc_test", long_busy_list_alloc_test, },
+    { "random_size_alloc_test", random_size_alloc_test, },
+    { "fix_align_alloc_test", fix_align_alloc_test, },
+    { "random_size_align_alloc_test", random_size_align_alloc_test, },
+    { "align_shift_alloc_test", align_shift_alloc_test, true },
Quoted 8 lines

lib/test_vmalloc.c vm_map_ram_test(void) · line 415

Quoted 6 lines
lib/test_vmalloc.c +4 -0
+    { "pcpu_alloc_test", pcpu_alloc_test, },
+    { "kvfree_rcu_1_arg_vmalloc_test", kvfree_rcu_1_arg_vmalloc_test, },
+    { "kvfree_rcu_2_arg_vmalloc_test", kvfree_rcu_2_arg_vmalloc_test, },
+    { "vm_map_ram_test", vm_map_ram_test, },
       /* Add a new test case here. */
   };

Why this change?

Perhaps not entirely necessary except for align_shift_alloc_test line, still updated the field since one more bool field added. But let me know if you are okay with current state OR need a respin for that?

[...]

#3 lore raw
Quoted 77 lines · Raghavendra K T
Quoted 20 lines · Dev Jain
Quoted 18 lines · Raghavendra K T

The test align_shift_alloc_test is expected to fail. Reporting the test as fail confuses to be a genuine failure. Introduce widely used xfail sematics to address the issue.

Note: a warn_alloc dump similar to below is still expected:

  Call Trace:
   <TASK>
   dump_stack_lvl+0x64/0x80
   warn_alloc+0x137/0x1b0
   ? __get_vm_area_node+0x134/0x140

Snippet of dmesg after change:

Summary: random_size_align_alloc_test passed: 1 failed: 0 xfailed: 0 ..
Summary: align_shift_alloc_test passed: 0 failed: 0 xfailed: 1 ..
Summary: pcpu_alloc_test passed: 1 failed: 0 xfailed: 0 ..

Quoted 5 lines
Quoted 2 lines

---

Thanks for doing this, been thinking about this for so long but I'm lazy : )

:)

Quoted 37 lines
Quoted 37 lines

  lib/test_vmalloc.c | 36 +++++++++++++++++++++---------------

  1 file changed, 21 insertions(+), 15 deletions(-)
lib/test_vmalloc.c +10 -11
index 1b0b59549aaf..649f352e2046 100644
@@ -396,25 +396,27 @@ vm_map_ram_test(void)
   struct test_case_desc {
       const char *test_name;
       int (*test_func)(void);
+    bool xfail;
   };
   static struct test_case_desc test_case_array[] = {
-    { "fix_size_alloc_test", fix_size_alloc_test },
-    { "full_fit_alloc_test", full_fit_alloc_test },
-    { "long_busy_list_alloc_test", long_busy_list_alloc_test },
-    { "random_size_alloc_test", random_size_alloc_test },
-    { "fix_align_alloc_test", fix_align_alloc_test },
-    { "random_size_align_alloc_test", random_size_align_alloc_test },
-    { "align_shift_alloc_test", align_shift_alloc_test },
-    { "pcpu_alloc_test", pcpu_alloc_test },
-    { "kvfree_rcu_1_arg_vmalloc_test", 
 kvfree_rcu_1_arg_vmalloc_test },
-    { "kvfree_rcu_2_arg_vmalloc_test", 
 kvfree_rcu_2_arg_vmalloc_test },
-    { "vm_map_ram_test", vm_map_ram_test },
+    { "fix_size_alloc_test", fix_size_alloc_test, },
+    { "full_fit_alloc_test", full_fit_alloc_test, },
+    { "long_busy_list_alloc_test", long_busy_list_alloc_test, },
+    { "random_size_alloc_test", random_size_alloc_test, },
+    { "fix_align_alloc_test", fix_align_alloc_test, },
+    { "random_size_align_alloc_test", random_size_align_alloc_test, },
+    { "align_shift_alloc_test", align_shift_alloc_test, true },
+    { "pcpu_alloc_test", pcpu_alloc_test, },
+    { "kvfree_rcu_1_arg_vmalloc_test", 
Quoted 8 lines

lib/test_vmalloc.c vm_map_ram_test(void) · line 415

Quoted 6 lines
lib/test_vmalloc.c +2 -0
 kvfree_rcu_1_arg_vmalloc_test, },
+    { "kvfree_rcu_2_arg_vmalloc_test", 
 kvfree_rcu_2_arg_vmalloc_test, },
+    { "vm_map_ram_test", vm_map_ram_test, },
       /* Add a new test case here. */
   };

Why this change?

Quoted 3 lines

Perhaps not entirely necessary except for align_shift_alloc_test line, still updated the field since one more bool field added. But let me know if you are okay with current state OR need a respin for that?

Oh now I saw the "true", I thought you were adding commas for no reason.

I think that's fine then, but will let Uladzislau decide.

Quoted 2 lines

[...]

#4 lore raw
Quoted 79 lines · Dev Jain
Quoted 77 lines · Raghavendra K T
Quoted 20 lines · Dev Jain
Quoted 18 lines · Raghavendra K T

The test align_shift_alloc_test is expected to fail. Reporting the test as fail confuses to be a genuine failure. Introduce widely used xfail sematics to address the issue.

Note: a warn_alloc dump similar to below is still expected:

  Call Trace:
   <TASK>
   dump_stack_lvl+0x64/0x80
   warn_alloc+0x137/0x1b0
   ? __get_vm_area_node+0x134/0x140

Snippet of dmesg after change:

Summary: random_size_align_alloc_test passed: 1 failed: 0 xfailed: 0 ..
Summary: align_shift_alloc_test passed: 0 failed: 0 xfailed: 1 ..
Summary: pcpu_alloc_test passed: 1 failed: 0 xfailed: 0 ..

Quoted 5 lines
Quoted 2 lines

---

Thanks for doing this, been thinking about this for so long but I'm lazy : )

:)

Quoted 45 lines
Quoted 33 lines

  lib/test_vmalloc.c | 36 +++++++++++++++++++++---------------

  1 file changed, 21 insertions(+), 15 deletions(-)
lib/test_vmalloc.c +6 -11
index 1b0b59549aaf..649f352e2046 100644
@@ -396,25 +396,27 @@ vm_map_ram_test(void)
   struct test_case_desc {
       const char *test_name;
       int (*test_func)(void);
+    bool xfail;
   };
   static struct test_case_desc test_case_array[] = {
-    { "fix_size_alloc_test", fix_size_alloc_test },
-    { "full_fit_alloc_test", full_fit_alloc_test },
-    { "long_busy_list_alloc_test", long_busy_list_alloc_test },
-    { "random_size_alloc_test", random_size_alloc_test },
-    { "fix_align_alloc_test", fix_align_alloc_test },
-    { "random_size_align_alloc_test", random_size_align_alloc_test },
-    { "align_shift_alloc_test", align_shift_alloc_test },
-    { "pcpu_alloc_test", pcpu_alloc_test },
-    { "kvfree_rcu_1_arg_vmalloc_test", 
 kvfree_rcu_1_arg_vmalloc_test },
-    { "kvfree_rcu_2_arg_vmalloc_test", 
 kvfree_rcu_2_arg_vmalloc_test },
-    { "vm_map_ram_test", vm_map_ram_test },
+    { "fix_size_alloc_test", fix_size_alloc_test, },
+    { "full_fit_alloc_test", full_fit_alloc_test, },
+    { "long_busy_list_alloc_test", long_busy_list_alloc_test, },
+    { "random_size_alloc_test", random_size_alloc_test, },
+    { "fix_align_alloc_test", fix_align_alloc_test, },

lib/test_vmalloc.c vm_map_ram_test(void) · line 418

Quoted 10 lines
lib/test_vmalloc.c +6 -0
+    { "random_size_align_alloc_test", random_size_align_alloc_test, },
+    { "align_shift_alloc_test", align_shift_alloc_test, true },
+    { "pcpu_alloc_test", pcpu_alloc_test, },
+    { "kvfree_rcu_1_arg_vmalloc_test", 
 kvfree_rcu_1_arg_vmalloc_test, },
+    { "kvfree_rcu_2_arg_vmalloc_test", 
 kvfree_rcu_2_arg_vmalloc_test, },
+    { "vm_map_ram_test", vm_map_ram_test, },
       /* Add a new test case here. */
   };

Why this change?

Quoted 9 lines
Quoted 3 lines

Perhaps not entirely necessary except for align_shift_alloc_test line, still updated the field since one more bool field added. But let me know if you are okay with current state OR need a respin for that?

Oh now I saw the "true", I thought you were adding commas for no reason.

I think that's fine then, but will let Uladzislau decide.

Uladzislau,

Do you think this patch would be useful? and above change is okay?

Thanks and regards
- Raghu

maintainer
#5 lore raw

Hello, Raghavendra!

Quoted 87 lines · Dev Jain
Quoted 85 lines · Raghavendra K T
Quoted 77 lines · Dev Jain
Quoted 20 lines · Raghavendra K T
Quoted 18 lines

The test align_shift_alloc_test is expected to fail. Reporting the test as fail confuses to be a genuine failure. Introduce widely used xfail sematics to address the issue.

Note: a warn_alloc dump similar to below is still expected:

  Call Trace:
   <TASK>
   dump_stack_lvl+0x64/0x80
   warn_alloc+0x137/0x1b0
   ? __get_vm_area_node+0x134/0x140

Snippet of dmesg after change:

Summary: random_size_align_alloc_test passed: 1 failed: 0 xfailed: 0 ..
Summary: align_shift_alloc_test passed: 0 failed: 0 xfailed: 1 ..
Summary: pcpu_alloc_test passed: 1 failed: 0 xfailed: 0 ..

Quoted 5 lines
Quoted 2 lines

---

Thanks for doing this, been thinking about this for so long but I'm lazy : )

:)

Quoted 37 lines
Quoted 37 lines

  lib/test_vmalloc.c | 36 +++++++++++++++++++++---------------

  1 file changed, 21 insertions(+), 15 deletions(-)
lib/test_vmalloc.c +10 -11
index 1b0b59549aaf..649f352e2046 100644
@@ -396,25 +396,27 @@ vm_map_ram_test(void)
   struct test_case_desc {
       const char *test_name;
       int (*test_func)(void);
+    bool xfail;
   };
   static struct test_case_desc test_case_array[] = {
-    { "fix_size_alloc_test", fix_size_alloc_test },
-    { "full_fit_alloc_test", full_fit_alloc_test },
-    { "long_busy_list_alloc_test", long_busy_list_alloc_test },
-    { "random_size_alloc_test", random_size_alloc_test },
-    { "fix_align_alloc_test", fix_align_alloc_test },
-    { "random_size_align_alloc_test", random_size_align_alloc_test },
-    { "align_shift_alloc_test", align_shift_alloc_test },
-    { "pcpu_alloc_test", pcpu_alloc_test },
-    { "kvfree_rcu_1_arg_vmalloc_test",
 kvfree_rcu_1_arg_vmalloc_test },
-    { "kvfree_rcu_2_arg_vmalloc_test",
 kvfree_rcu_2_arg_vmalloc_test },
-    { "vm_map_ram_test", vm_map_ram_test },
+    { "fix_size_alloc_test", fix_size_alloc_test, },
+    { "full_fit_alloc_test", full_fit_alloc_test, },
+    { "long_busy_list_alloc_test", long_busy_list_alloc_test, },
+    { "random_size_alloc_test", random_size_alloc_test, },
+    { "fix_align_alloc_test", fix_align_alloc_test, },
+    { "random_size_align_alloc_test", random_size_align_alloc_test, },
+    { "align_shift_alloc_test", align_shift_alloc_test, true },
+    { "pcpu_alloc_test", pcpu_alloc_test, },
+    { "kvfree_rcu_1_arg_vmalloc_test",
Quoted 8 lines

lib/test_vmalloc.c vm_map_ram_test(void) · line 415

Quoted 6 lines
lib/test_vmalloc.c +2 -0
 kvfree_rcu_1_arg_vmalloc_test, },
+    { "kvfree_rcu_2_arg_vmalloc_test",
 kvfree_rcu_2_arg_vmalloc_test, },
+    { "vm_map_ram_test", vm_map_ram_test, },
       /* Add a new test case here. */
   };

Why this change?

Quoted 3 lines

Perhaps not entirely necessary except for align_shift_alloc_test line, still updated the field since one more bool field added. But let me know if you are okay with current state OR need a respin for that?

Oh now I saw the "true", I thought you were adding commas for no reason.

Quoted 8 lines
Quoted 3 lines

I think that's fine then, but will let Uladzislau decide.

Uladzislau,

Do you think this patch would be useful? and above change is okay?

Sorry, i missed this. Yes, i think it makes sense since it confuses people.

--
Uladzislau Rezki

maintainer Reviewed-by on v1 1/1
#6 lore raw
In reply to Raghavendra K T
Quoted 108 lines · Raghavendra K T

The test align_shift_alloc_test is expected to fail. Reporting the test as fail confuses to be a genuine failure. Introduce widely used xfail sematics to address the issue.

Note: a warn_alloc dump similar to below is still expected:

 Call Trace:
  <TASK>
  dump_stack_lvl+0x64/0x80
  warn_alloc+0x137/0x1b0
  ? __get_vm_area_node+0x134/0x140

Snippet of dmesg after change:

Summary: random_size_align_alloc_test passed: 1 failed: 0 xfailed: 0 ..
Summary: align_shift_alloc_test passed: 0 failed: 0 xfailed: 1 ..
Summary: pcpu_alloc_test passed: 1 failed: 0 xfailed: 0 ..

---
 lib/test_vmalloc.c | 36 +++++++++++++++++++++---------------
 1 file changed, 21 insertions(+), 15 deletions(-)
lib/test_vmalloc.c +21 -15
index 1b0b59549aaf..649f352e2046 100644
@@ -396,25 +396,27 @@ vm_map_ram_test(void)
 struct test_case_desc {
 	const char *test_name;
 	int (*test_func)(void);
+	bool xfail;
 };
 
 static struct test_case_desc test_case_array[] = {
-	{ "fix_size_alloc_test", fix_size_alloc_test },
-	{ "full_fit_alloc_test", full_fit_alloc_test },
-	{ "long_busy_list_alloc_test", long_busy_list_alloc_test },
-	{ "random_size_alloc_test", random_size_alloc_test },
-	{ "fix_align_alloc_test", fix_align_alloc_test },
-	{ "random_size_align_alloc_test", random_size_align_alloc_test },
-	{ "align_shift_alloc_test", align_shift_alloc_test },
-	{ "pcpu_alloc_test", pcpu_alloc_test },
-	{ "kvfree_rcu_1_arg_vmalloc_test", kvfree_rcu_1_arg_vmalloc_test },
-	{ "kvfree_rcu_2_arg_vmalloc_test", kvfree_rcu_2_arg_vmalloc_test },
-	{ "vm_map_ram_test", vm_map_ram_test },
+	{ "fix_size_alloc_test", fix_size_alloc_test, },
+	{ "full_fit_alloc_test", full_fit_alloc_test, },
+	{ "long_busy_list_alloc_test", long_busy_list_alloc_test, },
+	{ "random_size_alloc_test", random_size_alloc_test, },
+	{ "fix_align_alloc_test", fix_align_alloc_test, },
+	{ "random_size_align_alloc_test", random_size_align_alloc_test, },
+	{ "align_shift_alloc_test", align_shift_alloc_test, true },
+	{ "pcpu_alloc_test", pcpu_alloc_test, },
+	{ "kvfree_rcu_1_arg_vmalloc_test", kvfree_rcu_1_arg_vmalloc_test, },
+	{ "kvfree_rcu_2_arg_vmalloc_test", kvfree_rcu_2_arg_vmalloc_test, },
+	{ "vm_map_ram_test", vm_map_ram_test, },
 	/* Add a new test case here. */
 };
 
 struct test_case_data {
 	int test_failed;
+	int test_xfailed;
 	int test_passed;
 	u64 time;
 };
@@ -444,7 +446,7 @@ static int test_func(void *private)
 {
 	struct test_driver *t = private;
 	int random_array[ARRAY_SIZE(test_case_array)];
-	int index, i, j;
+	int index, i, j, ret;
 	ktime_t kt;
 	u64 delta;
 
@@ -468,11 +470,14 @@ static int test_func(void *private)
 		 */
 		if (!((run_test_mask & (1 << index)) >> index))
 			continue;
-
 		kt = ktime_get();
 		for (j = 0; j < test_repeat_count; j++) {
-			if (!test_case_array[index].test_func())
+			ret = test_case_array[index].test_func();
+
+			if (!ret && !test_case_array[index].xfail)
 				t->data[index].test_passed++;
+			else if (ret && test_case_array[index].xfail)
+				t->data[index].test_xfailed++;
 			else
 				t->data[index].test_failed++;
 		}
@@ -576,10 +581,11 @@ static void do_concurrent_test(void)
 				continue;
 
 			pr_info(
-				"Summary: %s passed: %d failed: %d repeat: %d loops: %d avg: %llu usec\n",
+				"Summary: %s passed: %d failed: %d xfailed: %d repeat: %d loops: %d avg: %llu usec\n",
 				test_case_array[j].test_name,
 				t->data[j].test_passed,
 				t->data[j].test_failed,
+				t->data[j].test_xfailed,
 				test_repeat_count, test_loop_count,
 				t->data[j].time);
 		}
Signature · 1 line
2.43.0

--
Uladzislau Rezki