bnxt_en: eliminate the compile warning in bnxt_request_irq due to CONFIG_RFS_ACCEL
PATCH v2 1/1 bnxt_en: eliminate the compile warning in bnxt_request_irq due to CONFIG_RFS_ACCEL
From: Jason Xing <[email protected]>
I received a kernel-test-bot report[1] that shows the [-Wunused-but-set-variable] warning. Since the previous commit I made, as the 'Fixes' tag shows, gives users an option to turn on and off the CONFIG_RFS_ACCEL, the issue then can be discovered and reproduced with GCC specifically.
Like Simon and Jakub suggested, use fewer #ifdefs which leads to fewer bugs.
[1]
All warnings (new ones prefixed by >>):
drivers/net/ethernet/broadcom/bnxt/bnxt.c: In function 'bnxt_request_irq':
Quoted 1 line
Quoted 1 line
drivers/net/ethernet/broadcom/bnxt/bnxt.c:10703:9: warning: variable 'j' set but not used [-Wunused-but-set-variable]
10703 | int i, j, rc = 0;
| ^
---
v2
1. use a better approach with fewer #ifdefs (Simon, Jakub)
--- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
drivers/net/ethernet/broadcom/bnxt/bnxt.c +4 -6
@@ -11538,11 +11538,9 @@ static void bnxt_free_irq(struct bnxt *bp)static int bnxt_request_irq (struct bnxt *bp) { +struct cpu_rmap *rmap =NULL ;int i, j, rc =0 ;unsigned long flags =0 ; -#ifdef CONFIG_RFS_ACCEL -struct cpu_rmap *rmap; -#endif rc =bnxt_setup_int_mode (bp);if (rc) {
@@ -11563,15 +11561,15 @@ static int bnxt_request_irq(struct bnxt *bp)int map_idx =bnxt_cp_num_to_irq_num (bp, i);struct bnxt_irq *irq = &bp->irq_tbl[map_idx]; -#ifdef CONFIG_RFS_ACCEL -if (rmap && bp->bnapi[i]->rx_ring) { +if (IS_ENABLED (CONFIG_RFS_ACCEL ) && + rmap && bp->bnapi[i]->rx_ring) { rc =irq_cpu_rmap_add (rmap, irq->vector);if (rc)netdev_warn (bp->dev,"failed adding irq rmap for ring %d\n" , j); j++; } -#endif + rc =request_irq (irq->vector, irq->handler, flags, irq->name, bp->bnapi[i]);if (rc)
Signature · 1 line
2.41.3
Quoted 19 lines · Jason Xing
From: Jason Xing <[email protected]>
I received a kernel-test-bot report[1] that shows the [-Wunused-but-set-variable] warning. Since the previous commit I made, as the 'Fixes' tag shows, gives users an option to turn on and off the
CONFIG_RFS_ACCEL, the issue then can be discovered and reproduced with GCC specifically.Like Simon and Jakub suggested, use fewer #ifdefs which leads to fewer bugs.
[1]
All warnings (new ones prefixed by >>):
drivers/net/ethernet/broadcom/bnxt/bnxt.c: In function 'bnxt_request_irq':Quoted 1 line
Quoted 1 line
drivers/net/ethernet/broadcom/bnxt/bnxt.c:10703:9: warning: variable 'j' set but not used [-Wunused-but-set-variable]10703 | int i, j, rc = 0;
| ^
Quoted 8 lines
Fixes 9b6a30febddf ("net: allow rps/rfs related configs to be switched")Reported-by kernel test robot <[email protected]>Signed-off-by Jason Xing <[email protected]>---
v21. use a better approach with fewer #ifdefs (Simon, Jakub)
Thanks for the update.
This patch was applied to netdev/net.git (main) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:
Quoted 9 lines · On Wed, 2 Jul 2025 14:48:22 +0800 you wrote:
From: Jason Xing <[email protected]>
I received a kernel-test-bot report[1] that shows the [-Wunused-but-set-variable] warning. Since the previous commit I made, as the 'Fixes' tag shows, gives users an option to turn on and off the
CONFIG_RFS_ACCEL, the issue then can be discovered and reproduced with GCC specifically.[...]
Here is the summary with links:
- [net,v2] bnxt_en: eliminate the compile warning in bnxt_request_irq due to CONFIG_RFS_ACCEL
https://git.kernel.org/netdev/net/c/b9fd9888a565
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html