Skip to contentSkip to conversation

Input: pcf50633-input - Remove

PATCH Applied [email protected] 3 participants 6 messages Jun 29, 2025 – Jul 2, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Input: pcf50633-input - Remove

From: "Dr. David Alan Gilbert" <[email protected]>

The pcf50633 was used as part of the OpenMoko devices but the support for its main chip was recently removed in:
commit 61b7f8920b17 ("ARM: s3c: remove all s3c24xx support")

Remove the input code.

This was originally posted as a set of pcf50633 removals in March, and is the only major component that hasn't been picked up.
https://lore.kernel.org/all/[email protected]/

---
 drivers/input/misc/Kconfig          |   7 --
 drivers/input/misc/Makefile         |   1 -
 drivers/input/misc/pcf50633-input.c | 113 ----------------------------
 3 files changed, 121 deletions(-)
 delete mode 100644 drivers/input/misc/pcf50633-input.c
drivers/input/misc/Kconfig +0 -7
index f5496ca0c0d2..0fb21c99a5e3 100644
@@ -584,13 +584,6 @@ config INPUT_PALMAS_PWRBUTTON
 	  To compile this driver as a module, choose M here. The module will
 	  be called palmas_pwrbutton.
 
-config INPUT_PCF50633_PMU
-	tristate "PCF50633 PMU events"
-	depends on MFD_PCF50633
-	help
-	 Say Y to include support for delivering  PMU events via  input
-	 layer on NXP PCF50633.
-
 config INPUT_PCF8574
 	tristate "PCF8574 Keypad input device"
 	depends on I2C
drivers/input/misc/Makefile +0 -1
index 6d91804d0a6f..d468c8140b93 100644
@@ -59,7 +59,6 @@ obj-$(CONFIG_INPUT_MC13783_PWRBUTTON)	+= mc13783-pwrbutton.o
 obj-$(CONFIG_INPUT_MMA8450)		+= mma8450.o
 obj-$(CONFIG_INPUT_PALMAS_PWRBUTTON)	+= palmas-pwrbutton.o
 obj-$(CONFIG_INPUT_PCAP)		+= pcap_keys.o
-obj-$(CONFIG_INPUT_PCF50633_PMU)	+= pcf50633-input.o
 obj-$(CONFIG_INPUT_PCF8574)		+= pcf8574_keypad.o
 obj-$(CONFIG_INPUT_PCSPKR)		+= pcspkr.o
 obj-$(CONFIG_INPUT_PM8941_PWRKEY)	+= pm8941-pwrkey.o
drivers/input/misc/pcf50633-input.c deleted +0 -113

113 lines not on this page · raw message

Signature · 1 line
2.50.0
maintainer Applied
#1 lore raw
Quoted 6 lines · On Sun, Jun 29, 2025 at 10:28:20PM +0100, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

The pcf50633 was used as part of the OpenMoko devices but the support for its main chip was recently removed in:
commit 61b7f8920b17 ("ARM: s3c: remove all s3c24xx support")

Quoted 7 lines

Remove the input code.

This was originally posted as a set of pcf50633 removals in March, and is the only major component that hasn't been picked up.
https://lore.kernel.org/all/[email protected]/

Applied, thank you.

Signature · 1 line
Dmitry
#2 lore raw
Quoted 9 lines · * Dmitry Torokhov ([email protected]) wrote:
Quoted 8 lines · On Sun, Jun 29, 2025 at 10:28:20PM +0100, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

The pcf50633 was used as part of the OpenMoko devices but the support for its main chip was recently removed in:
commit 61b7f8920b17 ("ARM: s3c: remove all s3c24xx support")

Remove the input code.

Quoted 7 lines
Quoted 5 lines

This was originally posted as a set of pcf50633 removals in March, and is the only major component that hasn't been picked up.
https://lore.kernel.org/all/[email protected]/

Applied, thank you.

Thanks!

Dave

Quoted 2 lines
Signature · 1 line
Dmitry
Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
#3 lore raw
In reply to Dmitry Torokhov

Lee:

Quoted 9 lines · * Dmitry Torokhov ([email protected]) wrote:
Quoted 8 lines · On Sun, Jun 29, 2025 at 10:28:20PM +0100, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

The pcf50633 was used as part of the OpenMoko devices but the support for its main chip was recently removed in:
commit 61b7f8920b17 ("ARM: s3c: remove all s3c24xx support")

Remove the input code.

Quoted 7 lines
Quoted 5 lines

This was originally posted as a set of pcf50633 removals in March, and is the only major component that hasn't been picked up.
https://lore.kernel.org/all/[email protected]/

Applied, thank you.

I see Dmitry has got that into -next, so I've posted a patch to take out the pcf50633 header which is the last bit left.

Dave

Quoted 2 lines
Signature · 1 line
Dmitry
Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
maintainer
#4 lore raw
Quoted 16 lines · Dr. David Alan Gilbert

Lee:

Quoted 13 lines · * Dmitry Torokhov ([email protected]) wrote:
Quoted 12 lines · On Sun, Jun 29, 2025 at 10:28:20PM +0100, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

The pcf50633 was used as part of the OpenMoko devices but the support for its main chip was recently removed in:
commit 61b7f8920b17 ("ARM: s3c: remove all s3c24xx support")

Remove the input code.

This was originally posted as a set of pcf50633 removals in March, and is the only major component that hasn't been picked up.
https://lore.kernel.org/all/[email protected]/

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

Applied, thank you.

I see Dmitry has got that into -next, so I've posted a patch to take out the pcf50633 header which is the last bit left.

Lee, do you want me to take it through my tree as well to avoid juggling inter-tree dependencies?

Thanks.

Signature · 1 line
Dmitry
#5 lore raw
Quoted 19 lines · Dmitry Torokhov
Quoted 18 lines · Dr. David Alan Gilbert

Lee:

Quoted 15 lines · * Dmitry Torokhov ([email protected]) wrote:
Quoted 13 lines · On Sun, Jun 29, 2025 at 10:28:20PM +0100, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

The pcf50633 was used as part of the OpenMoko devices but the support for its main chip was recently removed in:
commit 61b7f8920b17 ("ARM: s3c: remove all s3c24xx support")

Remove the input code.

This was originally posted as a set of pcf50633 removals in March, and is the only major component that hasn't been picked up.
https://lore.kernel.org/all/[email protected]/

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Applied, thank you.

I see Dmitry has got that into -next, so I've posted a patch to take out the pcf50633 header which is the last bit left.

Lee, do you want me to take it through my tree as well to avoid juggling inter-tree dependencies?

If the driver is unused, it shouldn't cause too many issues. Let's ensure that all of these get applied for this cycle and all should be well.

Signature · 1 line
Lee Jones [李琼斯]