Skip to contentSkip to conversation

dt-bindings: net: Convert Marvell Armada NETA and BM to DT schema

PATCH In review Rob Herring (Arm) 3 participants 4 messages Jul 2, 2025 – Jul 20, 2025

Subsystems (3)
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: net: Convert Marvell Armada NETA and BM to DT schema

Convert Marvell Armada NETA Ethernet Controller and Buffer Manager bindings to schema. It is a straight forward conversion.

---
 .../bindings/net/marvell,armada-370-neta.yaml | 79 +++++++++++++++++++
 .../net/marvell,armada-380-neta-bm.yaml       | 60 ++++++++++++++
 .../bindings/net/marvell-armada-370-neta.txt  | 50 ------------
 .../bindings/net/marvell-neta-bm.txt          | 47 -----------
 .../devicetree/bindings/vendor-prefixes.yaml  |  1 +
 5 files changed, 140 insertions(+), 97 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/marvell,armada-370-neta.yaml
 create mode 100644 Documentation/devicetree/bindings/net/marvell,armada-380-neta-bm.yaml
 delete mode 100644 Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt
 delete mode 100644 Documentation/devicetree/bindings/net/marvell-neta-bm.txt
Documentation/devicetree/bindings/net/marvell,armada-370-neta.yaml new file +79 -0
new file mode 100644
index 000000000000..8814977da024
@@ -0,0 +1,79 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/marvell,armada-370-neta.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Marvell Armada 370/XP/3700/AC5 Ethernet Controller (NETA)
+
+maintainers:
+  - Marcin Wojtas <[email protected]>
+
+allOf:
+  - $ref: /schemas/net/ethernet-controller.yaml#
+
+properties:
+  compatible:
+    enum:
+      - marvell,armada-370-neta
+      - marvell,armada-xp-neta
+      - marvell,armada-3700-neta
+      - marvell,armada-ac5-neta
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    minItems: 1
+    maxItems: 2
+
+  clock-names:
+    minItems: 1
+    items:
+      - const: core
+      - const: bus
+
+  phys:
+    maxItems: 1
+
+  tx-csum-limit:
+    description: Maximum MTU in bytes for Tx checksum offload; default is 1600 for
+      armada-370-neta and 9800 for others.
+    $ref: /schemas/types.yaml#/definitions/uint32
+
+  buffer-manager:
+    description: Phandle to hardware buffer manager.
+    $ref: /schemas/types.yaml#/definitions/phandle
+
+  bm,pool-long:
+    description: Pool ID for packets larger than the short threshold.
+    $ref: /schemas/types.yaml#/definitions/uint32
+
+  bm,pool-short:
+    description: Pool ID for packets smaller than the long threshold.
+    $ref: /schemas/types.yaml#/definitions/uint32
+
+required:
+  - compatible
+  - reg
+  - clocks
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    ethernet@70000 {
+        compatible = "marvell,armada-370-neta";
+        reg = <0x70000 0x2500>;
+        interrupts = <8>;
+        clocks = <&gate_clk 4>;
+        tx-csum-limit = <9800>;
+        phy = <&phy0>;
+        phy-mode = "rgmii-id";
+        buffer-manager = <&bm>;
+        bm,pool-long = <0>;
+        bm,pool-short = <1>;
+    };
Documentation/devicetree/bindings/net/marvell,armada-380-neta-bm.yaml new file +60 -0

60 lines not on this page · raw message

Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt deleted +0 -50

50 lines not on this page · raw message

Documentation/devicetree/bindings/net/marvell-neta-bm.txt deleted +0 -47

47 lines not on this page · raw message

Documentation/devicetree/bindings/vendor-prefixes.yaml +1 -0
index 5d2a7a8d3ac6..741b545e3ab0 100644
@@ -21,6 +21,7 @@ patternProperties:
   "^(pciclass|pinctrl-single|#pinctrl-single|PowerPC),.*": true
   "^(pl022|pxa-mmc|rcar_sound|rotary-encoder|s5m8767|sdhci),.*": true
   "^(simple-audio-card|st-plgpio|st-spics|ts),.*": true
+  "^pool[0-3],.*": true
 
   # Keep list in alphabetical order.
   "^100ask,.*":
Signature · 1 line
2.47.2
maintainer
#1 lore raw

Documentation/devicetree/bindings/vendor-prefixes.yaml patternProperties: · line 24

Quoted 9 lines · Rob Herring (Arm)
Documentation/devicetree/bindings/vendor-prefixes.yaml +1 -0
index 5d2a7a8d3ac6..741b545e3ab0 100644
@@ -21,6 +21,7 @@ patternProperties:
   "^(pciclass|pinctrl-single|#pinctrl-single|PowerPC),.*": true
   "^(pl022|pxa-mmc|rcar_sound|rotary-encoder|s5m8767|sdhci),.*": true
   "^(simple-audio-card|st-plgpio|st-spics|ts),.*": true
+  "^pool[0-3],.*": true

The 'DO NOT ADD NEW PROPERTIES TO THIS LIST' comment just above this block is a bit scaring, even if the list has been indeed updated a few times. @Rob: can you please confirm this chunk is intended?

Also I understand you want this patch to go through the net-next tree, could you please confirm?

Thanks,

/P

author maintainer
#2 lore raw
Quoted 15 lines · Paolo Abeni

Documentation/devicetree/bindings/vendor-prefixes.yaml patternProperties: · line 24

Quoted 9 lines · Rob Herring (Arm)
Documentation/devicetree/bindings/vendor-prefixes.yaml +1 -0
index 5d2a7a8d3ac6..741b545e3ab0 100644
@@ -21,6 +21,7 @@ patternProperties:
   "^(pciclass|pinctrl-single|#pinctrl-single|PowerPC),.*": true
   "^(pl022|pxa-mmc|rcar_sound|rotary-encoder|s5m8767|sdhci),.*": true
   "^(simple-audio-card|st-plgpio|st-spics|ts),.*": true
+  "^pool[0-3],.*": true

The 'DO NOT ADD NEW PROPERTIES TO THIS LIST' comment just above this block is a bit scaring, even if the list has been indeed updated a few times. @Rob: can you please confirm this chunk is intended?

Yes, it is intended. It's not new properties. It's properties added to the schemas which I suppose I missed when initially populating this list.

Quoted 2 lines

Also I understand you want this patch to go through the net-next tree, could you please confirm?

Yes.

Rob

maintainer
#3 lore raw
In reply to Rob Herring (Arm)
Quoted 2 lines · On Wed, 2 Jul 2025 17:26:24 -0500 Rob Herring (Arm) wrote:

Convert Marvell Armada NETA Ethernet Controller and Buffer Manager bindings to schema. It is a straight forward conversion.

This still needs review, and it's getting close to the 2 week threshold where some patchwork instances will automatically archive the patch.