Intel VSEC/PMT: Introduce Discovery Driver
Subsystems (7)
David E. Box
maintainerv3 cover Intel VSEC/PMT: Introduce Discovery Driver
This patch series introduces a new discovery driver for Intel Platform Monitoring Technology (PMT) and a set of supporting changes to improve telemetry integration across Intel VSEC features.
The primary goal of this series is to add the PMT Discovery driver, which enumerates and exposes telemetry attributes by parsing hardware-provided discovery tables from OOBMSM devices. In particular, the discovery driver gathers detailed capability information (such as telemetry region attributes) that will later enable direct access to telemetry regions via a new API (intel_pmt_get_regions_by_feature()). This API is crucial for retrieving data like per-RMID counters.
The remainder of the series consists of several preparatory and testing patches:
1. Private Data and CPU Mapping: The VSEC driver now includes per-device private data to store the OOBMSM-to-CPU mapping. The TPMI driver copies its platform info into this common area (via intel_vsec_set_mapping()), allowing other VSEC features to access CPU mapping information without redundant queries.
2. Device Links Enhancements: With telemetry now depending on both the TPMI driver (for CPU mapping) and the new discovery driver (for telemetry region attributes), device links have been added and optimized. These changes ensure that supplier drivers are probed and registered before consumer drivers, enforcing the proper dependency order for reliable telemetry feature access.
4. Discovery Driver and API: The core of the series is the addition of the PMT Discovery driver. This driver not only implements discovery of telemetry attributes and capability data (exposed via sysfs) but also introduces an API to retrieve telemetry regions by feature, which is essential for features like per-RMID telemetry counters.
5. Testing: A simple KUNIT test is provided for the enhanced discovery API to ensure its reliability and correctness.
Together, these patches provide a foundation for future telemetry enhancements in the Intel VSEC framework. They enable a unified interface for accessing hardware telemetry capabilities and ensure that inter-driver dependencies are properly managed through device links.
David E. Box (15):
MAINTAINERS: Add link to documentation of Intel PMT ABI platform/x86/intel/vsec: Add private data for per-device data platform/x86/intel/vsec: Create wrapper to walk PCI config space platform/x86/intel/vsec: Add device links to enforce dependencies platform/x86/intel/vsec: Skip absent features during initialization platform/x86/intel/vsec: Skip driverless features platform/x86/intel/vsec: Add new Discovery feature platform/x86/intel/pmt: Add PMT Discovery driver
docs: Add ABI documentation for intel_pmt feature directories platform/x86/intel/tpmi: Relocate platform info to intel_vsec.h platform/x86/intel/vsec: Set OOBMSM to CPU mapping platform/x86/intel/tpmi: Get OOBMSM CPU mapping from TPMI platform/x86/intel/pmt/discovery: Get telemetry attributes platform/x86/intel/pmt/telemetry: Add API to retrieve telemetry
regions by feature
platform/x86/intel/pmt: KUNIT test for PMT Enhanced Discovery API
.../testing/sysfs-class-intel_pmt-features | 134 ++++ MAINTAINERS | 2 + drivers/platform/x86/intel/plr_tpmi.c | 3 +- drivers/platform/x86/intel/pmt/Kconfig | 27 + drivers/platform/x86/intel/pmt/Makefile | 4 + drivers/platform/x86/intel/pmt/class.c | 35 +- drivers/platform/x86/intel/pmt/class.h | 9 + .../platform/x86/intel/pmt/discovery-kunit.c | 116 ++++ drivers/platform/x86/intel/pmt/discovery.c | 635 ++++++++++++++++++ drivers/platform/x86/intel/pmt/features.c | 205 ++++++ drivers/platform/x86/intel/pmt/telemetry.c | 94 ++- .../intel/speed_select_if/isst_tpmi_core.c | 9 +- .../uncore-frequency/uncore-frequency-tpmi.c | 7 +- drivers/platform/x86/intel/vsec.c | 372 +++++++++- drivers/platform/x86/intel/vsec_tpmi.c | 8 +- drivers/powercap/intel_rapl_tpmi.c | 9 +- include/linux/intel_pmt_features.h | 157 +++++ include/linux/intel_tpmi.h | 27 +- include/linux/intel_vsec.h | 98 ++- 19 files changed, 1885 insertions(+), 66 deletions(-) create mode 100644 Documentation/ABI/testing/sysfs-class-intel_pmt-features create mode 100644 drivers/platform/x86/intel/pmt/discovery-kunit.c create mode 100644 drivers/platform/x86/intel/pmt/discovery.c create mode 100644 drivers/platform/x86/intel/pmt/features.c create mode 100644 include/linux/intel_pmt_features.h
base-commit: d0b3b7b22dfa1f4b515fd3a295b3fd958f9e81af
Signature · 1 line
2.43.0
David E. Box
maintainerPATCH v3 1/15 MAINTAINERS: Add link to documentation of Intel PMT ABI
Add a link to the documentation for the Intel Platform Monitoring Technology ABI in Documentation/ABI/testing/sysfs-class-intel_pmt
---
Changes in v3:
- No changes
Changes in v2:
- No changes
MAINTAINERS | 1 + 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
@@ -12388,6 +12388,7 @@ F: include/linux/mfd/intel_soc_pmic* INTEL PMT DRIVERS M: David E. Box <[email protected]> S: Supported +F: Documentation/ABI/testing/sysfs-class-intel_pmt F: drivers/platform/x86/intel/pmt/ INTEL PRO/WIRELESS 2100, 2200BG, 2915ABG NETWORK CONNECTION SUPPORT
Signature · 1 line
2.43.0
David E. Box
maintainerPATCH v3 2/15 platform/x86/intel/vsec: Add private data for per-device data
In reply to David E. BoxIntroduce a new private structure, struct vsec_priv, to hold a pointer to the platform-specific information. Although the driver didn’t previously require this per-device data, adding it now lays the groundwork for upcoming patches that will manage such data. No functional changes.
---
Changes in v3:
- No changes
Changes in v2:
- No changes
drivers/platform/x86/intel/vsec.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
drivers/platform/x86/intel/vsec.c +12 -0
@@ -32,6 +32,10 @@ static DEFINE_IDA(intel_vsec_ida);static DEFINE_IDA (intel_vsec_sdsi_ida);static DEFINE_XARRAY_ALLOC (auxdev_array); +struct vsec_priv { +struct intel_vsec_platform_info *info; +}; +static const char *intel_vsec_name (enum intel_vsec_id id) {switch (id) {
@@ -348,6 +352,7 @@ EXPORT_SYMBOL_NS_GPL(intel_vsec_register, "INTEL_VSEC");static int intel_vsec_pci_probe (struct pci_dev *pdev,const struct pci_device_id *id) {struct intel_vsec_platform_info *info; +struct vsec_priv *priv;bool have_devices = false;int ret;
@@ -360,6 +365,13 @@ static int intel_vsec_pci_probe(struct pci_dev *pdev, const struct pci_device_idif (!info)return -EINVAL ; + priv =devm_kzalloc (&pdev->dev,sizeof (*priv),GFP_KERNEL ); +if (!priv) +return -ENOMEM ; + + priv->info = info; +pci_set_drvdata (pdev, priv); +if (intel_vsec_walk_dvsec (pdev, info)) have_devices = true;
Signature · 1 line
2.43.0
David E. Box
maintainerPATCH v3 3/15 platform/x86/intel/vsec: Create wrapper to walk PCI config space
In reply to David E. BoxCombine three PCI config space walkers — intel_vsec_walk_dvsec(), intel_vsec_walk_vsec(), and intel_vsec_walk_header() — into a new wrapper function, intel_vsec_feature_walk(). This refactoring simplifies the probe logic and lays the groundwork for future patches that will loop over these calls. No functional changes.
---
Changes in v3:
- Rename intel_vsec_feature_walk() to intel_vsec_get_features() and have it return bool instead of passing as an argument
Changes in v2:
- No changes
drivers/platform/x86/intel/vsec.c | 38 +++++++++++++++++++++---------- 1 file changed, 26 insertions(+), 12 deletions(-)
drivers/platform/x86/intel/vsec.c +26 -12
@@ -349,11 +349,35 @@ int intel_vsec_register(struct pci_dev *pdev, }EXPORT_SYMBOL_NS_GPL (intel_vsec_register,"INTEL_VSEC" ); +static bool intel_vsec_get_features (struct pci_dev *pdev, +struct intel_vsec_platform_info *info) +{ +bool found = false; + +/* +* Both DVSEC and VSEC capabilities can exist on the same device, +* so both intel_vsec_walk_dvsec() and intel_vsec_walk_vsec() must be +* called independently. Additionally, intel_vsec_walk_header() is +* needed for devices that do not have VSEC/DVSEC but provide the +* information via device_data. +*/ +if (intel_vsec_walk_dvsec (pdev, info)) + found = true; + +if (intel_vsec_walk_vsec (pdev, info)) + found = true; + +if (info && (info->quirks &VSEC_QUIRK_NO_DVSEC ) && +intel_vsec_walk_header (pdev, info)) + found = true; + +return found; +} +static int intel_vsec_pci_probe (struct pci_dev *pdev,const struct pci_device_id *id) {struct intel_vsec_platform_info *info;struct vsec_priv *priv; -bool have_devices = false;int ret; ret =pcim_enable_device (pdev);
@@ -372,17 +396,7 @@ static int intel_vsec_pci_probe(struct pci_dev *pdev, const struct pci_device_id priv->info = info;pci_set_drvdata (pdev, priv); -if (intel_vsec_walk_dvsec (pdev, info)) - have_devices = true; - -if (intel_vsec_walk_vsec (pdev, info)) - have_devices = true; - -if (info && (info->quirks &VSEC_QUIRK_NO_DVSEC ) && -intel_vsec_walk_header (pdev, info)) - have_devices = true; - -if (!have_devices) +if (!intel_vsec_get_features (pdev, info))return -ENODEV ;return 0 ;
Signature · 1 line
2.43.0
David E. Box
maintainerPATCH v3 4/15 platform/x86/intel/vsec: Add device links to enforce dependencies
In reply to David E. BoxNew Intel VSEC features will have dependencies on other features, requiring certain supplier drivers to be probed before their consumers. To enforce this dependency ordering, introduce device links using device_link_add(), ensuring that suppliers are fully registered before consumers are probed.
- Add device link tracking by storing supplier devices and tracking their state.
- Implement intel_vsec_link_devices() to establish links between suppliers and consumers based on feature dependencies.
- Add get_consumer_dependencies() to retrieve supplier-consumer relationships.
- Modify feature registration logic:
* Consumers now check that all required suppliers are registered before being initialized.
* suppliers_ready() verifies that all required supplier devices are available.
- Prevent potential null consumer name issue in sysfs:
- Use dev_set_name() when creating auxiliary devices to ensure a unique, non-null consumer name.
- Update intel_vsec_pci_probe() to loop up to the number of possible features or when all devices are registered, whichever comes first.
- Introduce VSEC_CAP_UNUSED to prevent sub-features (registered via exported APIs) from being mistakenly linked.
---
Changes in v3:
- In suppliers_ready() add WARN_ON_ONCE on feature check. Also include bug.h
- Add found_any bool to check the return value from intel_vsec_get_features() and return -ENODEV if none were ever found.
Changes in v2:
- Simplify dependency search in get_consumer_dependencies() per comments from Ilpo.
- Add rollback for auxiliary_device_uninit() in intel_vsec_add_aux().
- In suppliers_ready() clarify that for_each_set_bit() is searching for all *ready* suppliers, not all suppliers. If any is not ready and not ignored, it immediately returns.
- In suppliers_ready() check device_link_add() return status.
- In intel_vsec_probe() uses info->caps consistently.
- Fix spelling errors and remove unrelated changes.
drivers/platform/x86/intel/vsec.c | 223 ++++++++++++++++++++++++++++-- include/linux/intel_vsec.h | 28 +++- 2 files changed, 236 insertions(+), 15 deletions(-)
drivers/platform/x86/intel/vsec.c +213 -10
@@ -15,9 +15,12 @@#include <linux/auxiliary_bus.h> #include <linux/bits.h> +#include <linux/bitops.h> +#include <linux/bug.h> #include <linux/cleanup.h> #include <linux/delay.h> #include <linux/idr.h> +#include <linux/log2.h> #include <linux/intel_vsec.h> #include <linux/kernel.h> #include <linux/module.h>
@@ -32,8 +35,17 @@ static DEFINE_IDA(intel_vsec_ida);static DEFINE_IDA (intel_vsec_sdsi_ida);static DEFINE_XARRAY_ALLOC (auxdev_array); +enum vsec_device_state { +STATE_NOT_FOUND , +STATE_REGISTERED , +STATE_SKIP , +}; +struct vsec_priv {struct intel_vsec_platform_info *info; +struct device *suppliers[VSEC_FEATURE_COUNT ]; +enum vsec_device_state state[VSEC_FEATURE_COUNT ]; +unsigned long found_caps; };static const char *intel_vsec_name (enum intel_vsec_id id)
@@ -95,6 +107,74 @@ static void intel_vsec_dev_release(struct device *dev)kfree (intel_vsec_dev); } +static const struct vsec_feature_dependency * +get_consumer_dependencies (struct vsec_priv *priv,int cap_id) +{ +const struct vsec_feature_dependency *deps = priv->info->deps; +int consumer_id = priv->info->num_deps; + +if (!deps) +return NULL ; + +while (consumer_id--) +if (deps[consumer_id].feature ==BIT (cap_id)) +return &deps[consumer_id]; + +return NULL ; +} + +/* +* Although pci_device_id table is available in the pdev, this prototype is +* necessary because the code using it can be called by an exported API that +* might pass a different pdev. +*/ +static const struct pci_device_id intel_vsec_pci_ids[]; + +static int intel_vsec_link_devices (struct pci_dev *pdev,struct device *dev, +int consumer_id) +{ +const struct vsec_feature_dependency *deps; +enum vsec_device_state *state; +struct device **suppliers; +struct vsec_priv *priv; +int supplier_id; + +if (!consumer_id) +return 0 ; + +if (!pci_match_id (intel_vsec_pci_ids, pdev)) +return 0 ; + + priv =pci_get_drvdata (pdev); + state = priv->state; + suppliers = priv->suppliers; + + priv->suppliers[consumer_id] = dev; + + deps =get_consumer_dependencies (priv, consumer_id); +if (!deps) +return 0 ; + +for_each_set_bit (supplier_id, &deps->supplier_bitmap,VSEC_FEATURE_COUNT ) { +struct device_link *link; + +if (state[supplier_id] !=STATE_REGISTERED ) +continue ; + +if (!suppliers[supplier_id]) { +dev_err (dev,"Bad supplier list\n" ); +return -EINVAL ; + } + + link =device_link_add (dev, suppliers[supplier_id], +DL_FLAG_AUTOPROBE_CONSUMER ); +if (!link) +return -EINVAL ; + } + +return 0 ; +} +int intel_vsec_add_aux (struct pci_dev *pdev,struct device *parent,struct intel_vsec_device *intel_vsec_dev,const char *name)
@@ -132,19 +212,37 @@ int intel_vsec_add_aux(struct pci_dev *pdev, struct device *parent,return ret; } +/* +* Assign a name now to ensure that the device link doesn't contain +* a null string for the consumer name. This is a problem when a supplier +* supplies more than one consumer and can lead to a duplicate name error +* when the link is created in sysfs. +*/ + ret =dev_set_name (&auxdev->dev,"%s.%s.%d" ,KBUILD_MODNAME , auxdev->name, + auxdev->id); +if (ret) + goto cleanup_aux; + + ret =intel_vsec_link_devices (pdev, &auxdev->dev, intel_vsec_dev->cap_id); +if (ret) + goto cleanup_aux; + ret =auxiliary_device_add (auxdev); -if (ret <0 ) { -auxiliary_device_uninit (auxdev); -return ret; - } +if (ret) + goto cleanup_aux;return devm_add_action_or_reset (parent, intel_vsec_remove_aux, auxdev); + +cleanup_aux: +auxiliary_device_uninit (auxdev); +return ret; }EXPORT_SYMBOL_NS_GPL (intel_vsec_add_aux,"INTEL_VSEC" );static int intel_vsec_add_dev (struct pci_dev *pdev,struct intel_vsec_header *header, -struct intel_vsec_platform_info *info) +struct intel_vsec_platform_info *info, +unsigned long cap_id) { struct intel_vsec_device __free(kfree) *intel_vsec_dev = NULL; struct resource __free(kfree) *res = NULL;
@@ -211,6 +309,7 @@ static int intel_vsec_add_dev(struct pci_dev *pdev, struct intel_vsec_header *he intel_vsec_dev->quirks = info->quirks; intel_vsec_dev->base_addr = info->base_addr; intel_vsec_dev->priv_data = info->priv_data; + intel_vsec_dev->cap_id = cap_id;if (header->id ==VSEC_ID_SDSI ) intel_vsec_dev->ida = &intel_vsec_sdsi_ida;
@@ -225,6 +324,101 @@ static int intel_vsec_add_dev(struct pci_dev *pdev, struct intel_vsec_header *he intel_vsec_name(header->id)); } +static bool suppliers_ready (struct vsec_priv *priv, +const struct vsec_feature_dependency *consumer_deps, +int cap_id) +{ +enum vsec_device_state *state = priv->state; +int supplier_id; + +if (WARN_ON_ONCE (consumer_deps->feature !=BIT (cap_id))) +return false; + +/* +* Verify that all required suppliers have been found. Return false +* immediately if any are still missing. +*/ +for_each_set_bit (supplier_id, &consumer_deps->supplier_bitmap,VSEC_FEATURE_COUNT ) { +if (state[supplier_id] ==STATE_SKIP ) +continue ; + +if (state[supplier_id] ==STATE_NOT_FOUND ) +return false; + } + +/* +* All suppliers have been found and the consumer is ready to be +* registered. +*/ +return true; +} + +static int get_cap_id (u32 header_id,unsigned long *cap_id) +{ +switch (header_id) { +case VSEC_ID_TELEMETRY : + *cap_id =ilog2 (VSEC_CAP_TELEMETRY ); +break ; +case VSEC_ID_WATCHER : + *cap_id =ilog2 (VSEC_CAP_WATCHER ); +break ; +case VSEC_ID_CRASHLOG : + *cap_id =ilog2 (VSEC_CAP_CRASHLOG ); +break ; +case VSEC_ID_SDSI : + *cap_id =ilog2 (VSEC_CAP_SDSI ); +break ; +case VSEC_ID_TPMI : + *cap_id =ilog2 (VSEC_CAP_TPMI ); +break ; +default : +return -EINVAL ; + } + +return 0 ; +} + +static int intel_vsec_register_device (struct pci_dev *pdev, +struct intel_vsec_header *header, +struct intel_vsec_platform_info *info) +{ +const struct vsec_feature_dependency *consumer_deps; +struct vsec_priv *priv; +unsigned long cap_id; +int ret; + + ret =get_cap_id (header->id, &cap_id); +if (ret) +return ret; + +/* +* Only track dependencies for devices probed by the VSEC driver. +* For others using the exported APIs, add the device directly. +*/ +if (!pci_match_id (intel_vsec_pci_ids, pdev)) +return intel_vsec_add_dev (pdev, header, info, cap_id); + + priv =pci_get_drvdata (pdev); +if (priv->state[cap_id] ==STATE_REGISTERED || + priv->state[cap_id] ==STATE_SKIP ) +return -EEXIST ; + + priv->found_caps |=BIT (cap_id); + + consumer_deps =get_consumer_dependencies (priv, cap_id); +if (!consumer_deps ||suppliers_ready (priv, consumer_deps, cap_id)) { + ret =intel_vsec_add_dev (pdev, header, info, cap_id); +if (ret) + priv->state[cap_id] =STATE_SKIP ; +else + priv->state[cap_id] =STATE_REGISTERED ; + +return ret; + } + +return -EAGAIN ; +} +static bool intel_vsec_walk_header (struct pci_dev *pdev,struct intel_vsec_platform_info *info) {
@@ -233,7 +427,7 @@ static bool intel_vsec_walk_header(struct pci_dev *pdev,int ret;for ( ; *header; header++) { - ret =intel_vsec_add_dev (pdev, *header, info); + ret =intel_vsec_register_device (pdev, *header, info);if (!ret) have_devices = true; }
@@ -281,7 +475,7 @@ static bool intel_vsec_walk_dvsec(struct pci_dev *pdev,pci_read_config_dword (pdev, pos +PCI_DVSEC_HEADER2 , &hdr); header.id =PCI_DVSEC_HEADER2_ID (hdr); - ret =intel_vsec_add_dev (pdev, &header, info); + ret =intel_vsec_register_device (pdev, &header, info);if (ret)continue ;
@@ -326,7 +520,7 @@ static bool intel_vsec_walk_vsec(struct pci_dev *pdev, header.tbir =INTEL_DVSEC_TABLE_BAR (table); header.offset =INTEL_DVSEC_TABLE_OFFSET (table); - ret =intel_vsec_add_dev (pdev, &header, info); + ret =intel_vsec_register_device (pdev, &header, info);if (ret)continue ;
@@ -378,7 +572,8 @@ static int intel_vsec_pci_probe(struct pci_dev *pdev, const struct pci_device_id {struct intel_vsec_platform_info *info;struct vsec_priv *priv; -int ret; +int num_caps, ret; +bool found_any = false; ret =pcim_enable_device (pdev);if (ret)
@@ -396,7 +591,15 @@ static int intel_vsec_pci_probe(struct pci_dev *pdev, const struct pci_device_id priv->info = info;pci_set_drvdata (pdev, priv); -if (!intel_vsec_get_features (pdev, info)) + num_caps =hweight_long (info->caps); +while (num_caps--) { + found_any |=intel_vsec_get_features (pdev, info); + +if (priv->found_caps == info->caps) +break ; + } + +if (!found_any)return -ENODEV ;return 0 ;
include/linux/intel_vsec.h +23 -5
@@ -5,11 +5,18 @@#include <linux/auxiliary_bus.h> #include <linux/bits.h> -#define VSEC_CAP_TELEMETRY BIT(0) -#define VSEC_CAP_WATCHER BIT(1) -#define VSEC_CAP_CRASHLOG BIT(2) -#define VSEC_CAP_SDSI BIT(3) -#define VSEC_CAP_TPMI BIT(4) +/* +* VSEC_CAP_UNUSED is reserved. It exists to prevent zero initialized +* intel_vsec devices from being automatically set to a known +* capability with ID 0 +*/ +#define VSEC_CAP_UNUSED BIT(0) +#define VSEC_CAP_TELEMETRY BIT(1) +#define VSEC_CAP_WATCHER BIT(2) +#define VSEC_CAP_CRASHLOG BIT(3) +#define VSEC_CAP_SDSI BIT(4) +#define VSEC_CAP_TPMI BIT(5) +#define VSEC_FEATURE_COUNT 6/* Intel DVSEC offsets */ #define INTEL_DVSEC_ENTRIES 0xA
@@ -81,22 +88,31 @@ struct pmt_callbacks {int (*read_telem)(struct pci_dev *pdev,u32 guid,u64 *data,loff_t off,u32 count); }; +struct vsec_feature_dependency { +unsigned long feature; +unsigned long supplier_bitmap; +}; +/** * struct intel_vsec_platform_info - Platform specific data * @parent: parent device in the auxbus chain * @headers: list of headers to define the PMT client devices to create +* @deps: array of feature dependencies * @priv_data: private data, usable by parent devices, currently a callback * @caps: bitmask of PMT capabilities for the given headers * @quirks: bitmask of VSEC device quirks * @base_addr: allow a base address to be specified (rather than derived) +* @num_deps: Count feature dependencies */ struct intel_vsec_platform_info {struct device *parent;struct intel_vsec_header **headers; +const struct vsec_feature_dependency *deps;void *priv_data;unsigned long caps;unsigned long quirks;u64 base_addr; +int num_deps; };/**
@@ -110,6 +126,7 @@ struct intel_vsec_platform_info {* @priv_data: any private data needed * @quirks: specified quirks * @base_addr: base address of entries (if specified) +* @cap_id: the enumerated id of the vsec feature */ struct intel_vsec_device {struct auxiliary_device auxdev;
@@ -122,6 +139,7 @@ struct intel_vsec_device {size_t priv_data_size;unsigned long quirks;u64 base_addr; +unsigned long cap_id; }; int intel_vsec_add_aux(struct pci_dev *pdev, struct device *parent,
Signature · 1 line
2.43.0
David E. Box
maintainerPATCH v3 5/15 platform/x86/intel/vsec: Skip absent features during initialization
In reply to David E. BoxSome VSEC features depend on the presence of supplier features that may not always be present. To prevent unnecessary retries and device linking during initialization, introduce logic to skip attempts to link consumers to missing suppliers.
---
Changes in v3:
- No changes
Changes in v2:
- No changes
drivers/platform/x86/intel/vsec.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)
drivers/platform/x86/intel/vsec.c +24 -0
@@ -568,11 +568,30 @@ static bool intel_vsec_get_features(struct pci_dev *pdev,return found; } +static void intel_vsec_skip_missing_dependencies (struct pci_dev *pdev) +{ +struct vsec_priv *priv =pci_get_drvdata (pdev); +const struct vsec_feature_dependency *deps = priv->info->deps; +int consumer_id = priv->info->num_deps; + +while (consumer_id--) { +int supplier_id; + + deps = &priv->info->deps[consumer_id]; + +for_each_set_bit (supplier_id, &deps->supplier_bitmap,VSEC_FEATURE_COUNT ) { +if (!(BIT (supplier_id) & priv->found_caps)) + priv->state[supplier_id] =STATE_SKIP ; + } + } +} +static int intel_vsec_pci_probe (struct pci_dev *pdev,const struct pci_device_id *id) {struct intel_vsec_platform_info *info;struct vsec_priv *priv;int num_caps, ret; +int run_once =0 ;bool found_any = false; ret =pcim_enable_device (pdev);
@@ -597,6 +616,11 @@ static int intel_vsec_pci_probe(struct pci_dev *pdev, const struct pci_device_idif (priv->found_caps == info->caps)break ; + +if (!run_once) { +intel_vsec_skip_missing_dependencies (pdev); + run_once =1 ; + } }if (!found_any)
Signature · 1 line
2.43.0
David E. Box
maintainerPATCH v3 6/15 platform/x86/intel/vsec: Skip driverless features
In reply to David E. BoxIf a feature lacks a corresponding driver and that feature is also a supplier, registering it would be prevent the consumer driver from probing. Introduces logic to skip such features during device registration.
---
Changes in v3:
- No changes
Changes in v2:
- No changes
drivers/platform/x86/intel/vsec.c | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-)
drivers/platform/x86/intel/vsec.c +27 -1
@@ -123,6 +123,26 @@ get_consumer_dependencies(struct vsec_priv *priv, int cap_id)return NULL ; } +static bool vsec_driver_present (int cap_id) +{ +unsigned long bit =BIT (cap_id); + +switch (bit) { +case VSEC_CAP_TELEMETRY : +return IS_ENABLED (CONFIG_INTEL_PMT_TELEMETRY ); +case VSEC_CAP_WATCHER : +return IS_ENABLED (CONFIG_INTEL_PMT_WATCHER ); +case VSEC_CAP_CRASHLOG : +return IS_ENABLED (CONFIG_INTEL_PMT_CRASHLOG ); +case VSEC_CAP_SDSI : +return IS_ENABLED (CONFIG_INTEL_SDSI ); +case VSEC_CAP_TPMI : +return IS_ENABLED (CONFIG_INTEL_TPMI ); +default : +return false; + } +} +/* * Although pci_device_id table is available in the pdev, this prototype is * necessary because the code using it can be called by an exported API that
@@ -158,7 +178,8 @@ static int intel_vsec_link_devices(struct pci_dev *pdev, struct device *dev,for_each_set_bit (supplier_id, &deps->supplier_bitmap,VSEC_FEATURE_COUNT ) {struct device_link *link; -if (state[supplier_id] !=STATE_REGISTERED ) +if (state[supplier_id] !=STATE_REGISTERED || + !vsec_driver_present (supplier_id))continue ;if (!suppliers[supplier_id]) {
@@ -405,6 +426,11 @@ static int intel_vsec_register_device(struct pci_dev *pdev, priv->found_caps |=BIT (cap_id); +if (!vsec_driver_present (cap_id)) { + priv->state[cap_id] =STATE_SKIP ; +return -ENODEV ; + } + consumer_deps =get_consumer_dependencies (priv, cap_id);if (!consumer_deps ||suppliers_ready (priv, consumer_deps, cap_id)) { ret =intel_vsec_add_dev (pdev, header, info, cap_id);
Signature · 1 line
2.43.0
David E. Box
maintainerPATCH v3 7/15 platform/x86/intel/vsec: Add new Discovery feature
In reply to David E. BoxAdd the PCIe VSEC ID for new Intel Platform Monitoring Technology Capability Discovery feature. Discovery provides detailed information for the various Intel VSEC features. Also make the driver a supplier for TPMI and Telemetry drivers which will use the information.
---
Changes in v3:
- No changes
Changes in v2:
- Add missing comma in oobmsm_deps[]
drivers/platform/x86/intel/vsec.c | 26 ++++++++++++++++++++++++-- include/linux/intel_vsec.h | 4 +++- 2 files changed, 27 insertions(+), 3 deletions(-)
drivers/platform/x86/intel/vsec.c +24 -2
@@ -66,6 +66,9 @@ static const char *intel_vsec_name(enum intel_vsec_id id)case VSEC_ID_TPMI :return "tpmi" ; +case VSEC_ID_DISCOVERY : +return "discovery" ; +default :return NULL ; }
@@ -84,6 +87,8 @@ static bool intel_vsec_supported(u16 id, unsigned long caps)return !!(caps &VSEC_CAP_SDSI );case VSEC_ID_TPMI :return !!(caps &VSEC_CAP_TPMI ); +case VSEC_ID_DISCOVERY : +return !!(caps &VSEC_CAP_DISCOVERY );default :return false; }
@@ -138,6 +143,8 @@ static bool vsec_driver_present(int cap_id)return IS_ENABLED (CONFIG_INTEL_SDSI );case VSEC_CAP_TPMI :return IS_ENABLED (CONFIG_INTEL_TPMI ); +case VSEC_CAP_DISCOVERY : +return IS_ENABLED (CONFIG_INTEL_PMT_DISCOVERY );default :return false; }
@@ -392,6 +399,9 @@ static int get_cap_id(u32 header_id, unsigned long *cap_id)case VSEC_ID_TPMI : *cap_id =ilog2 (VSEC_CAP_TPMI );break ; +case VSEC_ID_DISCOVERY : + *cap_id =ilog2 (VSEC_CAP_DISCOVERY ); +break ;default :return -EINVAL ; }
@@ -681,14 +691,26 @@ static const struct intel_vsec_platform_info mtl_info = { .caps = VSEC_CAP_TELEMETRY, }; +static const struct vsec_feature_dependency oobmsm_deps[] = { + { + .feature =VSEC_CAP_TELEMETRY , + .supplier_bitmap =VSEC_CAP_DISCOVERY , + }, +}; +/* OOBMSM info */ static const struct intel_vsec_platform_info oobmsm_info = { - .caps =VSEC_CAP_TELEMETRY |VSEC_CAP_SDSI |VSEC_CAP_TPMI , + .caps =VSEC_CAP_TELEMETRY |VSEC_CAP_SDSI |VSEC_CAP_TPMI | +VSEC_CAP_DISCOVERY , + .deps = oobmsm_deps, + .num_deps =ARRAY_SIZE (oobmsm_deps), };/* DMR OOBMSM info */ static const struct intel_vsec_platform_info dmr_oobmsm_info = { - .caps =VSEC_CAP_TELEMETRY |VSEC_CAP_TPMI , + .caps =VSEC_CAP_TELEMETRY |VSEC_CAP_TPMI |VSEC_CAP_DISCOVERY , + .deps = oobmsm_deps, + .num_deps =ARRAY_SIZE (oobmsm_deps), };/* TGL info */
include/linux/intel_vsec.h +3 -1
@@ -16,7 +16,8 @@#define VSEC_CAP_CRASHLOG BIT(3)#define VSEC_CAP_SDSI BIT(4)#define VSEC_CAP_TPMI BIT(5) -#define VSEC_FEATURE_COUNT 6 +#define VSEC_CAP_DISCOVERY BIT(6) +#define VSEC_FEATURE_COUNT 7/* Intel DVSEC offsets */ #define INTEL_DVSEC_ENTRIES 0xA
@@ -33,6 +34,7 @@ enum intel_vsec_id {VSEC_ID_TELEMETRY =2 ,VSEC_ID_WATCHER =3 ,VSEC_ID_CRASHLOG =4 , +VSEC_ID_DISCOVERY =12 ,VSEC_ID_SDSI =65 , VSEC_ID_TPMI = 66, };
Signature · 1 line
2.43.0
David E. Box
maintainerPATCH v3 8/15 platform/x86/intel/pmt: Add PMT Discovery driver
In reply to David E. BoxThis patch introduces a new driver to enumerate and expose Intel Platform Monitoring Technology (PMT) capabilities via a simple discovery mechanism. The PMT Discovery driver parses hardware-provided discovery tables from Intel Out of Band Management Services Modules (OOBMSM) and extracts feature information for various providers (such as TPMI, Telemetry, Crash Log, etc). This unified interface simplifies the process of determining which manageability and telemetry features are supported by a given platform.
This new feature is described in the Intel Platform Monitoring Technology 3.0 specification, section 6.6 Capability.
Key changes and additions:
New file drivers/platform/x86/intel/pmt/discovery.c:
– Implements the discovery logic to map the discovery resource, read the feature discovery table, and validate feature parameters.
New file drivers/platform/x86/intel/pmt/features.c:
– Defines feature names, layouts, and associated capability masks.
– Provides a mapping between raw hardware attributes and sysfs representations for easier integration with user-space tools.
New header include/linux/intel_pmt_features.h:
– Declares constants, masks, and feature identifiers used across the PMT framework.
Sysfs integration:
– Feature attributes are exposed under /sys/class/intel_pmt.
– Each device is represented by a subfolder within the intel_pmt class, named using its DBDF (Domain:Bus:Device.Function), e.g.:
features-0000:00:03.1
– Example directory layout for a device:
/sys/class/intel_pmt/features-0000:00:03.1/
├── accelerator_telemetry
├── crash_log
├── per_core_environment_telemetry
├── per_core_performance_telemetry
├── per_rmid_energy_telemetry
├── per_rmid_perf_telemetry
├── tpmi_control
├── tracing
└── uncore_telemetryBy exposing PMT feature details through sysfs and integrating with the existing PMT class, this driver paves the way for more streamlined integration of PMT-based manageability and telemetry tools.
---
Changes in v3:
- No changes
Changes in v2:
- Add comment spelling out RMID
- Remove extra parens around several uses of PTR_ERR()
- Add PMT_ACCESS_TYPE_RSVD for magic number 0x7
- In pmt_feature_discovery() clarify zero-init of disc_tbl is for false positive compiler warning.
- In features.c fix several spelling errors, use snake case consistently for all capability names, and spell out "telemetry".
drivers/platform/x86/intel/pmt/Kconfig | 12 + drivers/platform/x86/intel/pmt/Makefile | 2 + drivers/platform/x86/intel/pmt/class.c | 35 +- drivers/platform/x86/intel/pmt/class.h | 2 + drivers/platform/x86/intel/pmt/discovery.c | 602 +++++++++++++++++++++ drivers/platform/x86/intel/pmt/features.c | 205 +++++++ include/linux/intel_pmt_features.h | 157 ++++++ 7 files changed, 1013 insertions(+), 2 deletions(-) create mode 100644 drivers/platform/x86/intel/pmt/discovery.c create mode 100644 drivers/platform/x86/intel/pmt/features.c create mode 100644 include/linux/intel_pmt_features.h
drivers/platform/x86/intel/pmt/Kconfig +12 -0
@@ -38,3 +38,15 @@ config INTEL_PMT_CRASHLOG To compile this driver as a module, choose M here: the module will be called intel_pmt_crashlog. + +config INTEL_PMT_DISCOVERY + tristate "Intel Platform Monitoring Technology (PMT) Discovery driver" + depends on INTEL_VSEC + select INTEL_PMT_CLASS + help + The Intel Platform Monitoring Technology (PMT) discovery driver provides + access to details about the various PMT features and feature specific + attributes. + + To compile this driver as a module, choose M here: the module + will be called pmt_discovery.
drivers/platform/x86/intel/pmt/Makefile +2 -0
@@ -10,3 +10,5 @@ obj-$(CONFIG_INTEL_PMT_TELEMETRY) += pmt_telemetry.o pmt_telemetry-y := telemetry.o obj-$(CONFIG_INTEL_PMT_CRASHLOG) += pmt_crashlog.o pmt_crashlog-y := crashlog.o +obj-$(CONFIG_INTEL_PMT_DISCOVERY) += pmt_discovery.o +pmt_discovery-y := discovery.o features.o
drivers/platform/x86/intel/pmt/class.c +33 -2
@@ -9,11 +9,13 @@*/ #include <linux/kernel.h> +#include <linux/log2.h> #include <linux/intel_vsec.h> #include <linux/io-64-nonatomic-lo-hi.h> #include <linux/module.h> #include <linux/mm.h> #include <linux/pci.h> +#include <linux/sysfs.h> #include "class.h"
@@ -166,12 +168,41 @@ static struct attribute *intel_pmt_attrs[] = { &dev_attr_offset.attr,NULL }; -ATTRIBUTE_GROUPS (intel_pmt); -static struct class intel_pmt_class = { +static umode_t intel_pmt_attr_visible (struct kobject *kobj, +struct attribute *attr,int n) +{ + struct device *dev = container_of(kobj, struct device, kobj); +struct auxiliary_device *auxdev =to_auxiliary_dev (dev->parent); +struct intel_vsec_device *ivdev =auxdev_to_ivdev (auxdev); + +/* +* Place the discovery features folder in /sys/class/intel_pmt, but +* exclude the common attributes as they are not applicable. +*/ +if (ivdev->cap_id ==ilog2 (VSEC_CAP_DISCOVERY )) +return 0 ; + +return attr->mode; +} + +static bool intel_pmt_group_visible (struct kobject *kobj) +{ +return true; +} +DEFINE_SYSFS_GROUP_VISIBLE (intel_pmt); + +static const struct attribute_group intel_pmt_group = { + .attrs = intel_pmt_attrs, + .is_visible =SYSFS_GROUP_VISIBLE (intel_pmt), +}; +__ATTRIBUTE_GROUPS (intel_pmt); + +struct class intel_pmt_class = { .name ="intel_pmt" , .dev_groups = intel_pmt_groups, }; +EXPORT_SYMBOL_GPL (intel_pmt_class); static int intel_pmt_populate_entry(struct intel_pmt_entry *entry, struct intel_vsec_device *ivdev,
drivers/platform/x86/intel/pmt/class.h +2 -0
@@ -20,6 +20,7 @@#define GET_ADDRESS (v) ((v) & GENMASK(31, 3))struct pci_dev ; +extern struct class intel_pmt_class;struct telem_endpoint {struct pci_dev *pcidev;
@@ -48,6 +49,7 @@ struct intel_pmt_entry {unsigned long base_addr;size_t size;u32 guid; +u32 num_rmids;/* Number of Resource Monitoring IDs */ int devid; };
drivers/platform/x86/intel/pmt/discovery.c new file +602 -0
602 lines not on this page · raw message
drivers/platform/x86/intel/pmt/features.c new file +205 -0
205 lines not on this page · raw message
include/linux/intel_pmt_features.h new file +157 -0
157 lines not on this page · raw message
Signature · 1 line
2.43.0
David E. Box
maintainerPATCH v3 9/15 docs: Add ABI documentation for intel_pmt feature directories
In reply to David E. BoxAdd a new sysfs ABI documentation file describing the layout and content of the features-<PCI BDF>/ directory used by Intel PMT (Platform Monitoring Technology). This directory exposes telemetry and control feature details for a given PMT PCI device.
---
Changes in v3:
- No changes
Changes in v2:
- Spell out RMID and add description of the feature.
- Add a description of the watcher API
- Update example to use snake case for pmt_sp_policy
.../testing/sysfs-class-intel_pmt-features | 134 ++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 135 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-class-intel_pmt-features
Documentation/ABI/testing/sysfs-class-intel_pmt-features new file +134 -0
@@ -0,0 +1,134 @@ +What: /sys/class/intel_pmt/features-<PCI BDF>/ +Date: 2025-04-24 +KernelVersion: 6.16 +Contact: [email protected] +Description: + The `features-<PCI BDF>/` directory represents the "features" + capability exposed by Intel PMT (Platform Monitoring Technology) + for the given PCI device. + + Each directory corresponds to a PMT feature and contains + attributes describing the available telemetry, monitoring, or + control functionalities. + +Directory Structure: + + /sys/class/intel_pmt/features-<PCI BDF>/ + ├── accelerator_telemetry/ # Per-accelerator telemetry data + ├── crash_log/ # Contains system crash telemetry logs + ├── per_core_environment_telemetry/ # Environmental telemetry per core + ├── per_core_performance_telemetry/ # Performance telemetry per core + ├── per_rmid_energy_telemetry/ # Energy telemetry for RMIDs + ├── per_rmid_perf_telemetry/ # Performance telemetry for RMIDs + ├── tpmi_control/ # TPMI-related controls and telemetry + ├── tracing/ # PMT tracing features + └── uncore_telemetry/ # Uncore telemetry data + +Common Files (Present in all feature directories): + + caps + - Read-only + - Lists available capabilities for this feature. + + guids + - Read-only + - Lists GUIDs associated with this feature. + +Additional Attributes (Conditional Presence): + + max_command_size + - Read-only + - Present if the feature supports out-of-band MCTP access. + - Maximum supported MCTP command size for out-of-band PMT access (bytes). + + max_stream_size + - Read-only + - Present if the feature supports out-of-band MCTP access. + - Maximum supported MCTP stream size (bytes). + + min_watcher_period_ms + - Read-only + - Present if the feature supports the watcher API. + The watcher API provides a writable control interface that allows user + configuration of monitoring behavior, such as setting the sampling or + reporting interval. + - Minimum supported time period for the watcher interface (milliseconds). + + num_rmids + - Read-only + - Present if the feature supports RMID (Resource Monitoring ID) telemetry. + RMIDs are identifiers used by hardware to track and report resource usage, + such as memory bandwidth or energy consumption, on a per-logical-entity + basis (e.g., per core, thread, or process group). + - Maximum number of RMIDs tracked simultaneously. + +Example: +For a device with PCI BDF `0000:00:03.1`, the directory tree could look like: + + /sys/class/intel_pmt/features-0000:00:03.1/ + ├── accelerator_telemetry/ + │ ├── caps + │ ├── guids + │ ├── max_command_size + │ ├── max_stream_size + │ ├── min_watcher_period_ms + ├── crash_log/ + │ ├── caps + │ ├── guids + │ ├── max_command_size + │ ├── max_stream_size + ├── per_core_environment_telemetry/ + │ ├── caps + │ ├── guids + │ ├── max_command_size + │ ├── max_stream_size + │ ├── min_watcher_period_ms + ├── per_rmid_energy_telemetry/ + │ ├── caps + │ ├── guids + │ ├── max_command_size + │ ├── max_stream_size + │ ├── min_watcher_period_ms + │ ├── num_rmids + ├── tpmi_control/ + │ ├── caps + │ ├── guids + ├── tracing/ + │ ├── caps + │ ├── guids + ├── uncore_telemetry/ + │ ├── caps + │ ├── guids + │ ├── max_command_size + │ ├── max_stream_size + │ ├── min_watcher_period_ms + +Notes: + - Some attributes are only present if the corresponding feature supports + the capability (e.g., `max_command_size` for MCTP-capable features). + - Features supporting RMIDs include `num_rmids`. + - Features supporting the watcher API include `min_watcher_period_ms`. + - The `caps` file provides additional information about the functionality + of the feature. + +Example 'caps' content for the 'tracing' feature: + + /sys/class/intel_pmt/features-0000:00:03.1/ + ├── tracing/ + │ ├── caps + + telemetry Available: No + watcher Available: Yes + crashlog Available: No + streaming Available: No + threashold Available: No + window Available: No + config Available: Yes + tracing Available: No + inband Available: Yes + oob Available: Yes + secure_chan Available: No + pmt_sp Available: Yes + pmt_sp_policy Available: Yes + mailbox Available: Yes + bios_lock Available: Yes
MAINTAINERS +1 -0
@@ -12389,6 +12389,7 @@ INTEL PMT DRIVERS M: David E. Box <[email protected]> S: Supported F: Documentation/ABI/testing/sysfs-class-intel_pmt +F: Documentation/ABI/testing/sysfs-class-intel_pmt-features F: drivers/platform/x86/intel/pmt/ INTEL PRO/WIRELESS 2100, 2200BG, 2915ABG NETWORK CONNECTION SUPPORT
Signature · 1 line
2.43.0
David E. Box
maintainerPATCH v3 10/15 platform/x86/intel/tpmi: Relocate platform info to intel_vsec.h
In reply to David E. BoxThe TPMI platform information provides a mapping of OOBMSM PCI devices to logical CPUs. Since this mapping is consistent across all OOBMSM features (e.g., TPMI, PMT, SDSi), it can be leveraged by multiple drivers. To facilitate reuse, relocate the struct intel_tpmi_plat_info to intel_vsec.h, renaming it to struct oobmsm_plat_info, making it accessible to other features. While modifying headers, place them in alphabetical order.
---
Changes in v3:
- No changes
Changes in v2:
- Add change for uncore-frequency-tmpi 6.16-rc1
- In intel_tpmi.h add newline after headers
drivers/platform/x86/intel/plr_tpmi.c | 3 ++- .../intel/speed_select_if/isst_tpmi_core.c | 9 ++++--- .../uncore-frequency/uncore-frequency-tpmi.c | 7 ++--- drivers/platform/x86/intel/vsec_tpmi.c | 4 +-- drivers/powercap/intel_rapl_tpmi.c | 9 ++++--- include/linux/intel_tpmi.h | 27 +++---------------- include/linux/intel_vsec.h | 22 +++++++++++++++ 7 files changed, 43 insertions(+), 38 deletions(-)
drivers/platform/x86/intel/plr_tpmi.c +2 -1
@@ -14,6 +14,7 @@#include <linux/err.h> #include <linux/gfp_types.h> #include <linux/intel_tpmi.h> +#include <linux/intel_vsec.h> #include <linux/io.h> #include <linux/iopoll.h> #include <linux/kstrtox.h>
@@ -256,7 +257,7 @@ DEFINE_SHOW_STORE_ATTRIBUTE(plr_status);static int intel_plr_probe (struct auxiliary_device *auxdev,const struct auxiliary_device_id *id) { -struct intel_tpmi_plat_info *plat_info; +struct oobmsm_plat_info *plat_info;struct dentry *dentry;int i, num_resources;struct resource *res;
drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c +5 -4
@@ -22,6 +22,7 @@#include <linux/auxiliary_bus.h> #include <linux/delay.h> #include <linux/intel_tpmi.h> +#include <linux/intel_vsec.h> #include <linux/fs.h> #include <linux/io.h> #include <linux/kernel.h>
@@ -1546,7 +1547,7 @@ int tpmi_sst_dev_add(struct auxiliary_device *auxdev) {struct tpmi_per_power_domain_info *pd_info;bool read_blocked =0 , write_blocked =0 ; -struct intel_tpmi_plat_info *plat_info; +struct oobmsm_plat_info *plat_info;struct device *dev = &auxdev->dev;struct tpmi_sst_struct *tpmi_sst;u8 i, num_resources, io_die_cnt;
@@ -1698,7 +1699,7 @@ EXPORT_SYMBOL_NS_GPL(tpmi_sst_dev_add, "INTEL_TPMI_SST");void tpmi_sst_dev_remove (struct auxiliary_device *auxdev) {struct tpmi_sst_struct *tpmi_sst =auxiliary_get_drvdata (auxdev); -struct intel_tpmi_plat_info *plat_info; +struct oobmsm_plat_info *plat_info; plat_info =tpmi_get_platform_data (auxdev);if (!plat_info)
@@ -1720,7 +1721,7 @@ void tpmi_sst_dev_suspend(struct auxiliary_device *auxdev) {struct tpmi_sst_struct *tpmi_sst =auxiliary_get_drvdata (auxdev);struct tpmi_per_power_domain_info *power_domain_info; -struct intel_tpmi_plat_info *plat_info; +struct oobmsm_plat_info *plat_info;void __iomem *cp_base; plat_info =tpmi_get_platform_data (auxdev);
@@ -1748,7 +1749,7 @@ void tpmi_sst_dev_resume(struct auxiliary_device *auxdev) {struct tpmi_sst_struct *tpmi_sst =auxiliary_get_drvdata (auxdev);struct tpmi_per_power_domain_info *power_domain_info; -struct intel_tpmi_plat_info *plat_info; +struct oobmsm_plat_info *plat_info;void __iomem *cp_base; plat_info =tpmi_get_platform_data (auxdev);
drivers/platform/x86/intel/uncore-frequency/uncore-frequency-tpmi.c +4 -3
@@ -22,9 +22,10 @@#include <linux/auxiliary_bus.h> #include <linux/bitfield.h> #include <linux/bits.h> +#include <linux/intel_tpmi.h> +#include <linux/intel_vsec.h> #include <linux/io.h> #include <linux/module.h> -#include <linux/intel_tpmi.h> #include "../tpmi_power_domains.h" #include "uncore-frequency-common.h"
@@ -448,7 +449,7 @@ static void remove_cluster_entries(struct tpmi_uncore_struct *tpmi_uncore) }static void set_cdie_id (int domain_id,struct tpmi_uncore_cluster_info *cluster_info, -struct intel_tpmi_plat_info *plat_info) +struct oobmsm_plat_info *plat_info) { cluster_info->cdie_id = domain_id;
@@ -465,7 +466,7 @@ static void set_cdie_id(int domain_id, struct tpmi_uncore_cluster_info *cluster_static int uncore_probe (struct auxiliary_device *auxdev,const struct auxiliary_device_id *id) {bool read_blocked =0 , write_blocked =0 ; -struct intel_tpmi_plat_info *plat_info; +struct oobmsm_plat_info *plat_info;struct tpmi_uncore_struct *tpmi_uncore;bool uncore_sysfs_added = false;int ret, i, pkg =0 ;
drivers/platform/x86/intel/vsec_tpmi.c +2 -2
@@ -116,7 +116,7 @@ struct intel_tpmi_info {struct intel_vsec_device *vsec_dev;int feature_count;u64 pfs_start; -struct intel_tpmi_plat_info plat_info; +struct oobmsm_plat_info plat_info;void __iomem *tpmi_control_mem;struct dentry *dbgfs_dir; };
@@ -187,7 +187,7 @@ struct tpmi_feature_state {/* Used during auxbus device creation */ static DEFINE_IDA (intel_vsec_tpmi_ida); -struct intel_tpmi_plat_info *tpmi_get_platform_data (struct auxiliary_device *auxdev) +struct oobmsm_plat_info *tpmi_get_platform_data (struct auxiliary_device *auxdev) {struct intel_vsec_device *vsec_dev =auxdev_to_ivdev (auxdev);
drivers/powercap/intel_rapl_tpmi.c +5 -4
@@ -9,9 +9,10 @@#define pr_fmt (fmt) KBUILD_MODNAME ": " fmt#include <linux/auxiliary_bus.h> -#include <linux/io.h> -#include <linux/intel_tpmi.h> #include <linux/intel_rapl.h> +#include <linux/intel_tpmi.h> +#include <linux/intel_vsec.h> +#include <linux/io.h> #include <linux/module.h> #include <linux/slab.h>
@@ -48,7 +49,7 @@ enum tpmi_rapl_register {struct tpmi_rapl_package {struct rapl_if_priv priv; -struct intel_tpmi_plat_info *tpmi_info; +struct oobmsm_plat_info *tpmi_info;struct rapl_package *rp;void __iomem *base;struct list_head node;
@@ -253,7 +254,7 @@ static int intel_rapl_tpmi_probe(struct auxiliary_device *auxdev, const struct auxiliary_device_id *id) {struct tpmi_rapl_package *trp; -struct intel_tpmi_plat_info *info; +struct oobmsm_plat_info *info;struct resource *res;u32 offset;int ret;
include/linux/intel_tpmi.h +3 -24
@@ -8,6 +8,8 @@#include <linux/bitfield.h> +struct oobmsm_plat_info ; +#define TPMI_VERSION_INVALID 0xff#define TPMI_MINOR_VERSION (val) FIELD_GET(GENMASK(4, 0), val)#define TPMI_MAJOR_VERSION (val) FIELD_GET(GENMASK(7, 5), val)
@@ -26,30 +28,7 @@ enum intel_tpmi_id { TPMI_INFO_ID = 0x81, /* Special ID for PCI BDF and Package ID information */ }; -/** -* struct intel_tpmi_plat_info - Platform information for a TPMI device instance -* @cdie_mask: Mask of all compute dies in the partition -* @package_id: CPU Package id -* @partition: Package partition id when multiple VSEC PCI devices per package -* @segment: PCI segment ID -* @bus_number: PCI bus number -* @device_number: PCI device number -* @function_number: PCI function number -* -* Structure to store platform data for a TPMI device instance. This -* struct is used to return data via tpmi_get_platform_data(). -*/ -struct intel_tpmi_plat_info { -u16 cdie_mask; -u8 package_id; -u8 partition; -u8 segment; -u8 bus_number; -u8 device_number; -u8 function_number; -}; - -struct intel_tpmi_plat_info *tpmi_get_platform_data (struct auxiliary_device *auxdev); +struct oobmsm_plat_info *tpmi_get_platform_data (struct auxiliary_device *auxdev);struct resource *tpmi_get_resource_at_index (struct auxiliary_device *auxdev,int index);int tpmi_get_resource_count (struct auxiliary_device *auxdev); int tpmi_get_feature_status(struct auxiliary_device *auxdev, int feature_id, bool *read_blocked,
include/linux/intel_vsec.h +22 -0
@@ -144,6 +144,28 @@ struct intel_vsec_device {unsigned long cap_id; }; +/** +* struct oobmsm_plat_info - Platform information for a device instance +* @cdie_mask: Mask of all compute dies in the partition +* @package_id: CPU Package id +* @partition: Package partition id when multiple VSEC PCI devices per package +* @segment: PCI segment ID +* @bus_number: PCI bus number +* @device_number: PCI device number +* @function_number: PCI function number +* +* Structure to store platform data for a OOBMSM device instance. +*/ +struct oobmsm_plat_info { +u16 cdie_mask; +u8 package_id; +u8 partition; +u8 segment; +u8 bus_number; +u8 device_number; +u8 function_number; +}; +int intel_vsec_add_aux (struct pci_dev *pdev,struct device *parent,struct intel_vsec_device *intel_vsec_dev,const char *name);
Signature · 1 line
2.43.0
David E. Box
maintainerPATCH v3 11/15 platform/x86/intel/vsec: Set OOBMSM to CPU mapping
In reply to David E. BoxAdd functions, intel_vsec_set/get_mapping(), to set and retrieve the OOBMSM-to-CPU mapping data in the private data of the parent Intel VSEC driver. With this mapping information available, other Intel VSEC features on the same OOBMSM device can easily access and use the mapping data, allowing each of the OOBMSM features to map to the CPUs they provides data for.
---
Changes in v3:
- Drop unused intel_vsec_suppliers_read() declaration from intel_vsec.h.
Changes in v2:
- No changes
drivers/platform/x86/intel/vsec.c | 31 +++++++++++++++++++++++++++++++ include/linux/intel_vsec.h | 12 ++++++++++++ 2 files changed, 43 insertions(+)
drivers/platform/x86/intel/vsec.c +31 -0
@@ -44,6 +44,7 @@ enum vsec_device_state {struct vsec_priv {struct intel_vsec_platform_info *info;struct device *suppliers[VSEC_FEATURE_COUNT ]; +struct oobmsm_plat_info plat_info;enum vsec_device_state state[VSEC_FEATURE_COUNT ];unsigned long found_caps; };
@@ -665,6 +666,36 @@ static int intel_vsec_pci_probe(struct pci_dev *pdev, const struct pci_device_idreturn 0 ; } +int intel_vsec_set_mapping (struct oobmsm_plat_info *plat_info, +struct intel_vsec_device *vsec_dev) +{ +struct vsec_priv *priv; + + priv =pci_get_drvdata (vsec_dev->pcidev); +if (!priv) +return -EINVAL ; + + priv->plat_info = *plat_info; + +return 0 ; +} +EXPORT_SYMBOL_NS_GPL (intel_vsec_set_mapping,"INTEL_VSEC" ); + +struct oobmsm_plat_info *intel_vsec_get_mapping (struct pci_dev *pdev) +{ +struct vsec_priv *priv; + +if (!pci_match_id (intel_vsec_pci_ids, pdev)) +return ERR_PTR (-EINVAL ); + + priv =pci_get_drvdata (pdev); +if (!priv) +return ERR_PTR (-EINVAL ); + +return &priv->plat_info; +} +EXPORT_SYMBOL_NS_GPL (intel_vsec_get_mapping,"INTEL_VSEC" ); +/* DG1 info */ static struct intel_vsec_header dg1_header = { .length =0x10 ,
include/linux/intel_vsec.h +12 -0
@@ -183,11 +183,23 @@ static inline struct intel_vsec_device *auxdev_to_ivdev(struct auxiliary_device#if IS_ENABLED (CONFIG_INTEL_VSEC )int intel_vsec_register (struct pci_dev *pdev,struct intel_vsec_platform_info *info); +int intel_vsec_set_mapping (struct oobmsm_plat_info *plat_info, +struct intel_vsec_device *vsec_dev); +struct oobmsm_plat_info *intel_vsec_get_mapping (struct pci_dev *pdev);#else static inline int intel_vsec_register (struct pci_dev *pdev,struct intel_vsec_platform_info *info) {return -ENODEV ; } +static inline int intel_vsec_set_mapping (struct oobmsm_plat_info *plat_info, +struct intel_vsec_device *vsec_dev) +{ +return -ENODEV ; +} +static inline struct oobmsm_plat_info *intel_vsec_get_mapping (struct pci_dev *pdev) +{ +return ERR_PTR (-ENODEV ); +}#endif #endif
Signature · 1 line
2.43.0
David E. Box
maintainerPATCH v3 12/15 platform/x86/intel/tpmi: Get OOBMSM CPU mapping from TPMI
In reply to David E. BoxCopy TPMI’s OOBMSM platform info into a common area within VSEC private data via intel_vsec_set_mapping(). This enables other Intel VSEC features to access the CPU mapping without additional queries.
Additionally, designate the TPMI driver as a supplier for the Telemetry driver, ensuring it can obtain the necessary platform information for future feature extensions.
---
Changes in v3:
- No changes
Changes in v2:
- Add missing comma in mtl_info
drivers/platform/x86/intel/vsec.c | 2 +- drivers/platform/x86/intel/vsec_tpmi.c | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-)
drivers/platform/x86/intel/vsec.c +1 -1
@@ -725,7 +725,7 @@ static const struct intel_vsec_platform_info mtl_info = {static const struct vsec_feature_dependency oobmsm_deps[] = { { .feature =VSEC_CAP_TELEMETRY , - .supplier_bitmap =VSEC_CAP_DISCOVERY , + .supplier_bitmap =VSEC_CAP_DISCOVERY |VSEC_CAP_TPMI , }, };
drivers/platform/x86/intel/vsec_tpmi.c +4 -0
@@ -799,6 +799,10 @@ static int intel_vsec_tpmi_init(struct auxiliary_device *auxdev) ret =tpmi_process_info (tpmi_info, pfs);if (ret)return ret; + + ret =intel_vsec_set_mapping (&tpmi_info->plat_info, vsec_dev); +if (ret) +return ret; }if (pfs->pfs_header.tpmi_id ==TPMI_CONTROL_ID )
Signature · 1 line
2.43.0
David E. Box
maintainerPATCH v3 13/15 platform/x86/intel/pmt/discovery: Get telemetry attributes
In reply to David E. BoxAdd intel_pmt_get_features() in PMT Discovery to enable the PMT Telemetry driver to obtain attributes of the aggregated telemetry spaces it enumerates. The function gathers feature flags and associated data (like the number of RMIDs) from each PMT entry, laying the groundwork for a future kernel interface that will allow direct access to telemetry regions based on their capabilities.
---
Changes in v3:
- No changes
Changes in v2:
- No changes
drivers/platform/x86/intel/pmt/Kconfig | 1 + drivers/platform/x86/intel/pmt/class.h | 7 +++++ drivers/platform/x86/intel/pmt/discovery.c | 33 ++++++++++++++++++++++ drivers/platform/x86/intel/pmt/telemetry.c | 5 ++++ include/linux/intel_vsec.h | 16 +++++++++++ 5 files changed, 62 insertions(+)
drivers/platform/x86/intel/pmt/Kconfig +1 -0
@@ -18,6 +18,7 @@ config INTEL_PMT_CLASS config INTEL_PMT_TELEMETRY tristate "Intel Platform Monitoring Technology (PMT) Telemetry driver" depends on INTEL_VSEC + select INTEL_PMT_DISCOVERY select INTEL_PMT_CLASS help The Intel Platform Monitory Technology (PMT) Telemetry driver provides
drivers/platform/x86/intel/pmt/class.h +7 -0
@@ -48,6 +48,7 @@ struct intel_pmt_entry {struct pmt_callbacks *cb;unsigned long base_addr;size_t size; +u64 feature_flags;u32 guid;u32 num_rmids;/* Number of Resource Monitoring IDs */ int devid;
@@ -71,4 +72,10 @@ int intel_pmt_dev_create(struct intel_pmt_entry *entry, struct intel_vsec_device *dev, int idx);void intel_pmt_dev_destroy (struct intel_pmt_entry *entry,struct intel_pmt_namespace *ns); +#if IS_ENABLED (CONFIG_INTEL_PMT_DISCOVERY ) +void intel_pmt_get_features (struct intel_pmt_entry *entry); +#else +static inline void intel_pmt_get_features (struct intel_pmt_entry *entry) {} +#endif +#endif
drivers/platform/x86/intel/pmt/discovery.c +33 -0
@@ -583,6 +583,39 @@ static int pmt_features_probe(struct auxiliary_device *auxdev, const struct auxireturn ret; } +static void pmt_get_features (struct intel_pmt_entry *entry,struct feature *f) +{ +int num_guids = f->table.header.num_guids; +int i; + +for (i =0 ; i < num_guids; i++) { +if (f->table.guids[i] != entry->guid) +continue ; + + entry->feature_flags |=BIT (f->id); + +if (feature_layout[f->id] ==LAYOUT_RMID ) + entry->num_rmids = f->table.rmid.num_rmids; +else + entry->num_rmids =0 ;/* entry is kzalloc but set anyway */ + } +} + +void intel_pmt_get_features (struct intel_pmt_entry *entry) +{ +struct feature *feature; + +mutex_lock (&feature_list_lock); +list_for_each_entry (feature, &pmt_feature_list, list) { +if (feature->priv->parent != &entry->ep->pcidev->dev) +continue ; + +pmt_get_features (entry, feature); + } +mutex_unlock (&feature_list_lock); +} +EXPORT_SYMBOL_NS_GPL (intel_pmt_get_features,"INTEL_PMT" ); +static const struct auxiliary_device_id pmt_features_id_table[] = { { .name ="intel_vsec.discovery" }, {}
drivers/platform/x86/intel/pmt/telemetry.c +5 -0
@@ -9,11 +9,14 @@*/ #include <linux/auxiliary_bus.h> +#include <linux/intel_pmt_features.h> #include <linux/intel_vsec.h> #include <linux/kernel.h> +#include <linux/kref.h> #include <linux/module.h> #include <linux/pci.h> #include <linux/slab.h> +#include <linux/types.h> #include <linux/uaccess.h> #include <linux/overflow.h>
@@ -311,6 +314,8 @@ static int pmt_telem_probe(struct auxiliary_device *auxdev, const struct auxiliacontinue ; priv->num_entries++; + +intel_pmt_get_features (entry); }return 0 ;
include/linux/intel_vsec.h +16 -0
@@ -4,6 +4,7 @@#include <linux/auxiliary_bus.h> #include <linux/bits.h> +#include <linux/intel_pmt_features.h> /* * VSEC_CAP_UNUSED is reserved. It exists to prevent zero initialized
@@ -166,6 +167,21 @@ struct oobmsm_plat_info {u8 function_number; }; +struct telemetry_region { +struct oobmsm_plat_info plat_info; +void __iomem *addr; +size_t size; +u32 guid; +u32 num_rmids; +}; + +struct pmt_feature_group { +enum pmt_feature_id id; +int count; +struct kref kref; +struct telemetry_region regions[]; +}; +int intel_vsec_add_aux (struct pci_dev *pdev,struct device *parent,struct intel_vsec_device *intel_vsec_dev,const char *name);
Signature · 1 line
2.43.0
David E. Box
maintainerPATCH v3 14/15 platform/x86/intel/pmt/telemetry: Add API to retrieve telemetry regions by feature
In reply to David E. BoxIntroduce a new API, intel_pmt_get_regions_by_feature(), that gathers telemetry regions based on a provided capability flag. This API enables retrieval of regions with various capabilities (for example, RMID-based telemetry) and provides a unified interface for accessing them. Resource management is handled via reference counting using intel_pmt_put_feature_group().
---
Changes in v3:
- No changes
Changes in v2:
- In pmt_telem_get_endpoint_info() use __free() for feature_group
- Add missing header for ERR_PTR()
- Split static inline function into multiple lines
drivers/platform/x86/intel/pmt/telemetry.c | 89 +++++++++++++++++++++- include/linux/intel_vsec.h | 18 +++++ 2 files changed, 106 insertions(+), 1 deletion(-)
drivers/platform/x86/intel/pmt/telemetry.c +88 -1
@@ -9,16 +9,21 @@*/ #include <linux/auxiliary_bus.h> +#include <linux/bitops.h> +#include <linux/cleanup.h> +#include <linux/err.h> #include <linux/intel_pmt_features.h> #include <linux/intel_vsec.h> #include <linux/kernel.h> #include <linux/kref.h> #include <linux/module.h> +#include <linux/mutex.h> +#include <linux/overflow.h> #include <linux/pci.h> #include <linux/slab.h> #include <linux/types.h> #include <linux/uaccess.h> -#include <linux/overflow.h> +#include <linux/xarray.h> #include "class.h"
@@ -209,6 +214,87 @@ int pmt_telem_get_endpoint_info(int devid, struct telem_endpoint_info *info) }EXPORT_SYMBOL_NS_GPL (pmt_telem_get_endpoint_info,"INTEL_PMT_TELEMETRY" ); +static int pmt_copy_region (struct telemetry_region *region, +struct intel_pmt_entry *entry) +{ + +struct oobmsm_plat_info *plat_info; + + plat_info =intel_vsec_get_mapping (entry->ep->pcidev); +if (IS_ERR (plat_info)) +return PTR_ERR (plat_info); + + region->plat_info = *plat_info; + region->guid = entry->guid; + region->addr = entry->ep->base; + region->size = entry->size; + region->num_rmids = entry->num_rmids; + +return 0 ; +} + +static void pmt_feature_group_release (struct kref *kref) +{ +struct pmt_feature_group *feature_group; + + feature_group = container_of(kref, struct pmt_feature_group, kref); +kfree (feature_group); +} + +struct pmt_feature_group *intel_pmt_get_regions_by_feature (enum pmt_feature_id id) +{ + struct pmt_feature_group *feature_group __free(kfree) = NULL; +struct telemetry_region *region; +struct intel_pmt_entry *entry; +unsigned long idx; +int count =0 ; +size_t size; + +if (!pmt_feature_id_is_valid (id)) +return ERR_PTR (-EINVAL ); + +guard (mutex)(&ep_lock); +xa_for_each (&telem_array, idx, entry) { +if (entry->feature_flags &BIT (id)) + count++; + } + +if (!count) +return ERR_PTR (-ENOENT ); + + size =struct_size (feature_group, regions, count); + feature_group =kzalloc (size,GFP_KERNEL ); +if (!feature_group) +return ERR_PTR (-ENOMEM ); + + feature_group->count = count; + + region = feature_group->regions; +xa_for_each (&telem_array, idx, entry) { +int ret; + +if (!(entry->feature_flags &BIT (id))) +continue ; + + ret =pmt_copy_region (region, entry); +if (ret) +return ERR_PTR (ret); + + region++; + } + +kref_init (&feature_group->kref); + +return no_free_ptr (feature_group); +} +EXPORT_SYMBOL (intel_pmt_get_regions_by_feature); + +void intel_pmt_put_feature_group (struct pmt_feature_group *feature_group) +{ +kref_put (&feature_group->kref, pmt_feature_group_release); +} +EXPORT_SYMBOL (intel_pmt_put_feature_group); +int pmt_telem_read (struct telem_endpoint *ep,u32 id,u64 *data,u32 count) {u32 offset, size;
@@ -353,3 +439,4 @@ MODULE_AUTHOR("David E. Box <[email protected]>");MODULE_DESCRIPTION ("Intel PMT Telemetry driver" );MODULE_LICENSE ("GPL v2" );MODULE_IMPORT_NS ("INTEL_PMT" ); +MODULE_IMPORT_NS ("INTEL_VSEC" );
include/linux/intel_vsec.h +18 -0
@@ -4,6 +4,7 @@#include <linux/auxiliary_bus.h> #include <linux/bits.h> +#include <linux/err.h> #include <linux/intel_pmt_features.h> /*
@@ -218,4 +219,21 @@ static inline struct oobmsm_plat_info *intel_vsec_get_mapping(struct pci_dev *pdreturn ERR_PTR (-ENODEV ); }#endif + +#if IS_ENABLED (CONFIG_INTEL_PMT_TELEMETRY ) +struct pmt_feature_group * +intel_pmt_get_regions_by_feature (enum pmt_feature_id id); + +void intel_pmt_put_feature_group (struct pmt_feature_group *feature_group); +#else +static inline struct pmt_feature_group * +intel_pmt_get_regions_by_feature (enum pmt_feature_id id) +{ +return ERR_PTR (-ENODEV ); +} + +static inline void +intel_pmt_put_feature_group (struct pmt_feature_group *feature_group) {} +#endif +#endif
Signature · 1 line
2.43.0
David E. Box
maintainerPATCH v3 15/15 platform/x86/intel/pmt: KUNIT test for PMT Enhanced Discovery API
In reply to David E. BoxAdds a KUNIT test for the intel_pmt_get_regions_by_feature() API.
---
Changes in v3:
- No changes
Changes in v2:
- No changes
drivers/platform/x86/intel/pmt/Kconfig | 14 +++ drivers/platform/x86/intel/pmt/Makefile | 2 + .../platform/x86/intel/pmt/discovery-kunit.c | 116 ++++++++++++++++++ 3 files changed, 132 insertions(+) create mode 100644 drivers/platform/x86/intel/pmt/discovery-kunit.c
drivers/platform/x86/intel/pmt/Kconfig +14 -0
@@ -51,3 +51,17 @@ config INTEL_PMT_DISCOVERY To compile this driver as a module, choose M here: the module will be called pmt_discovery. + +config INTEL_PMT_KUNIT_TEST + tristate "KUnit tests for Intel PMT driver" + depends on INTEL_PMT_DISCOVERY + depends on KUNIT + help + Enable this option to compile and run a suite of KUnit tests for the Intel + Platform Monitoring Technology (PMT) driver. These tests are designed to + validate the driver's functionality, error handling, and overall stability, + helping developers catch regressions and ensure code quality during changes. + + This option is intended for development and testing environments. It is + recommended to disable it in production builds. To compile this driver as a + module, choose M here: the module will be called pmt-discovery-kunit.
drivers/platform/x86/intel/pmt/Makefile +2 -0
@@ -12,3 +12,5 @@ obj-$(CONFIG_INTEL_PMT_CRASHLOG) += pmt_crashlog.o pmt_crashlog-y := crashlog.o obj-$(CONFIG_INTEL_PMT_DISCOVERY) += pmt_discovery.o pmt_discovery-y := discovery.o features.o +obj-$(CONFIG_INTEL_PMT_KUNIT_TEST) += pmt-discovery-kunit.o +pmt-discovery-kunit-y := discovery-kunit.o
drivers/platform/x86/intel/pmt/discovery-kunit.c new file +116 -0
116 lines not on this page · raw message
Signature · 1 line
2.43.0
kernel test robot
build botRe: [PATCH V3 15/15] platform/x86/intel/pmt: KUNIT test for PMT Enhanced Discovery API
kernel test robot noticed the following build warnings:
Hi David,
kernel test robot noticed the following build warnings:
[auto build test WARNING on d0b3b7b22dfa1f4b515fd3a295b3fd958f9e81af]
url: https://github.com/intel-lab-lkp/linux/commits/David-E-Box/MAINTAINERS-Add-link-to-documentation-of-Intel-PMT-ABI/20250703-103720 base: d0b3b7b22dfa1f4b515fd3a295b3fd958f9e81af patch link: https://lore.kernel.org/r/20250703022832.1302928-16-david.e.box%40linux.intel.com patch subject: [PATCH V3 15/15] platform/x86/intel/pmt: KUNIT test for PMT Enhanced Discovery API config: i386-randconfig-004-20250704 (https://download.01.org/0day-ci/archive/20250704/[email protected]/config) compiler: clang version 20.1.7 (https://github.com/llvm/llvm-project 6146a88f60492b520a36f8f8f3231e15f3cc6082) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250704/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All warnings (new ones prefixed by >>):
>> drivers/platform/x86/intel/pmt/discovery-kunit.c:35:73: warning: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Wformat]
35 | kunit_info(test, "\t\taddr=%p, size=%lu, num_rmids=%u", region->addr, region->size,
| ~~~ ^~~~~~~~~~~~
| %zu
include/kunit/test.h:616:39: note: expanded from macro 'kunit_info'
616 | kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
| ~~~ ^~~~~~~~~~~
include/kunit/test.h:604:21: note: expanded from macro 'kunit_printk'
603 | kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
| ~~~
604 | (test)->name, ##__VA_ARGS__)
| ^~~~~~~~~~~
include/kunit/test.h:597:21: note: expanded from macro 'kunit_log'
597 | printk(lvl fmt, ##__VA_ARGS__); \
| ~~~ ^~~~~~~~~~~
include/linux/printk.h:507:60: note: expanded from macro 'printk'
507 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
| ~~~ ^~~~~~~~~~~
include/linux/printk.h:479:19: note: expanded from macro 'printk_index_wrap'
479 | _p_func(_fmt, ##__VA_ARGS__); \
| ~~~~ ^~~~~~~~~~~
>> drivers/platform/x86/intel/pmt/discovery-kunit.c:35:73: warning: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Wformat]
35 | kunit_info(test, "\t\taddr=%p, size=%lu, num_rmids=%u", region->addr, region->size,
| ~~~ ^~~~~~~~~~~~
| %zu
include/kunit/test.h:616:39: note: expanded from macro 'kunit_info'
616 | kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
| ~~~ ^~~~~~~~~~~
include/kunit/test.h:604:21: note: expanded from macro 'kunit_printk'
603 | kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
| ~~~
604 | (test)->name, ##__VA_ARGS__)
| ^~~~~~~~~~~
include/kunit/test.h:599:8: note: expanded from macro 'kunit_log'
598 | kunit_log_append((test_or_suite)->log, fmt, \
| ~~~
599 | ##__VA_ARGS__); \
| ^~~~~~~~~~~2 warnings generated.
vim +35 drivers/platform/x86/intel/pmt/discovery-kunit.c
17
18 static void
19 validate_pmt_regions(struct kunit *test, struct pmt_feature_group *feature_group, int feature_id)
20 {
21 int i;
22
23 kunit_info(test, "Feature ID %d [%s] has %d regions.\n", feature_id,
24 pmt_feature_names[feature_id], feature_group->count);
25
26 for (i = 0; i < feature_group->count; i++) {
27 struct telemetry_region *region = &feature_group->regions[i];
28
29 kunit_info(test, " - Region %d: cdie_mask=%u, package_id=%u, partition=%u, segment=%u,",
30 i, region->plat_info.cdie_mask, region->plat_info.package_id,
31 region->plat_info.partition, region->plat_info.segment);
32 kunit_info(test, "\t\tbus=%u, device=%u, function=%u, guid=0x%x,",
33 region->plat_info.bus_number, region->plat_info.device_number,
34 region->plat_info.function_number, region->guid);
> 35 kunit_info(test, "\t\taddr=%p, size=%lu, num_rmids=%u", region->addr, region->size,
36 region->num_rmids);
37
38
39 KUNIT_ASSERT_GE(test, region->plat_info.cdie_mask, 0);
40 KUNIT_ASSERT_GE(test, region->plat_info.package_id, 0);
41 KUNIT_ASSERT_GE(test, region->plat_info.partition, 0);
42 KUNIT_ASSERT_GE(test, region->plat_info.segment, 0);
43 KUNIT_ASSERT_GE(test, region->plat_info.bus_number, 0);
44 KUNIT_ASSERT_GE(test, region->plat_info.device_number, 0);
45 KUNIT_ASSERT_GE(test, region->plat_info.function_number, 0);
46
47 KUNIT_ASSERT_NE(test, region->guid, 0);
48
49 KUNIT_ASSERT_NOT_ERR_OR_NULL(test, (__force const void *)region->addr);
50 }
51 }
52 Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
Ilpo Järvinen
maintainerQuoted 12 lines · David E. Box
This patch series introduces a new discovery driver for Intel Platform Monitoring Technology (PMT) and a set of supporting changes to improve telemetry integration across Intel VSEC features.
The primary goal of this series is to add the PMT Discovery driver, which enumerates and exposes telemetry attributes by parsing hardware-provided discovery tables from OOBMSM devices. In particular, the discovery driver gathers detailed capability information (such as telemetry region attributes) that will later enable direct access to telemetry regions via a new API (
intel_pmt_get_regions_by_feature()). This API is crucial for retrieving data like per-RMID counters.
Quoted 1 line
[...]
Thank you for your contribution, it has been applied to my local review-ilpo-next branch. Note it will show up in the public platform-drivers-x86/review-ilpo-next branch only once I've pushed my local branch there, which might take a while.
The list of commits applied:
[01/15] MAINTAINERS: Add link to documentation of Intel PMT ABI
commit: fb1311b3f171bbb3c07cc7764ec981605564c83a
[02/15] platform/x86/intel/vsec: Add private data for per-device data
commit: dc957ab6aa05c118c3da0542428a4d6602aa2d2d
[03/15] platform/x86/intel/vsec: Create wrapper to walk PCI config space
commit: b0631f8a5740c55b52d02174cc4c9c84cc7a16a1
[04/15] platform/x86/intel/vsec: Add device links to enforce dependencies
commit: 8a67d4b49bbdebcd255abde9e652092c3de3b657
[05/15] platform/x86/intel/vsec: Skip absent features during initialization
commit: 1f3855ea7d6b03f68c2eec7a0bcd537cedcc6680
[06/15] platform/x86/intel/vsec: Skip driverless features
commit: e4436e98672c7993cdfd7743efd0fcaa8df7cc17
[07/15] platform/x86/intel/vsec: Add new Discovery feature
commit: 10f32796e86c04f73b7f8580cc9483765ed19f49
[08/15] platform/x86/intel/pmt: Add PMT Discovery driver
commit: d9a0788093565c300f7c8dd034dbfa6ac4da9aa6
[09/15] docs: Add ABI documentation for intel_pmt feature directories
commit: 2e7ba52110ef15d29846b40eb28b400f1fb1834a
[10/15] platform/x86/intel/tpmi: Relocate platform info to intel_vsec.h
commit: 934954df0f44de5e10afc1af84c06f78149f15fe
[11/15] platform/x86/intel/vsec: Set OOBMSM to CPU mapping
commit: a885a2780937afac4f31f00d11663f50d05dfb35
[12/15] platform/x86/intel/tpmi: Get OOBMSM CPU mapping from TPMI
commit: c9699057521834862616ce159a47bd33920f0d9f
[13/15] platform/x86/intel/pmt/discovery: Get telemetry attributes
commit: 86fc85c75bcd9b0f28afadd60c9f890669b42ba4
[14/15] platform/x86/intel/pmt/telemetry: Add API to retrieve telemetry regions by feature
commit: 42dabe5442887946b16e64c6ebe91d2671a96fbb
[15/15] platform/x86/intel/pmt: KUNIT test for PMT Enhanced Discovery API
commit: b9707d46a95962bb4e28ae1929015e419ad6aff7--
i.