package/cpulimit: Backport fix for function signature
PATCH 1/1 package/cpulimit: Backport fix for function signature
Backport the upstream pull request patch fixing the incorrect function signature passed to pthread_create()
Signed-off-by Florian Fainelli <[email protected]>
--- ...0005-Correct-loop-function-signature.patch | 49 +++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 package/cpulimit/0005-Correct-loop-function-signature.patch
package/cpulimit/0005-Correct-loop-function-signature.patch new file +49 -0
@@ -0,0 +1,49 @@ +From 74e95c96e8d82e4e374f86142972fcf4305fe1f2 Mon Sep 17 00:00:00 2001 +From: Florian Fainelli <[email protected]> +Date: Wed, 2 Jul 2025 20:47:58 -0700 +Subject: [PATCH] Correct loop function signature + +loop is passed to pthread_create() which requires the following +prototype to be used: void *(*start_routine) (void *) + +Correct the signature to avoid such warnings: + +In file included from busy.c:3: +/home/buildroot/instance-0/output-1/host/mips-buildroot-linux-uclibc/sysroot/usr/include/pthread.h:164:36: note: expected 'void * (*)(void *)' but argument is of type 'void * (*)(void)' + 164 | void *(*__start_routine) (void *), + | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ +busy.c:6:7: note: 'loop' declared here + 6 | void *loop() + | ^~~~ + +Signed-off-by: Florian Fainelli <[email protected]> +[Upstream: https://github.com/opsengine/cpulimit/pull/127] +--- + tests/busy.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/tests/busy.c b/tests/busy.c +index b3afb7cd853b..93f0bcce67a8 100644 +--- a/tests/busy.c ++++ b/tests/busy.c +@@ -3,7 +3,7 @@ + #include <pthread.h> + #include <unistd.h> + +-void *loop() ++void *loop(void *) + { + while(1); + } +@@ -23,7 +23,7 @@ int main(int argc, char **argv) { + exit(1); + } + } +- loop(); ++ loop(NULL); + return 0; + } + +-- +2.43.0 +
Signature · 6 lines
2.43.0 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 7 lines · Florian Fainelli
Backport the upstream pull request patch fixing the incorrect function signature passed to
pthread_create()Signed-off-by Florian Fainelli <[email protected]>
Applied to master, thanks.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Thomas Perale via buildroot
AppliedIn reply of:
Quoted 7 lines
Backport the upstream pull request patch fixing the incorrect function signature passed to
pthread_create()Signed-off-by Florian Fainelli <[email protected]>
Applied to 2025.02.x & 2025.05.x. Thanks
Quoted 67 lines
--- ...0005-Correct-loop-function-signature.patch | 49 +++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 package/cpulimit/0005-Correct-loop-function-signature.patchpackage/cpulimit/0005-Correct-loop-function-signature.patch new file +49
-0@@ -0,0 +1,49 @@ +From 74e95c96e8d82e4e374f86142972fcf4305fe1f2 Mon Sep 17 00:00:00 2001 +From: Florian Fainelli <[email protected]> +Date: Wed, 2 Jul 2025 20:47:58 -0700 +Subject: [PATCH] Correct loop function signature + +loop is passed to pthread_create() which requires the following +prototype to be used: void *(*start_routine) (void *) + +Correct the signature to avoid such warnings: + +In file included from busy.c:3: +/home/buildroot/instance-0/output-1/host/mips-buildroot-linux-uclibc/sysroot/usr/include/pthread.h:164:36: note: expected 'void * (*)(void *)' but argument is of type 'void * (*)(void)' + 164 | void *(*__start_routine) (void *), + | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ +busy.c:6:7: note: 'loop' declared here + 6 | void *loop() + | ^~~~ + +Signed-off-by: Florian Fainelli <[email protected]> +[Upstream: https://github.com/opsengine/cpulimit/pull/127] +--- + tests/busy.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/tests/busy.c b/tests/busy.c +index b3afb7cd853b..93f0bcce67a8 100644 +--- a/tests/busy.c ++++ b/tests/busy.c +@@ -3,7 +3,7 @@ + #include <pthread.h> + #include <unistd.h> + +-void *loop() ++void *loop(void *) + { + while(1); + } +@@ -23,7 +23,7 @@ int main(int argc, char **argv) { + exit(1); + } + } +- loop(); ++ loop(NULL); + return 0; + } + +-- +2.43.0 +Signature · 6 lines
2.43.0 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot