Skip to contentSkip to conversation

ALSA: hda: Remove old commented out sanity check

PATCH In review Thorsten Blum 2 participants 2 messages Jul 3, 2025 – Jul 4, 2025 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: hda: Remove old commented out sanity check

The sanity check has been commented out for more than 12 years since commit d5657ec9f4ad ("ALSA: hda - Disable the sanity check in snd_hda_add_pincfg()") - remove it.

---
 sound/pci/hda/hda_codec.c | 9 ---------
 1 file changed, 9 deletions(-)
sound/pci/hda/hda_codec.c +0 -9
index 5508381a1833..cb72e9655c8a 100644
@@ -479,15 +479,6 @@ int snd_hda_add_pincfg(struct hda_codec *codec, struct snd_array *list,
 {
 	struct hda_pincfg *pin;
 
-	/* the check below may be invalid when pins are added by a fixup
-	 * dynamically (e.g. via snd_hda_codec_update_widgets()), so disabled
-	 * for now
-	 */
-	/*
-	if (get_wcaps_type(get_wcaps(codec, nid)) != AC_WID_PIN)
-		return -EINVAL;
-	*/
-
 	pin = look_up_pincfg(codec, list, nid);
 	if (!pin) {
 		pin = snd_array_new(list);
Signature · 1 line
2.50.0
#1 lore raw
Quoted 6 lines · Thorsten Blum

The sanity check has been commented out for more than 12 years since commit d5657ec9f4ad ("ALSA: hda - Disable the sanity check in snd_hda_add_pincfg()") - remove it.

Applied now. Thanks.

Takashi