Skip to contentSkip to conversation

rust: miscdevice: remove unnecessary import

PATCH In review Tamir Duberstein 3 participants 4 messages Jul 4, 2025 – Jul 7, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rust: miscdevice: remove unnecessary import

kernel::str::CStr is included in the prelude.

---
 rust/kernel/miscdevice.rs | 1 -
 1 file changed, 1 deletion(-)
rust/kernel/miscdevice.rs +0 -1
index 288f40e79906..8309d656088a 100644
@@ -17,7 +17,6 @@
     mm::virt::VmaNew,
     prelude::*,
     seq_file::SeqFile,
-    str::CStr,
     types::{ForeignOwnable, Opaque},
 };
 use core::{marker::PhantomData, mem::MaybeUninit, pin::Pin};

---
base-commit: 769e324b66b0d92d04f315d0c45a0f72737c7494
change-id: 20250704-cstr-include-miscdevice-4c5cb26a0ece

Best regards,

Signature · 1 line
Tamir Duberstein <[email protected]>
#1 lore raw
Quoted 25 lines · Tamir Duberstein

kernel::str::CStr is included in the prelude.

---
 rust/kernel/miscdevice.rs | 1 -
 1 file changed, 1 deletion(-)
rust/kernel/miscdevice.rs +0 -2
index 288f40e79906..8309d656088a 100644
@@ -17,7 +17,6 @@
     mm::virt::VmaNew,
     prelude::*,
     seq_file::SeqFile,
-    str::CStr,
     types::{ForeignOwnable, Opaque},
 };
 use core::{marker::PhantomData, mem::MaybeUninit, pin::Pin};
 
---

base-commit: 769e324b66b0d92d04f315d0c45a0f72737c7494
change-id: 20250704-cstr-include-miscdevice-4c5cb26a0ece

Quoted 4 lines

Best regards,
--
Tamir Duberstein <[email protected]>

Oops, should have sent this to Greg. Sent
https://lore.kernel.org/all/[email protected]/
to make this easier in the future.

#2 lore raw
Quoted 26 lines · Tamir Duberstein
Quoted 25 lines · Tamir Duberstein

kernel::str::CStr is included in the prelude.

---
 rust/kernel/miscdevice.rs | 1 -
 1 file changed, 1 deletion(-)
rust/kernel/miscdevice.rs +0 -2
index 288f40e79906..8309d656088a 100644
@@ -17,7 +17,6 @@
     mm::virt::VmaNew,
     prelude::*,
     seq_file::SeqFile,
-    str::CStr,
     types::{ForeignOwnable, Opaque},
 };
 use core::{marker::PhantomData, mem::MaybeUninit, pin::Pin};
 
---

base-commit: 769e324b66b0d92d04f315d0c45a0f72737c7494
change-id: 20250704-cstr-include-miscdevice-4c5cb26a0ece

Quoted 8 lines
Quoted 4 lines

Best regards,
--
Tamir Duberstein <[email protected]>

Oops, should have sent this to Greg. Sent
https://lore.kernel.org/all/[email protected]/
to make this easier in the future.

Thanks, I just noticed this as well. I'll queue up this, and the MAINTAINERS update when I get a chance tomorrow or so.

greg k-h