drm/sun4i: Cleanup v3s mixer config fields ordering and indentation
Subsystems (5)
PATCH 1/1 drm/sun4i: Cleanup v3s mixer config fields ordering and indentation
The v3s mixer config definition is a bit messy. Tidy it up. No function change is intended.
--- drivers/gpu/drm/sun4i/sun8i_mixer.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/gpu/drm/sun4i/sun8i_mixer.c +6 -6
@@ -670,12 +670,12 @@ static const struct sun8i_mixer_cfg sun8i_r40_mixer1_cfg = { };static const struct sun8i_mixer_cfg sun8i_v3s_mixer_cfg = { - .vi_num =2 , - .ui_num =1 , - .scaler_mask =0x3 , - .scanline_yuv =2048 , - .ccsc =CCSC_MIXER0_LAYOUT , - .mod_rate =150000000 , + .ccsc =CCSC_MIXER0_LAYOUT , + .mod_rate =150000000 , + .scaler_mask =0x3 , + .scanline_yuv =2048 , + .ui_num =1 , + .vi_num =2 , };static const struct sun8i_mixer_cfg sun20i_d1_mixer0_cfg = {
Signature · 1 line
2.49.0
Hi,
Quoted 2 lines · Paul Kocialkowski
The v3s mixer config definition is a bit messy. Tidy it up. No function change is intended.
This patch didn't make it in the previous cycle.
Would it be possible to pick it up this time?
Thanks!
Paul
Quoted 31 lines
Signed-off-by Paul Kocialkowski <[email protected]>--- drivers/gpu/drm/sun4i/sun8i_mixer.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)drivers/gpu/drm/sun4i/sun8i_mixer.c +6
-6@@ -670,12 +670,12 @@ static const struct sun8i_mixer_cfg sun8i_r40_mixer1_cfg = { };static const struct sun8i_mixer_cfg sun8i_v3s_mixer_cfg = { - .vi_num =2 , - .ui_num =1 , - .scaler_mask =0x3 , - .scanline_yuv =2048 , - .ccsc =CCSC_MIXER0_LAYOUT , - .mod_rate =150000000 , + .ccsc =CCSC_MIXER0_LAYOUT , + .mod_rate =150000000 , + .scaler_mask =0x3 , + .scanline_yuv =2048 , + .ui_num =1 , + .vi_num =2 , };static const struct sun8i_mixer_cfg sun20i_d1_mixer0_cfg = {Signature · 1 line
2.49.0
Signature · 6 lines
Paul Kocialkowski, Independent contractor - sys-base - https://www.sys-base.io/ Free software developer - https://www.paulk.fr/ Expert in multimedia, graphics and embedded hardware support with Linux.
Quoted 9 lines · Paul Kocialkowski
Hi,
Quoted 2 lines · Paul Kocialkowski
The v3s mixer config definition is a bit messy. Tidy it up. No function change is intended.
This patch didn't make it in the previous cycle.
Would it be possible to pick it up this time?
I guess this is going to conflict with Jernej's refactoring / cleanup series.
And, I think v3s is not the only one that has fields in a different order. Might we clean this up after all the refactoring?
ChenYu
Hi Chen-Yu,
Quoted 8 lines · Chen-Yu Tsai
Quoted 7 lines · Paul Kocialkowski
Hi,
Quoted 2 lines · Paul Kocialkowski
The v3s mixer config definition is a bit messy. Tidy it up. No function change is intended.
Quoted 8 lines
Quoted 2 lines
This patch didn't make it in the previous cycle.
Would it be possible to pick it up this time?I guess this is going to conflict with Jernej's refactoring / cleanup series.
And, I think v3s is not the only one that has fields in a different order. Might we clean this up after all the refactoring?
Sure, it's better if this doesn't get in the way of the rework. I'll send something after the rework is merged if the issue still exists.
Thanks,
Paul
Signature · 6 lines
Paul Kocialkowski, Independent contractor - sys-base - https://www.sys-base.io/ Free software developer - https://www.paulk.fr/ Expert in multimedia, graphics and embedded hardware support with Linux.