Skip to contentSkip to conversation

ACPI: FAN: Update fps count debug print

PATCH Applied Sumeet Pawnikar 2 participants 2 messages Jul 5, 2025 – Jul 7, 2025 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ACPI: FAN: Update fps count debug print

Update invalid control value returned debug print with appropriate message as no matching fps control value for checking fan fps count condition.

---
v1->v2: Addressed review comment received from Rafael Wysocki
to update the debug message appropriately.

---
 drivers/acpi/fan_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/fan_core.c +1 -1
index 8ad12ad3aaaf..095502086b41 100644
@@ -102,7 +102,7 @@ static int fan_get_state_acpi4(struct acpi_device *device, unsigned long *state)
 			break;
 	}
 	if (i == fan->fps_count) {
-		dev_dbg(&device->dev, "Invalid control value returned\n");
+		dev_dbg(&device->dev, "No matching fps control value\n");
 		return -EINVAL;
 	}
 
Signature · 1 line
2.43.0
maintainer Applied
#1 lore raw
Quoted 18 lines · Sumeet Pawnikar

Update invalid control value returned debug print with appropriate message as no matching fps control value for checking fan fps count condition.

---
v1->v2: Addressed review comment received from Rafael Wysocki
to update the debug message appropriately.

---
 drivers/acpi/fan_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/fan_core.c +0 -0
index 8ad12ad3aaaf..095502086b41 100644

drivers/acpi/fan_core.c static int fan_get_state_acpi4(struct acpi_device *device, unsigned long *state)

Quoted 9 lines
drivers/acpi/fan_core.c +1 -2
@@ -102,7 +102,7 @@ static int fan_get_state_acpi4(struct acpi_device *device, unsigned long *state)
                        break;
        }
        if (i == fan->fps_count) {
-               dev_dbg(&device->dev, "Invalid control value returned\n");
+               dev_dbg(&device->dev, "No matching fps control value\n");
                return -EINVAL;
        }
 
--

Applied as 6.17 material with edited subject, thanks!