Add Dell Inspiron 7441 / Latitude 7455 (X1E-80-100)
Subsystems (7)
v3 cover Add Dell Inspiron 7441 / Latitude 7455 (X1E-80-100)
The unified series for Dell Thena laptops.
Changes since v2[1]:
- Fixed From/Co-developed-by on the big patch
- Fixed one remaining "inspirIon"
- Fixed codec/cpu alphabetical order in audio nodes (copy-paste..)
- Made the common dtsi an 'x1-' one in preparation for x1p models
[1]: https://lore.kernel.org/all/[email protected]/
Bryan O'Donoghue (2):
dt-bindings: arm: qcom: Add Dell Inspiron 14 Plus 7441
arm64: dts: qcom: Add support for Dell Inspiron 7441 / Latitude 7455
Val Packett (3):
dt-bindings: arm: qcom: Add Dell Latitude 7455
firmware: qcom: scm: Allow QSEECOM on Dell Inspiron 7441 / Latitude
7455
drm/panel-edp: Add BOE NE14QDM panel for Dell Latitude 7455
.../devicetree/bindings/arm/qcom.yaml | 2 + arch/arm64/boot/dts/qcom/Makefile | 4 + arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi | 1657 +++++++++++++++++ .../x1e80100-dell-inspiron-14-plus-7441.dts | 52 + .../dts/qcom/x1e80100-dell-latitude-7455.dts | 53 + drivers/firmware/qcom/qcom_scm.c | 2 + drivers/gpu/drm/panel/panel-edp.c | 1 + 7 files changed, 1771 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi create mode 100644 arch/arm64/boot/dts/qcom/x1e80100-dell-inspiron-14-plus-7441.dts create mode 100644 arch/arm64/boot/dts/qcom/x1e80100-dell-latitude-7455.dts
Signature · 1 line
2.49.0
PATCH v3 1/5 dt-bindings: arm: qcom: Add Dell Inspiron 14 Plus 7441
From: Bryan O'Donoghue <[email protected]>
Document the X1E80100-based Dell Inspiron 14 Plus 7441 laptop, codename:
Thena.
--- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/qcom.yaml +1 -0
@@ -1146,6 +1146,7 @@ properties: - enum: - asus,vivobook-s15 - asus,zenbook-a14-ux3407ra + - dell,inspiron-14-plus-7441 - dell,xps13-9345 - hp,elitebook-ultra-g1q - hp,omnibook-x14
Signature · 1 line
2.49.0
PATCH v3 2/5 dt-bindings: arm: qcom: Add Dell Latitude 7455
In reply to Val PackettDocument the X1E80100-based Dell Latitude 7455 laptop, codename Thena (the codename is shared with the near-identical Inspiron 14 Plus 7441).
--- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/qcom.yaml +1 -0
@@ -1147,6 +1147,7 @@ properties: - asus,vivobook-s15 - asus,zenbook-a14-ux3407ra - dell,inspiron-14-plus-7441 + - dell,latitude-7455 - dell,xps13-9345 - hp,elitebook-ultra-g1q - hp,omnibook-x14
Signature · 1 line
2.49.0
PATCH v3 3/5 arm64: dts: qcom: Add support for Dell Inspiron 7441 / Latitude 7455
In reply to Val PackettFrom: Bryan O'Donoghue <[email protected]>
Add device trees for both SKUs of the X1E80100 Thena laptop:
- Dell Latitude 7455
- Dell Inspiron 14 Plus 7441
Works:
- Wi-Fi (WCN7850 hw2.0)
- Bluetooth
- USB Type-C x2 (with DP alt mode)
- USB Type-A
- USB Fingerprint reader
- eDP Display (with brightness)
- NVMe
- SDHC (microSD slot)
- Keyboard
- Touchpad
- Touchscreen
- Audio (4 Speakers, 2 DMICs, Combo Jack)
- Battery
Not included:
- Camera
--- arch/arm64/boot/dts/qcom/Makefile | 4 + arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi | 1657 +++++++++++++++++ .../x1e80100-dell-inspiron-14-plus-7441.dts | 52 + .../dts/qcom/x1e80100-dell-latitude-7455.dts | 53 + 4 files changed, 1766 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi create mode 100644 arch/arm64/boot/dts/qcom/x1e80100-dell-inspiron-14-plus-7441.dts create mode 100644 arch/arm64/boot/dts/qcom/x1e80100-dell-latitude-7455.dts
arch/arm64/boot/dts/qcom/Makefile +4 -0
@@ -315,6 +315,10 @@ x1e80100-asus-zenbook-a14-el2-dtbs := x1e80100-asus-zenbook-a14.dtb x1-el2.dtbo dtb-$(CONFIG_ARCH_QCOM) += x1e80100-asus-zenbook-a14.dtb x1e80100-asus-zenbook-a14-el2.dtb x1e80100-crd-el2-dtbs := x1e80100-crd.dtb x1-el2.dtbo dtb-$(CONFIG_ARCH_QCOM) += x1e80100-crd.dtb x1e80100-crd-el2.dtb +x1e80100-dell-inspiron-14-plus-7441-el2-dtbs := x1e80100-dell-inspiron-14-plus-7441.dtb x1-el2.dtbo +dtb-$(CONFIG_ARCH_QCOM) += x1e80100-dell-inspiron-14-plus-7441.dtb x1e80100-dell-inspiron-14-plus-7441-el2.dtb +x1e80100-dell-latitude-7455-el2-dtbs := x1e80100-dell-latitude-7455.dtb x1-el2.dtbo +dtb-$(CONFIG_ARCH_QCOM) += x1e80100-dell-latitude-7455.dtb x1e80100-dell-latitude-7455-el2.dtb x1e80100-dell-xps13-9345-el2-dtbs := x1e80100-dell-xps13-9345.dtb x1-el2.dtbo dtb-$(CONFIG_ARCH_QCOM) += x1e80100-dell-xps13-9345.dtb x1e80100-dell-xps13-9345-el2.dtb x1e80100-hp-elitebook-ultra-g1q-el2-dtbs := x1e80100-hp-elitebook-ultra-g1q.dtb x1-el2.dtbo
arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi new file +1657 -0
1,657 lines not on this page · raw message
arch/arm64/boot/dts/qcom/x1e80100-dell-inspiron-14-plus-7441.dts new file +52 -0
52 lines not on this page · raw message
arch/arm64/boot/dts/qcom/x1e80100-dell-latitude-7455.dts new file +53 -0
53 lines not on this page · raw message
Signature · 1 line
2.49.0
Re: [PATCH v3 3/5] arm64: dts: qcom: Add support for Dell Inspiron 7441 / Latitude 7455
Quoted 28 lines · Val Packett
From: Bryan O'Donoghue <[email protected]>
Add device trees for both SKUs of the X1E80100 Thena laptop:
- Dell Latitude 7455
- Dell Inspiron 14 Plus 7441Works:
- Wi-Fi (WCN7850 hw2.0)
- Bluetooth
- USB Type-C x2 (with DP alt mode)
- USB Type-A
- USB Fingerprint reader
- eDP Display (with brightness)
- NVMe
- SDHC (microSD slot)
- Keyboard
- Touchpad
- Touchscreen
- Audio (4 Speakers, 2 DMICs, Combo Jack)
- BatteryNot included:
- CameraSigned-off-by Bryan O'Donoghue <[email protected]>Co-developed-by Val Packett <[email protected]>Signed-off-by Val Packett <[email protected]>---
[...]
arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi line 28
Quoted 5 lines
arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi new file +5
-0+ wcd938x: audio-codec { + compatible = "qcom,wcd9385-codec"; + + pinctrl-names = "default"; + pinctrl-0 = <&wcd_default>;
Please do:
property-n
property-names
consistently
[...]
arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi line 1641
Quoted 4 lines
+&usb_mp_dwc3 {
arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi new file +3
-0+ phys = <&usb_mp_hsphy0>, <&usb_mp_qmpphy0>; + phy-names = "usb2-0", "usb3-0"; +};
Let's not override this, so that the driver can still put the remaining ones to sleep cleanly
Konrad
Re: [PATCH v3 3/5] arm64: dts: qcom: Add support for Dell Inspiron 7441 / Latitude 7455
Quoted 10 lines · Konrad Dybcio
arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi line 28
Quoted 5 lines · Val Packett
arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi new file +5
-0+ wcd938x: audio-codec { + compatible = "qcom,wcd9385-codec"; + + pinctrl-names = "default"; + pinctrl-0 = <&wcd_default>;Please do:
property-n
property-names
Ack
Quoted 6 lines
arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi line 1641
Quoted 4 lines
+&usb_mp_dwc3 {
arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi new file +3
-0+ phys = <&usb_mp_hsphy0>, <&usb_mp_qmpphy0>; + phy-names = "usb2-0", "usb3-0"; +};Let's not override this, so that the driver can still put the remaining ones to sleep cleanly
This was added for a reason, after all-
Just tested booting without this, and the USB-A port does not work, with this in dmesg:
platform a400000.usb: deferred probe pending: dwc3: failed to initialize core
So it seems like the other ones "don't exist" / have been shut down completely by boot firmware(?)
Will add a clarifying comment.
~val
Re: [PATCH v3 3/5] arm64: dts: qcom: Add support for Dell Inspiron 7441 / Latitude 7455
Quoted 9 lines · Val Packett
Quoted 7 lines · Konrad Dybcio
Quoted 4 lines · Val Packett
+&usb_mp_dwc3 {
+ phys = <&usb_mp_hsphy0>, <&usb_mp_qmpphy0>;
+ phy-names = "usb2-0", "usb3-0";
+};Let's not override this, so that the driver can still put the remaining ones to sleep cleanly
[..]
Quoted 1 line
So it seems like the other ones "don't exist" / have been shut down completely by boot firmware(?)
Oh, oops - that actually happens because the PHYs are disabled in the DT.
Looking at other laptops, x1e80100-hp-omnibook-x14.dts has the same chunk that changes usb_mp_dwc3 to only have two PHYs, while x1e80100-dell-xps13-9345.dts lists both PHYs, but only one of them has a repeater attached, while the other one is empty.
I'll do the XPS thing, sure.
PATCH v3 4/5 firmware: qcom: scm: Allow QSEECOM on Dell Inspiron 7441 / Latitude 7455
In reply to Val PackettAllow these machines to access efivars through qseecom/uefisecapp.
--- drivers/firmware/qcom/qcom_scm.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/firmware/qcom/qcom_scm.c +2 -0
@@ -1988,6 +1988,8 @@ static const struct of_device_id qcom_scm_qseecom_allowlist[] __maybe_unused = { { .compatible = "asus,vivobook-s15" }, { .compatible = "asus,zenbook-a14-ux3407qa" }, { .compatible = "asus,zenbook-a14-ux3407ra" }, + { .compatible = "dell,inspiron-14-plus-7441" }, + { .compatible = "dell,latitude-7455" }, { .compatible = "dell,xps13-9345" }, { .compatible = "hp,elitebook-ultra-g1q" }, { .compatible = "hp,omnibook-x14" },
Signature · 1 line
2.49.0
PATCH v3 5/5 drm/panel-edp: Add BOE NE14QDM panel for Dell Latitude 7455
In reply to Val PackettCannot confirm which variant exactly it is, as the EDID alphanumeric data contains '0RGNR' <0x80> 'NE14QDM' and ends there; but it's 60 Hz and with touch.
I do not have access to datasheets for these panels, so the timing is a guess that was tested to work fine on this laptop.
Raw EDID dump:
00 ff ff ff ff ff ff 00 09 e5 1e 0b 00 00 00 00
10 20 01 04 a5 1e 13 78 07 fd 85 a7 53 4c 9b 25
0f 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
01 01 01 01 01 01 a7 6d 00 a0 a0 40 78 60 30 20
36 00 2e bc 10 00 00 1a b9 57 00 a0 a0 40 78 60
30 20 36 00 2e bc 10 00 00 1a 00 00 00 fe 00 30
52 47 4e 52 80 4e 45 31 34 51 44 4d 00 00 00 00
00 02 41 31 a8 00 01 00 00 1a 41 0a 20 20 00 8f
--- drivers/gpu/drm/panel/panel-edp.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/panel/panel-edp.c +1 -0
@@ -1939,6 +1939,7 @@ static const struct edp_panel_entry edp_panels[] = {EDP_PANEL_ENTRY ('B' ,'O' ,'E' ,0x0ac5 , &delay_200_500_e50,"NV116WHM-N4C" ),EDP_PANEL_ENTRY ('B' ,'O' ,'E' ,0x0ae8 , &delay_200_500_e50_p2e80,"NV140WUM-N41" ),EDP_PANEL_ENTRY ('B' ,'O' ,'E' ,0x0b09 , &delay_200_500_e50_po2e200,"NV140FHM-NZ" ), +EDP_PANEL_ENTRY ('B' ,'O' ,'E' ,0x0b1e , &delay_200_500_e80,"NE140QDM-N6A" ),EDP_PANEL_ENTRY ('B' ,'O' ,'E' ,0x0b34 , &delay_200_500_e80,"NV122WUM-N41" ),EDP_PANEL_ENTRY ('B' ,'O' ,'E' ,0x0b43 , &delay_200_500_e200,"NV140FHM-T09" ), EDP_PANEL_ENTRY('B', 'O', 'E', 0x0b56, &delay_200_500_e80, "NT140FHM-N47"),
Signature · 1 line
2.49.0
Re: [PATCH v3 5/5] drm/panel-edp: Add BOE NE14QDM panel for Dell Latitude 7455
Hi,
Quoted 19 lines · Val Packett
Cannot confirm which variant exactly it is, as the EDID alphanumeric data contains '0RGNR' <
0x80> 'NE14QDM' and ends there; but it's 60 Hz and with touch.I do not have access to datasheets for these panels, so the timing is a guess that was tested to work fine on this laptop.
Raw EDID dump:
00 ff ff ff ff ff ff 00 09 e5 1e 0b 00 00 00 00
10 20 01 04 a5 1e 13 78 07 fd 85 a7 53 4c 9b 25
0f 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
01 01 01 01 01 01 a7 6d 00 a0 a0 40 78 60 30 20
36 00 2e bc 10 00 00 1a b9 57 00 a0 a0 40 78 60
30 20 36 00 2e bc 10 00 00 1a 00 00 00 fe 00 30
52 47 4e 52 80 4e 45 31 34 51 44 4d 00 00 00 00
00 02 41 31 a8 00 01 00 00 1a 41 0a 20 20 00 8f
Quoted 4 lines
Signed-off-by Val Packett <[email protected]>--- drivers/gpu/drm/panel/panel-edp.c | 1 + 1 file changed, 1 insertion(+)
Pushed to drm-misc-next:
[5/5] drm/panel-edp: Add BOE NE14QDM panel for Dell Latitude 7455
commit: 1a304a2f8f7dbe25f555721f502227f9197145ed
Hi Val,
Quoted 29 lines · Val Packett
The unified series for Dell Thena laptops.
Changes since v2[1]:
- Fixed From/Co-developed-by on the big patch
- Fixed one remaining "inspirIon"
- Fixed codec/cpu alphabetical order in audio nodes (copy-paste..)
- Made the common dtsi an 'x1-' one in preparation for x1p models[1]: https://lore.kernel.org/all/[email protected]/
Bryan O'Donoghue (2):
dt-bindings: arm: qcom: Add Dell Inspiron 14 Plus 7441
arm64: dts: qcom: Add support for Dell Inspiron 7441 / Latitude 7455Val Packett (3):
dt-bindings: arm: qcom: Add Dell Latitude 7455
firmware: qcom: scm: Allow QSEECOM on Dell Inspiron 7441 / Latitude7455drm/panel-edp: Add BOE NE14QDM panel for Dell Latitude 7455
.../devicetree/bindings/arm/qcom.yaml | 2 + arch/arm64/boot/dts/qcom/Makefile | 4 + arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi | 1657 +++++++++++++++++ .../x1e80100-dell-inspiron-14-plus-7441.dts | 52 + .../dts/qcom/x1e80100-dell-latitude-7455.dts | 53 + drivers/firmware/qcom/qcom_scm.c | 2 + drivers/gpu/drm/panel/panel-edp.c | 1 + 7 files changed, 1771 insertions(+)
Quoted 4 lines
create mode 100644
arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi
create mode 100644arch/arm64/boot/dts/qcom/x1e80100-dell-inspiron-14-plus-7441.dtscreate mode 100644arch/arm64/boot/dts/qcom/x1e80100-dell-latitude-7455.dts
Thanks much for the effort!
For the series: