Skip to contentSkip to conversation

net/sxe: add base driver directory and doc

PATCH New Jie Liu 4 participants 338 messages Apr 25, 2025 – Mar 22 Page 6 of 6

Subsystems (2)
lore
Share & tools
lore
#300 lore raw

PATCH v18 11/13 net/sxe: add custom cmd led ctrl

In reply to [email protected]

From: Jie Liu <[email protected]>

Add custom cmd led ctrl.

---
 drivers/net/sxe/include/sxe/sxe_cli.h   | 218 ++++++++++++++++++++++++
 drivers/net/sxe/include/sxe/sxe_ioctl.h |  21 +++
 drivers/net/sxe/sxe_testpmd.c           |  66 +++++++
 3 files changed, 305 insertions(+)
 create mode 100644 drivers/net/sxe/include/sxe/sxe_cli.h
 create mode 100644 drivers/net/sxe/include/sxe/sxe_ioctl.h
 create mode 100644 drivers/net/sxe/sxe_testpmd.c
drivers/net/sxe/include/sxe/sxe_cli.h new file +218 -0
new file mode 100644
index 0000000000..b278a67907
@@ -0,0 +1,218 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (C), 2022, Linkdata Technology Co., Ltd.
+ */
+
+#ifndef __SXE_CLI_H__
+#define __SXE_CLI_H__
+
+#ifdef SXE_HOST_DRIVER
+#include "sxe_drv_type.h"
+#endif
+
+#define SXE_CODE_VERSION_LEN			(32)
+#define SXE_MAC_NUM				(128)
+#define SXE_PORT_TRANSCEIVER_LEN		(32)
+#define SXE_PORT_VENDOR_LEN			(32)
+#define SXE_CHIP_TYPE_LEN			(32)
+#define SXE_VPD_SN_LEN				(16)
+#define SXE_SOC_RST_TIME			(0x93A80)
+#define SXE_SFP_TEMP_THRESHOLD_INTERVAL		(3)
+#define MGC_TERMLOG_INFO_MAX_LEN		(12 * 1024)
+#define SXE_REGS_DUMP_MAX_LEN			(12 * 1024)
+#define SXE_PRODUCT_NAME_LEN			(32)
+
+typedef enum sxe_led_mode {
+	SXE_IDENTIFY_LED_BLINK_ON = 0,
+	SXE_IDENTIFY_LED_BLINK_OFF,
+	SXE_IDENTIFY_LED_ON,
+	SXE_IDENTIFY_LED_OFF,
+	SXE_IDENTIFY_LED_RESET,
+} sxe_led_mode_s;
+
+typedef struct sxe_led_ctrl {
+	U32	mode;
+	U32	duration;
+
+} sxe_led_ctrl_s;
+
+typedef struct sxe_led_ctrl_resp {
+	U32	ack;
+} sxe_led_ctrl_resp_s;
+
+typedef enum port_link_speed {
+	PORT_LINK_NO	= 0,
+	PORT_LINK_100M	= 1,
+	PORT_LINK_1G	= 2,
+	PORT_LINK_10G	= 3,
+} port_link_speed_e;
+
+typedef struct sys_soc_info {
+	S8	fw_ver[SXE_CODE_VERSION_LEN];
+	S8	opt_ver[SXE_CODE_VERSION_LEN];
+	U8	soc_status;
+	U8	pad[3];
+	S32	soc_temp;
+	U64	chipid;
+	S8	chip_type[SXE_CHIP_TYPE_LEN];
+	S8	pba[SXE_VPD_SN_LEN];
+	S8	product_name[SXE_PRODUCT_NAME_LEN];
+} sys_soc_info_s;
+
+typedef struct sys_port_info {
+	U64	mac[SXE_MAC_NUM];
+	U8	is_port_abs;
+	U8	link_stat;
+	U8	link_speed;
+
+
+	U8	is_sfp:1;
+	U8	is_get_info:1;
+	U8	rvd:6;
+	S8	optical_mod_temp;
+	U8	pad[3];
+	S8	transceiver_type[SXE_PORT_TRANSCEIVER_LEN];
+	S8	vendor_name[SXE_PORT_VENDOR_LEN];
+	S8	vendor_pn[SXE_PORT_VENDOR_LEN];
+} sys_port_info_s;
+
+typedef struct sys_info_resp {
+	sys_soc_info_s	soc_info;
+	sys_port_info_s	port_info;
+} sys_info_resp_s;
+
+typedef enum sfp_temp_td_mode {
+	SFP_TEMP_THRESHOLD_MODE_ALARM   = 0,
+	SFP_TEMP_THRESHOLD_MODE_WARN,
+} sfp_temp_td_mode_e;
+
+typedef struct sfp_temp_td_set {
+	U8	mode;
+	U8	pad[3];
+	S8	hthreshold;
+	S8	lthreshold;
+} sfp_temp_td_set_s;
+
+typedef struct sxe_log_export_resp {
+	U16	cur_log_len;
+	U8	is_end;
+	U8	pad;
+	S32	session_id;
+	S8	data[0];
+} sxe_log_export_resp_s;
+
+typedef enum sxe_log_export_type  {
+	SXE_LOG_EXPORT_REQ	= 0,
+	SXE_LOG_EXPORT_FIN,
+	SXE_LOG_EXPORT_ABORT,
+} sxe_log_export_type_e;
+
+typedef struct sxe_log_export_req {
+	U8	is_all_log;
+	U8	cmdtype;
+	U8	is_begin;
+	U8	pad;
+	S32	session_id;
+	U32	log_len;
+} sxe_log_export_req_s;
+
+typedef struct soc_rst_req {
+	U32	time;
+} soc_rst_req_s;
+
+typedef struct regs_dump_resp {
+	U32	curdw_len;
+	U8	data[0];
+} regs_dump_resp_s;
+
+enum {
+	SXE_MFG_PART_NUMBER_LEN   = 8,
+	SXE_MFG_SERIAL_NUMBER_LEN = 16,
+	SXE_MFG_REVISION_LEN	  = 4,
+	SXE_MFG_OEM_STR_LEN	   = 64,
+	SXE_MFG_SXE_BOARD_ASSEMBLY_LEN  = 32,
+	SXE_MFG_SXE_BOARD_TRACE_NUM_LEN = 16,
+	SXE_MFG_SXE_MAC_ADDR_CNT		= 2,
+};
+
+typedef struct sxe_mfg_info {
+	U8 part_number[SXE_MFG_PART_NUMBER_LEN];
+	U8 serial_number[SXE_MFG_SERIAL_NUMBER_LEN];
+	U32 mfg_date;
+	U8 revision[SXE_MFG_REVISION_LEN];
+	U32 rework_date;
+	U8 pad[4];
+	U64 mac_addr[SXE_MFG_SXE_MAC_ADDR_CNT];
+	U8 board_trace_num[SXE_MFG_SXE_BOARD_TRACE_NUM_LEN];
+	U8 board_assembly[SXE_MFG_SXE_BOARD_ASSEMBLY_LEN];
+	U8 extra1[SXE_MFG_OEM_STR_LEN];
+	U8 extra2[SXE_MFG_OEM_STR_LEN];
+} sxe_mfg_info_t;
+
+typedef struct sxe_lldp_info {
+	U8	lldp_state;
+	U8	pad[3];
+} sxe_lldp_info_t;
+
+typedef struct regs_dump_req {
+	U32	base_addr;
+	U32	dw_len;
+} regs_dump_req_s;
+
+typedef enum sxe_pcs_mode {
+	SXE_PCS_MODE_1000BASE_KX_WO = 0,
+	SXE_PCS_MODE_1000BASE_KX_W,
+	SXE_PCS_MODE_SGMII,
+	SXE_PCS_MODE_10GBASE_KR_WO,
+	SXE_PCS_MODE_AUTO_NEGT_73,
+	SXE_PCS_MODE_LPBK_PHY_TX2RX,
+	SXE_PCS_MODE_LPBK_PHY_RX2TX,
+	SXE_PCS_MODE_LPBK_PCS_RX2TX,
+	SXE_PCS_MODE_BUTT,
+} sxe_pcs_mode_e;
+
+typedef enum sxe_remote_fault_mode {
+	SXE_REMOTE_FALUT_NO_ERROR		= 0,
+	SXE_REMOTE_FALUT_OFFLINE,
+	SXE_REMOTE_FALUT_LINK_FAILURE,
+	SXE_REMOTE_FALUT_AUTO_NEGOTIATION,
+	SXE_REMOTE_UNKNOWN,
+} sxe_remote_fault_e;
+
+typedef struct sxe_phy_cfg {
+	sxe_pcs_mode_e mode;
+	U32 mtu;
+} sxe_pcs_cfg_s;
+
+typedef enum sxe_an_speed {
+	SXE_AN_SPEED_NO_LINK = 0,
+	SXE_AN_SPEED_100M,
+	SXE_AN_SPEED_1G,
+	SXE_AN_SPEED_10G,
+	SXE_AN_SPEED_UNKNOWN,
+} sxe_an_speed_e;
+
+typedef enum sxe_phy_pause_cap {
+	SXE_PAUSE_CAP_NO_PAUSE	= 0,
+	SXE_PAUSE_CAP_ASYMMETRIC_PAUSE,
+	SXE_PAUSE_CAP_SYMMETRIC_PAUSE,
+	SXE_PAUSE_CAP_BOTH_PAUSE,
+	SXE_PAUSE_CAP_UNKNOWN,
+} sxe_phy_pause_cap_e;
+
+typedef enum sxe_phy_duplex_type {
+	SXE_FULL_DUPLEX	= 0,
+	SXE_HALF_DUPLEX	= 1,
+	SXE_UNKNOWN_DUPLEX,
+} sxe_phy_duplex_type_e;
+
+typedef struct sxe_phy_an_cap {
+	sxe_remote_fault_e   remote_fault;
+	sxe_phy_pause_cap_e  pause_cap;
+	sxe_phy_duplex_type_e duplex_cap;
+} sxe_phy_an_cap_s;
+
+typedef struct sxe_an_cap {
+	sxe_phy_an_cap_s local;
+	sxe_phy_an_cap_s peer;
+} sxe_an_cap_s;
+#endif
drivers/net/sxe/include/sxe/sxe_ioctl.h new file +21 -0
new file mode 100644
index 0000000000..4a4b0bc304
@@ -0,0 +1,21 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (C), 2022, Linkdata Technology Co., Ltd.
+ */
+#ifndef _SXE_IOCTL_H_
+#define _SXE_IOCTL_H_
+
+#ifdef SXE_HOST_DRIVER
+#include "sxe_drv_type.h"
+#endif
+
+struct sxe_ioctl_sync_cmd {
+	U64   traceid;
+	void *in_data;
+	U32   in_len;
+	void *out_data;
+	U32   out_len;
+};
+
+#define SXE_CMD_IOCTL_SYNC_CMD _IOWR('M', 1, struct sxe_ioctl_sync_cmd)
+
+#endif
drivers/net/sxe/sxe_testpmd.c new file +66 -0

66 lines not on this page · raw message

Signature · 1 line
2.18.2
#301 lore raw

PATCH v18 12/13 net/sxe: add simd function

In reply to [email protected]

From: Jie Liu <[email protected]>

Add simd function.

---
 drivers/net/sxe/base/sxe_queue_common.c |  52 +-
 drivers/net/sxe/base/sxe_rx_common.c    | 124 ++++-
 drivers/net/sxe/pf/sxe_vec_common.h     | 321 ++++++++++++
 drivers/net/sxe/pf/sxe_vec_neon.c       | 600 +++++++++++++++++++++++
 drivers/net/sxe/pf/sxe_vec_sse.c        | 622 ++++++++++++++++++++++++
 5 files changed, 1716 insertions(+), 3 deletions(-)
 create mode 100644 drivers/net/sxe/pf/sxe_vec_common.h
 create mode 100644 drivers/net/sxe/pf/sxe_vec_neon.c
 create mode 100644 drivers/net/sxe/pf/sxe_vec_sse.c
drivers/net/sxe/base/sxe_queue_common.c +51 -1
index da44270019..991b374667 100644
@@ -13,6 +13,10 @@
 #include "sxe_logs.h"
 #include "sxe_regs.h"
 #include "sxe.h"
+#if defined SXE_DPDK_L4_FEATURES && defined SXE_DPDK_SIMD
+#include "sxe_vec_common.h"
+#include <rte_vect.h>
+#endif
 #include "sxe_queue_common.h"
 #include "sxe_queue.h"
 
@@ -57,6 +61,10 @@ s32 __rte_cold __sxe_rx_queue_setup(struct rx_setup *rx_setup, bool is_vf)
 	u16 len;
 	u64 offloads;
 	s32 ret = 0;
+#if defined SXE_DPDK_L4_FEATURES && defined SXE_DPDK_SIMD
+	struct sxe_adapter *pf_adapter = dev->data->dev_private;
+	struct sxevf_adapter *vf_adapter = dev->data->dev_private;
+#endif
 
 	PMD_INIT_FUNC_TRACE();
 
@@ -161,6 +169,23 @@ s32 __rte_cold __sxe_rx_queue_setup(struct rx_setup *rx_setup, bool is_vf)
 				"dma_addr=0x%" SXE_PRIX64,
 			 rxq->buffer_ring, rxq->sc_buffer_ring, rxq->desc_ring,
 			 rxq->base_addr);
+
+#if defined SXE_DPDK_L4_FEATURES && defined SXE_DPDK_SIMD
+	if (!rte_is_power_of_2(desc_num)) {
+		PMD_LOG_DEBUG(INIT, "queue[%d] doesn't meet Vector Rx "
+					"preconditions - canceling the feature for "
+					"the whole port[%d]",
+				 rxq->queue_id, rxq->port_id);
+		if (is_vf)
+			vf_adapter->rx_vec_allowed = false;
+		else
+			pf_adapter->rx_vec_allowed = false;
+
+	} else {
+		sxe_rxq_vec_setup(rxq);
+	}
+#endif
+
 	dev->data->rx_queues[queue_idx] = rxq;
 
 	sxe_rx_queue_init(*rx_setup->rx_batch_alloc_allowed, rxq);
@@ -254,6 +279,9 @@ void __sxe_recycle_rxq_info_get(struct rte_eth_dev *dev, u16 queue_id,
 		struct rte_eth_recycle_rxq_info *q_info)
 {
 	struct sxe_rx_queue *rxq;
+#if defined SXE_DPDK_L4_FEATURES && defined SXE_DPDK_SIMD
+	struct sxe_adapter *adapter = dev->data->dev_private;
+#endif
 
 	rxq = dev->data->rx_queues[queue_id];
 
@@ -261,9 +289,21 @@ void __sxe_recycle_rxq_info_get(struct rte_eth_dev *dev, u16 queue_id,
 	q_info->mp = rxq->mb_pool;
 	q_info->mbuf_ring_size = rxq->ring_depth;
 	q_info->receive_tail = &rxq->processing_idx;
-
+#if defined SXE_DPDK_L4_FEATURES && defined SXE_DPDK_SIMD
+	if (adapter->rx_vec_allowed) {
+#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM)
+		q_info->refill_requirement = rxq->realloc_num;
+		q_info->refill_head = &rxq->realloc_start;
+#endif
+	} else {
+		q_info->refill_requirement = rxq->batch_alloc_size;
+		q_info->refill_head = &rxq->batch_alloc_trigger;
+	}
+#else
 	q_info->refill_requirement = rxq->batch_alloc_size;
 	q_info->refill_head = &rxq->batch_alloc_trigger;
+#endif
+	return;
 }
 
 void __sxe_tx_queue_info_get(struct rte_eth_dev *dev, u16 queue_id,
@@ -289,7 +329,17 @@ s32 __sxe_tx_done_cleanup(void *tx_queue, u32 free_cnt)
 	struct sxe_tx_queue *txq = (struct sxe_tx_queue *)tx_queue;
 	if (txq->offloads == 0 &&
 		txq->rs_thresh >= RTE_PMD_SXE_MAX_TX_BURST) {
+#if defined SXE_DPDK_L4_FEATURES && defined SXE_DPDK_SIMD
+		if (txq->rs_thresh <= RTE_SXE_MAX_TX_FREE_BUF_SZ &&
+			(rte_eal_process_type() != RTE_PROC_PRIMARY ||
+			txq->buffer_ring_vec != NULL)) {
+			ret = sxe_tx_done_cleanup_vec(txq, free_cnt);
+		} else {
+			ret = sxe_tx_done_cleanup_simple(txq, free_cnt);
+		}
+#else
 		ret = sxe_tx_done_cleanup_simple(txq, free_cnt);
+#endif
 
 	} else {
 		ret = sxe_tx_done_cleanup_full(txq, free_cnt);
drivers/net/sxe/base/sxe_rx_common.c +122 -2

173 lines not on this page · raw message

drivers/net/sxe/pf/sxe_vec_common.h new file +321 -0

321 lines not on this page · raw message

drivers/net/sxe/pf/sxe_vec_neon.c new file +600 -0

600 lines not on this page · raw message

drivers/net/sxe/pf/sxe_vec_sse.c new file +622 -0

622 lines not on this page · raw message

Signature · 1 line
2.18.2
#302 lore raw

PATCH v18 13/13 net/sxe: add virtual function

In reply to [email protected]

From: Jie Liu <[email protected]>

Add virtual function.

---
 drivers/net/sxe/base/sxe_common.c          |    2 +-
 drivers/net/sxe/base/sxe_compat_platform.h |    2 -
 drivers/net/sxe/base/sxe_queue_common.c    |    4 +
 drivers/net/sxe/base/sxevf_hw.c            |  950 ++++++++++++++++
 drivers/net/sxe/base/sxevf_hw.h            |  349 ++++++
 drivers/net/sxe/base/sxevf_regs.h          |  119 ++
 drivers/net/sxe/include/sxe/sxe_msg.h      |    4 +-
 drivers/net/sxe/pf/rte_pmd_sxe.h           |    1 +
 drivers/net/sxe/pf/sxe_filter.c            |  177 +++
 drivers/net/sxe/pf/sxe_filter.h            |   15 +
 drivers/net/sxe/pf/sxe_phy.h               |    1 +
 drivers/net/sxe/pf/sxe_tx.c                |    2 +-
 drivers/net/sxe/pf/sxe_vf.c                | 1199 ++++++++++++++++++++
 drivers/net/sxe/pf/sxe_vf.h                |  200 ++++
 drivers/net/sxe/sxe_testpmd.c              |  130 +++
 drivers/net/sxe/vf/sxevf.h                 |   42 +
 drivers/net/sxe/vf/sxevf_ethdev.c          |  752 ++++++++++++
 drivers/net/sxe/vf/sxevf_ethdev.h          |   16 +
 drivers/net/sxe/vf/sxevf_filter.c          |  493 ++++++++
 drivers/net/sxe/vf/sxevf_filter.h          |   70 ++
 drivers/net/sxe/vf/sxevf_irq.c             |  432 +++++++
 drivers/net/sxe/vf/sxevf_irq.h             |   34 +
 drivers/net/sxe/vf/sxevf_main.c            |   82 ++
 drivers/net/sxe/vf/sxevf_msg.c             |  624 ++++++++++
 drivers/net/sxe/vf/sxevf_msg.h             |  201 ++++
 drivers/net/sxe/vf/sxevf_offload.c         |   30 +
 drivers/net/sxe/vf/sxevf_offload.h         |   16 +
 drivers/net/sxe/vf/sxevf_queue.c           |  208 ++++
 drivers/net/sxe/vf/sxevf_queue.h           |   69 ++
 drivers/net/sxe/vf/sxevf_rx.c              |  162 +++
 drivers/net/sxe/vf/sxevf_rx.h              |   18 +
 drivers/net/sxe/vf/sxevf_stats.c           |  162 +++
 drivers/net/sxe/vf/sxevf_stats.h           |   31 +
 drivers/net/sxe/vf/sxevf_tx.c              |   46 +
 drivers/net/sxe/vf/sxevf_tx.h              |   14 +
 35 files changed, 6651 insertions(+), 6 deletions(-)
 create mode 100644 drivers/net/sxe/base/sxevf_hw.c
 create mode 100644 drivers/net/sxe/base/sxevf_hw.h
 create mode 100644 drivers/net/sxe/base/sxevf_regs.h
 create mode 100644 drivers/net/sxe/pf/sxe_vf.c
 create mode 100644 drivers/net/sxe/pf/sxe_vf.h
 create mode 100644 drivers/net/sxe/vf/sxevf.h
 create mode 100644 drivers/net/sxe/vf/sxevf_ethdev.c
 create mode 100644 drivers/net/sxe/vf/sxevf_ethdev.h
 create mode 100644 drivers/net/sxe/vf/sxevf_filter.c
 create mode 100644 drivers/net/sxe/vf/sxevf_filter.h
 create mode 100644 drivers/net/sxe/vf/sxevf_irq.c
 create mode 100644 drivers/net/sxe/vf/sxevf_irq.h
 create mode 100644 drivers/net/sxe/vf/sxevf_main.c
 create mode 100644 drivers/net/sxe/vf/sxevf_msg.c
 create mode 100644 drivers/net/sxe/vf/sxevf_msg.h
 create mode 100644 drivers/net/sxe/vf/sxevf_offload.c
 create mode 100644 drivers/net/sxe/vf/sxevf_offload.h
 create mode 100644 drivers/net/sxe/vf/sxevf_queue.c
 create mode 100644 drivers/net/sxe/vf/sxevf_queue.h
 create mode 100644 drivers/net/sxe/vf/sxevf_rx.c
 create mode 100644 drivers/net/sxe/vf/sxevf_rx.h
 create mode 100644 drivers/net/sxe/vf/sxevf_stats.c
 create mode 100644 drivers/net/sxe/vf/sxevf_stats.h
 create mode 100644 drivers/net/sxe/vf/sxevf_tx.c
 create mode 100644 drivers/net/sxe/vf/sxevf_tx.h
drivers/net/sxe/base/sxe_common.c +1 -1
index 8b3fb13e73..cf6b656680 100644
@@ -44,7 +44,7 @@ u64 sxe_time_get_real_ms(void)
 
 u64 sxe_trace_id_gen(void)
 {
-	u64 tid	   = getpid() + (pthread_self() << 20);
+	u64 tid	   = (u64)getpid() + ((u64)pthread_self() << 20);
 	u64 index	 = 0;
 	u64 timestamp = sxe_time_get_real_ms();
 
drivers/net/sxe/base/sxe_compat_platform.h +0 -2
index 80d7d3f288..8c254d52c5 100644
@@ -25,8 +25,6 @@
 #define __iomem
 #define __force
 
-#define min(a, b)	RTE_MIN(a, b)
-
 #ifndef fallthrough
 # define fallthrough do {} while (0)
 #endif
drivers/net/sxe/base/sxe_queue_common.c +4 -0
index 991b374667..15e086b45e 100644
@@ -12,11 +12,15 @@
 #include "sxe_tx.h"
 #include "sxe_logs.h"
 #include "sxe_regs.h"
+#include "sxevf_regs.h"
 #include "sxe.h"
 #if defined SXE_DPDK_L4_FEATURES && defined SXE_DPDK_SIMD
 #include "sxe_vec_common.h"
 #include <rte_vect.h>
 #endif
+#if defined SXE_DPDK_L4_FEATURES && defined SXE_DPDK_SRIOV
+#include "sxevf.h"
+#endif
 #include "sxe_queue_common.h"
 #include "sxe_queue.h"
 
drivers/net/sxe/base/sxevf_hw.c new file +950 -0

950 lines not on this page · raw message

drivers/net/sxe/base/sxevf_hw.h new file +349 -0

349 lines not on this page · raw message

drivers/net/sxe/base/sxevf_regs.h new file +119 -0

119 lines not on this page · raw message

drivers/net/sxe/include/sxe/sxe_msg.h +2 -2
index 460258c907..19d03d25b2 100644
@@ -119,7 +119,7 @@ typedef struct sxe_sfp_rate_able {
 
 
 typedef struct sxe_spp_tx_able {
-	BOOL is_disable;
+	bool is_disable;
 } sxe_spp_tx_able_s;
 
 
@@ -129,7 +129,7 @@ typedef struct sxe_default_mac_addr_resp {
 
 
 typedef struct sxe_mng_rst {
-	BOOL enable;
+	bool enable;
 } sxe_mng_rst_s;
 
 #endif
drivers/net/sxe/pf/rte_pmd_sxe.h +1 -0
index 25e768624f..2369f03214 100644
@@ -15,4 +15,5 @@ typedef int32_t		s32;
 s32 rte_pmd_sxe_tx_loopback_set(u16 port, u8 on);
 __rte_experimental
 s32 rte_pmd_sxe_tc_bw_set(u8 port, u8 tc_num, u8 *bw_weight);
+int rte_pmd_sxe_set_vf_rxmode(u16 port, u16 vf, u16 rx_mask, u8 on);
 #endif
drivers/net/sxe/pf/sxe_filter.c +177 -0

202 lines not on this page · raw message

drivers/net/sxe/pf/sxe_filter.h +15 -0
index 2b7c91a9bd..7b9026fcfb 100644
@@ -72,6 +72,15 @@ void sxe_mac_addr_remove(struct rte_eth_dev *dev, u32 rar_idx);
 s32 sxe_mac_addr_set(struct rte_eth_dev *dev,
 				 struct rte_ether_addr *mac_addr);
 
+s32 sxe_uc_hash_table_set(struct rte_eth_dev *dev,
+			struct rte_ether_addr *mac_addr, u8 on);
+
+s32 sxe_uc_all_hash_table_set(struct rte_eth_dev *dev, u8 on);
+
+s32 sxe_set_mc_addr_list(struct rte_eth_dev *dev,
+			  struct rte_ether_addr *mc_addr_list,
+			  u32 nb_mc_addr);
+
 s32 sxe_vlan_filter_set(struct rte_eth_dev *eth_dev, u16 vlan_id, s32 on);
 
 s32 sxe_vlan_tpid_set(struct rte_eth_dev *eth_dev,
@@ -91,4 +100,10 @@ void sxe_vlan_strip_switch_set(struct rte_eth_dev *dev);
 
 void sxe_fc_mac_addr_set(struct sxe_adapter *adapter);
 
+u8 sxe_sw_uc_entry_vf_add(struct sxe_adapter *adapter,
+				u8 vf_idx, u8 *mac_addr, bool macvlan);
+
+void sxe_sw_uc_entry_vf_del(struct sxe_adapter *adapter, u8 vf_idx,
+					bool macvlan);
+
 #endif
drivers/net/sxe/pf/sxe_phy.h +1 -0
index 0dd2ad2d95..65a530ba2b 100644
@@ -6,6 +6,7 @@
 
 #include <rte_ethdev.h>
 #include "drv_msg.h"
+#include "sxe_cli.h"
 #include "sxe_msg.h"
 
 #define SXE_SFF_BASE_ADDR			0x0
drivers/net/sxe/pf/sxe_tx.c +1 -1
index 33d4468ebc..bbf802cd2f 100644
@@ -55,7 +55,7 @@ void __rte_cold sxe_tx_function_set(struct rte_eth_dev *dev,
 
 		PMD_LOG_INFO(INIT, "using full-featured tx code path");
 		PMD_LOG_INFO(INIT, " - offloads = 0x%" SXE_PRIX64,
-					(unsigned long)txq->offloads);
+							txq->offloads);
 		PMD_LOG_INFO(INIT, " - tx_rs_thresh = %d "
 				   "[RTE_PMD_SXE_MAX_TX_BURST=%d]",
 				txq->rs_thresh,
drivers/net/sxe/pf/sxe_vf.c new file +1199 -0

1,199 lines not on this page · raw message

drivers/net/sxe/pf/sxe_vf.h new file +200 -0

89 lines not on this page · raw message

drivers/net/sxe/sxe_testpmd.c +130 -0

130 lines not on this page · raw message

drivers/net/sxe/vf/sxevf.h new file +42 -0

42 lines not on this page · raw message

drivers/net/sxe/vf/sxevf_ethdev.c new file +752 -0

752 lines not on this page · raw message

drivers/net/sxe/vf/sxevf_ethdev.h new file +16 -0
new file mode 100644
index 0000000000..57dfeea2e6

Lines of this file are not shown. View the raw message.

drivers/net/sxe/vf/sxevf_filter.c new file +493 -0

493 lines not on this page · raw message

drivers/net/sxe/vf/sxevf_filter.h new file +70 -0

70 lines not on this page · raw message

drivers/net/sxe/vf/sxevf_irq.c new file +432 -0

432 lines not on this page · raw message

drivers/net/sxe/vf/sxevf_irq.h new file +34 -0
new file mode 100644
index 0000000000..2f9860ba15

Lines of this file are not shown. View the raw message.

drivers/net/sxe/vf/sxevf_main.c new file +82 -0

82 lines not on this page · raw message

drivers/net/sxe/vf/sxevf_msg.c new file +624 -0

624 lines not on this page · raw message

drivers/net/sxe/vf/sxevf_msg.h new file +201 -0

201 lines not on this page · raw message

drivers/net/sxe/vf/sxevf_offload.c new file +30 -0
new file mode 100644
index 0000000000..b39245aa11

Lines of this file are not shown. View the raw message.

drivers/net/sxe/vf/sxevf_offload.h new file +16 -0
new file mode 100644
index 0000000000..ae4bf87f30

Lines of this file are not shown. View the raw message.

drivers/net/sxe/vf/sxevf_queue.c new file +208 -0

208 lines not on this page · raw message

drivers/net/sxe/vf/sxevf_queue.h new file +69 -0

69 lines not on this page · raw message

drivers/net/sxe/vf/sxevf_rx.c new file +162 -0

162 lines not on this page · raw message

drivers/net/sxe/vf/sxevf_rx.h new file +18 -0
new file mode 100644
index 0000000000..55ca2705c1

Lines of this file are not shown. View the raw message.

drivers/net/sxe/vf/sxevf_stats.c new file +162 -0

162 lines not on this page · raw message

drivers/net/sxe/vf/sxevf_stats.h new file +31 -0
new file mode 100644
index 0000000000..cba450953f

Lines of this file are not shown. View the raw message.

drivers/net/sxe/vf/sxevf_tx.c new file +46 -0

46 lines not on this page · raw message

drivers/net/sxe/vf/sxevf_tx.h new file +14 -0
new file mode 100644
index 0000000000..c8ad400bca

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.18.2

Part of the diff is not shown here. View the raw message.

#303 lore raw

v19 cover net/sxe: added Linkdata sxe ethernet driver

From: Jie Liu <[email protected]>

This patch set implements core functionality for the SXE PMD, including basic driver framework, data path setup, and advanced offload features (VLAN, RSS, DCB, PTP etc.).

V19:
- Addressed AI comments

v18:
- Addressed AI comments

Jie Liu (13):
net/sxe: add base driver directory and doc
net/sxe: add ethdev probe and remove
net/sxe: add tx rx setup and data path
net/sxe: add link and mac layer operations
net/sxe: support vlan filter
net/sxe: add filter function
net/sxe: support rss offload
net/sxe: add dcb function
net/sxe: support ptp
net/sxe: add xstats function
net/sxe: add custom cmd led ctrl
net/sxe: add simd function
net/sxe: add virtual function

 MAINTAINERS                                |    6 +
 doc/guides/nics/features/sxe.ini           |   51 +
 doc/guides/nics/features/sxe_vf.ini        |   37 +
 doc/guides/nics/index.rst                  |    1 +
 doc/guides/nics/sxe.rst                    |   71 +
 doc/guides/rel_notes/release_26_03.rst     |    6 +
 drivers/net/meson.build                    |    1 +
 drivers/net/sxe/base/sxe_common.c          |   45 +
 drivers/net/sxe/base/sxe_common.h          |   13 +
 drivers/net/sxe/base/sxe_compat_platform.h |   73 +
 drivers/net/sxe/base/sxe_compat_version.h  |   34 +
 drivers/net/sxe/base/sxe_errno.h           |   61 +
 drivers/net/sxe/base/sxe_hw.c              | 3271 ++++++++++++++++++++
 drivers/net/sxe/base/sxe_hw.h              | 1010 ++++++
 drivers/net/sxe/base/sxe_logs.h            |  105 +
 drivers/net/sxe/base/sxe_offload_common.c  |   54 +
 drivers/net/sxe/base/sxe_offload_common.h  |   14 +
 drivers/net/sxe/base/sxe_queue_common.c    |  450 +++
 drivers/net/sxe/base/sxe_queue_common.h    |  240 ++
 drivers/net/sxe/base/sxe_rx_common.c       |  358 +++
 drivers/net/sxe/base/sxe_rx_common.h       |   17 +
 drivers/net/sxe/base/sxe_tx_common.c       |   40 +
 drivers/net/sxe/base/sxe_tx_common.h       |   12 +
 drivers/net/sxe/base/sxe_types.h           |   40 +
 drivers/net/sxe/base/sxevf_hw.c            |  819 +++++
 drivers/net/sxe/base/sxevf_hw.h            |  318 ++
 drivers/net/sxe/base/sxevf_regs.h          |  119 +
 drivers/net/sxe/include/drv_msg.h          |   18 +
 drivers/net/sxe/include/sxe/sxe_cli.h      |  218 ++
 drivers/net/sxe/include/sxe/sxe_hdc.h      |   43 +
 drivers/net/sxe/include/sxe/sxe_ioctl.h    |   21 +
 drivers/net/sxe/include/sxe/sxe_msg.h      |  135 +
 drivers/net/sxe/include/sxe/sxe_regs.h     | 1270 ++++++++
 drivers/net/sxe/include/sxe_type.h         |  795 +++++
 drivers/net/sxe/include/sxe_version.h      |   29 +
 drivers/net/sxe/meson.build                |   65 +
 drivers/net/sxe/pf/rte_pmd_sxe.h           |   19 +
 drivers/net/sxe/pf/sxe.h                   |   93 +
 drivers/net/sxe/pf/sxe_dcb.c               |  945 ++++++
 drivers/net/sxe/pf/sxe_dcb.h               |   99 +
 drivers/net/sxe/pf/sxe_ethdev.c            |  928 ++++++
 drivers/net/sxe/pf/sxe_ethdev.h            |   28 +
 drivers/net/sxe/pf/sxe_filter.c            |  923 ++++++
 drivers/net/sxe/pf/sxe_filter.h            |  109 +
 drivers/net/sxe/pf/sxe_flow_ctrl.c         |   98 +
 drivers/net/sxe/pf/sxe_flow_ctrl.h         |   16 +
 drivers/net/sxe/pf/sxe_irq.c               |  516 +++
 drivers/net/sxe/pf/sxe_irq.h               |   48 +
 drivers/net/sxe/pf/sxe_main.c              |  196 ++
 drivers/net/sxe/pf/sxe_offload.c           |  336 ++
 drivers/net/sxe/pf/sxe_offload.h           |   51 +
 drivers/net/sxe/pf/sxe_phy.c               |  953 ++++++
 drivers/net/sxe/pf/sxe_phy.h               |  117 +
 drivers/net/sxe/pf/sxe_pmd_hdc.c           |  661 ++++
 drivers/net/sxe/pf/sxe_pmd_hdc.h           |   42 +
 drivers/net/sxe/pf/sxe_ptp.c               |  209 ++
 drivers/net/sxe/pf/sxe_ptp.h               |   26 +
 drivers/net/sxe/pf/sxe_queue.c             |  774 +++++
 drivers/net/sxe/pf/sxe_queue.h             |  132 +
 drivers/net/sxe/pf/sxe_rx.c                | 1459 +++++++++
 drivers/net/sxe/pf/sxe_rx.h                |  188 ++
 drivers/net/sxe/pf/sxe_stats.c             |  586 ++++
 drivers/net/sxe/pf/sxe_stats.h             |   69 +
 drivers/net/sxe/pf/sxe_tx.c                | 1051 +++++++
 drivers/net/sxe/pf/sxe_tx.h                |   50 +
 drivers/net/sxe/pf/sxe_vec_common.h        |  321 ++
 drivers/net/sxe/pf/sxe_vec_neon.c          |  600 ++++
 drivers/net/sxe/pf/sxe_vec_sse.c           |  622 ++++
 drivers/net/sxe/pf/sxe_vf.c                | 1199 +++++++
 drivers/net/sxe/pf/sxe_vf.h                |  200 ++
 drivers/net/sxe/sxe_drv_type.h             |   15 +
 drivers/net/sxe/sxe_testpmd.c              |  196 ++
 drivers/net/sxe/vf/sxevf.h                 |   42 +
 drivers/net/sxe/vf/sxevf_ethdev.c          |  752 +++++
 drivers/net/sxe/vf/sxevf_ethdev.h          |   16 +
 drivers/net/sxe/vf/sxevf_filter.c          |  493 +++
 drivers/net/sxe/vf/sxevf_filter.h          |   70 +
 drivers/net/sxe/vf/sxevf_irq.c             |  432 +++
 drivers/net/sxe/vf/sxevf_irq.h             |   34 +
 drivers/net/sxe/vf/sxevf_main.c            |   82 +
 drivers/net/sxe/vf/sxevf_msg.c             |  624 ++++
 drivers/net/sxe/vf/sxevf_msg.h             |  201 ++
 drivers/net/sxe/vf/sxevf_offload.c         |   30 +
 drivers/net/sxe/vf/sxevf_offload.h         |   16 +
 drivers/net/sxe/vf/sxevf_queue.c           |  208 ++
 drivers/net/sxe/vf/sxevf_queue.h           |   69 +
 drivers/net/sxe/vf/sxevf_rx.c              |  162 +
 drivers/net/sxe/vf/sxevf_rx.h              |   18 +
 drivers/net/sxe/vf/sxevf_stats.c           |  162 +
 drivers/net/sxe/vf/sxevf_stats.h           |   31 +
 drivers/net/sxe/vf/sxevf_tx.c              |   46 +
 drivers/net/sxe/vf/sxevf_tx.h              |   14 +
 92 files changed, 27237 insertions(+)
 create mode 100644 doc/guides/nics/features/sxe.ini
 create mode 100644 doc/guides/nics/features/sxe_vf.ini
 create mode 100644 doc/guides/nics/sxe.rst
 create mode 100644 drivers/net/sxe/base/sxe_common.c
 create mode 100644 drivers/net/sxe/base/sxe_common.h
 create mode 100644 drivers/net/sxe/base/sxe_compat_platform.h
 create mode 100644 drivers/net/sxe/base/sxe_compat_version.h
 create mode 100644 drivers/net/sxe/base/sxe_errno.h
 create mode 100644 drivers/net/sxe/base/sxe_hw.c
 create mode 100644 drivers/net/sxe/base/sxe_hw.h
 create mode 100644 drivers/net/sxe/base/sxe_logs.h
 create mode 100644 drivers/net/sxe/base/sxe_offload_common.c
 create mode 100644 drivers/net/sxe/base/sxe_offload_common.h
 create mode 100644 drivers/net/sxe/base/sxe_queue_common.c
 create mode 100644 drivers/net/sxe/base/sxe_queue_common.h
 create mode 100644 drivers/net/sxe/base/sxe_rx_common.c
 create mode 100644 drivers/net/sxe/base/sxe_rx_common.h
 create mode 100644 drivers/net/sxe/base/sxe_tx_common.c
 create mode 100644 drivers/net/sxe/base/sxe_tx_common.h
 create mode 100644 drivers/net/sxe/base/sxe_types.h
 create mode 100644 drivers/net/sxe/base/sxevf_hw.c
 create mode 100644 drivers/net/sxe/base/sxevf_hw.h
 create mode 100644 drivers/net/sxe/base/sxevf_regs.h
 create mode 100644 drivers/net/sxe/include/drv_msg.h
 create mode 100644 drivers/net/sxe/include/sxe/sxe_cli.h
 create mode 100644 drivers/net/sxe/include/sxe/sxe_hdc.h
 create mode 100644 drivers/net/sxe/include/sxe/sxe_ioctl.h
 create mode 100644 drivers/net/sxe/include/sxe/sxe_msg.h
 create mode 100644 drivers/net/sxe/include/sxe/sxe_regs.h
 create mode 100644 drivers/net/sxe/include/sxe_type.h
 create mode 100644 drivers/net/sxe/include/sxe_version.h
 create mode 100644 drivers/net/sxe/meson.build
 create mode 100644 drivers/net/sxe/pf/rte_pmd_sxe.h
 create mode 100644 drivers/net/sxe/pf/sxe.h
 create mode 100644 drivers/net/sxe/pf/sxe_dcb.c
 create mode 100644 drivers/net/sxe/pf/sxe_dcb.h
 create mode 100644 drivers/net/sxe/pf/sxe_ethdev.c
 create mode 100644 drivers/net/sxe/pf/sxe_ethdev.h
 create mode 100644 drivers/net/sxe/pf/sxe_filter.c
 create mode 100644 drivers/net/sxe/pf/sxe_filter.h
 create mode 100644 drivers/net/sxe/pf/sxe_flow_ctrl.c
 create mode 100644 drivers/net/sxe/pf/sxe_flow_ctrl.h
 create mode 100644 drivers/net/sxe/pf/sxe_irq.c
 create mode 100644 drivers/net/sxe/pf/sxe_irq.h
 create mode 100644 drivers/net/sxe/pf/sxe_main.c
 create mode 100644 drivers/net/sxe/pf/sxe_offload.c
 create mode 100644 drivers/net/sxe/pf/sxe_offload.h
 create mode 100644 drivers/net/sxe/pf/sxe_phy.c
 create mode 100644 drivers/net/sxe/pf/sxe_phy.h
 create mode 100644 drivers/net/sxe/pf/sxe_pmd_hdc.c
 create mode 100644 drivers/net/sxe/pf/sxe_pmd_hdc.h
 create mode 100644 drivers/net/sxe/pf/sxe_ptp.c
 create mode 100644 drivers/net/sxe/pf/sxe_ptp.h
 create mode 100644 drivers/net/sxe/pf/sxe_queue.c
 create mode 100644 drivers/net/sxe/pf/sxe_queue.h
 create mode 100644 drivers/net/sxe/pf/sxe_rx.c
 create mode 100644 drivers/net/sxe/pf/sxe_rx.h
 create mode 100644 drivers/net/sxe/pf/sxe_stats.c
 create mode 100644 drivers/net/sxe/pf/sxe_stats.h
 create mode 100644 drivers/net/sxe/pf/sxe_tx.c
 create mode 100644 drivers/net/sxe/pf/sxe_tx.h
 create mode 100644 drivers/net/sxe/pf/sxe_vec_common.h
 create mode 100644 drivers/net/sxe/pf/sxe_vec_neon.c
 create mode 100644 drivers/net/sxe/pf/sxe_vec_sse.c
 create mode 100644 drivers/net/sxe/pf/sxe_vf.c
 create mode 100644 drivers/net/sxe/pf/sxe_vf.h
 create mode 100644 drivers/net/sxe/sxe_drv_type.h
 create mode 100644 drivers/net/sxe/sxe_testpmd.c
 create mode 100644 drivers/net/sxe/vf/sxevf.h
 create mode 100644 drivers/net/sxe/vf/sxevf_ethdev.c
 create mode 100644 drivers/net/sxe/vf/sxevf_ethdev.h
 create mode 100644 drivers/net/sxe/vf/sxevf_filter.c
 create mode 100644 drivers/net/sxe/vf/sxevf_filter.h
 create mode 100644 drivers/net/sxe/vf/sxevf_irq.c
 create mode 100644 drivers/net/sxe/vf/sxevf_irq.h
 create mode 100644 drivers/net/sxe/vf/sxevf_main.c
 create mode 100644 drivers/net/sxe/vf/sxevf_msg.c
 create mode 100644 drivers/net/sxe/vf/sxevf_msg.h
 create mode 100644 drivers/net/sxe/vf/sxevf_offload.c
 create mode 100644 drivers/net/sxe/vf/sxevf_offload.h
 create mode 100644 drivers/net/sxe/vf/sxevf_queue.c
 create mode 100644 drivers/net/sxe/vf/sxevf_queue.h
 create mode 100644 drivers/net/sxe/vf/sxevf_rx.c
 create mode 100644 drivers/net/sxe/vf/sxevf_rx.h
 create mode 100644 drivers/net/sxe/vf/sxevf_stats.c
 create mode 100644 drivers/net/sxe/vf/sxevf_stats.h
 create mode 100644 drivers/net/sxe/vf/sxevf_tx.c
 create mode 100644 drivers/net/sxe/vf/sxevf_tx.h
Signature · 1 line
2.18.2
#304 lore raw

PATCH v19 1/13 net/sxe: add base driver directory and doc

From: Jie Liu <[email protected]>

Adding a minimum maintainable directory structure for the network driver and request maintenance of the sxe driver.

---
 MAINTAINERS                            |  6 +++
 doc/guides/nics/features/sxe.ini       | 51 ++++++++++++++++++
 doc/guides/nics/features/sxe_vf.ini    | 37 ++++++++++++++
 doc/guides/nics/index.rst              |  1 +
 doc/guides/nics/sxe.rst                | 71 ++++++++++++++++++++++++++
 doc/guides/rel_notes/release_26_03.rst |  6 +++
 drivers/net/sxe/meson.build            |  9 ++++
 drivers/net/sxe/pf/sxe_ethdev.c        |  3 ++
 drivers/net/sxe/pf/sxe_ethdev.h        |  3 ++
 9 files changed, 187 insertions(+)
 create mode 100644 doc/guides/nics/features/sxe.ini
 create mode 100644 doc/guides/nics/features/sxe_vf.ini
 create mode 100644 doc/guides/nics/sxe.rst
 create mode 100644 drivers/net/sxe/meson.build
 create mode 100644 drivers/net/sxe/pf/sxe_ethdev.c
 create mode 100644 drivers/net/sxe/pf/sxe_ethdev.h
MAINTAINERS +6 -0
index 5eb8e9dc22..13341e9bcd 100644
@@ -858,6 +858,12 @@ F: drivers/net/intel/ipn3ke/
 F: doc/guides/nics/ipn3ke.rst
 F: doc/guides/nics/features/ipn3ke.ini
 
+Linkdata sxe
+M: Jie Liu <[email protected]>
+F: drivers/net/sxe/
+F: doc/guides/nics/sxe.rst
+F: doc/guides/nics/features/sxe*.ini
+
 Marvell cnxk
 M: Nithin Dabilpuram <[email protected]>
 M: Kiran Kumar K <[email protected]>
doc/guides/nics/features/sxe.ini new file +51 -0

51 lines not on this page · raw message

doc/guides/nics/features/sxe_vf.ini new file +37 -0
new file mode 100644
index 0000000000..7caf5435ae
@@ -0,0 +1,37 @@
+;
+; Supported features of the 'sxe_vf' network poll mode driver.
+;
+; Refer to default.ini for the full list of available PMD features.
+;
+[Features]
+Link status          = Y
+Rx interrupt         = Y
+Power mgmt address monitor = Y
+MTU update           = Y
+Scattered Rx         = Y
+LRO                  = Y
+TSO                  = Y
+Promiscuous mode     = Y
+Allmulticast mode    = Y
+Unicast MAC filter   = Y
+RSS hash             = Y
+RSS key update       = Y
+RSS reta update      = Y
+VLAN filter          = Y
+Inline crypto        = Y
+CRC offload          = P
+VLAN offload         = P
+QinQ offload         = P
+L3 checksum offload  = P
+L4 checksum offload  = P
+Inner L3 checksum    = P
+Inner L4 checksum    = P
+Packet type parsing  = Y
+Rx descriptor status = Y
+Tx descriptor status = Y
+Basic stats          = Y
+Extended stats       = Y
+Registers dump       = Y
+Linux                = Y
+ARMv8                = Y
+x86-64               = Y
doc/guides/nics/index.rst +1 -0
index cb818284fe..ace3caa8c4 100644
@@ -68,6 +68,7 @@ Network Interface Controller Drivers
     rnp
     sfc_efx
     softnic
+    sxe
     tap
     thunderx
     txgbe
doc/guides/nics/sxe.rst new file +71 -0

71 lines not on this page · raw message

doc/guides/rel_notes/release_26_03.rst +6 -0
index f6801c41b6..64595054a0 100644
@@ -122,6 +122,12 @@ New Features
   Added handling of the key combination Control+L
   to clear the screen before redisplaying the prompt.
 
+* **Added Linkdata sxe ethernet driver.**
+
+  Added support for Linkdata NIC series, including 1160-2X (supporting 10G).
+  As these new models share hardware similarities with the existing 10G Sapphire NICs,
+  many of the existing configurations and practices are expected to apply.
+
 Removed Items
 -------------
 
drivers/net/sxe/meson.build new file +9 -0
new file mode 100644
index 0000000000..c2460c7229
@@ -0,0 +1,9 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright (C), 2022, Linkdata Technology Co., Ltd.
+
+deps += ['hash']
+sources = files(
+        'pf/sxe_ethdev.c',
+)
+
+includes += include_directories('pf')
drivers/net/sxe/pf/sxe_ethdev.c new file +3 -0
new file mode 100644
index 0000000000..bcd91b6a8c
@@ -0,0 +1,3 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (C), 2022, Linkdata Technology Co., Ltd.
+ */
drivers/net/sxe/pf/sxe_ethdev.h new file +3 -0
new file mode 100644
index 0000000000..bcd91b6a8c
@@ -0,0 +1,3 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (C), 2022, Linkdata Technology Co., Ltd.
+ */
Signature · 1 line
2.18.2
#305 lore raw

PATCH v19 2/13 net/sxe: add ethdev probe and remove

In reply to [email protected]

From: Jie Liu <[email protected]>

Add basic modules: logs and hardware communication and common components and support basic PCIe ethdev probe and remove.

---
 drivers/net/sxe/base/sxe_common.c          |   45 +
 drivers/net/sxe/base/sxe_common.h          |   13 +
 drivers/net/sxe/base/sxe_compat_platform.h |   75 +
 drivers/net/sxe/base/sxe_compat_version.h  |   34 +
 drivers/net/sxe/base/sxe_errno.h           |   61 +
 drivers/net/sxe/base/sxe_hw.c              | 3271 ++++++++++++++++++++
 drivers/net/sxe/base/sxe_hw.h              | 1010 ++++++
 drivers/net/sxe/base/sxe_logs.h            |  105 +
 drivers/net/sxe/base/sxe_types.h           |   40 +
 drivers/net/sxe/include/drv_msg.h          |   18 +
 drivers/net/sxe/include/sxe/sxe_hdc.h      |   43 +
 drivers/net/sxe/include/sxe/sxe_msg.h      |  135 +
 drivers/net/sxe/include/sxe/sxe_regs.h     | 1270 ++++++++
 drivers/net/sxe/include/sxe_version.h      |   29 +
 drivers/net/sxe/meson.build                |   17 +
 drivers/net/sxe/pf/sxe.h                   |   56 +
 drivers/net/sxe/pf/sxe_ethdev.c            |  302 ++
 drivers/net/sxe/pf/sxe_ethdev.h            |   25 +
 drivers/net/sxe/pf/sxe_irq.c               |  118 +
 drivers/net/sxe/pf/sxe_irq.h               |   39 +
 drivers/net/sxe/pf/sxe_main.c              |  178 ++
 drivers/net/sxe/pf/sxe_phy.h               |   38 +
 drivers/net/sxe/pf/sxe_pmd_hdc.c           |  661 ++++
 drivers/net/sxe/pf/sxe_pmd_hdc.h           |   42 +
 drivers/net/sxe/sxe_drv_type.h             |   15 +
 25 files changed, 7640 insertions(+)
 create mode 100644 drivers/net/sxe/base/sxe_common.c
 create mode 100644 drivers/net/sxe/base/sxe_common.h
 create mode 100644 drivers/net/sxe/base/sxe_compat_platform.h
 create mode 100644 drivers/net/sxe/base/sxe_compat_version.h
 create mode 100644 drivers/net/sxe/base/sxe_errno.h
 create mode 100644 drivers/net/sxe/base/sxe_hw.c
 create mode 100644 drivers/net/sxe/base/sxe_hw.h
 create mode 100644 drivers/net/sxe/base/sxe_logs.h
 create mode 100644 drivers/net/sxe/base/sxe_types.h
 create mode 100644 drivers/net/sxe/include/drv_msg.h
 create mode 100644 drivers/net/sxe/include/sxe/sxe_hdc.h
 create mode 100644 drivers/net/sxe/include/sxe/sxe_msg.h
 create mode 100644 drivers/net/sxe/include/sxe/sxe_regs.h
 create mode 100644 drivers/net/sxe/include/sxe_version.h
 create mode 100644 drivers/net/sxe/pf/sxe.h
 create mode 100644 drivers/net/sxe/pf/sxe_irq.c
 create mode 100644 drivers/net/sxe/pf/sxe_irq.h
 create mode 100644 drivers/net/sxe/pf/sxe_main.c
 create mode 100644 drivers/net/sxe/pf/sxe_phy.h
 create mode 100644 drivers/net/sxe/pf/sxe_pmd_hdc.c
 create mode 100644 drivers/net/sxe/pf/sxe_pmd_hdc.h
 create mode 100644 drivers/net/sxe/sxe_drv_type.h
drivers/net/sxe/base/sxe_common.c new file +45 -0
new file mode 100644
index 0000000000..8f3e80fae3
@@ -0,0 +1,45 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (C), 2022, Linkdata Technology Co., Ltd.
+ */
+
+#include <pthread.h>
+#include <sys/time.h>
+#include <sys/types.h>
+#include <unistd.h>
+#include <rte_common.h>
+#include <rte_cycles.h>
+#include <time.h>
+#include "sxe_types.h"
+#include "sxe_common.h"
+
+#define SXE_SEC_TO_MS(sec) ((sec) * 1000ULL)
+
+#define SXE_NSEC_PER_MS		  1000000
+
+RTE_ATOMIC(uint64_t) sxe_trace_id;
+
+u64 sxe_time_get_real_ms(void)
+{
+	u64 ms = 0;
+	struct timespec ts;
+	s32 ret = clock_gettime(CLOCK_MONOTONIC, &ts);
+	if (ret < 0)
+		goto l_end;
+
+	ms = SXE_SEC_TO_MS(ts.tv_sec) + ts.tv_nsec / SXE_NSEC_PER_MS;
+
+l_end:
+	return ms;
+}
+
+void sxe_trace_id_gen(void)
+{
+	sxe_trace_id = 0;
+	return;
+}
+
+u64 sxe_trace_id_get(void)
+{
+	return rte_atomic_fetch_add_explicit((uint64_t __rte_atomic *)&sxe_trace_id,
+			1, rte_memory_order_relaxed);
+}
drivers/net/sxe/base/sxe_common.h new file +13 -0
new file mode 100644
index 0000000000..7196eb08bf
@@ -0,0 +1,13 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (C), 2022, Linkdata Technology Co., Ltd.
+ */
+#ifndef __SXE_DPDK_COMMON_H__
+#define __SXE_DPDK_COMMON_H__
+
+void sxe_trace_id_gen(void);
+
+u64 sxe_trace_id_get(void);
+
+u64 sxe_time_get_real_ms(void);
+
+#endif
drivers/net/sxe/base/sxe_compat_platform.h new file +75 -0

75 lines not on this page · raw message

drivers/net/sxe/base/sxe_compat_version.h new file +34 -0
new file mode 100644
index 0000000000..7eb9f37da6
@@ -0,0 +1,34 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (C), 2022, Linkdata Technology Co., Ltd.
+ */
+
+#ifndef __SXE_COMPAT_VERSION_H__
+#define __SXE_COMPAT_VERSION_H__
+
+#include <stdbool.h>
+
+struct rte_eth_dev;
+enum rte_eth_event_type;
+
+int sxe_eth_dev_callback_process(struct rte_eth_dev *dev,
+	enum rte_eth_event_type event, void *ret_param);
+
+#define PCI_REG_WC_WRITE
+
+#ifndef PCI_REG_WC_WRITE
+#define rte_write32_wc rte_write32
+#define rte_write32_wc_relaxed rte_write32_relaxed
+#endif
+
+#define SXE_PCI_INTR_HANDLE(pci_dev) \
+	((pci_dev)->intr_handle)
+#define SXE_DEV_FNAV_CONF(dev) \
+	(&((struct sxe_adapter *)(dev)->data->dev_private)->fnav_conf)
+#define RTE_ADAPTER_HAVE_FNAV_CONF
+#define SXE_GET_FRAME_SIZE(dev) \
+	((dev)->data->mtu + SXE_ETH_OVERHEAD)
+
+#define DEV_RX_OFFLOAD_CHECKSUM RTE_ETH_RX_OFFLOAD_CHECKSUM
+#define ETH_DCB_NUM_USER_PRIORITIES RTE_ETH_DCB_NUM_USER_PRIORITIES
+
+#endif
drivers/net/sxe/base/sxe_errno.h new file +61 -0

61 lines not on this page · raw message

drivers/net/sxe/base/sxe_hw.c new file +3271 -0

2,772 lines not on this page · raw message

drivers/net/sxe/base/sxe_hw.h new file +1010 -0

1,010 lines not on this page · raw message

drivers/net/sxe/base/sxe_logs.h new file +105 -0

105 lines not on this page · raw message

drivers/net/sxe/base/sxe_types.h new file +40 -0
new file mode 100644
index 0000000000..a36a3cfbf6

Lines of this file are not shown. View the raw message.

drivers/net/sxe/include/drv_msg.h new file +18 -0
new file mode 100644
index 0000000000..87c505569d

Lines of this file are not shown. View the raw message.

drivers/net/sxe/include/sxe/sxe_hdc.h new file +43 -0

43 lines not on this page · raw message

drivers/net/sxe/include/sxe/sxe_msg.h new file +135 -0

135 lines not on this page · raw message

drivers/net/sxe/include/sxe/sxe_regs.h new file +1270 -0

1,270 lines not on this page · raw message

drivers/net/sxe/include/sxe_version.h new file +29 -0
new file mode 100644
index 0000000000..fb58e73399

Lines of this file are not shown. View the raw message.

drivers/net/sxe/meson.build +17 -0
index c2460c7229..0afd54e071 100644

Lines of this file are not shown. View the raw message.

drivers/net/sxe/pf/sxe.h new file +56 -0

56 lines not on this page · raw message

drivers/net/sxe/pf/sxe_ethdev.c +302 -0

302 lines not on this page · raw message

drivers/net/sxe/pf/sxe_ethdev.h +25 -0
index bcd91b6a8c..66034343ea 100644

Lines of this file are not shown. View the raw message.

drivers/net/sxe/pf/sxe_irq.c new file +118 -0

118 lines not on this page · raw message

drivers/net/sxe/pf/sxe_irq.h new file +39 -0
new file mode 100644
index 0000000000..e3a7da6ae8

Lines of this file are not shown. View the raw message.

drivers/net/sxe/pf/sxe_main.c new file +178 -0

178 lines not on this page · raw message

drivers/net/sxe/pf/sxe_phy.h new file +38 -0
new file mode 100644
index 0000000000..2947d88812

Lines of this file are not shown. View the raw message.

drivers/net/sxe/pf/sxe_pmd_hdc.c new file +661 -0

661 lines not on this page · raw message

drivers/net/sxe/pf/sxe_pmd_hdc.h new file +42 -0

42 lines not on this page · raw message

drivers/net/sxe/sxe_drv_type.h new file +15 -0
new file mode 100644
index 0000000000..027c0571a4

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.18.2

Part of the diff is not shown here. View the raw message.

#306 lore raw

Re: [PATCH v19 02/13] net/sxe: add ethdev probe and remove

Quoted 15 lines · On Sat, 14 Mar 2026 16:51:54 +0800 [email protected] wrote:
drivers/net/sxe/base/sxe_common.c new file +9 -0
new file mode 100644
index 0000000000..8f3e80fae3
@@ -0,0 +1,45 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (C), 2022, Linkdata Technology Co., Ltd.
+ */
+
+#include <pthread.h>
+#include <sys/time.h>
+#include <sys/types.h>
+#include <unistd.h>
+#include <rte_common.h>

drivers/net/sxe/base/sxe_common.c line 19

Quoted 10 lines
drivers/net/sxe/base/sxe_common.c new file +10 -0
+#include <rte_cycles.h>
+#include <time.h>
+#include "sxe_types.h"
+#include "sxe_common.h"
+
+#define SXE_SEC_TO_MS(sec) ((sec) * 1000ULL)
+
+#define SXE_NSEC_PER_MS		  1000000
+
+RTE_ATOMIC(uint64_t) sxe_trace_id;

Could this be static.

drivers/net/sxe/base/sxe_common.c line 25

Quoted 6 lines
drivers/net/sxe/base/sxe_common.c new file +6 -0
+
+u64 sxe_time_get_real_ms(void)
+{
+	u64 ms = 0;
+	struct timespec ts;
+	s32 ret = clock_gettime(CLOCK_MONOTONIC, &ts);

If you are only looking at ms then you might be able to CLOCK_MONOTONIC_COARSE

drivers/net/sxe/base/sxe_common.c line 27

Quoted 2 lines
drivers/net/sxe/base/sxe_common.c new file +2 -0
+	if (ret < 0)
+		goto l_end;

Could be simpler as:

	if (unlikely(clockgettime(CLOCK_MONOTONIC, &ts) < 0))
		return 0;

drivers/net/sxe/base/sxe_common.c line 39

Quoted 12 lines
drivers/net/sxe/base/sxe_common.c new file +12 -0
+
+	ms = SXE_SEC_TO_MS(ts.tv_sec) + ts.tv_nsec / SXE_NSEC_PER_MS;
+
+l_end:
+	return ms;
+}
+
+void sxe_trace_id_gen(void)
+{
+	sxe_trace_id = 0;
+	return;
+}

Return statement is unnecessary here

drivers/net/sxe/base/sxe_common.c line 45

Quoted 5 lines
drivers/net/sxe/base/sxe_common.c new file +5 -0
+u64 sxe_trace_id_get(void)
+{
+	return rte_atomic_fetch_add_explicit((uint64_t __rte_atomic *)&sxe_trace_id,
+			1, rte_memory_order_relaxed);
+}

The cast should not be necessary.

#307 lore raw

PATCH v19 3/13 net/sxe: add tx rx setup and data path

In reply to [email protected]

From: Jie Liu <[email protected]>

Add setup and initialization and logic for tx and rx queues.

---
 drivers/net/meson.build                   |    1 +
 drivers/net/sxe/base/sxe_offload_common.c |   49 +
 drivers/net/sxe/base/sxe_offload_common.h |   14 +
 drivers/net/sxe/base/sxe_queue_common.c   |  396 ++++++
 drivers/net/sxe/base/sxe_queue_common.h   |  240 ++++
 drivers/net/sxe/base/sxe_rx_common.c      |  238 ++++
 drivers/net/sxe/base/sxe_rx_common.h      |   17 +
 drivers/net/sxe/base/sxe_tx_common.c      |   40 +
 drivers/net/sxe/base/sxe_tx_common.h      |   12 +
 drivers/net/sxe/include/sxe_type.h        |  795 +++++++++++
 drivers/net/sxe/meson.build               |    8 +
 drivers/net/sxe/pf/sxe.h                  |    3 +
 drivers/net/sxe/pf/sxe_ethdev.c           |    2 +-
 drivers/net/sxe/pf/sxe_irq.c              |  257 ++++
 drivers/net/sxe/pf/sxe_irq.h              |    9 +
 drivers/net/sxe/pf/sxe_main.c             |    7 +
 drivers/net/sxe/pf/sxe_offload.c          |   37 +
 drivers/net/sxe/pf/sxe_offload.h          |   18 +
 drivers/net/sxe/pf/sxe_queue.c            |  774 +++++++++++
 drivers/net/sxe/pf/sxe_queue.h            |  132 ++
 drivers/net/sxe/pf/sxe_rx.c               | 1459 +++++++++++++++++++++
 drivers/net/sxe/pf/sxe_rx.h               |  188 +++
 drivers/net/sxe/pf/sxe_tx.c               | 1051 +++++++++++++++
 drivers/net/sxe/pf/sxe_tx.h               |   50 +
 24 files changed, 5796 insertions(+), 1 deletion(-)
 create mode 100644 drivers/net/sxe/base/sxe_offload_common.c
 create mode 100644 drivers/net/sxe/base/sxe_offload_common.h
 create mode 100644 drivers/net/sxe/base/sxe_queue_common.c
 create mode 100644 drivers/net/sxe/base/sxe_queue_common.h
 create mode 100644 drivers/net/sxe/base/sxe_rx_common.c
 create mode 100644 drivers/net/sxe/base/sxe_rx_common.h
 create mode 100644 drivers/net/sxe/base/sxe_tx_common.c
 create mode 100644 drivers/net/sxe/base/sxe_tx_common.h
 create mode 100644 drivers/net/sxe/include/sxe_type.h
 create mode 100644 drivers/net/sxe/pf/sxe_offload.c
 create mode 100644 drivers/net/sxe/pf/sxe_offload.h
 create mode 100644 drivers/net/sxe/pf/sxe_queue.c
 create mode 100644 drivers/net/sxe/pf/sxe_queue.h
 create mode 100644 drivers/net/sxe/pf/sxe_rx.c
 create mode 100644 drivers/net/sxe/pf/sxe_rx.h
 create mode 100644 drivers/net/sxe/pf/sxe_tx.c
 create mode 100644 drivers/net/sxe/pf/sxe_tx.h
drivers/net/meson.build +1 -0
index c7dae4ad27..a1d9949a9d 100644
@@ -58,6 +58,7 @@ drivers = [
         'rnp',
         'sfc',
         'softnic',
+        'sxe',
         'tap',
         'thunderx',
         'txgbe',
drivers/net/sxe/base/sxe_offload_common.c new file +49 -0

49 lines not on this page · raw message

drivers/net/sxe/base/sxe_offload_common.h new file +14 -0
new file mode 100644
index 0000000000..cbfb7fd93f
@@ -0,0 +1,14 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (C), 2022, Linkdata Technology Co., Ltd.
+ */
+
+#ifndef __SXE_OFFLOAD_COMMON_H__
+#define __SXE_OFFLOAD_COMMON_H__
+
+u64 __sxe_rx_queue_offload_capa_get(struct rte_eth_dev *dev);
+
+u64 __sxe_rx_port_offload_capa_get(struct rte_eth_dev *dev);
+
+u64 __sxe_tx_port_offload_capa_get(struct rte_eth_dev *dev);
+
+#endif
drivers/net/sxe/base/sxe_queue_common.c new file +396 -0

396 lines not on this page · raw message

drivers/net/sxe/base/sxe_queue_common.h new file +240 -0

240 lines not on this page · raw message

drivers/net/sxe/base/sxe_rx_common.c new file +238 -0

238 lines not on this page · raw message

drivers/net/sxe/base/sxe_rx_common.h new file +17 -0
new file mode 100644
index 0000000000..d1bf172c89
@@ -0,0 +1,17 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (C), 2022, Linkdata Technology Co., Ltd.
+ */
+
+#ifndef __SXE_RX_COMMON_H__
+#define __SXE_RX_COMMON_H__
+
+void __rte_cold __sxe_rx_function_set(struct rte_eth_dev *dev,
+	bool rx_batch_alloc_allowed, bool *rx_vec_allowed);
+
+s32 __sxe_rx_descriptor_status(void *rx_queue, u16 offset);
+
+u16 __sxe_pkts_recv(void *rx_queue, struct rte_mbuf **rx_pkts,
+		u16 pkts_num);
+
+const u32 *__sxe_dev_supported_ptypes_get(struct rte_eth_dev *dev, size_t *no_of_elements);
+#endif
drivers/net/sxe/base/sxe_tx_common.c new file +40 -0
new file mode 100644
index 0000000000..5f8a951bbd
@@ -0,0 +1,40 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (C), 2022, Linkdata Technology Co., Ltd.
+ */
+#include <ethdev_driver.h>
+#include <ethdev_pci.h>
+#include <rte_net.h>
+
+#include "sxe_hw.h"
+#include "sxe_logs.h"
+#include "sxe_queue_common.h"
+#include "sxe_tx_common.h"
+
+int __sxe_tx_descriptor_status(void *tx_queue, u16 offset)
+{
+	int ret = RTE_ETH_TX_DESC_FULL;
+	u32 desc_idx;
+	struct sxe_tx_queue *txq = tx_queue;
+	volatile u32 *status;
+
+	if (unlikely(offset >= txq->ring_depth)) {
+		ret = -EINVAL;
+		goto l_end;
+	}
+
+	desc_idx = txq->next_to_use + offset;
+
+	desc_idx = ((desc_idx + txq->rs_thresh - 1) / txq->rs_thresh) * txq->rs_thresh;
+	if (desc_idx >= txq->ring_depth) {
+		desc_idx -= txq->ring_depth;
+		if (desc_idx >= txq->ring_depth)
+			desc_idx -= txq->ring_depth;
+	}
+
+	status = &txq->desc_ring[desc_idx].wb.status;
+	if (*status & rte_cpu_to_le_32(SXE_TX_DESC_STAT_DD))
+		ret = RTE_ETH_TX_DESC_DONE;
+
+l_end:
+	return ret;
+}
drivers/net/sxe/base/sxe_tx_common.h new file +12 -0
new file mode 100644
index 0000000000..2759ef5a7a
@@ -0,0 +1,12 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (C), 2022, Linkdata Technology Co., Ltd.
+ */
+
+#ifndef __SXE_TX_COMMON_H__
+#define __SXE_TX_COMMON_H__
+
+int __sxe_tx_descriptor_status(void *tx_queue, u16 offset);
+
+u16 __sxe_pkts_xmit_with_offload(void *tx_queue, struct rte_mbuf **tx_pkts, u16 pkts_num);
+
+#endif
drivers/net/sxe/include/sxe_type.h new file +795 -0

795 lines not on this page · raw message

drivers/net/sxe/meson.build +8 -0
index 0afd54e071..816d7b02a6 100644
@@ -15,7 +15,15 @@ sources = files(
         'pf/sxe_main.c',
         'pf/sxe_irq.c',
         'pf/sxe_ethdev.c',
+        'pf/sxe_offload.c',
+        'pf/sxe_queue.c',
+        'pf/sxe_rx.c',
+        'pf/sxe_tx.c',
         'pf/sxe_pmd_hdc.c',
+        'base/sxe_queue_common.c',
+        'base/sxe_rx_common.c',
+        'base/sxe_tx_common.c',
+        'base/sxe_offload_common.c',
         'base/sxe_common.c',
         'base/sxe_hw.c',
 )
drivers/net/sxe/pf/sxe.h +3 -0
index 009d2db173..187c7341e1 100644
@@ -9,7 +9,9 @@
 
 #include <stdbool.h>
 #include "sxe_types.h"
+#include "sxe_filter.h"
 #include "sxe_irq.h"
+#include "sxe_stats.h"
 #include "sxe_phy.h"
 #include "sxe_hw.h"
 
@@ -44,6 +46,7 @@ struct sxe_adapter {
 
 	struct sxe_irq_context irq_ctxt;
 
+	bool rx_batch_alloc_allowed;
 	s8 name[PCI_PRI_STR_SIZE + 1];
 };
 
drivers/net/sxe/pf/sxe_ethdev.c +1 -1
index 41bf47cf7d..c28cbd9a74 100644
@@ -1,13 +1,13 @@
 /* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (C), 2022, Linkdata Technology Co., Ltd.
  */
-
 #include <bus_pci_driver.h>
 #include <ethdev_driver.h>
 #include <dev_driver.h>
 #include <ethdev_pci.h>
 #include <rte_ethdev.h>
 #include <rte_alarm.h>
+#include <eal_export.h>
 #include "sxe_types.h"
 #include "sxe_logs.h"
 #include "sxe_compat_platform.h"
drivers/net/sxe/pf/sxe_irq.c +257 -0

273 lines not on this page · raw message

drivers/net/sxe/pf/sxe_irq.h +9 -0
index e3a7da6ae8..f2bbc74928 100644
@@ -33,7 +33,16 @@ void sxe_event_irq_delayed_handler(void *param);
 
 void sxe_irq_init(struct rte_eth_dev *eth_dev);
 
+s32 sxe_irq_configure(struct rte_eth_dev *dev);
+
+void sxe_irq_enable(struct rte_eth_dev *eth_dev);
+
+void sxe_irq_disable(struct rte_eth_dev *eth_dev);
+
 void sxe_irq_uninit(struct rte_eth_dev *eth_dev);
 
+s32 sxe_rx_queue_intr_enable(struct rte_eth_dev *eth_dev, u16 queue_id);
+
+s32 sxe_rx_queue_intr_disable(struct rte_eth_dev *eth_dev, u16 queue_id);
 
 #endif
drivers/net/sxe/pf/sxe_main.c +7 -0
index 19ec5e93ac..ee81d37385 100644
@@ -19,9 +19,11 @@
 #include "sxe_ethdev.h"
 #include "sxe.h"
 #include "drv_msg.h"
+#include "sxe_queue.h"
 #include "sxe_errno.h"
 #include "sxe_compat_platform.h"
 #include "sxe_pmd_hdc.h"
+#include "sxe_queue.h"
 
 static const struct rte_pci_id sxe_pci_tbl[] = {
 	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_STARS, SXE_DEV_ID_ASIC) },
@@ -115,10 +117,15 @@ s32 sxe_hw_reset(struct sxe_hw *hw)
 {
 	s32 ret;
 
+	/* Rx DBU off */
+	sxe_hw_rx_cap_switch_off(hw);
+
 	sxe_hw_all_irq_disable(hw);
 
 	sxe_hw_pending_irq_read_clear(hw);
 
+	sxe_hw_all_ring_disable(hw, SXE_HW_TXRX_RING_NUM_MAX);
+
 	ret = sxe_mng_reset(hw, false);
 	if (ret) {
 		PMD_LOG_ERR(INIT, "mng reset disable failed, ret=%d", ret);
drivers/net/sxe/pf/sxe_offload.c new file +37 -0
new file mode 100644
index 0000000000..0fa3f4822a
@@ -0,0 +1,37 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (C), 2022, Linkdata Technology Co., Ltd.
+ */
+#include <ethdev_driver.h>
+#include "sxe.h"
+#include "sxe_offload.h"
+#include "sxe_logs.h"
+#include "sxe_compat_version.h"
+#include "sxe_queue_common.h"
+#include "sxe_offload_common.h"
+
+#define SXE_4_BIT_WIDTH  (CHAR_BIT / 2)
+#define SXE_4_BIT_MASK   RTE_LEN2MASK(SXE_4_BIT_WIDTH, u8)
+#define SXE_8_BIT_WIDTH  CHAR_BIT
+#define SXE_8_BIT_MASK   UINT8_MAX
+
+u64 sxe_rx_queue_offload_capa_get(struct rte_eth_dev *dev)
+{
+	return __sxe_rx_queue_offload_capa_get(dev);
+}
+
+u64 sxe_rx_port_offload_capa_get(struct rte_eth_dev *dev)
+{
+	return __sxe_rx_port_offload_capa_get(dev);
+}
+
+u64 sxe_tx_queue_offload_capa_get(struct rte_eth_dev *dev)
+{
+	RTE_SET_USED(dev);
+
+	return 0;
+}
+
+u64 sxe_tx_port_offload_capa_get(struct rte_eth_dev *dev)
+{
+	return __sxe_tx_port_offload_capa_get(dev);
+}
drivers/net/sxe/pf/sxe_offload.h new file +18 -0
new file mode 100644
index 0000000000..a70d6bf94b
@@ -0,0 +1,18 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (C), 2022, Linkdata Technology Co., Ltd.
+ */
+
+#ifndef __SXE_OFFLOAD_H__
+#define __SXE_OFFLOAD_H__
+
+#include "sxe_hw.h"
+
+u64 sxe_rx_queue_offload_capa_get(struct rte_eth_dev *dev);
+
+u64 sxe_rx_port_offload_capa_get(struct rte_eth_dev *dev);
+
+u64 sxe_tx_queue_offload_capa_get(struct rte_eth_dev *dev);
+
+u64 sxe_tx_port_offload_capa_get(struct rte_eth_dev *dev);
+
+#endif
drivers/net/sxe/pf/sxe_queue.c new file +774 -0

774 lines not on this page · raw message

drivers/net/sxe/pf/sxe_queue.h new file +132 -0

3 lines not on this page · raw message

drivers/net/sxe/pf/sxe_rx.c new file +1459 -0

1,459 lines not on this page · raw message

drivers/net/sxe/pf/sxe_rx.h new file +188 -0

188 lines not on this page · raw message

drivers/net/sxe/pf/sxe_tx.c new file +1051 -0

1,051 lines not on this page · raw message

drivers/net/sxe/pf/sxe_tx.h new file +50 -0

50 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.18.2

Part of the diff is not shown here. View the raw message.

#308 lore raw

PATCH v19 4/13 net/sxe: add link and mac layer operations

In reply to [email protected]

From: Jie Liu <[email protected]>

Add link and mac layer operations.

---
 drivers/net/sxe/meson.build        |   3 +
 drivers/net/sxe/pf/rte_pmd_sxe.h   |  14 +
 drivers/net/sxe/pf/sxe.h           |  36 +-
 drivers/net/sxe/pf/sxe_ethdev.c    | 629 +++++++++++++++++++-
 drivers/net/sxe/pf/sxe_filter.c    | 278 +++++++++
 drivers/net/sxe/pf/sxe_filter.h    |  52 ++
 drivers/net/sxe/pf/sxe_flow_ctrl.c |  98 +++
 drivers/net/sxe/pf/sxe_flow_ctrl.h |  16 +
 drivers/net/sxe/pf/sxe_irq.c       | 143 ++++-
 drivers/net/sxe/pf/sxe_main.c      |   2 +-
 drivers/net/sxe/pf/sxe_phy.c       | 919 +++++++++++++++++++++++++++++
 drivers/net/sxe/pf/sxe_phy.h       |  76 +++
 12 files changed, 2260 insertions(+), 6 deletions(-)
 create mode 100644 drivers/net/sxe/pf/rte_pmd_sxe.h
 create mode 100644 drivers/net/sxe/pf/sxe_filter.c
 create mode 100644 drivers/net/sxe/pf/sxe_filter.h
 create mode 100644 drivers/net/sxe/pf/sxe_flow_ctrl.c
 create mode 100644 drivers/net/sxe/pf/sxe_flow_ctrl.h
 create mode 100644 drivers/net/sxe/pf/sxe_phy.c
drivers/net/sxe/meson.build +3 -0
index 816d7b02a6..251eeced94 100644
@@ -13,6 +13,8 @@ cflags += ['-DSXE_HOST_DRIVER']
 deps += ['hash']
 sources = files(
         'pf/sxe_main.c',
+        'pf/sxe_filter.c',
+        'pf/sxe_flow_ctrl.c',
         'pf/sxe_irq.c',
         'pf/sxe_ethdev.c',
         'pf/sxe_offload.c',
@@ -20,6 +22,7 @@ sources = files(
         'pf/sxe_rx.c',
         'pf/sxe_tx.c',
         'pf/sxe_pmd_hdc.c',
+        'pf/sxe_phy.c',
         'base/sxe_queue_common.c',
         'base/sxe_rx_common.c',
         'base/sxe_tx_common.c',
drivers/net/sxe/pf/rte_pmd_sxe.h new file +14 -0
new file mode 100644
index 0000000000..64c1140490
@@ -0,0 +1,14 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (C), 2022, Linkdata Technology Co., Ltd.
+ */
+
+#ifndef __PMD_SXE_H__
+#define __PMD_SXE_H__
+
+typedef uint8_t		u8;
+typedef uint16_t	u16;
+typedef uint32_t	u32;
+typedef int32_t		s32;
+
+s32 rte_pmd_sxe_tx_loopback_set(u16 port, u8 on);
+#endif
drivers/net/sxe/pf/sxe.h +35 -1
index 187c7341e1..8fecce13fd 100644
@@ -6,16 +6,18 @@
 
 #include <rte_pci.h>
 #include <rte_time.h>
-
 #include <stdbool.h>
 #include "sxe_types.h"
 #include "sxe_filter.h"
 #include "sxe_irq.h"
 #include "sxe_stats.h"
 #include "sxe_phy.h"
+#include "sxe_vf.h"
+#include "sxe_dcb.h"
 #include "sxe_hw.h"
 
 struct sxe_hw;
+struct sxe_vlan_context;
 
 #define SXE_LPBK_DISABLED   0x0
 #define SXE_LPBK_ENABLED	0x1
@@ -41,13 +43,45 @@ struct sxe_hw;
 #define rte_sxe_prefetch(p)   do {} while (0)
 #endif
 
+struct sxe_ptp_context {
+	struct rte_timecounter	  systime_tc;
+	struct rte_timecounter	  rx_tstamp_tc;
+	struct rte_timecounter	  tx_tstamp_tc;
+	u32 tx_hwtstamp_sec;
+	u32 tx_hwtstamp_nsec;
+};
+
 struct sxe_adapter {
 	struct sxe_hw hw;
 
 	struct sxe_irq_context irq_ctxt;
 
+	struct sxe_vlan_context vlan_ctxt;
+	struct sxe_mac_filter_context mac_filter_ctxt;
+#ifdef RTE_ADAPTER_HAVE_FNAV_CONF
+	struct rte_eth_fdir_conf fnav_conf;
+#endif
+	struct sxe_ptp_context ptp_ctxt;
+	struct sxe_phy_context phy_ctxt;
+	struct sxe_virtual_context vt_ctxt;
+
+	struct sxe_stats_info stats_info;
+	struct sxe_dcb_context dcb_ctxt;
+
 	bool rx_batch_alloc_allowed;
+#if defined SXE_DPDK_L4_FEATURES && defined SXE_DPDK_SIMD
+	bool rx_vec_allowed;
+#endif
 	s8 name[PCI_PRI_STR_SIZE + 1];
+
+	u32 mtu;
+
+	bool rss_reta_updated;
+
+	RTE_ATOMIC(bool) link_thread_running;
+	RTE_ATOMIC(bool) is_stopping;
+	rte_thread_t link_thread_tid;
+	bool is_stopped;
 };
 
 s32 sxe_hw_reset(struct sxe_hw *hw);
drivers/net/sxe/pf/sxe_ethdev.c +626 -3

767 lines not on this page · raw message

drivers/net/sxe/pf/sxe_filter.c new file +278 -0

278 lines not on this page · raw message

drivers/net/sxe/pf/sxe_filter.h new file +52 -0

52 lines not on this page · raw message

drivers/net/sxe/pf/sxe_flow_ctrl.c new file +98 -0

98 lines not on this page · raw message

drivers/net/sxe/pf/sxe_flow_ctrl.h new file +16 -0
new file mode 100644
index 0000000000..fb124b11bd
@@ -0,0 +1,16 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (C), 2022, Linkdata Technology Co., Ltd.
+ */
+
+#ifndef __SXE_FLOW_CTRL_H__
+#define __SXE_FLOW_CTRL_H__
+
+s32 sxe_flow_ctrl_enable(struct rte_eth_dev *dev);
+
+s32 sxe_flow_ctrl_get(struct rte_eth_dev *dev,
+					struct rte_eth_fc_conf *fc_conf);
+
+s32 sxe_flow_ctrl_set(struct rte_eth_dev *dev,
+					struct rte_eth_fc_conf *fc_conf);
+
+#endif
drivers/net/sxe/pf/sxe_irq.c +142 -1

169 lines not on this page · raw message

drivers/net/sxe/pf/sxe_main.c +1 -1
index ee81d37385..cbc0edd2cd 100644
@@ -152,7 +152,7 @@ s32 sxe_hw_reset(struct sxe_hw *hw)
 
 void sxe_hw_start(struct sxe_hw *hw)
 {
-	;
+	sxe_fc_autoneg_localcap_set(hw);
 }
 
 static bool is_device_supported(struct rte_eth_dev *dev,
drivers/net/sxe/pf/sxe_phy.c new file +919 -0

919 lines not on this page · raw message

drivers/net/sxe/pf/sxe_phy.h +76 -0

81 lines not on this page · raw message

Signature · 1 line
2.18.2
#309 lore raw

PATCH v19 5/13 net/sxe: support vlan filter

In reply to [email protected]

From: Jie Liu <[email protected]>

Support vlan filter.

---
 drivers/net/sxe/base/sxe_offload_common.c |   4 +
 drivers/net/sxe/pf/sxe_filter.c           | 277 ++++++++++++++++++++++
 drivers/net/sxe/pf/sxe_filter.h           |  13 +
 drivers/net/sxe/pf/sxe_main.c             |   2 +
 4 files changed, 296 insertions(+)
drivers/net/sxe/base/sxe_offload_common.c +4 -0
index f07d2b9572..f7c7363a2e 100644
@@ -12,6 +12,8 @@ u64 __sxe_rx_queue_offload_capa_get(struct rte_eth_dev *dev)
 
 	u64 offloads = 0;
 
+	offloads |= RTE_ETH_RX_OFFLOAD_VLAN_STRIP;
+
 	return offloads;
 }
 
@@ -23,6 +25,8 @@ u64 __sxe_rx_port_offload_capa_get(struct rte_eth_dev *dev)
 			RTE_ETH_RX_OFFLOAD_UDP_CKSUM   |
 			RTE_ETH_RX_OFFLOAD_TCP_CKSUM   |
 			RTE_ETH_RX_OFFLOAD_KEEP_CRC	|
+			RTE_ETH_RX_OFFLOAD_VLAN_FILTER |
+			RTE_ETH_RX_OFFLOAD_VLAN_EXTEND |
 			RTE_ETH_RX_OFFLOAD_SCATTER;
 
 	if (!RTE_ETH_DEV_SRIOV(dev).active)
drivers/net/sxe/pf/sxe_filter.c +277 -0

280 lines not on this page · raw message

drivers/net/sxe/pf/sxe_filter.h +13 -0
index 1f103f978d..51df05ac8e 100644
@@ -43,10 +43,23 @@ void sxe_mac_addr_remove(struct rte_eth_dev *dev, u32 rar_idx);
 s32 sxe_mac_addr_set(struct rte_eth_dev *dev,
 				 struct rte_ether_addr *mac_addr);
 
+s32 sxe_vlan_filter_set(struct rte_eth_dev *eth_dev, u16 vlan_id, s32 on);
+
+s32 sxe_vlan_tpid_set(struct rte_eth_dev *eth_dev,
+			enum rte_vlan_type vlan_type, u16 tpid);
+
+s32 sxe_vlan_offload_set(struct rte_eth_dev *dev, s32 vlan_mask);
+
+void sxe_vlan_strip_queue_set(struct rte_eth_dev *dev, u16 queue, s32 on);
+
+void sxe_vlan_filter_configure(struct rte_eth_dev *dev);
+
 s32 sxe_set_mc_addr_list(struct rte_eth_dev *dev,
 			  struct rte_ether_addr *mc_addr_list,
 			  u32 nb_mc_addr);
 
+void sxe_vlan_strip_switch_set(struct rte_eth_dev *dev);
+
 void sxe_fc_mac_addr_set(struct sxe_adapter *adapter);
 
 #endif
drivers/net/sxe/pf/sxe_main.c +2 -0
index cbc0edd2cd..2c69f95301 100644
@@ -152,6 +152,8 @@ s32 sxe_hw_reset(struct sxe_hw *hw)
 
 void sxe_hw_start(struct sxe_hw *hw)
 {
+	sxe_hw_vlan_filter_array_clear(hw);
+
 	sxe_fc_autoneg_localcap_set(hw);
 }
 
Signature · 1 line
2.18.2
#310 lore raw

PATCH v19 6/13 net/sxe: add filter function

In reply to [email protected]

From: Jie Liu <[email protected]>

Add filter function.

---
 drivers/net/sxe/pf/sxe_filter.c | 191 ++++++++++++++++++++++++++++++++
 drivers/net/sxe/pf/sxe_filter.h |  29 +++++
 drivers/net/sxe/pf/sxe_main.c   |   1 +
 3 files changed, 221 insertions(+)
drivers/net/sxe/pf/sxe_filter.c +191 -0
index 8e3f6b6b29..df583c960a 100644
@@ -82,6 +82,47 @@ static void sxe_default_mac_addr_get(struct sxe_adapter *adapter)
 	rte_ether_addr_copy(&mac_addr, &adapter->mac_filter_ctxt.fc_mac_addr);
 }
 
+static u8 sxe_sw_uc_entry_add(struct rte_eth_dev *eth_dev, u8 index,
+	u8 *mac_addr)
+{
+	u8 i, pool;
+	struct sxe_adapter *adapter = eth_dev->data->dev_private;
+	struct sxe_uc_addr_table *uc_table = adapter->mac_filter_ctxt.uc_addr_table;
+
+	pool = sxe_vf_num_get(eth_dev);
+	for (i = 0; i < SXE_UC_ENTRY_NUM_MAX; i++) {
+		if (!uc_table[i].used) {
+			uc_table[i].pool_idx = pool;
+			uc_table[i].used = true;
+			uc_table[i].rar_idx = i;
+			uc_table[i].original_index = index;
+			uc_table[i].type = SXE_PF;
+			rte_memcpy(uc_table[i].addr, mac_addr, SXE_MAC_ADDR_LEN);
+			break;
+		}
+	}
+
+	return i;
+}
+
+static u8 sxe_sw_uc_entry_del(struct sxe_adapter *adapter, u8 index)
+{
+	u8 i;
+	struct sxe_uc_addr_table *uc_table = adapter->mac_filter_ctxt.uc_addr_table;
+
+	for (i = 0; i < SXE_UC_ENTRY_NUM_MAX; i++) {
+		if (!uc_table[i].used || uc_table[i].type != SXE_PF)
+			continue;
+
+		if (uc_table[i].original_index == index) {
+			uc_table[i].used = false;
+			break;
+		}
+	}
+
+	return i;
+}
+
 s32 sxe_mac_addr_init(struct rte_eth_dev *eth_dev)
 {
 	struct sxe_adapter *adapter = eth_dev->data->dev_private;
@@ -149,6 +190,156 @@ s32 sxe_mac_addr_init(struct rte_eth_dev *eth_dev)
 	goto l_out;
 }
 
+static void sxe_pf_promisc_mac_update(struct rte_eth_dev *dev, bool enable)
+{
+	struct sxe_adapter *adapter = dev->data->dev_private;
+	struct sxe_uc_addr_table *uc_table = adapter->mac_filter_ctxt.uc_addr_table;
+	u16 pf_pool = sxe_vf_num_get(dev);
+	s32 i;
+
+	for (i = 0; i < SXE_UC_ENTRY_NUM_MAX; i++) {
+		if (uc_table[i].used && uc_table[i].type != SXE_PF) {
+			if (enable)
+				sxe_hw_uc_addr_pool_enable(&adapter->hw,
+					uc_table[i].rar_idx, pf_pool);
+			else
+				sxe_hw_uc_addr_pool_del(&adapter->hw,
+					uc_table[i].rar_idx, pf_pool);
+		}
+	}
+}
+
+s32 sxe_promiscuous_enable(struct rte_eth_dev *dev)
+{
+	struct sxe_adapter *adapter = dev->data->dev_private;
+	struct sxe_hw *hw = &adapter->hw;
+	u32 flt_ctrl;
+	u32 vm_l2_ctrl = 0;
+	u16 vf_num;
+
+	flt_ctrl = sxe_hw_rx_mode_get(hw);
+	PMD_LOG_DEBUG(DRV, "read flt_ctrl=0x%x", flt_ctrl);
+
+	flt_ctrl |= (SXE_FCTRL_UPE | SXE_FCTRL_MPE);
+
+	vf_num = sxe_vf_num_get(dev);
+	if (vf_num != 0) {
+		vm_l2_ctrl = sxe_hw_pool_rx_mode_get(hw, vf_num) |
+				SXE_VMOLR_ROMPE | SXE_VMOLR_MPE;
+		sxe_hw_pool_rx_mode_set(hw, vm_l2_ctrl, vf_num);
+
+		sxe_pf_promisc_mac_update(dev, true);
+	}
+
+	PMD_LOG_DEBUG(DRV, "write flt_ctrl=0x%x vmolr=0x%x", flt_ctrl, vm_l2_ctrl);
+	sxe_hw_rx_mode_set(hw, flt_ctrl);
+	adapter->mac_filter_ctxt.promiscuous_mode = true;
+
+	return 0;
+}
+
+s32 sxe_promiscuous_disable(struct rte_eth_dev *dev)
+{
+	struct sxe_adapter *adapter = dev->data->dev_private;
+	struct sxe_hw *hw = &adapter->hw;
+	u32 flt_ctrl;
+	u32 vm_l2_ctrl = 0;
+	u16 vf_num;
+
+	flt_ctrl = sxe_hw_rx_mode_get(hw);
+	PMD_LOG_DEBUG(DRV, "read flt_ctrl=0x%x", flt_ctrl);
+
+	flt_ctrl &= (~SXE_FCTRL_UPE);
+	if (dev->data->all_multicast == 1)
+		flt_ctrl |= SXE_FCTRL_MPE;
+	else
+		flt_ctrl &= (~SXE_FCTRL_MPE);
+
+	vf_num = sxe_vf_num_get(dev);
+	if (vf_num != 0) {
+		vm_l2_ctrl = sxe_hw_pool_rx_mode_get(hw, vf_num);
+		if (dev->data->all_multicast == 0) {
+			vm_l2_ctrl &= ~SXE_VMOLR_MPE;
+			if ((sxe_hw_mc_filter_get(hw) & SXE_MCSTCTRL_MFE) == 0)
+				vm_l2_ctrl &= ~SXE_VMOLR_ROMPE;
+		}
+		sxe_hw_pool_rx_mode_set(hw, vm_l2_ctrl, vf_num);
+		sxe_pf_promisc_mac_update(dev, false);
+	}
+
+	PMD_LOG_DEBUG(DRV, "write flt_ctrl=0x%x vmolr=0x%x", flt_ctrl, vm_l2_ctrl);
+	sxe_hw_rx_mode_set(hw, flt_ctrl);
+	adapter->mac_filter_ctxt.promiscuous_mode = false;
+
+	return 0;
+}
+
+s32 sxe_allmulticast_enable(struct rte_eth_dev *dev)
+{
+	struct sxe_adapter *adapter = dev->data->dev_private;
+	struct sxe_hw *hw = &adapter->hw;
+	u32 flt_ctrl;
+	u32 vm_l2_ctrl = 0;
+	u16 vf_num;
+
+	flt_ctrl = sxe_hw_rx_mode_get(hw);
+	PMD_LOG_DEBUG(DRV, "read flt_ctrl=0x%x", flt_ctrl);
+
+	flt_ctrl |= SXE_FCTRL_MPE;
+
+	PMD_LOG_DEBUG(DRV, "write flt_ctrl=0x%x", flt_ctrl);
+	sxe_hw_rx_mode_set(hw, flt_ctrl);
+
+	vf_num = sxe_vf_num_get(dev);
+	if (vf_num != 0) {
+		vm_l2_ctrl = sxe_hw_pool_rx_mode_get(hw, vf_num) |
+				SXE_VMOLR_MPE | SXE_VMOLR_ROMPE;
+		sxe_hw_pool_rx_mode_set(hw, vm_l2_ctrl, vf_num);
+	}
+
+	PMD_LOG_DEBUG(DRV, "write flt_ctrl=0x%x vmolr=0x%x",
+			flt_ctrl, vm_l2_ctrl);
+
+	return 0;
+}
+
+s32 sxe_allmulticast_disable(struct rte_eth_dev *dev)
+{
+	struct sxe_adapter *adapter = dev->data->dev_private;
+	struct sxe_hw *hw = &adapter->hw;
+	u32 flt_ctrl;
+	u32 vm_l2_ctrl = 0;
+	u16 vf_num;
+
+	if (dev->data->promiscuous == 1) {
+		PMD_LOG_DEBUG(DRV, "promiscuous is enable, allmulticast must be enabled.");
+		goto l_out;
+	}
+
+	flt_ctrl = sxe_hw_rx_mode_get(hw);
+	PMD_LOG_DEBUG(DRV, "read flt_ctrl=0x%x", flt_ctrl);
+
+	flt_ctrl &= (~SXE_FCTRL_MPE);
+
+	vf_num = sxe_vf_num_get(dev);
+	if (vf_num != 0) {
+		vm_l2_ctrl = sxe_hw_pool_rx_mode_get(hw, vf_num) &
+					(~SXE_VMOLR_MPE);
+		if ((sxe_hw_mc_filter_get(hw) & SXE_MCSTCTRL_MFE) == 0)
+			vm_l2_ctrl &= ~SXE_VMOLR_ROMPE;
+
+		sxe_hw_pool_rx_mode_set(hw, vm_l2_ctrl, vf_num);
+	} else {
+		sxe_hw_rx_mode_set(hw, flt_ctrl);
+	}
+
+	PMD_LOG_DEBUG(DRV, "write flt_ctrl=0x%x vmolr=0x%x",
+			flt_ctrl, vm_l2_ctrl);
+
+l_out:
+	return 0;
+}
+
 s32 sxe_mac_addr_add(struct rte_eth_dev *dev,
 				 struct rte_ether_addr *mac_addr,
 				 u32 index, u32 pool)
drivers/net/sxe/pf/sxe_filter.h +29 -0
index 51df05ac8e..2b7c91a9bd 100644
@@ -18,6 +18,27 @@ struct sxe_adapter;
 		RTE_ALIGN((SXE_HW_TXRX_RING_NUM_MAX / (sizeof(u32) * BYTE_BIT_NUM)), \
 		sizeof(u32))
 
+struct sxe_vlan_context {
+	u32 vlan_hash_table[SXE_VFT_TBL_SIZE];
+	u32 strip_bitmap[SXE_VLAN_STRIP_BITMAP_SIZE];
+	u32  vlan_table_size;
+};
+
+enum sxe_uc_addr_src_type {
+	SXE_PF = 0,
+	SXE_VF,
+	SXE_VF_MACVLAN
+};
+
+struct sxe_uc_addr_table {
+	u8 rar_idx;
+	u8 pool_idx;
+	u8 type;
+	u8 original_index;
+	bool used;
+	u8 addr[SXE_MAC_ADDR_LEN];
+};
+
 struct sxe_mac_filter_context {
 	struct rte_ether_addr def_mac_addr;
 	struct rte_ether_addr cur_mac_addr;
@@ -34,6 +55,14 @@ struct sxe_mac_filter_context {
 
 s32 sxe_mac_addr_init(struct rte_eth_dev *eth_dev);
 
+s32 sxe_promiscuous_enable(struct rte_eth_dev *dev);
+
+s32 sxe_promiscuous_disable(struct rte_eth_dev *dev);
+
+s32 sxe_allmulticast_enable(struct rte_eth_dev *dev);
+
+s32 sxe_allmulticast_disable(struct rte_eth_dev *dev);
+
 s32 sxe_mac_addr_add(struct rte_eth_dev *dev,
 				 struct rte_ether_addr *mac_addr,
 				 u32 rar_idx, u32 pool);
drivers/net/sxe/pf/sxe_main.c +1 -0
index 2c69f95301..79b37fe117 100644
@@ -146,6 +146,7 @@ s32 sxe_hw_reset(struct sxe_hw *hw)
 		goto l_end;
 	}
 
+	sxe_hw_uc_addr_clear(hw);
 l_end:
 	return ret;
 }
Signature · 1 line
2.18.2
#311 lore raw

PATCH v19 7/13 net/sxe: support rss offload

In reply to [email protected]

From: Jie Liu <[email protected]>

Support rss offload.

---
 drivers/net/sxe/base/sxe_offload_common.c |   3 +-
 drivers/net/sxe/pf/sxe_offload.c          | 299 ++++++++++++++++++++++
 drivers/net/sxe/pf/sxe_offload.h          |  33 +++
 3 files changed, 334 insertions(+), 1 deletion(-)
drivers/net/sxe/base/sxe_offload_common.c +2 -1
index f7c7363a2e..4eb4e03a4d 100644
@@ -27,7 +27,8 @@ u64 __sxe_rx_port_offload_capa_get(struct rte_eth_dev *dev)
 			RTE_ETH_RX_OFFLOAD_KEEP_CRC	|
 			RTE_ETH_RX_OFFLOAD_VLAN_FILTER |
 			RTE_ETH_RX_OFFLOAD_VLAN_EXTEND |
-			RTE_ETH_RX_OFFLOAD_SCATTER;
+			RTE_ETH_RX_OFFLOAD_SCATTER |
+			RTE_ETH_RX_OFFLOAD_RSS_HASH;
 
 	if (!RTE_ETH_DEV_SRIOV(dev).active)
 		rx_offload_capa |= RTE_ETH_RX_OFFLOAD_TCP_LRO;
drivers/net/sxe/pf/sxe_offload.c +299 -0

313 lines not on this page · raw message

drivers/net/sxe/pf/sxe_offload.h +33 -0
index a70d6bf94b..458b6464c5 100644
@@ -7,6 +7,21 @@
 
 #include "sxe_hw.h"
 
+#define SXE_RSS_OFFLOAD_ALL ( \
+		RTE_ETH_RSS_IPV4 | \
+		RTE_ETH_RSS_NONFRAG_IPV4_TCP | \
+		RTE_ETH_RSS_NONFRAG_IPV4_UDP | \
+		RTE_ETH_RSS_IPV6 | \
+		RTE_ETH_RSS_NONFRAG_IPV6_TCP | \
+		RTE_ETH_RSS_NONFRAG_IPV6_UDP)
+
+#if defined SXE_DPDK_L4_FEATURES && defined SXE_DPDK_FILTER_CTRL
+u8 *sxe_rss_hash_key_get(void);
+#endif
+
+void sxe_rss_hash_set(struct sxe_hw *hw,
+				struct rte_eth_rss_conf *rss_conf);
+
 u64 sxe_rx_queue_offload_capa_get(struct rte_eth_dev *dev);
 
 u64 sxe_rx_port_offload_capa_get(struct rte_eth_dev *dev);
@@ -15,4 +30,22 @@ u64 sxe_tx_queue_offload_capa_get(struct rte_eth_dev *dev);
 
 u64 sxe_tx_port_offload_capa_get(struct rte_eth_dev *dev);
 
+void sxe_rss_disable(struct rte_eth_dev *dev);
+
+void sxe_rss_configure(struct rte_eth_dev *dev);
+
+s32 sxe_rss_reta_update(struct rte_eth_dev *dev,
+			struct rte_eth_rss_reta_entry64 *reta_conf,
+			u16 reta_size);
+
+s32 sxe_rss_reta_query(struct rte_eth_dev *dev,
+			 struct rte_eth_rss_reta_entry64 *reta_conf,
+			 u16 reta_size);
+
+s32 sxe_rss_hash_update(struct rte_eth_dev *dev,
+			struct rte_eth_rss_conf *rss_conf);
+
+s32 sxe_rss_hash_conf_get(struct rte_eth_dev *dev,
+				struct rte_eth_rss_conf *rss_conf);
+
 #endif
Signature · 1 line
2.18.2
#312 lore raw

PATCH v19 8/13 net/sxe: add dcb function

In reply to [email protected]

From: Jie Liu <[email protected]>

Add dcb function.

---
 drivers/net/sxe/meson.build      |  28 +
 drivers/net/sxe/pf/rte_pmd_sxe.h |   4 +
 drivers/net/sxe/pf/sxe_dcb.c     | 945 +++++++++++++++++++++++++++++++
 drivers/net/sxe/pf/sxe_dcb.h     |  99 ++++
 drivers/net/sxe/pf/sxe_main.c    |   1 +
 drivers/net/sxe/pf/sxe_phy.c     |  34 ++
 drivers/net/sxe/pf/sxe_phy.h     |   2 +
 7 files changed, 1113 insertions(+)
 create mode 100644 drivers/net/sxe/pf/sxe_dcb.c
 create mode 100644 drivers/net/sxe/pf/sxe_dcb.h
drivers/net/sxe/meson.build +28 -0
index 251eeced94..818778aa35 100644
@@ -5,8 +5,12 @@ if not is_linux or not (dpdk_conf.has('RTE_ARCH_X86_64') or dpdk_conf.has('RTE_A
     reason = 'only supported on x86_64 or arm64 Linux'
     subdir_done()
 endif
+
 cflags += ['-DSXE_DPDK']
 cflags += ['-DSXE_HOST_DRIVER']
+cflags += ['-DSXE_DPDK_L4_FEATURES']
+cflags += ['-DSXE_DPDK_SRIOV']
+cflags += ['-DSXE_DPDK_SIMD']
 
 #subdir('base')
 #objs = [base_objs]
@@ -21,17 +25,41 @@ sources = files(
         'pf/sxe_queue.c',
         'pf/sxe_rx.c',
         'pf/sxe_tx.c',
+        'pf/sxe_stats.c',
         'pf/sxe_pmd_hdc.c',
         'pf/sxe_phy.c',
+        'pf/sxe_ptp.c',
+        'pf/sxe_vf.c',
+        'pf/sxe_dcb.c',
+        'vf/sxevf_main.c',
+        'vf/sxevf_filter.c',
+        'vf/sxevf_irq.c',
+        'vf/sxevf_msg.c',
+        'vf/sxevf_ethdev.c',
+        'vf/sxevf_stats.c',
+        'vf/sxevf_rx.c',
+        'vf/sxevf_tx.c',
+        'vf/sxevf_queue.c',
+        'vf/sxevf_offload.c',
         'base/sxe_queue_common.c',
         'base/sxe_rx_common.c',
         'base/sxe_tx_common.c',
         'base/sxe_offload_common.c',
         'base/sxe_common.c',
         'base/sxe_hw.c',
+        'base/sxevf_hw.c',
 )
 
+testpmd_sources = files('sxe_testpmd.c')
+
+if arch_subdir == 'x86'
+    sources += files('pf/sxe_vec_sse.c')
+elif arch_subdir == 'arm'
+    sources += files('pf/sxe_vec_neon.c')
+endif
+
 includes += include_directories('base')
 includes += include_directories('pf')
+includes += include_directories('vf')
 includes += include_directories('include/sxe/')
 includes += include_directories('include/')
drivers/net/sxe/pf/rte_pmd_sxe.h +4 -0
index 64c1140490..25e768624f 100644
@@ -5,10 +5,14 @@
 #ifndef __PMD_SXE_H__
 #define __PMD_SXE_H__
 
+#include <rte_compat.h>
+
 typedef uint8_t		u8;
 typedef uint16_t	u16;
 typedef uint32_t	u32;
 typedef int32_t		s32;
 
 s32 rte_pmd_sxe_tx_loopback_set(u16 port, u8 on);
+__rte_experimental
+s32 rte_pmd_sxe_tc_bw_set(u8 port, u8 tc_num, u8 *bw_weight);
 #endif
drivers/net/sxe/pf/sxe_dcb.c new file +945 -0

945 lines not on this page · raw message

drivers/net/sxe/pf/sxe_dcb.h new file +99 -0

99 lines not on this page · raw message

drivers/net/sxe/pf/sxe_main.c +1 -0
index 79b37fe117..e3f4d466a4 100644
@@ -154,6 +154,7 @@ s32 sxe_hw_reset(struct sxe_hw *hw)
 void sxe_hw_start(struct sxe_hw *hw)
 {
 	sxe_hw_vlan_filter_array_clear(hw);
+	sxe_hw_dcb_rate_limiter_clear(hw, SXE_TXRX_RING_NUM_MAX);
 
 	sxe_fc_autoneg_localcap_set(hw);
 }
drivers/net/sxe/pf/sxe_phy.c +34 -0
index e681a41ecf..eebebe7ee9 100644
@@ -724,6 +724,40 @@ s32 sxe_fc_enable(struct sxe_adapter *adapter)
 	return ret;
 }
 
+s32 sxe_pfc_enable(struct sxe_adapter *adapter, u8 tc_idx)
+{
+	s32 ret;
+	struct sxe_hw *hw = &adapter->hw;
+
+	if (!hw->fc.pause_time) {
+		LOG_ERROR_BDF("link fc disabled since pause time is 0");
+		ret = -SXE_ERR_INVALID_LINK_SETTINGS;
+		goto l_ret;
+	}
+
+	if (hw->fc.current_mode & SXE_FC_TX_PAUSE) {
+		if (!hw->fc.high_water[tc_idx] || !hw->fc.low_water[tc_idx]) {
+			LOG_ERROR_BDF("Invalid water mark configuration");
+			ret = SXE_ERR_INVALID_LINK_SETTINGS;
+			goto l_ret;
+		}
+
+		if (hw->fc.low_water[tc_idx] >= hw->fc.high_water[tc_idx]) {
+			LOG_ERROR_BDF("Invalid water mark configuration");
+			ret = SXE_ERR_INVALID_LINK_SETTINGS;
+			goto l_ret;
+		}
+	}
+
+	sxe_fc_autoneg(adapter);
+
+	ret = sxe_hw_pfc_enable(hw, tc_idx);
+	if (ret)
+		PMD_LOG_ERR(INIT, "link fc enable failed, ret=%d", ret);
+
+l_ret:
+	return ret;
+}
 s32 sxe_sfp_identify(struct sxe_adapter *adapter)
 {
 	s32 ret;
drivers/net/sxe/pf/sxe_phy.h +2 -0
index b2127e6064..0dd2ad2d95 100644
@@ -104,6 +104,8 @@ s32 sxe_fc_enable(struct sxe_adapter *adapter);
 
 void sxe_link_info_get(struct sxe_adapter *adapter, u32 *link_speed, bool *link_up);
 
+s32 sxe_pfc_enable(struct sxe_adapter *adapter, u8 tc_idx);
+
 void sxe_sfp_link_capabilities_get(struct sxe_adapter *adapter, u32 *speed,
 							bool *autoneg);
 
Signature · 1 line
2.18.2
#313 lore raw

PATCH v19 9/13 net/sxe: support ptp

In reply to [email protected]

From: Jie Liu <[email protected]>

Add ptp module.

---
 drivers/net/sxe/pf/sxe_ptp.c | 209 +++++++++++++++++++++++++++++++++++
 drivers/net/sxe/pf/sxe_ptp.h |  26 +++++
 2 files changed, 235 insertions(+)
 create mode 100644 drivers/net/sxe/pf/sxe_ptp.c
 create mode 100644 drivers/net/sxe/pf/sxe_ptp.h
drivers/net/sxe/pf/sxe_ptp.c new file +209 -0
new file mode 100644
index 0000000000..4116dbb37e
@@ -0,0 +1,209 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (C), 2022, Linkdata Technology Co., Ltd.
+ */
+
+#include "sxe.h"
+#include "sxe_logs.h"
+#include "sxe_hw.h"
+#include "sxe_ptp.h"
+
+#define SXE_CYCLECOUNTER_MASK   0xffffffffffffffffULL
+
+static void sxe_timecounters_start(struct rte_eth_dev *dev)
+{
+	struct sxe_adapter *adapter = dev->data->dev_private;
+
+	u32 shift = 0;
+
+	memset(&adapter->ptp_ctxt.systime_tc, 0, sizeof(struct rte_timecounter));
+	memset(&adapter->ptp_ctxt.rx_tstamp_tc, 0, sizeof(struct rte_timecounter));
+	memset(&adapter->ptp_ctxt.tx_tstamp_tc, 0, sizeof(struct rte_timecounter));
+
+	adapter->ptp_ctxt.systime_tc.cc_mask = SXE_CYCLECOUNTER_MASK;
+	adapter->ptp_ctxt.systime_tc.cc_shift = shift;
+	adapter->ptp_ctxt.systime_tc.nsec_mask = (1ULL << shift) - 1;
+
+	adapter->ptp_ctxt.rx_tstamp_tc.cc_mask = SXE_CYCLECOUNTER_MASK;
+	adapter->ptp_ctxt.rx_tstamp_tc.cc_shift = shift;
+	adapter->ptp_ctxt.rx_tstamp_tc.nsec_mask = (1ULL << shift) - 1;
+
+	adapter->ptp_ctxt.tx_tstamp_tc.cc_mask = SXE_CYCLECOUNTER_MASK;
+	adapter->ptp_ctxt.tx_tstamp_tc.cc_shift = shift;
+	adapter->ptp_ctxt.tx_tstamp_tc.nsec_mask = (1ULL << shift) - 1;
+
+	adapter->ptp_ctxt.tx_hwtstamp_nsec = 0;
+	adapter->ptp_ctxt.tx_hwtstamp_sec = 0;
+}
+
+s32 sxe_timesync_enable(struct rte_eth_dev *dev)
+{
+	struct sxe_adapter *adapter = dev->data->dev_private;
+	struct sxe_hw *hw = &adapter->hw;
+	u32 tses = SXE_TSES_TXES_V2_ALL | SXE_TSES_RXES_V2_ALL;
+
+	struct timespec ts;
+
+	memset(&ts, 0, sizeof(struct timespec));
+
+	clock_gettime(CLOCK_REALTIME, &ts);
+
+	sxe_hw_ptp_init(hw);
+
+
+	sxe_hw_ptp_timestamp_mode_set(hw, true, 0, tses);
+
+	sxe_hw_ptp_timestamp_enable(hw);
+
+	sxe_hw_ptp_rx_timestamp_clear(hw);
+
+	sxe_hw_ptp_systime_init(hw);
+
+	sxe_timecounters_start(dev);
+
+
+	sxe_timesync_write_time(dev, &ts);
+
+	return 0;
+}
+
+s32 sxe_timesync_disable(struct rte_eth_dev *dev)
+{
+	struct sxe_adapter *adapter = dev->data->dev_private;
+	struct sxe_hw *hw = &adapter->hw;
+
+	sxe_hw_ptp_timestamp_disable(hw);
+
+	sxe_hw_ptp_timestamp_mode_set(hw, false, 0, 0);
+
+	sxe_hw_ptp_time_inc_stop(hw);
+
+	return 0;
+}
+
+s32 sxe_timesync_read_rx_timestamp(struct rte_eth_dev *dev,
+				 struct timespec *timestamp,
+				 u32 flags __rte_unused)
+{
+	struct sxe_adapter *adapter = dev->data->dev_private;
+	struct sxe_hw *hw = &adapter->hw;
+	u64 ns;
+	s32 ret = 0;
+	bool is_valid;
+	u64 rx_tstamp_cycles;
+
+	is_valid = sxe_hw_ptp_is_rx_timestamp_valid(hw);
+	if (!is_valid) {
+		PMD_LOG_ERR(DRV, "no valid ptp timestamp in rx register");
+		ret = -EINVAL;
+		goto l_end;
+	}
+
+	rx_tstamp_cycles = sxe_hw_ptp_rx_timestamp_get(hw);
+	ns = rte_timecounter_update(&adapter->ptp_ctxt.rx_tstamp_tc, rx_tstamp_cycles);
+	PMD_LOG_DEBUG(DRV, "got rx_tstamp_cycles = %" SXE_PRIU64 "ns=%" SXE_PRIU64,
+			rx_tstamp_cycles, ns);
+	*timestamp = rte_ns_to_timespec(ns);
+
+l_end:
+	return ret;
+}
+
+static u64 sxe_timesync_tx_tstamp_cycles_get(struct sxe_adapter *adapter)
+{
+	return SXE_TIME_TO_NS(adapter->ptp_ctxt.tx_hwtstamp_nsec,
+				adapter->ptp_ctxt.tx_hwtstamp_sec);
+}
+
+s32 sxe_timesync_read_tx_timestamp(struct rte_eth_dev *dev,
+				 struct timespec *timestamp)
+{
+	struct sxe_adapter *adapter = dev->data->dev_private;
+	struct sxe_hw *hw = &adapter->hw;
+	u64 ns;
+	s32 ret = 0;
+	u64 tx_tstamp_cycles;
+	u32 ts_sec;
+	u32 ts_ns;
+	u32 last_sec;
+	u32 last_ns;
+	bool tx_tstamp_valid = true;
+	u8 i;
+
+	sxe_hw_ptp_tx_timestamp_get(hw, &ts_sec, &ts_ns);
+	if (ts_ns  != adapter->ptp_ctxt.tx_hwtstamp_nsec ||
+		ts_sec != adapter->ptp_ctxt.tx_hwtstamp_sec) {
+		for (i = 0; i < SXE_TXTS_POLL_CHECK; i++)
+			sxe_hw_ptp_tx_timestamp_get(hw, &last_sec, &last_ns);
+
+		for (; i < SXE_TXTS_POLL; i++) {
+			sxe_hw_ptp_tx_timestamp_get(hw, &ts_sec, &ts_ns);
+			if (last_ns != ts_ns || last_sec != ts_sec) {
+				tx_tstamp_valid = false;
+				break;
+			}
+		}
+	}
+
+	if (!tx_tstamp_valid || (ts_ns == adapter->ptp_ctxt.tx_hwtstamp_nsec &&
+			ts_sec == adapter->ptp_ctxt.tx_hwtstamp_sec)) {
+		PMD_LOG_DEBUG(DRV, "no valid ptp timestamp in tx register");
+		ret = -EINVAL;
+		goto l_end;
+	} else {
+		adapter->ptp_ctxt.tx_hwtstamp_nsec = ts_ns;
+		adapter->ptp_ctxt.tx_hwtstamp_sec  = ts_sec;
+		tx_tstamp_cycles =
+			sxe_timesync_tx_tstamp_cycles_get(adapter);
+		ns = rte_timecounter_update(&adapter->ptp_ctxt.tx_tstamp_tc,
+						tx_tstamp_cycles);
+		PMD_LOG_DEBUG(DRV, "got tx_tstamp_cycles = %"
+			SXE_PRIU64 "ns=%" SXE_PRIU64, tx_tstamp_cycles, ns);
+		*timestamp = rte_ns_to_timespec(ns);
+	}
+
+l_end:
+	return ret;
+}
+
+s32 sxe_timesync_adjust_time(struct rte_eth_dev *dev, s64 delta)
+{
+	struct sxe_adapter *adapter = dev->data->dev_private;
+
+	PMD_LOG_DEBUG(DRV, "got delta = %" SXE_PRID64, delta);
+
+	adapter->ptp_ctxt.systime_tc.nsec += delta;
+	adapter->ptp_ctxt.rx_tstamp_tc.nsec += delta;
+	adapter->ptp_ctxt.tx_tstamp_tc.nsec += delta;
+
+	return 0;
+}
+
+s32 sxe_timesync_read_time(struct rte_eth_dev *dev, struct timespec *ts)
+{
+	struct sxe_adapter *adapter = dev->data->dev_private;
+	struct sxe_hw *hw = &adapter->hw;
+	u64 ns, systime_cycles;
+
+	systime_cycles = sxe_hw_ptp_systime_get(hw);
+	ns = rte_timecounter_update(&adapter->ptp_ctxt.systime_tc, systime_cycles);
+	PMD_LOG_DEBUG(DRV, "got systime_cycles = %" SXE_PRIU64 "ns=%" SXE_PRIU64,
+			systime_cycles, ns);
+	*ts = rte_ns_to_timespec(ns);
+
+	return 0;
+}
+
+s32 sxe_timesync_write_time(struct rte_eth_dev *dev,
+					const struct timespec *ts)
+{
+	u64 ns;
+	struct sxe_adapter *adapter = dev->data->dev_private;
+
+	ns = rte_timespec_to_ns(ts);
+	PMD_LOG_DEBUG(DRV, "set systime ns = %" SXE_PRIU64, ns);
+	adapter->ptp_ctxt.systime_tc.nsec = ns;
+	adapter->ptp_ctxt.rx_tstamp_tc.nsec = ns;
+	adapter->ptp_ctxt.tx_tstamp_tc.nsec = ns;
+
+	return 0;
+}
drivers/net/sxe/pf/sxe_ptp.h new file +26 -0
new file mode 100644
index 0000000000..14971b2d50
@@ -0,0 +1,26 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (C), 2022, Linkdata Technology Co., Ltd.
+ */
+
+#ifndef __SXE_PTP_H__
+#define __SXE_PTP_H__
+
+s32 sxe_timesync_enable(struct rte_eth_dev *dev);
+
+s32 sxe_timesync_disable(struct rte_eth_dev *dev);
+
+s32 sxe_timesync_read_rx_timestamp(struct rte_eth_dev *dev,
+				 struct timespec *timestamp,
+				 u32 flags __rte_unused);
+
+s32 sxe_timesync_read_tx_timestamp(struct rte_eth_dev *dev,
+				 struct timespec *timestamp);
+
+s32 sxe_timesync_adjust_time(struct rte_eth_dev *dev, s64 delta);
+
+s32 sxe_timesync_read_time(struct rte_eth_dev *dev, struct timespec *ts);
+
+s32 sxe_timesync_write_time(struct rte_eth_dev *dev,
+					const struct timespec *ts);
+
+#endif
Signature · 1 line
2.18.2
#314 lore raw

PATCH v19 10/13 net/sxe: add xstats function

In reply to [email protected]

From: Jie Liu <[email protected]>

Add xstats function.

---
 drivers/net/sxe/pf/sxe_main.c  |   7 +
 drivers/net/sxe/pf/sxe_stats.c | 586 +++++++++++++++++++++++++++++++++
 drivers/net/sxe/pf/sxe_stats.h |  69 ++++
 3 files changed, 662 insertions(+)
 create mode 100644 drivers/net/sxe/pf/sxe_stats.c
 create mode 100644 drivers/net/sxe/pf/sxe_stats.h
drivers/net/sxe/pf/sxe_main.c +7 -0
index e3f4d466a4..4950ba24ef 100644
@@ -19,10 +19,12 @@
 #include "sxe_ethdev.h"
 #include "sxe.h"
 #include "drv_msg.h"
+#include "sxe_cli.h"
 #include "sxe_queue.h"
 #include "sxe_errno.h"
 #include "sxe_compat_platform.h"
 #include "sxe_pmd_hdc.h"
+#include "sxe_vf.h"
 #include "sxe_queue.h"
 
 static const struct rte_pci_id sxe_pci_tbl[] = {
@@ -154,6 +156,11 @@ s32 sxe_hw_reset(struct sxe_hw *hw)
 void sxe_hw_start(struct sxe_hw *hw)
 {
 	sxe_hw_vlan_filter_array_clear(hw);
+
+	sxe_hw_stats_regs_clean(hw);
+
+	sxe_hw_no_snoop_disable(hw);
+
 	sxe_hw_dcb_rate_limiter_clear(hw, SXE_TXRX_RING_NUM_MAX);
 
 	sxe_fc_autoneg_localcap_set(hw);
drivers/net/sxe/pf/sxe_stats.c new file +586 -0

586 lines not on this page · raw message

drivers/net/sxe/pf/sxe_stats.h new file +69 -0

69 lines not on this page · raw message

Signature · 1 line
2.18.2
#315 lore raw

PATCH v19 11/13 net/sxe: add custom cmd led ctrl

In reply to [email protected]

From: Jie Liu <[email protected]>

Add custom cmd led ctrl.

---
 drivers/net/sxe/include/sxe/sxe_cli.h   | 218 ++++++++++++++++++++++++
 drivers/net/sxe/include/sxe/sxe_ioctl.h |  21 +++
 drivers/net/sxe/sxe_testpmd.c           |  66 +++++++
 3 files changed, 305 insertions(+)
 create mode 100644 drivers/net/sxe/include/sxe/sxe_cli.h
 create mode 100644 drivers/net/sxe/include/sxe/sxe_ioctl.h
 create mode 100644 drivers/net/sxe/sxe_testpmd.c
drivers/net/sxe/include/sxe/sxe_cli.h new file +218 -0
new file mode 100644
index 0000000000..b278a67907
@@ -0,0 +1,218 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (C), 2022, Linkdata Technology Co., Ltd.
+ */
+
+#ifndef __SXE_CLI_H__
+#define __SXE_CLI_H__
+
+#ifdef SXE_HOST_DRIVER
+#include "sxe_drv_type.h"
+#endif
+
+#define SXE_CODE_VERSION_LEN			(32)
+#define SXE_MAC_NUM				(128)
+#define SXE_PORT_TRANSCEIVER_LEN		(32)
+#define SXE_PORT_VENDOR_LEN			(32)
+#define SXE_CHIP_TYPE_LEN			(32)
+#define SXE_VPD_SN_LEN				(16)
+#define SXE_SOC_RST_TIME			(0x93A80)
+#define SXE_SFP_TEMP_THRESHOLD_INTERVAL		(3)
+#define MGC_TERMLOG_INFO_MAX_LEN		(12 * 1024)
+#define SXE_REGS_DUMP_MAX_LEN			(12 * 1024)
+#define SXE_PRODUCT_NAME_LEN			(32)
+
+typedef enum sxe_led_mode {
+	SXE_IDENTIFY_LED_BLINK_ON = 0,
+	SXE_IDENTIFY_LED_BLINK_OFF,
+	SXE_IDENTIFY_LED_ON,
+	SXE_IDENTIFY_LED_OFF,
+	SXE_IDENTIFY_LED_RESET,
+} sxe_led_mode_s;
+
+typedef struct sxe_led_ctrl {
+	U32	mode;
+	U32	duration;
+
+} sxe_led_ctrl_s;
+
+typedef struct sxe_led_ctrl_resp {
+	U32	ack;
+} sxe_led_ctrl_resp_s;
+
+typedef enum port_link_speed {
+	PORT_LINK_NO	= 0,
+	PORT_LINK_100M	= 1,
+	PORT_LINK_1G	= 2,
+	PORT_LINK_10G	= 3,
+} port_link_speed_e;
+
+typedef struct sys_soc_info {
+	S8	fw_ver[SXE_CODE_VERSION_LEN];
+	S8	opt_ver[SXE_CODE_VERSION_LEN];
+	U8	soc_status;
+	U8	pad[3];
+	S32	soc_temp;
+	U64	chipid;
+	S8	chip_type[SXE_CHIP_TYPE_LEN];
+	S8	pba[SXE_VPD_SN_LEN];
+	S8	product_name[SXE_PRODUCT_NAME_LEN];
+} sys_soc_info_s;
+
+typedef struct sys_port_info {
+	U64	mac[SXE_MAC_NUM];
+	U8	is_port_abs;
+	U8	link_stat;
+	U8	link_speed;
+
+
+	U8	is_sfp:1;
+	U8	is_get_info:1;
+	U8	rvd:6;
+	S8	optical_mod_temp;
+	U8	pad[3];
+	S8	transceiver_type[SXE_PORT_TRANSCEIVER_LEN];
+	S8	vendor_name[SXE_PORT_VENDOR_LEN];
+	S8	vendor_pn[SXE_PORT_VENDOR_LEN];
+} sys_port_info_s;
+
+typedef struct sys_info_resp {
+	sys_soc_info_s	soc_info;
+	sys_port_info_s	port_info;
+} sys_info_resp_s;
+
+typedef enum sfp_temp_td_mode {
+	SFP_TEMP_THRESHOLD_MODE_ALARM   = 0,
+	SFP_TEMP_THRESHOLD_MODE_WARN,
+} sfp_temp_td_mode_e;
+
+typedef struct sfp_temp_td_set {
+	U8	mode;
+	U8	pad[3];
+	S8	hthreshold;
+	S8	lthreshold;
+} sfp_temp_td_set_s;
+
+typedef struct sxe_log_export_resp {
+	U16	cur_log_len;
+	U8	is_end;
+	U8	pad;
+	S32	session_id;
+	S8	data[0];
+} sxe_log_export_resp_s;
+
+typedef enum sxe_log_export_type  {
+	SXE_LOG_EXPORT_REQ	= 0,
+	SXE_LOG_EXPORT_FIN,
+	SXE_LOG_EXPORT_ABORT,
+} sxe_log_export_type_e;
+
+typedef struct sxe_log_export_req {
+	U8	is_all_log;
+	U8	cmdtype;
+	U8	is_begin;
+	U8	pad;
+	S32	session_id;
+	U32	log_len;
+} sxe_log_export_req_s;
+
+typedef struct soc_rst_req {
+	U32	time;
+} soc_rst_req_s;
+
+typedef struct regs_dump_resp {
+	U32	curdw_len;
+	U8	data[0];
+} regs_dump_resp_s;
+
+enum {
+	SXE_MFG_PART_NUMBER_LEN   = 8,
+	SXE_MFG_SERIAL_NUMBER_LEN = 16,
+	SXE_MFG_REVISION_LEN	  = 4,
+	SXE_MFG_OEM_STR_LEN	   = 64,
+	SXE_MFG_SXE_BOARD_ASSEMBLY_LEN  = 32,
+	SXE_MFG_SXE_BOARD_TRACE_NUM_LEN = 16,
+	SXE_MFG_SXE_MAC_ADDR_CNT		= 2,
+};
+
+typedef struct sxe_mfg_info {
+	U8 part_number[SXE_MFG_PART_NUMBER_LEN];
+	U8 serial_number[SXE_MFG_SERIAL_NUMBER_LEN];
+	U32 mfg_date;
+	U8 revision[SXE_MFG_REVISION_LEN];
+	U32 rework_date;
+	U8 pad[4];
+	U64 mac_addr[SXE_MFG_SXE_MAC_ADDR_CNT];
+	U8 board_trace_num[SXE_MFG_SXE_BOARD_TRACE_NUM_LEN];
+	U8 board_assembly[SXE_MFG_SXE_BOARD_ASSEMBLY_LEN];
+	U8 extra1[SXE_MFG_OEM_STR_LEN];
+	U8 extra2[SXE_MFG_OEM_STR_LEN];
+} sxe_mfg_info_t;
+
+typedef struct sxe_lldp_info {
+	U8	lldp_state;
+	U8	pad[3];
+} sxe_lldp_info_t;
+
+typedef struct regs_dump_req {
+	U32	base_addr;
+	U32	dw_len;
+} regs_dump_req_s;
+
+typedef enum sxe_pcs_mode {
+	SXE_PCS_MODE_1000BASE_KX_WO = 0,
+	SXE_PCS_MODE_1000BASE_KX_W,
+	SXE_PCS_MODE_SGMII,
+	SXE_PCS_MODE_10GBASE_KR_WO,
+	SXE_PCS_MODE_AUTO_NEGT_73,
+	SXE_PCS_MODE_LPBK_PHY_TX2RX,
+	SXE_PCS_MODE_LPBK_PHY_RX2TX,
+	SXE_PCS_MODE_LPBK_PCS_RX2TX,
+	SXE_PCS_MODE_BUTT,
+} sxe_pcs_mode_e;
+
+typedef enum sxe_remote_fault_mode {
+	SXE_REMOTE_FALUT_NO_ERROR		= 0,
+	SXE_REMOTE_FALUT_OFFLINE,
+	SXE_REMOTE_FALUT_LINK_FAILURE,
+	SXE_REMOTE_FALUT_AUTO_NEGOTIATION,
+	SXE_REMOTE_UNKNOWN,
+} sxe_remote_fault_e;
+
+typedef struct sxe_phy_cfg {
+	sxe_pcs_mode_e mode;
+	U32 mtu;
+} sxe_pcs_cfg_s;
+
+typedef enum sxe_an_speed {
+	SXE_AN_SPEED_NO_LINK = 0,
+	SXE_AN_SPEED_100M,
+	SXE_AN_SPEED_1G,
+	SXE_AN_SPEED_10G,
+	SXE_AN_SPEED_UNKNOWN,
+} sxe_an_speed_e;
+
+typedef enum sxe_phy_pause_cap {
+	SXE_PAUSE_CAP_NO_PAUSE	= 0,
+	SXE_PAUSE_CAP_ASYMMETRIC_PAUSE,
+	SXE_PAUSE_CAP_SYMMETRIC_PAUSE,
+	SXE_PAUSE_CAP_BOTH_PAUSE,
+	SXE_PAUSE_CAP_UNKNOWN,
+} sxe_phy_pause_cap_e;
+
+typedef enum sxe_phy_duplex_type {
+	SXE_FULL_DUPLEX	= 0,
+	SXE_HALF_DUPLEX	= 1,
+	SXE_UNKNOWN_DUPLEX,
+} sxe_phy_duplex_type_e;
+
+typedef struct sxe_phy_an_cap {
+	sxe_remote_fault_e   remote_fault;
+	sxe_phy_pause_cap_e  pause_cap;
+	sxe_phy_duplex_type_e duplex_cap;
+} sxe_phy_an_cap_s;
+
+typedef struct sxe_an_cap {
+	sxe_phy_an_cap_s local;
+	sxe_phy_an_cap_s peer;
+} sxe_an_cap_s;
+#endif
drivers/net/sxe/include/sxe/sxe_ioctl.h new file +21 -0
new file mode 100644
index 0000000000..4a4b0bc304
@@ -0,0 +1,21 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (C), 2022, Linkdata Technology Co., Ltd.
+ */
+#ifndef _SXE_IOCTL_H_
+#define _SXE_IOCTL_H_
+
+#ifdef SXE_HOST_DRIVER
+#include "sxe_drv_type.h"
+#endif
+
+struct sxe_ioctl_sync_cmd {
+	U64   traceid;
+	void *in_data;
+	U32   in_len;
+	void *out_data;
+	U32   out_len;
+};
+
+#define SXE_CMD_IOCTL_SYNC_CMD _IOWR('M', 1, struct sxe_ioctl_sync_cmd)
+
+#endif
drivers/net/sxe/sxe_testpmd.c new file +66 -0

66 lines not on this page · raw message

Signature · 1 line
2.18.2
#316 lore raw

PATCH v19 12/13 net/sxe: add simd function

In reply to [email protected]

From: Jie Liu <[email protected]>

Add simd function.

---
 drivers/net/sxe/base/sxe_queue_common.c |  52 +-
 drivers/net/sxe/base/sxe_rx_common.c    | 124 ++++-
 drivers/net/sxe/pf/sxe_vec_common.h     | 321 ++++++++++++
 drivers/net/sxe/pf/sxe_vec_neon.c       | 600 +++++++++++++++++++++++
 drivers/net/sxe/pf/sxe_vec_sse.c        | 622 ++++++++++++++++++++++++
 5 files changed, 1716 insertions(+), 3 deletions(-)
 create mode 100644 drivers/net/sxe/pf/sxe_vec_common.h
 create mode 100644 drivers/net/sxe/pf/sxe_vec_neon.c
 create mode 100644 drivers/net/sxe/pf/sxe_vec_sse.c
drivers/net/sxe/base/sxe_queue_common.c +51 -1
index da44270019..991b374667 100644
@@ -13,6 +13,10 @@
 #include "sxe_logs.h"
 #include "sxe_regs.h"
 #include "sxe.h"
+#if defined SXE_DPDK_L4_FEATURES && defined SXE_DPDK_SIMD
+#include "sxe_vec_common.h"
+#include <rte_vect.h>
+#endif
 #include "sxe_queue_common.h"
 #include "sxe_queue.h"
 
@@ -57,6 +61,10 @@ s32 __rte_cold __sxe_rx_queue_setup(struct rx_setup *rx_setup, bool is_vf)
 	u16 len;
 	u64 offloads;
 	s32 ret = 0;
+#if defined SXE_DPDK_L4_FEATURES && defined SXE_DPDK_SIMD
+	struct sxe_adapter *pf_adapter = dev->data->dev_private;
+	struct sxevf_adapter *vf_adapter = dev->data->dev_private;
+#endif
 
 	PMD_INIT_FUNC_TRACE();
 
@@ -161,6 +169,23 @@ s32 __rte_cold __sxe_rx_queue_setup(struct rx_setup *rx_setup, bool is_vf)
 				"dma_addr=0x%" SXE_PRIX64,
 			 rxq->buffer_ring, rxq->sc_buffer_ring, rxq->desc_ring,
 			 rxq->base_addr);
+
+#if defined SXE_DPDK_L4_FEATURES && defined SXE_DPDK_SIMD
+	if (!rte_is_power_of_2(desc_num)) {
+		PMD_LOG_DEBUG(INIT, "queue[%d] doesn't meet Vector Rx "
+					"preconditions - canceling the feature for "
+					"the whole port[%d]",
+				 rxq->queue_id, rxq->port_id);
+		if (is_vf)
+			vf_adapter->rx_vec_allowed = false;
+		else
+			pf_adapter->rx_vec_allowed = false;
+
+	} else {
+		sxe_rxq_vec_setup(rxq);
+	}
+#endif
+
 	dev->data->rx_queues[queue_idx] = rxq;
 
 	sxe_rx_queue_init(*rx_setup->rx_batch_alloc_allowed, rxq);
@@ -254,6 +279,9 @@ void __sxe_recycle_rxq_info_get(struct rte_eth_dev *dev, u16 queue_id,
 		struct rte_eth_recycle_rxq_info *q_info)
 {
 	struct sxe_rx_queue *rxq;
+#if defined SXE_DPDK_L4_FEATURES && defined SXE_DPDK_SIMD
+	struct sxe_adapter *adapter = dev->data->dev_private;
+#endif
 
 	rxq = dev->data->rx_queues[queue_id];
 
@@ -261,9 +289,21 @@ void __sxe_recycle_rxq_info_get(struct rte_eth_dev *dev, u16 queue_id,
 	q_info->mp = rxq->mb_pool;
 	q_info->mbuf_ring_size = rxq->ring_depth;
 	q_info->receive_tail = &rxq->processing_idx;
-
+#if defined SXE_DPDK_L4_FEATURES && defined SXE_DPDK_SIMD
+	if (adapter->rx_vec_allowed) {
+#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM)
+		q_info->refill_requirement = rxq->realloc_num;
+		q_info->refill_head = &rxq->realloc_start;
+#endif
+	} else {
+		q_info->refill_requirement = rxq->batch_alloc_size;
+		q_info->refill_head = &rxq->batch_alloc_trigger;
+	}
+#else
 	q_info->refill_requirement = rxq->batch_alloc_size;
 	q_info->refill_head = &rxq->batch_alloc_trigger;
+#endif
+	return;
 }
 
 void __sxe_tx_queue_info_get(struct rte_eth_dev *dev, u16 queue_id,
@@ -289,7 +329,17 @@ s32 __sxe_tx_done_cleanup(void *tx_queue, u32 free_cnt)
 	struct sxe_tx_queue *txq = (struct sxe_tx_queue *)tx_queue;
 	if (txq->offloads == 0 &&
 		txq->rs_thresh >= RTE_PMD_SXE_MAX_TX_BURST) {
+#if defined SXE_DPDK_L4_FEATURES && defined SXE_DPDK_SIMD
+		if (txq->rs_thresh <= RTE_SXE_MAX_TX_FREE_BUF_SZ &&
+			(rte_eal_process_type() != RTE_PROC_PRIMARY ||
+			txq->buffer_ring_vec != NULL)) {
+			ret = sxe_tx_done_cleanup_vec(txq, free_cnt);
+		} else {
+			ret = sxe_tx_done_cleanup_simple(txq, free_cnt);
+		}
+#else
 		ret = sxe_tx_done_cleanup_simple(txq, free_cnt);
+#endif
 
 	} else {
 		ret = sxe_tx_done_cleanup_full(txq, free_cnt);
drivers/net/sxe/base/sxe_rx_common.c +122 -2

173 lines not on this page · raw message

drivers/net/sxe/pf/sxe_vec_common.h new file +321 -0

321 lines not on this page · raw message

drivers/net/sxe/pf/sxe_vec_neon.c new file +600 -0

600 lines not on this page · raw message

drivers/net/sxe/pf/sxe_vec_sse.c new file +622 -0

622 lines not on this page · raw message

Signature · 1 line
2.18.2
#317 lore raw

PATCH v19 13/13 net/sxe: add virtual function

In reply to [email protected]

From: Jie Liu <[email protected]>

Add virtual function.

---
 drivers/net/sxe/base/sxe_compat_platform.h |    2 -
 drivers/net/sxe/base/sxe_queue_common.c    |    4 +
 drivers/net/sxe/base/sxevf_hw.c            |  819 +++++++++++++
 drivers/net/sxe/base/sxevf_hw.h            |  318 ++++++
 drivers/net/sxe/base/sxevf_regs.h          |  119 ++
 drivers/net/sxe/include/sxe/sxe_msg.h      |    4 +-
 drivers/net/sxe/pf/rte_pmd_sxe.h           |    1 +
 drivers/net/sxe/pf/sxe_filter.c            |  177 +++
 drivers/net/sxe/pf/sxe_filter.h            |   15 +
 drivers/net/sxe/pf/sxe_phy.h               |    1 +
 drivers/net/sxe/pf/sxe_tx.c                |    2 +-
 drivers/net/sxe/pf/sxe_vf.c                | 1199 ++++++++++++++++++++
 drivers/net/sxe/pf/sxe_vf.h                |  200 ++++
 drivers/net/sxe/sxe_testpmd.c              |  130 +++
 drivers/net/sxe/vf/sxevf.h                 |   42 +
 drivers/net/sxe/vf/sxevf_ethdev.c          |  752 ++++++++++++
 drivers/net/sxe/vf/sxevf_ethdev.h          |   16 +
 drivers/net/sxe/vf/sxevf_filter.c          |  493 ++++++++
 drivers/net/sxe/vf/sxevf_filter.h          |   70 ++
 drivers/net/sxe/vf/sxevf_irq.c             |  432 +++++++
 drivers/net/sxe/vf/sxevf_irq.h             |   34 +
 drivers/net/sxe/vf/sxevf_main.c            |   82 ++
 drivers/net/sxe/vf/sxevf_msg.c             |  624 ++++++++++
 drivers/net/sxe/vf/sxevf_msg.h             |  201 ++++
 drivers/net/sxe/vf/sxevf_offload.c         |   30 +
 drivers/net/sxe/vf/sxevf_offload.h         |   16 +
 drivers/net/sxe/vf/sxevf_queue.c           |  208 ++++
 drivers/net/sxe/vf/sxevf_queue.h           |   69 ++
 drivers/net/sxe/vf/sxevf_rx.c              |  162 +++
 drivers/net/sxe/vf/sxevf_rx.h              |   18 +
 drivers/net/sxe/vf/sxevf_stats.c           |  162 +++
 drivers/net/sxe/vf/sxevf_stats.h           |   31 +
 drivers/net/sxe/vf/sxevf_tx.c              |   46 +
 drivers/net/sxe/vf/sxevf_tx.h              |   14 +
 34 files changed, 6488 insertions(+), 5 deletions(-)
 create mode 100644 drivers/net/sxe/base/sxevf_hw.c
 create mode 100644 drivers/net/sxe/base/sxevf_hw.h
 create mode 100644 drivers/net/sxe/base/sxevf_regs.h
 create mode 100644 drivers/net/sxe/pf/sxe_vf.c
 create mode 100644 drivers/net/sxe/pf/sxe_vf.h
 create mode 100644 drivers/net/sxe/vf/sxevf.h
 create mode 100644 drivers/net/sxe/vf/sxevf_ethdev.c
 create mode 100644 drivers/net/sxe/vf/sxevf_ethdev.h
 create mode 100644 drivers/net/sxe/vf/sxevf_filter.c
 create mode 100644 drivers/net/sxe/vf/sxevf_filter.h
 create mode 100644 drivers/net/sxe/vf/sxevf_irq.c
 create mode 100644 drivers/net/sxe/vf/sxevf_irq.h
 create mode 100644 drivers/net/sxe/vf/sxevf_main.c
 create mode 100644 drivers/net/sxe/vf/sxevf_msg.c
 create mode 100644 drivers/net/sxe/vf/sxevf_msg.h
 create mode 100644 drivers/net/sxe/vf/sxevf_offload.c
 create mode 100644 drivers/net/sxe/vf/sxevf_offload.h
 create mode 100644 drivers/net/sxe/vf/sxevf_queue.c
 create mode 100644 drivers/net/sxe/vf/sxevf_queue.h
 create mode 100644 drivers/net/sxe/vf/sxevf_rx.c
 create mode 100644 drivers/net/sxe/vf/sxevf_rx.h
 create mode 100644 drivers/net/sxe/vf/sxevf_stats.c
 create mode 100644 drivers/net/sxe/vf/sxevf_stats.h
 create mode 100644 drivers/net/sxe/vf/sxevf_tx.c
 create mode 100644 drivers/net/sxe/vf/sxevf_tx.h
drivers/net/sxe/base/sxe_compat_platform.h +0 -2
index ef22fe7797..0c0b2d9220 100644
@@ -20,8 +20,6 @@
 #define __iomem
 #define __force
 
-#define min(a, b)	RTE_MIN(a, b)
-
 #define cpu_to_be16(o) rte_cpu_to_be_16(o)
 #define cpu_to_be32(o) rte_cpu_to_be_32(o)
 #define cpu_to_be64(o) rte_cpu_to_be_64(o)
drivers/net/sxe/base/sxe_queue_common.c +4 -0
index 991b374667..15e086b45e 100644
@@ -12,11 +12,15 @@
 #include "sxe_tx.h"
 #include "sxe_logs.h"
 #include "sxe_regs.h"
+#include "sxevf_regs.h"
 #include "sxe.h"
 #if defined SXE_DPDK_L4_FEATURES && defined SXE_DPDK_SIMD
 #include "sxe_vec_common.h"
 #include <rte_vect.h>
 #endif
+#if defined SXE_DPDK_L4_FEATURES && defined SXE_DPDK_SRIOV
+#include "sxevf.h"
+#endif
 #include "sxe_queue_common.h"
 #include "sxe_queue.h"
 
drivers/net/sxe/base/sxevf_hw.c new file +819 -0

819 lines not on this page · raw message

drivers/net/sxe/base/sxevf_hw.h new file +318 -0

318 lines not on this page · raw message

drivers/net/sxe/base/sxevf_regs.h new file +119 -0

119 lines not on this page · raw message

drivers/net/sxe/include/sxe/sxe_msg.h +2 -2
index 460258c907..19d03d25b2 100644
@@ -119,7 +119,7 @@ typedef struct sxe_sfp_rate_able {
 
 
 typedef struct sxe_spp_tx_able {
-	BOOL is_disable;
+	bool is_disable;
 } sxe_spp_tx_able_s;
 
 
@@ -129,7 +129,7 @@ typedef struct sxe_default_mac_addr_resp {
 
 
 typedef struct sxe_mng_rst {
-	BOOL enable;
+	bool enable;
 } sxe_mng_rst_s;
 
 #endif
drivers/net/sxe/pf/rte_pmd_sxe.h +1 -0
index 25e768624f..2369f03214 100644
@@ -15,4 +15,5 @@ typedef int32_t		s32;
 s32 rte_pmd_sxe_tx_loopback_set(u16 port, u8 on);
 __rte_experimental
 s32 rte_pmd_sxe_tc_bw_set(u8 port, u8 tc_num, u8 *bw_weight);
+int rte_pmd_sxe_set_vf_rxmode(u16 port, u16 vf, u16 rx_mask, u8 on);
 #endif
drivers/net/sxe/pf/sxe_filter.c +177 -0

202 lines not on this page · raw message

drivers/net/sxe/pf/sxe_filter.h +15 -0
index 2b7c91a9bd..7b9026fcfb 100644
@@ -72,6 +72,15 @@ void sxe_mac_addr_remove(struct rte_eth_dev *dev, u32 rar_idx);
 s32 sxe_mac_addr_set(struct rte_eth_dev *dev,
 				 struct rte_ether_addr *mac_addr);
 
+s32 sxe_uc_hash_table_set(struct rte_eth_dev *dev,
+			struct rte_ether_addr *mac_addr, u8 on);
+
+s32 sxe_uc_all_hash_table_set(struct rte_eth_dev *dev, u8 on);
+
+s32 sxe_set_mc_addr_list(struct rte_eth_dev *dev,
+			  struct rte_ether_addr *mc_addr_list,
+			  u32 nb_mc_addr);
+
 s32 sxe_vlan_filter_set(struct rte_eth_dev *eth_dev, u16 vlan_id, s32 on);
 
 s32 sxe_vlan_tpid_set(struct rte_eth_dev *eth_dev,
@@ -91,4 +100,10 @@ void sxe_vlan_strip_switch_set(struct rte_eth_dev *dev);
 
 void sxe_fc_mac_addr_set(struct sxe_adapter *adapter);
 
+u8 sxe_sw_uc_entry_vf_add(struct sxe_adapter *adapter,
+				u8 vf_idx, u8 *mac_addr, bool macvlan);
+
+void sxe_sw_uc_entry_vf_del(struct sxe_adapter *adapter, u8 vf_idx,
+					bool macvlan);
+
 #endif
drivers/net/sxe/pf/sxe_phy.h +1 -0
index 0dd2ad2d95..65a530ba2b 100644
@@ -6,6 +6,7 @@
 
 #include <rte_ethdev.h>
 #include "drv_msg.h"
+#include "sxe_cli.h"
 #include "sxe_msg.h"
 
 #define SXE_SFF_BASE_ADDR			0x0
drivers/net/sxe/pf/sxe_tx.c +1 -1
index 33d4468ebc..bbf802cd2f 100644
@@ -55,7 +55,7 @@ void __rte_cold sxe_tx_function_set(struct rte_eth_dev *dev,
 
 		PMD_LOG_INFO(INIT, "using full-featured tx code path");
 		PMD_LOG_INFO(INIT, " - offloads = 0x%" SXE_PRIX64,
-					(unsigned long)txq->offloads);
+							txq->offloads);
 		PMD_LOG_INFO(INIT, " - tx_rs_thresh = %d "
 				   "[RTE_PMD_SXE_MAX_TX_BURST=%d]",
 				txq->rs_thresh,
drivers/net/sxe/pf/sxe_vf.c new file +1199 -0

1,199 lines not on this page · raw message

drivers/net/sxe/pf/sxe_vf.h new file +200 -0

200 lines not on this page · raw message

drivers/net/sxe/sxe_testpmd.c +130 -0

59 lines not on this page · raw message

drivers/net/sxe/vf/sxevf.h new file +42 -0

42 lines not on this page · raw message

drivers/net/sxe/vf/sxevf_ethdev.c new file +752 -0

752 lines not on this page · raw message

drivers/net/sxe/vf/sxevf_ethdev.h new file +16 -0
new file mode 100644
index 0000000000..57dfeea2e6

Lines of this file are not shown. View the raw message.

drivers/net/sxe/vf/sxevf_filter.c new file +493 -0

493 lines not on this page · raw message

drivers/net/sxe/vf/sxevf_filter.h new file +70 -0

70 lines not on this page · raw message

drivers/net/sxe/vf/sxevf_irq.c new file +432 -0

432 lines not on this page · raw message

drivers/net/sxe/vf/sxevf_irq.h new file +34 -0
new file mode 100644
index 0000000000..2f9860ba15

Lines of this file are not shown. View the raw message.

drivers/net/sxe/vf/sxevf_main.c new file +82 -0

82 lines not on this page · raw message

drivers/net/sxe/vf/sxevf_msg.c new file +624 -0

624 lines not on this page · raw message

drivers/net/sxe/vf/sxevf_msg.h new file +201 -0

201 lines not on this page · raw message

drivers/net/sxe/vf/sxevf_offload.c new file +30 -0
new file mode 100644
index 0000000000..b39245aa11

Lines of this file are not shown. View the raw message.

drivers/net/sxe/vf/sxevf_offload.h new file +16 -0
new file mode 100644
index 0000000000..ae4bf87f30

Lines of this file are not shown. View the raw message.

drivers/net/sxe/vf/sxevf_queue.c new file +208 -0

208 lines not on this page · raw message

drivers/net/sxe/vf/sxevf_queue.h new file +69 -0

69 lines not on this page · raw message

drivers/net/sxe/vf/sxevf_rx.c new file +162 -0

162 lines not on this page · raw message

drivers/net/sxe/vf/sxevf_rx.h new file +18 -0
new file mode 100644
index 0000000000..55ca2705c1

Lines of this file are not shown. View the raw message.

drivers/net/sxe/vf/sxevf_stats.c new file +162 -0

162 lines not on this page · raw message

drivers/net/sxe/vf/sxevf_stats.h new file +31 -0
new file mode 100644
index 0000000000..cba450953f

Lines of this file are not shown. View the raw message.

drivers/net/sxe/vf/sxevf_tx.c new file +46 -0

46 lines not on this page · raw message

drivers/net/sxe/vf/sxevf_tx.h new file +14 -0
new file mode 100644
index 0000000000..c8ad400bca

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.18.2

Part of the diff is not shown here. View the raw message.

Reviewed-by on the v19 series
#318 lore raw

Re: [PATCH v19 00/13] net/sxe: added Linkdata sxe ethernet driver

In reply to [email protected]
Quoted 200 lines · On Sat, 14 Mar 2026 16:51:52 +0800 [email protected] wrote:

From: Jie Liu <[email protected]>

This patch set implements core functionality for the SXE PMD, including basic driver framework, data path setup, and advanced offload features (VLAN, RSS, DCB, PTP etc.).

V19:
- Addressed AI comments

v18:
- Addressed AI comments

Jie Liu (13):
net/sxe: add base driver directory and doc
net/sxe: add ethdev probe and remove
net/sxe: add tx rx setup and data path
net/sxe: add link and mac layer operations
net/sxe: support vlan filter
net/sxe: add filter function
net/sxe: support rss offload
net/sxe: add dcb function
net/sxe: support ptp
net/sxe: add xstats function
net/sxe: add custom cmd led ctrl
net/sxe: add simd function
net/sxe: add virtual function

 MAINTAINERS                                |    6 +
 doc/guides/nics/features/sxe.ini           |   51 +
 doc/guides/nics/features/sxe_vf.ini        |   37 +
 doc/guides/nics/index.rst                  |    1 +
 doc/guides/nics/sxe.rst                    |   71 +
 doc/guides/rel_notes/release_26_03.rst     |    6 +
 drivers/net/meson.build                    |    1 +
 drivers/net/sxe/base/sxe_common.c          |   45 +
 drivers/net/sxe/base/sxe_common.h          |   13 +
 drivers/net/sxe/base/sxe_compat_platform.h |   73 +
 drivers/net/sxe/base/sxe_compat_version.h  |   34 +
 drivers/net/sxe/base/sxe_errno.h           |   61 +
 drivers/net/sxe/base/sxe_hw.c              | 3271 ++++++++++++++++++++
 drivers/net/sxe/base/sxe_hw.h              | 1010 ++++++
 drivers/net/sxe/base/sxe_logs.h            |  105 +
 drivers/net/sxe/base/sxe_offload_common.c  |   54 +
 drivers/net/sxe/base/sxe_offload_common.h  |   14 +
 drivers/net/sxe/base/sxe_queue_common.c    |  450 +++
 drivers/net/sxe/base/sxe_queue_common.h    |  240 ++
 drivers/net/sxe/base/sxe_rx_common.c       |  358 +++
 drivers/net/sxe/base/sxe_rx_common.h       |   17 +
 drivers/net/sxe/base/sxe_tx_common.c       |   40 +
 drivers/net/sxe/base/sxe_tx_common.h       |   12 +
 drivers/net/sxe/base/sxe_types.h           |   40 +
 drivers/net/sxe/base/sxevf_hw.c            |  819 +++++
 drivers/net/sxe/base/sxevf_hw.h            |  318 ++
 drivers/net/sxe/base/sxevf_regs.h          |  119 +
 drivers/net/sxe/include/drv_msg.h          |   18 +
 drivers/net/sxe/include/sxe/sxe_cli.h      |  218 ++
 drivers/net/sxe/include/sxe/sxe_hdc.h      |   43 +
 drivers/net/sxe/include/sxe/sxe_ioctl.h    |   21 +
 drivers/net/sxe/include/sxe/sxe_msg.h      |  135 +
 drivers/net/sxe/include/sxe/sxe_regs.h     | 1270 ++++++++
 drivers/net/sxe/include/sxe_type.h         |  795 +++++
 drivers/net/sxe/include/sxe_version.h      |   29 +
 drivers/net/sxe/meson.build                |   65 +
 drivers/net/sxe/pf/rte_pmd_sxe.h           |   19 +
 drivers/net/sxe/pf/sxe.h                   |   93 +
 drivers/net/sxe/pf/sxe_dcb.c               |  945 ++++++
 drivers/net/sxe/pf/sxe_dcb.h               |   99 +
 drivers/net/sxe/pf/sxe_ethdev.c            |  928 ++++++
 drivers/net/sxe/pf/sxe_ethdev.h            |   28 +
 drivers/net/sxe/pf/sxe_filter.c            |  923 ++++++
 drivers/net/sxe/pf/sxe_filter.h            |  109 +
 drivers/net/sxe/pf/sxe_flow_ctrl.c         |   98 +
 drivers/net/sxe/pf/sxe_flow_ctrl.h         |   16 +
 drivers/net/sxe/pf/sxe_irq.c               |  516 +++
 drivers/net/sxe/pf/sxe_irq.h               |   48 +
 drivers/net/sxe/pf/sxe_main.c              |  196 ++
 drivers/net/sxe/pf/sxe_offload.c           |  336 ++
 drivers/net/sxe/pf/sxe_offload.h           |   51 +
 drivers/net/sxe/pf/sxe_phy.c               |  953 ++++++
 drivers/net/sxe/pf/sxe_phy.h               |  117 +
 drivers/net/sxe/pf/sxe_pmd_hdc.c           |  661 ++++
 drivers/net/sxe/pf/sxe_pmd_hdc.h           |   42 +
 drivers/net/sxe/pf/sxe_ptp.c               |  209 ++
 drivers/net/sxe/pf/sxe_ptp.h               |   26 +
 drivers/net/sxe/pf/sxe_queue.c             |  774 +++++
 drivers/net/sxe/pf/sxe_queue.h             |  132 +
 drivers/net/sxe/pf/sxe_rx.c                | 1459 +++++++++
 drivers/net/sxe/pf/sxe_rx.h                |  188 ++
 drivers/net/sxe/pf/sxe_stats.c             |  586 ++++
 drivers/net/sxe/pf/sxe_stats.h             |   69 +
 drivers/net/sxe/pf/sxe_tx.c                | 1051 +++++++
 drivers/net/sxe/pf/sxe_tx.h                |   50 +
 drivers/net/sxe/pf/sxe_vec_common.h        |  321 ++
 drivers/net/sxe/pf/sxe_vec_neon.c          |  600 ++++
 drivers/net/sxe/pf/sxe_vec_sse.c           |  622 ++++
 drivers/net/sxe/pf/sxe_vf.c                | 1199 +++++++
 drivers/net/sxe/pf/sxe_vf.h                |  200 ++
 drivers/net/sxe/sxe_drv_type.h             |   15 +
 drivers/net/sxe/sxe_testpmd.c              |  196 ++
 drivers/net/sxe/vf/sxevf.h                 |   42 +
 drivers/net/sxe/vf/sxevf_ethdev.c          |  752 +++++
 drivers/net/sxe/vf/sxevf_ethdev.h          |   16 +
 drivers/net/sxe/vf/sxevf_filter.c          |  493 +++
 drivers/net/sxe/vf/sxevf_filter.h          |   70 +
 drivers/net/sxe/vf/sxevf_irq.c             |  432 +++
 drivers/net/sxe/vf/sxevf_irq.h             |   34 +
 drivers/net/sxe/vf/sxevf_main.c            |   82 +
 drivers/net/sxe/vf/sxevf_msg.c             |  624 ++++
 drivers/net/sxe/vf/sxevf_msg.h             |  201 ++
 drivers/net/sxe/vf/sxevf_offload.c         |   30 +
 drivers/net/sxe/vf/sxevf_offload.h         |   16 +
 drivers/net/sxe/vf/sxevf_queue.c           |  208 ++
 drivers/net/sxe/vf/sxevf_queue.h           |   69 +
 drivers/net/sxe/vf/sxevf_rx.c              |  162 +
 drivers/net/sxe/vf/sxevf_rx.h              |   18 +
 drivers/net/sxe/vf/sxevf_stats.c           |  162 +
 drivers/net/sxe/vf/sxevf_stats.h           |   31 +
 drivers/net/sxe/vf/sxevf_tx.c              |   46 +
 drivers/net/sxe/vf/sxevf_tx.h              |   14 +
 92 files changed, 27237 insertions(+)
 create mode 100644 doc/guides/nics/features/sxe.ini
 create mode 100644 doc/guides/nics/features/sxe_vf.ini
 create mode 100644 doc/guides/nics/sxe.rst
 create mode 100644 drivers/net/sxe/base/sxe_common.c
 create mode 100644 drivers/net/sxe/base/sxe_common.h
 create mode 100644 drivers/net/sxe/base/sxe_compat_platform.h
 create mode 100644 drivers/net/sxe/base/sxe_compat_version.h
 create mode 100644 drivers/net/sxe/base/sxe_errno.h
 create mode 100644 drivers/net/sxe/base/sxe_hw.c
 create mode 100644 drivers/net/sxe/base/sxe_hw.h
 create mode 100644 drivers/net/sxe/base/sxe_logs.h
 create mode 100644 drivers/net/sxe/base/sxe_offload_common.c
 create mode 100644 drivers/net/sxe/base/sxe_offload_common.h
 create mode 100644 drivers/net/sxe/base/sxe_queue_common.c
 create mode 100644 drivers/net/sxe/base/sxe_queue_common.h
 create mode 100644 drivers/net/sxe/base/sxe_rx_common.c
 create mode 100644 drivers/net/sxe/base/sxe_rx_common.h
 create mode 100644 drivers/net/sxe/base/sxe_tx_common.c
 create mode 100644 drivers/net/sxe/base/sxe_tx_common.h
 create mode 100644 drivers/net/sxe/base/sxe_types.h
 create mode 100644 drivers/net/sxe/base/sxevf_hw.c
 create mode 100644 drivers/net/sxe/base/sxevf_hw.h
 create mode 100644 drivers/net/sxe/base/sxevf_regs.h
 create mode 100644 drivers/net/sxe/include/drv_msg.h
 create mode 100644 drivers/net/sxe/include/sxe/sxe_cli.h
 create mode 100644 drivers/net/sxe/include/sxe/sxe_hdc.h
 create mode 100644 drivers/net/sxe/include/sxe/sxe_ioctl.h
 create mode 100644 drivers/net/sxe/include/sxe/sxe_msg.h
 create mode 100644 drivers/net/sxe/include/sxe/sxe_regs.h
 create mode 100644 drivers/net/sxe/include/sxe_type.h
 create mode 100644 drivers/net/sxe/include/sxe_version.h
 create mode 100644 drivers/net/sxe/meson.build
 create mode 100644 drivers/net/sxe/pf/rte_pmd_sxe.h
 create mode 100644 drivers/net/sxe/pf/sxe.h
 create mode 100644 drivers/net/sxe/pf/sxe_dcb.c
 create mode 100644 drivers/net/sxe/pf/sxe_dcb.h
 create mode 100644 drivers/net/sxe/pf/sxe_ethdev.c
 create mode 100644 drivers/net/sxe/pf/sxe_ethdev.h
 create mode 100644 drivers/net/sxe/pf/sxe_filter.c
 create mode 100644 drivers/net/sxe/pf/sxe_filter.h
 create mode 100644 drivers/net/sxe/pf/sxe_flow_ctrl.c
 create mode 100644 drivers/net/sxe/pf/sxe_flow_ctrl.h
 create mode 100644 drivers/net/sxe/pf/sxe_irq.c
 create mode 100644 drivers/net/sxe/pf/sxe_irq.h
 create mode 100644 drivers/net/sxe/pf/sxe_main.c
 create mode 100644 drivers/net/sxe/pf/sxe_offload.c
 create mode 100644 drivers/net/sxe/pf/sxe_offload.h
 create mode 100644 drivers/net/sxe/pf/sxe_phy.c
 create mode 100644 drivers/net/sxe/pf/sxe_phy.h
 create mode 100644 drivers/net/sxe/pf/sxe_pmd_hdc.c
 create mode 100644 drivers/net/sxe/pf/sxe_pmd_hdc.h
 create mode 100644 drivers/net/sxe/pf/sxe_ptp.c
 create mode 100644 drivers/net/sxe/pf/sxe_ptp.h
 create mode 100644 drivers/net/sxe/pf/sxe_queue.c
 create mode 100644 drivers/net/sxe/pf/sxe_queue.h
 create mode 100644 drivers/net/sxe/pf/sxe_rx.c
 create mode 100644 drivers/net/sxe/pf/sxe_rx.h
 create mode 100644 drivers/net/sxe/pf/sxe_stats.c
 create mode 100644 drivers/net/sxe/pf/sxe_stats.h
 create mode 100644 drivers/net/sxe/pf/sxe_tx.c
 create mode 100644 drivers/net/sxe/pf/sxe_tx.h
 create mode 100644 drivers/net/sxe/pf/sxe_vec_common.h
 create mode 100644 drivers/net/sxe/pf/sxe_vec_neon.c
 create mode 100644 drivers/net/sxe/pf/sxe_vec_sse.c
 create mode 100644 drivers/net/sxe/pf/sxe_vf.c
 create mode 100644 drivers/net/sxe/pf/sxe_vf.h
 create mode 100644 drivers/net/sxe/sxe_drv_type.h
 create mode 100644 drivers/net/sxe/sxe_testpmd.c
 create mode 100644 drivers/net/sxe/vf/sxevf.h
 create mode 100644 drivers/net/sxe/vf/sxevf_ethdev.c
 create mode 100644 drivers/net/sxe/vf/sxevf_ethdev.h
 create mode 100644 drivers/net/sxe/vf/sxevf_filter.c
 create mode 100644 drivers/net/sxe/vf/sxevf_filter.h
 create mode 100644 drivers/net/sxe/vf/sxevf_irq.c
 create mode 100644 drivers/net/sxe/vf/sxevf_irq.h
 create mode 100644 drivers/net/sxe/vf/sxevf_main.c
 create mode 100644 drivers/net/sxe/vf/sxevf_msg.c
 create mode 100644 drivers/net/sxe/vf/sxevf_msg.h
 create mode 100644 drivers/net/sxe/vf/sxevf_offload.c
 create mode 100644 drivers/net/sxe/vf/sxevf_offload.h
Quoted 8 lines
 create mode 100644 drivers/net/sxe/vf/sxevf_queue.c
 create mode 100644 drivers/net/sxe/vf/sxevf_queue.h
 create mode 100644 drivers/net/sxe/vf/sxevf_rx.c
 create mode 100644 drivers/net/sxe/vf/sxevf_rx.h
 create mode 100644 drivers/net/sxe/vf/sxevf_stats.c
 create mode 100644 drivers/net/sxe/vf/sxevf_stats.h
 create mode 100644 drivers/net/sxe/vf/sxevf_tx.c
 create mode 100644 drivers/net/sxe/vf/sxevf_tx.h

This driver is large and requires more detail human review so it won't make 25.03 release.

Some more automated review feedback (some of this is false positives like complaining about u8, etc).

Review of [PATCH v19 01/13] through [PATCH v19 13/13] net/sxe driver series
=============================================================================

Patch 02/13: net/sxe: add ethdev probe and remove
--------------------------------------------------

Error: Blocking calls (mdelay) under spinlock in HDC command path.

In sxe_pmd_hdc.c, sxe_hdc_cmd_process() acquires g_hdc_lock (an rte_spinlock_t) then calls sxe_hdc_packet_trans(), which calls sxe_poll_fw_ack() containing mdelay(10) in a loop up to 1000 iterations (SXE_HDC_WAIT_TIME). That is up to 10 seconds of blocking while holding a spinlock. Spinlocks are busy-wait locks; blocking under them wastes CPU on any other thread trying to acquire the lock and causes massive latency spikes.

Replace g_hdc_lock with a pthread_mutex_t, which is a sleeping lock and appropriate for operations that block for milliseconds.

Error: Global HDC state re-initialized on every probe.

sxe_hdc_channel_init() is called from sxe_probe() and re-initializes the global g_hdc_lock spinlock and resets the global sxe_trace_id counter. If two SXE PCI devices are probed, the second probe reinitializes the lock while the first device may be using it. This is a race condition.

Move the HDC channel initialization to a one-time constructor (RTE_INIT) or use rte_thread_once / an initialization flag.

Error: Non-atomic store to atomic variable.

In sxe_common.c, sxe_trace_id_gen() writes sxe_trace_id with a plain assignment (sxe_trace_id = 0) despite sxe_trace_id being declared RTE_ATOMIC(uint64_t) and read elsewhere via rte_atomic_fetch_add_explicit(). This is a data race. Use rte_atomic_store_explicit(&sxe_trace_id, 0, rte_memory_order_relaxed).

Warning: sxe_compat_version.h defines SXE_GET_FRAME_SIZE using dev->data->mtu + SXE_ETH_OVERHEAD, where SXE_ETH_OVERHEAD is RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN (18 bytes). The feature set claims VLAN and QinQ support. The scatter decision in sxe_rx_queue_attr_configure (patch 03) correctly adds 2*SXE_VLAN_TAG_SIZE separately, but the SXE_GET_FRAME_SIZE macro does not include VLAN overhead. This inconsistency means callers of SXE_GET_FRAME_SIZE that don't add VLAN overhead themselves will underestimate frame size. Consider making the overhead device-specific or using SXE_ETH_DEAD_LOAD consistently.

Patch 03/13: net/sxe: add tx rx setup and data path
----------------------------------------------------

Error: mtu_set does not re-select the Rx burst function.

In sxe_mtu_set() (sxe_ethdev.c), when the device is started and scatter is not enabled, the function rejects the MTU change with -EINVAL and tells the user to "stop port first." However, even if the port is stopped and restarted, the mtu_set callback itself stores the new MTU in adapter->mtu but never updates dev->data->scattered_rx or re-selects the Rx burst function. The Rx function selection only happens in sxe_rx_configure() during dev_start, but it reads dev->data->mtu, not adapter->mtu. If adapter->mtu and dev->data->mtu diverge, the scatter decision at restart will use the wrong value.

The adapter->mtu field appears to shadow dev->data->mtu without a clear purpose. The ethdev layer already writes dev->data->mtu before calling the mtu_set callback. Either remove adapter->mtu and use dev->data->mtu everywhere, or ensure they stay in sync.

Warning: dev_infos_get reports max_mtu using SXE_ETH_OVERHEAD (18 bytes) but the device supports VLAN/QinQ, so the true maximum frame overhead is larger. This means max_mtu is slightly overestimated — the ethdev layer would allow an MTU that, with VLAN tags, exceeds max_rx_pktlen. This is a minor inconsistency with the scatter Rx decision which does account for VLAN tags.

Patch 04/13: net/sxe: add link and mac layer operations
--------------------------------------------------------

No correctness issues found.

Patch 12/13: net/sxe: add virtual function
-------------------------------------------

Error: Missing NULL check after malloc.

In sxe_vf_rss_hash_conf_get(), rss_conf.rss_key is allocated with malloc(SXE_RSS_KEY_SIZE) but the return value is never checked for NULL. If malloc fails, the subsequent sxe_rss_hash_conf_get() and memcpy() will dereference a NULL pointer.

  rss_conf.rss_key = malloc(SXE_RSS_KEY_SIZE);
  +if (rss_conf.rss_key == NULL)
  +    return -ENOMEM;
  sxe_rss_hash_conf_get(dev, &rss_conf);

Series-wide observations
------------------------

Warning: The driver defines its own integer typedefs (u8, u16, u32, u64, s32 etc.) in sxe_types.h. DPDK convention is to use standard C types (uint8_t, uint16_t, uint32_t, uint64_t, int32_t) throughout. While this is a style issue and the base/ directory has some latitude for cross-platform shared code, the pf/ and vf/ code that is purely DPDK should prefer standard types.

Warning: Many functions use the goto-label pattern with labels like l_end, l_out, l_ret, l_up, l_error, l_free, etc. Some functions have goto targets that simply return 0 unconditionally (e.g., sxe_hw_uc_addr_pool_disable), making the goto pattern add complexity without benefit.

Warning: sxe_ethdev.c defines local constants SXE_ETH_HLEN (14), SXE_ETH_FRAME_LEN (1514), SXE_ETH_FCS_LEN (4) that duplicate standard RTE_ETHER_HDR_LEN, RTE_ETHER_MAX_LEN, and RTE_ETHER_CRC_LEN. Use the rte_ constants directly.

#319 lore raw

Re: [PATCH v19 00/13] net/sxe: added Linkdata sxe ethernet driver

In reply to [email protected]
Quoted 200 lines · On Sat, 14 Mar 2026 16:51:52 +0800 [email protected] wrote:

From: Jie Liu <[email protected]>

This patch set implements core functionality for the SXE PMD, including basic driver framework, data path setup, and advanced offload features (VLAN, RSS, DCB, PTP etc.).

V19:
- Addressed AI comments

v18:
- Addressed AI comments

Jie Liu (13):
net/sxe: add base driver directory and doc
net/sxe: add ethdev probe and remove
net/sxe: add tx rx setup and data path
net/sxe: add link and mac layer operations
net/sxe: support vlan filter
net/sxe: add filter function
net/sxe: support rss offload
net/sxe: add dcb function
net/sxe: support ptp
net/sxe: add xstats function
net/sxe: add custom cmd led ctrl
net/sxe: add simd function
net/sxe: add virtual function

 MAINTAINERS                                |    6 +
 doc/guides/nics/features/sxe.ini           |   51 +
 doc/guides/nics/features/sxe_vf.ini        |   37 +
 doc/guides/nics/index.rst                  |    1 +
 doc/guides/nics/sxe.rst                    |   71 +
 doc/guides/rel_notes/release_26_03.rst     |    6 +
 drivers/net/meson.build                    |    1 +
 drivers/net/sxe/base/sxe_common.c          |   45 +
 drivers/net/sxe/base/sxe_common.h          |   13 +
 drivers/net/sxe/base/sxe_compat_platform.h |   73 +
 drivers/net/sxe/base/sxe_compat_version.h  |   34 +
 drivers/net/sxe/base/sxe_errno.h           |   61 +
 drivers/net/sxe/base/sxe_hw.c              | 3271 ++++++++++++++++++++
 drivers/net/sxe/base/sxe_hw.h              | 1010 ++++++
 drivers/net/sxe/base/sxe_logs.h            |  105 +
 drivers/net/sxe/base/sxe_offload_common.c  |   54 +
 drivers/net/sxe/base/sxe_offload_common.h  |   14 +
 drivers/net/sxe/base/sxe_queue_common.c    |  450 +++
 drivers/net/sxe/base/sxe_queue_common.h    |  240 ++
 drivers/net/sxe/base/sxe_rx_common.c       |  358 +++
 drivers/net/sxe/base/sxe_rx_common.h       |   17 +
 drivers/net/sxe/base/sxe_tx_common.c       |   40 +
 drivers/net/sxe/base/sxe_tx_common.h       |   12 +
 drivers/net/sxe/base/sxe_types.h           |   40 +
 drivers/net/sxe/base/sxevf_hw.c            |  819 +++++
 drivers/net/sxe/base/sxevf_hw.h            |  318 ++
 drivers/net/sxe/base/sxevf_regs.h          |  119 +
 drivers/net/sxe/include/drv_msg.h          |   18 +
 drivers/net/sxe/include/sxe/sxe_cli.h      |  218 ++
 drivers/net/sxe/include/sxe/sxe_hdc.h      |   43 +
 drivers/net/sxe/include/sxe/sxe_ioctl.h    |   21 +
 drivers/net/sxe/include/sxe/sxe_msg.h      |  135 +
 drivers/net/sxe/include/sxe/sxe_regs.h     | 1270 ++++++++
 drivers/net/sxe/include/sxe_type.h         |  795 +++++
 drivers/net/sxe/include/sxe_version.h      |   29 +
 drivers/net/sxe/meson.build                |   65 +
 drivers/net/sxe/pf/rte_pmd_sxe.h           |   19 +
 drivers/net/sxe/pf/sxe.h                   |   93 +
 drivers/net/sxe/pf/sxe_dcb.c               |  945 ++++++
 drivers/net/sxe/pf/sxe_dcb.h               |   99 +
 drivers/net/sxe/pf/sxe_ethdev.c            |  928 ++++++
 drivers/net/sxe/pf/sxe_ethdev.h            |   28 +
 drivers/net/sxe/pf/sxe_filter.c            |  923 ++++++
 drivers/net/sxe/pf/sxe_filter.h            |  109 +
 drivers/net/sxe/pf/sxe_flow_ctrl.c         |   98 +
 drivers/net/sxe/pf/sxe_flow_ctrl.h         |   16 +
 drivers/net/sxe/pf/sxe_irq.c               |  516 +++
 drivers/net/sxe/pf/sxe_irq.h               |   48 +
 drivers/net/sxe/pf/sxe_main.c              |  196 ++
 drivers/net/sxe/pf/sxe_offload.c           |  336 ++
 drivers/net/sxe/pf/sxe_offload.h           |   51 +
 drivers/net/sxe/pf/sxe_phy.c               |  953 ++++++
 drivers/net/sxe/pf/sxe_phy.h               |  117 +
 drivers/net/sxe/pf/sxe_pmd_hdc.c           |  661 ++++
 drivers/net/sxe/pf/sxe_pmd_hdc.h           |   42 +
 drivers/net/sxe/pf/sxe_ptp.c               |  209 ++
 drivers/net/sxe/pf/sxe_ptp.h               |   26 +
 drivers/net/sxe/pf/sxe_queue.c             |  774 +++++
 drivers/net/sxe/pf/sxe_queue.h             |  132 +
 drivers/net/sxe/pf/sxe_rx.c                | 1459 +++++++++
 drivers/net/sxe/pf/sxe_rx.h                |  188 ++
 drivers/net/sxe/pf/sxe_stats.c             |  586 ++++
 drivers/net/sxe/pf/sxe_stats.h             |   69 +
 drivers/net/sxe/pf/sxe_tx.c                | 1051 +++++++
 drivers/net/sxe/pf/sxe_tx.h                |   50 +
 drivers/net/sxe/pf/sxe_vec_common.h        |  321 ++
 drivers/net/sxe/pf/sxe_vec_neon.c          |  600 ++++
 drivers/net/sxe/pf/sxe_vec_sse.c           |  622 ++++
 drivers/net/sxe/pf/sxe_vf.c                | 1199 +++++++
 drivers/net/sxe/pf/sxe_vf.h                |  200 ++
 drivers/net/sxe/sxe_drv_type.h             |   15 +
 drivers/net/sxe/sxe_testpmd.c              |  196 ++
 drivers/net/sxe/vf/sxevf.h                 |   42 +
 drivers/net/sxe/vf/sxevf_ethdev.c          |  752 +++++
 drivers/net/sxe/vf/sxevf_ethdev.h          |   16 +
 drivers/net/sxe/vf/sxevf_filter.c          |  493 +++
 drivers/net/sxe/vf/sxevf_filter.h          |   70 +
 drivers/net/sxe/vf/sxevf_irq.c             |  432 +++
 drivers/net/sxe/vf/sxevf_irq.h             |   34 +
 drivers/net/sxe/vf/sxevf_main.c            |   82 +
 drivers/net/sxe/vf/sxevf_msg.c             |  624 ++++
 drivers/net/sxe/vf/sxevf_msg.h             |  201 ++
 drivers/net/sxe/vf/sxevf_offload.c         |   30 +
 drivers/net/sxe/vf/sxevf_offload.h         |   16 +
 drivers/net/sxe/vf/sxevf_queue.c           |  208 ++
 drivers/net/sxe/vf/sxevf_queue.h           |   69 +
 drivers/net/sxe/vf/sxevf_rx.c              |  162 +
 drivers/net/sxe/vf/sxevf_rx.h              |   18 +
 drivers/net/sxe/vf/sxevf_stats.c           |  162 +
 drivers/net/sxe/vf/sxevf_stats.h           |   31 +
 drivers/net/sxe/vf/sxevf_tx.c              |   46 +
 drivers/net/sxe/vf/sxevf_tx.h              |   14 +
 92 files changed, 27237 insertions(+)
 create mode 100644 doc/guides/nics/features/sxe.ini
 create mode 100644 doc/guides/nics/features/sxe_vf.ini
 create mode 100644 doc/guides/nics/sxe.rst
 create mode 100644 drivers/net/sxe/base/sxe_common.c
 create mode 100644 drivers/net/sxe/base/sxe_common.h
 create mode 100644 drivers/net/sxe/base/sxe_compat_platform.h
 create mode 100644 drivers/net/sxe/base/sxe_compat_version.h
 create mode 100644 drivers/net/sxe/base/sxe_errno.h
 create mode 100644 drivers/net/sxe/base/sxe_hw.c
 create mode 100644 drivers/net/sxe/base/sxe_hw.h
 create mode 100644 drivers/net/sxe/base/sxe_logs.h
 create mode 100644 drivers/net/sxe/base/sxe_offload_common.c
 create mode 100644 drivers/net/sxe/base/sxe_offload_common.h
 create mode 100644 drivers/net/sxe/base/sxe_queue_common.c
 create mode 100644 drivers/net/sxe/base/sxe_queue_common.h
 create mode 100644 drivers/net/sxe/base/sxe_rx_common.c
 create mode 100644 drivers/net/sxe/base/sxe_rx_common.h
 create mode 100644 drivers/net/sxe/base/sxe_tx_common.c
 create mode 100644 drivers/net/sxe/base/sxe_tx_common.h
 create mode 100644 drivers/net/sxe/base/sxe_types.h
 create mode 100644 drivers/net/sxe/base/sxevf_hw.c
 create mode 100644 drivers/net/sxe/base/sxevf_hw.h
 create mode 100644 drivers/net/sxe/base/sxevf_regs.h
 create mode 100644 drivers/net/sxe/include/drv_msg.h
 create mode 100644 drivers/net/sxe/include/sxe/sxe_cli.h
 create mode 100644 drivers/net/sxe/include/sxe/sxe_hdc.h
 create mode 100644 drivers/net/sxe/include/sxe/sxe_ioctl.h
 create mode 100644 drivers/net/sxe/include/sxe/sxe_msg.h
 create mode 100644 drivers/net/sxe/include/sxe/sxe_regs.h
 create mode 100644 drivers/net/sxe/include/sxe_type.h
 create mode 100644 drivers/net/sxe/include/sxe_version.h
 create mode 100644 drivers/net/sxe/meson.build
 create mode 100644 drivers/net/sxe/pf/rte_pmd_sxe.h
 create mode 100644 drivers/net/sxe/pf/sxe.h
 create mode 100644 drivers/net/sxe/pf/sxe_dcb.c
 create mode 100644 drivers/net/sxe/pf/sxe_dcb.h
 create mode 100644 drivers/net/sxe/pf/sxe_ethdev.c
 create mode 100644 drivers/net/sxe/pf/sxe_ethdev.h
 create mode 100644 drivers/net/sxe/pf/sxe_filter.c
 create mode 100644 drivers/net/sxe/pf/sxe_filter.h
 create mode 100644 drivers/net/sxe/pf/sxe_flow_ctrl.c
 create mode 100644 drivers/net/sxe/pf/sxe_flow_ctrl.h
 create mode 100644 drivers/net/sxe/pf/sxe_irq.c
 create mode 100644 drivers/net/sxe/pf/sxe_irq.h
 create mode 100644 drivers/net/sxe/pf/sxe_main.c
 create mode 100644 drivers/net/sxe/pf/sxe_offload.c
 create mode 100644 drivers/net/sxe/pf/sxe_offload.h
 create mode 100644 drivers/net/sxe/pf/sxe_phy.c
 create mode 100644 drivers/net/sxe/pf/sxe_phy.h
 create mode 100644 drivers/net/sxe/pf/sxe_pmd_hdc.c
 create mode 100644 drivers/net/sxe/pf/sxe_pmd_hdc.h
 create mode 100644 drivers/net/sxe/pf/sxe_ptp.c
 create mode 100644 drivers/net/sxe/pf/sxe_ptp.h
 create mode 100644 drivers/net/sxe/pf/sxe_queue.c
 create mode 100644 drivers/net/sxe/pf/sxe_queue.h
 create mode 100644 drivers/net/sxe/pf/sxe_rx.c
 create mode 100644 drivers/net/sxe/pf/sxe_rx.h
 create mode 100644 drivers/net/sxe/pf/sxe_stats.c
 create mode 100644 drivers/net/sxe/pf/sxe_stats.h
 create mode 100644 drivers/net/sxe/pf/sxe_tx.c
 create mode 100644 drivers/net/sxe/pf/sxe_tx.h
 create mode 100644 drivers/net/sxe/pf/sxe_vec_common.h
 create mode 100644 drivers/net/sxe/pf/sxe_vec_neon.c
 create mode 100644 drivers/net/sxe/pf/sxe_vec_sse.c
 create mode 100644 drivers/net/sxe/pf/sxe_vf.c
 create mode 100644 drivers/net/sxe/pf/sxe_vf.h
 create mode 100644 drivers/net/sxe/sxe_drv_type.h
 create mode 100644 drivers/net/sxe/sxe_testpmd.c
 create mode 100644 drivers/net/sxe/vf/sxevf.h
 create mode 100644 drivers/net/sxe/vf/sxevf_ethdev.c
 create mode 100644 drivers/net/sxe/vf/sxevf_ethdev.h
 create mode 100644 drivers/net/sxe/vf/sxevf_filter.c
 create mode 100644 drivers/net/sxe/vf/sxevf_filter.h
 create mode 100644 drivers/net/sxe/vf/sxevf_irq.c
 create mode 100644 drivers/net/sxe/vf/sxevf_irq.h
 create mode 100644 drivers/net/sxe/vf/sxevf_main.c
 create mode 100644 drivers/net/sxe/vf/sxevf_msg.c
 create mode 100644 drivers/net/sxe/vf/sxevf_msg.h
 create mode 100644 drivers/net/sxe/vf/sxevf_offload.c
 create mode 100644 drivers/net/sxe/vf/sxevf_offload.h
Quoted 9 lines
 create mode 100644 drivers/net/sxe/vf/sxevf_queue.c
 create mode 100644 drivers/net/sxe/vf/sxevf_queue.h
 create mode 100644 drivers/net/sxe/vf/sxevf_rx.c
 create mode 100644 drivers/net/sxe/vf/sxevf_rx.h
 create mode 100644 drivers/net/sxe/vf/sxevf_stats.c
 create mode 100644 drivers/net/sxe/vf/sxevf_stats.h
 create mode 100644 drivers/net/sxe/vf/sxevf_tx.c
 create mode 100644 drivers/net/sxe/vf/sxevf_tx.h

More observations with wordy AI information:

The base layer has several problematic patterns where it pulls in raw POSIX/libc syscalls instead of using DPDK's own abstractions. This matters because DPDK abstractions exist specifically to handle portability (Windows support), to integrate with the EAL runtime model, and to avoid surprising behavior in a userspace poll-mode environment.

Here's what I found:

clock_gettime(CLOCK_MONOTONIC) in sxe_common.c — Used by sxe_time_get_real_ms() to get a millisecond timestamp that's sent to firmware via the HDC time sync command. DPDK provides rte_get_timer_cycles() and rte_get_timer_hz() for exactly this purpose. If wall-clock time is specifically needed for the firmware protocol (as opposed to monotonic elapsed time), that's a slightly different situation, but the function name says "real ms" and it uses CLOCK_MONOTONIC, so rte_get_timer_cycles() / (rte_get_timer_hz() / 1000) is a direct replacement.

clock_gettime(CLOCK_REALTIME) in the PTP code (patch 09) — This one is for PTP initialization, where wall-clock time is arguably needed. But DPDK's rte_timespec_get() (or even just using the PTP hardware clock directly) would be more appropriate than a raw syscall.

pthread_sigmask() / sigaddset() / sigemptyset() in sxe_pmd_hdc.c — The HDC command path blocks SIGINT/SIGTERM during firmware transactions to avoid being interrupted mid-protocol. This is a Linux-specific pattern and won't work on other platforms. More fundamentally, DPDK drivers shouldn't need to manipulate signal masks — the EAL owns signal handling. If the concern is that a firmware transaction must complete atomically, the proper approach is to not use signals for cancellation in the first place. In DPDK's model, control operations run on the main thread which is not expected to receive asynchronous signals during normal operation.

gettimeofday() / localtime() / strftime() in the TIME() macro in sxe_logs.h — This macro is defined but appears unused, which is good because gettimeofday is a syscall and localtime is not thread-safe. It should just be removed. The RTE_LOG infrastructure already handles timestamps.

#include <pthread.h> in sxe_common.c and sxe_logs.h — These includes appear to be unnecessary leftovers. sxe_common.c doesn't use any pthread functions (the trace_id uses rte_atomic). sxe_logs.h includes pthread.h but doesn't use it either — presumably it was for a pthread_self() call in a logging macro that was removed.

pthread_t and pthread_barrier_t in VF adapter struct (patch 12) — These are declared in the struct but never used in the patch. If they're intended for a link-check thread, the DPDK equivalent is rte_thread_create_internal_control() with rte_thread_t.

The usleep_range() / mdelay() / msleep() macros in sxe_compat_platform.h — These are defined as wrappers around rte_delay_us / rte_delay_ms, which is the right approach. But the macro names are Linux kernel conventions (usleep_range, mdelay, msleep), which suggests this base code was ported from a kernel driver. While the macros themselves map to DPDK functions, the kernel-style naming throughout the base layer is a signal that the port wasn't fully adapted to DPDK conventions.

The overall pattern is that this base/ directory looks like a kernel driver compat layer that was mechanically ported — the Linux-isms (__iomem, __force, usleep_range, mdelay, BIT(), ARRAY_SIZE(), kernel-style type names) are papered over with macros, but some raw POSIX calls leaked through. The driver would be cleaner if the base layer used DPDK APIs directly rather than maintaining a Linux kernel compatibility shim.

#320 lore raw

Re: [PATCH v19 00/13] net/sxe: added Linkdata sxe ethernet driver

In reply to [email protected]
Quoted 200 lines · On Sat, 14 Mar 2026 16:51:52 +0800 [email protected] wrote:

From: Jie Liu <[email protected]>

This patch set implements core functionality for the SXE PMD, including basic driver framework, data path setup, and advanced offload features (VLAN, RSS, DCB, PTP etc.).

V19:
- Addressed AI comments

v18:
- Addressed AI comments

Jie Liu (13):
net/sxe: add base driver directory and doc
net/sxe: add ethdev probe and remove
net/sxe: add tx rx setup and data path
net/sxe: add link and mac layer operations
net/sxe: support vlan filter
net/sxe: add filter function
net/sxe: support rss offload
net/sxe: add dcb function
net/sxe: support ptp
net/sxe: add xstats function
net/sxe: add custom cmd led ctrl
net/sxe: add simd function
net/sxe: add virtual function

 MAINTAINERS                                |    6 +
 doc/guides/nics/features/sxe.ini           |   51 +
 doc/guides/nics/features/sxe_vf.ini        |   37 +
 doc/guides/nics/index.rst                  |    1 +
 doc/guides/nics/sxe.rst                    |   71 +
 doc/guides/rel_notes/release_26_03.rst     |    6 +
 drivers/net/meson.build                    |    1 +
 drivers/net/sxe/base/sxe_common.c          |   45 +
 drivers/net/sxe/base/sxe_common.h          |   13 +
 drivers/net/sxe/base/sxe_compat_platform.h |   73 +
 drivers/net/sxe/base/sxe_compat_version.h  |   34 +
 drivers/net/sxe/base/sxe_errno.h           |   61 +
 drivers/net/sxe/base/sxe_hw.c              | 3271 ++++++++++++++++++++
 drivers/net/sxe/base/sxe_hw.h              | 1010 ++++++
 drivers/net/sxe/base/sxe_logs.h            |  105 +
 drivers/net/sxe/base/sxe_offload_common.c  |   54 +
 drivers/net/sxe/base/sxe_offload_common.h  |   14 +
 drivers/net/sxe/base/sxe_queue_common.c    |  450 +++
 drivers/net/sxe/base/sxe_queue_common.h    |  240 ++
 drivers/net/sxe/base/sxe_rx_common.c       |  358 +++
 drivers/net/sxe/base/sxe_rx_common.h       |   17 +
 drivers/net/sxe/base/sxe_tx_common.c       |   40 +
 drivers/net/sxe/base/sxe_tx_common.h       |   12 +
 drivers/net/sxe/base/sxe_types.h           |   40 +
 drivers/net/sxe/base/sxevf_hw.c            |  819 +++++
 drivers/net/sxe/base/sxevf_hw.h            |  318 ++
 drivers/net/sxe/base/sxevf_regs.h          |  119 +
 drivers/net/sxe/include/drv_msg.h          |   18 +
 drivers/net/sxe/include/sxe/sxe_cli.h      |  218 ++
 drivers/net/sxe/include/sxe/sxe_hdc.h      |   43 +
 drivers/net/sxe/include/sxe/sxe_ioctl.h    |   21 +
 drivers/net/sxe/include/sxe/sxe_msg.h      |  135 +
 drivers/net/sxe/include/sxe/sxe_regs.h     | 1270 ++++++++
 drivers/net/sxe/include/sxe_type.h         |  795 +++++
 drivers/net/sxe/include/sxe_version.h      |   29 +
 drivers/net/sxe/meson.build                |   65 +
 drivers/net/sxe/pf/rte_pmd_sxe.h           |   19 +
 drivers/net/sxe/pf/sxe.h                   |   93 +
 drivers/net/sxe/pf/sxe_dcb.c               |  945 ++++++
 drivers/net/sxe/pf/sxe_dcb.h               |   99 +
 drivers/net/sxe/pf/sxe_ethdev.c            |  928 ++++++
 drivers/net/sxe/pf/sxe_ethdev.h            |   28 +
 drivers/net/sxe/pf/sxe_filter.c            |  923 ++++++
 drivers/net/sxe/pf/sxe_filter.h            |  109 +
 drivers/net/sxe/pf/sxe_flow_ctrl.c         |   98 +
 drivers/net/sxe/pf/sxe_flow_ctrl.h         |   16 +
 drivers/net/sxe/pf/sxe_irq.c               |  516 +++
 drivers/net/sxe/pf/sxe_irq.h               |   48 +
 drivers/net/sxe/pf/sxe_main.c              |  196 ++
 drivers/net/sxe/pf/sxe_offload.c           |  336 ++
 drivers/net/sxe/pf/sxe_offload.h           |   51 +
 drivers/net/sxe/pf/sxe_phy.c               |  953 ++++++
 drivers/net/sxe/pf/sxe_phy.h               |  117 +
 drivers/net/sxe/pf/sxe_pmd_hdc.c           |  661 ++++
 drivers/net/sxe/pf/sxe_pmd_hdc.h           |   42 +
 drivers/net/sxe/pf/sxe_ptp.c               |  209 ++
 drivers/net/sxe/pf/sxe_ptp.h               |   26 +
 drivers/net/sxe/pf/sxe_queue.c             |  774 +++++
 drivers/net/sxe/pf/sxe_queue.h             |  132 +
 drivers/net/sxe/pf/sxe_rx.c                | 1459 +++++++++
 drivers/net/sxe/pf/sxe_rx.h                |  188 ++
 drivers/net/sxe/pf/sxe_stats.c             |  586 ++++
 drivers/net/sxe/pf/sxe_stats.h             |   69 +
 drivers/net/sxe/pf/sxe_tx.c                | 1051 +++++++
 drivers/net/sxe/pf/sxe_tx.h                |   50 +
 drivers/net/sxe/pf/sxe_vec_common.h        |  321 ++
 drivers/net/sxe/pf/sxe_vec_neon.c          |  600 ++++
 drivers/net/sxe/pf/sxe_vec_sse.c           |  622 ++++
 drivers/net/sxe/pf/sxe_vf.c                | 1199 +++++++
 drivers/net/sxe/pf/sxe_vf.h                |  200 ++
 drivers/net/sxe/sxe_drv_type.h             |   15 +
 drivers/net/sxe/sxe_testpmd.c              |  196 ++
 drivers/net/sxe/vf/sxevf.h                 |   42 +
 drivers/net/sxe/vf/sxevf_ethdev.c          |  752 +++++
 drivers/net/sxe/vf/sxevf_ethdev.h          |   16 +
 drivers/net/sxe/vf/sxevf_filter.c          |  493 +++
 drivers/net/sxe/vf/sxevf_filter.h          |   70 +
 drivers/net/sxe/vf/sxevf_irq.c             |  432 +++
 drivers/net/sxe/vf/sxevf_irq.h             |   34 +
 drivers/net/sxe/vf/sxevf_main.c            |   82 +
 drivers/net/sxe/vf/sxevf_msg.c             |  624 ++++
 drivers/net/sxe/vf/sxevf_msg.h             |  201 ++
 drivers/net/sxe/vf/sxevf_offload.c         |   30 +
 drivers/net/sxe/vf/sxevf_offload.h         |   16 +
 drivers/net/sxe/vf/sxevf_queue.c           |  208 ++
 drivers/net/sxe/vf/sxevf_queue.h           |   69 +
 drivers/net/sxe/vf/sxevf_rx.c              |  162 +
 drivers/net/sxe/vf/sxevf_rx.h              |   18 +
 drivers/net/sxe/vf/sxevf_stats.c           |  162 +
 drivers/net/sxe/vf/sxevf_stats.h           |   31 +
 drivers/net/sxe/vf/sxevf_tx.c              |   46 +
 drivers/net/sxe/vf/sxevf_tx.h              |   14 +
 92 files changed, 27237 insertions(+)
 create mode 100644 doc/guides/nics/features/sxe.ini
 create mode 100644 doc/guides/nics/features/sxe_vf.ini
 create mode 100644 doc/guides/nics/sxe.rst
 create mode 100644 drivers/net/sxe/base/sxe_common.c
 create mode 100644 drivers/net/sxe/base/sxe_common.h
 create mode 100644 drivers/net/sxe/base/sxe_compat_platform.h
 create mode 100644 drivers/net/sxe/base/sxe_compat_version.h
 create mode 100644 drivers/net/sxe/base/sxe_errno.h
 create mode 100644 drivers/net/sxe/base/sxe_hw.c
 create mode 100644 drivers/net/sxe/base/sxe_hw.h
 create mode 100644 drivers/net/sxe/base/sxe_logs.h
 create mode 100644 drivers/net/sxe/base/sxe_offload_common.c
 create mode 100644 drivers/net/sxe/base/sxe_offload_common.h
 create mode 100644 drivers/net/sxe/base/sxe_queue_common.c
 create mode 100644 drivers/net/sxe/base/sxe_queue_common.h
 create mode 100644 drivers/net/sxe/base/sxe_rx_common.c
 create mode 100644 drivers/net/sxe/base/sxe_rx_common.h
 create mode 100644 drivers/net/sxe/base/sxe_tx_common.c
 create mode 100644 drivers/net/sxe/base/sxe_tx_common.h
 create mode 100644 drivers/net/sxe/base/sxe_types.h
 create mode 100644 drivers/net/sxe/base/sxevf_hw.c
 create mode 100644 drivers/net/sxe/base/sxevf_hw.h
 create mode 100644 drivers/net/sxe/base/sxevf_regs.h
 create mode 100644 drivers/net/sxe/include/drv_msg.h
 create mode 100644 drivers/net/sxe/include/sxe/sxe_cli.h
 create mode 100644 drivers/net/sxe/include/sxe/sxe_hdc.h
 create mode 100644 drivers/net/sxe/include/sxe/sxe_ioctl.h
 create mode 100644 drivers/net/sxe/include/sxe/sxe_msg.h
 create mode 100644 drivers/net/sxe/include/sxe/sxe_regs.h
 create mode 100644 drivers/net/sxe/include/sxe_type.h
 create mode 100644 drivers/net/sxe/include/sxe_version.h
 create mode 100644 drivers/net/sxe/meson.build
 create mode 100644 drivers/net/sxe/pf/rte_pmd_sxe.h
 create mode 100644 drivers/net/sxe/pf/sxe.h
 create mode 100644 drivers/net/sxe/pf/sxe_dcb.c
 create mode 100644 drivers/net/sxe/pf/sxe_dcb.h
 create mode 100644 drivers/net/sxe/pf/sxe_ethdev.c
 create mode 100644 drivers/net/sxe/pf/sxe_ethdev.h
 create mode 100644 drivers/net/sxe/pf/sxe_filter.c
 create mode 100644 drivers/net/sxe/pf/sxe_filter.h
 create mode 100644 drivers/net/sxe/pf/sxe_flow_ctrl.c
 create mode 100644 drivers/net/sxe/pf/sxe_flow_ctrl.h
 create mode 100644 drivers/net/sxe/pf/sxe_irq.c
 create mode 100644 drivers/net/sxe/pf/sxe_irq.h
 create mode 100644 drivers/net/sxe/pf/sxe_main.c
 create mode 100644 drivers/net/sxe/pf/sxe_offload.c
 create mode 100644 drivers/net/sxe/pf/sxe_offload.h
 create mode 100644 drivers/net/sxe/pf/sxe_phy.c
 create mode 100644 drivers/net/sxe/pf/sxe_phy.h
 create mode 100644 drivers/net/sxe/pf/sxe_pmd_hdc.c
 create mode 100644 drivers/net/sxe/pf/sxe_pmd_hdc.h
 create mode 100644 drivers/net/sxe/pf/sxe_ptp.c
 create mode 100644 drivers/net/sxe/pf/sxe_ptp.h
 create mode 100644 drivers/net/sxe/pf/sxe_queue.c
 create mode 100644 drivers/net/sxe/pf/sxe_queue.h
 create mode 100644 drivers/net/sxe/pf/sxe_rx.c
 create mode 100644 drivers/net/sxe/pf/sxe_rx.h
 create mode 100644 drivers/net/sxe/pf/sxe_stats.c
 create mode 100644 drivers/net/sxe/pf/sxe_stats.h
 create mode 100644 drivers/net/sxe/pf/sxe_tx.c
 create mode 100644 drivers/net/sxe/pf/sxe_tx.h
 create mode 100644 drivers/net/sxe/pf/sxe_vec_common.h
 create mode 100644 drivers/net/sxe/pf/sxe_vec_neon.c
 create mode 100644 drivers/net/sxe/pf/sxe_vec_sse.c
 create mode 100644 drivers/net/sxe/pf/sxe_vf.c
 create mode 100644 drivers/net/sxe/pf/sxe_vf.h
 create mode 100644 drivers/net/sxe/sxe_drv_type.h
 create mode 100644 drivers/net/sxe/sxe_testpmd.c
 create mode 100644 drivers/net/sxe/vf/sxevf.h
 create mode 100644 drivers/net/sxe/vf/sxevf_ethdev.c
 create mode 100644 drivers/net/sxe/vf/sxevf_ethdev.h
 create mode 100644 drivers/net/sxe/vf/sxevf_filter.c
 create mode 100644 drivers/net/sxe/vf/sxevf_filter.h
 create mode 100644 drivers/net/sxe/vf/sxevf_irq.c
 create mode 100644 drivers/net/sxe/vf/sxevf_irq.h
 create mode 100644 drivers/net/sxe/vf/sxevf_main.c
 create mode 100644 drivers/net/sxe/vf/sxevf_msg.c
 create mode 100644 drivers/net/sxe/vf/sxevf_msg.h
 create mode 100644 drivers/net/sxe/vf/sxevf_offload.c
 create mode 100644 drivers/net/sxe/vf/sxevf_offload.h
Quoted 9 lines
 create mode 100644 drivers/net/sxe/vf/sxevf_queue.c
 create mode 100644 drivers/net/sxe/vf/sxevf_queue.h
 create mode 100644 drivers/net/sxe/vf/sxevf_rx.c
 create mode 100644 drivers/net/sxe/vf/sxevf_rx.h
 create mode 100644 drivers/net/sxe/vf/sxevf_stats.c
 create mode 100644 drivers/net/sxe/vf/sxevf_stats.h
 create mode 100644 drivers/net/sxe/vf/sxevf_tx.c
 create mode 100644 drivers/net/sxe/vf/sxevf_tx.h

Since this is a new driver. added an AI review of documentation (features matrix) vs code

Implemented (ops wired up):
Feature Status Evidence
Speed capabilities ✅ dev_infos_get reports speed_capa
Link speed configuration ✅ dev_set_link_up / dev_set_link_down
Link status ✅ link_update
Link status event ✅ LSC interrupt handler + SXE_IRQ_LINK_UPDATE
Rx interrupt ✅ rx_queue_intr_enable / rx_queue_intr_disable
Queue start/stop ✅ rx_queue_start/stop, tx_queue_start/stop
MTU update ✅ mtu_set
Scattered Rx ✅ scattered_rx logic in queue configure
LRO ✅ LRO Rx burst functions
TSO ✅ TSO offload in tx_offload_capa
Promiscuous mode ✅ promiscuous_enable / promiscuous_disable
Allmulticast mode ✅ allmulticast_enable / allmulticast_disable
Unicast MAC filter ✅ mac_addr_add / mac_addr_remove / mac_addr_set
Multicast MAC filter ✅ set_mc_addr_list
RSS hash ✅ rss_hash_update / rss_hash_conf_get
RSS key update ✅ via rss_hash_update
RSS reta update ✅ reta_update / reta_query
VMDq ✅ VMDQ configure code present
SR-IOV ✅ VF driver in patch 13, sxe_vt_configure
DCB ✅ get_dcb_info, DCB configure functions
VLAN filter ✅ vlan_filter_set
Flow control ✅ flow_ctrl_get / flow_ctrl_set / priority_flow_ctrl_set
CRC offload ✅ RTE_ETH_RX_OFFLOAD_KEEP_CRC handling
VLAN offload ✅ vlan_offload_set / vlan_strip_queue_set / vlan_tpid_set
L3/L4 checksum offload ✅ In offload capabilities
Packet type parsing ✅ dev_supported_ptypes_get, ptype tables
Timesync ✅ Full set of timesync ops
Rx descriptor status ✅ Assigned to eth_dev->rx_descriptor_status
Tx descriptor status ✅ Assigned to eth_dev->tx_descriptor_status
Basic stats ✅ stats_get / stats_reset
Extended stats ✅ xstats_get / xstats_reset / xstats_get_names
Stats per queue ✅ queue_stats_mapping_set
FW version ✅ fw_version_get
Registers dump ✅ get_reg
Module EEPROM dump ✅ get_module_info / get_module_eeprom
Linux ✅ Platform code present
x86-64 ✅ SIMD code in patch 12

Claimed but NOT implemented (no ops wired):
Feature Status Notes
EEPROM dump ❌ No get_eeprom_length or get_eeprom ops wired. sxe.ini claims EEPROM dump = Y but there's no get_eeprom callback in sxe_eth_dev_ops. Module EEPROM (get_module_eeprom) is present but that's a different feature.
Power mgmt address monitor ❓ No get_monitor_addr op visible in the ops struct. This feature requires the PMD to implement get_monitor_addr to support rte_power_monitor().
QinQ offload ❓ Claimed as P (partial). vlan_tpid_set is present, but I didn't see explicit QinQ double-tag handling in the offload path. The overhead calculations reference 2 * SXE_VLAN_TAG_SIZE suggesting awareness, but the actual hardware offload for QinQ insertion/stripping needs verification.
Inner L3/L4 checksum ❓ Claimed as P. The ptype tables cover NVGRE/VXLAN tunnel types, but whether inner checksum offload is actually wired in the Tx path needs verification against the offload capabilities returned.
ARMv8 ❓ Claimed as Y but the SIMD code in patch 12 appears to be x86-specific (SSE/AVX). No NEON intrinsics visible.

#321 lore raw

Re: [PATCH v18 00/13] net/sxe: added Linkdata sxe ethernet driver

In reply to [email protected]
Quoted 8 lines · On Tue, 3 Mar 2026 17:10:44 +0800 [email protected] wrote:

From: Jie Liu <[email protected]>

This patch set implements core functionality for the SXE PMD, including basic driver framework, data path setup, and advanced offload features (VLAN, RSS, DCB, PTP etc.).

v18:
- Addressed AI comments

Thanks for the revision. I still see some things which AI found that are worth addressing. Rather than bore you with the long version here is the summary. Ask if you want more detail.

---

**Errors (must fix):**

1. **Bitwise vs logical AND** — sxe_hw.c, sxe_hw_uc_addr_pool_disable(): if (!hi & !low) should be if (!hi && !low). Numerically equivalent here but wrong operator.

2. **Off-by-one bounds check** — sxe_hw.c, sxe_hw_uc_addr_pool_enable(): uses rar_idx > SXE_UC_ENTRY_NUM_MAX but sxe_hw_uc_addr_add() correctly uses >=. One of them is wrong.

3. **Data race on global sxe_trace_id** — sxe_common.c: sxe_trace_id++ is called from sxe_driver_cmd_trans() before the HDC spinlock is acquired. Multiple threads can race on this non-atomic increment.

4. **#define false 0 / #define true 1** — sxe_compat_platform.h: conflicts with <stdbool.h> which is included elsewhere. UB per C99 §7.1.3. Remove these and use <stdbool.h>.

5. **Spinlock held 2.5+ seconds** — sxe_pmd_hdc.c, sxe_hdc_cmd_process(): rte_spinlock_t (busy-wait) held across 250 retries × 10ms. Other lcores burn CPU spinning. Use a sleeping lock or release between retries.

6. **Wrong length in multi-packet HDC response** — sxe_pmd_hdc.c, hdc_resp_process(): passes total resp_len to hdc_resp_data_rcv() for every packet instead of resp_len - offset. The last-dword partial-copy (out_len % 4) logic is wrong for packets after the first.

7. **MAINTAINERS name/email mismatch** — Lists "Jie Li <lijie@...>" but all patches are from "Jie Liu <liujie5@...>". Different person and different address.

8. **Double hardware reset in sxe_dev_close()** — Calls sxe_hw_reset() directly, then calls sxe_dev_stop() which calls sxe_hw_reset() again. Second reset may fail since HDC channel state was already altered.

---

**Warnings (should fix):**

1. **set_bit/clear_bit/test_and_clear_bit are not atomic** — sxe_compat_platform.h: plain read-modify-write on int *. If used from multiple threads, these are racy.

2. **Non-const lookup tables in hot path** — sxe_rx.h: error_to_pkt_flags_map, ip_rss_types_map should be static const.

3. **Dead code in sxe_dev_configure()** — Unused variables adapter, irq and unreachable l_end label.

4. **Misleading macro name** — SXE_USEC_PER_MS is 1000000 (nanoseconds per millisecond). Should be SXE_NSEC_PER_MS.

5. **strlcpy off-by-one** — sxe_hw_base_init(): strlcpy(adapter->name, ..., sizeof(adapter->name) - 1) wastes one byte. strlcpy already null-terminates; pass sizeof(adapter->name).

6. **sxe_fw_version_get** — resp.fw_version from HDC memcpy may not be null-terminated. snprintf will read past the field.

7. **HDC channel lifecycle not multi-device safe** — sxe_hdc_channel_init() initializes a single global spinlock. sxe_remove() calls sxe_hdc_channel_uninit() — if two SXE devices are probed, removing the first destroys the channel while the second still uses it.

8. **Feature matrix overclaims** — sxe.ini marks Traffic Manager, Inline Crypto, MACsec, Rate Limitation as Y/P, but none of the 13 patches implement these features.

9. **#ifdef __KERNEL__ dead code** — base/sxe_hw.c, base/sxevf_hw.c contain thousands of lines of Linux kernel code paths. Strip before submission to DPDK.

10. **sxe_vf_rss_rxq_num_validate return value check is inverted** — sxe_queue.c: if ((rx_q_num <= ...) && sxe_vf_rss_rxq_num_validate(dev, rx_q_num)) — the validate function returns 0 on success and negative on error, but the if treats a truthy (error) return as the success path for entering the error log. The condition logic needs review.

#323 lore raw
In reply to [email protected]
Quoted 7 lines · On Mon, 9 Feb 2026 09:24:46 +0800 [email protected] wrote:

From: Jie Liu <[email protected]>

Adding a minimum maintainable directory structure for the network driver and request maintenance of the sxe driver.

---

Next time please add a cover letter to large patch sets.

The AI review identified a long list of this that need changing.

# Review: [PATCH v17 01-13/13] net/sxe: Linkdata SXE NIC driver

## Errors

### 1. Patch 02 — sxe_dev_configure(): uninitialized return value

sxe_ethdev.c declares s32 ret; and immediately falls through to l_end: return ret; without ever assigning ret. This returns an indeterminate value to the caller.

```c
static s32 sxe_dev_configure(struct rte_eth_dev *dev)
{
    s32 ret;
    /* ... */
    PMD_INIT_FUNC_TRACE();

l_end:
    return ret;  /* ret never assigned */
}
```

**Fix:** Initialize ret = 0 or assign it from a meaningful operation.

---

### 2. Patch 02 — sxe_hdc_cmd_process(): all error codes silently overwritten

At label l_ret:, the line ret = pthread_sigmask(SIG_SETMASK, &old_mask, NULL); unconditionally overwrites ret. Every error path in this function (sem_wait failure, retry loop exhaustion, packet trans errors) reaches l_ret and has its error code replaced with the return value of pthread_sigmask (typically 0). The subsequent check if (ret == -SXE_HDC_RETRY_ERR) is then dead code.

This means the HDC command channel silently swallows all errors and reports success to callers.

```c
l_up:
    sem_post(sxe_hdc_sema_get());
l_ret:
    ret = pthread_sigmask(SIG_SETMASK, &old_mask, NULL);  /* overwrites error */
    if (ret)
        LOG_ERROR_BDF("...");

    if (ret == -SXE_HDC_RETRY_ERR)  /* dead code */
        ret = -EFAULT;

    return ret;
```

**Fix:** Save the original ret before restoring the signal mask and return it:

```c
l_up:
    sem_post(sxe_hdc_sema_get());
l_ret:
    if (pthread_sigmask(SIG_SETMASK, &old_mask, NULL) != 0)
        LOG_ERROR_BDF("...");

    if (ret == -SXE_HDC_RETRY_ERR)
        ret = -EFAULT;

    return ret;
```

---

### 3. Patch 13 — sxevf_dev_stop(): stop flag set to wrong value

The function sets adapter->stop = false when the device is being stopped. This should be true. The guard at the top if (adapter->stop) will therefore never trigger, and the device is never marked as stopped.

```c
static s32 sxevf_dev_stop(struct rte_eth_dev *dev)
{
    ...
    if (adapter->stop) {
        LOG_INFO_BDF("eth dev has been stopped.");
        goto l_out;
    }

    adapter->stop = false;  /* BUG: should be true */
```

**Fix:** adapter->stop = true;

---

### 4. Patch 04 — sxe_dev_start(): unsupported loopback mode leaks resources

After sxe_rx_configure(), sxe_irq_configure(), and sxe_txrx_start() have all run, an unsupported lpbk_mode value causes a goto l_end that skips the l_error cleanup path. This leaks IRQ vectors and queue resources.

```c
    sxe_txrx_start(dev);
    ...
    } else {
        ret = -ENOTSUP;
        PMD_LOG_ERR(INIT, "unsupported loopback mode:%u.",
                dev->data->dev_conf.lpbk_mode);
        goto l_end;  /* should be goto l_error */
    }
```

**Fix:** Change goto l_end to goto l_error.

---

### 5. Patch 02 — hdc_packet_send() / hdc_resp_data_rcv(): unaligned 32-bit memory access

Both functions cast arbitrary byte-offset pointers to u32 * and dereference them:

```c
pkg_data = *(u32 *)(data + offset);     /* hdc_packet_send */
*(u32 *)(out_data + offset) = pkt_data; /* hdc_resp_data_rcv */
```

If data/out_data is not 4-byte aligned, this causes undefined behavior and may fault on ARM (ARMv8 is listed as a supported architecture in sxe.ini).

**Fix:** Use memcpy for these accesses, or use rte_le_to_cpu_32/rte_cpu_to_le_32 with memcpy.

---

### 6. Patch 02 — sxe_fw_time_sync(): error silently dropped

The return value from sxe_fw_time_sync_process() is stored in ret_v but the function returns ret which remains 0 on this path, so the caller never sees the failure.

```c
    ret_v = sxe_fw_time_sync_process(hw);
    if (ret_v) {
        LOG_WARN_BDF("fw time sync failed, ret_v=%d", ret_v);
        goto l_ret;
    }

l_ret:
    return ret;  /* ret is still 0 */
```

**Fix:** Use ret instead of ret_v, or set ret = ret_v before the goto.

---

## Warnings

### 1. Patch 04 — Subject line contains commas

"net/sxe: add link, flow ctrl, mac ops, mtu ops function" — commas are forbidden punctuation in DPDK subject lines per check-git-log.sh. Consider splitting this patch or rephrasing (e.g., "net/sxe: add link and mac layer operations").

---

### 2. Patch 02 — Commit message body contains non-ASCII characters

"Add basic modules: logs、 hardware communication、common components" — the 、 characters are Chinese punctuation (U+3001). Use standard ASCII commas.

---

### 3. Patch 01 — Release note says "Updated" for a new driver

The release note reads **Updated Linkdata sxe ethernet driver.** but this is a new driver, not an update. It should use the **Added** or **New** convention (e.g., **Added Linkdata sxe ethernet driver.**), matching the New Features section it's placed in.

---

### 4. Patch 02 — rte_zmalloc() used for control-path temporary buffers

In sxe_driver_cmd_trans(), rte_zmalloc() allocates temporary HDC request/response buffers. These don't need hugepage memory (no DMA, no shared-memory requirement). Standard calloc() would be faster and not consume limited hugepage resources.

---

### 5. Patch 02 — Global HDC semaphore shared across all PCI devices

g_hdc_sem is a single global semaphore. All SXE PFs serialize HDC firmware commands through it. If multiple SXE NICs are present, they will unnecessarily block each other. Consider a per-device semaphore.

---

### 6. Patch 02 — sxe_irq_vec_free() directly accesses handle->intr_vec

The function directly accesses handle->intr_vec instead of using the DPDK interrupt API (rte_intr_vec_list_free()). Direct field access may break with future DPDK versions where the interrupt handle is opaque.

---

## Info

- The series is at v17, indicating extensive prior review. The overall structure follows DPDK PMD conventions with proper SPDX headers, meson integration, feature documentation, and release notes.
- The base sxe_hw.c at ~6200 lines is large for a single file. Consider splitting register-group definitions from operational logic if practical.
- Several functions across the series have unused variables (e.g., pci_dev in sxe_dev_infos_get in patch 02, link/num declared early in sxe_dev_stop in patch 02). These will generate compiler warnings with -Wunused-variable depending on #ifdef configurations.

#324 lore raw
In reply to [email protected]
Quoted 6 lines · On Thu, 25 Dec 2025 17:22:12 +0800 [email protected] wrote:

From: Jie Liu <[email protected]>

Adding a minimum maintainable directory structure for the network driver and request maintenance of the sxe driver.

I do not like that this driver has to invent its own tracing facility. The DPDK already has one, and adding a driver specific tracing is a bad precedent. The goal of DPDK is to abstract the interface to the hardware and make it possible for applications to work everywhere.

I understand that you may need/want more data to resolve internal driver bugs. Is it possible to use existing trace API for this.

Build is failing please resolve the issues and resubmit.

#325 lore raw

PATCH v13 1/13 net/sxe: add base driver directory and doc

In reply to [email protected]

From: Jie Liu <[email protected]>

Adding a minimum maintainable directory structure for the network driver and request maintenance of the sxe driver.

---
 MAINTAINERS                            |  6 +++
 doc/guides/nics/features/sxe.ini       | 55 ++++++++++++++++++++
 doc/guides/nics/features/sxe_vf.ini    | 37 ++++++++++++++
 doc/guides/nics/index.rst              |  1 +
 doc/guides/nics/sxe.rst                | 71 ++++++++++++++++++++++++++
 doc/guides/rel_notes/release_26_03.rst |  4 ++
 drivers/net/sxe/meson.build            |  9 ++++
 drivers/net/sxe/pf/sxe_ethdev.c        |  3 ++
 drivers/net/sxe/pf/sxe_ethdev.h        |  3 ++
 9 files changed, 189 insertions(+)
 create mode 100644 doc/guides/nics/features/sxe.ini
 create mode 100644 doc/guides/nics/features/sxe_vf.ini
 create mode 100644 doc/guides/nics/sxe.rst
 create mode 100644 drivers/net/sxe/meson.build
 create mode 100644 drivers/net/sxe/pf/sxe_ethdev.c
 create mode 100644 drivers/net/sxe/pf/sxe_ethdev.h
MAINTAINERS +6 -0
index d7d8dbdb25..034dea8908 100644
@@ -859,6 +859,12 @@ F: drivers/net/intel/ipn3ke/
 F: doc/guides/nics/ipn3ke.rst
 F: doc/guides/nics/features/ipn3ke.ini
 
+Linkdata sxe
+M: Jie Li <[email protected]>
+F: drivers/net/sxe/
+F: doc/guides/nics/sxe.rst
+F: doc/guides/nics/features/sxe*.ini
+
 Marvell cnxk
 M: Nithin Dabilpuram <[email protected]>
 M: Kiran Kumar K <[email protected]>
doc/guides/nics/features/sxe.ini new file +55 -0

55 lines not on this page · raw message

doc/guides/nics/features/sxe_vf.ini new file +37 -0
new file mode 100644
index 0000000000..7caf5435ae
@@ -0,0 +1,37 @@
+;
+; Supported features of the 'sxe_vf' network poll mode driver.
+;
+; Refer to default.ini for the full list of available PMD features.
+;
+[Features]
+Link status          = Y
+Rx interrupt         = Y
+Power mgmt address monitor = Y
+MTU update           = Y
+Scattered Rx         = Y
+LRO                  = Y
+TSO                  = Y
+Promiscuous mode     = Y
+Allmulticast mode    = Y
+Unicast MAC filter   = Y
+RSS hash             = Y
+RSS key update       = Y
+RSS reta update      = Y
+VLAN filter          = Y
+Inline crypto        = Y
+CRC offload          = P
+VLAN offload         = P
+QinQ offload         = P
+L3 checksum offload  = P
+L4 checksum offload  = P
+Inner L3 checksum    = P
+Inner L4 checksum    = P
+Packet type parsing  = Y
+Rx descriptor status = Y
+Tx descriptor status = Y
+Basic stats          = Y
+Extended stats       = Y
+Registers dump       = Y
+Linux                = Y
+ARMv8                = Y
+x86-64               = Y
doc/guides/nics/index.rst +1 -0
index b00ed998c5..3d9e359f6b 100644
@@ -67,6 +67,7 @@ Network Interface Controller Drivers
     rnp
     sfc_efx
     softnic
+    sxe
     tap
     thunderx
     txgbe
doc/guides/nics/sxe.rst new file +71 -0

71 lines not on this page · raw message

doc/guides/rel_notes/release_26_03.rst +4 -0
index 15dabee7a1..fd8fc0c2e4 100644
@@ -54,7 +54,11 @@ New Features
      This section is a comment. Do not overwrite or remove it.
      Also, make sure to start the actual text at the margin.
      =======================================================
+* **Updated Linkdata sxe ethernet driver.**
 
+  Added support for Linkdata NIC series, including 1160-2X (supporting 10G).
+  As these new models share hardware similarities with the existing 10G Sapphire NICs,
+  many of the existing configurations and practices are expected to apply.
 
 Removed Items
 -------------
drivers/net/sxe/meson.build new file +9 -0
new file mode 100644
index 0000000000..dad9ee44a0
@@ -0,0 +1,9 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright (C), 2020, Wuxi Stars Micro System Technologies Co., Ltd.
+
+deps += ['hash']
+sources = files(
+        'pf/sxe_ethdev.c',
+)
+
+includes += include_directories('pf')
drivers/net/sxe/pf/sxe_ethdev.c new file +3 -0
new file mode 100644
index 0000000000..e31a23deeb
@@ -0,0 +1,3 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2015-2024
+ */
drivers/net/sxe/pf/sxe_ethdev.h new file +3 -0
new file mode 100644
index 0000000000..e31a23deeb
@@ -0,0 +1,3 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2015-2024
+ */
Signature · 1 line
2.18.2
#326 lore raw

PATCH v13 2/13 net/sxe: add ethdev probe and remove MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit

From: Jie Liu <[email protected]>

Add basic modules: logs、 hardware communication、common components and support basic PCIe ethdev probe and remove.

---
 drivers/net/sxe/base/sxe_common.c          |   66 +
 drivers/net/sxe/base/sxe_common.h          |   15 +
 drivers/net/sxe/base/sxe_compat_platform.h |  126 +
 drivers/net/sxe/base/sxe_compat_version.h  |   34 +
 drivers/net/sxe/base/sxe_errno.h           |   61 +
 drivers/net/sxe/base/sxe_hw.c              | 6259 ++++++++++++++++++++
 drivers/net/sxe/base/sxe_hw.h              | 1537 +++++
 drivers/net/sxe/base/sxe_logs.h            |  105 +
 drivers/net/sxe/base/sxe_types.h           |   40 +
 drivers/net/sxe/include/drv_msg.h          |   18 +
 drivers/net/sxe/include/sxe/sxe_hdc.h      |   42 +
 drivers/net/sxe/include/sxe/sxe_msg.h      |  135 +
 drivers/net/sxe/include/sxe/sxe_regs.h     | 1270 ++++
 drivers/net/sxe/include/sxe_version.h      |   29 +
 drivers/net/sxe/meson.build                |   20 +-
 drivers/net/sxe/pf/sxe.h                   |   56 +
 drivers/net/sxe/pf/sxe_ethdev.c            |  321 +-
 drivers/net/sxe/pf/sxe_ethdev.h            |   27 +-
 drivers/net/sxe/pf/sxe_irq.c               |  125 +
 drivers/net/sxe/pf/sxe_irq.h               |   39 +
 drivers/net/sxe/pf/sxe_main.c              |  181 +
 drivers/net/sxe/pf/sxe_phy.h               |   38 +
 drivers/net/sxe/pf/sxe_pmd_hdc.c           |  682 +++
 drivers/net/sxe/pf/sxe_pmd_hdc.h           |   44 +
 drivers/net/sxe/sxe_drv_type.h             |   15 +
 25 files changed, 11282 insertions(+), 3 deletions(-)
 create mode 100644 drivers/net/sxe/base/sxe_common.c
 create mode 100644 drivers/net/sxe/base/sxe_common.h
 create mode 100644 drivers/net/sxe/base/sxe_compat_platform.h
 create mode 100644 drivers/net/sxe/base/sxe_compat_version.h
 create mode 100644 drivers/net/sxe/base/sxe_errno.h
 create mode 100644 drivers/net/sxe/base/sxe_hw.c
 create mode 100644 drivers/net/sxe/base/sxe_hw.h
 create mode 100644 drivers/net/sxe/base/sxe_logs.h
 create mode 100644 drivers/net/sxe/base/sxe_types.h
 create mode 100644 drivers/net/sxe/include/drv_msg.h
 create mode 100644 drivers/net/sxe/include/sxe/sxe_hdc.h
 create mode 100644 drivers/net/sxe/include/sxe/sxe_msg.h
 create mode 100644 drivers/net/sxe/include/sxe/sxe_regs.h
 create mode 100644 drivers/net/sxe/include/sxe_version.h
 create mode 100644 drivers/net/sxe/pf/sxe.h
 create mode 100644 drivers/net/sxe/pf/sxe_irq.c
 create mode 100644 drivers/net/sxe/pf/sxe_irq.h
 create mode 100644 drivers/net/sxe/pf/sxe_main.c
 create mode 100644 drivers/net/sxe/pf/sxe_phy.h
 create mode 100644 drivers/net/sxe/pf/sxe_pmd_hdc.c
 create mode 100644 drivers/net/sxe/pf/sxe_pmd_hdc.h
 create mode 100644 drivers/net/sxe/sxe_drv_type.h
drivers/net/sxe/base/sxe_common.c new file +66 -0
new file mode 100644
index 0000000000..8b3fb13e73
@@ -0,0 +1,66 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (C), 2022, Linkdata Technology Co., Ltd.
+ */
+
+#include <pthread.h>
+#include <sys/time.h>
+#include <sys/types.h>
+#include <unistd.h>
+#include <rte_common.h>
+#include <rte_cycles.h>
+#include <time.h>
+#include "sxe_types.h"
+#include "sxe_common.h"
+
+#define SXE_TRACE_ID_COUNT_MASK  0x00000000000000FFLLU
+#define SXE_TRACE_ID_TID_MASK	0x0000000000FFFF00LLU
+#define SXE_TRACE_ID_TIME_MASK   0x00FFFFFFFF000000LLU
+#define SXE_TRACE_ID_FLAG		0xFF00000000000000LLU
+
+#define SXE_TRACE_ID_COUNT_SHIFT 0
+#define SXE_TRACE_ID_TID_SHIFT   8
+#define SXE_TRACE_ID_TIME_SHIFT  24
+
+#define SXE_SEC_TO_MS(sec) ((sec) * 1000ULL)
+#define SXE_SEC_TO_NS(sec) ((sec) * 1000000000ULL)
+
+#define SXE_USEC_PER_MS		  1000000
+
+u64 sxe_trace_id;
+
+u64 sxe_time_get_real_ms(void)
+{
+	u64 ms = 0;
+	struct timespec ts;
+	s32 ret = clock_gettime(CLOCK_MONOTONIC, &ts);
+	if (ret < 0)
+		goto l_end;
+
+	ms = SXE_SEC_TO_MS(ts.tv_sec) + ts.tv_nsec / SXE_USEC_PER_MS;
+
+l_end:
+	return ms;
+}
+
+u64 sxe_trace_id_gen(void)
+{
+	u64 tid	   = getpid() + (pthread_self() << 20);
+	u64 index	 = 0;
+	u64 timestamp = sxe_time_get_real_ms();
+
+	sxe_trace_id = (SXE_TRACE_ID_FLAG)
+		| ((timestamp << SXE_TRACE_ID_TIME_SHIFT) & SXE_TRACE_ID_TIME_MASK)
+		| ((tid << SXE_TRACE_ID_TID_SHIFT) & SXE_TRACE_ID_TID_MASK)
+		| ((index << SXE_TRACE_ID_COUNT_SHIFT) & SXE_TRACE_ID_COUNT_MASK);
+	return sxe_trace_id;
+}
+
+void sxe_trace_id_clean(void)
+{
+	sxe_trace_id = 0;
+}
+
+u64 sxe_trace_id_get(void)
+{
+	return sxe_trace_id++;
+}
drivers/net/sxe/base/sxe_common.h new file +15 -0
new file mode 100644
index 0000000000..43c062b937
@@ -0,0 +1,15 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (C), 2022, Linkdata Technology Co., Ltd.
+ */
+#ifndef __SXE_DPDK_COMMON_H__
+#define __SXE_DPDK_COMMON_H__
+
+u64 sxe_trace_id_gen(void);
+
+void sxe_trace_id_clean(void);
+
+u64 sxe_trace_id_get(void);
+
+u64 sxe_time_get_real_ms(void);
+
+#endif
drivers/net/sxe/base/sxe_compat_platform.h new file +126 -0

126 lines not on this page · raw message

drivers/net/sxe/base/sxe_compat_version.h new file +34 -0
new file mode 100644
index 0000000000..7eb9f37da6
@@ -0,0 +1,34 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (C), 2022, Linkdata Technology Co., Ltd.
+ */
+
+#ifndef __SXE_COMPAT_VERSION_H__
+#define __SXE_COMPAT_VERSION_H__
+
+#include <stdbool.h>
+
+struct rte_eth_dev;
+enum rte_eth_event_type;
+
+int sxe_eth_dev_callback_process(struct rte_eth_dev *dev,
+	enum rte_eth_event_type event, void *ret_param);
+
+#define PCI_REG_WC_WRITE
+
+#ifndef PCI_REG_WC_WRITE
+#define rte_write32_wc rte_write32
+#define rte_write32_wc_relaxed rte_write32_relaxed
+#endif
+
+#define SXE_PCI_INTR_HANDLE(pci_dev) \
+	((pci_dev)->intr_handle)
+#define SXE_DEV_FNAV_CONF(dev) \
+	(&((struct sxe_adapter *)(dev)->data->dev_private)->fnav_conf)
+#define RTE_ADAPTER_HAVE_FNAV_CONF
+#define SXE_GET_FRAME_SIZE(dev) \
+	((dev)->data->mtu + SXE_ETH_OVERHEAD)
+
+#define DEV_RX_OFFLOAD_CHECKSUM RTE_ETH_RX_OFFLOAD_CHECKSUM
+#define ETH_DCB_NUM_USER_PRIORITIES RTE_ETH_DCB_NUM_USER_PRIORITIES
+
+#endif
drivers/net/sxe/base/sxe_errno.h new file +61 -0

61 lines not on this page · raw message

drivers/net/sxe/base/sxe_hw.c new file +6259 -0

2,698 lines not on this page · raw message

drivers/net/sxe/base/sxe_hw.h new file +1537 -0

1,537 lines not on this page · raw message

drivers/net/sxe/base/sxe_logs.h new file +105 -0

105 lines not on this page · raw message

drivers/net/sxe/base/sxe_types.h new file +40 -0
new file mode 100644
index 0000000000..a36a3cfbf6

Lines of this file are not shown. View the raw message.

drivers/net/sxe/include/drv_msg.h new file +18 -0
new file mode 100644
index 0000000000..87c505569d

Lines of this file are not shown. View the raw message.

drivers/net/sxe/include/sxe/sxe_hdc.h new file +42 -0

42 lines not on this page · raw message

drivers/net/sxe/include/sxe/sxe_msg.h new file +135 -0

135 lines not on this page · raw message

drivers/net/sxe/include/sxe/sxe_regs.h new file +1270 -0

1,270 lines not on this page · raw message

drivers/net/sxe/include/sxe_version.h new file +29 -0
new file mode 100644
index 0000000000..fb58e73399

Lines of this file are not shown. View the raw message.

drivers/net/sxe/meson.build +19 -1
index dad9ee44a0..598fce480d 100644

Lines of this file are not shown. View the raw message.

drivers/net/sxe/pf/sxe.h new file +56 -0

56 lines not on this page · raw message

drivers/net/sxe/pf/sxe_ethdev.c +320 -1

321 lines not on this page · raw message

drivers/net/sxe/pf/sxe_ethdev.h +26 -1
index e31a23deeb..66034343ea 100644

Lines of this file are not shown. View the raw message.

drivers/net/sxe/pf/sxe_irq.c new file +125 -0

125 lines not on this page · raw message

drivers/net/sxe/pf/sxe_irq.h new file +39 -0
new file mode 100644
index 0000000000..e3a7da6ae8

Lines of this file are not shown. View the raw message.

drivers/net/sxe/pf/sxe_main.c new file +181 -0

181 lines not on this page · raw message

drivers/net/sxe/pf/sxe_phy.h new file +38 -0
new file mode 100644
index 0000000000..2947d88812

Lines of this file are not shown. View the raw message.

drivers/net/sxe/pf/sxe_pmd_hdc.c new file +682 -0

682 lines not on this page · raw message

drivers/net/sxe/pf/sxe_pmd_hdc.h new file +44 -0

44 lines not on this page · raw message

drivers/net/sxe/sxe_drv_type.h new file +15 -0
new file mode 100644
index 0000000000..027c0571a4

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.18.2

Part of the diff is not shown here. View the raw message.

#327 lore raw
In reply to [email protected]
Quoted 6 lines · On Mon, 28 Jul 2025 17:05:05 +0800 [email protected] wrote:

From: Jie Liu <[email protected]>

Adding a minimum maintainable directory structure for the network driver and request maintenance of the sxe driver.

Quoted 16 lines
---
 MAINTAINERS                         |  6 +++
 doc/guides/nics/features/sxe.ini    | 55 ++++++++++++++++++++++
 doc/guides/nics/features/sxe_vf.ini | 37 +++++++++++++++
 doc/guides/nics/index.rst           |  1 +
 doc/guides/nics/sxe.rst             | 71 +++++++++++++++++++++++++++++
 drivers/net/sxe/meson.build         |  9 ++++
 drivers/net/sxe/pf/sxe_ethdev.c     |  3 ++
 drivers/net/sxe/pf/sxe_ethdev.h     |  3 ++
 8 files changed, 185 insertions(+)
 create mode 100644 doc/guides/nics/features/sxe.ini
 create mode 100644 doc/guides/nics/features/sxe_vf.ini
 create mode 100644 doc/guides/nics/sxe.rst
 create mode 100644 drivers/net/sxe/meson.build
 create mode 100644 drivers/net/sxe/pf/sxe_ethdev.c
 create mode 100644 drivers/net/sxe/pf/sxe_ethdev.h

You need to add a release not do doc/guide/rel_notes/release_25_11.rst

PS: if you have trouble using AI to summarize for release notes is easy and fine.

#328 lore raw
In reply to [email protected]
Quoted 5 lines · On Mon, 28 Jul 2025 17:05:05 +0800 [email protected] wrote:
MAINTAINERS +0 -0
index 0e9357f3a3..b286452143 100644

MAINTAINERS F: examples/vmdq/ · line 2082

Quoted 9 lines
MAINTAINERS +6 -0
@@ -2074,3 +2074,9 @@ F: examples/vmdq/
 F: doc/guides/sample_app_ug/vmdq_forwarding.rst
 F: examples/vmdq_dcb/
 F: doc/guides/sample_app_ug/vmdq_dcb_forwarding.rst
+
+Linkdata sxe
+M: Jie Li <[email protected]>
+F: drivers/net/sxe/
+F: doc/guides/nics/sxe.rst
+F: doc/guides/nics/features/sxe*.ini

Maintainers file is kept in alphabetic order in the networking drivers section. This should go after "Intel ipn3ke" and before "Marvell cnxk"

#329 lore raw
In reply to [email protected]

The following patch may help you fix the driver and have it build on current 25.11-rc1 or later.

drivers/net/sxe/pf/sxe_queue.c +1 -1
index 75287defda..59447cc8af 100644
@@ -676,7 +676,7 @@ s32 __rte_cold sxe_rx_queue_stop(struct rte_eth_dev *dev, u16 queue_id)
 	return 0;
 }
 
-u32 sxe_rx_queue_count(void *rx_queue)
+s32 sxe_rx_queue_count(void *rx_queue)
 {
 	volatile sxe_rx_data_desc_u *desc;
 	struct sxe_rx_queue *rxq;
drivers/net/sxe/pf/sxe_queue.h +1 -1
index 43d8d4d633..c60bc6b9c2 100644
@@ -76,7 +76,7 @@ void sxe_rx_queue_init(bool rx_batch_alloc_allowed,
 
 void sxe_rx_queue_free(sxe_rx_queue_s *rxq);
 
-u32 sxe_rx_queue_count(void *rx_queue);
+s32 sxe_rx_queue_count(void *rx_queue);
 
 s32 sxe_mq_mode_check(struct rte_eth_dev *dev);
 
drivers/net/sxe/pf/sxe_stats.c +11 -10
index 34470eae64..dd3196b75d 100644
@@ -93,8 +93,8 @@ u32 sxe_xstats_cnt_get(void)
 }
 #endif
 
-s32 sxe_eth_stats_get(struct rte_eth_dev *eth_dev,
-				struct rte_eth_stats *stats)
+s32 sxe_eth_stats_get(struct rte_eth_dev *eth_dev, struct rte_eth_stats *stats,
+		      struct eth_queue_stats *qstats)
 {
 	struct sxe_adapter *adapter = eth_dev->data->dev_private;
 	struct sxe_stats_info *stats_info = &adapter->stats_info;
@@ -112,16 +112,17 @@ s32 sxe_eth_stats_get(struct rte_eth_dev *eth_dev,
 		goto l_out;
 	}
 
-	for (i = 0; i < RTE_MIN_T(SXE_QUEUE_STAT_COUNT,
-		RTE_ETHDEV_QUEUE_STAT_CNTRS, typeof(i)); i++) {
+	for (i = 0; i < SXE_QUEUE_STAT_COUNT; i++) {
 		rx_packets += stats_info->hw_stats.qprc[i];
 		rx_bytes += stats_info->hw_stats.qbrc[i];
 
-		stats->q_ipackets[i] = stats_info->hw_stats.qprc[i];
-		stats->q_opackets[i] = stats_info->hw_stats.qptc[i];
-		stats->q_ibytes[i] = stats_info->hw_stats.qbrc[i];
-		stats->q_obytes[i] = stats_info->hw_stats.qbtc[i];
-		stats->q_errors[i] = stats_info->hw_stats.qprdc[i];
+		if (qstats && i < RTE_ETHDEV_QUEUE_STAT_CNTRS) {
+			qstats->q_ipackets[i] = stats_info->hw_stats.qprc[i];
+			qstats->q_opackets[i] = stats_info->hw_stats.qptc[i];
+			qstats->q_ibytes[i] = stats_info->hw_stats.qbrc[i];
+			qstats->q_obytes[i] = stats_info->hw_stats.qbtc[i];
+			qstats->q_errors[i] = stats_info->hw_stats.qprdc[i];
+		}
 	}
 
 	stats->ipackets = rx_packets;
@@ -278,7 +279,7 @@ s32 sxe_stats_reset(struct rte_eth_dev *eth_dev)
 	sxe_rx_queue_s *rxq;
 	u32 i;
 
-	sxe_eth_stats_get(eth_dev, NULL);
+	sxe_eth_stats_get(eth_dev, NULL, NULL);
 	sxe_hw_stats_seq_clean(hw, &stats_info->hw_stats);
 
 	for (i = 0; i < eth_dev->data->nb_rx_queues; i++) {
drivers/net/sxe/pf/sxe_stats.h +3 -2
index 7c70761cd6..d84d93421c 100644
@@ -7,6 +7,7 @@
 
 #include <rte_ethdev.h>
 #include <rte_ethdev_core.h>
+#include <ethdev_driver.h>
 #include "sxe_hw.h"
 
 #define SXE_STATS_FIELD_NAME_SIZE  50
@@ -31,8 +32,8 @@ struct sxe_stats_field {
 	u32 offset;
 };
 
-s32 sxe_eth_stats_get(struct rte_eth_dev *eth_dev,
-				struct rte_eth_stats *stats);
+s32 sxe_eth_stats_get(struct rte_eth_dev *eth_dev,struct rte_eth_stats *stats,
+		      struct eth_queue_stats *qstats);
 
 s32 sxe_stats_reset(struct rte_eth_dev *eth_dev);
 
drivers/net/sxe/vf/sxevf_stats.c +4 -3
index 30ce9753dd..3b75126eb7 100644
@@ -5,6 +5,7 @@
 #if defined SXE_DPDK_L4_FEATURES && defined SXE_DPDK_SRIOV
 
 #include <rte_ethdev.h>
+#include <ethdev_driver.h>
 
 #include "sxevf_stats.h"
 #include "sxe_logs.h"
@@ -25,8 +26,8 @@ static u32 sxevf_xstats_cnt_get(void)
 }
 #endif
 
-s32 sxevf_eth_stats_get(struct rte_eth_dev *eth_dev,
-				struct rte_eth_stats *stats)
+s32 sxevf_eth_stats_get(struct rte_eth_dev *eth_dev, struct rte_eth_stats *stats,
+			struct eth_queue_stats *qstats __rte_unused)
 {
 	struct sxevf_adapter *adapter = eth_dev->data->dev_private;
 	struct sxevf_stats_info *stats_info = &adapter->stats_info;
@@ -55,7 +56,7 @@ s32 sxevf_dev_stats_reset(struct rte_eth_dev *eth_dev)
 	struct sxevf_adapter *adapter = eth_dev->data->dev_private;
 	struct sxevf_stats_info *stats_info = &adapter->stats_info;
 
-	sxevf_eth_stats_get(eth_dev, NULL);
+	sxevf_eth_stats_get(eth_dev, NULL, NULL);
 
 	stats_info->hw_stats.vfgprc = 0;
 	stats_info->hw_stats.vfgorc = 0;
drivers/net/sxe/vf/sxevf_stats.h +2 -2
index ddf56c39df..7a6649577b 100644
@@ -16,8 +16,8 @@ struct sxevf_stats_info {
 	struct sxevf_hw_stats hw_stats;
 };
 
-s32 sxevf_eth_stats_get(struct rte_eth_dev *eth_dev,
-				struct rte_eth_stats *stats);
+s32 sxevf_eth_stats_get(struct rte_eth_dev *eth_dev, struct rte_eth_stats *stats,
+			struct eth_queue_stats *qstats);
 
 s32 sxevf_dev_stats_reset(struct rte_eth_dev *eth_dev);
 
#330 lore raw
In reply to [email protected]
Quoted 7 lines · On Mon, 28 Jul 2025 17:05:05 +0800 [email protected] wrote:

From: Jie Liu <[email protected]>

Adding a minimum maintainable directory structure for the network driver and request maintenance of the sxe driver.

---

Drivers need to have all global symbols prefixed consistently to avoid conflicts when DPDK is statically linked.

This driver has some work left:

.../sxe/build/drivers $ nm librte_net_sxe.a | grep ' [TDB] ' | grep -v ' sxe' | grep -v '__sxe' | grep -v 'rte_pmd_sxe_' 0000000000000000 B g_log_filename
0000000000000108 B is_log_created
00000000000002a0 T is_sxe_supported
0000000000000000 D def_txq_ops
0000000000000000 D mac_regs
0000000000000000 B dump_regs

#331 lore raw
In reply to Jie Liu

Hello,

Quoted 5 lines · Jie Liu

Adding a minimum maintainable directory structure for the network driver and request maintenance of the sxe driver.

- Such a big series deserves a cover letter, with annotations/tracking of the changes across the revisions.

- I did not look in detail but I noticed a .map file. Driver specific API should be avoided as much as possible.

But if it is really necessary, please look at the recent changes wrt symbol exports since .map are not used anymore.
Example of a conversion:

$ git diff v25.03 -- drivers/baseband/acc/
(quoted diff) +0 -0

b/drivers/baseband/acc/rte_acc100_pmd.c
index d33e42c807..b7f02f56e1 100644

drivers/baseband/acc/rte_acc100_pmd.c +1 -0
@@ -4,6 +4,7 @@
 
 #include <unistd.h>
 
+#include <eal_export.h>
 #include <rte_common.h>
 #include <rte_log.h>
 #include <dev_driver.h>
@@ -4635,6 +4636,7 @@ acc100_configure(const char *dev_name, struct

rte_acc_conf *conf)

        return 0;

}

+RTE_EXPORT_EXPERIMENTAL_SYMBOL(rte_acc_configure, 22.11)
int
rte_acc_configure(const char *dev_name, struct rte_acc_conf *conf) {

drivers/baseband/acc/version.map deleted +0 -10
deleted file mode 100644
index 3f427caf67..0000000000
@@ -1,10 +0,0 @@
-DPDK_25 {
-       local: *;
-};
-
-EXPERIMENTAL {
-       global:
-
-       # added in 22.11
-       rte_acc_configure;
-};
Signature · 1 line
David Marchand
#332 lore raw
In reply to Jie Liu
Quoted 5 lines · On Wed, 16 Jul 2025 04:29:17 -0400 Jie Liu <[email protected]>…

Adding a minimum maintainable directory structure for the network driver and request maintenance of the sxe driver.

---

Some complaints from check-git-log.sh not all have to be fixed though.

 $ ./devtools/check-git-log.sh 
Wrong headline format:
	net/sxe: add link, flow ctrl, mac ops, mtu ops function
	net/sxe: add Solve compilation problems.
Wrong headline prefix:
	net/sxe: add tx rx setup and data path
Wrong headline case:
			"net/sxe: add dcb function": dcb --> DCB
Wrong headline case:
			"net/sxe: add link, flow ctrl, mac ops, mtu ops function": mac --> MAC
Wrong headline case:
			"net/sxe: add link, flow ctrl, mac ops, mtu ops function": mtu --> MTU
Wrong headline case:
			"net/sxe: support rss offload": rss --> RSS
Wrong headline case:
			"net/sxe: add tx rx setup and data path": rx --> Rx
Wrong headline case:
			"net/sxe: add tx rx setup and data path": tx --> Tx
Wrong headline case:
			"net/sxe: support vlan filter": vlan --> VLAN
Contributor name/email mismatch with .mailmap: 
	Jie Liu <[email protected]> is not the primary email address

Invalid patch(es) found - checked 14 patches

#334 lore raw
In reply to Jie Liu

doc/guides/nics/index.rst Network Interface Controller Drivers · line 75

Quoted 9 lines · On Mon, 7 Jul 2025 07:58:06 -0400 Jie Liu <[email protected]>…
doc/guides/nics/index.rst +1 -0
index 10a2eca3b0..67e6374c69 100644
@@ -72,3 +72,4 @@ Network Interface Controller Drivers
     vmxnet3
     xsc
     zxdh
+    sxe

Please insert driver in alphabetical order position, not at end.

#335 lore raw
In reply to Jie Liu
Quoted 15 lines · On Mon, 7 Jul 2025 07:58:06 -0400 Jie Liu <[email protected]>…
doc/guides/nics/sxe.rst new file +15 -0
+Dynamic Logging Parameters
+~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+One may leverage EAL option "--log-level" to change default levels
+for the log types supported by the driver. The option is used with
+an argument typically consisting of two parts separated by a colon.
+
+SXE PMD provides the following log types available for control:
+
+- ``pmd.net.sxe.drv`` (default level is **DEBUG**)
+
+  Affects driver-wide messages unrelated to any particular devices.
+
+- ``pmd.net.sxe.init`` (default level is **DEBUG**)
+

doc/guides/nics/sxe.rst line 68

Quoted 10 lines
doc/guides/nics/sxe.rst new file +10 -0
+  Extra logging of the messages during PMD initialization.
+
+- ``pmd.net.sxe.rx`` (default level is **DEBUG**)
+
+  Affects rx-wide messages.
+- ``pmd.net.sxe.tx`` (default level is **DEBUG**)
+
+  Affects tx-wide messages.
+
+------------------------------

Other drivers default to INFO or NOTICE level.
Having a default of DEBUG implies the driver is not tested enough.

#336 lore raw
In reply to Jie Liu

Hi,

(please see below)

Quoted 185 lines · Jie Liu

From: JieLiu <[email protected]>

Adding a minimum maintainable directory structure for the network driver and request maintenance of the sxe driver.

---

MAINTAINERS                         |  6 +++
doc/guides/nics/features/sxe.ini    | 82 +++++++++++++++++++++++++++++
doc/guides/nics/features/sxe_vf.ini | 39 ++++++++++++++
doc/guides/nics/index.rst           |  1 +
doc/guides/nics/sxe.rst             | 71 +++++++++++++++++++++++++
drivers/net/sxe/meson.build         |  9 ++++
drivers/net/sxe/pf/sxe_ethdev.c     |  3 ++
drivers/net/sxe/pf/sxe_ethdev.h     |  3 ++
8 files changed, 214 insertions(+)

create mode 100644 doc/guides/nics/features/sxe.ini create mode 100644 doc/guides/nics/features/sxe_vf.ini create mode 100644 doc/guides/nics/sxe.rst create mode 100644 drivers/net/sxe/meson.build create mode 100644 drivers/net/sxe/pf/sxe_ethdev.c create mode 100644 drivers/net/sxe/pf/sxe_ethdev.h

MAINTAINERS +0 -0
index 82f6e2f917..f92f4fea81 100644
@@ -2055,3 +2055,9 @@ F: examples/vmdq/

F: doc/guides/sample_app_ug/vmdq_forwarding.rst
F: examples/vmdq_dcb/
F: doc/guides/sample_app_ug/vmdq_dcb_forwarding.rst

MAINTAINERS +6 -0
+
+Linkdata sxe
+M: Jie Li <[email protected]>
+F: drivers/net/sxe/
+F: doc/guides/nics/sxe.rst
+F: doc/guides/nics/features/sxe*.ini
doc/guides/nics/features/sxe.ini new file +82 -0
new file mode 100644
index 0000000000..b61ad7c699
@@ -0,0 +1,82 @@
+;
+; Supported features of the 'sxe' network poll mode driver.
+;
+; Refer to default.ini for the full list of available PMD features.
+;
+[Features]
+Speed capabilities   = Y
+Link speed configuration = Y
+Link status          = Y
+Link status event    = Y
+Rx interrupt         = Y
+Queue start/stop     = Y
+Power mgmt address monitor = Y
+MTU update           = Y
+Scattered Rx         = Y
+LRO                  = Y
+TSO                  = Y
+Promiscuous mode     = Y
+Allmulticast mode    = Y
+Unicast MAC filter   = Y
+Multicast MAC filter = Y
+RSS hash             = Y
+RSS key update       = Y
+RSS reta update      = Y
+VMDq                 = Y
+SR-IOV               = Y
+DCB                  = Y
+VLAN filter          = Y
+Flow control         = Y
+Rate limitation      = Y
+Traffic manager      = Y
+Inline crypto        = Y
+CRC offload          = P
+VLAN offload         = P
+QinQ offload         = P
+L3 checksum offload  = P
+L4 checksum offload  = P
+MACsec offload       = P
+Inner L3 checksum    = P
+Inner L4 checksum    = P
+Packet type parsing  = Y
+Timesync             = Y
+Rx descriptor status = Y
+Tx descriptor status = Y
+Basic stats          = Y
+Extended stats       = Y
+Stats per queue      = Y
+FW version           = Y
+EEPROM dump          = Y
+Module EEPROM dump   = Y
+Registers dump       = Y
+Multiprocess aware   = Y
+FreeBSD              = Y
+Linux                = Y
+ARMv8                = Y
+LoongArch64          = Y
+rv64                 = Y
+x86-32               = Y
+x86-64               = Y
+
+[rte_flow items]
+eth                  = P
+e_tag                = Y
+fuzzy                = Y
+ipv4                 = Y
+ipv6                 = Y
+nvgre                = Y
+raw                  = Y
+sctp                 = Y
+tcp                  = Y
+udp                  = Y
+vlan                 = P
+vxlan                = Y
+
+[rte_flow actions]
+drop                 = Y
+mark                 = Y
+pf                   = Y
+queue                = Y
+rss                  = Y
+security             = Y
+vf                   = Y
doc/guides/nics/features/sxe_vf.ini new file +39 -0
new file mode 100644
index 0000000000..49eaeaaaae
@@ -0,0 +1,39 @@
+;
+; Supported features of the 'sxe_vf' network poll mode driver.
+;
+; Refer to default.ini for the full list of available PMD features.
+;
+[Features]
+Link status          = Y
+Rx interrupt         = Y
+Power mgmt address monitor = Y
+MTU update           = Y
+Scattered Rx         = Y
+LRO                  = Y
+TSO                  = Y
+Promiscuous mode     = Y
+Allmulticast mode    = Y
+Unicast MAC filter   = Y
+RSS hash             = Y
+RSS key update       = Y
+RSS reta update      = Y
+VLAN filter          = Y
+Inline crypto        = Y
+CRC offload          = P
+VLAN offload         = P
+QinQ offload         = P
+L3 checksum offload  = P
+L4 checksum offload  = P
+Inner L3 checksum    = P
+Inner L4 checksum    = P
+Packet type parsing  = Y
+Rx descriptor status = Y
+Tx descriptor status = Y
+Basic stats          = Y
+Extended stats       = Y
+Registers dump       = Y
+FreeBSD              = Y
+Linux                = Y
+ARMv8                = Y
+x86-32               = Y
+x86-64               = Y
doc/guides/nics/index.rst +1 -0
index 10a2eca3b0..67e6374c69 100644
@@ -72,3 +72,4 @@ Network Interface Controller Drivers
    vmxnet3
    xsc
    zxdh
+    sxe
doc/guides/nics/sxe.rst new file +0 -0
new file mode 100644
index 0000000000..d86d15bec8

doc/guides/nics/sxe.rst line 2

Quoted 2 lines
doc/guides/nics/sxe.rst new file +2 -0
@@ -0,0 +1,71 @@
+..  SPDX-License-Identifier: BSD-3-Clause
+    Copyright (C), 2022, Linkdata Technology Co., Ltd.

Why not 2025?

doc/guides/nics/sxe.rst line 13

Quoted 11 lines
doc/guides/nics/sxe.rst new file +11 -0
+
+SXE Poll Mode Driver
+======================
+
+The SXE PMD (librte_pmd_sxe) provides poll mode driver support
+for Linkdata 1160-2X 10GE Ethernet Adapter.
+
+Features
+--------
+- PXE boot
+- PTP(Precision Time Protocol)

Consider: 'PTP (precision time protocol)'.

doc/guides/nics/sxe.rst line 14

Quoted 1 line
doc/guides/nics/sxe.rst new file +1 -0
+- VMDq(Virtual Machine Device Queues)

Consider: 'VMDq (virtual machine devise queues)'.

doc/guides/nics/sxe.rst line 15

Quoted 1 line
doc/guides/nics/sxe.rst new file +1 -0
+- SR-IOV,max 2PF,63VF per PF

Consider: 'SR-IOV, max. 2 PFs, 63 VFs per PF'.

doc/guides/nics/sxe.rst line 24

Quoted 9 lines
doc/guides/nics/sxe.rst new file +9 -0
+- 128 L2 Ethernet MAC Address Filters (unicast and multicast)
+- 64 L2 VLAN filters
+- pldm over mctp over smbus
+- 802.1q VLAN
+- Low Latency Interrupts
+- LRO
+- Promiscuous mode
+- Multicast mode
+- Multiple queues for TX and RX

Consider to spell it as 'Tx' and 'Rx.

doc/guides/nics/sxe.rst line 25

Quoted 1 line
doc/guides/nics/sxe.rst new file +1 -0
+- Receiver Side Scaling (RSS)

For consistency, 'RSS (receive side scaling)', may be?

doc/guides/nics/sxe.rst line 35

Quoted 10 lines
doc/guides/nics/sxe.rst new file +10 -0
+- MAC/VLAN filtering
+- Packet type information
+- Checksum offload
+- VLAN/QinQ stripping and inserting
+- TSO offload
+- Port hardware statistics
+- Link state information
+- Link flow control
+- Interrupt mode for RX
+- Scattered and gather for TX and RX

Consider to spell it as 'Tx' and 'Rx'.

Quoted 18 lines
doc/guides/nics/sxe.rst new file +18 -0
+- DCB
+- IEEE 1588
+- FW version
+- Generic flow API
+
+Configuration
+-------------
+
+Dynamic Logging Parameters
+~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+One may leverage EAL option "--log-level" to change default levels
+for the log types supported by the driver. The option is used with
+an argument typically consisting of two parts separated by a colon.
+
+SXE PMD provides the following log types available for control:
+
+- ``pmd.net.sxe.drv`` (default level is **DEBUG**)

doc/guides/nics/sxe.rst line 63

Quoted 10 lines
doc/guides/nics/sxe.rst new file +10 -0
+
+  Affects driver-wide messages unrelated to any particular devices.
+
+- ``pmd.net.sxe.init`` (default level is **DEBUG**)
+
+  Extra logging of the messages during PMD initialization.
+
+- ``pmd.net.sxe.rx`` (default level is **DEBUG**)
+
+  Affects rx-wide messages.

Perhaps 'rx' -> 'Rx'.

doc/guides/nics/sxe.rst line 64

Quoted 1 line
doc/guides/nics/sxe.rst new file +1 -0
+- ``pmd.net.sxe.tx`` (default level is **DEBUG**)

Perhaps 'tx' -> 'Tx'.

doc/guides/nics/sxe.rst line 66

Quoted 2 lines
doc/guides/nics/sxe.rst new file +2 -0
+
+  Affects tx-wide messages.

Why is 'DEBUG' used by default? Won't it overwhelm the screen with messages?

Thank you.

Quoted 42 lines
doc/guides/nics/sxe.rst new file +5 -0
+
+------------------------------
+
+Refer to the document :ref:`compiling and testing a PMD for a NIC <pmd_build_and_test>`
+for details.
drivers/net/sxe/meson.build new file +9 -0
new file mode 100644
index 0000000000..dad9ee44a0
@@ -0,0 +1,9 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright (C), 2020, Wuxi Stars Micro System Technologies Co., Ltd.
+
+deps += ['hash']
+sources = files(
+        'pf/sxe_ethdev.c',
+)
+
+includes += include_directories('pf')
drivers/net/sxe/pf/sxe_ethdev.c new file +3 -0
new file mode 100644
index 0000000000..e31a23deeb
@@ -0,0 +1,3 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2015-2024
+ */
drivers/net/sxe/pf/sxe_ethdev.h new file +3 -0
new file mode 100644
index 0000000000..e31a23deeb
@@ -0,0 +1,3 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2015-2024
+ */
Signature · 1 line
2.18.4
#337 lore raw
Quoted 278 lines · Ivan Malov

Hi,

(please see below)

Quoted 185 lines · Jie Liu

From: JieLiu <[email protected]>

Adding a minimum maintainable directory structure for the network driver and request maintenance of the sxe driver.

---

MAINTAINERS                         |  6 +++
doc/guides/nics/features/sxe.ini    | 82 +++++++++++++++++++++++++++++
doc/guides/nics/features/sxe_vf.ini | 39 ++++++++++++++
doc/guides/nics/index.rst           |  1 +
doc/guides/nics/sxe.rst             | 71 +++++++++++++++++++++++++
drivers/net/sxe/meson.build         |  9 ++++
drivers/net/sxe/pf/sxe_ethdev.c     |  3 ++
drivers/net/sxe/pf/sxe_ethdev.h     |  3 ++
8 files changed, 214 insertions(+)

create mode 100644 doc/guides/nics/features/sxe.ini create mode 100644 doc/guides/nics/features/sxe_vf.ini create mode 100644 doc/guides/nics/sxe.rst create mode 100644 drivers/net/sxe/meson.build create mode 100644 drivers/net/sxe/pf/sxe_ethdev.c create mode 100644 drivers/net/sxe/pf/sxe_ethdev.h

MAINTAINERS +0 -0
index 82f6e2f917..f92f4fea81 100644
@@ -2055,3 +2055,9 @@ F: examples/vmdq/

F: doc/guides/sample_app_ug/vmdq_forwarding.rst
F: examples/vmdq_dcb/
F: doc/guides/sample_app_ug/vmdq_dcb_forwarding.rst

MAINTAINERS +6 -0
+
+Linkdata sxe
+M: Jie Li <[email protected]>
+F: drivers/net/sxe/
+F: doc/guides/nics/sxe.rst
+F: doc/guides/nics/features/sxe*.ini
doc/guides/nics/features/sxe.ini new file +82 -0
new file mode 100644
index 0000000000..b61ad7c699
@@ -0,0 +1,82 @@
+;
+; Supported features of the 'sxe' network poll mode driver.
+;
+; Refer to default.ini for the full list of available PMD features.
+;
+[Features]
+Speed capabilities   = Y
+Link speed configuration = Y
+Link status          = Y
+Link status event    = Y
+Rx interrupt         = Y
+Queue start/stop     = Y
+Power mgmt address monitor = Y
+MTU update           = Y
+Scattered Rx         = Y
+LRO                  = Y
+TSO                  = Y
+Promiscuous mode     = Y
+Allmulticast mode    = Y
+Unicast MAC filter   = Y
+Multicast MAC filter = Y
+RSS hash             = Y
+RSS key update       = Y
+RSS reta update      = Y
+VMDq                 = Y
+SR-IOV               = Y
+DCB                  = Y
+VLAN filter          = Y
+Flow control         = Y
+Rate limitation      = Y
+Traffic manager      = Y
+Inline crypto        = Y
+CRC offload          = P
+VLAN offload         = P
+QinQ offload         = P
+L3 checksum offload  = P
+L4 checksum offload  = P
+MACsec offload       = P
+Inner L3 checksum    = P
+Inner L4 checksum    = P
+Packet type parsing  = Y
+Timesync             = Y
+Rx descriptor status = Y
+Tx descriptor status = Y
+Basic stats          = Y
+Extended stats       = Y
+Stats per queue      = Y
+FW version           = Y
+EEPROM dump          = Y
+Module EEPROM dump   = Y
+Registers dump       = Y
+Multiprocess aware   = Y
+FreeBSD              = Y
+Linux                = Y
+ARMv8                = Y
+LoongArch64          = Y
+rv64                 = Y
+x86-32               = Y
+x86-64               = Y
+
+[rte_flow items]
+eth                  = P
+e_tag                = Y
+fuzzy                = Y
+ipv4                 = Y
+ipv6                 = Y
+nvgre                = Y
+raw                  = Y
+sctp                 = Y
+tcp                  = Y
+udp                  = Y
+vlan                 = P
+vxlan                = Y
+
+[rte_flow actions]
+drop                 = Y
+mark                 = Y
+pf                   = Y
+queue                = Y
+rss                  = Y
+security             = Y
+vf                   = Y
doc/guides/nics/features/sxe_vf.ini new file +39 -0
new file mode 100644
index 0000000000..49eaeaaaae
@@ -0,0 +1,39 @@
+;
+; Supported features of the 'sxe_vf' network poll mode driver.
+;
+; Refer to default.ini for the full list of available PMD features.
+;
+[Features]
+Link status          = Y
+Rx interrupt         = Y
+Power mgmt address monitor = Y
+MTU update           = Y
+Scattered Rx         = Y
+LRO                  = Y
+TSO                  = Y
+Promiscuous mode     = Y
+Allmulticast mode    = Y
+Unicast MAC filter   = Y
+RSS hash             = Y
+RSS key update       = Y
+RSS reta update      = Y
+VLAN filter          = Y
+Inline crypto        = Y
+CRC offload          = P
+VLAN offload         = P
+QinQ offload         = P
+L3 checksum offload  = P
+L4 checksum offload  = P
+Inner L3 checksum    = P
+Inner L4 checksum    = P
+Packet type parsing  = Y
+Rx descriptor status = Y
+Tx descriptor status = Y
+Basic stats          = Y
+Extended stats       = Y
+Registers dump       = Y
+FreeBSD              = Y
+Linux                = Y
+ARMv8                = Y
+x86-32               = Y
+x86-64               = Y
doc/guides/nics/index.rst +1 -0
index 10a2eca3b0..67e6374c69 100644
@@ -72,3 +72,4 @@ Network Interface Controller Drivers
    vmxnet3
    xsc
    zxdh
+    sxe
doc/guides/nics/sxe.rst new file +0 -0
new file mode 100644
index 0000000000..d86d15bec8

doc/guides/nics/sxe.rst line 2

Quoted 2 lines
doc/guides/nics/sxe.rst new file +2 -0
@@ -0,0 +1,71 @@
+..  SPDX-License-Identifier: BSD-3-Clause
+    Copyright (C), 2022, Linkdata Technology Co., Ltd.

Why not 2025?

doc/guides/nics/sxe.rst line 13

Quoted 11 lines
doc/guides/nics/sxe.rst new file +11 -0
+
+SXE Poll Mode Driver
+======================
+
+The SXE PMD (librte_pmd_sxe) provides poll mode driver support
+for Linkdata 1160-2X 10GE Ethernet Adapter.
+
+Features
+--------
+- PXE boot
+- PTP(Precision Time Protocol)

Consider: 'PTP (precision time protocol)'.

doc/guides/nics/sxe.rst line 14

Quoted 1 line
doc/guides/nics/sxe.rst new file +1 -0
+- VMDq(Virtual Machine Device Queues)

Consider: 'VMDq (virtual machine devise queues)'.

doc/guides/nics/sxe.rst line 15

Quoted 1 line
doc/guides/nics/sxe.rst new file +1 -0
+- SR-IOV,max 2PF,63VF per PF

Consider: 'SR-IOV, max. 2 PFs, 63 VFs per PF'.

doc/guides/nics/sxe.rst line 24

Quoted 9 lines
doc/guides/nics/sxe.rst new file +9 -0
+- 128 L2 Ethernet MAC Address Filters (unicast and multicast)
+- 64 L2 VLAN filters
+- pldm over mctp over smbus
+- 802.1q VLAN
+- Low Latency Interrupts
+- LRO
+- Promiscuous mode
+- Multicast mode
+- Multiple queues for TX and RX

Consider to spell it as 'Tx' and 'Rx.

doc/guides/nics/sxe.rst line 25

Quoted 1 line
doc/guides/nics/sxe.rst new file +1 -0
+- Receiver Side Scaling (RSS)

For consistency, 'RSS (receive side scaling)', may be?

doc/guides/nics/sxe.rst line 35

Quoted 10 lines
doc/guides/nics/sxe.rst new file +10 -0
+- MAC/VLAN filtering
+- Packet type information
+- Checksum offload
+- VLAN/QinQ stripping and inserting
+- TSO offload
+- Port hardware statistics
+- Link state information
+- Link flow control
+- Interrupt mode for RX
+- Scattered and gather for TX and RX

Consider to spell it as 'Tx' and 'Rx'.

Quoted 18 lines
doc/guides/nics/sxe.rst new file +18 -0
+- DCB
+- IEEE 1588
+- FW version
+- Generic flow API
+
+Configuration
+-------------
+
+Dynamic Logging Parameters
+~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+One may leverage EAL option "--log-level" to change default levels
+for the log types supported by the driver. The option is used with
+an argument typically consisting of two parts separated by a colon.
+
+SXE PMD provides the following log types available for control:
+
+- ``pmd.net.sxe.drv`` (default level is **DEBUG**)

doc/guides/nics/sxe.rst line 63

Quoted 10 lines
doc/guides/nics/sxe.rst new file +10 -0
+
+  Affects driver-wide messages unrelated to any particular devices.
+
+- ``pmd.net.sxe.init`` (default level is **DEBUG**)
+
+  Extra logging of the messages during PMD initialization.
+
+- ``pmd.net.sxe.rx`` (default level is **DEBUG**)
+
+  Affects rx-wide messages.

Perhaps 'rx' -> 'Rx'.

Quoted 8 lines

doc/guides/nics/sxe.rst line 64

Quoted 1 line
doc/guides/nics/sxe.rst new file +1 -0
+- ``pmd.net.sxe.tx`` (default level is **DEBUG**)

Perhaps 'tx' -> 'Tx'.

doc/guides/nics/sxe.rst line 66

Quoted 2 lines
doc/guides/nics/sxe.rst new file +2 -0
+
+  Affects tx-wide messages.

Why is 'DEBUG' used by default? Won't it overwhelm the screen with messages?

Please disregard this message, - I see this has been fixed already. Sorry.

Thank you.

Quoted 47 lines

Thank you.

Quoted 43 lines
doc/guides/nics/sxe.rst new file +4 -0
+
+------------------------------
+
+Refer to the document :ref:`compiling and testing a PMD for a NIC 

<pmd_build_and_test>`

doc/guides/nics/sxe.rst new file +1 -0
+for details.
drivers/net/sxe/meson.build new file +9 -0
new file mode 100644
index 0000000000..dad9ee44a0
@@ -0,0 +1,9 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright (C), 2020, Wuxi Stars Micro System Technologies Co., Ltd.
+
+deps += ['hash']
+sources = files(
+        'pf/sxe_ethdev.c',
+)
+
+includes += include_directories('pf')
drivers/net/sxe/pf/sxe_ethdev.c new file +3 -0
new file mode 100644
index 0000000000..e31a23deeb
@@ -0,0 +1,3 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2015-2024
+ */
drivers/net/sxe/pf/sxe_ethdev.h new file +3 -0
new file mode 100644
index 0000000000..e31a23deeb
@@ -0,0 +1,3 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2015-2024
+ */
Signature · 1 line
2.18.4