add static PMD zero page support
Subsystems (7)
v2 cover add static PMD zero page support
From: Pankaj Raghav <[email protected]>
There are many places in the kernel where we need to zeroout larger chunks but the maximum segment we can zeroout at a time by ZERO_PAGE is limited by PAGE_SIZE.
This concern was raised during the review of adding Large Block Size support to XFS[1][2].
This is especially annoying in block devices and filesystems where we attach multiple ZERO_PAGEs to the bio in different bvecs. With multipage bvec support in block layer, it is much more efficient to send out larger zero pages as a part of a single bvec.
Some examples of places in the kernel where this could be useful:
- blkdev_issue_zero_pages()
- iomap_dio_zero()
- vmalloc.c:zero_iter()
- rxperf_process_call()
- fscrypt_zeroout_range_inline_crypt()
- bch2_checksum_update()
...
We already have huge_zero_folio that is allocated on demand, and it will be deallocated by the shrinker if there are no users of it left.
At moment, huge_zero_folio infrastructure refcount is tied to the process lifetime that created it. This might not work for bio layer as the completions can be async and the process that created the huge_zero_folio might no longer be alive.
Add a config option STATIC_PMD_ZERO_PAGE that will always allocate the huge_zero_folio via memblock, and it will never be freed.
I have converted blkdev_issue_zero_pages() as an example as a part of this series.
I will send patches to individual subsystems using the huge_zero_folio once this gets upstreamed.
Looking forward to some feedback.
[1] https://lore.kernel.org/linux-xfs/[email protected]/
[2] https://lore.kernel.org/linux-xfs/[email protected]/
Changes since v1:
- Move from .bss to allocating it through memblock(David)
Changes since RFC:
- Added the config option based on the feedback from David.
- Encode more info in the header to avoid dead code (Dave hansen feedback)
- The static part of huge_zero_folio in memory.c and the dynamic part stays in huge_memory.c
- Split the patches to make it easy for review.
Pankaj Raghav (5):
mm: move huge_zero_page declaration from huge_mm.h to mm.h
huge_memory: add huge_zero_page_shrinker_(init|exit) function
mm: add static PMD zero page
mm: add largest_zero_folio() routine
block: use largest_zero_folio in __blkdev_issue_zero_pages()
block/blk-lib.c | 17 +++++---- include/linux/huge_mm.h | 31 ---------------- include/linux/mm.h | 81 +++++++++++++++++++++++++++++++++++++++++ mm/Kconfig | 9 +++++ mm/huge_memory.c | 62 +++++++++++++++++++++++-------- mm/memory.c | 25 +++++++++++++ mm/mm_init.c | 1 + 7 files changed, 173 insertions(+), 53 deletions(-)
base-commit: d7b8f8e20813f0179d8ef519541a3527e7661d3a
Signature · 1 line
2.49.0
PATCH v2 1/5 mm: move huge_zero_page declaration from huge_mm.h to mm.h
From: Pankaj Raghav <[email protected]>
Move the declaration associated with huge_zero_page from huge_mm.h to mm.h. This patch is in preparation for adding static PMD zero page as we will be reusing some of the huge_zero_page infrastructure.
No functional changes.
--- include/linux/huge_mm.h | 31 ------------------------------- include/linux/mm.h | 34 ++++++++++++++++++++++++++++++++++ 2 files changed, 34 insertions(+), 31 deletions(-)
include/linux/huge_mm.h +0 -31
@@ -478,22 +478,6 @@ struct page *follow_devmap_pmd(struct vm_area_struct *vma, unsigned long addr,vm_fault_t do_huge_pmd_numa_page (struct vm_fault *vmf); -extern struct folio *huge_zero_folio; -extern unsigned long huge_zero_pfn; - -static inline bool is_huge_zero_folio (const struct folio *folio) -{ -return READ_ONCE (huge_zero_folio) == folio; -} - -static inline bool is_huge_zero_pmd (pmd_t pmd) -{ -return pmd_present (pmd) &&READ_ONCE (huge_zero_pfn) ==pmd_pfn (pmd); -} - -struct folio *mm_get_huge_zero_folio (struct mm_struct *mm); -void mm_put_huge_zero_folio (struct mm_struct *mm); -static inline bool thp_migration_supported (void ) {return IS_ENABLED (CONFIG_ARCH_ENABLE_THP_MIGRATION );
@@ -631,21 +615,6 @@ static inline vm_fault_t do_huge_pmd_numa_page(struct vm_fault *vmf)return 0 ; } -static inline bool is_huge_zero_folio (const struct folio *folio) -{ -return false; -} - -static inline bool is_huge_zero_pmd (pmd_t pmd) -{ -return false; -} - -static inline void mm_put_huge_zero_folio (struct mm_struct *mm) -{ -return ; -} -static inline struct page *follow_devmap_pmd (struct vm_area_struct *vma,unsigned long addr,pmd_t *pmd,int flags,struct dev_pagemap **pgmap) {
include/linux/mm.h +34 -0
@@ -4018,6 +4018,40 @@ static inline bool vma_is_special_huge(const struct vm_area_struct *vma)#endif /* CONFIG_TRANSPARENT_HUGEPAGE || CONFIG_HUGETLBFS */ +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +extern struct folio *huge_zero_folio; +extern unsigned long huge_zero_pfn; + +static inline bool is_huge_zero_folio (const struct folio *folio) +{ +return READ_ONCE (huge_zero_folio) == folio; +} + +static inline bool is_huge_zero_pmd (pmd_t pmd) +{ +return pmd_present (pmd) &&READ_ONCE (huge_zero_pfn) ==pmd_pfn (pmd); +} + +struct folio *mm_get_huge_zero_folio (struct mm_struct *mm); +void mm_put_huge_zero_folio (struct mm_struct *mm); + +#else +static inline bool is_huge_zero_folio (const struct folio *folio) +{ +return false; +} + +static inline bool is_huge_zero_pmd (pmd_t pmd) +{ +return false; +} + +static inline void mm_put_huge_zero_folio (struct mm_struct *mm) +{ +return ; +} +#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ +#if MAX_NUMNODES >1 void __init setup_nr_node_ids (void );#else
Signature · 1 line
2.49.0
Re: [PATCH v2 1/5] mm: move huge_zero_page declaration from huge_mm.h to mm.h
Quoted 5 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
Move the declaration associated with
huge_zero_pagefromhuge_mm.htomm.h. This patch is in preparation for adding static PMD zero page as we will be reusing some of thehuge_zero_pageinfrastructure.
Hmm this is really iffy.
The whole purpose of huge_mm.h is to handle huge page stuff, and now you're moving it to a general header... not a fan of this - now we have _some_ huge stuff in mm.h and some stuff here.
Yes this might be something we screwed up already, but that's not a recent to perpetuate mistakes.
Surely you don't _need_ to do this and this is a question of fixing up header includes right?
Or is them some horrible cyclical header issue here?
Also your commit message doesn't give any reason as to why you _need_ to do this also. For something like this where you're doing something that at face value seems to contradict the purpose of these headers, you need to explain why.
Quoted 106 lines
No functional changes.
Signed-off-by Pankaj Raghav <[email protected]>--- include/linux/huge_mm.h | 31 ------------------------------- include/linux/mm.h | 34 ++++++++++++++++++++++++++++++++++ 2 files changed, 34 insertions(+), 31 deletions(-)include/linux/huge_mm.h +0
-31@@ -478,22 +478,6 @@ struct page *follow_devmap_pmd(struct vm_area_struct *vma, unsigned long addr,vm_fault_t do_huge_pmd_numa_page (struct vm_fault *vmf); -extern struct folio *huge_zero_folio; -extern unsigned long huge_zero_pfn; - -static inline bool is_huge_zero_folio (const struct folio *folio) -{ -return READ_ONCE (huge_zero_folio) == folio; -} - -static inline bool is_huge_zero_pmd (pmd_t pmd) -{ -return pmd_present (pmd) &&READ_ONCE (huge_zero_pfn) ==pmd_pfn (pmd); -} - -struct folio *mm_get_huge_zero_folio (struct mm_struct *mm); -void mm_put_huge_zero_folio (struct mm_struct *mm); -static inline bool thp_migration_supported (void ) {return IS_ENABLED (CONFIG_ARCH_ENABLE_THP_MIGRATION );@@ -631,21 +615,6 @@ static inline vm_fault_t do_huge_pmd_numa_page(struct vm_fault *vmf)return 0 ; } -static inline bool is_huge_zero_folio (const struct folio *folio) -{ -return false; -} - -static inline bool is_huge_zero_pmd (pmd_t pmd) -{ -return false; -} - -static inline void mm_put_huge_zero_folio (struct mm_struct *mm) -{ -return ; -} -static inline struct page *follow_devmap_pmd (struct vm_area_struct *vma,unsigned long addr,pmd_t *pmd,int flags,struct dev_pagemap **pgmap) {include/linux/mm.h +34
-1@@ -4018,6 +4018,40 @@ static inline bool vma_is_special_huge(const struct vm_area_struct *vma)#endif /* CONFIG_TRANSPARENT_HUGEPAGE || CONFIG_HUGETLBFS */ +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +extern struct folio *huge_zero_folio; +extern unsigned long huge_zero_pfn; + +static inline bool is_huge_zero_folio (const struct folio *folio) +{ +return READ_ONCE (huge_zero_folio) == folio; +} + +static inline bool is_huge_zero_pmd (pmd_t pmd) +{ +return pmd_present (pmd) &&READ_ONCE (huge_zero_pfn) ==pmd_pfn (pmd); +} + +struct folio *mm_get_huge_zero_folio (struct mm_struct *mm); +void mm_put_huge_zero_folio (struct mm_struct *mm); + +#else +static inline bool is_huge_zero_folio (const struct folio *folio) +{ +return false; +} + +static inline bool is_huge_zero_pmd (pmd_t pmd) +{ +return false; +} + +static inline void mm_put_huge_zero_folio (struct mm_struct *mm) +{ +return ; +} +#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ +#if MAX_NUMNODES >1 void __init setup_nr_node_ids (void );#else --2.49.0
Re: [PATCH v2 1/5] mm: move huge_zero_page declaration from huge_mm.h to mm.h
Quoted 19 lines · Lorenzo Stoakes
Quoted 5 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
Move the declaration associated with
huge_zero_pagefromhuge_mm.htomm.h. This patch is in preparation for adding static PMD zero page as we will be reusing some of thehuge_zero_pageinfrastructure.Hmm this is really iffy.
The whole purpose of
huge_mm.his to handle huge page stuff, and now you're moving it to a general header... not a fan of this - now we have _some_ huge stuff inmm.hand some stuff here.Yes this might be something we screwed up already, but that's not a recent to perpetuate mistakes.
Surely you don't _need_ to do this and this is a question of fixing up header includes right?
Quoted 7 lines
Or is them some horrible cyclical header issue here?
Also your commit message doesn't give any reason as to why you _need_ to do this also. For something like this where you're doing something that at face value seems to contradict the purpose of these headers, you need to explain why.
In one of the earlier versions, David asked me to experiment by moving some of these declarations to mm.h and see how it looks. Mainly because, as you guessed it later, we can use it without THP being enabled.
But I see that you strongly feel against moving this to mm.h (and I see why).
I can move it back to huge_mm.h.
Thanks
--
Pankaj
Re: [PATCH v2 1/5] mm: move huge_zero_page declaration from huge_mm.h to mm.h
Quoted 28 lines · Pankaj Raghav (Samsung)
Quoted 19 lines · Lorenzo Stoakes
Quoted 5 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
Move the declaration associated with
huge_zero_pagefromhuge_mm.htomm.h. This patch is in preparation for adding static PMD zero page as we will be reusing some of thehuge_zero_pageinfrastructure.Hmm this is really iffy.
The whole purpose of
huge_mm.his to handle huge page stuff, and now you're moving it to a general header... not a fan of this - now we have _some_ huge stuff inmm.hand some stuff here.Yes this might be something we screwed up already, but that's not a recent to perpetuate mistakes.
Surely you don't _need_ to do this and this is a question of fixing up header includes right?
Quoted 7 lines
Or is them some horrible cyclical header issue here?
Also your commit message doesn't give any reason as to why you _need_ to do this also. For something like this where you're doing something that at face value seems to contradict the purpose of these headers, you need to explain why.
Quoted 3 lines
In one of the earlier versions, David asked me to experiment by moving some of these declarations to
mm.hand see how it looks. Mainly because, as you guessed it later, we can use it without THP being enabled.
I assume, in the future, most setups we care about (-> performance) will have THP compiled in. So likely we can defer moving it until it's really required.
Signature · 3 lines
Cheers, David / dhildenb
PATCH v2 2/5 huge_memory: add huge_zero_page_shrinker_(init|exit) function
In reply to Pankaj Raghav (Samsung)From: Pankaj Raghav <[email protected]>
Add huge_zero_page_shrinker_init() and huge_zero_page_shrinker_exit(). As shrinker will not be needed when static PMD zero page is enabled, these two functions can be a no-op.
This is a preparation patch for static PMD zero page. No functional changes.
--- mm/huge_memory.c | 38 +++++++++++++++++++++++++++----------- 1 file changed, 27 insertions(+), 11 deletions(-)
mm/huge_memory.c +27 -11
@@ -289,6 +289,24 @@ static unsigned long shrink_huge_zero_page_scan(struct shrinker *shrink, }static struct shrinker *huge_zero_page_shrinker; +static int huge_zero_page_shrinker_init (void ) +{ + huge_zero_page_shrinker =shrinker_alloc (0 ,"thp-zero" ); +if (!huge_zero_page_shrinker) +return -ENOMEM ; + + huge_zero_page_shrinker->count_objects = shrink_huge_zero_page_count; + huge_zero_page_shrinker->scan_objects = shrink_huge_zero_page_scan; +shrinker_register (huge_zero_page_shrinker); +return 0 ; +} + +static void huge_zero_page_shrinker_exit (void ) +{ +shrinker_free (huge_zero_page_shrinker); +return ; +} +#ifdef CONFIG_SYSFS static ssize_t enabled_show(struct kobject *kobj,
@@ -850,33 +868,31 @@ static inline void hugepage_exit_sysfs(struct kobject *hugepage_kobj)static int __init thp_shrinker_init (void ) { - huge_zero_page_shrinker =shrinker_alloc (0 ,"thp-zero" ); -if (!huge_zero_page_shrinker) -return -ENOMEM ; +int ret =0 ; deferred_split_shrinker =shrinker_alloc (SHRINKER_NUMA_AWARE |SHRINKER_MEMCG_AWARE |SHRINKER_NONSLAB ,"thp-deferred_split" ); -if (!deferred_split_shrinker) { -shrinker_free (huge_zero_page_shrinker); +if (!deferred_split_shrinker)return -ENOMEM ; - } - - huge_zero_page_shrinker->count_objects = shrink_huge_zero_page_count; - huge_zero_page_shrinker->scan_objects = shrink_huge_zero_page_scan; -shrinker_register (huge_zero_page_shrinker); deferred_split_shrinker->count_objects = deferred_split_count; deferred_split_shrinker->scan_objects = deferred_split_scan;shrinker_register (deferred_split_shrinker); + ret =huge_zero_page_shrinker_init (); +if (ret) { +shrinker_free (deferred_split_shrinker); +return ret; + } +return 0 ; }static void __init thp_shrinker_exit (void ) { -shrinker_free (huge_zero_page_shrinker); +huge_zero_page_shrinker_exit ();shrinker_free (deferred_split_shrinker); }
Signature · 1 line
2.49.0
Re: [PATCH v2 2/5] huge_memory: add huge_zero_page_shrinker_(init|exit) function
Quoted 29 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
Add
huge_zero_page_shrinker_init()andhuge_zero_page_shrinker_exit(). As shrinker will not be needed when static PMD zero page is enabled, these two functions can be a no-op.This is a preparation patch for static PMD zero page. No functional changes.
Signed-off-by Pankaj Raghav <[email protected]>--- mm/huge_memory.c | 38 +++++++++++++++++++++++++++----------- 1 file changed, 27 insertions(+), 11 deletions(-)mm/huge_memory.c +7
-0@@ -289,6 +289,24 @@ static unsigned long shrink_huge_zero_page_scan(struct shrinker *shrink, }static struct shrinker *huge_zero_page_shrinker; +static int huge_zero_page_shrinker_init (void ) +{ + huge_zero_page_shrinker =shrinker_alloc (0 ,"thp-zero" ); +if (!huge_zero_page_shrinker) +return -ENOMEM ; + + huge_zero_page_shrinker->count_objects = shrink_huge_zero_page_count;
mm/huge_memory.c static unsigned long shrink_huge_zero_page_scan(struct shrinker *shrink, · line 308
Quoted 10 lines
mm/huge_memory.c +10
-0+ huge_zero_page_shrinker->scan_objects = shrink_huge_zero_page_scan; +shrinker_register (huge_zero_page_shrinker); +return 0 ; +} + +static void huge_zero_page_shrinker_exit (void ) +{ +shrinker_free (huge_zero_page_shrinker); +return ; +}
While at it, we should rename most of that to "huge_zero_folio" I assume.
Signature · 3 lines
Cheers, David / dhildenb
Re: [PATCH v2 2/5] huge_memory: add huge_zero_page_shrinker_(init|exit) function
Quoted 33 lines · David Hildenbrand
Quoted 32 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
Add
huge_zero_page_shrinker_init()andhuge_zero_page_shrinker_exit(). As shrinker will not be needed when static PMD zero page is enabled, these two functions can be a no-op.This is a preparation patch for static PMD zero page. No functional changes.
Signed-off-by Pankaj Raghav <[email protected]>--- mm/huge_memory.c | 38 +++++++++++++++++++++++++++----------- 1 file changed, 27 insertions(+), 11 deletions(-)mm/huge_memory.c +11
-0@@ -289,6 +289,24 @@ static unsigned long shrink_huge_zero_page_scan(struct shrinker *shrink, }static struct shrinker *huge_zero_page_shrinker; +static int huge_zero_page_shrinker_init (void ) +{ + huge_zero_page_shrinker =shrinker_alloc (0 ,"thp-zero" ); +if (!huge_zero_page_shrinker) +return -ENOMEM ; + + huge_zero_page_shrinker->count_objects = shrink_huge_zero_page_count; + huge_zero_page_shrinker->scan_objects = shrink_huge_zero_page_scan; +shrinker_register (huge_zero_page_shrinker); +return 0 ; +}
Quoted 8 lines
mm/huge_memory.c static unsigned long shrink_huge_zero_page_scan(struct shrinker *shrink, · line 308
Quoted 6 lines
mm/huge_memory.c +6
-0+ +static void huge_zero_page_shrinker_exit (void ) +{ +shrinker_free (huge_zero_page_shrinker); +return ; +}While at it, we should rename most of that to "
huge_zero_folio" I assume.
Sounds good.
Quoted 6 lines
Signature · 4 lines
-- Cheers, David / dhildenb
Re: [PATCH v2 2/5] huge_memory: add huge_zero_page_shrinker_(init|exit) function
In reply to Pankaj Raghav (Samsung)Nit on subject, function -> functions.
Quoted 8 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
Add
huge_zero_page_shrinker_init()andhuge_zero_page_shrinker_exit(). As shrinker will not be needed when static PMD zero page is enabled, these two functions can be a no-op.This is a preparation patch for static PMD zero page. No functional changes.
This is nitty stuff, but I think this is a little unclear, maybe something like:
We will soon be determining whether to use a shrinker depending on whether a static PMD zero page is available, therefore abstract out shrink initialisation and teardown such that we can more easily handle both the shrinker and static PMD zero page cases.
Quoted 2 lines
Signed-off-by Pankaj Raghav <[email protected]>
Other than nits, this LGTM, so with those addressed:
Quoted 34 lines
--- mm/huge_memory.c | 38 +++++++++++++++++++++++++++----------- 1 file changed, 27 insertions(+), 11 deletions(-)mm/huge_memory.c +18
-0@@ -289,6 +289,24 @@ static unsigned long shrink_huge_zero_page_scan(struct shrinker *shrink, }static struct shrinker *huge_zero_page_shrinker; +static int huge_zero_page_shrinker_init (void ) +{ + huge_zero_page_shrinker =shrinker_alloc (0 ,"thp-zero" ); +if (!huge_zero_page_shrinker) +return -ENOMEM ; + + huge_zero_page_shrinker->count_objects = shrink_huge_zero_page_count; + huge_zero_page_shrinker->scan_objects = shrink_huge_zero_page_scan; +shrinker_register (huge_zero_page_shrinker); +return 0 ; +} + +static void huge_zero_page_shrinker_exit (void ) +{ +shrinker_free (huge_zero_page_shrinker); +return ; +} +#ifdef CONFIG_SYSFS static ssize_t enabled_show(struct kobject *kobj,
mm/huge_memory.c static inline void hugepage_exit_sysfs(struct kobject *hugepage_kobj) · line 871
Quoted 7 lines
mm/huge_memory.c +1
-3@@ -850,33 +868,31 @@ static inline void hugepage_exit_sysfs(struct kobject *hugepage_kobj)static int __init thp_shrinker_init (void ) { - huge_zero_page_shrinker =shrinker_alloc (0 ,"thp-zero" ); -if (!huge_zero_page_shrinker) -return -ENOMEM ; +int ret =0 ;
Kinda no point in initialising to zero, unless...
Quoted 14 lines
mm/huge_memory.c +1
-7deferred_split_shrinker =shrinker_alloc (SHRINKER_NUMA_AWARE |SHRINKER_MEMCG_AWARE |SHRINKER_NONSLAB ,"thp-deferred_split" ); -if (!deferred_split_shrinker) { -shrinker_free (huge_zero_page_shrinker); +if (!deferred_split_shrinker)return -ENOMEM ; - } - - huge_zero_page_shrinker->count_objects = shrink_huge_zero_page_count; - huge_zero_page_shrinker->scan_objects = shrink_huge_zero_page_scan; -shrinker_register (huge_zero_page_shrinker);
mm/huge_memory.c static inline void hugepage_exit_sysfs(struct kobject *hugepage_kobj) · line 888
Quoted 10 lines
mm/huge_memory.c +5
-0deferred_split_shrinker->count_objects = deferred_split_count; deferred_split_shrinker->scan_objects = deferred_split_scan;shrinker_register (deferred_split_shrinker); + ret =huge_zero_page_shrinker_init (); +if (ret) { +shrinker_free (deferred_split_shrinker); +return ret; + }
... you change this to:
if (ret) shrinker_free(deferred_split_shrinker); return ret;
But it's not a big deal. Maybe I'd rename ret -> err if you keep things as they are (but don't init to 0).
Quoted 14 lines
mm/huge_memory.c +2
-2+return 0 ; }static void __init thp_shrinker_exit (void ) { -shrinker_free (huge_zero_page_shrinker); +huge_zero_page_shrinker_exit ();shrinker_free (deferred_split_shrinker); } --2.49.0
Re: [PATCH v2 2/5] huge_memory: add huge_zero_page_shrinker_(init|exit) function
Quoted 12 lines · Lorenzo Stoakes
Nit on subject, function -> functions.
Quoted 8 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
Add
huge_zero_page_shrinker_init()andhuge_zero_page_shrinker_exit(). As shrinker will not be needed when static PMD zero page is enabled, these two functions can be a no-op.This is a preparation patch for static PMD zero page. No functional changes.
Quoted 8 lines
This is nitty stuff, but I think this is a little unclear, maybe something like:
We will soon be determining whether to use a shrinker depending on whether a static PMD zero page is available, therefore abstract out shrink initialisation and teardown such that we can more easily handle both the shrinker and static PMD zero page cases.
This looks good. I will use add this to the commit message.
Quoted 6 lines
Quoted 2 lines
Signed-off-by Pankaj Raghav <[email protected]>Other than nits, this LGTM, so with those addressed:
Reviewed-by Lorenzo Stoakes <[email protected]>
Thanks.
Quoted 40 lines
mm/huge_memory.c static inline void hugepage_exit_sysfs(struct kobject *hugepage_kobj) · line 871
Quoted 10 lines
#ifdef
CONFIG_SYSFS
staticssize_tenabled_show(struct kobject *kobj,mm/huge_memory.c +1
-3@@ -850,33 +868,31 @@ static inline void hugepage_exit_sysfs(struct kobject *hugepage_kobj)static int __init thp_shrinker_init (void ) { - huge_zero_page_shrinker =shrinker_alloc (0 ,"thp-zero" ); -if (!huge_zero_page_shrinker) -return -ENOMEM ; +int ret =0 ;Kinda no point in initialising to zero, unless...
Quoted 14 lines
mm/huge_memory.c +1
-7deferred_split_shrinker =shrinker_alloc (SHRINKER_NUMA_AWARE |SHRINKER_MEMCG_AWARE |SHRINKER_NONSLAB ,"thp-deferred_split" ); -if (!deferred_split_shrinker) { -shrinker_free (huge_zero_page_shrinker); +if (!deferred_split_shrinker)return -ENOMEM ; - } - - huge_zero_page_shrinker->count_objects = shrink_huge_zero_page_count; - huge_zero_page_shrinker->scan_objects = shrink_huge_zero_page_scan; -shrinker_register (huge_zero_page_shrinker);mm/huge_memory.c static inline void hugepage_exit_sysfs(struct kobject *hugepage_kobj) · line 888
Quoted 10 lines
mm/huge_memory.c +5
-0deferred_split_shrinker->count_objects = deferred_split_count; deferred_split_shrinker->scan_objects = deferred_split_scan;shrinker_register (deferred_split_shrinker); + ret =huge_zero_page_shrinker_init (); +if (ret) { +shrinker_free (deferred_split_shrinker); +return ret; + }... you change this to:
Quoted 7 lines
if (ret) shrinker_free(deferred_split_shrinker); return ret;But it's not a big deal. Maybe I'd rename ret -> err if you keep things as they are (but don't init to 0).
Sounds good.
--
Pankaj
PATCH v2 3/5 mm: add static PMD zero page
In reply to Pankaj Raghav (Samsung)From: Pankaj Raghav <[email protected]>
There are many places in the kernel where we need to zeroout larger chunks but the maximum segment we can zeroout at a time by ZERO_PAGE is limited by PAGE_SIZE.
This is especially annoying in block devices and filesystems where we attach multiple ZERO_PAGEs to the bio in different bvecs. With multipage bvec support in block layer, it is much more efficient to send out larger zero pages as a part of single bvec.
This concern was raised during the review of adding LBS support to XFS[1][2].
Usually huge_zero_folio is allocated on demand, and it will be deallocated by the shrinker if there are no users of it left. At moment, huge_zero_folio infrastructure refcount is tied to the process lifetime that created it. This might not work for bio layer as the completitions can be async and the process that created the huge_zero_folio might no longer be alive.
Add a config option STATIC_PMD_ZERO_PAGE that will always allocate the huge_zero_folio, and it will never be freed. This makes using the huge_zero_folio without having to pass any mm struct and does not tie the lifetime of the zero folio to anything.
memblock is used to allocated this PMD zero page during early boot.
If STATIC_PMD_ZERO_PAGE config option is enabled, then mm_get_huge_zero_folio() will simply return this page instead of dynamically allocating a new PMD page.
As STATIC_PMD_ZERO_PAGE does not depend on THP, declare huge_zero_folio and huge_zero_pfn outside the THP config.
[1] https://lore.kernel.org/linux-xfs/[email protected]/
[2] https://lore.kernel.org/linux-xfs/[email protected]/
--- include/linux/mm.h | 25 ++++++++++++++++++++++++- mm/Kconfig | 9 +++++++++ mm/huge_memory.c | 24 ++++++++++++++++++++---- mm/memory.c | 25 +++++++++++++++++++++++++ mm/mm_init.c | 1 + 5 files changed, 79 insertions(+), 5 deletions(-)
include/linux/mm.h +24 -1
@@ -4018,10 +4018,19 @@ static inline bool vma_is_special_huge(const struct vm_area_struct *vma)#endif /* CONFIG_TRANSPARENT_HUGEPAGE || CONFIG_HUGETLBFS */ -#ifdef CONFIG_TRANSPARENT_HUGEPAGE +#ifdef CONFIG_STATIC_PMD_ZERO_PAGE +extern void __init static_pmd_zero_init (void ); +#else +static inline void __init static_pmd_zero_init (void ) +{ +return ; +} +#endif +extern struct folio *huge_zero_folio;extern unsigned long huge_zero_pfn; +#ifdef CONFIG_TRANSPARENT_HUGEPAGE static inline bool is_huge_zero_folio (const struct folio *folio) {return READ_ONCE (huge_zero_folio) == folio;
@@ -4032,9 +4041,23 @@ static inline bool is_huge_zero_pmd(pmd_t pmd) return pmd_present(pmd) && READ_ONCE(huge_zero_pfn) == pmd_pfn(pmd); } +#ifdef CONFIG_STATIC_PMD_ZERO_PAGE +static inline struct folio *mm_get_huge_zero_folio (struct mm_struct *mm) +{ +return READ_ONCE (huge_zero_folio); +} + +static inline void mm_put_huge_zero_folio (struct mm_struct *mm) +{ +return ; +} + +#else struct folio *mm_get_huge_zero_folio (struct mm_struct *mm);void mm_put_huge_zero_folio (struct mm_struct *mm); +#endif /* CONFIG_STATIC_PMD_ZERO_PAGE */ +#else static inline bool is_huge_zero_folio (const struct folio *folio) {
mm/Kconfig +9 -0
@@ -826,6 +826,15 @@ config ARCH_WANTS_THP_SWAP config MM_ID def_bool n +config STATIC_PMD_ZERO_PAGE + bool "Allocate a PMD page for zeroing" + help + Typically huge_zero_folio, which is a PMD page of zeroes, is allocated + on demand and deallocated when not in use. This option will + allocate a PMD sized zero page during early boot and huge_zero_folio will + use it instead allocating dynamically. + Not suitable for memory constrained systems. + menuconfig TRANSPARENT_HUGEPAGE bool "Transparent Hugepage Support" depends on HAVE_ARCH_TRANSPARENT_HUGEPAGE && !PREEMPT_RT
mm/huge_memory.c +20 -4
@@ -75,9 +75,6 @@ static unsigned long deferred_split_scan(struct shrinker *shrink, struct shrink_control *sc);static bool split_underused_thp = true; -static atomic_t huge_zero_refcount; -struct folio *huge_zero_folio__read_mostly ; -unsigned long huge_zero_pfn__read_mostly = ~0UL ;unsigned long huge_anon_orders_always__read_mostly ;unsigned long huge_anon_orders_madvise__read_mostly ;unsigned long huge_anon_orders_inherit__read_mostly ;
@@ -208,6 +205,23 @@ unsigned long __thp_vma_allowable_orders(struct vm_area_struct *vma,return orders; } +#ifdef CONFIG_STATIC_PMD_ZERO_PAGE +static int huge_zero_page_shrinker_init (void ) +{ +return 0 ; +} + +static void huge_zero_page_shrinker_exit (void ) +{ +return ; +} +#else + +static struct shrinker *huge_zero_page_shrinker; +static atomic_t huge_zero_refcount; +struct folio *huge_zero_folio__read_mostly ; +unsigned long huge_zero_pfn__read_mostly = ~0UL ; +static bool get_huge_zero_page (void ) {struct folio *zero_folio;
@@ -288,7 +302,6 @@ static unsigned long shrink_huge_zero_page_scan(struct shrinker *shrink,return 0 ; } -static struct shrinker *huge_zero_page_shrinker;static int huge_zero_page_shrinker_init (void ) { huge_zero_page_shrinker =shrinker_alloc (0 ,"thp-zero" );
@@ -307,6 +320,7 @@ static void huge_zero_page_shrinker_exit(void)return ; } +#endif #ifdef CONFIG_SYSFS static ssize_t enabled_show(struct kobject *kobj,
@@ -2843,6 +2857,8 @@ static void __split_huge_zero_page_pmd(struct vm_area_struct *vma,pte_t *pte;int i; +// FIXME: can this be called with static zero page? +VM_BUG_ON (IS_ENABLED (CONFIG_STATIC_PMD_ZERO_PAGE ));/* * Leave pmd empty until pte is filled note that it is fine to delay * notification until mmu_notifier_invalidate_range_end() as we are
mm/memory.c +25 -0
@@ -42,6 +42,7 @@#include <linux/kernel_stat.h> #include <linux/mm.h> #include <linux/mm_inline.h> +#include <linux/memblock.h> #include <linux/sched/mm.h> #include <linux/sched/numa_balancing.h> #include <linux/sched/task.h>
@@ -159,6 +160,30 @@ static int __init init_zero_pfn(void) }early_initcall (init_zero_pfn); +#ifdef CONFIG_STATIC_PMD_ZERO_PAGE +struct folio *huge_zero_folio__read_mostly =NULL ; +unsigned long huge_zero_pfn__read_mostly = ~0UL ; + +void __init static_pmd_zero_init (void ) +{ +void *alloc =memblock_alloc (PMD_SIZE ,PAGE_SIZE ); + +if (!alloc) +return ; + + huge_zero_folio =virt_to_folio (alloc); + huge_zero_pfn =page_to_pfn (virt_to_page (alloc)); + +__folio_set_head (huge_zero_folio); +prep_compound_head ((struct page *)huge_zero_folio,PMD_ORDER ); +/* Ensure zero folio won't have large_rmappable flag set. */ +folio_clear_large_rmappable (huge_zero_folio); +folio_zero_range (huge_zero_folio,0 ,PMD_SIZE ); + +return ; +} +#endif +void mm_trace_rss_stat (struct mm_struct *mm,int member) {trace_rss_stat (mm, member);
mm/mm_init.c +1 -0
@@ -2765,6 +2765,7 @@ void __init mm_core_init(void)*/ kho_memory_init (); +static_pmd_zero_init ();memblock_free_all ();mem_init ();kmem_cache_init ();
Signature · 1 line
2.49.0
Re: [PATCH v2 3/5] mm: add static PMD zero page
Quoted 14 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
There are many places in the kernel where we need to zeroout larger chunks but the maximum segment we can zeroout at a time by
ZERO_PAGEis limited byPAGE_SIZE.This is especially annoying in block devices and filesystems where we attach multiple
ZERO_PAGEsto the bio in different bvecs. With multipage bvec support in block layer, it is much more efficient to send out larger zero pages as a part of single bvec.This concern was raised during the review of adding LBS support to XFS[1][2].
Quoted 6 lines
Usually
huge_zero_foliois allocated on demand, and it will be deallocated by the shrinker if there are no users of it left. At moment,huge_zero_folioinfrastructure refcount is tied to the process lifetime that created it. This might not work for bio layer as the completitions can be async and the process that created thehuge_zero_foliomight no longer be alive.
Of course, what we could do is indicating that there is any untracked reference to the huge zero folio, and then simply refuse to free it for all eternity.
Essentially, every any non-mm reference -> un-shrinkable.
We'd still be allocating the huge zero folio dynamically. We could try allocating it on first usage either from memblock, or from the buddy if already around.
Then, we'd only need a config option to allow for that to happen.
Signature · 3 lines
Cheers, David / dhildenb
Re: [PATCH v2 3/5] mm: add static PMD zero page
Quoted 26 lines · David Hildenbrand
Quoted 14 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
There are many places in the kernel where we need to zeroout larger chunks but the maximum segment we can zeroout at a time by
ZERO_PAGEis limited byPAGE_SIZE.This is especially annoying in block devices and filesystems where we attach multiple
ZERO_PAGEsto the bio in different bvecs. With multipage bvec support in block layer, it is much more efficient to send out larger zero pages as a part of single bvec.This concern was raised during the review of adding LBS support to XFS[1][2].
Quoted 6 lines
Usually
huge_zero_foliois allocated on demand, and it will be deallocated by the shrinker if there are no users of it left. At moment,huge_zero_folioinfrastructure refcount is tied to the process lifetime that created it. This might not work for bio layer as the completitions can be async and the process that created thehuge_zero_foliomight no longer be alive.Of course, what we could do is indicating that there is any untracked reference to the huge zero folio, and then simply refuse to free it for all eternity.
Quoted 7 lines
Essentially, every any non-mm reference -> un-shrinkable.
We'd still be allocating the huge zero folio dynamically. We could try allocating it on first usage either from memblock, or from the buddy if already around.
Then, we'd only need a config option to allow for that to happen.
Something incomplete and very hacky just to give an idea. It would try allocating it if there is actual code running that would need it, and then have it stick around forever.
include/linux/huge_mm.h +26 -1
@@ -481,6 +481,7 @@ vm_fault_t do_huge_pmd_numa_page(struct vm_fault *vmf);extern struct folio *huge_zero_folio;extern unsigned long huge_zero_pfn; +atomic_t huge_zero_folio_is_static;static inline bool is_huge_zero_folio (const struct folio *folio) {
@@ -499,6 +500,16 @@ static inline bool is_huge_zero_pmd(pmd_t pmd)struct folio *mm_get_huge_zero_folio (struct mm_struct *mm);void mm_put_huge_zero_folio (struct mm_struct *mm); +struct folio *__get_static_huge_zero_folio (void ); + +static inline struct folio *get_static_huge_zero_folio (void ) +{ +if (!IS_ENMABLED (CONFIG_STATIC_HUGE_ZERO_FOLIO )) +return NULL ; +if (likely (atomic_read (&huge_zero_folio_is_static))) +return huge_zero_folio; +return get_static_huge_zero_folio (); +}static inline bool thp_migration_supported (void ) {
@@ -509,7 +520,6 @@ void split_huge_pmd_locked(struct vm_area_struct *vma, unsigned long address, pmd_t *pmd, bool freeze);bool unmap_huge_pmd_locked (struct vm_area_struct *vma,unsigned long addr,pmd_t *pmdp,struct folio *folio); -#else /* CONFIG_TRANSPARENT_HUGEPAGE */ static inline bool folio_test_pmd_mappable (struct folio *folio)
@@ -690,6 +700,11 @@ static inline int change_huge_pud(struct mmu_gather *tlb, {return 0 ; } + +static inline struct folio *static_huge_zero_folio (void ) +{ +return NULL ; +}#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ static inline int split_folio_to_list_to_order(struct folio *folio,
@@ -703,4 +718,14 @@ static inline int split_folio_to_order(struct folio *folio, int new_order) return split_folio_to_list_to_order(folio, NULL, new_order); } +static inline struct folio *largest_zero_folio (void ) +{ +struct folio *folio; + + folio =get_static_huge_zero_folio (); +if (folio) +return folio; +return page_folio (ZERO_PAGE (0 )); +} +#endif /* _LINUX_HUGE_MM_H */
mm/huge_memory.c +20 -0
@@ -77,6 +77,7 @@ static bool split_underused_thp = true;static atomic_t huge_zero_refcount;struct folio *huge_zero_folio__read_mostly ;unsigned long huge_zero_pfn__read_mostly = ~0UL ; +atomic_t huge_zero_folio_is_static__read_mostly ;unsigned long huge_anon_orders_always__read_mostly ;unsigned long huge_anon_orders_madvise__read_mostly ;unsigned long huge_anon_orders_inherit__read_mostly ;
@@ -266,6 +267,25 @@ void mm_put_huge_zero_folio(struct mm_struct *mm)put_huge_zero_page (); } +#ifdef CONFIG_STATIC_HUGE_ZERO_FOLIO +struct folio *__get_static_huge_zero_folio (void ) +{ +/* +* Our raised reference will prevent the shrinker from ever having +* success -> static. +*/ +if (atomic_read (&huge_zero_folio_is_static)) +return huge_zero_folio; +/* TODO: memblock allocation if buddy is not up yet? Or Reject that earlier. */ +if (!get_huge_zero_page ()) +return NULL ; +if (atomic_cmpxchg (&huge_zero_folio_is_static,0 ,1 ) !=0 ) +put_huge_zero_page (); +return huge_zero_folio; + +} +#endif /* CONFIG_STATIC_HUGE_ZERO_FOLIO */ +static unsigned long shrink_huge_zero_page_count (struct shrinker *shrink,struct shrink_control *sc) {
Signature · 3 lines
Cheers, David / dhildenb
Re: [PATCH v2 3/5] mm: add static PMD zero page
Quoted 6 lines
Quoted 1 line
Then, we'd only need a config option to allow for that to happen.
Something incomplete and very hacky just to give an idea. It would try allocating it if there is actual code running that would need it, and then have it stick around forever.
Thanks a lot for this David :) I think this is a much better idea and reduces the amount code and reuse the existing infrastructure.
I will try this approach in the next version.
<snip>
mm/huge_memory.c void mm_put_huge_zero_folio(struct mm_struct *mm) · line 279
Quoted 7 lines
mm/huge_memory.c +7
-0+/* +* Our raised reference will prevent the shrinker from ever having +* success -> static. +*/ +if (atomic_read (&huge_zero_folio_is_static)) +return huge_zero_folio; +/* TODO: memblock allocation if buddy is not up yet? Or Reject that earlier. */
Do we need memblock allocation? At least the use cases I forsee for static pmd zero page are all after the mm is up. So I don't see why we need to allocate it via memblock.
mm/huge_memory.c void mm_put_huge_zero_folio(struct mm_struct *mm) · line 291
Quoted 13 lines
mm/huge_memory.c +9
-0+if (!get_huge_zero_page ()) +return NULL ; +if (atomic_cmpxchg (&huge_zero_folio_is_static,0 ,1 ) !=0 ) +put_huge_zero_page (); + return huge_zero_folio; + +} +#endif /* CONFIG_STATIC_HUGE_ZERO_FOLIO */ +static unsigned long shrink_huge_zero_page_count (struct shrinker *shrink,struct shrink_control *sc) {
--
Pankaj
Re: [PATCH v2 3/5] mm: add static PMD zero page
Quoted 20 lines · Pankaj Raghav (Samsung)
Quoted 6 lines
Quoted 1 line
Then, we'd only need a config option to allow for that to happen.
Something incomplete and very hacky just to give an idea. It would try allocating it if there is actual code running that would need it, and then have it stick around forever.
Thanks a lot for this David :) I think this is a much better idea and reduces the amount code and reuse the existing infrastructure.
I will try this approach in the next version.
<snip>
mm/huge_memory.c void mm_put_huge_zero_folio(struct mm_struct *mm) · line 279
Quoted 7 lines
mm/huge_memory.c +7
-0+/* +* Our raised reference will prevent the shrinker from ever having +* success -> static. +*/ +if (atomic_read (&huge_zero_folio_is_static)) +return huge_zero_folio; +/* TODO: memblock allocation if buddy is not up yet? Or Reject that earlier. */
Quoted 3 lines
Do we need memblock allocation? At least the use cases I forsee for static pmd zero page are all after the mm is up. So I don't see why we need to allocate it via memblock.
Even better!
We might want to detect whether allocation of the huge zeropage failed a couple of times and then just give up. Otherwise, each and every user of the largest zero folio will keep allocating it.
Signature · 3 lines
Cheers, David / dhildenb
Re: [PATCH v2 3/5] mm: add static PMD zero page
Quoted 25 lines · David Hildenbrand
Quoted 20 lines · Pankaj Raghav (Samsung)
Quoted 6 lines
Quoted 1 line
Then, we'd only need a config option to allow for that to happen.
Something incomplete and very hacky just to give an idea. It would try allocating it if there is actual code running that would need it, and then have it stick around forever.
Thanks a lot for this David :) I think this is a much better idea and reduces the amount code and reuse the existing infrastructure.
I will try this approach in the next version.
<snip>
mm/huge_memory.c void mm_put_huge_zero_folio(struct mm_struct *mm) · line 279
Quoted 7 lines
mm/huge_memory.c +7
-0+/* +* Our raised reference will prevent the shrinker from ever having +* success -> static. +*/ +if (atomic_read (&huge_zero_folio_is_static)) +return huge_zero_folio; +/* TODO: memblock allocation if buddy is not up yet? Or Reject that earlier. */ Quoted 3 lines
Do we need memblock allocation? At least the use cases I forsee for static pmd zero page are all after the mm is up. So I don't see why we need to allocate it via memblock.
Quoted 5 lines
Even better!
We might want to detect whether allocation of the huge zeropage failed a couple of times and then just give up. Otherwise, each and every user of the largest zero folio will keep allocating it.
Yes, that makes sense. We need sort of like a global counter to count the nr of failures and then give up trying to allocate it if it goes above a threshold.
--
Pankaj
Re: [PATCH v2 3/5] mm: add static PMD zero page
In reply to Pankaj Raghav (Samsung)Quoted 6 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
There are many places in the kernel where we need to zeroout larger chunks but the maximum segment we can zeroout at a time by
ZERO_PAGEis limited byPAGE_SIZE.
Quoted 7 lines
This is especially annoying in block devices and filesystems where we attach multiple
ZERO_PAGEsto the bio in different bvecs. With multipage bvec support in block layer, it is much more efficient to send out larger zero pages as a part of single bvec.This concern was raised during the review of adding LBS support to XFS[1][2].
Nit, but maybe worth spelling out LBS = (presumably :P) Large Block Support.
Quoted 8 lines
Usually
huge_zero_foliois allocated on demand, and it will be deallocated by the shrinker if there are no users of it left. At moment,huge_zero_folioinfrastructure refcount is tied to the process lifetime that created it. This might not work for bio layer as the completitions can be async and the process that created thehuge_zero_foliomight no longer be alive.
Quoted 4 lines
Add a config option
STATIC_PMD_ZERO_PAGEthat will always allocate thehuge_zero_folio, and it will never be freed. This makes using thehuge_zero_foliowithout having to pass any mm struct and does not tie the lifetime of the zero folio to anything.
Can we in that case #ifndef CONFIG_STATIC_PMD_ZERO_PAGE around the refcount logic?
And surely we should additionally update mm_get_huge_zero_folio() etc. to account for this?
Quoted 28 lines
memblock is used to allocated this PMD zero page during early boot.
If
STATIC_PMD_ZERO_PAGEconfig option is enabled, thenmm_get_huge_zero_folio()will simply return this page instead of dynamically allocating a new PMD page.As
STATIC_PMD_ZERO_PAGEdoes not depend on THP, declarehuge_zero_folioandhuge_zero_pfnoutside the THP config.[1] https://lore.kernel.org/linux-xfs/[email protected]/
[2] https://lore.kernel.org/linux-xfs/[email protected]/Suggested-by David Hildenbrand <[email protected]>Signed-off-by Pankaj Raghav <[email protected]>--- include/linux/mm.h | 25 ++++++++++++++++++++++++- mm/Kconfig | 9 +++++++++ mm/huge_memory.c | 24 ++++++++++++++++++++---- mm/memory.c | 25 +++++++++++++++++++++++++ mm/mm_init.c | 1 + 5 files changed, 79 insertions(+), 5 deletions(-)include/linux/mm.h +0
-0
include/linux/mm.h static inline bool vma_is_special_huge(const struct vm_area_struct *vma) · line 4022
Quoted 6 lines
include/linux/mm.h +2
-1@@ -4018,10 +4018,19 @@ static inline bool vma_is_special_huge(const struct vm_area_struct *vma)#endif /* CONFIG_TRANSPARENT_HUGEPAGE || CONFIG_HUGETLBFS */ -#ifdef CONFIG_TRANSPARENT_HUGEPAGE +#ifdef CONFIG_STATIC_PMD_ZERO_PAGE +extern void __init static_pmd_zero_init (void );
We don't use extern for this kind of function declaration, and actually try to remove extern's as we touch header decls that have them as we go.
include/linux/mm.h static inline bool vma_is_special_huge(const struct vm_area_struct *vma) · line 4026
Quoted 4 lines
include/linux/mm.h +4
-0+#else +static inline void __init static_pmd_zero_init (void ) +{ +return ;
This return is redundant.
include/linux/mm.h static inline bool vma_is_special_huge(const struct vm_area_struct *vma) · line 4033
Quoted 7 lines
include/linux/mm.h +4
-0+} +#endif +extern struct folio *huge_zero_folio;extern unsigned long huge_zero_pfn; +#ifdef CONFIG_TRANSPARENT_HUGEPAGE
OK I guess the point here is to make huge_zero_folio, huge_zero_pfn available regardless of whether THP is enabled.
Again, I really think this should live in huge_mm.h and any place that doesn't include it needs to like, just include it :)
I really don't want these randomly placed in mm.h if we can avoid it.
Can we also add a comment saying 'this is used for both static huge PMD and THP
Quoted 6 lines
include/linux/mm.h +0
-0static inline bool is_huge_zero_folio (const struct folio *folio) {return READ_ONCE (huge_zero_folio) == folio;@@ -4032,9 +4041,23 @@ static inline bool is_huge_zero_pmd(pmd_t pmd)return pmd_present (pmd) &&READ_ONCE (huge_zero_pfn) ==pmd_pfn (pmd); }
include/linux/mm.h static inline bool is_huge_zero_pmd(pmd_t pmd) · line 4052
Quoted 10 lines
include/linux/mm.h +9
-0+#ifdef CONFIG_STATIC_PMD_ZERO_PAGE +static inline struct folio *mm_get_huge_zero_folio (struct mm_struct *mm) +{ +return READ_ONCE (huge_zero_folio); +} + +static inline void mm_put_huge_zero_folio (struct mm_struct *mm) +{ +return ;
This return is redundant.
Quoted 17 lines
include/linux/mm.h +5
-0+} + +#else struct folio *mm_get_huge_zero_folio (struct mm_struct *mm);void mm_put_huge_zero_folio (struct mm_struct *mm); +#endif /* CONFIG_STATIC_PMD_ZERO_PAGE */ +#else static inline bool is_huge_zero_folio (const struct folio *folio) {mm/Kconfig +0
-0@@ -826,6 +826,15 @@ config ARCH_WANTS_THP_SWAP config MM_ID
mm/Kconfig config ARCH_WANTS_THP_SWAP · line 836
Quoted 10 lines
mm/Kconfig +8
-0def_bool n +config STATIC_PMD_ZERO_PAGE + bool "Allocate a PMD page for zeroing" + help + Typically huge_zero_folio, which is a PMD page of zeroes, is allocated + on demand and deallocated when not in use. This option will + allocate a PMD sized zero page during early boot and huge_zero_folio will + use it instead allocating dynamically. + Not suitable for memory constrained systems.
Would have to be pretty constrained to not spare 2 MiB :P but I accept of course these devices do exist...
Quoted 9 lines
mm/Kconfig +1
-0+ menuconfig TRANSPARENT_HUGEPAGE bool "Transparent Hugepage Support" depends on HAVE_ARCH_TRANSPARENT_HUGEPAGE && !PREEMPT_RTmm/huge_memory.c +0
-0
mm/huge_memory.c static unsigned long deferred_split_scan(struct shrinker *shrink, · line 80
Quoted 6 lines
mm/huge_memory.c +0
-3@@ -75,9 +75,6 @@ static unsigned long deferred_split_scan(struct shrinker *shrink, struct shrink_control *sc);static bool split_underused_thp = true; -static atomic_t huge_zero_refcount; -struct folio *huge_zero_folio__read_mostly ; -unsigned long huge_zero_pfn__read_mostly = ~0UL ;
Ugh yeah this is a mess.
I see you're moving this to mm/memory.c because we only compile huge_memory.c if THP is enabled.
Are there any circumstances where it makes sense to want to use static PMD page and NOT have THP enabled?
It'd just be simpler if we could have CONFIG_STATIC_PMD_ZERO_PAGE depend on CONFIG_TRANSPARENT_HUGEPAGE.
Why can't we do that?
Quoted 6 lines
mm/huge_memory.c +0
-0unsigned long huge_anon_orders_always__read_mostly ;unsigned long huge_anon_orders_madvise__read_mostly ;unsigned long huge_anon_orders_inherit__read_mostly ;@@ -208,6 +205,23 @@ unsigned long __thp_vma_allowable_orders(struct vm_area_struct *vma,return orders; }
mm/huge_memory.c unsigned long __thp_vma_allowable_orders(struct vm_area_struct *vma, · line 216
Quoted 10 lines
mm/huge_memory.c +9
-0+#ifdef CONFIG_STATIC_PMD_ZERO_PAGE +static int huge_zero_page_shrinker_init (void ) +{ +return 0 ; +} + +static void huge_zero_page_shrinker_exit (void ) +{ +return ;
You seem to love putting return statements in void functions like this :P you don't need to, please remove.
Quoted 28 lines
mm/huge_memory.c +9
-1+} +#else + +static struct shrinker *huge_zero_page_shrinker; +static atomic_t huge_zero_refcount; +struct folio *huge_zero_folio__read_mostly ; +unsigned long huge_zero_pfn__read_mostly = ~0UL ; +static bool get_huge_zero_page (void ) {struct folio *zero_folio;@@ -288,7 +302,6 @@ static unsigned long shrink_huge_zero_page_scan(struct shrinker *shrink,return 0 ; } -static struct shrinker *huge_zero_page_shrinker;static int huge_zero_page_shrinker_init (void ) { huge_zero_page_shrinker =shrinker_alloc (0 ,"thp-zero" );@@ -307,6 +320,7 @@ static void huge_zero_page_shrinker_exit(void)return ; } +#endif #ifdef CONFIG_SYSFS static ssize_t enabled_show(struct kobject *kobj,
mm/huge_memory.c static void __split_huge_zero_page_pmd(struct vm_area_struct *vma, · line 2860
Quoted 4 lines
mm/huge_memory.c +1
-0@@ -2843,6 +2857,8 @@ static void __split_huge_zero_page_pmd(struct vm_area_struct *vma,pte_t *pte;int i; +// FIXME: can this be called with static zero page?
This shouldn't be in upstream code, it's up to you to determine this. And please don't use //.
mm/huge_memory.c static void __split_huge_zero_page_pmd(struct vm_area_struct *vma, · line 2861
Quoted 1 line
mm/huge_memory.c +1
-0+VM_BUG_ON (IS_ENABLED (CONFIG_STATIC_PMD_ZERO_PAGE ));
Also [VM_]BUG_ON() is _entirely_ deprecated. This should be VM_WARN_ON_ONCE().
Quoted 19 lines
mm/huge_memory.c +0
-0/* * Leave pmd empty until pte is filled note that it is fine to delay * notification until mmu_notifier_invalidate_range_end() as we are mm/memory.c +1
-0@@ -42,6 +42,7 @@#include <linux/kernel_stat.h> #include <linux/mm.h> #include <linux/mm_inline.h> +#include <linux/memblock.h> #include <linux/sched/mm.h> #include <linux/sched/numa_balancing.h> #include <linux/sched/task.h> @@ -159,6 +160,30 @@ static int __init init_zero_pfn(void) }early_initcall (init_zero_pfn);
mm/memory.c static int __init init_zero_pfn(void) · line 172
Quoted 10 lines
mm/memory.c +10
-0+#ifdef CONFIG_STATIC_PMD_ZERO_PAGE +struct folio *huge_zero_folio__read_mostly =NULL ; +unsigned long huge_zero_pfn__read_mostly = ~0UL ; + +void __init static_pmd_zero_init (void ) +{ +void *alloc =memblock_alloc (PMD_SIZE ,PAGE_SIZE ); + +if (!alloc) +return ;
Ummm... so we're fine with just having huge_zero_folio, huge_zero_pfn unintialised if the allocation fails?
This seems to be to be a rare case where we should panic the kernel? Because everything's broken now.
There's actually a memblock_alloc_or_panic() function you could use for this.
mm/memory.c static int __init init_zero_pfn(void) · line 178
Quoted 6 lines
mm/memory.c +6
-0+ + huge_zero_folio =virt_to_folio (alloc); + huge_zero_pfn =page_to_pfn (virt_to_page (alloc)); + +__folio_set_head (huge_zero_folio); +prep_compound_head ((struct page *)huge_zero_folio,PMD_ORDER );
What will the reference count be on the folio here? Might something acccidentally put this somewhere if we're not careful?
mm/memory.c static int __init init_zero_pfn(void) · line 180
Quoted 2 lines
mm/memory.c +2
-0+/* Ensure zero folio won't have large_rmappable flag set. */ +folio_clear_large_rmappable (huge_zero_folio);
Why? What would set it?
I'm a little concerned as to whether this folio is correctly initialised, need to be careful here.
mm/memory.c static int __init init_zero_pfn(void) · line 183
Quoted 3 lines
mm/memory.c +3
-0+folio_zero_range (huge_zero_folio,0 ,PMD_SIZE ); + +return ;
You don't need to put returns at the end of void functions.
Quoted 21 lines
mm/memory.c +3
-0+} +#endif +void mm_trace_rss_stat (struct mm_struct *mm,int member) {trace_rss_stat (mm, member);mm/mm_init.c +1
-1@@ -2765,6 +2765,7 @@ void __init mm_core_init(void)*/ kho_memory_init (); +static_pmd_zero_init ();memblock_free_all ();mem_init ();kmem_cache_init (); --2.49.0
PATCH v2 4/5 mm: add largest_zero_folio() routine
In reply to Pankaj Raghav (Samsung)From: Pankaj Raghav <[email protected]>
Add largest_zero_folio() routine so that huge_zero_folio can be used without the need to pass any mm struct. This will return ZERO_PAGE folio if CONFIG_STATIC_PMD_ZERO_PAGE is disabled or if we failed to allocate a PMD page from memblock.
This routine can also be called even if THP is disabled.
--- include/linux/mm.h | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-)
include/linux/mm.h +26 -2
@@ -4018,17 +4018,41 @@ static inline bool vma_is_special_huge(const struct vm_area_struct *vma)#endif /* CONFIG_TRANSPARENT_HUGEPAGE || CONFIG_HUGETLBFS */ +extern struct folio *huge_zero_folio; +extern unsigned long huge_zero_pfn; +#ifdef CONFIG_STATIC_PMD_ZERO_PAGE extern void __init static_pmd_zero_init (void ); + +/* +* largest_zero_folio - Get the largest zero size folio available +* +* This function will return a PMD sized zero folio if CONFIG_STATIC_PMD_ZERO_PAGE +* is enabled. Otherwise, a ZERO_PAGE folio is returned. +* +* Deduce the size of the folio with folio_size instead of assuming the +* folio size. +*/ +static inline struct folio *largest_zero_folio (void ) +{ +if (!huge_zero_folio) +return page_folio (ZERO_PAGE (0 )); + +return READ_ONCE (huge_zero_folio); +} +#else static inline void __init static_pmd_zero_init (void ) {return ; } + +static inline struct folio *largest_zero_folio (void ) +{ +return page_folio (ZERO_PAGE (0 )); +}#endif -extern struct folio *huge_zero_folio; -extern unsigned long huge_zero_pfn;#ifdef CONFIG_TRANSPARENT_HUGEPAGE static inline bool is_huge_zero_folio (const struct folio *folio)
Signature · 1 line
2.49.0
Re: [PATCH v2 4/5] mm: add largest_zero_folio() routine
Quoted 19 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
Add
largest_zero_folio()routine so thathuge_zero_foliocan be used without the need to pass any mm struct. This will returnZERO_PAGEfolio ifCONFIG_STATIC_PMD_ZERO_PAGEis disabled or if we failed to allocate a PMD page from memblock.This routine can also be called even if THP is disabled.
Signed-off-by Pankaj Raghav <[email protected]>--- include/linux/mm.h | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-)include/linux/mm.h +0
-0
include/linux/mm.h static inline bool vma_is_special_huge(const struct vm_area_struct *vma) · line 4022
Quoted 5 lines
include/linux/mm.h +2
-0@@ -4018,17 +4018,41 @@ static inline bool vma_is_special_huge(const struct vm_area_struct *vma)#endif /* CONFIG_TRANSPARENT_HUGEPAGE || CONFIG_HUGETLBFS */ +extern struct folio *huge_zero_folio; +extern unsigned long huge_zero_pfn;
No need for "extern".
Quoted 6 lines
include/linux/mm.h +4
-0+#ifdef CONFIG_STATIC_PMD_ZERO_PAGE extern void __init static_pmd_zero_init (void ); + +/* +* largest_zero_folio - Get the largest zero size folio available
include/linux/mm.h static inline bool vma_is_special_huge(const struct vm_area_struct *vma) · line 4038
Quoted 10 lines
include/linux/mm.h +10
-0+* +* This function will return a PMD sized zero folio if CONFIG_STATIC_PMD_ZERO_PAGE +* is enabled. Otherwise, a ZERO_PAGE folio is returned. +* +* Deduce the size of the folio with folio_size instead of assuming the +* folio size. +*/ +static inline struct folio *largest_zero_folio (void ) +{ +if (!huge_zero_folio)
Nit: if (!huge_zero_folio), but see below
I assume this check is only in place to handle whether static allocation failed, correct?
include/linux/mm.h static inline bool vma_is_special_huge(const struct vm_area_struct *vma) · line 4041
Quoted 3 lines
include/linux/mm.h +3
-0+return page_folio (ZERO_PAGE (0 )); + +return READ_ONCE (huge_zero_folio);
READ_ONCE should not be required if it cannot get freed.
include/linux/mm.h static inline bool vma_is_special_huge(const struct vm_area_struct *vma) · line 4054
Quoted 13 lines
include/linux/mm.h +7
-0+} +#else static inline void __init static_pmd_zero_init (void ) {return ; } + +static inline struct folio *largest_zero_folio (void ) +{ +return page_folio (ZERO_PAGE (0 )); +}#endif
Could we do:
static inline struct folio *largest_zero_folio(void)
{
if (IS_ENABLED(CONFIG_STATIC_PMD_ZERO_PAGE) &&
likely(huge_zero_folio))
return huge_zero_folio;
return page_folio(ZERO_PAGE(0));
}Signature · 3 lines
Cheers, David / dhildenb
Re: [PATCH v2 4/5] mm: add largest_zero_folio() routine
Quoted 21 lines · David Hildenbrand
Quoted 20 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
Add
largest_zero_folio()routine so thathuge_zero_foliocan be used without the need to pass any mm struct. This will returnZERO_PAGEfolio ifCONFIG_STATIC_PMD_ZERO_PAGEis disabled or if we failed to allocate a PMD page from memblock.This routine can also be called even if THP is disabled.
Signed-off-by Pankaj Raghav <[email protected]>--- include/linux/mm.h | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-)include/linux/mm.h +0
-0@@ -4018,17 +4018,41 @@ static inline bool vma_is_special_huge(const struct vm_area_struct *vma)
Quoted 6 lines
include/linux/mm.h static inline bool vma_is_special_huge(const struct vm_area_struct *vma) · line 4022
Quoted 4 lines
include/linux/mm.h +2
-0#endif /* CONFIG_TRANSPARENT_HUGEPAGE || CONFIG_HUGETLBFS */ +extern struct folio *huge_zero_folio; +extern unsigned long huge_zero_pfn;No need for "extern".
Scratch that, was confused with functions ...
Signature · 3 lines
Cheers, David / dhildenb
Re: [PATCH v2 4/5] mm: add largest_zero_folio() routine
In reply to Pankaj Raghav (Samsung)Nit on subject - this is a function not a routine :)
Quoted 8 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
Add
largest_zero_folio()routine so thathuge_zero_foliocan be used without the need to pass any mm struct. This will returnZERO_PAGEfolio ifCONFIG_STATIC_PMD_ZERO_PAGEis disabled or if we failed to allocate a PMD page from memblock.This routine can also be called even if THP is disabled.
This is pretty much implicit in the series as a whole though, so probably not worth mentioning :)
Quoted 11 lines
Signed-off-by Pankaj Raghav <[email protected]>--- include/linux/mm.h | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-)include/linux/mm.h +0
-0
include/linux/mm.h static inline bool vma_is_special_huge(const struct vm_area_struct *vma) · line 4022
Quoted 5 lines
include/linux/mm.h +2
-0@@ -4018,17 +4018,41 @@ static inline bool vma_is_special_huge(const struct vm_area_struct *vma)#endif /* CONFIG_TRANSPARENT_HUGEPAGE || CONFIG_HUGETLBFS */ +extern struct folio *huge_zero_folio; +extern unsigned long huge_zero_pfn;
I mean this should be i huge_mm.h again imo, but at any rate I don't know why you're moving them up here.
But maybe diff algorithm being weird?
Quoted 15 lines
include/linux/mm.h +13
-0+#ifdef CONFIG_STATIC_PMD_ZERO_PAGE extern void __init static_pmd_zero_init (void ); + +/* +* largest_zero_folio - Get the largest zero size folio available +* +* This function will return a PMD sized zero folio if CONFIG_STATIC_PMD_ZERO_PAGE +* is enabled. Otherwise, a ZERO_PAGE folio is returned. +* +* Deduce the size of the folio with folio_size instead of assuming the +* folio size. +*/ +static inline struct folio *largest_zero_folio (void ) +{
include/linux/mm.h static inline bool vma_is_special_huge(const struct vm_area_struct *vma) · line 4047
Quoted 10 lines
include/linux/mm.h +6
-0+if (!huge_zero_folio) +return page_folio (ZERO_PAGE (0 )); + + return READ_ONCE(huge_zero_folio); +} +#else static inline void __init static_pmd_zero_init (void ) {return ;
No need to return in void functions.
Quoted 16 lines
include/linux/mm.h +5
-3} + +static inline struct folio *largest_zero_folio (void ) +{ +return page_folio (ZERO_PAGE (0 )); +}#endif -extern struct folio *huge_zero_folio; -extern unsigned long huge_zero_pfn;#ifdef CONFIG_TRANSPARENT_HUGEPAGE static inline bool is_huge_zero_folio (const struct folio *folio) --2.49.0
PATCH v2 5/5 block: use largest_zero_folio in __blkdev_issue_zero_pages()
In reply to Pankaj Raghav (Samsung)From: Pankaj Raghav <[email protected]>
Use largest_zero_folio() in __blkdev_issue_zero_pages().
On systems with CONFIG_STATIC_PMD_ZERO_PAGE enabled, we will end up sending larger bvecs instead of multiple small ones.
Noticed a 4% increase in performance on a commercial NVMe SSD which does not support OP_WRITE_ZEROES. The device's MDTS was 128K. The performance gains might be bigger if the device supports bigger MDTS.
--- block/blk-lib.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-)
block/blk-lib.c +10 -7
@@ -196,6 +196,10 @@ static void __blkdev_issue_zero_pages(struct block_device *bdev, sector_t sector, sector_t nr_sects, gfp_t gfp_mask, struct bio **biop, unsigned int flags) { + struct folio *zero_folio; + + zero_folio =largest_zero_folio (); +while (nr_sects) {unsigned int nr_vecs =__blkdev_sectors_to_bio_pages (nr_sects);struct bio *bio;
@@ -208,15 +212,14 @@ static void __blkdev_issue_zero_pages(struct block_device *bdev,break ;do { -unsigned int len, added; +unsigned int len; - len =min_t (sector_t, -PAGE_SIZE , nr_sects <<SECTOR_SHIFT ); - added =bio_add_page (bio,ZERO_PAGE (0 ), len,0 ); -if (added < len) + len =min_t (sector_t,folio_size (zero_folio), + nr_sects <<SECTOR_SHIFT ); +if (!bio_add_folio (bio, zero_folio, len,0 ))break ; - nr_sects -= added >>SECTOR_SHIFT ; - sector += added >>SECTOR_SHIFT ; + nr_sects -= len >>SECTOR_SHIFT ; + sector += len >>SECTOR_SHIFT ; }while (nr_sects); *biop =bio_chain_and_submit (*biop, bio);
Signature · 1 line
2.49.0
Re: [PATCH v2 5/5] block: use largest_zero_folio in __blkdev_issue_zero_pages()
Quoted 21 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
Use
largest_zero_folio()in__blkdev_issue_zero_pages().On systems with
CONFIG_STATIC_PMD_ZERO_PAGEenabled, we will end up sending larger bvecs instead of multiple small ones.Noticed a 4% increase in performance on a commercial NVMe SSD which does not support
OP_WRITE_ZEROES. The device's MDTS was 128K. The performance gains might be bigger if the device supports bigger MDTS.Signed-off-by Pankaj Raghav <[email protected]>--- block/blk-lib.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-)block/blk-lib.c +0
-0
block/blk-lib.c static void __blkdev_issue_zero_pages(struct block_device *bdev, · line 201
Quoted 6 lines
block/blk-lib.c +3
-0@@ -196,6 +196,10 @@ static void __blkdev_issue_zero_pages(struct block_device *bdev, sector_t sector, sector_t nr_sects, gfp_t gfp_mask, struct bio **biop, unsigned int flags) { + struct folio *zero_folio; + + zero_folio =largest_zero_folio ();
Just assign this in the decl :)
Quoted 8 lines
block/blk-lib.c +1
-0+while (nr_sects) {unsigned int nr_vecs =__blkdev_sectors_to_bio_pages (nr_sects);struct bio *bio;@@ -208,15 +212,14 @@ static void __blkdev_issue_zero_pages(struct block_device *bdev,break ; do {
block/blk-lib.c static void __blkdev_issue_zero_pages(struct block_device *bdev, · line 219
Quoted 10 lines
block/blk-lib.c +4
-5-unsigned int len, added; +unsigned int len; - len =min_t (sector_t, -PAGE_SIZE , nr_sects <<SECTOR_SHIFT ); - added =bio_add_page (bio,ZERO_PAGE (0 ), len,0 ); -if (added < len) + len =min_t (sector_t,folio_size (zero_folio), + nr_sects <<SECTOR_SHIFT ); +if (!bio_add_folio (bio, zero_folio, len,0 ))
Hmm, will this work if nr_sects << SECTOR_SHIFT size isn't PMD-aligned?
I guess it actually just copies individual pages in the folio as needed?
Does this actually result in a significant performance improvement? Do we have numbers for this to justify the series?
Quoted 11 lines
block/blk-lib.c +2
-3break ; - nr_sects -= added >>SECTOR_SHIFT ; - sector += added >>SECTOR_SHIFT ; + nr_sects -= len >>SECTOR_SHIFT ; + sector += len >>SECTOR_SHIFT ; }while (nr_sects); *biop =bio_chain_and_submit (*biop, bio); --2.49.0
Re: [PATCH v2 5/5] block: use largest_zero_folio in __blkdev_issue_zero_pages()
Quoted 17 lines · Lorenzo Stoakes
Quoted 16 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
Use
largest_zero_folio()in__blkdev_issue_zero_pages().On systems with
CONFIG_STATIC_PMD_ZERO_PAGEenabled, we will end up sending larger bvecs instead of multiple small ones.Noticed a 4% increase in performance on a commercial NVMe SSD which does not support
OP_WRITE_ZEROES. The device's MDTS was 128K. The performance gains might be bigger if the device supports bigger MDTS.Signed-off-by Pankaj Raghav <[email protected]>--- block/blk-lib.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-)
Quoted 13 lines
block/blk-lib.c static void __blkdev_issue_zero_pages(struct block_device *bdev, · line 201
Quoted 11 lines
block/blk-lib.c +3
-0@@ -196,6 +196,10 @@ static void __blkdev_issue_zero_pages(struct block_device *bdev, sector_t sector, sector_t nr_sects, gfp_t gfp_mask, struct bio **biop, unsigned int flags) { + struct folio *zero_folio; + + zero_folio =largest_zero_folio ();Just assign this in the decl :)
Yeah!
Quoted 12 lines
Quoted 12 lines
block/blk-lib.c +2
-1+while (nr_sects) {unsigned int nr_vecs =__blkdev_sectors_to_bio_pages (nr_sects);struct bio *bio;@@ -208,15 +212,14 @@ static void __blkdev_issue_zero_pages(struct block_device *bdev,break ; do { - unsigned int len, added; + unsigned int len;
Quoted 9 lines
block/blk-lib.c static void __blkdev_issue_zero_pages(struct block_device *bdev, · line 219
Quoted 7 lines
block/blk-lib.c +3
-4- len =min_t (sector_t, -PAGE_SIZE , nr_sects <<SECTOR_SHIFT ); - added =bio_add_page (bio,ZERO_PAGE (0 ), len,0 ); -if (added < len) + len =min_t (sector_t,folio_size (zero_folio), + nr_sects <<SECTOR_SHIFT ); +if (!bio_add_folio (bio, zero_folio, len,0 ))Hmm, will this work if
nr_sects<<SECTOR_SHIFTsize isn't PMD-aligned?
Yeah, that should not be a problem as long as (nr_sects << SECTOR_SHIFT) < PMD_SIZED folio.
Quoted 5 lines
I guess it actually just copies individual pages in the folio as needed?
Does this actually result in a significant performance improvement? Do we have numbers for this to justify the series?
I put it in my commit message:
``` Noticed a 4% increase in performance on a commercial NVMe SSD which does not support OP_WRITE_ZEROES. The device's MDTS was 128K. The performance gains might be bigger if the device supports bigger MDTS. ```
Even though it is more of a synthetic benchmark, but this goes to show the effects of adding multiple bio_vecs with ZERO_PAGE instead of single PMD_ZERO_PAGE.
--
Pankaj
Zi Yan
reviewerQuoted 26 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
There are many places in the kernel where we need to zeroout larger chunks but the maximum segment we can zeroout at a time by
ZERO_PAGEis limited byPAGE_SIZE.This concern was raised during the review of adding Large Block Size support to XFS[1][2].
This is especially annoying in block devices and filesystems where we attach multiple
ZERO_PAGEsto the bio in different bvecs. With multipage bvec support in block layer, it is much more efficient to send out larger zero pages as a part of a single bvec.Some examples of places in the kernel where this could be useful:
-blkdev_issue_zero_pages()
-iomap_dio_zero()
- vmalloc.c:zero_iter()
-rxperf_process_call()
-fscrypt_zeroout_range_inline_crypt()
-bch2_checksum_update()
...We already have
huge_zero_foliothat is allocated on demand, and it will be deallocated by the shrinker if there are no users of it left.
Quoted 7 lines
At moment,
huge_zero_folioinfrastructure refcount is tied to the process lifetime that created it. This might not work for bio layer as the completions can be async and the process that created thehuge_zero_foliomight no longer be alive.Add a config option
STATIC_PMD_ZERO_PAGEthat will always allocate thehuge_zero_foliovia memblock, and it will never be freed.
Do the above users want a PMD sized zero page or a 2MB zero page? Because on systems with non 4KB base page size, e.g., ARM64 with 64KB base page, PMD size is different. ARM64 with 64KB base page has 512MB PMD sized pages. Having STATIC_PMD_ZERO_PAGE means losing half GB memory. I am not sure if it is acceptable.
Best Regards,
Yan, Zi
Hi Zi,
Quoted 8 lines
Quoted 2 lines
Add a config option
STATIC_PMD_ZERO_PAGEthat will always allocate thehuge_zero_foliovia memblock, and it will never be freed.Do the above users want a PMD sized zero page or a 2MB zero page? Because on systems with non 4KB base page size, e.g., ARM64 with 64KB base page, PMD size is different. ARM64 with 64KB base page has 512MB PMD sized pages. Having
STATIC_PMD_ZERO_PAGEmeans losing half GB memory. I am not sure if it is acceptable.
That is a good point. My intial RFC patches allocated 2M instead of a PMD sized page.
But later David wanted to reuse the memory we allocate here with huge_zero_folio. So if this config is enabled, we simply just use the same pointer for huge_zero_folio.
Since that happened, I decided to go with PMD sized page.
This config is still opt in and I would expect the users with 64k page size systems to not enable this.
But to make sure we don't enable this for those architecture, I could do a per-arch opt in with something like this[1] that I did in my previous patch:
arch/x86/Kconfig +1 -0
@@ -153,6 +153,7 @@ config X86 select ARCH_WANT_OPTIMIZE_HUGETLB_VMEMMAP if X86_64 select ARCH_WANT_HUGETLB_VMEMMAP_PREINIT if X86_64 select ARCH_WANTS_THP_SWAP if X86_64 + select ARCH_HAS_STATIC_PMD_ZERO_PAGE if X86_64 select ARCH_HAS_PARANOID_L1D_FLUSH select ARCH_WANT_IRQS_OFF_ACTIVATE_MM select BUILDTIME_TABLE_SORT
mm/Kconfig +6 -0
@@ -826,6 +826,19 @@ config ARCH_WANTS_THP_SWAP config MM_ID def_bool n +config ARCH_HAS_STATIC_PMD_ZERO_PAGE + def_bool n + +config STATIC_PMD_ZERO_PAGE + bool "Allocate a PMD page for zeroing" + depends on ARCH_HAS_STATIC_PMD_ZERO_PAGE
<snip>
Let me know your thoughts.
[1] https://lore.kernel.org/linux-mm/[email protected]/#Z31mm:Kconfig
--
Pankaj
Zi Yan
reviewerQuoted 11 lines · Pankaj Raghav
Hi Zi,
Quoted 8 lines
Quoted 2 lines
Add a config option
STATIC_PMD_ZERO_PAGEthat will always allocate thehuge_zero_foliovia memblock, and it will never be freed.Do the above users want a PMD sized zero page or a 2MB zero page? Because on systems with non 4KB base page size, e.g., ARM64 with 64KB base page, PMD size is different. ARM64 with 64KB base page has 512MB PMD sized pages. Having
STATIC_PMD_ZERO_PAGEmeans losing half GB memory. I am not sure if it is acceptable.
Quoted 7 lines
That is a good point. My intial RFC patches allocated 2M instead of a PMD sized page.
But later David wanted to reuse the memory we allocate here with
huge_zero_folio. So if this config is enabled, we simply just use the same pointer forhuge_zero_folio.Since that happened, I decided to go with PMD sized page.
Got it. Thank you for the explanation. This means for your use cases 2MB is big enough. For those arch which have PMD > 2MB, ideally, a 2MB zero mTHP should be used. Thinking about this feature long term, I wonder what we should do to support arch with PMD > 2MB. Make the static huge zero page size a boot time parameter?
Quoted 37 lines
This config is still opt in and I would expect the users with 64k page size systems to not enable this.
But to make sure we don't enable this for those architecture, I could do a per-arch opt in with something like this[1] that I did in my previous patch:
arch/x86/Kconfig +1
-0@@ -153,6 +153,7 @@ config X86 select ARCH_WANT_OPTIMIZE_HUGETLB_VMEMMAP if X86_64 select ARCH_WANT_HUGETLB_VMEMMAP_PREINIT if X86_64 select ARCH_WANTS_THP_SWAP if X86_64 + select ARCH_HAS_STATIC_PMD_ZERO_PAGE if X86_64 select ARCH_HAS_PARANOID_L1D_FLUSH select ARCH_WANT_IRQS_OFF_ACTIVATE_MM select BUILDTIME_TABLE_SORTmm/Kconfig +6
-0@@ -826,6 +826,19 @@ config ARCH_WANTS_THP_SWAP config MM_ID def_bool n +config ARCH_HAS_STATIC_PMD_ZERO_PAGE + def_bool n + +config STATIC_PMD_ZERO_PAGE + bool "Allocate a PMD page for zeroing" + depends on ARCH_HAS_STATIC_PMD_ZERO_PAGE
Quoted 1 line
Let me know your thoughts.
Sounds good to me, since without STATIC_PMD_ZERO_PAGE, when THP is enabled, the use cases you mentioned are still able to use the THP zero page.
Thanks.
Quoted 4 lines
[1] https://lore.kernel.org/linux-mm/[email protected]/#Z31mm:Kconfig
--
Pankaj
Best Regards,
Yan, Zi
Quoted 44 lines · Pankaj Raghav
Hi Zi,
Quoted 8 lines
Quoted 2 lines
Add a config option
STATIC_PMD_ZERO_PAGEthat will always allocate thehuge_zero_foliovia memblock, and it will never be freed.Do the above users want a PMD sized zero page or a 2MB zero page? Because on systems with non 4KB base page size, e.g., ARM64 with 64KB base page, PMD size is different. ARM64 with 64KB base page has 512MB PMD sized pages. Having
STATIC_PMD_ZERO_PAGEmeans losing half GB memory. I am not sure if it is acceptable.That is a good point. My intial RFC patches allocated 2M instead of a PMD sized page.
But later David wanted to reuse the memory we allocate here with
huge_zero_folio. So if this config is enabled, we simply just use the same pointer forhuge_zero_folio.Since that happened, I decided to go with PMD sized page.
This config is still opt in and I would expect the users with 64k page size systems to not enable this.
But to make sure we don't enable this for those architecture, I could do a per-arch opt in with something like this[1] that I did in my previous patch:
arch/x86/Kconfig +1
-0@@ -153,6 +153,7 @@ config X86 select ARCH_WANT_OPTIMIZE_HUGETLB_VMEMMAP if X86_64 select ARCH_WANT_HUGETLB_VMEMMAP_PREINIT if X86_64 select ARCH_WANTS_THP_SWAP if X86_64 + select ARCH_HAS_STATIC_PMD_ZERO_PAGE if X86_64 select ARCH_HAS_PARANOID_L1D_FLUSH select ARCH_WANT_IRQS_OFF_ACTIVATE_MM select BUILDTIME_TABLE_SORTmm/Kconfig +0
-0
mm/Kconfig config ARCH_WANTS_THP_SWAP · line 830
Quoted 5 lines
mm/Kconfig +2
-0@@ -826,6 +826,19 @@ config ARCH_WANTS_THP_SWAP config MM_ID def_bool n +config ARCH_HAS_STATIC_PMD_ZERO_PAGE + def_bool n
Hm is this correct? arm64 supports mutliple page tables sizes, so while the architecture might 'support' it, it will vary based on page size, so actually we don't care about arch at all?
mm/Kconfig config ARCH_WANTS_THP_SWAP · line 834
Quoted 4 lines
mm/Kconfig +4
-0+ +config STATIC_PMD_ZERO_PAGE + bool "Allocate a PMD page for zeroing" + depends on ARCH_HAS_STATIC_PMD_ZERO_PAGE
Maybe need to just make this depend on !CONFIG_PAGE_SIZE_xx?
Quoted 7 lines
<snip>
Let me know your thoughts.
[1] https://lore.kernel.org/linux-mm/[email protected]/#Z31mm:Kconfig
--
Pankaj
Quoted 55 lines · Lorenzo Stoakes
Quoted 44 lines · Pankaj Raghav
Hi Zi,
Quoted 8 lines
Quoted 2 lines
Add a config option
STATIC_PMD_ZERO_PAGEthat will always allocate thehuge_zero_foliovia memblock, and it will never be freed.Do the above users want a PMD sized zero page or a 2MB zero page? Because on systems with non 4KB base page size, e.g., ARM64 with 64KB base page, PMD size is different. ARM64 with 64KB base page has 512MB PMD sized pages. Having
STATIC_PMD_ZERO_PAGEmeans losing half GB memory. I am not sure if it is acceptable.That is a good point. My intial RFC patches allocated 2M instead of a PMD sized page.
But later David wanted to reuse the memory we allocate here with
huge_zero_folio. So if this config is enabled, we simply just use the same pointer forhuge_zero_folio.Since that happened, I decided to go with PMD sized page.
This config is still opt in and I would expect the users with 64k page size systems to not enable this.
But to make sure we don't enable this for those architecture, I could do a per-arch opt in with something like this[1] that I did in my previous patch:
arch/x86/Kconfig +1
-0@@ -153,6 +153,7 @@ config X86 select ARCH_WANT_OPTIMIZE_HUGETLB_VMEMMAP if X86_64 select ARCH_WANT_HUGETLB_VMEMMAP_PREINIT if X86_64 select ARCH_WANTS_THP_SWAP if X86_64 + select ARCH_HAS_STATIC_PMD_ZERO_PAGE if X86_64 select ARCH_HAS_PARANOID_L1D_FLUSH select ARCH_WANT_IRQS_OFF_ACTIVATE_MM select BUILDTIME_TABLE_SORTmm/Kconfig +0
-0mm/Kconfig config ARCH_WANTS_THP_SWAP · line 830
Quoted 5 lines
mm/Kconfig +2
-0@@ -826,6 +826,19 @@ config ARCH_WANTS_THP_SWAP config MM_ID def_bool n +config ARCH_HAS_STATIC_PMD_ZERO_PAGE + def_bool nHm is this correct? arm64 supports mutliple page tables sizes, so while the architecture might 'support' it, it will vary based on page size, so actually we don't care about arch at all?
Quoted 6 lines
mm/Kconfig config ARCH_WANTS_THP_SWAP · line 834
Quoted 4 lines
mm/Kconfig +4
-0+ +config STATIC_PMD_ZERO_PAGE + bool "Allocate a PMD page for zeroing" + depends on ARCH_HAS_STATIC_PMD_ZERO_PAGEMaybe need to just make this depend on !CONFIG_PAGE_SIZE_xx?
I think at some point we discussed "when does the PMD-sized zeropage make *any* sense on these weird arch configs" (512MiB on arm64 64bit)
No idea who wants to waste half a gig on that at runtime either.
But yeah, we should let the arch code opt in whether it wants it or not (in particular, maybe only on arm64 with CONFIG_PAGE_SIZE_4K)
Signature · 3 lines
Cheers, David / dhildenb
Quoted 4 lines · David Hildenbrand
I think at some point we discussed "when does the PMD-sized zeropage make *any* sense on these weird arch configs" (512MiB on arm64 64bit)
No idea who wants to waste half a gig on that at runtime either.
Yeah this is a problem we _really_ need to solve. But obviously somewhat out of scope here.
Quoted 3 lines
But yeah, we should let the arch code opt in whether it wants it or not (in particular, maybe only on arm64 with
CONFIG_PAGE_SIZE_4K)
I don't think this should be an ARCH_HAS_xxx.
Because that's saying 'this architecture has X', this isn't architecture scope.
I suppose PMDs may vary in terms of how huge they are regardless of page table size actually.
So maybe the best solution is a semantic one - just rename this to ARCH_WANT_STATIC_PMD_ZERO_PAGE
And then put the page size selector in the arch code.
For example in arm64 we have:
select ARCH_WANT_HUGE_PMD_SHARE if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36)
So doing something similar here like:
select ARCH_WANT_STATIC_PMD_ZERO_PAGE if ARM64_4K_PAGES
Would do thie job and sort everything out.
Quoted 6 lines
--
Cheers,David / dhildenb
CHeers, Lorenzo
Quoted 28 lines · Lorenzo Stoakes
Quoted 4 lines · David Hildenbrand
I think at some point we discussed "when does the PMD-sized zeropage make *any* sense on these weird arch configs" (512MiB on arm64 64bit)
No idea who wants to waste half a gig on that at runtime either.
Yeah this is a problem we _really_ need to solve. But obviously somewhat out of scope here.
Quoted 3 lines
But yeah, we should let the arch code opt in whether it wants it or not (in particular, maybe only on arm64 with
CONFIG_PAGE_SIZE_4K)I don't think this should be an
ARCH_HAS_xxx.Because that's saying 'this architecture has X', this isn't architecture scope.
I suppose PMDs may vary in terms of how huge they are regardless of page table size actually.
So maybe the best solution is a semantic one - just rename this to
ARCH_WANT_STATIC_PMD_ZERO_PAGEAnd then put the page size selector in the arch code.
For example in arm64 we have:
Quoted 7 lines
select ARCH_WANT_HUGE_PMD_SHARE if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36)So doing something similar here like:
select
ARCH_WANT_STATIC_PMD_ZERO_PAGEifARM64_4K_PAGESWould do thie job and sort everything out.
Yes.
Signature · 3 lines
Cheers, David / dhildenb
Quoted 31 lines · David Hildenbrand
Quoted 30 lines · Lorenzo Stoakes
Quoted 4 lines · David Hildenbrand
I think at some point we discussed "when does the PMD-sized zeropage make *any* sense on these weird arch configs" (512MiB on arm64 64bit)
No idea who wants to waste half a gig on that at runtime either.
Yeah this is a problem we _really_ need to solve. But obviously somewhat out of scope here.
Quoted 3 lines
But yeah, we should let the arch code opt in whether it wants it or not (in particular, maybe only on arm64 with
CONFIG_PAGE_SIZE_4K)I don't think this should be an
ARCH_HAS_xxx.Because that's saying 'this architecture has X', this isn't architecture scope.
I suppose PMDs may vary in terms of how huge they are regardless of page table size actually.
So maybe the best solution is a semantic one - just rename this to
ARCH_WANT_STATIC_PMD_ZERO_PAGEAnd then put the page size selector in the arch code.
For example in arm64 we have:
select ARCH_WANT_HUGE_PMD_SHARE if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36)
Quoted 7 lines
Quoted 5 lines
So doing something similar here like:
select
ARCH_WANT_STATIC_PMD_ZERO_PAGEifARM64_4K_PAGESWould do thie job and sort everything out.
Yes.
Actually I had something similar in one of my earlier versions[1] where we can opt in from arch specific Kconfig with *WANT* instead *HAS*.
For starters, I will enable this only from x86. We can probably extend this once we get the base patches up.
[1] https://lore.kernel.org/linux-mm/[email protected]/
--
Pankaj
Quoted 38 lines · Pankaj Raghav (Samsung)
Quoted 37 lines · David Hildenbrand
Quoted 35 lines · Lorenzo Stoakes
Quoted 4 lines · David Hildenbrand
I think at some point we discussed "when does the PMD-sized zeropage make *any* sense on these weird arch configs" (512MiB on arm64 64bit)
No idea who wants to waste half a gig on that at runtime either.
Yeah this is a problem we _really_ need to solve. But obviously somewhat out of scope here.
Quoted 3 lines
But yeah, we should let the arch code opt in whether it wants it or not (in particular, maybe only on arm64 with
CONFIG_PAGE_SIZE_4K)I don't think this should be an
ARCH_HAS_xxx.Because that's saying 'this architecture has X', this isn't architecture scope.
I suppose PMDs may vary in terms of how huge they are regardless of page table size actually.
So maybe the best solution is a semantic one - just rename this to
ARCH_WANT_STATIC_PMD_ZERO_PAGEAnd then put the page size selector in the arch code.
For example in arm64 we have:
select ARCH_WANT_HUGE_PMD_SHARE if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36)So doing something similar here like:
select
ARCH_WANT_STATIC_PMD_ZERO_PAGEifARM64_4K_PAGESWould do thie job and sort everything out.
Quoted 7 lines
Quoted 1 line
Yes.
Actually I had something similar in one of my earlier versions[1] where we can opt in from arch specific
Kconfigwith *WANT* instead *HAS*.For starters, I will enable this only from x86. We can probably extend this once we get the base patches up.
Makes sense.
Signature · 3 lines
Cheers, David / dhildenb
Andrew Morton
maintainerQuoted 21 lines · On Mon, 7 Jul 2025 16:23:14 +0200 "Pankaj Raghav (Samsung)"…
There are many places in the kernel where we need to zeroout larger chunks but the maximum segment we can zeroout at a time by
ZERO_PAGEis limited byPAGE_SIZE.This concern was raised during the review of adding Large Block Size support to XFS[1][2].
This is especially annoying in block devices and filesystems where we attach multiple
ZERO_PAGEsto the bio in different bvecs. With multipage bvec support in block layer, it is much more efficient to send out larger zero pages as a part of a single bvec.Some examples of places in the kernel where this could be useful:
-blkdev_issue_zero_pages()
-iomap_dio_zero()
- vmalloc.c:zero_iter()
-rxperf_process_call()
-fscrypt_zeroout_range_inline_crypt()
-bch2_checksum_update()
...
Quoted 7 lines
We already have
huge_zero_foliothat is allocated on demand, and it will be deallocated by the shrinker if there are no users of it left.At moment,
huge_zero_folioinfrastructure refcount is tied to the process lifetime that created it. This might not work for bio layer as the completions can be async and the process that created thehuge_zero_foliomight no longer be alive.
Can we change that? Alter the refcounting model so that dropping the final reference at interrupt time works as expected?
And if we were to do this, what sort of benefit might it produce?
Quoted 2 lines
Add a config option
STATIC_PMD_ZERO_PAGEthat will always allocate thehuge_zero_foliovia memblock, and it will never be freed.
Hi Andrew,
Quoted 11 lines
Quoted 7 lines
We already have
huge_zero_foliothat is allocated on demand, and it will be deallocated by the shrinker if there are no users of it left.At moment,
huge_zero_folioinfrastructure refcount is tied to the process lifetime that created it. This might not work for bio layer as the completions can be async and the process that created thehuge_zero_foliomight no longer be alive.Can we change that? Alter the refcounting model so that dropping the final reference at interrupt time works as expected?
That is an interesting point. I did not try it. At the moment, we always drop the reference in __mmput().
Going back to the discussion before this work started, one of the main thing that people wanted was to use some sort of a **drop in replacement** for ZERO_PAGE that can be bigger than PAGE_SIZE[1].
And, during the RFCs of these patches, one of the feedback I got from David was in big server systems, 2M (in the case of 4k page size) should not be a problem and we don't need any unnecessary refcounting for them.
Also when I had a chat with David, he also wants to make changes to the existing mm_huge_zero_folio infrastructure to get rid of shrinker if possible. So we decided that it is better to have opt-in static allocation and keep the existing dynamic allocation path.
So that is why I went with this approach of having a static PMD allocation.
I hope this clarifies the motivation a bit.
Let me know if you have more questions.
Quoted 4 lines
And if we were to do this, what sort of benefit might it produce?
Quoted 2 lines
Add a config option
STATIC_PMD_ZERO_PAGEthat will always allocate thehuge_zero_foliovia memblock, and it will never be freed.
Quoted 26 lines · Andrew Morton
Quoted 24 lines · On Mon, 7 Jul 2025 16:23:14 +0200 "Pankaj Raghav (Samsung)"…
There are many places in the kernel where we need to zeroout larger chunks but the maximum segment we can zeroout at a time by
ZERO_PAGEis limited byPAGE_SIZE.This concern was raised during the review of adding Large Block Size support to XFS[1][2].
This is especially annoying in block devices and filesystems where we attach multiple
ZERO_PAGEsto the bio in different bvecs. With multipage bvec support in block layer, it is much more efficient to send out larger zero pages as a part of a single bvec.Some examples of places in the kernel where this could be useful:
-blkdev_issue_zero_pages()
-iomap_dio_zero()
- vmalloc.c:zero_iter()
-rxperf_process_call()
-fscrypt_zeroout_range_inline_crypt()
-bch2_checksum_update()
...We already have
huge_zero_foliothat is allocated on demand, and it will be deallocated by the shrinker if there are no users of it left.
Quoted 7 lines
Quoted 4 lines
At moment,
huge_zero_folioinfrastructure refcount is tied to the process lifetime that created it. This might not work for bio layer as the completions can be async and the process that created thehuge_zero_foliomight no longer be alive.Can we change that? Alter the refcounting model so that dropping the final reference at interrupt time works as expected?
I would hope that we can drop that whole shrinking+freeing mechanism at some point, and simply always keep it around once allocated.
Any unprivileged process can keep the huge zero folio mapped and, therefore, around, until that process is killed ...
But I assume some people might still have an opinion on the shrinker, so for the time being having a second static model might be less controversial.
(I don't think we should be refcounting the huge zerofolio in the long term)
Signature · 3 lines
Cheers, David / dhildenb
Hi David,
For now I have some feedback from Zi. It would be great to hear your feedback before I send the next version :)
--
Pankaj
Quoted 76 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
There are many places in the kernel where we need to zeroout larger chunks but the maximum segment we can zeroout at a time by
ZERO_PAGEis limited byPAGE_SIZE.This concern was raised during the review of adding Large Block Size support to XFS[1][2].
This is especially annoying in block devices and filesystems where we attach multiple
ZERO_PAGEsto the bio in different bvecs. With multipage bvec support in block layer, it is much more efficient to send out larger zero pages as a part of a single bvec.Some examples of places in the kernel where this could be useful:
-blkdev_issue_zero_pages()
-iomap_dio_zero()
- vmalloc.c:zero_iter()
-rxperf_process_call()
-fscrypt_zeroout_range_inline_crypt()
-bch2_checksum_update()
...We already have
huge_zero_foliothat is allocated on demand, and it will be deallocated by the shrinker if there are no users of it left.At moment,
huge_zero_folioinfrastructure refcount is tied to the process lifetime that created it. This might not work for bio layer as the completions can be async and the process that created thehuge_zero_foliomight no longer be alive.Add a config option
STATIC_PMD_ZERO_PAGEthat will always allocate thehuge_zero_foliovia memblock, and it will never be freed.I have converted
blkdev_issue_zero_pages()as an example as a part of this series.I will send patches to individual subsystems using the
huge_zero_folioonce this gets upstreamed.Looking forward to some feedback.
[1] https://lore.kernel.org/linux-xfs/[email protected]/
[2] https://lore.kernel.org/linux-xfs/[email protected]/Changes since v1:
- Move from .bss to allocating it through memblock(David)Changes since RFC:
- Added the config option based on the feedback from David.
- Encode more info in the header to avoid dead code (Dave hansen feedback)
- The static part ofhuge_zero_folioinmemory.cand the dynamic part stays inhuge_memory.c
- Split the patches to make it easy for review.Pankaj Raghav (5):
mm: movehuge_zero_pagedeclaration fromhuge_mm.htomm.h
huge_memory: addhuge_zero_page_shrinker_(init|exit)function
mm: add static PMD zero page
mm: addlargest_zero_folio()routine
block: uselargest_zero_folioin__blkdev_issue_zero_pages()block/blk-lib.c | 17 +++++---- include/linux/huge_mm.h | 31 ---------------- include/linux/mm.h | 81 +++++++++++++++++++++++++++++++++++++++++ mm/Kconfig | 9 +++++ mm/huge_memory.c | 62 +++++++++++++++++++++++-------- mm/memory.c | 25 +++++++++++++ mm/mm_init.c | 1 + 7 files changed, 173 insertions(+), 53 deletions(-)base-commit:
d7b8f8e20813f0179d8ef519541a3527e7661d3a--
2.49.0
Note that this series does not apply to mm-new. Please rebase for the next respin.
Pankaj,
There seems to be quite a lot to work on here, and it seems rather speculative, so can we respin as an RFC please?
Thanks! :)
Quoted 77 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
There are many places in the kernel where we need to zeroout larger chunks but the maximum segment we can zeroout at a time by
ZERO_PAGEis limited byPAGE_SIZE.This concern was raised during the review of adding Large Block Size support to XFS[1][2].
This is especially annoying in block devices and filesystems where we attach multiple
ZERO_PAGEsto the bio in different bvecs. With multipage bvec support in block layer, it is much more efficient to send out larger zero pages as a part of a single bvec.Some examples of places in the kernel where this could be useful:
-blkdev_issue_zero_pages()
-iomap_dio_zero()
- vmalloc.c:zero_iter()
-rxperf_process_call()
-fscrypt_zeroout_range_inline_crypt()
-bch2_checksum_update()
...We already have
huge_zero_foliothat is allocated on demand, and it will be deallocated by the shrinker if there are no users of it left.At moment,
huge_zero_folioinfrastructure refcount is tied to the process lifetime that created it. This might not work for bio layer as the completions can be async and the process that created thehuge_zero_foliomight no longer be alive.Add a config option
STATIC_PMD_ZERO_PAGEthat will always allocate thehuge_zero_foliovia memblock, and it will never be freed.I have converted
blkdev_issue_zero_pages()as an example as a part of this series.I will send patches to individual subsystems using the
huge_zero_folioonce this gets upstreamed.Looking forward to some feedback.
[1] https://lore.kernel.org/linux-xfs/[email protected]/
[2] https://lore.kernel.org/linux-xfs/[email protected]/Changes since v1:
- Move from .bss to allocating it through memblock(David)Changes since RFC:
- Added the config option based on the feedback from David.
- Encode more info in the header to avoid dead code (Dave hansen feedback)
- The static part ofhuge_zero_folioinmemory.cand the dynamic part stays inhuge_memory.c
- Split the patches to make it easy for review.Pankaj Raghav (5):
mm: movehuge_zero_pagedeclaration fromhuge_mm.htomm.h
huge_memory: addhuge_zero_page_shrinker_(init|exit)function
mm: add static PMD zero page
mm: addlargest_zero_folio()routine
block: uselargest_zero_folioin__blkdev_issue_zero_pages()block/blk-lib.c | 17 +++++---- include/linux/huge_mm.h | 31 ---------------- include/linux/mm.h | 81 +++++++++++++++++++++++++++++++++++++++++ mm/Kconfig | 9 +++++ mm/huge_memory.c | 62 +++++++++++++++++++++++-------- mm/memory.c | 25 +++++++++++++ mm/mm_init.c | 1 + 7 files changed, 173 insertions(+), 53 deletions(-)base-commit:
d7b8f8e20813f0179d8ef519541a3527e7661d3a--
2.49.0
Hi Lorenzo,
Quoted 5 lines · Lorenzo Stoakes
Pankaj,
There seems to be quite a lot to work on here, and it seems rather speculative, so can we respin as an RFC please?
Thanks for all the review comments.
Yeah, I agree. I will resend it as RFC. I will try the new approach suggested by David in Patch 3 in the next version.
--
Pankaj