Skip to contentSkip to conversation

mmc: loongson2: prevent integer overflow in ret variable

PATCH In review Sergio Perez Gonzalez 3 participants 3 messages Jul 7, 2025 – Jul 9, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: loongson2: prevent integer overflow in ret variable

In loongson2_mmc_dll_mode_init(), ret variable is declared as u32 but it is expected to hold an int value.

Fixes d0f8e961deae ("mc: loongson2: Add Loongson-2K2000 SD/SDIO/eMMC controller driver")
---
 drivers/mmc/host/loongson2-mmc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mmc/host/loongson2-mmc.c +2 -1
index 515ccf834f0a..ba6bb8fd5535 100644
@@ -485,7 +485,8 @@ static irqreturn_t loongson2_mmc_irq(int irq, void *devid)
 
 static void loongson2_mmc_dll_mode_init(struct loongson2_mmc_host *host)
 {
-	u32 val, pad_delay, delay, ret;
+	u32 val, pad_delay, delay;
+	int ret;
 
 	regmap_update_bits(host->regmap, LOONGSON2_MMC_REG_SEL,
 			   LOONGSON2_MMC_SEL_DATA, LOONGSON2_MMC_SEL_DATA);
Signature · 1 line
2.43.0
maintainer Reviewed-by on v1 1/1
#1 lore raw

Hi Sergio:

Thanks for your patch.

Quoted 7 lines · Sergio Perez Gonzalez

In loongson2_mmc_dll_mode_init(), ret variable is declared as u32 but it is expected to hold an int value.

Fixes d0f8e961deae ("mc: loongson2: Add Loongson-2K2000 SD/SDIO/eMMC controller driver")
Quoted 9 lines
---
  drivers/mmc/host/loongson2-mmc.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mmc/host/loongson2-mmc.c +0 -0
index 515ccf834f0a..ba6bb8fd5535 100644

drivers/mmc/host/loongson2-mmc.c static irqreturn_t loongson2_mmc_irq(int irq, void *devid) · line 492

Quoted 9 lines
drivers/mmc/host/loongson2-mmc.c +2 -1
@@ -485,7 +485,8 @@ static irqreturn_t loongson2_mmc_irq(int irq, void *devid)
 
  static void loongson2_mmc_dll_mode_init(struct loongson2_mmc_host *host)
  {
-	u32 val, pad_delay, delay, ret;
+	u32 val, pad_delay, delay;
+	int ret;
 
  	regmap_update_bits(host->regmap, LOONGSON2_MMC_REG_SEL,
  			   LOONGSON2_MMC_SEL_DATA, LOONGSON2_MMC_SEL_DATA);

Thanks.
Binbin

#2 lore raw
In reply to Sergio Perez Gonzalez
Quoted 8 lines · Sergio Perez Gonzalez

In loongson2_mmc_dll_mode_init(), ret variable is declared as u32 but it is expected to hold an int value.

Fixes d0f8e961deae ("mc: loongson2: Add Loongson-2K2000 SD/SDIO/eMMC controller driver")

Applied for next, thanks!

Kind regards
Uffe

Quoted 21 lines
---
 drivers/mmc/host/loongson2-mmc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mmc/host/loongson2-mmc.c +2 -2
index 515ccf834f0a..ba6bb8fd5535 100644
@@ -485,7 +485,8 @@ static irqreturn_t loongson2_mmc_irq(int irq, void *devid)
 
 static void loongson2_mmc_dll_mode_init(struct loongson2_mmc_host *host)
 {
-       u32 val, pad_delay, delay, ret;
+       u32 val, pad_delay, delay;
+       int ret;
 
        regmap_update_bits(host->regmap, LOONGSON2_MMC_REG_SEL,
                           LOONGSON2_MMC_SEL_DATA, LOONGSON2_MMC_SEL_DATA);
--

2.43.0