mmc: loongson2: prevent integer overflow in ret variable
PATCH 1/1 mmc: loongson2: prevent integer overflow in ret variable
In loongson2_mmc_dll_mode_init(), ret variable is declared as u32 but it is expected to hold an int value.
Fixes d0f8e961deae ("mc: loongson2: Add Loongson-2K2000 SD/SDIO/eMMC controller driver")
Signed-off-by Sergio Perez Gonzalez <[email protected]>
--- drivers/mmc/host/loongson2-mmc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mmc/host/loongson2-mmc.c +2 -1
@@ -485,7 +485,8 @@ static irqreturn_t loongson2_mmc_irq(int irq, void *devid)static void loongson2_mmc_dll_mode_init (struct loongson2_mmc_host *host) { -u32 val, pad_delay, delay, ret; +u32 val, pad_delay, delay; +int ret;regmap_update_bits (host->regmap,LOONGSON2_MMC_REG_SEL ,LOONGSON2_MMC_SEL_DATA ,LOONGSON2_MMC_SEL_DATA );
Signature · 1 line
2.43.0
Hi Sergio:
Thanks for your patch.
Quoted 7 lines · Sergio Perez Gonzalez
In
loongson2_mmc_dll_mode_init(),retvariable is declared as u32 but it is expected to hold an int value.Fixes d0f8e961deae ("mc: loongson2: Add Loongson-2K2000 SD/SDIO/eMMC controller driver")Signed-off-by Sergio Perez Gonzalez <[email protected]>
Reviewed-by Binbin Zhou <[email protected]>
Quoted 9 lines
--- drivers/mmc/host/loongson2-mmc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/mmc/host/loongson2-mmc.c +0
-0
drivers/mmc/host/loongson2-mmc.c static irqreturn_t loongson2_mmc_irq(int irq, void *devid) · line 492
Quoted 9 lines
drivers/mmc/host/loongson2-mmc.c +2
-1@@ -485,7 +485,8 @@ static irqreturn_t loongson2_mmc_irq(int irq, void *devid)static void loongson2_mmc_dll_mode_init (struct loongson2_mmc_host *host) { -u32 val, pad_delay, delay, ret; +u32 val, pad_delay, delay; +int ret;regmap_update_bits (host->regmap,LOONGSON2_MMC_REG_SEL ,LOONGSON2_MMC_SEL_DATA ,LOONGSON2_MMC_SEL_DATA );
Thanks.
Binbin
Quoted 8 lines · Sergio Perez Gonzalez
In
loongson2_mmc_dll_mode_init(),retvariable is declared as u32 but it is expected to hold an int value.Fixes d0f8e961deae ("mc: loongson2: Add Loongson-2K2000 SD/SDIO/eMMC controller driver")Signed-off-by Sergio Perez Gonzalez <[email protected]>
Applied for next, thanks!
Kind regards
Uffe
Quoted 21 lines
--- drivers/mmc/host/loongson2-mmc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/mmc/host/loongson2-mmc.c +2
-2@@ -485,7 +485,8 @@ static irqreturn_t loongson2_mmc_irq(int irq, void *devid)static void loongson2_mmc_dll_mode_init (struct loongson2_mmc_host *host) { -u32 val, pad_delay, delay, ret; +u32 val, pad_delay, delay; +int ret;regmap_update_bits (host->regmap,LOONGSON2_MMC_REG_SEL ,LOONGSON2_MMC_SEL_DATA ,LOONGSON2_MMC_SEL_DATA ); --2.43.0