netfilter: nf_tables: hide clash bit from userspace
Subsystems (2)
Florian Westphal
maintainerPATCH 1/1 netfilter: nf_tables: hide clash bit from userspace
Its a kernel implementation detail, at least at this time:
We can later decide to revert this patch if there is a compelling reason, but then we should also remove the ifdef that prevents exposure of ip_conntrack_status enum IPS_NAT_CLASH value in the uapi header.
Clash entries are not included in dumps (true for both old /proc and ctnetlink) either. So for now exlude the clash bit when dumping.
--- net/netfilter/nf_tables_trace.c | 3 +++ 1 file changed, 3 insertions(+)
net/netfilter/nf_tables_trace.c +3 -0
@@ -127,6 +127,9 @@ static int nf_trace_fill_ct_info(struct sk_buff *nlskb,if (nla_put_be32 (nlskb,NFTA_TRACE_CT_ID , (__force __be32 )id))return -1 ; +/* Kernel implementation detail, withhold this from userspace for now */ + status &= ~IPS_NAT_CLASH ; +if (status &&nla_put_be32 (nlskb,NFTA_TRACE_CT_STATUS ,htonl (status)))return -1 ; }
Signature · 1 line
2.49.0
Quoted 8 lines · Florian Westphal
Its a kernel implementation detail, at least at this time:
We can later decide to revert this patch if there is a compelling reason, but then we should also remove the ifdef that prevents exposure of
ip_conntrack_statusenumIPS_NAT_CLASHvalue in the uapi header.Clash entries are not included in dumps (true for both old /proc and ctnetlink) either. So for now exlude the clash bit when dumping.
Applied to nf.git, thanks