target/s390x: Cleanups around s390_cpu_[un]halt()
cover target/s390x: Cleanups around s390_cpu_[un]halt()
Trivial cleanups around s390_cpu_[un]halt(), split of a bigger series which consolidates CPUClass::[un]halt() for re-use between accelerators.
Philippe Mathieu-Daudé (4):
target/s390x: Remove unused s390_cpu_[un]halt() user stubs target/s390x: Expose s390_count_running_cpus() method target/s390x: Have s390_cpu_halt() not return anything target/s390x: Extract system internal declarations to s390x-internal.h
target/s390x/s390x-internal.h | 231 +--------------------------------- target/s390x/s390x-system.h | 215 +++++++++++++++++++++++++++++++ target/s390x/cpu-system.c | 6 +- target/s390x/helper.c | 4 +- 4 files changed, 222 insertions(+), 234 deletions(-) create mode 100644 target/s390x/s390x-system.h
Signature · 1 line
2.49.0
PATCH 1/4 target/s390x: Remove unused s390_cpu_[un]halt() user stubs
Since commit da944885469 ("target/s390x: make helper.c sysemu-only") target/s390x/helper.c is only built for system mode, so s390_cpu_halt() and s390_cpu_unhalt() are never called from user mode.
--- target/s390x/s390x-internal.h | 10 ---------- 1 file changed, 10 deletions(-)
target/s390x/s390x-internal.h +0 -10
@@ -246,16 +246,6 @@ void s390_cpu_finalize(Object *obj);void s390_cpu_system_class_init (CPUClass *cc);void s390_cpu_machine_reset_cb (void *opaque);bool s390_cpu_has_work (CPUState *cs); - -#else -static inline unsigned int s390_cpu_halt (S390CPU *cpu) -{ -return 0 ; -} - -static inline void s390_cpu_unhalt (S390CPU *cpu) -{ -}#endif /* CONFIG_USER_ONLY */
Signature · 1 line
2.49.0
Re: [PATCH 1/4] target/s390x: Remove unused s390_cpu_[un]halt() user stubs
Quoted 10 lines · Philippe Mathieu-Daudé
Since commit
da944885469("target/s390x: makehelper.csysemu-only")target/s390x/helper.cis only built for system mode, sos390_cpu_halt()ands390_cpu_unhalt()are never called from user mode.Fixes da944885469 ("target/s390x: make helper.c sysemu-only")Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- target/s390x/s390x-internal.h | 10 ---------- 1 file changed, 10 deletions(-)
There is another call to s390_cpu_unhalt() in target/s390x/tcg/excp_helper.c but it is protected by an #ifdef ... so this should be fine.
PATCH 2/4 target/s390x: Expose s390_count_running_cpus() method
In reply to Philippe Mathieu-DaudéIn order to simplify the next commit where s390_count_running_cpus() is split out of s390_cpu_halt(), make its prototype public as a preliminary step.
--- target/s390x/s390x-internal.h | 1 + target/s390x/cpu-system.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)
target/s390x/s390x-internal.h +1 -0
@@ -238,6 +238,7 @@ uint32_t calc_cc(CPUS390XState *env, uint32_t cc_op, uint64_t src, uint64_t dst,/* cpu.c */ #ifndef CONFIG_USER_ONLY +unsigned int s390_count_running_cpus (void );unsigned int s390_cpu_halt (S390CPU *cpu);void s390_cpu_unhalt (S390CPU *cpu);void s390_cpu_system_init (Object *obj);
target/s390x/cpu-system.c +1 -1
@@ -196,7 +196,7 @@ static bool disabled_wait(CPUState *cpu) (PSW_MASK_IO | PSW_MASK_EXT | PSW_MASK_MCHECK)); } -static unsigned s390_count_running_cpus (void ) +unsigned s390_count_running_cpus (void ) {CPUState *cpu;int nr_running =0 ;
Signature · 1 line
2.49.0
Re: [PATCH 2/4] target/s390x: Expose s390_count_running_cpus() method
Quoted 9 lines · Philippe Mathieu-Daudé
In order to simplify the next commit where
s390_count_running_cpus()is split out ofs390_cpu_halt(), make its prototype public as a preliminary step.Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- target/s390x/s390x-internal.h | 1 + target/s390x/cpu-system.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)
PATCH 3/4 target/s390x: Have s390_cpu_halt() not return anything
In reply to Philippe Mathieu-DaudéSince halting a vCPU and how many left running do not need to be tied together, split the s390_count_running_cpus() call out of s390_cpu_halt() to the single caller using it:s390_handle_wait().
--- target/s390x/s390x-internal.h | 2 +- target/s390x/cpu-system.c | 4 +--- target/s390x/helper.c | 4 +++- 3 files changed, 5 insertions(+), 5 deletions(-)
target/s390x/s390x-internal.h +1 -1
@@ -239,7 +239,7 @@ uint32_t calc_cc(CPUS390XState *env, uint32_t cc_op, uint64_t src, uint64_t dst,/* cpu.c */ #ifndef CONFIG_USER_ONLY unsigned int s390_count_running_cpus (void ); -unsigned int s390_cpu_halt (S390CPU *cpu); +void s390_cpu_halt (S390CPU *cpu);void s390_cpu_unhalt (S390CPU *cpu);void s390_cpu_system_init (Object *obj);bool s390_cpu_system_realize (DeviceState *dev,Error **errp);
target/s390x/cpu-system.c +1 -3
@@ -214,7 +214,7 @@ unsigned s390_count_running_cpus(void)return nr_running; } -unsigned int s390_cpu_halt (S390CPU *cpu) +void s390_cpu_halt (S390CPU *cpu) {CPUState *cs =CPU (cpu);trace_cpu_halt (cs->cpu_index);
@@ -223,8 +223,6 @@ unsigned int s390_cpu_halt(S390CPU *cpu) cs->halted =1 ; cs->exception_index =EXCP_HLT ; } - -return s390_count_running_cpus (); }void s390_cpu_unhalt (S390CPU *cpu)
target/s390x/helper.c +3 -1
@@ -91,7 +91,9 @@ void s390_handle_wait(S390CPU *cpu) {CPUState *cs =CPU (cpu); -if (s390_cpu_halt (cpu) ==0 ) { +s390_cpu_halt (cpu); + +if (s390_count_running_cpus () ==0 ) {if (is_special_wait_psw (cpu->env.psw.addr)) {qemu_system_shutdown_request (SHUTDOWN_CAUSE_GUEST_SHUTDOWN ); }else {
Signature · 1 line
2.49.0
Re: [PATCH 3/4] target/s390x: Have s390_cpu_halt() not return anything
Quoted 11 lines · Philippe Mathieu-Daudé
Since halting a vCPU and how many left running do not need to be tied together, split the
s390_count_running_cpus()call out ofs390_cpu_halt()to the single caller using it:s390_handle_wait().Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- target/s390x/s390x-internal.h | 2 +- target/s390x/cpu-system.c | 4 +--- target/s390x/helper.c | 4 +++- 3 files changed, 5 insertions(+), 5 deletions(-)
PATCH 4/4 target/s390x: Extract system internal declarations to s390x-internal.h
In reply to Philippe Mathieu-DaudéSimplify a bit the big "s390x-internal.h" header by extracting system-specific declarations to "s390x-system.h".
--- target/s390x/s390x-internal.h | 222 +--------------------------------- target/s390x/s390x-system.h | 215 ++++++++++++++++++++++++++++++++ 2 files changed, 217 insertions(+), 220 deletions(-) create mode 100644 target/s390x/s390x-system.h
target/s390x/s390x-internal.h +2 -220
@@ -14,89 +14,8 @@#include "fpu/softfloat.h" #ifndef CONFIG_USER_ONLY -typedef struct LowCore { -/* prefix area: defined by architecture */ -uint32_t ccw1[2 ];/* 0x000 */ -uint32_t ccw2[4 ];/* 0x008 */ -uint8_t pad1[0x80 -0x18 ];/* 0x018 */ -uint32_t ext_params;/* 0x080 */ -uint16_t cpu_addr;/* 0x084 */ -uint16_t ext_int_code;/* 0x086 */ -uint16_t svc_ilen;/* 0x088 */ -uint16_t svc_code;/* 0x08a */ -uint16_t pgm_ilen;/* 0x08c */ -uint16_t pgm_code;/* 0x08e */ -uint32_t data_exc_code;/* 0x090 */ -uint16_t mon_class_num;/* 0x094 */ -uint16_t per_perc_atmid;/* 0x096 */ -uint64_t per_address;/* 0x098 */ -uint8_t exc_access_id;/* 0x0a0 */ -uint8_t per_access_id;/* 0x0a1 */ -uint8_t op_access_id;/* 0x0a2 */ -uint8_t ar_access_id;/* 0x0a3 */ -uint8_t pad2[0xA8 -0xA4 ];/* 0x0a4 */ -uint64_t trans_exc_code;/* 0x0a8 */ -uint64_t monitor_code;/* 0x0b0 */ -uint16_t subchannel_id;/* 0x0b8 */ -uint16_t subchannel_nr;/* 0x0ba */ -uint32_t io_int_parm;/* 0x0bc */ -uint32_t io_int_word;/* 0x0c0 */ -uint8_t pad3[0xc8 -0xc4 ];/* 0x0c4 */ -uint32_t stfl_fac_list;/* 0x0c8 */ -uint8_t pad4[0xe8 -0xcc ];/* 0x0cc */ -uint64_t mcic;/* 0x0e8 */ -uint8_t pad5[0xf4 -0xf0 ];/* 0x0f0 */ -uint32_t external_damage_code;/* 0x0f4 */ -uint64_t failing_storage_address;/* 0x0f8 */ -uint8_t pad6[0x110 -0x100 ];/* 0x100 */ -uint64_t per_breaking_event_addr;/* 0x110 */ -uint8_t pad7[0x120 -0x118 ];/* 0x118 */ -PSW restart_old_psw;/* 0x120 */ -PSW external_old_psw;/* 0x130 */ -PSW svc_old_psw;/* 0x140 */ -PSW program_old_psw;/* 0x150 */ -PSW mcck_old_psw;/* 0x160 */ -PSW io_old_psw;/* 0x170 */ -uint8_t pad8[0x1a0 -0x180 ];/* 0x180 */ -PSW restart_new_psw;/* 0x1a0 */ -PSW external_new_psw;/* 0x1b0 */ -PSW svc_new_psw;/* 0x1c0 */ -PSW program_new_psw;/* 0x1d0 */ -PSW mcck_new_psw;/* 0x1e0 */ -PSW io_new_psw;/* 0x1f0 */ -uint8_t pad13[0x11b0 -0x200 ];/* 0x200 */ - -uint64_t mcesad;/* 0x11B0 */ - -/* 64 bit extparam used for pfault, diag 250 etc */ -uint64_t ext_params2;/* 0x11B8 */ - -uint8_t pad14[0x1200 -0x11C0 ];/* 0x11C0 */ - -/* System info area */ - -uint64_t floating_pt_save_area[16 ];/* 0x1200 */ -uint64_t gpregs_save_area[16 ];/* 0x1280 */ -uint32_t st_status_fixed_logout[4 ];/* 0x1300 */ -uint8_t pad15[0x1318 -0x1310 ];/* 0x1310 */ -uint32_t prefixreg_save_area;/* 0x1318 */ -uint32_t fpt_creg_save_area;/* 0x131c */ -uint8_t pad16[0x1324 -0x1320 ];/* 0x1320 */ -uint32_t tod_progreg_save_area;/* 0x1324 */ -uint64_t cpu_timer_save_area;/* 0x1328 */ -uint64_t clock_comp_save_area;/* 0x1330 */ -uint8_t pad17[0x1340 -0x1338 ];/* 0x1338 */ -uint32_t access_regs_save_area[16 ];/* 0x1340 */ -uint64_t cregs_save_area[16 ];/* 0x1380 */ - -/* align to the top of the prefix area */ - -uint8_t pad18[0x2000 -0x1400 ];/* 0x1400 */ -} QEMU_PACKED LowCore; -QEMU_BUILD_BUG_ON (sizeof (LowCore) !=8192 ); -#endif /* CONFIG_USER_ONLY */ - -#define MAX_ILEN 6 +#include "s390x-system.h" +#endif /* While the PoO talks about ILC (a number between 1-3) what is actually stored in LowCore is shifted left one bit (an even between 2-6). As
@@ -116,18 +35,6 @@ static inline int get_ilen(uint8_t opc) } } -/* Compute the ATMID field that is stored in the per_perc_atmid lowcore -entry when a PER exception is triggered. */ -static inline uint8_t get_per_atmid (CPUS390XState *env) -{ -return ((env->psw.mask &PSW_MASK_64 ) ? (1 <<7 ) :0 ) | - (1 <<6 ) | - ((env->psw.mask &PSW_MASK_32 ) ? (1 <<5 ) :0 ) | - ((env->psw.mask &PSW_MASK_DAT ) ? (1 <<4 ) :0 ) | - ((env->psw.mask &PSW_ASC_SECONDARY ) ? (1 <<3 ) :0 ) | - ((env->psw.mask &PSW_ASC_ACCREG ) ? (1 <<2 ) :0 ); -} -static inline uint64_t wrap_address (CPUS390XState *env,uint64_t a) {if (!(env->psw.mask &PSW_MASK_64 )) {
@@ -201,55 +108,11 @@ enum cc_op { CC_OP_MAX }; -#ifndef CONFIG_USER_ONLY - -static inline hwaddr decode_basedisp_s (CPUS390XState *env,uint32_t ipb, -uint8_t *ar) -{ -hwaddr addr =0 ; -uint8_t reg; - - reg = ipb >>28 ; -if (reg >0 ) { - addr = env->regs[reg]; - } - addr += (ipb >>16 ) &0xfff ; -if (ar) { - *ar = reg; - } - -return addr; -} - -/* Base/displacement are at the same locations. */ -#define decode_basedisp_rs decode_basedisp_s - -#endif /* CONFIG_USER_ONLY */ - -/* arch_dump.c */ -int s390_cpu_write_elf64_note (WriteCoreDumpFunction f,CPUState *cs, -int cpuid,DumpState *s); - -/* cc_helper.c */ const char *cc_name (enum cc_op cc_op);uint32_t calc_cc (CPUS390XState *env,uint32_t cc_op,uint64_t src,uint64_t dst,uint64_t vr); -/* cpu.c */ -#ifndef CONFIG_USER_ONLY -unsigned int s390_count_running_cpus (void ); -void s390_cpu_halt (S390CPU *cpu); -void s390_cpu_unhalt (S390CPU *cpu); -void s390_cpu_system_init (Object *obj); -bool s390_cpu_system_realize (DeviceState *dev,Error **errp); -void s390_cpu_finalize (Object *obj); -void s390_cpu_system_class_init (CPUClass *cc); -void s390_cpu_machine_reset_cb (void *opaque); -bool s390_cpu_has_work (CPUState *cs); -#endif /* CONFIG_USER_ONLY */ - -/* cpu_models.c */ void s390_cpu_model_class_register_props (ObjectClass *oc);void s390_realize_cpu_model (CPUState *cs,Error **errp);
@@ -257,11 +120,7 @@ S390CPUModel *get_max_cpu_model(Error **errp);void apply_cpu_model (const S390CPUModel *model,Error **errp);ObjectClass *s390_cpu_class_by_name (const char *name); - -/* excp_helper.c */ -void s390x_cpu_debug_excp_handler (CPUState *cs);void s390_cpu_do_interrupt (CPUState *cpu); -bool s390_cpu_exec_interrupt (CPUState *cpu,int int_req);#ifdef CONFIG_USER_ONLY void s390_cpu_record_sigsegv(CPUState *cs, vaddr address,
@@ -312,87 +171,14 @@ int s390_cpu_gdb_read_register(CPUState *cpu, GByteArray *buf, int reg);int s390_cpu_gdb_write_register (CPUState *cpu,uint8_t *buf,int reg);void s390_cpu_gdb_init (CPUState *cs); - -/* helper.c */ void s390_cpu_dump_state (CPUState *cpu,FILE *f,int flags); -void do_restart_interrupt (CPUS390XState *env); -#ifndef CONFIG_USER_ONLY -void s390_cpu_recompute_watchpoints (CPUState *cs); -void s390x_tod_timer (void *opaque); -void s390x_cpu_timer (void *opaque); -void s390_handle_wait (S390CPU *cpu); -hwaddr s390_cpu_get_phys_page_debug (CPUState *cpu,vaddr addr); -hwaddr s390_cpu_get_phys_addr_debug (CPUState *cpu,vaddr addr); -#define S390_STORE_STATUS_DEF_ADDR offsetof(LowCore, floating_pt_save_area) -int s390_store_status (S390CPU *cpu,hwaddr addr,bool store_arch); -int s390_store_adtl_status (S390CPU *cpu,hwaddr addr,hwaddr len); -LowCore *cpu_map_lowcore (CPUS390XState *env); -void cpu_unmap_lowcore (LowCore *lowcore); -#endif /* CONFIG_USER_ONLY */ -/* interrupt.c */ void trigger_pgm_exception (CPUS390XState *env,uint32_t code); -#ifndef CONFIG_USER_ONLY -void cpu_inject_clock_comparator (S390CPU *cpu); -void cpu_inject_cpu_timer (S390CPU *cpu); -void cpu_inject_emergency_signal (S390CPU *cpu,uint16_t src_cpu_addr); -int cpu_inject_external_call (S390CPU *cpu,uint16_t src_cpu_addr); -bool s390_cpu_has_io_int (S390CPU *cpu); -bool s390_cpu_has_ext_int (S390CPU *cpu); -bool s390_cpu_has_mcck_int (S390CPU *cpu); -bool s390_cpu_has_int (S390CPU *cpu); -bool s390_cpu_has_restart_int (S390CPU *cpu); -bool s390_cpu_has_stop_int (S390CPU *cpu); -void cpu_inject_restart (S390CPU *cpu); -void cpu_inject_stop (S390CPU *cpu); -#endif /* CONFIG_USER_ONLY */ - -/* ioinst.c */ -#ifndef CONFIG_USER_ONLY -void ioinst_handle_xsch (S390CPU *cpu,uint64_t reg1,uintptr_t ra); -void ioinst_handle_csch (S390CPU *cpu,uint64_t reg1,uintptr_t ra); -void ioinst_handle_hsch (S390CPU *cpu,uint64_t reg1,uintptr_t ra); -void ioinst_handle_msch (S390CPU *cpu,uint64_t reg1,uint32_t ipb, -uintptr_t ra); -void ioinst_handle_ssch (S390CPU *cpu,uint64_t reg1,uint32_t ipb, -uintptr_t ra); -void ioinst_handle_stcrw (S390CPU *cpu,uint32_t ipb,uintptr_t ra); -void ioinst_handle_stsch (S390CPU *cpu,uint64_t reg1,uint32_t ipb, -uintptr_t ra); -int ioinst_handle_tsch (S390CPU *cpu,uint64_t reg1,uint32_t ipb,uintptr_t ra); -void ioinst_handle_chsc (S390CPU *cpu,uint32_t ipb,uintptr_t ra); -void ioinst_handle_schm (S390CPU *cpu,uint64_t reg1,uint64_t reg2, -uint32_t ipb,uintptr_t ra); -void ioinst_handle_rsch (S390CPU *cpu,uint64_t reg1,uintptr_t ra); -void ioinst_handle_rchp (S390CPU *cpu,uint64_t reg1,uintptr_t ra); -void ioinst_handle_sal (S390CPU *cpu,uint64_t reg1,uintptr_t ra); -#endif /* CONFIG_USER_ONLY */ - - -/* mem_helper.c */ -target_ulong mmu_real2abs (CPUS390XState *env,target_ulong raddr);void probe_write_access (CPUS390XState *env,uint64_t addr,uint64_t len,uintptr_t ra); - -/* mmu_helper.c */ -bool mmu_absolute_addr_valid (target_ulong addr,bool is_write); -/* Special access mode only valid for mmu_translate() */ -#define MMU_S390_LRA -1 -int mmu_translate (CPUS390XState *env,target_ulong vaddr,int rw,uint64_t asc, -target_ulong *raddr,int *flags,uint64_t *tec); -int mmu_translate_real (CPUS390XState *env,target_ulong raddr,int rw, -target_ulong *addr,int *flags,uint64_t *tec); - - -/* misc_helper.c */ -int handle_diag_288 (CPUS390XState *env,uint64_t r1,uint64_t r3); -void handle_diag_308 (CPUS390XState *env,uint64_t r1,uint64_t r3, -uintptr_t ra); - -/* translate.c */ void s390x_translate_init (void ); void s390x_translate_code(CPUState *cs, TranslationBlock *tb,
@@ -401,8 +187,4 @@ void s390x_restore_state_to_opc(CPUState *cs,const TranslationBlock *tb, const uint64_t *data); -/* sigp.c */ -int handle_sigp (CPUS390XState *env,uint8_t order,uint64_t r1,uint64_t r3); -void do_stop_interrupt (CPUS390XState *env); -#endif /* S390X_INTERNAL_H */
target/s390x/s390x-system.h new file +215 -0
215 lines not on this page · raw message
Signature · 1 line
2.49.0
Re: [PATCH 4/4] target/s390x: Extract system internal declarations to s390x-internal.h
Quoted 14 lines · Philippe Mathieu-Daudé
Simplify a bit the big "
s390x-internal.h" header by extracting system-specific declarations to "s390x-system.h".Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- target/s390x/s390x-internal.h | 222 +--------------------------------- target/s390x/s390x-system.h | 215 ++++++++++++++++++++++++++++++++ 2 files changed, 217 insertions(+), 220 deletions(-)create mode 100644
target/s390x/s390x-system.htarget/s390x/s390x-internal.h +0
-0
...
target/s390x/s390x-internal.h S390CPUModel *get_max_cpu_model(Error **errp); · line 261
Quoted 6 lines
target/s390x/s390x-internal.h +0
-2@@ -257,11 +120,7 @@ S390CPUModel *get_max_cpu_model(Error **errp);void apply_cpu_model (const S390CPUModel *model,Error **errp);ObjectClass *s390_cpu_class_by_name (const char *name); - -/* excp_helper.c */
Please don't remove the excp_helper.c comment here, otherwise the s390_cpu_do_interrupt() below belongs to the wrong section here.
target/s390x/s390x-internal.h int s390_cpu_gdb_read_register(CPUState *cpu, GByteArray *buf, int reg); · line 174
Quoted 13 lines
target/s390x/s390x-internal.h +0
-4-void s390x_cpu_debug_excp_handler (CPUState *cs);void s390_cpu_do_interrupt (CPUState *cpu); -bool s390_cpu_exec_interrupt (CPUState *cpu,int int_req);#ifdef CONFIG_USER_ONLY void s390_cpu_record_sigsegv(CPUState *cs, vaddr address,@@ -312,87 +171,14 @@ int s390_cpu_gdb_read_register(CPUState *cpu, GByteArray *buf, int reg);int s390_cpu_gdb_write_register (CPUState *cpu,uint8_t *buf,int reg);void s390_cpu_gdb_init (CPUState *cs); - -/* helper.c */ void s390_cpu_dump_state (CPUState *cpu,FILE *f,int flags);
s390_cpu_dump_state() should get a new comment in front of it:
/* cpu-dump.c */
Quoted 14 lines
target/s390x/s390x-internal.h +0
-14-void do_restart_interrupt (CPUS390XState *env); -#ifndef CONFIG_USER_ONLY -void s390_cpu_recompute_watchpoints (CPUState *cs); -void s390x_tod_timer (void *opaque); -void s390x_cpu_timer (void *opaque); -void s390_handle_wait (S390CPU *cpu); -hwaddr s390_cpu_get_phys_page_debug (CPUState *cpu,vaddr addr); -hwaddr s390_cpu_get_phys_addr_debug (CPUState *cpu,vaddr addr); -#define S390_STORE_STATUS_DEF_ADDR offsetof(LowCore, floating_pt_save_area) -int s390_store_status (S390CPU *cpu,hwaddr addr,bool store_arch); -int s390_store_adtl_status (S390CPU *cpu,hwaddr addr,hwaddr len); -LowCore *cpu_map_lowcore (CPUS390XState *env); -void cpu_unmap_lowcore (LowCore *lowcore); -#endif /* CONFIG_USER_ONLY */
...
Quoted 6 lines
target/s390x/s390x-system.h new file +0
-0
target/s390x/s390x-system.h line 8
Quoted 8 lines
target/s390x/s390x-system.h new file +8
-0@@ -0,0 +1,215 @@ +/* +* s390x system internal definitions and helpers +* +* Copyright (c) 2009 Ulrich Hecht +* +* This work is licensed under the terms of the GNU GPL, version 2 or later. +* See the COPYING file in the top-level directory. +*/
Can you please add a proper SPDX license identifier to new files?
Thanks,
Thomas
Quoted 10 lines · Philippe Mathieu-Daudé
Trivial cleanups around s390_cpu_[un]halt(), split of a bigger series which consolidates CPUClass::[un]halt() for re-use between accelerators.
Philippe Mathieu-Daudé (4):
target/s390x: Remove unused s390_cpu_[un]halt() user stubs target/s390x: Expose s390_count_running_cpus() method target/s390x: Have s390_cpu_halt() not return anything target/s390x: Extract system internal declarations to s390x-internal.h
Quoted 6 lines
target/s390x/s390x-internal.h | 231 +--------------------------------- target/s390x/s390x-system.h | 215 +++++++++++++++++++++++++++++++ target/s390x/cpu-system.c | 6 +- target/s390x/helper.c | 4 +- 4 files changed, 222 insertions(+), 234 deletions(-)create mode 100644
target/s390x/s390x-system.h
Thanks, I'll queue 1-3 for my next pull request. Patch 4 needs some modifications.
Thomas
David Hildenbrand
Reviewed-byQuoted 11 lines · Thomas Huth
Quoted 10 lines · Philippe Mathieu-Daudé
Trivial cleanups around s390_cpu_[un]halt(), split of a bigger series which consolidates CPUClass::[un]halt() for re-use between accelerators.
Philippe Mathieu-Daudé (4):
target/s390x: Remove unused s390_cpu_[un]halt() user stubs target/s390x: Expose s390_count_running_cpus() method target/s390x: Have s390_cpu_halt() not return anything target/s390x: Extract system internal declarations to s390x-internal.h
Quoted 8 lines
Quoted 6 lines
target/s390x/s390x-internal.h | 231 +--------------------------------- target/s390x/s390x-system.h | 215 +++++++++++++++++++++++++++++++ target/s390x/cpu-system.c | 6 +- target/s390x/helper.c | 4 +- 4 files changed, 222 insertions(+), 234 deletions(-)create mode 100644
target/s390x/s390x-system.hThanks, I'll queue 1-3 for my next pull request.
For these 3:
Signature · 3 lines
Cheers, David / dhildenb