Skip to contentSkip to conversation

package/sudo: fix SUDO_ENABLE_SUDO_GROUP_RULE following version bump

PATCH Applied Marcus Hoffmann via buildroot 1 participant 4 messages Jul 8, 2025 – Jul 17, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/sudo: fix SUDO_ENABLE_SUDO_GROUP_RULE following version bump

From: Marcus Hoffmann <[email protected]>

Since the version bump of sudo to 1.9.17p1 [1], the sed command in SUDO_ENABLE_SUDO_GROUP_RULE no longer matches the the line in the example sudoers file shipped with the sudo package.

This commit fixes the regexp to match the new sudoers file.

[1] ee86844e632d5760355154ea4e928c9228f3dfd1

---
 package/sudo/sudo.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/sudo/sudo.mk +1 -1
index 4e1405eaf1..f57a86805a 100644
@@ -73,7 +73,7 @@ define SUDO_USERS
 endef
 
 define SUDO_ENABLE_SUDO_GROUP_RULE
-	$(SED) '/^# \%sudo\tALL=(ALL:ALL) ALL/s/^# //' $(TARGET_DIR)/etc/sudoers
+	$(SED) '/^# \%sudo ALL=(ALL:ALL) ALL/s/^# //' $(TARGET_DIR)/etc/sudoers
 endef
 SUDO_POST_INSTALL_TARGET_HOOKS += SUDO_ENABLE_SUDO_GROUP_RULE
 
Signature · 6 lines
2.43.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 11 lines · Marcus Hoffmann via buildroot

From: Marcus Hoffmann <[email protected]>

Since the version bump of sudo to 1.9.17p1 [1], the sed command in SUDO_ENABLE_SUDO_GROUP_RULE no longer matches the the line in the example sudoers file shipped with the sudo package.

This commit fixes the regexp to match the new sudoers file.

[1] ee86844e632d5760355154ea4e928c9228f3dfd1

Applied to master, thanks.

For info, I added a link to the upstream commit introducing the issue. See:
https://gitlab.com/buildroot.org/buildroot/-/commit/35708db02403b5066d4efc455e802c666ed01dc9

Best regards,

Julien.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#2 lore raw

Hi Julien

Quoted 1 line · Julien Olivain

On 08/07/2025 15:14, Marcus Hoffmann via buildroot wrote:

[...]

Quoted 6 lines

Applied to master, thanks.

For info, I added a link to the upstream commit introducing
the issue. See:
https://gitlab.com/buildroot.org/buildroot/-/ commit/35708db02403b5066d4efc455e802c666ed01dc9

Thanks for digging that up. I actually couldn't find this quickly yesterday and then was in a bit of a hurry and gave up. :)

Quoted 4 lines

Best regards,

Julien.

Best,
Marcus

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#3 lore raw
In reply to Marcus Hoffmann via buildroot
Quoted 11 lines · Marcus Hoffmann via buildroot

From: Marcus Hoffmann <[email protected]>

Since the version bump of sudo to 1.9.17p1 [1], the sed command in SUDO_ENABLE_SUDO_GROUP_RULE no longer matches the the line in the example sudoers file shipped with the sudo package.

This commit fixes the regexp to match the new sudoers file.

[1] ee86844e632d5760355154ea4e928c9228f3dfd1

Applied to 2025.02.x and 2025.05.x, thanks.

Regards,
Arnout

Quoted 9 lines
---
  package/sudo/sudo.mk | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
package/sudo/sudo.mk +0 -0
index 4e1405eaf1..f57a86805a 100644

package/sudo/sudo.mk define SUDO_USERS · line 79

Quoted 8 lines
package/sudo/sudo.mk +1 -1
@@ -73,7 +73,7 @@ define SUDO_USERS
  endef
 
  define SUDO_ENABLE_SUDO_GROUP_RULE
-	$(SED) '/^# \%sudo\tALL=(ALL:ALL) ALL/s/^# //' $(TARGET_DIR)/etc/sudoers
+	$(SED) '/^# \%sudo ALL=(ALL:ALL) ALL/s/^# //' $(TARGET_DIR)/etc/sudoers
  endef
  SUDO_POST_INSTALL_TARGET_HOOKS += SUDO_ENABLE_SUDO_GROUP_RULE
 

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot