media: i2c: Kconfig: Select COMMON_CLK for ACPI-based systems
PATCH 1/1 media: i2c: Kconfig: Select COMMON_CLK for ACPI-based systems
ACPI-based systems are required to create and register a fixed rate clock using the new v4l2 helper devm_v4l2_sensor_clk_get() that uses the common clk framework.
Ensure that COMMON_CLK is selected.
--- drivers/media/i2c/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/media/i2c/Kconfig +1 -0
@@ -31,6 +31,7 @@ menuconfig VIDEO_CAMERA_SENSOR select MEDIA_CONTROLLER select V4L2_FWNODE select VIDEO_V4L2_SUBDEV_API + select COMMON_CLK if ACPI && !HAVE_LEGACY_CLK default y if VIDEO_CAMERA_SENSOR
Signature · 1 line
2.49.0
Quoted 7 lines · Mehdi Djait
ACPI-based systems are required to create and register a fixed rate clock using the new v4l2 helper
devm_v4l2_sensor_clk_get()that uses the common clk framework.Ensure that
COMMON_CLKis selected.Signed-off-by Mehdi Djait <[email protected]>
You should never 'select' another subsystem or a drvier from an unrelated subsystem.
What you want here instead is 'depends on COMMON_CLK'.
Arnd
Hello Arnd,
Thank you for the review.
Quoted 5 lines · Arnd Bergmann
Quoted 4 lines · Mehdi Djait
ACPI-based systems are required to create and register a fixed rate clock using the new v4l2 helper
devm_v4l2_sensor_clk_get()that uses the common clk framework.
Quoted 8 lines
Quoted 3 lines
Ensure that
COMMON_CLKis selected.Signed-off-by Mehdi Djait <[email protected]>You should never 'select' another subsystem or a drvier from an unrelated subsystem.
What you want here instead is 'depends on
COMMON_CLK'.
Ack.
I will change this in the v2.
--
Kind Regards
Mehdi Djait