Skip to contentSkip to conversation

ecryptfs: use sysfs_emit() in version_show()

PATCH New Utkarsh Singh 1 participant 1 message Jul 8, 2025 Ecrypt file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ecryptfs: use sysfs_emit() in version_show()

The sysfs_emit() helper is the preferred way to format sysfs attribute output buffers. It provides consistent behavior and prevents potential buffer overflows.

This patch replaces the use of snprintf() with sysfs_emit() in the version_show() function.

---
 fs/ecryptfs/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/ecryptfs/main.c +1 -1
index 8dd1d7189c3b..49b8024d6c64 100644
@@ -764,7 +764,7 @@ static struct kobject *ecryptfs_kobj;
 static ssize_t version_show(struct kobject *kobj,
 			    struct kobj_attribute *attr, char *buff)
 {
-	return snprintf(buff, PAGE_SIZE, "%d\n", ECRYPTFS_VERSIONING_MASK);
+	return sysfs_emit(buff, "%d\n", ECRYPTFS_VERSIONING_MASK);
 }
 
 static struct kobj_attribute version_attr = __ATTR_RO(version);
Signature · 1 line
2.34.1