Skip to contentSkip to conversation

tools: bootconfig: Regex enclosed with quotes to make syntax highlight proper

PATCH In review Bhaskar Chowdhury 2 participants 2 messages Jul 9, 2025 – Jul 14, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 tools: bootconfig: Regex enclosed with quotes to make syntax highlight proper

As suggested, changed the square brackets escaping to quote the whole Regex class.

---
Changes to V2 from V1:
Surround the Regex class with single quotations.

 tools/bootconfig/test-bootconfig.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/bootconfig/test-bootconfig.sh +2 -2
index a2c484c243f5..32401bf61340 100755
@@ -167,8 +167,8 @@ echo > $INITRD
 
 xpass $BOOTCONF -a $TEMPCONF $INITRD
 $BOOTCONF $INITRD > $OUTFILE
-xfail grep -q val[[:space:]] $OUTFILE
-xpass grep -q val2[[:space:]] $OUTFILE
+xfail grep -q 'val[[:space:]]' $OUTFILE
+xpass grep -q 'val2[[:space:]]' $OUTFILE
 
 echo "=== expected failure cases ==="
 for i in samples/bad-* ; do

--
2.49.1

#1 lore raw
Quoted 3 lines · On Wed, 9 Jul 2025 08:27:59 +0530 Bhaskar Chowdhury <[email protected]>…

As suggested, changed the square brackets escaping to quote the whole Regex class.

Yeah, let me pick it.

Thanks,

Quoted 26 lines

---
Changes to V2 from V1:
Surround the Regex class with single quotations.

 tools/bootconfig/test-bootconfig.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/bootconfig/test-bootconfig.sh +2 -3
index a2c484c243f5..32401bf61340 100755
@@ -167,8 +167,8 @@ echo > $INITRD
 
 xpass $BOOTCONF -a $TEMPCONF $INITRD
 $BOOTCONF $INITRD > $OUTFILE
-xfail grep -q val[[:space:]] $OUTFILE
-xpass grep -q val2[[:space:]] $OUTFILE
+xfail grep -q 'val[[:space:]]' $OUTFILE
+xpass grep -q 'val2[[:space:]]' $OUTFILE
 
 echo "=== expected failure cases ==="
 for i in samples/bad-* ; do
--

2.49.1

Signature · 1 line
Masami Hiramatsu (Google) <[email protected]>