staging: nvec: silence macro argument warnings in NVEC_PHD()
Subsystems (3)
PATCH 1/1 staging: nvec: silence macro argument warnings in NVEC_PHD()
checkpatch.pl warns that the NVEC_PHD macro defines unused arguments. Use (void) casts to prevent unused argument warnings when the macro is disabled.
Signed-off-by Emre Cecanpunar <[email protected]>
--- drivers/staging/nvec/nvec_ps2.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/staging/nvec/nvec_ps2.c +5 -1
@@ -28,7 +28,11 @@print_hex_dump (KERN_DEBUG , str,DUMP_PREFIX_NONE , \ 16, 1, buf, len, false)#else -#define NVEC_PHD (str, buf, len) do { } while (0) +#define NVEC_PHD (str, buf, len) do { \ + (void)(str); \ + (void)(buf); \ + (void)(len); \ +} while (0)#endif enum ps2_subcmds {
Signature · 1 line
2.50.0
Greg KH
maintainerQuoted 13 lines · Emre Cecanpunar
checkpatch.pl warns that the
NVEC_PHDmacro defines unused arguments. Use (void) casts to prevent unused argument warnings when the macro is disabled.Signed-off-by Emre Cecanpunar <[email protected]>--- drivers/staging/nvec/nvec_ps2.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)drivers/staging/nvec/nvec_ps2.c +0
-0
drivers/staging/nvec/nvec_ps2.c line 35
Quoted 9 lines
drivers/staging/nvec/nvec_ps2.c +5
-1@@ -28,7 +28,11 @@print_hex_dump (KERN_DEBUG , str,DUMP_PREFIX_NONE , \ 16, 1, buf, len, false)#else -#define NVEC_PHD (str, buf, len) do { } while (0) +#define NVEC_PHD (str, buf, len) do { \ + (void)(str); \ + (void)(buf); \ + (void)(len); \ +} while (0)
This is really not needed at all, sorry. Especially for a define that will never even be used. Can you work to remove NVEC_PS2_DEBUG instead, as that's not a good idea.
thanks,
greg k-h