Skip to contentSkip to conversation

s390/sclp_tty: Use macros for hardcoded values

PATCH New Xose Vazquez Perez 1 participant 1 message Jul 9, 2025 s390

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 s390/sclp_tty: Use macros for hardcoded values

Similar as in sclp_vt220

Cc Heiko Carstens <[email protected]> (maintainer:S390 ARCHITECTURE,commit_signer:1/2=50%)
Cc Vasily Gorbik <[email protected]> (maintainer:S390 ARCHITECTURE)
Cc Alexander Gordeev <[email protected]> (maintainer:S390 ARCHITECTURE)
Cc Christian Borntraeger <[email protected]> (reviewer:S390 ARCHITECTURE)
Cc Sven Schnelle <[email protected]> (reviewer:S390 ARCHITECTURE,commit_signer:1/2=50%)
Cc S390 ML <[email protected]> (open list:S390 ARCHITECTURE)

---
Trivial, but uncompiled!!

---
 drivers/s390/char/sclp_tty.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)
drivers/s390/char/sclp_tty.c +9 -4
index 0a92d08830e7..4e06dc70534c 100644
@@ -23,6 +23,11 @@
 #include "sclp_rw.h"
 #include "sclp_tty.h"
 
+#define SCLP_TTY_MAJOR		TTY_MAJOR
+#define SCLP_TTY_MINOR		64
+#define SCLP_TTY_DRIVER_NAME	"sclp_line"
+#define SCLP_TTY_DEVICE_NAME	"sclp_line"
+
 /*
  * size of a buffer that collects single characters coming in
  * via sclp_tty_put_char()
@@ -550,10 +555,10 @@ sclp_tty_init(void)
 
 	tty_port_init(&sclp_port);
 
-	driver->driver_name = "sclp_line";
-	driver->name = "sclp_line";
-	driver->major = TTY_MAJOR;
-	driver->minor_start = 64;
+	driver->driver_name = SCLP_TTY_DRIVER_NAME;
+	driver->name = SCLP_TTY_DEVICE_NAME;
+	driver->major = SCLP_TTY_MAJOR;
+	driver->minor_start = SCLP_TTY_MINOR;
 	driver->type = TTY_DRIVER_TYPE_SYSTEM;
 	driver->subtype = SYSTEM_TYPE_TTY;
 	driver->init_termios = tty_std_termios;
Signature · 1 line
2.50.0